Hi Pierre,
In the code section I mentioned below, each attribute of the slot
will need to be looked at to see if should be preserved from the
parent (and an error thrown if an overload attempted), or the new
attribute should apply.
For example, the :allocation and :protection should not be allowed
to change, but I agree that the customization slot should be
overloadable. The customize group, however, should probably remain
constant.
If you would like to try your had at patching EIEIO, that would be
appreciated. Starting with the version in CVS would likely be best.
Once you've made your change, running it through eieio-test.el is
important to make sure nothing is broken. If nothing breaks, then it
is likely a new test will need to be added.
Thanks!
Eric
>>> Pierre Lorenzon <pollock.nageoire@...> seems to think that:
>Hi Eric,
>
>
>
>
>From: "Eric M. Ludlam" <eric@...>
>Subject: Re[1]: [cedet-eieio] Slot characteristic inheritance
>Date: Wed, 6 Jun 2007 12:06:45 -0400
>
>> In eieio.el, I see the following comment:
>>
>> ;; TODO:
>> ;; For other slots (protection, etc) we should get the
>> ;; original value, and make sure each is equal to the
>> ;; last value and throw an error, or accept it.
>
> Ok, I did not see thiscomment since I
> investigated carefully version 0.17 of eieio
> were this comment was not. Then I installed
> vers 1.0 in the hope that something would
> have change : but unfortunately .... So
> what is rellay the scope that must be
> implemented ? If it is only a matter of
> implementation shurely I can do it ! But so
> waht ? Should the child custom match the
> parent custom or is it allowed to completely
> change custom between parent and children ?
> I must confess that I would prefer the
> second solution but I know that I have to
> respect the package developers will !
>
>
>>
>> which seems as though I never got around to implementing this section.
>>
>> If you'd like to take a stab at fixing the part for custom and
>> customgroup, that'd be ideal. There is a good example just before
>> that comment. Otherwise I'll look into sometime soon.
>>
>> Thanks
>> Eric
>
> Regards
>
> Pierre
>
>
>-------------------------------------------------------------------------
>This SF.net email is sponsored by DB2 Express
>Download DB2 Express C - the FREE version of DB2 express and take
>control of your XML. No limits. Just data. Click to get it now.
>http://sourceforge.net/powerbar/db2/
>_______________________________________________
>cedet-eieio mailing list
>cedet-eieio@...
>https://lists.sourceforge.net/lists/listinfo/cedet-eieio
>
--
Eric Ludlam: zappo@..., eric@...
Home: http://www.ludlam.net Siege: http://www.siege-engine.com
Emacs: http://cedet.sourceforge.net GNU: http://www.gnu.org
|