Home / Browse / CEDET / Mail / Archive

CEDET

Email Archive: cedet-devel (read-only)

Re: Re[1]: [CEDET-devel] Problem in semantic-change-function

From: <eric@si...> - 2003-09-16 17:32

My computer is dead.  Would someone mind applying this
patch for me?  (Unless, of course, you can think of a
better way.) Thanks.

Eric

On 16 Sep 2003 12:34:14 -0400, Stuart Popejoy wrote:

> 
> [ ... ]
> 
> > Hmmm.  In our code, it says:
> > 
> >   (let ((changes-in-change
> (semantic-changes-in-region (1- start) (1+ end)))
> > 	)
> > 
> > without much testing to see if END was equal to
EOB. 
> Apparently this
> > is ok in GNU Emacs.  Did this happen editing the end
> of a file?
> > 
> > If so, does a patch like this help?
> > 
> > *** semantic-edit.el.~1.21.~	Tue Aug 26 10:25:43
2003
> > --- semantic-edit.el	Mon Sep 15 22:36:48 2003
> > ***************
> > *** 128,133 ****
> > --- 128,135 ----
> >   Optional argument BUFFER is the buffer to search
> for changes in."
> >     (save-excursion
> >       (if buffer (set-buffer buffer))
> > +     (if (< start 0) (setq start 0))
> > +     (if (> end (point-max)) (setq end
(point-max)))
> >       (let ((ol (semantic-overlays-in start end))
> >   	  (ret nil))
> >         (while ol
> > 
> > 
> 
> The patch works great. Thanks!
> 
> Stuart
> 
> 
> 
> 
>
-------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Cedet-devel mailing list
> Cedet-devel@...
>
https://lists.sourceforge.net/lists/listinfo/cedet-devel

Thread View

Thread	Author	Date
Re: Re[1]: [CEDET-devel] Problem in semantic-change-function	<eric@si...>

Re: [CEDET-devel] Problem in semantic-change-function

From: David Ponce <david.ponce@wa...> - 2003-09-16 18:23

> My computer is dead.  Would someone mind applying this
> patch for me?  (Unless, of course, you can think of a
> better way.) Thanks.

What a pity :-(

Do you agree with this version:

(defun semantic-changes-in-region (start end &optional buffer)
   "Find change overlays which exist in whole or in part between START and END.
Optional argument BUFFER is the buffer to search for changes in."
   (save-excursion
     (if buffer (set-buffer buffer))
     (let ((ol (semantic-overlays-in (max start (point-min))
				    (min end (point-max))))
	  (ret nil))
       (while ol
	(when (semantic-overlay-get (car ol) 'semantic-change)
	  (setq ret (cons (car ol) ret)))
	(setq ol (cdr ol)))
       (sort ret #'(lambda (a b) (< (semantic-overlay-start a)
				   (semantic-overlay-start b)))))))

I used `min' and `max', replaced 0 by `point-min', and removed the unnecessary
`let' inside the `while' loop ;-)

If no objection, I will check the fix.

David