>>> "David PONCE" <David.Ponce@...> seems to think that:
>Hi Eric,
>
>I did the first implementation that uses the common API to manage
>parse tree state :-) Attached you will find a new global patch.
That's great!
>I think Semantic has now a good framework to develop and plug custom
>parsers.
>
>I also removed the dependency between semantic.el and
>semantic-edit.el. The latter is now setup in semantic-load.el with
>appropriate autoloads.
>
>In fact, to install a new parsers it should suffice to put the
>appropriate autoloads in semantic-load.el ;-)
This is great too.
I have some code at work I need to adapt to semantic to auto-generate
the autoload statements. I'll have to look into how it may also add
the code needed to hook up parsers.
>The new version seems to work well. It would be nice if you could
>review and try the new code.
>
>IMO, to complete the work it remains to remove the
>`semantic-bovinate-toplevel-override' stuff, that is adapt
>semantic-texi.el code to use the new parser plug-in API.
[ ... ]
I can do that after you check stuff in. It's probably fine to just
remove it directly, as then texinfo will just revert back to imenu (I
think). Once it is running again, I can restore stuff in
semantic-load.
Here are some patch comments:
--- 437,443 ----
(defsubst semantic-edits-incremental-fail ()
"When the incremental parser fails, we mark that we need a full reparse."
;;(debug)
! (semantic-parse-tree-needs-rebuild)
(message "Force full reparse (%s)" (buffer-name (current-buffer)))
(run-hooks 'semantic-edits-incremental-reparse-failed-hooks)
)
***************
When looking at this in code, I think having `set' in the name would
help, such as `semantic-set-parse-tree-needs-rebuild', or
`semantic-parse-tree-set-needs-rebuild'.
Also, I like having all the garbage collector stuff moved to wrap the
whole contents of `semantic-bovinate-toplevel'.
*** 895,898 ****
;; Semantic-util is a part of the semantic API. Include it last
;; because it depends on semantic.
(require 'semantic-util)
- (require 'semantic-edit)
--- 892,894 ----
Yay!
It looks good! My next semantic task will be to fix the texinfo
regex parser.
Have fun
Eric
--
Eric Ludlam: zappo@..., eric@...
Home: http://www.ultranet.com/~zappo Siege: http://www.siege-engine.com
Emacs: http://cedet.sourceforge.net GNU: http://www.gnu.org
|