BUMP. Could one of the devs who understands more about filters help me
out on this??
On 1 Sep 2013, at 18:14, doug wrote:
> On 29/08/13 19:16, Tim Lyons wrote:
>> I have fixed:
>> 0006849: citationtreeview with search bar only searches in sources,
>> not citation data
>> 0006848: citationtreeview corrupts when search bar open and edit
>> 0006829: Searching into source/citation selector disallows to select
>> all related citations, only matching rows
>> by fixing treebasemodel so it properly deals with secondary objects,
>> and also citationtreemodel so it adds secondary odes even when the
>> parent is not present.
>> The effect now is that in treeviews, the 'Search Bar' (at the top of
>> the main display area) causes the display of any primary or secondary
>> objects that match the criteria. So in Citation Tree View, you get
>> matching sources and citations. If a citation matches, but its source
>> does not, you get the citation as a top level node in the display.
>> same thing works with the 'Select Source or Citation' dialogue.
>> However, when you use the sidebar filters, objects of the 'wrong'
>> are are allowed through. So if you apply a Source filter for
>> 'Title==mysource' to a citation, it behaves as if it matches. This is
>> symmetrical, so if you use a source filter, you get the matching
>> sources and all citations. If you use a citation filter you get
>> matching citations, and all sources.
> Where have these changes been implemented?
> I'm running 3.4.6 svn22976M which displays Source-Citation data
> nicely and allows one to switch from Source View to Citation View on
> the same item without any hassle.
> I only have a tree view present on Sources, not Citations.
Yes, I'm talking about the Gramps34 maintenance branch (among others)
which is now up to svn23001. (22976 is actually a gramps40 revision??)
> I'm not sure how this is supposed to work, so apologies if my
> comments are not relevant. However Source: Citation Tree View has a
> default Filter sidebar that works with Custom filters on the data,
In Citation Tree View, the default Filter sidebar (right click and
select 'Restore default gramplets') is a source filter (you can tell
that because it contains 'Title' which is a source data item). If you
type something into one of the fields (e.g. the Title field), and
press Find, it finds all the sources that contain the text you typed,
but also finds *all* citations, irrespective of whether they are part
of the source you found, or not. I don't think this is what one would
expect, so I count that as a fault, and I am surprised if you say you
think it is working.
You can also create a custom filter with this filter, and you get
offered various 'General Filters' which all relate to source
information, and again, these select the source you wanted plus all
> while the Editor is a Citation Filter Editor allowing Custom
> Citation filters to be created and edited, but not operating on the
> data AFAICT.
I don't understand this. The default editor is a Source Filter editor.
If you right click on the top of the sidebar, you can also bring up a
Citation Filer sidebar. This has 'Volume/Page' in it. If you type
something into that (e.g. type some text into the 'Volume/Page' filed,
then press find, it finds all the citations which contain the text
(each displayed under its associated source) just as I would have
expected, but it also displays *all* sources, even if they don't have
any citation that contains the requested text. I don't think that is
what would be expected, so I count that as being a fault.
> I assumed that adding a Citation filter to the sidebar under 'Add a
> gramplet' would make filtering on citation details available. It
> seems not to be so.
See above I think it does make filtering available to some extent.
What result are you seeing with the Citation filter?