Enlightenment

Log:
Elementary map: Bug Fix.
  1. the range of marker to remove.
  2. after free(marker->groups[i]), reuse the value.
  Patch by Sangho Park <gouache95@...>
  Reviewed by Atton Jonathan.
  

Author:       seoz
Date:         2011-02-09 08:44:47 -0800 (Wed, 09 Feb 2011)
New Revision: 56849
Trac:         http://trac.enlightenment.org/e/changeset/56849

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-02-09 16:43:03 UTC (rev 56848)
+++ trunk/elementary/src/lib/elm_map.c	2011-02-09 16:44:47 UTC (rev 56849)
@@ -2976,41 +2976,42 @@
    EINA_SAFETY_ON_NULL_RETURN(marker);
    wd = marker->wd;
    if (!wd) return;
-   for (i = 0; i <= ZOOM_MAX; i++)
+   for (i = marker->clas_group->zoom_displayed; i <= ZOOM_MAX; i++)
      {
-	marker->groups[i]->markers = eina_list_remove(marker->groups[i]->markers, marker);
-	if (!eina_list_count(marker->groups[i]->markers))
-	  {
+        marker->groups[i]->markers = eina_list_remove(marker->groups[i]->markers, marker);
+        if (!eina_list_count(marker->groups[i]->markers))
+          {
              groups = eina_matrixsparse_cell_data_get(marker->groups[i]->cell);
              groups = eina_list_remove(groups, marker->groups[i]);
              eina_matrixsparse_cell_data_set(marker->groups[i]->cell, groups);
-             
+
              _group_object_free(marker->groups[i]);
              _group_bubble_free(marker->groups[i]);
              free(marker->groups[i]);
-	  }
-	else
-	  {
-	     marker->groups[i]->sum_x -= marker->x[i];
-	     marker->groups[i]->sum_y -= marker->y[i];
-             
-	     marker->groups[i]->x = marker->groups[i]->sum_x / eina_list_count(marker->groups[i]->markers);
-	     marker->groups[i]->y = marker->groups[i]->sum_y / eina_list_count(marker->groups[i]->markers);
-             
-	     marker->groups[i]->w = marker->groups[i]->clas->priv.edje_w
-               + marker->groups[i]->clas->priv.edje_w/8. * eina_list_count(marker->groups[i]->markers);
-	     marker->groups[i]->h = marker->groups[i]->clas->priv.edje_h
-               + marker->groups[i]->clas->priv.edje_h/8. * eina_list_count(marker->groups[i]->markers);
-	     if (marker->groups[i]->w > marker->groups[i]->clas->priv.edje_max_w)
-	       marker->groups[i]->w = marker->groups[i]->clas->priv.edje_max_w;
-	     if (marker->groups[i]->h > marker->groups[i]->clas->priv.edje_max_h)
-	       marker->groups[i]->h = marker->groups[i]->clas->priv.edje_max_h;
-	  }
-	if ((marker->groups[i]->obj) && (eina_list_count(marker->groups[i]->markers) == 1))
-	  {
-	     _group_object_free(marker->groups[i]);
-	     _group_object_create(marker->groups[i]);
-	  }
+          }
+        else
+          {
+             marker->groups[i]->sum_x -= marker->x[i];
+             marker->groups[i]->sum_y -= marker->y[i];
+
+             marker->groups[i]->x = marker->groups[i]->sum_x / eina_list_count(marker->groups[i]->markers);
+             marker->groups[i]->y = marker->groups[i]->sum_y / eina_list_count(marker->groups[i]->markers);
+
+             marker->groups[i]->w = marker->groups[i]->clas->priv.edje_w
+                + marker->groups[i]->clas->priv.edje_w/8. * eina_list_count(marker->groups[i]->markers);
+             marker->groups[i]->h = marker->groups[i]->clas->priv.edje_h
+                + marker->groups[i]->clas->priv.edje_h/8. * eina_list_count(marker->groups[i]->markers);
+             if (marker->groups[i]->w > marker->groups[i]->clas->priv.edje_max_w)
+               marker->groups[i]->w = marker->groups[i]->clas->priv.edje_max_w;
+             if (marker->groups[i]->h > marker->groups[i]->clas->priv.edje_max_h)
+               marker->groups[i]->h = marker->groups[i]->clas->priv.edje_max_h;
+
+             if ((marker->groups[i]->obj) && (eina_list_count(marker->groups[i]->markers) == 1))
+               {
+                  _group_object_free(marker->groups[i]);
+                  _group_object_create(marker->groups[i]);
+               }
+          }
      }
 
    if ((marker->content) && (marker->clas->func.del))

Log:
Elementary genlist: Enabling _show_region_hook to handle the genlist item sub
  objects hierarchical region show. Scroller pan geometry is included, as scrolelr
  is smart object, not in genlist hierarchy.
  Patch By Govindaraju SM <govi.sm@...>
  
  

Author:       seoz
Date:         2011-02-13 02:28:55 -0800 (Sun, 13 Feb 2011)
New Revision: 56981
Trac:         http://trac.enlightenment.org/e/changeset/56981

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-02-13 08:22:06 UTC (rev 56980)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-02-13 10:28:55 UTC (rev 56981)
@@ -447,7 +447,7 @@
 static void      _del_hook(Evas_Object *obj);
 static void _mirrored_set(Evas_Object *obj, Eina_Bool rtl);
 static void      _theme_hook(Evas_Object *obj);
-//static void _show_region_hook(void *data, Evas_Object *obj);
+static void      _show_region_hook(void *data, Evas_Object *obj);
 static void      _sizing_eval(Evas_Object *obj);
 static void      _item_unrealize(Elm_Genlist_Item *it);
 static void      _item_block_unrealize(Item_Block *itb);
@@ -763,17 +763,18 @@
    _sizing_eval(obj);
 }
 
-/*
-   static void
-   _show_region_hook(void *data, Evas_Object *obj)
-   {
+static void
+_show_region_hook(void *data, Evas_Object *obj)
+{
    Widget_Data *wd = elm_widget_data_get(data);
    Evas_Coord x, y, w, h;
    if (!wd) return;
    elm_widget_show_region_get(obj, &x, &y, &w, &h);
+   //x & y are screen coordinates, Add with pan coordinates
+   x += wd->pan_x;
+   y += wd->pan_y;
    elm_smart_scroller_child_region_show(wd->scr, x, y, w, h);
-   }
- */
+}
 
 static void
 _sizing_eval(Evas_Object *obj)
@@ -2616,6 +2617,7 @@
    elm_widget_theme_hook_set(obj, _theme_hook);
    elm_widget_can_focus_set(obj, EINA_TRUE);
    elm_widget_event_hook_set(obj, _event_hook);
+   elm_widget_on_show_region_hook_set(obj, _show_region_hook, obj);
 
    wd->scr = elm_smart_scroller_add(e);
    elm_smart_scroller_widget_set(wd->scr, obj);

Log:
Elementary: Fixed some NULL pointer reference bug in elementary.
  

Author:       seoz
Date:         2011-02-13 05:16:59 -0800 (Sun, 13 Feb 2011)
New Revision: 56985
Trac:         http://trac.enlightenment.org/e/changeset/56985

Modified:
  trunk/elementary/src/lib/elm_diskselector.c trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_diskselector.c
===================================================================
--- trunk/elementary/src/lib/elm_diskselector.c	2011-02-13 13:07:37 UTC (rev 56984)
+++ trunk/elementary/src/lib/elm_diskselector.c	2011-02-13 13:16:59 UTC (rev 56985)
@@ -1078,7 +1078,7 @@
           }
      }
    wd->check_idler = ecore_idler_add(_check_string, wd);
-   _sizing_eval(it->base.widget);
+   _sizing_eval(wd->self);
 }
 
 /**

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-02-13 13:07:37 UTC (rev 56984)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-02-13 13:16:59 UTC (rev 56985)
@@ -2818,9 +2818,9 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return NULL;
    if (!wd->items) return NULL;
    Elm_Gengrid_Item *item = ELM_GENGRID_ITEM_FROM_INLIST(wd->items->last);
-   if (!wd) return NULL;
    while ((item) && (item->delete_me))
      item = ELM_GENGRID_ITEM_FROM_INLIST(EINA_INLIST_GET(item)->prev);
    return item;

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-02-13 13:07:37 UTC (rev 56984)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-02-13 13:16:59 UTC (rev 56985)
@@ -2938,9 +2938,9 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return NULL;
    Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
                                     func_data);
-   if (!wd) return NULL;
    if (!it) return NULL;
    if (!it->parent)
      {
@@ -3000,9 +3000,9 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return NULL;
    Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
                                     func_data);
-   if (!wd) return NULL;
    if (!it) return NULL;
    if (!it->parent)
      {
@@ -3059,9 +3059,9 @@
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    EINA_SAFETY_ON_NULL_RETURN_VAL(before, NULL);
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return NULL;
    Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
                                     func_data);
-   if (!wd) return NULL;
    if (!it) return NULL;
    if (it->parent)
      {
@@ -3107,9 +3107,9 @@
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    EINA_SAFETY_ON_NULL_RETURN_VAL(after, NULL);
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return NULL;
    Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
                                     func_data);
-   if (!wd) return NULL;
    if (!it) return NULL;
    wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
                                            EINA_INLIST_GET(after));

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-02-13 13:07:37 UTC (rev 56984)
+++ trunk/elementary/src/lib/elm_map.c	2011-02-13 13:16:59 UTC (rev 56985)
@@ -1951,7 +1951,8 @@
    edje_object_size_min_calc(group->bubble, NULL, &hh);
 
    s = edje_object_data_get(group->bubble, "size_w");
-   ww = atoi(s);
+   if (s) ww = atoi(s);
+   else ww = 0;
    xx = x + w / 2 - ww / 2;
    yy = y-hh;
 
@@ -2830,13 +2831,17 @@
 	o = edje_object_add(evas_object_evas_get(obj));
 	_elm_theme_object_set(obj, o, "map/marker", style, elm_widget_style_get(obj));
 	s = edje_object_data_get(o, "size_w");
-	clas_group->priv.edje_w = atoi(s);
+	if (s) clas_group->priv.edje_w = atoi(s);
+	else clas_group->priv.edje_w = 0;
 	s = edje_object_data_get(o, "size_h");
-	clas_group->priv.edje_h = atoi(s);
+	if (s) clas_group->priv.edje_h = atoi(s);
+	else clas_group->priv.edje_h = 0;
 	s = edje_object_data_get(o, "size_max_w");
-	clas_group->priv.edje_max_w = atoi(s);
+	if (s) clas_group->priv.edje_max_w = atoi(s);
+	else clas_group->priv.edje_max_w = 0;
 	s = edje_object_data_get(o, "size_max_h");
-	clas_group->priv.edje_max_h = atoi(s);
+	if (s) clas_group->priv.edje_max_h = atoi(s);
+	else clas_group->priv.edje_max_h = 0;
 	evas_object_del(o);
 
 	clas_group->priv.set = EINA_TRUE;
@@ -2851,9 +2856,11 @@
 	o = edje_object_add(evas_object_evas_get(obj));
 	_elm_theme_object_set(obj, o, "map/marker", style, elm_widget_style_get(obj));
 	s = edje_object_data_get(o, "size_w");
-	clas->priv.edje_w = atoi(s);
+	if (s) clas->priv.edje_w = atoi(s);
+	else clas->priv.edje_w = 0;
 	s = edje_object_data_get(o, "size_h");
-	clas->priv.edje_h = atoi(s);
+	if (s) clas->priv.edje_h = atoi(s);
+	else clas->priv.edje_h = 0;
 	evas_object_del(o);
 
 	clas->priv.set = EINA_TRUE;

Log:
Elementayr genlist: Fixed item disabled bug.
  

Author:       seoz
Date:         2011-02-21 08:02:45 -0800 (Mon, 21 Feb 2011)
New Revision: 57217
Trac:         http://trac.enlightenment.org/e/changeset/57217

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-02-21 15:52:24 UTC (rev 57216)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-02-21 16:02:45 UTC (rev 57217)
@@ -834,7 +834,7 @@
 _item_hilight(Elm_Genlist_Item *it)
 {
    const char *selectraise;
-   if ((it->wd->no_select) || (it->delete_me) || (it->hilighted)) return;
+   if ((it->wd->no_select) || (it->delete_me) || (it->hilighted) || (it->disabled)) return;
    edje_object_signal_emit(it->base.view, "elm,state,selected", "elm");
    selectraise = edje_object_data_get(it->base.view, "selectraise");
    if ((selectraise) && (!strcmp(selectraise, "on")))

Log:
Elementary genlist: Fixed item display only bug.
  

Author:       seoz
Date:         2011-02-21 08:08:23 -0800 (Mon, 21 Feb 2011)
New Revision: 57218
Trac:         http://trac.enlightenment.org/e/changeset/57218

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-02-21 16:02:45 UTC (rev 57217)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-02-21 16:08:23 UTC (rev 57218)
@@ -834,7 +834,7 @@
 _item_hilight(Elm_Genlist_Item *it)
 {
    const char *selectraise;
-   if ((it->wd->no_select) || (it->delete_me) || (it->hilighted) || (it->disabled)) return;
+   if ((it->wd->no_select) || (it->delete_me) || (it->hilighted) || (it->disabled) || (it->display_only)) return;
    edje_object_signal_emit(it->base.view, "elm,state,selected", "elm");
    selectraise = edje_object_data_get(it->base.view, "selectraise");
    if ((selectraise) && (!strcmp(selectraise, "on")))
@@ -3751,13 +3751,12 @@
                                   Eina_Bool         display_only)
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
-   if (!it->block) return;
    if (it->display_only == display_only) return;
    if (it->delete_me) return;
    it->display_only = display_only;
    it->mincalcd = EINA_FALSE;
    it->updateme = EINA_TRUE;
-   it->block->updateme = EINA_TRUE;
+   if (it->block) it->block->updateme = EINA_TRUE;
    if (it->wd->update_job) ecore_job_del(it->wd->update_job);
    it->wd->update_job = ecore_job_add(_update_job, it->wd);
 }

Log:
Elementary genlist: Fixed doxygen typo.
  

Author:       seoz
Date:         2011-02-21 08:09:05 -0800 (Mon, 21 Feb 2011)
New Revision: 57219
Trac:         http://trac.enlightenment.org/e/changeset/57219

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-02-21 16:08:23 UTC (rev 57218)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-02-21 16:09:05 UTC (rev 57219)
@@ -3224,7 +3224,7 @@
 /**
  * Enable or disable multi-select in the genlist
  *
- * This enables (EINA_TRUE) or disableds (EINA_FALSE) multi-select in
+ * This enables (EINA_TRUE) or disables (EINA_FALSE) multi-select in
  * the list. This allows more than 1 item to be selected.
  *
  * @param obj The genlist object

Log:
Elementary genlist: Blocked "swipe" and "clicked" events for display only and disabled modes.
  

Author:       seoz
Date:         2011-02-21 08:38:24 -0800 (Mon, 21 Feb 2011)
New Revision: 57222
Trac:         http://trac.enlightenment.org/e/changeset/57222

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-02-21 16:31:32 UTC (rev 57221)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-02-21 16:38:24 UTC (rev 57222)
@@ -1130,6 +1130,7 @@
    int i, sum = 0;
 
    if (!it) return;
+   if ((it->display_only) || (it->disabled)) return;
    it->wd->swipe = EINA_FALSE;
    for (i = 0; i < it->wd->movements; i++)
      {
@@ -1333,7 +1334,8 @@
    it->wd->wasselected = it->selected;
    _item_hilight(it);
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
-     evas_object_smart_callback_call(it->base.widget, "clicked", it);
+      if ((!it->disabled) && (!it->display_only))
+         evas_object_smart_callback_call(it->base.widget, "clicked", it);
    if (it->long_timer) ecore_timer_del(it->long_timer);
    if (it->swipe_timer) ecore_timer_del(it->swipe_timer);
    it->swipe_timer = ecore_timer_add(0.4, _swipe_cancel, it);

Log:
Elementary elm_actionslider.c: Fixed formatting.
  

Author:       seoz
Date:         2011-02-24 11:10:46 -0800 (Thu, 24 Feb 2011)
New Revision: 57307
Trac:         http://trac.enlightenment.org/e/changeset/57307

Modified:
  trunk/elementary/src/lib/elm_actionslider.c 

Modified: trunk/elementary/src/lib/elm_actionslider.c
===================================================================
--- trunk/elementary/src/lib/elm_actionslider.c	2011-02-24 18:45:24 UTC (rev 57306)
+++ trunk/elementary/src/lib/elm_actionslider.c	2011-02-24 19:10:46 UTC (rev 57307)
@@ -37,9 +37,9 @@
 
 static const Evas_Smart_Cb_Description _signals[] =
 {
-   {SIG_CHANGED, ""},
-   {SIG_SELECTED, ""},
-   {NULL, NULL}
+     {SIG_CHANGED, ""},
+     {SIG_SELECTED, ""},
+     {NULL, NULL}
 };
 
 
@@ -88,7 +88,7 @@
 
    if (!wd) return;
    if (edje_object_mirrored_get(wd->as) == rtl)
-     return;
+      return;
 
    edje_object_mirrored_set(wd->as, rtl);
    if (!elm_widget_mirrored_get(obj))
@@ -131,7 +131,7 @@
    if (!wd) return;
    _elm_widget_mirrored_reload(obj);
    if (!edje_object_part_swallow_get(wd->as, "elm.drag_button_base"))
-     edje_object_part_unswallow(wd->as, wd->drag_button_base);
+      edje_object_part_unswallow(wd->as, wd->drag_button_base);
 
    _elm_theme_object_set(obj, wd->as, "actionslider",
                          "base", elm_widget_style_get(obj));
@@ -165,15 +165,15 @@
    if (!wd->mouse_down) return;
    edje_object_part_drag_value_get(wd->as, "elm.drag_button_base", &pos, NULL);
    if (pos == 0.0)
-     evas_object_smart_callback_call(obj, SIG_CHANGED,
-              (void *) ((!elm_widget_mirrored_get(obj)) ?
-                 "left" : "right"));
+      evas_object_smart_callback_call(obj, SIG_CHANGED,
+                                      (void *) ((!elm_widget_mirrored_get(obj)) ?
+                                                "left" : "right"));
    else if (pos == 1.0)
-     evas_object_smart_callback_call(obj, SIG_CHANGED,
-              (void *) ((!elm_widget_mirrored_get(obj)) ?
-                 "right" : "left"));
+      evas_object_smart_callback_call(obj, SIG_CHANGED,
+                                      (void *) ((!elm_widget_mirrored_get(obj)) ?
+                                                "right" : "left"));
    else if (pos >= 0.45 && pos <= 0.55)
-     evas_object_smart_callback_call(obj, SIG_CHANGED, (void *)"center");
+      evas_object_smart_callback_call(obj, SIG_CHANGED, (void *)"center");
 }
 
 static Eina_Bool
@@ -193,7 +193,7 @@
         adjusted_final = (!elm_widget_mirrored_get(obj)) ?
            wd->final_position : 1.0 - wd->final_position;
         if ((adjusted_final == 0.0) ||
-              (adjusted_final == 0.5 && cur_position >= adjusted_final))
+            (adjusted_final == 0.5 && cur_position >= adjusted_final))
           {
              new_position = cur_position - move_amount;
              if (new_position <= adjusted_final)
@@ -203,7 +203,7 @@
                }
           }
         else if ((adjusted_final == 1.0) ||
-              (adjusted_final == 0.5 && cur_position < adjusted_final))
+                 (adjusted_final == 0.5 && cur_position < adjusted_final))
           {
              new_position = cur_position + move_amount;
              if (new_position >= adjusted_final)
@@ -213,23 +213,23 @@
                }
           }
         edje_object_part_drag_value_set(wd->as,
-              "elm.drag_button_base", new_position, 0.5);
+                                        "elm.drag_button_base", new_position, 0.5);
      }
 
    if (flag_finish_animation)
      {
         if ((!wd->final_position) &&
             (wd->enabled_position & ELM_ACTIONSLIDER_LEFT))
-          evas_object_smart_callback_call(data, SIG_SELECTED,
-                                          (void *)wd->text_left);
+           evas_object_smart_callback_call(data, SIG_SELECTED,
+                                           (void *)wd->text_left);
         else if ((wd->final_position == 0.5) &&
                  (wd->enabled_position & ELM_ACTIONSLIDER_CENTER))
-          evas_object_smart_callback_call(data, SIG_SELECTED,
-                                          (void *)wd->text_center);
+           evas_object_smart_callback_call(data, SIG_SELECTED,
+                                           (void *)wd->text_center);
         else if ((wd->final_position == 1) &&
                  (wd->enabled_position & ELM_ACTIONSLIDER_RIGHT))
-          evas_object_smart_callback_call(data, SIG_SELECTED,
-                                          (void *)wd->text_right);
+           evas_object_smart_callback_call(data, SIG_SELECTED,
+                                           (void *)wd->text_right);
         return EINA_FALSE;
      }
    return EINA_TRUE;
@@ -249,12 +249,12 @@
                                    &position, NULL);
 
    if ((wd->enabled_position & ELM_ACTIONSLIDER_LEFT) &&
-         ((!elm_widget_mirrored_get(obj) && position == 0.0) ||
-         (elm_widget_mirrored_get(obj) && position == 1.0)))
+       ((!elm_widget_mirrored_get(obj) && position == 0.0) ||
+        (elm_widget_mirrored_get(obj) && position == 1.0)))
      {
         wd->final_position = 0;
         evas_object_smart_callback_call(data, SIG_SELECTED,
-              (void *) wd->text_left);
+                                        (void *) wd->text_left);
         return;
      }
    if (position >= 0.45 && position <= 0.55 &&
@@ -266,12 +266,12 @@
         return;
      }
    if ((wd->enabled_position & ELM_ACTIONSLIDER_RIGHT) &&
-         ((!elm_widget_mirrored_get(obj) && position == 1.0) ||
-         (elm_widget_mirrored_get(obj) && position == 0.0)))
+       ((!elm_widget_mirrored_get(obj) && position == 1.0) ||
+        (elm_widget_mirrored_get(obj) && position == 0.0)))
      {
         wd->final_position = 1;
         evas_object_smart_callback_call(data, SIG_SELECTED,
-              (void *) wd->text_right);
+                                        (void *) wd->text_right);
         return;
      }
 
@@ -280,46 +280,46 @@
 #define _FINAL_POS_BY_ORIENTATION(x) (x)
 #define _POS_BY_ORIENTATION(x) \
    ((!elm_widget_mirrored_get(obj)) ? \
-     x : 1.0 - x)
+    x : 1.0 - x)
 
    position = _POS_BY_ORIENTATION(position);
 
    if (position < 0.3)
      {
         if (wd->magnet_position & ELM_ACTIONSLIDER_LEFT)
-          wd->final_position = _FINAL_POS_BY_ORIENTATION(0);
+           wd->final_position = _FINAL_POS_BY_ORIENTATION(0);
         else if (wd->magnet_position & ELM_ACTIONSLIDER_CENTER)
-          wd->final_position = 0.5;
+           wd->final_position = 0.5;
         else if (wd->magnet_position & ELM_ACTIONSLIDER_RIGHT)
-          wd->final_position = _FINAL_POS_BY_ORIENTATION(1);
+           wd->final_position = _FINAL_POS_BY_ORIENTATION(1);
      }
    else if ((position >= 0.3) && (position <= 0.7))
      {
         if (wd->magnet_position & ELM_ACTIONSLIDER_CENTER)
-          wd->final_position = 0.5;
+           wd->final_position = 0.5;
         else if (position < 0.5)
           {
              if (wd->magnet_position & ELM_ACTIONSLIDER_LEFT)
-               wd->final_position = _FINAL_POS_BY_ORIENTATION(0);
+                wd->final_position = _FINAL_POS_BY_ORIENTATION(0);
              else
-               wd->final_position = _FINAL_POS_BY_ORIENTATION(1);
+                wd->final_position = _FINAL_POS_BY_ORIENTATION(1);
           }
         else
           {
              if (wd->magnet_position & ELM_ACTIONSLIDER_RIGHT)
-               wd->final_position = _FINAL_POS_BY_ORIENTATION(1);
+                wd->final_position = _FINAL_POS_BY_ORIENTATION(1);
              else
-               wd->final_position = _FINAL_POS_BY_ORIENTATION(0);
+                wd->final_position = _FINAL_POS_BY_ORIENTATION(0);
           }
      }
    else
      {
         if (wd->magnet_position & ELM_ACTIONSLIDER_RIGHT)
-          wd->final_position = _FINAL_POS_BY_ORIENTATION(1);
+           wd->final_position = _FINAL_POS_BY_ORIENTATION(1);
         else if (wd->magnet_position & ELM_ACTIONSLIDER_CENTER)
-          wd->final_position = 0.5;
+           wd->final_position = 0.5;
         else
-          wd->final_position = _FINAL_POS_BY_ORIENTATION(0);
+           wd->final_position = _FINAL_POS_BY_ORIENTATION(0);
      }
    wd->button_animator = ecore_animator_add(_button_animation, data);
 
@@ -420,11 +420,11 @@
 
    edje_object_part_drag_value_get(wd->as, "elm.drag_button_base", &position, NULL);
    if (position < 0.3)
-     return _get_pos_by_orientation(obj, ELM_ACTIONSLIDER_LEFT);
+      return _get_pos_by_orientation(obj, ELM_ACTIONSLIDER_LEFT);
    else if (position < 0.7)
-     return ELM_ACTIONSLIDER_CENTER;
+      return ELM_ACTIONSLIDER_CENTER;
    else
-     return _get_pos_by_orientation(obj, ELM_ACTIONSLIDER_RIGHT);
+      return _get_pos_by_orientation(obj, ELM_ACTIONSLIDER_RIGHT);
 }
 
 /**
@@ -577,15 +577,15 @@
 
    if ((wd->final_position == 0.0) &&
        (wd->enabled_position & ELM_ACTIONSLIDER_LEFT))
-     return wd->text_left;
+      return wd->text_left;
 
    if ((wd->final_position == 0.5) &&
        (wd->enabled_position & ELM_ACTIONSLIDER_CENTER))
-     return wd->text_center;
+      return wd->text_center;
 
    if ((wd->final_position == 1.0) &&
        (wd->enabled_position & ELM_ACTIONSLIDER_RIGHT))
-     return wd->text_right;
+      return wd->text_right;
 
    return NULL;
 }

Log:
Elementary elm_button.c: Fix formatting.
  

Author:       seoz
Date:         2011-02-27 14:59:12 -0800 (Sun, 27 Feb 2011)
New Revision: 57400
Trac:         http://trac.enlightenment.org/e/changeset/57400

Modified:
  trunk/elementary/src/lib/elm_button.c 

Modified: trunk/elementary/src/lib/elm_button.c
===================================================================
--- trunk/elementary/src/lib/elm_button.c	2011-02-27 22:39:51 UTC (rev 57399)
+++ trunk/elementary/src/lib/elm_button.c	2011-02-27 22:59:12 UTC (rev 57400)
@@ -41,10 +41,10 @@
 static const char SIG_REPEATED[] = "repeated";
 static const char SIG_UNPRESSED[] = "unpressed";
 static const Evas_Smart_Cb_Description _signals[] = {
-  {SIG_CLICKED, ""},
-  {SIG_REPEATED, ""},
-  {SIG_UNPRESSED, ""},
-  {NULL, NULL}
+       {SIG_CLICKED, ""},
+       {SIG_REPEATED, ""},
+       {SIG_UNPRESSED, ""},
+       {NULL, NULL}
 };
 
 static Eina_Bool
@@ -59,7 +59,7 @@
    if ((strcmp(ev->keyname, "Return")) &&
        (strcmp(ev->keyname, "KP_Enter")) &&
        (strcmp(ev->keyname, "space")))
-     return EINA_FALSE;
+      return EINA_FALSE;
    _activate(obj);
    ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
    edje_object_signal_emit(wd->btn, "elm,anim,activate", "elm");
@@ -82,13 +82,13 @@
    if (!wd) return;
    if (elm_widget_focus_get(obj))
      {
-	edje_object_signal_emit(wd->btn, "elm,action,focus", "elm");
-	evas_object_focus_set(wd->btn, EINA_TRUE);
+        edje_object_signal_emit(wd->btn, "elm,action,focus", "elm");
+        evas_object_focus_set(wd->btn, EINA_TRUE);
      }
    else
      {
-	edje_object_signal_emit(wd->btn, "elm,action,unfocus", "elm");
-	evas_object_focus_set(wd->btn, EINA_FALSE);
+        edje_object_signal_emit(wd->btn, "elm,action,unfocus", "elm");
+        evas_object_focus_set(wd->btn, EINA_FALSE);
      }
 }
 
@@ -110,25 +110,25 @@
    _mirrored_set(obj, elm_widget_mirrored_get(obj));
    _elm_theme_object_set(obj, wd->btn, "button", "base", elm_widget_style_get(obj));
    if (wd->icon)
-     edje_object_part_swallow(wd->btn, "elm.swallow.content", wd->icon);
+      edje_object_part_swallow(wd->btn, "elm.swallow.content", wd->icon);
    if (wd->label)
-     edje_object_signal_emit(wd->btn, "elm,state,text,visible", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,text,visible", "elm");
    else
-     edje_object_signal_emit(wd->btn, "elm,state,text,hidden", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,text,hidden", "elm");
    if (wd->icon)
-     edje_object_signal_emit(wd->btn, "elm,state,icon,visible", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,icon,visible", "elm");
    else
-     edje_object_signal_emit(wd->btn, "elm,state,icon,hidden", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,icon,hidden", "elm");
    edje_object_part_text_set(wd->btn, "elm.text", wd->label);
    if (elm_object_disabled_get(obj))
-     edje_object_signal_emit(wd->btn, "elm,state,disabled", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,disabled", "elm");
    edje_object_message_signal_process(wd->btn);
    edje_object_scale_set(wd->btn, elm_widget_scale_get(obj) * _elm_config->scale);
    str = edje_object_data_get(wd->btn, "focus_highlight");
    if ((str) && (!strcmp(str, "on")))
-     elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
+      elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
    else
-     elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
+      elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
    _sizing_eval(obj);
 }
 
@@ -138,9 +138,9 @@
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
    if (elm_widget_disabled_get(obj))
-     edje_object_signal_emit(wd->btn, "elm,state,disabled", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,disabled", "elm");
    else
-     edje_object_signal_emit(wd->btn, "elm,state,enabled", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,enabled", "elm");
 }
 
 static void
@@ -197,12 +197,12 @@
    if (!wd) return;
    if (sub == wd->icon)
      {
-	edje_object_signal_emit(wd->btn, "elm,state,icon,hidden", "elm");
-	evas_object_event_callback_del_full(sub, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
-                                       _changed_size_hints, obj);
-	wd->icon = NULL;
-	edje_object_message_signal_process(wd->btn);
-	_sizing_eval(obj);
+        edje_object_signal_emit(wd->btn, "elm,state,icon,hidden", "elm");
+        evas_object_event_callback_del_full(sub, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
+                                            _changed_size_hints, obj);
+        wd->icon = NULL;
+        edje_object_message_signal_process(wd->btn);
+        _sizing_eval(obj);
      }
 }
 
@@ -213,8 +213,8 @@
    if (!wd) return;
    if (wd->timer)
      {
-	ecore_timer_del(wd->timer);
-	wd->timer = NULL;
+        ecore_timer_del(wd->timer);
+        wd->timer = NULL;
      }
    wd->repeating = EINA_FALSE;
    evas_object_smart_callback_call(obj, SIG_CLICKED, NULL);
@@ -241,8 +241,8 @@
    evas_object_smart_callback_call(data, SIG_REPEATED, NULL);
    if (!wd->repeating)
      {
-	wd->timer = NULL;
-	return ECORE_CALLBACK_CANCEL;
+        wd->timer = NULL;
+        return ECORE_CALLBACK_CANCEL;
      }
 
    return ECORE_CALLBACK_RENEW;
@@ -270,10 +270,10 @@
 
    if ((wd->autorepeat) && (!wd->repeating))
      {
-	if (wd->ar_threshold <= 0.0)
-	  _autorepeat_initial_send(data); /* call immediately */
-	else
-	  wd->timer = ecore_timer_add(wd->ar_threshold, _autorepeat_initial_send, data);
+        if (wd->ar_threshold <= 0.0)
+           _autorepeat_initial_send(data); /* call immediately */
+        else
+           wd->timer = ecore_timer_add(wd->ar_threshold, _autorepeat_initial_send, data);
      }
 }
 
@@ -285,8 +285,8 @@
 
    if (wd->timer)
      {
-	ecore_timer_del(wd->timer);
-	wd->timer = NULL;
+        ecore_timer_del(wd->timer);
+        wd->timer = NULL;
      }
    wd->repeating = EINA_FALSE;
    evas_object_smart_callback_call(data, SIG_UNPRESSED, NULL);
@@ -363,9 +363,9 @@
    if (!wd) return;
    eina_stringshare_replace(&wd->label, label);
    if (label)
-     edje_object_signal_emit(wd->btn, "elm,state,text,visible", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,text,visible", "elm");
    else
-     edje_object_signal_emit(wd->btn, "elm,state,text,hidden", "elm");
+      edje_object_signal_emit(wd->btn, "elm,state,text,hidden", "elm");
    edje_object_message_signal_process(wd->btn);
    edje_object_part_text_set(wd->btn, "elm.text", label);
    _sizing_eval(obj);
@@ -403,12 +403,12 @@
    wd->icon = icon;
    if (icon)
      {
-	elm_widget_sub_object_add(obj, icon);
-	evas_object_event_callback_add(icon, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
-				       _changed_size_hints, obj);
-	edje_object_part_swallow(wd->btn, "elm.swallow.content", icon);
-	edje_object_signal_emit(wd->btn, "elm,state,icon,visible", "elm");
-	edje_object_message_signal_process(wd->btn);
+        elm_widget_sub_object_add(obj, icon);
+        evas_object_event_callback_add(icon, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
+                                       _changed_size_hints, obj);
+        edje_object_part_swallow(wd->btn, "elm.swallow.content", icon);
+        edje_object_signal_emit(wd->btn, "elm,state,icon,visible", "elm");
+        edje_object_message_signal_process(wd->btn);
      }
    _sizing_eval(obj);
 }
@@ -513,8 +513,8 @@
    if (wd->ar_threshold == t) return;
    if (wd->timer)
      {
-	ecore_timer_del(wd->timer);
-	wd->timer = NULL;
+        ecore_timer_del(wd->timer);
+        wd->timer = NULL;
      }
    wd->ar_threshold = t;
 }

Log:
Elementary Elementary.h.in: Fixed vim indentation setting.
  

Author:       seoz
Date:         2011-02-28 13:18:21 -0800 (Mon, 28 Feb 2011)
New Revision: 57436
Trac:         http://trac.enlightenment.org/e/changeset/57436

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-02-28 20:15:55 UTC (rev 57435)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-02-28 21:18:21 UTC (rev 57436)
@@ -1,6 +1,6 @@
 /*
  *
- * vim:ts=8:sw=3:sts=3:expandtab:cino=>5n-2f0^-2{2(0W1st0
+ * vim:ts=8:sw=3:sts=3:expandtab:cino=>5n-3f0^-2{2(0W1st0
  */
 #ifndef ELEMENTARY_H
 #define ELEMENTARY_H

Log:
Elementary button: Fixed 'if' statement indentation. Thanks Sebastian.
  

Author:       seoz
Date:         2011-02-28 13:23:59 -0800 (Mon, 28 Feb 2011)
New Revision: 57437
Trac:         http://trac.enlightenment.org/e/changeset/57437

Modified:
  trunk/elementary/src/lib/elm_button.c 

Modified: trunk/elementary/src/lib/elm_button.c
===================================================================
--- trunk/elementary/src/lib/elm_button.c	2011-02-28 21:18:21 UTC (rev 57436)
+++ trunk/elementary/src/lib/elm_button.c	2011-02-28 21:23:59 UTC (rev 57437)
@@ -59,7 +59,7 @@
    if ((strcmp(ev->keyname, "Return")) &&
        (strcmp(ev->keyname, "KP_Enter")) &&
        (strcmp(ev->keyname, "space")))
-      return EINA_FALSE;
+     return EINA_FALSE;
    _activate(obj);
    ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
    edje_object_signal_emit(wd->btn, "elm,anim,activate", "elm");
@@ -110,25 +110,25 @@
    _mirrored_set(obj, elm_widget_mirrored_get(obj));
    _elm_theme_object_set(obj, wd->btn, "button", "base", elm_widget_style_get(obj));
    if (wd->icon)
-      edje_object_part_swallow(wd->btn, "elm.swallow.content", wd->icon);
+     edje_object_part_swallow(wd->btn, "elm.swallow.content", wd->icon);
    if (wd->label)
-      edje_object_signal_emit(wd->btn, "elm,state,text,visible", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,text,visible", "elm");
    else
-      edje_object_signal_emit(wd->btn, "elm,state,text,hidden", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,text,hidden", "elm");
    if (wd->icon)
-      edje_object_signal_emit(wd->btn, "elm,state,icon,visible", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,icon,visible", "elm");
    else
-      edje_object_signal_emit(wd->btn, "elm,state,icon,hidden", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,icon,hidden", "elm");
    edje_object_part_text_set(wd->btn, "elm.text", wd->label);
    if (elm_object_disabled_get(obj))
-      edje_object_signal_emit(wd->btn, "elm,state,disabled", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,disabled", "elm");
    edje_object_message_signal_process(wd->btn);
    edje_object_scale_set(wd->btn, elm_widget_scale_get(obj) * _elm_config->scale);
    str = edje_object_data_get(wd->btn, "focus_highlight");
    if ((str) && (!strcmp(str, "on")))
-      elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
+     elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
    else
-      elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
+     elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
    _sizing_eval(obj);
 }
 
@@ -138,9 +138,9 @@
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
    if (elm_widget_disabled_get(obj))
-      edje_object_signal_emit(wd->btn, "elm,state,disabled", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,disabled", "elm");
    else
-      edje_object_signal_emit(wd->btn, "elm,state,enabled", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,enabled", "elm");
 }
 
 static void
@@ -271,9 +271,9 @@
    if ((wd->autorepeat) && (!wd->repeating))
      {
         if (wd->ar_threshold <= 0.0)
-           _autorepeat_initial_send(data); /* call immediately */
+          _autorepeat_initial_send(data); /* call immediately */
         else
-           wd->timer = ecore_timer_add(wd->ar_threshold, _autorepeat_initial_send, data);
+          wd->timer = ecore_timer_add(wd->ar_threshold, _autorepeat_initial_send, data);
      }
 }
 
@@ -363,9 +363,9 @@
    if (!wd) return;
    eina_stringshare_replace(&wd->label, label);
    if (label)
-      edje_object_signal_emit(wd->btn, "elm,state,text,visible", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,text,visible", "elm");
    else
-      edje_object_signal_emit(wd->btn, "elm,state,text,hidden", "elm");
+     edje_object_signal_emit(wd->btn, "elm,state,text,hidden", "elm");
    edje_object_message_signal_process(wd->btn);
    edje_object_part_text_set(wd->btn, "elm.text", label);
    _sizing_eval(obj);

Log:
Elementary elm_widget.c: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-03-09 23:22:22 -0800 (Wed, 09 Mar 2011)
New Revision: 57655
Trac:         http://trac.enlightenment.org/e/changeset/57655

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-03-10 06:35:33 UTC (rev 57654)
+++ trunk/elementary/src/lib/elm_widget.c	2011-03-10 07:22:22 UTC (rev 57655)
@@ -61,7 +61,7 @@
    const char    *style;
    unsigned int   focus_order;
    Eina_Bool      focus_order_on_calc;
-   
+
    int            child_drag_x_locked;
    int            child_drag_y_locked;
 
@@ -69,7 +69,7 @@
 
    Eina_Bool      drag_x_locked : 1;
    Eina_Bool      drag_y_locked : 1;
-   
+
    Eina_Bool      can_focus : 1;
    Eina_Bool      child_can_focus : 1;
    Eina_Bool      focused : 1;
@@ -181,7 +181,7 @@
 _sub_obj_mouse_down(void *data __UNUSED__, Evas *e __UNUSED__, Evas_Object *obj, void *event_info __UNUSED__)
 {
    Evas_Object *o = obj;
-   do 
+   do
      {
         if (_elm_widget_is(o)) break;
         o = evas_object_smart_parent_get(o);
@@ -307,7 +307,7 @@
 _elm_widget_type_clear(void)
 {
    const char **ptr;
-   
+
    EINA_LIST_FREE(widtypes, ptr)
      {
         eina_stringshare_del(*ptr);
@@ -727,7 +727,7 @@
         if (data)
           {
              if (data == obj) return;
-             evas_object_event_callback_del(sobj, EVAS_CALLBACK_DEL, 
+             evas_object_event_callback_del(sobj, EVAS_CALLBACK_DEL,
                                             _sub_obj_del);
           }
      }
@@ -785,7 +785,7 @@
      }
    else
      sd->subobjs = eina_list_remove(sd->subobjs, sobj);
-   evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_DEL, 
+   evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_DEL,
                                        _sub_obj_del, sd);
    evas_object_smart_callback_call(obj, "sub-object-del", sobj);
 }
@@ -1674,7 +1674,7 @@
 
    do
      {
-        parent_obj = sd->parent_obj; 
+        parent_obj = sd->parent_obj;
         child_obj = sd->obj;
         sd = evas_object_smart_data_get(parent_obj);
 
@@ -1862,7 +1862,7 @@
 elm_widget_style_set(Evas_Object *obj, const char *style)
 {
    API_ENTRY return;
-   
+
    if (eina_stringshare_replace(&sd->style, style))
       elm_widget_theme(obj);
 }
@@ -2521,7 +2521,7 @@
 {
    const Eina_List *l;
    Evas_Object *child, *ret, *best;
-   
+
    API_ENTRY return NULL;
    if (!evas_object_visible_get(obj)) return NULL;
    best = NULL;
@@ -2546,7 +2546,7 @@
    Evas_Object *top;
    Evas_Object *newest = NULL;
    unsigned int newest_focus_order = 0;
-   
+
    INTERNAL_ENTRY;
 
    if (!sd->focused) return;

Log:
Elementary elm_list.c: Check null before use it.
  

Author:       seoz
Date:         2011-03-09 23:30:02 -0800 (Wed, 09 Mar 2011)
New Revision: 57656
Trac:         http://trac.enlightenment.org/e/changeset/57656

Modified:
  trunk/elementary/src/lib/elm_list.c 

Modified: trunk/elementary/src/lib/elm_list.c
===================================================================
--- trunk/elementary/src/lib/elm_list.c	2011-03-10 07:22:22 UTC (rev 57655)
+++ trunk/elementary/src/lib/elm_list.c	2011-03-10 07:30:02 UTC (rev 57656)
@@ -1050,6 +1050,7 @@
 _fix_items(Evas_Object *obj)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return;
    const Eina_List *l;
    Elm_List_Item *it;
    Evas_Coord minw[2] = { 0, 0 }, minh[2] = { 0, 0 };
@@ -1061,7 +1062,6 @@
    const char *it_compress = wd->h_mode ? "h_item_compress" : "item_compress";
    const char *it_compress_odd = wd->h_mode ? "h_item_compress_odd" : "item_compress_odd";
 
-   if (!wd) return;
    if (wd->walking)
      {
         wd->fix_pending = EINA_TRUE;

Log:
Elementary Elementary.h.in: Removed whitespace and tab. Patch by
  Jihoon Kim (jihoon48.kim@...)
  

Author:       seoz
Date:         2011-03-10 00:12:16 -0800 (Thu, 10 Mar 2011)
New Revision: 57657
Trac:         http://trac.enlightenment.org/e/changeset/57657

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-03-10 07:30:02 UTC (rev 57656)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-03-10 08:12:16 UTC (rev 57657)
@@ -484,7 +484,7 @@
         ELM_WIN_KEYBOARD_KEYPAD,
         ELM_WIN_KEYBOARD_J2ME
      } Elm_Win_Keyboard_Mode;
-     
+
    typedef enum _Elm_Illume_Command
      {
         ELM_ILLUME_COMMAND_FOCUS_BACK,
@@ -1389,10 +1389,10 @@
 
    EAPI Evas_Object                 *elm_thumb_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
    EAPI void                         elm_thumb_reload(Evas_Object *obj) EINA_ARG_NONNULL(1);
-   EAPI void	                     elm_thumb_file_set(Evas_Object *obj, const char *file, const char *key) EINA_ARG_NONNULL(1);
-   EAPI void                	     elm_thumb_file_get(const Evas_Object *obj, const char **file, const char **key) EINA_ARG_NONNULL(1);
-   EAPI void	                     elm_thumb_path_get(const Evas_Object *obj, const char **file, const char **key) EINA_ARG_NONNULL(1);
-   EAPI void                	     elm_thumb_animate_set(Evas_Object *obj, Elm_Thumb_Animation_Setting s) EINA_ARG_NONNULL(1);
+   EAPI void                         elm_thumb_file_set(Evas_Object *obj, const char *file, const char *key) EINA_ARG_NONNULL(1);
+   EAPI void                         elm_thumb_file_get(const Evas_Object *obj, const char **file, const char **key) EINA_ARG_NONNULL(1);
+   EAPI void                         elm_thumb_path_get(const Evas_Object *obj, const char **file, const char **key) EINA_ARG_NONNULL(1);
+   EAPI void                         elm_thumb_animate_set(Evas_Object *obj, Elm_Thumb_Animation_Setting s) EINA_ARG_NONNULL(1);
    EAPI Elm_Thumb_Animation_Setting  elm_thumb_animate_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void                        *elm_thumb_ethumb_client_get(void);
    EAPI Eina_Bool                    elm_thumb_ethumb_client_connected(void);
@@ -2469,11 +2469,11 @@
      } Elm_Ctxpopup_Direction;
 
    EAPI Evas_Object  *elm_ctxpopup_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
-   EAPI Evas_Object  *elm_ctxpopup_item_icon_get(const Elm_Ctxpopup_Item *item) EINA_ARG_NONNULL(1); 
+   EAPI Evas_Object  *elm_ctxpopup_item_icon_get(const Elm_Ctxpopup_Item *item) EINA_ARG_NONNULL(1);
    EAPI void          elm_ctxpopup_item_icon_set(Elm_Ctxpopup_Item *item, Evas_Object *icon) EINA_ARG_NONNULL(1);
-   EAPI const char   *elm_ctxpopup_item_label_get(const Elm_Ctxpopup_Item *item) EINA_ARG_NONNULL(1);	
+   EAPI const char   *elm_ctxpopup_item_label_get(const Elm_Ctxpopup_Item *item) EINA_ARG_NONNULL(1);
    EAPI void          elm_ctxpopup_item_label_set(Elm_Ctxpopup_Item *item, const char *label) EINA_ARG_NONNULL(1);
-   EAPI void          elm_ctxpopup_hover_parent_set(Evas_Object *obj, Evas_Object *parent) EINA_ARG_NONNULL(1, 2); 
+   EAPI void          elm_ctxpopup_hover_parent_set(Evas_Object *obj, Evas_Object *parent) EINA_ARG_NONNULL(1, 2);
    EAPI Evas_Object  *elm_ctxpopup_hover_parent_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void          elm_ctxpopup_clear(Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void          elm_ctxpopup_horizontal_set(Evas_Object *obj, Eina_Bool horizontal) EINA_ARG_NONNULL(1);
@@ -2482,10 +2482,10 @@
    EAPI void          elm_ctxpopup_item_del(Elm_Ctxpopup_Item *item) EINA_ARG_NONNULL(1);
    EAPI void          elm_ctxpopup_item_disabled_set(Elm_Ctxpopup_Item *item, Eina_Bool disabled) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool     elm_ctxpopup_item_disabled_get(const Elm_Ctxpopup_Item *item) EINA_ARG_NONNULL(1);
-   EAPI void	      elm_ctxpopup_content_set(Evas_Object *obj, Evas_Object *content) EINA_ARG_NONNULL(1, 2);
+   EAPI void          elm_ctxpopup_content_set(Evas_Object *obj, Evas_Object *content) EINA_ARG_NONNULL(1, 2);
    EAPI Evas_Object  *elm_ctxpopup_content_unset(Evas_Object *obj) EINA_ARG_NONNULL(1);
-   EAPI void  	      elm_ctxpopup_direction_priority_set(Evas_Object *obj, Elm_Ctxpopup_Direction first, Elm_Ctxpopup_Direction second, Elm_Ctxpopup_Direction third, Elm_Ctxpopup_Direction fourth) EINA_ARG_NONNULL(1);
-   EAPI void  	      elm_ctxpopup_direction_priority_get(Evas_Object *obj, Elm_Ctxpopup_Direction *first, Elm_Ctxpopup_Direction *second, Elm_Ctxpopup_Direction *third, Elm_Ctxpopup_Direction *fourth) EINA_ARG_NONNULL(1);
+   EAPI void          elm_ctxpopup_direction_priority_set(Evas_Object *obj, Elm_Ctxpopup_Direction first, Elm_Ctxpopup_Direction second, Elm_Ctxpopup_Direction third, Elm_Ctxpopup_Direction fourth) EINA_ARG_NONNULL(1);
+   EAPI void          elm_ctxpopup_direction_priority_get(Evas_Object *obj, Elm_Ctxpopup_Direction *first, Elm_Ctxpopup_Direction *second, Elm_Ctxpopup_Direction *third, Elm_Ctxpopup_Direction *fourth) EINA_ARG_NONNULL(1);
    /* smart callbacks called:
     * "dismissed" - the ctxpopup was dismissed
     */
@@ -2538,7 +2538,7 @@
    EAPI int                    elm_transit_repeat_times_get(Elm_Transit *transit) EINA_ARG_NONNULL(1);
    EAPI void                   elm_transit_tween_mode_set(Elm_Transit *transit, Elm_Transit_Tween_Mode tween_mode) EINA_ARG_NONNULL(1);
    EAPI Elm_Transit_Tween_Mode elm_transit_tween_mode_get(const Elm_Transit *transit) EINA_ARG_NONNULL(1) EINA_ARG_NONNULL(1);
-   EAPI void                   elm_transit_duration_set(Elm_Transit *transit, double duration) EINA_ARG_NONNULL(1); 
+   EAPI void                   elm_transit_duration_set(Elm_Transit *transit, double duration) EINA_ARG_NONNULL(1);
    EAPI double                 elm_transit_duration_get(const Elm_Transit *transit) EINA_ARG_NONNULL(1);
    EAPI void                   elm_transit_go(Elm_Transit *transit) EINA_ARG_NONNULL(1);
    EAPI void                   elm_transit_paused_set(Elm_Transit *transit, Eina_Bool paused) EINA_ARG_NONNULL(1);
@@ -2555,7 +2555,7 @@
    EAPI void                  *elm_transit_effect_fade_add(Elm_Transit *transit);
    EAPI void                  *elm_transit_effect_blend_add(Elm_Transit *transit);
    EAPI void                  *elm_transit_effect_rotation_add(Elm_Transit *transit, float from_degree, float to_degree);
-   EAPI void                  *elm_transit_effect_image_animation_add(Elm_Transit *transit, Eina_List *images);       
+   EAPI void                  *elm_transit_effect_image_animation_add(Elm_Transit *transit, Eina_List *images);
 
   typedef struct _Elm_Store                      Elm_Store;
   typedef struct _Elm_Store_Filesystem           Elm_Store_Filesystem;

Log:
Elementary elm_genlist.c: Fixed typo. (hilight -> highlight)
  

Author:       seoz
Date:         2011-03-10 11:59:10 -0800 (Thu, 10 Mar 2011)
New Revision: 57679
Trac:         http://trac.enlightenment.org/e/changeset/57679

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-03-10 17:27:55 UTC (rev 57678)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-03-10 19:59:10 UTC (rev 57679)
@@ -402,7 +402,7 @@
    Eina_Bool   want_realize : 1;
    Eina_Bool   realized : 1;
    Eina_Bool   selected : 1;
-   Eina_Bool   hilighted : 1;
+   Eina_Bool   highlighted : 1;
    Eina_Bool   expanded : 1;
    Eina_Bool   disabled : 1;
    Eina_Bool   display_only : 1;
@@ -831,10 +831,10 @@
 }
 
 static void
-_item_hilight(Elm_Genlist_Item *it)
+_item_highlight(Elm_Genlist_Item *it)
 {
    const char *selectraise;
-   if ((it->wd->no_select) || (it->delete_me) || (it->hilighted) || (it->disabled) || (it->display_only)) return;
+   if ((it->wd->no_select) || (it->delete_me) || (it->highlighted) || (it->disabled) || (it->display_only)) return;
    edje_object_signal_emit(it->base.view, "elm,state,selected", "elm");
    selectraise = edje_object_data_get(it->base.view, "selectraise");
    if ((selectraise) && (!strcmp(selectraise, "on")))
@@ -843,7 +843,7 @@
         if ((it->group_item) && (it->group_item->realized))
            evas_object_raise(it->group_item->base.view);
      }
-   it->hilighted = EINA_TRUE;
+   it->highlighted = EINA_TRUE;
 }
 
 static void
@@ -982,7 +982,7 @@
 {
    const char *stacking, *selectraise;
 
-   if ((it->delete_me) || (!it->hilighted)) return;
+   if ((it->delete_me) || (!it->highlighted)) return;
    edje_object_signal_emit(it->base.view, "elm,state,unselected", "elm");
    stacking = edje_object_data_get(it->base.view, "stacking");
    selectraise = edje_object_data_get(it->base.view, "selectraise");
@@ -991,7 +991,7 @@
         if ((stacking) && (!strcmp(stacking, "below")))
           evas_object_lower(it->base.view);
      }
-   it->hilighted = EINA_FALSE;
+   it->highlighted = EINA_FALSE;
    if (it->selected)
      {
         it->selected = EINA_FALSE;
@@ -1332,7 +1332,7 @@
    else it->wd->on_hold = EINA_FALSE;
    if (it->wd->on_hold) return;
    it->wd->wasselected = it->selected;
-   _item_hilight(it);
+   _item_highlight(it);
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
       if ((!it->disabled) && (!it->display_only))
          evas_object_smart_callback_call(it->base.widget, "clicked", it);
@@ -1421,7 +1421,7 @@
      {
         if (!it->selected)
           {
-             _item_hilight(it);
+             _item_highlight(it);
              _item_select(it);
           }
         else _item_unselect(it);
@@ -1443,10 +1443,10 @@
 
              EINA_LIST_FOREACH_SAFE(it->wd->selected, l, l_next, it2)
                if (it2 != it) _item_unselect(it2);
-             //_item_hilight(it);
+             //_item_highlight(it);
              //_item_select(it);
           }
-        _item_hilight(it);
+        _item_highlight(it);
         _item_select(it);
      }
 }
@@ -3600,7 +3600,7 @@
              while (wd->selected)
                _item_unselect(wd->selected->data);
           }
-        _item_hilight(it);
+        _item_highlight(it);
         _item_select(it);
      }
    else

Log:
Elementary elm_button.c: Fixed unnecessary spaces.f
  

Author:       seoz
Date:         2011-03-10 18:27:12 -0800 (Thu, 10 Mar 2011)
New Revision: 57682
Trac:         http://trac.enlightenment.org/e/changeset/57682

Modified:
  trunk/elementary/src/lib/elm_button.c 

Modified: trunk/elementary/src/lib/elm_button.c
===================================================================
--- trunk/elementary/src/lib/elm_button.c	2011-03-10 20:58:55 UTC (rev 57681)
+++ trunk/elementary/src/lib/elm_button.c	2011-03-11 02:27:12 UTC (rev 57682)
@@ -315,7 +315,7 @@
    ELM_SET_WIDTYPE(widtype, "button");
    elm_widget_type_set(obj, "button");
    elm_widget_sub_object_add(parent, obj);
-   elm_widget_on_focus_hook_set( obj, _on_focus_hook, NULL );
+   elm_widget_on_focus_hook_set(obj, _on_focus_hook, NULL);
    elm_widget_data_set(obj, wd);
    elm_widget_del_hook_set(obj, _del_hook);
    elm_widget_theme_hook_set(obj, _theme_hook);

Log:
Elementary: Fixed indentation and white spaces. Patch by Jihoon Kim
  (jihoon48.kim@...)
  

Author:       seoz
Date:         2011-03-14 19:01:42 -0700 (Mon, 14 Mar 2011)
New Revision: 57759
Trac:         http://trac.enlightenment.org/e/changeset/57759

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_entry.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-03-15 00:23:43 UTC (rev 57758)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-03-15 02:01:42 UTC (rev 57759)
@@ -175,10 +175,10 @@
     */
    typedef enum _Elm_Policy
      {
-       ELM_POLICY_QUIT, /**< when should quit application automatically.
-                         * @see Elm_Policy_Quit.
-                         */
-       ELM_POLICY_LAST
+        ELM_POLICY_QUIT, /**< when should quit application automatically.
+                          * @see Elm_Policy_Quit.
+                          */
+        ELM_POLICY_LAST
      } Elm_Policy;
 
    typedef enum _Elm_Policy_Quit
@@ -467,7 +467,7 @@
 
    typedef enum _Elm_Win_Keyboard_Mode
      {
-	ELM_WIN_KEYBOARD_UNKNOWN,
+        ELM_WIN_KEYBOARD_UNKNOWN,
         ELM_WIN_KEYBOARD_OFF,
         ELM_WIN_KEYBOARD_ON,
         ELM_WIN_KEYBOARD_ALPHA,
@@ -881,7 +881,7 @@
    EAPI Evas_Object *elm_table_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_homogenous_set(Evas_Object *obj, Eina_Bool homogenous) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool    elm_table_homogeneous_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
-   EAPI void	     elm_table_padding_set(Evas_Object *obj, Evas_Coord horizontal, Evas_Coord vertical) EINA_ARG_NONNULL(1);
+   EAPI void         elm_table_padding_set(Evas_Object *obj, Evas_Coord horizontal, Evas_Coord vertical) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_padding_get(const Evas_Object *obj, Evas_Coord *horizontal, Evas_Coord *vertical) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_pack(Evas_Object *obj, Evas_Object *subobj, int x, int y, int w, int h) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_unpack(Evas_Object *obj, Evas_Object *subobj) EINA_ARG_NONNULL(1);
@@ -898,13 +898,14 @@
 
    struct _Elm_Gengrid_Item_Class
      {
-	const char             *item_style;
-	struct _Elm_Gengrid_Item_Class_Func {
-          GridItemLabelGetFunc  label_get;
-          GridItemIconGetFunc   icon_get;
-          GridItemStateGetFunc  state_get;
-          GridItemDelFunc       del;
-        } func;
+        const char             *item_style;
+        struct _Elm_Gengrid_Item_Class_Func
+          {
+             GridItemLabelGetFunc  label_get;
+             GridItemIconGetFunc   icon_get;
+             GridItemStateGetFunc  state_get;
+             GridItemDelFunc       del;
+          } func;
      };
 
    EAPI Evas_Object       *elm_gengrid_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
@@ -957,7 +958,7 @@
    EAPI void               elm_gengrid_item_cursor_engine_only_set(Elm_Gengrid_Item *item, Eina_Bool engine_only) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool          elm_gengrid_item_cursor_engine_only_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
 
-   EAPI void	           elm_gengrid_clear(Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void               elm_gengrid_clear(Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI Elm_Gengrid_Item  *elm_gengrid_selected_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI const Eina_List   *elm_gengrid_selected_items_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
 
@@ -995,7 +996,7 @@
         ELM_CLOCK_MIN_UNIT     = 1 << 3,
         ELM_CLOCK_SEC_DECIMAL  = 1 << 4,
         ELM_CLOCK_SEC_UNIT     = 1 << 5,
-        ELM_CLOCK_ALL	       = (1 << 6) - 1
+        ELM_CLOCK_ALL          = (1 << 6) - 1
      } Elm_Clock_Digedit;
 
    EAPI Evas_Object      *elm_clock_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
@@ -1003,14 +1004,14 @@
    EAPI void              elm_clock_time_get(const Evas_Object *obj, int *hrs, int *min, int *sec) EINA_ARG_NONNULL(1);
    EAPI void              elm_clock_edit_set(Evas_Object *obj, Eina_Bool edit) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool         elm_clock_edit_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
-   EAPI void	          elm_clock_digit_edit_set(Evas_Object *obj, Elm_Clock_Digedit digedit) EINA_ARG_NONNULL(1);
+   EAPI void              elm_clock_digit_edit_set(Evas_Object *obj, Elm_Clock_Digedit digedit) EINA_ARG_NONNULL(1);
    EAPI Elm_Clock_Digedit elm_clock_digit_edit_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void              elm_clock_show_am_pm_set(Evas_Object *obj, Eina_Bool am_pm) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool         elm_clock_show_am_pm_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void              elm_clock_show_seconds_set(Evas_Object *obj, Eina_Bool seconds) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool         elm_clock_show_seconds_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void              elm_clock_interval_set(Evas_Object *obj, double interval) EINA_ARG_NONNULL(1);
-   EAPI double	          elm_clock_interval_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI double            elm_clock_interval_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /* smart callbacks called:
     * "changed" - the user changed the time
     */
@@ -1182,9 +1183,9 @@
    typedef struct _Elm_Entry_Anchor_Info Elm_Entry_Anchor_Info;
    struct _Elm_Entry_Anchor_Info
      {
-	const char *name;
-	int         button;
-	Evas_Coord  x, y, w, h;
+        const char *name;
+        int         button;
+        Evas_Coord  x, y, w, h;
      };
    typedef enum _Elm_Icon_Type
      {
@@ -1290,16 +1291,16 @@
    typedef struct _Elm_Entry_Anchorview_Info Elm_Entry_Anchorview_Info;
    struct _Elm_Entry_Anchorview_Info
      {
-	const char     *name;
-	int             button;
-	Evas_Object    *hover;
+        const char     *name;
+        int             button;
+        Evas_Object    *hover;
         struct {
-          Evas_Coord    x, y, w, h;
+             Evas_Coord    x, y, w, h;
         } anchor, hover_parent;
-	Eina_Bool       hover_left : 1;
-	Eina_Bool       hover_right : 1;
-	Eina_Bool       hover_top : 1;
-	Eina_Bool       hover_bottom : 1;
+        Eina_Bool       hover_left : 1;
+        Eina_Bool       hover_right : 1;
+        Eina_Bool       hover_top : 1;
+        Eina_Bool       hover_bottom : 1;
      };
    EAPI Evas_Object *elm_anchorview_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
    EAPI void         elm_anchorview_text_set(Evas_Object *obj, const char *text) EINA_ARG_NONNULL(1);
@@ -1323,16 +1324,16 @@
    typedef struct _Elm_Entry_Anchorblock_Info Elm_Entry_Anchorblock_Info;
    struct _Elm_Entry_Anchorblock_Info
      {
-	const char     *name;
-	int             button;
-	Evas_Object    *hover;
-	struct {
-          Evas_Coord    x, y, w, h;
+        const char     *name;
+        int             button;
+        Evas_Object    *hover;
+        struct {
+             Evas_Coord    x, y, w, h;
         } anchor, hover_parent;
-	Eina_Bool       hover_left : 1;
-	Eina_Bool       hover_right : 1;
-	Eina_Bool       hover_top : 1;
-	Eina_Bool       hover_bottom : 1;
+        Eina_Bool       hover_left : 1;
+        Eina_Bool       hover_right : 1;
+        Eina_Bool       hover_top : 1;
+        Eina_Bool       hover_bottom : 1;
      };
    EAPI Evas_Object *elm_anchorblock_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
    EAPI void         elm_anchorblock_text_set(Evas_Object *obj, const char *text) EINA_ARG_NONNULL(1);
@@ -1597,7 +1598,7 @@
    EAPI void             elm_list_horizontal_set(Evas_Object *obj, Eina_Bool horizontal) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool        elm_list_horizontal_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void             elm_list_always_select_mode_set(Evas_Object *obj, Eina_Bool always_select) EINA_ARG_NONNULL(1);
-   EAPI Eina_Bool	 elm_list_always_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool        elm_list_always_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI const Eina_List *elm_list_items_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI Elm_List_Item   *elm_list_selected_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI const Eina_List *elm_list_selected_items_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
@@ -1722,13 +1723,14 @@
 
    struct _Elm_Genlist_Item_Class
      {
-	const char                *item_style;
-	struct {
-          GenlistItemLabelGetFunc  label_get;
-          GenlistItemIconGetFunc   icon_get;
-          GenlistItemStateGetFunc  state_get;
-          GenlistItemDelFunc       del;
-        } func;
+        const char                *item_style;
+        struct
+          {
+             GenlistItemLabelGetFunc  label_get;
+             GenlistItemIconGetFunc   icon_get;
+             GenlistItemStateGetFunc  state_get;
+             GenlistItemDelFunc       del;
+          } func;
      };
 
    EAPI Evas_Object      *elm_genlist_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
@@ -1861,10 +1863,11 @@
 
    struct _Elm_Slideshow_Item_Class
      {
-	struct _Elm_Slideshow_Item_Class_Func {
-          SlideshowItemGetFunc get;
-          SlideshowItemDelFunc del;
-	} func;
+        struct _Elm_Slideshow_Item_Class_Func
+          {
+             SlideshowItemGetFunc get;
+             SlideshowItemDelFunc del;
+          } func;
      };
 
    EAPI Evas_Object        *elm_slideshow_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
@@ -2101,7 +2104,7 @@
    EAPI void                  elm_map_paused_markers_set(Evas_Object *obj, Eina_Bool paused) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool             elm_map_paused_markers_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void                  elm_map_utils_downloading_status_get(const Evas_Object *obj, int *try_num, int *finish_num) EINA_ARG_NONNULL(1, 2, 3);
-   EAPI void	              elm_map_utils_convert_coord_into_geo(const Evas_Object *obj, int x, int y, int size, double *lon, double *lat);
+   EAPI void                  elm_map_utils_convert_coord_into_geo(const Evas_Object *obj, int x, int y, int size, double *lon, double *lat);
    EAPI void                  elm_map_utils_convert_geo_into_coord(const Evas_Object *obj, double lon, double lat, int size, int *x, int *y);
    EAPI Elm_Map_Marker       *elm_map_marker_add(Evas_Object *obj, double lon, double lat, Elm_Map_Marker_Class *clas, Elm_Map_Group_Class *clas_group, void *data) EINA_ARG_NONNULL(1, 4, 5);
    EAPI void                  elm_map_max_marker_per_group_set(Evas_Object *obj, int max) EINA_ARG_NONNULL(1);
@@ -2420,7 +2423,7 @@
    EAPI void                   elm_diskselector_clear(Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI const Eina_List       *elm_diskselector_items_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI Elm_Diskselector_Item *elm_diskselector_item_append(Evas_Object *obj, const char *label, Evas_Object *icon, Evas_Smart_Cb func, const void *data) EINA_ARG_NONNULL(1);
-   EAPI void	               elm_diskselector_item_del(Elm_Diskselector_Item *item) EINA_ARG_NONNULL(1);
+   EAPI void                   elm_diskselector_item_del(Elm_Diskselector_Item *item) EINA_ARG_NONNULL(1);
    EAPI void                   elm_diskselector_item_del_cb_set(Elm_Diskselector_Item *item, Evas_Smart_Cb func) EINA_ARG_NONNULL(1);
    EAPI void                  *elm_diskselector_item_data_get(const Elm_Diskselector_Item *item) EINA_ARG_NONNULL(1);
    EAPI Evas_Object           *elm_diskselector_item_icon_get(const Elm_Diskselector_Item *item) EINA_ARG_NONNULL(1);
@@ -2577,55 +2580,56 @@
 
   typedef enum
     {
-      ELM_STORE_ITEM_MAPPING_NONE = 0,
-      ELM_STORE_ITEM_MAPPING_LABEL, // const char * -> label
-      ELM_STORE_ITEM_MAPPING_STATE, // Eina_Bool -> state
-      ELM_STORE_ITEM_MAPPING_ICON, // char * -> icon path
-      ELM_STORE_ITEM_MAPPING_PHOTO, // char * -> photo path
-      ELM_STORE_ITEM_MAPPING_CUSTOM, // item->custom(it->data, it, part) -> void * (-> any)
-      // can add more here as needed by common apps
-      ELM_STORE_ITEM_MAPPING_LAST
+       ELM_STORE_ITEM_MAPPING_NONE = 0,
+       ELM_STORE_ITEM_MAPPING_LABEL, // const char * -> label
+       ELM_STORE_ITEM_MAPPING_STATE, // Eina_Bool -> state
+       ELM_STORE_ITEM_MAPPING_ICON, // char * -> icon path
+       ELM_STORE_ITEM_MAPPING_PHOTO, // char * -> photo path
+       ELM_STORE_ITEM_MAPPING_CUSTOM, // item->custom(it->data, it, part) -> void * (-> any)
+       // can add more here as needed by common apps
+       ELM_STORE_ITEM_MAPPING_LAST
     } Elm_Store_Item_Mapping_Type;
 
   struct _Elm_Store_Item_Mapping_Icon
     {
-      // FIXME: allow edje file icons
-      int                   w, h;
-      Elm_Icon_Lookup_Order lookup_order;
-      Eina_Bool             standard_name : 1;
-      Eina_Bool             no_scale : 1;
-      Eina_Bool             smooth : 1;
-      Eina_Bool             scale_up : 1;
-      Eina_Bool             scale_down : 1;
+       // FIXME: allow edje file icons
+       int                   w, h;
+       Elm_Icon_Lookup_Order lookup_order;
+       Eina_Bool             standard_name : 1;
+       Eina_Bool             no_scale : 1;
+       Eina_Bool             smooth : 1;
+       Eina_Bool             scale_up : 1;
+       Eina_Bool             scale_down : 1;
     };
 
   struct _Elm_Store_Item_Mapping_Empty
     {
-      Eina_Bool             dummy;
+       Eina_Bool             dummy;
     };
 
   struct _Elm_Store_Item_Mapping_Photo
     {
-      int                   size;
+       int                   size;
     };
 
   struct _Elm_Store_Item_Mapping_Custom
     {
-      Elm_Store_Item_Mapping_Cb func;
+       Elm_Store_Item_Mapping_Cb func;
     };
 
   struct _Elm_Store_Item_Mapping
     {
-      Elm_Store_Item_Mapping_Type     type;
-      const char                     *part;
-      int                             offset;
-      union {
-        Elm_Store_Item_Mapping_Empty  empty;
-        Elm_Store_Item_Mapping_Icon   icon;
-        Elm_Store_Item_Mapping_Photo  photo;
-        Elm_Store_Item_Mapping_Custom custom;
-        // add more types here
-      } details;
+       Elm_Store_Item_Mapping_Type     type;
+       const char                     *part;
+       int                             offset;
+       union
+         {
+            Elm_Store_Item_Mapping_Empty  empty;
+            Elm_Store_Item_Mapping_Icon   icon;
+            Elm_Store_Item_Mapping_Photo  photo;
+            Elm_Store_Item_Mapping_Custom custom;
+            // add more types here
+         } details;
     };
 
   struct _Elm_Store_Item_Info

Modified: trunk/elementary/src/lib/elm_entry.c
===================================================================
--- trunk/elementary/src/lib/elm_entry.c	2011-03-15 00:23:43 UTC (rev 57758)
+++ trunk/elementary/src/lib/elm_entry.c	2011-03-15 02:01:42 UTC (rev 57759)
@@ -375,13 +375,13 @@
    switch (wd->format)
      {
       case ELM_TEXT_FORMAT_PLAIN_UTF8:
-	_save_plain_utf8(wd->file, elm_entry_entry_get(obj));
-	break;
+         _save_plain_utf8(wd->file, elm_entry_entry_get(obj));
+         break;
       case ELM_TEXT_FORMAT_MARKUP_UTF8:
-	_save_markup_utf8(wd->file, elm_entry_entry_get(obj));
-	break;
+         _save_markup_utf8(wd->file, elm_entry_entry_get(obj));
+         break;
       default:
-	break;
+         break;
      }
 }
 
@@ -400,7 +400,7 @@
 {
    Elm_Entry_Text_Filter *tf = ELM_NEW(Elm_Entry_Text_Filter);
    if (!tf) return NULL;
-   
+
    tf->func = func;
    if (func == elm_entry_filter_limit_size)
      {
@@ -423,7 +423,7 @@
    else if (func == elm_entry_filter_accept_set)
      {
         Elm_Entry_Filter_Accept_Set *as = data, *as2;
-        
+
         if (!data)
           {
              free(tf);
@@ -557,13 +557,13 @@
 
    if (elm_widget_disabled_get(obj))
      {
-	edje_object_signal_emit(wd->ent, "elm,state,disabled", "elm");
-	wd->disabled = EINA_TRUE;
+        edje_object_signal_emit(wd->ent, "elm,state,disabled", "elm");
+        wd->disabled = EINA_TRUE;
      }
    else
      {
-	edje_object_signal_emit(wd->ent, "elm,state,enabled", "elm");
-	wd->disabled = EINA_FALSE;
+        edje_object_signal_emit(wd->ent, "elm,state,enabled", "elm");
+        wd->disabled = EINA_FALSE;
      }
 }
 
@@ -598,21 +598,21 @@
    if (!wd) return;
    if ((wd->linewrap) || (wd->char_linewrap))
      {
-	evas_object_geometry_get(wd->ent, NULL, NULL, &resw, &resh);
-	if ((resw == wd->lastw) && (!wd->changed)) return;
-	wd->changed = EINA_FALSE;
-	wd->lastw = resw;
-	if (wd->deferred_recalc_job) ecore_job_del(wd->deferred_recalc_job);
-	wd->deferred_recalc_job = ecore_job_add(_elm_win_recalc_job, obj);
+        evas_object_geometry_get(wd->ent, NULL, NULL, &resw, &resh);
+        if ((resw == wd->lastw) && (!wd->changed)) return;
+        wd->changed = EINA_FALSE;
+        wd->lastw = resw;
+        if (wd->deferred_recalc_job) ecore_job_del(wd->deferred_recalc_job);
+        wd->deferred_recalc_job = ecore_job_add(_elm_win_recalc_job, obj);
      }
    else
      {
-	evas_object_geometry_get(wd->ent, NULL, NULL, &resw, &resh);
-	edje_object_size_min_calc(wd->ent, &minw, &minh);
+        evas_object_geometry_get(wd->ent, NULL, NULL, &resw, &resh);
+        edje_object_size_min_calc(wd->ent, &minw, &minh);
         elm_coords_finger_size_adjust(1, &minw, 1, &minh);
-	evas_object_size_hint_min_set(obj, minw, minh);
+        evas_object_size_hint_min_set(obj, minw, minh);
         if (wd->single_line) maxh = minh;
-	evas_object_size_hint_max_set(obj, maxw, maxh);
+        evas_object_size_hint_max_set(obj, maxw, maxh);
      }
 }
 
@@ -625,17 +625,17 @@
    if (!wd->editable) return;
    if (elm_widget_focus_get(obj))
      {
-	evas_object_focus_set(wd->ent, EINA_TRUE);
-	edje_object_signal_emit(wd->ent, "elm,action,focus", "elm");
-	if (top) elm_win_keyboard_mode_set(top, ELM_WIN_KEYBOARD_ON);
-	evas_object_smart_callback_call(obj, SIG_FOCUSED, NULL);
+        evas_object_focus_set(wd->ent, EINA_TRUE);
+        edje_object_signal_emit(wd->ent, "elm,action,focus", "elm");
+        if (top) elm_win_keyboard_mode_set(top, ELM_WIN_KEYBOARD_ON);
+        evas_object_smart_callback_call(obj, SIG_FOCUSED, NULL);
      }
    else
      {
-	edje_object_signal_emit(wd->ent, "elm,action,unfocus", "elm");
-	evas_object_focus_set(wd->ent, EINA_FALSE);
-	if (top) elm_win_keyboard_mode_set(top, ELM_WIN_KEYBOARD_OFF);
-	evas_object_smart_callback_call(obj, SIG_UNFOCUSED, NULL);
+        edje_object_signal_emit(wd->ent, "elm,action,unfocus", "elm");
+        evas_object_focus_set(wd->ent, EINA_FALSE);
+        if (top) elm_win_keyboard_mode_set(top, ELM_WIN_KEYBOARD_OFF);
+        evas_object_smart_callback_call(obj, SIG_UNFOCUSED, NULL);
      }
 }
 
@@ -678,17 +678,17 @@
    if (!wd) return;
    evas_object_geometry_get(wd->ent, &x, &y, NULL, NULL);
    edje_object_part_text_cursor_geometry_get(wd->ent, "elm.text",
-					     &cx, &cy, &cw, &ch);
+                                             &cx, &cy, &cw, &ch);
    evas_object_size_hint_min_get(wd->hoversel, &mw, &mh);
    if (cw < mw)
      {
-	cx += (cw - mw) / 2;
-	cw = mw;
+        cx += (cw - mw) / 2;
+        cw = mw;
      }
    if (ch < mh)
      {
-	cy += (ch - mh) / 2;
-	ch = mh;
+        cy += (ch - mh) / 2;
+        ch = mh;
      }
    evas_object_move(wd->hoversel, x + cx, y + cy);
    evas_object_resize(wd->hoversel, cw, ch);
@@ -721,7 +721,7 @@
 {
    Widget_Data *wd = elm_widget_data_get(data);
    if (!wd) return;
-   
+
    if (wd->hoversel)
      {
         evas_object_del(wd->hoversel);
@@ -734,7 +734,7 @@
 _dismissed(void *data, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(data);
-   if (!wd) return; 
+   if (!wd) return;
    if (wd->hoversel) evas_object_hide(wd->hoversel);
    if (wd->selmode)
      {
@@ -770,10 +770,10 @@
 #ifdef HAVE_ELEMENTARY_X
         Elm_Sel_Format formats;
         wd->selection_asked = EINA_TRUE;
-	formats = ELM_SEL_FORMAT_MARKUP;
-	if (!wd->textonly)
-	   formats |= ELM_SEL_FORMAT_IMAGE;
-	elm_selection_get(ELM_SEL_CLIPBOARD, formats, data, NULL, NULL);
+        formats = ELM_SEL_FORMAT_MARKUP;
+        if (!wd->textonly)
+          formats |= ELM_SEL_FORMAT_IMAGE;
+        elm_selection_get(ELM_SEL_CLIPBOARD, formats, data, NULL, NULL);
 #endif
      }
 }
@@ -788,7 +788,7 @@
    sel = edje_object_part_text_selection_get(wd->ent, "elm.text");
    elm_selection_set(seltype, obj, ELM_SEL_FORMAT_MARKUP, sel);
    if (seltype == ELM_SEL_CLIPBOARD)
-	   eina_stringshare_replace(&wd->cut_sel, sel);
+     eina_stringshare_replace(&wd->cut_sel, sel);
 }
 
 static void
@@ -942,8 +942,8 @@
    if (ev->button != 1) return;
    if (wd->longpress_timer)
      {
-	ecore_timer_del(wd->longpress_timer);
-	wd->longpress_timer = NULL;
+        ecore_timer_del(wd->longpress_timer);
+        wd->longpress_timer = NULL;
      }
 }
 
@@ -956,46 +956,46 @@
    if (wd->disabled) return;
    if (!wd->selmode)
      {
-	if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD)
-	  {
-	     if (wd->longpress_timer)
-	       {
-		  ecore_timer_del(wd->longpress_timer);
-		  wd->longpress_timer = NULL;
-	       }
-	  }
-	else if (wd->longpress_timer)
-	  {
-	     Evas_Coord dx, dy;
+        if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD)
+          {
+             if (wd->longpress_timer)
+               {
+                  ecore_timer_del(wd->longpress_timer);
+                  wd->longpress_timer = NULL;
+               }
+          }
+        else if (wd->longpress_timer)
+          {
+             Evas_Coord dx, dy;
 
-	     dx = wd->downx - ev->cur.canvas.x;
-	     dx *= dx;
-	     dy = wd->downy - ev->cur.canvas.y;
-	     dy *= dy;
-	     if ((dx + dy) >
-		 ((_elm_config->finger_size / 2) *
-		  (_elm_config->finger_size / 2)))
-	       {
-		  ecore_timer_del(wd->longpress_timer);
-		  wd->longpress_timer = NULL;
-	       }
-	  }
+             dx = wd->downx - ev->cur.canvas.x;
+             dx *= dx;
+             dy = wd->downy - ev->cur.canvas.y;
+             dy *= dy;
+             if ((dx + dy) >
+                 ((_elm_config->finger_size / 2) *
+                  (_elm_config->finger_size / 2)))
+               {
+                  ecore_timer_del(wd->longpress_timer);
+                  wd->longpress_timer = NULL;
+               }
+          }
      }
    else if (wd->longpress_timer)
      {
-	Evas_Coord dx, dy;
+        Evas_Coord dx, dy;
 
-	dx = wd->downx - ev->cur.canvas.x;
-	dx *= dx;
-	dy = wd->downy - ev->cur.canvas.y;
-	dy *= dy;
-	if ((dx + dy) >
-	    ((_elm_config->finger_size / 2) *
-	     (_elm_config->finger_size / 2)))
-	  {
-	     ecore_timer_del(wd->longpress_timer);
-	     wd->longpress_timer = NULL;
-	  }
+        dx = wd->downx - ev->cur.canvas.x;
+        dx *= dx;
+        dy = wd->downy - ev->cur.canvas.y;
+        dy *= dy;
+        if ((dx + dy) >
+            ((_elm_config->finger_size / 2) *
+             (_elm_config->finger_size / 2)))
+          {
+             ecore_timer_del(wd->longpress_timer);
+             wd->longpress_timer = NULL;
+          }
      }
 }
 
@@ -1006,31 +1006,31 @@
    if (!wd) return "base";
    if (wd->editable)
      {
-	if (wd->password) return "base-password";
-	else
-	  {
-	     if (wd->single_line) return "base-single";
-	     else
-	       {
-		  if (wd->linewrap) return "base";
+        if (wd->password) return "base-password";
+        else
+          {
+             if (wd->single_line) return "base-single";
+             else
+               {
+                  if (wd->linewrap) return "base";
                   else if (wd->char_linewrap) return "base-charwrap";
-		  else  return "base-nowrap";
-	       }
-	  }
+                  else  return "base-nowrap";
+               }
+          }
      }
    else
      {
-	if (wd->password) return "base-password";
-	else
-	  {
-	     if (wd->single_line) return "base-single-noedit";
-	     else
-	       {
-		  if (wd->linewrap) return "base-noedit";
+        if (wd->password) return "base-password";
+        else
+          {
+             if (wd->single_line) return "base-single-noedit";
+             else
+               {
+                  if (wd->linewrap) return "base-noedit";
                   else if (wd->char_linewrap) return "base-noedit-charwrap";
-		  else  return "base-nowrap-noedit";
-	       }
-	  }
+                  else  return "base-nowrap-noedit";
+               }
+          }
      }
    return "base";
 }
@@ -1047,8 +1047,8 @@
    evas_object_smart_callback_call(data, SIG_CHANGED, NULL);
    if (wd->delay_write)
      {
-	ecore_timer_del(wd->delay_write);
-	wd->delay_write = NULL;
+        ecore_timer_del(wd->delay_write);
+        wd->delay_write = NULL;
      }
    if ((!wd->autosave) || (!wd->file)) return;
    wd->delay_write = ecore_timer_add(2.0, _delay_write, data);
@@ -1063,19 +1063,19 @@
    if (!wd) return;
    EINA_LIST_FOREACH(entries, l, entry)
      {
-	if (entry != data) elm_entry_select_none(entry);
+        if (entry != data) elm_entry_select_none(entry);
      }
    wd->have_selection = EINA_TRUE;
    evas_object_smart_callback_call(data, SIG_SELECTION_START, NULL);
 #ifdef HAVE_ELEMENTARY_X
    if (wd->sel_notify_handler)
      {
-	const char *txt = elm_entry_selection_get(data);
-	Evas_Object *top;
+        const char *txt = elm_entry_selection_get(data);
+        Evas_Object *top;
 
-	top = elm_widget_top_get(data);
-	if ((top) && (elm_win_xwindow_get(top)))
-	     elm_selection_set(ELM_SEL_PRIMARY, data, ELM_SEL_FORMAT_MARKUP, txt);
+        top = elm_widget_top_get(data);
+        if ((top) && (elm_win_xwindow_get(top)))
+          elm_selection_set(ELM_SEL_PRIMARY, data, ELM_SEL_FORMAT_MARKUP, txt);
      }
 #endif
 }
@@ -1088,7 +1088,7 @@
    wd->have_selection = EINA_TRUE;
    evas_object_smart_callback_call(data, SIG_SELECTION_CHANGED, NULL);
    elm_selection_set(ELM_SEL_PRIMARY, obj, ELM_SEL_FORMAT_MARKUP,
-		   elm_entry_selection_get(data));
+                     elm_entry_selection_get(data));
 }
 
 static void
@@ -1101,29 +1101,29 @@
    evas_object_smart_callback_call(data, SIG_SELECTION_CLEARED, NULL);
    if (wd->sel_notify_handler)
      {
-	if (wd->cut_sel)
-	  {
+        if (wd->cut_sel)
+          {
 #ifdef HAVE_ELEMENTARY_X
-	     Evas_Object *top;
+             Evas_Object *top;
 
-	     top = elm_widget_top_get(data);
-	     if ((top) && (elm_win_xwindow_get(top)))
-	         elm_selection_set(ELM_SEL_PRIMARY, data, ELM_SEL_FORMAT_MARKUP,
-				       wd->cut_sel);
+             top = elm_widget_top_get(data);
+             if ((top) && (elm_win_xwindow_get(top)))
+               elm_selection_set(ELM_SEL_PRIMARY, data, ELM_SEL_FORMAT_MARKUP,
+                                 wd->cut_sel);
 #endif
-	     eina_stringshare_del(wd->cut_sel);
-	     wd->cut_sel = NULL;
-	  }
-	else
-	  {
+             eina_stringshare_del(wd->cut_sel);
+             wd->cut_sel = NULL;
+          }
+        else
+          {
 #ifdef HAVE_ELEMENTARY_X
-	     Evas_Object *top;
+             Evas_Object *top;
 
-	     top = elm_widget_top_get(data);
-	     if ((top) && (elm_win_xwindow_get(top)))
-		elm_selection_clear(ELM_SEL_PRIMARY, data);
+             top = elm_widget_top_get(data);
+             if ((top) && (elm_win_xwindow_get(top)))
+               elm_selection_clear(ELM_SEL_PRIMARY, data);
 #endif
-	  }
+          }
      }
 }
 
@@ -1136,15 +1136,15 @@
    if (wd->sel_notify_handler)
      {
 #ifdef HAVE_ELEMENTARY_X
-	Evas_Object *top;
+        Evas_Object *top;
 
-	top = elm_widget_top_get(data);
-	if ((top) && (elm_win_xwindow_get(top)))
-	  {
+        top = elm_widget_top_get(data);
+        if ((top) && (elm_win_xwindow_get(top)))
+          {
              wd->selection_asked = EINA_TRUE;
              elm_selection_get(ELM_SEL_CLIPBOARD, ELM_SEL_FORMAT_MARKUP, data,
                                NULL, NULL);
-	  }
+          }
 #endif
      }
 }
@@ -1156,7 +1156,7 @@
    if (!wd) return;
    evas_object_smart_callback_call(data, SIG_SELECTION_COPY, NULL);
    elm_selection_set(ELM_SEL_CLIPBOARD, obj, ELM_SEL_FORMAT_MARKUP,
-			elm_entry_selection_get(data));
+                     elm_entry_selection_get(data));
 }
 
 static void
@@ -1166,7 +1166,7 @@
    if (!wd) return;
    evas_object_smart_callback_call(data, SIG_SELECTION_CUT, NULL);
    elm_selection_set(ELM_SEL_CLIPBOARD, obj, ELM_SEL_FORMAT_MARKUP,
-			elm_entry_selection_get(data));
+                     elm_entry_selection_get(data));
    edje_object_part_text_insert(wd->ent, "elm.text", "");
    wd->changed = EINA_TRUE;
    _sizing_eval(data);
@@ -1185,11 +1185,11 @@
      elm_widget_show_region_set(data, cx, cy, cw, ch);
    else
      {
-	wd->deferred_cur = EINA_TRUE;
-	wd->cx = cx;
-	wd->cy = cy;
-	wd->cw = cw;
-	wd->ch = ch;
+        wd->deferred_cur = EINA_TRUE;
+        wd->cx = cx;
+        wd->cy = cy;
+        wd->cw = cw;
+        wd->ch = ch;
      }
 }
 
@@ -1217,47 +1217,47 @@
    p = strrchr(emission, ',');
    if (p)
      {
-	const Eina_List *geoms;
+        const Eina_List *geoms;
 
-	n = p + 1;
-	p2 = p -1;
-	while (p2 >= emission)
-	  {
-	     if (*p2 == ',') break;
-	     p2--;
-	  }
-	p2++;
-	buf2 = alloca(5 + p - p2);
-	strncpy(buf2, p2, p - p2);
-	buf2[p - p2] = 0;
-	ei.name = n;
-	ei.button = atoi(buf2);
-	ei.x = ei.y = ei.w = ei.h = 0;
-	geoms =
-          edje_object_part_text_anchor_geometry_get(wd->ent, "elm.text", ei.name);
-	if (geoms)
-	  {
-	     Evas_Textblock_Rectangle *r;
-	     const Eina_List *l;
-	     Evas_Coord px, py, x, y;
+        n = p + 1;
+        p2 = p -1;
+        while (p2 >= emission)
+          {
+             if (*p2 == ',') break;
+             p2--;
+          }
+        p2++;
+        buf2 = alloca(5 + p - p2);
+        strncpy(buf2, p2, p - p2);
+        buf2[p - p2] = 0;
+        ei.name = n;
+        ei.button = atoi(buf2);
+        ei.x = ei.y = ei.w = ei.h = 0;
+        geoms =
+           edje_object_part_text_anchor_geometry_get(wd->ent, "elm.text", ei.name);
+        if (geoms)
+          {
+             Evas_Textblock_Rectangle *r;
+             const Eina_List *l;
+             Evas_Coord px, py, x, y;
 
-	     evas_object_geometry_get(wd->ent, &x, &y, NULL, NULL);
-	     evas_pointer_output_xy_get(evas_object_evas_get(wd->ent), &px, &py);
-	     EINA_LIST_FOREACH(geoms, l, r)
-	       {
-		  if (((r->x + x) <= px) && ((r->y + y) <= py) &&
-		      ((r->x + x + r->w) > px) && ((r->y + y + r->h) > py))
-		    {
-		       ei.x = r->x + x;
-		       ei.y = r->y + y;
-		       ei.w = r->w;
-		       ei.h = r->h;
-		       break;
-		    }
-	       }
-	  }
-	if (!wd->disabled)
-	  evas_object_smart_callback_call(data, SIG_ANCHOR_CLICKED, &ei);
+             evas_object_geometry_get(wd->ent, &x, &y, NULL, NULL);
+             evas_pointer_output_xy_get(evas_object_evas_get(wd->ent), &px, &py);
+             EINA_LIST_FOREACH(geoms, l, r)
+               {
+                  if (((r->x + x) <= px) && ((r->y + y) <= py) &&
+                      ((r->x + x + r->w) > px) && ((r->y + y + r->h) > py))
+                    {
+                       ei.x = r->x + x;
+                       ei.y = r->y + y;
+                       ei.w = r->w;
+                       ei.h = r->h;
+                       break;
+                    }
+               }
+          }
+        if (!wd->disabled)
+          evas_object_smart_callback_call(data, SIG_ANCHOR_CLICKED, &ei);
      }
 }

Log:
Elementary genlist: Removed trailing white spaces and fixed indentation.
  

Author:       seoz
Date:         2011-03-18 07:29:48 -0700 (Fri, 18 Mar 2011)
New Revision: 57850
Trac:         http://trac.enlightenment.org/e/changeset/57850

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-03-18 12:13:54 UTC (rev 57849)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-03-18 14:29:48 UTC (rev 57850)
@@ -198,7 +198,7 @@
  * handle that is an internal member inside the genlist. They all take a data
  * parameter that is meant to be used for a handle to the applications
  * internal data (eg the struct with the original item data). The parent
- * parameter is the parent genlist item this belongs to if it is a tree or 
+ * parameter is the parent genlist item this belongs to if it is a tree or
  * an indexed group, and NULL if there is no parent. The flags can be a bitmask
  * of ELM_GENLIST_ITEM_NONE, ELM_GENLIST_ITEM_SUBITEMS and
  * ELM_GENLIST_ITEM_GROUP. If ELM_GENLIST_ITEM_SUBITEMS is set then this item
@@ -1906,7 +1906,7 @@
    it->want_unrealize = EINA_FALSE;
 }
 
-static Eina_Bool 
+static Eina_Bool
 _item_block_recalc(Item_Block *itb,
                    int         in,
                    int         qadd,
@@ -2078,7 +2078,7 @@
 
    EINA_LIST_FOREACH(wd->group_items, l, git)
      {
-        if (git->want_realize) 
+        if (git->want_realize)
           {
              if (!git->realized)
                 _item_realize(git, 0, 0);
@@ -2089,7 +2089,7 @@
           }
         else if (!git->want_realize && git->realized)
           {
-             if (!git->dragging) 
+             if (!git->dragging)
                 _item_unrealize(git);
           }
      }
@@ -2947,7 +2947,7 @@
    if (!it->parent)
      {
         if (flags & ELM_GENLIST_ITEM_GROUP)
-           wd->group_items = eina_list_append(wd->group_items, it);
+          wd->group_items = eina_list_append(wd->group_items, it);
         wd->items = eina_inlist_append(wd->items, EINA_INLIST_GET(it));
         it->rel = NULL;
      }
@@ -2959,15 +2959,15 @@
         it->parent->items = eina_list_append(it->parent->items, it);
         if (!it2) it2 = it->parent;
         wd->items =
-          eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
-                                      EINA_INLIST_GET(it2));
+           eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
+                                       EINA_INLIST_GET(it2));
         it->rel = it2;
         it->rel->relcount++;
 
-        if (it->parent->flags & ELM_GENLIST_ITEM_GROUP) 
-           it->group_item = parent;
+        if (it->parent->flags & ELM_GENLIST_ITEM_GROUP)
+          it->group_item = parent;
         else if (it->parent->group_item)
-           it->group_item = it->parent->group_item;
+          it->group_item = it->parent->group_item;
      }
    it->before = EINA_FALSE;
    _item_queue(wd, it);
@@ -3169,7 +3169,7 @@
           it->wd->group_items = eina_list_remove(it->wd->group_items, it);
         elm_widget_item_pre_notify_del(it);
         if (it->realized) _item_unrealize(it);
-        if (((wd->clear_me) || (!it->delete_me)) && (it->itc->func.del)) 
+        if (((wd->clear_me) || (!it->delete_me)) && (it->itc->func.del))
           it->itc->func.del((void *)it->base.data, it->base.widget);
         if (it->long_timer) ecore_timer_del(it->long_timer);
         if (it->swipe_timer) ecore_timer_del(it->swipe_timer);
@@ -3832,7 +3832,7 @@
 elm_genlist_item_bring_in(Elm_Genlist_Item *it)
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
-   Evas_Coord gith = 0; 
+   Evas_Coord gith = 0;
    if (it->delete_me) return;
    if ((it->queued) || (!it->mincalcd))
      {

Log:
Elementary genlist: Changed int calc to Eina_Bool calc.
  
  calc decides whether this call is for calculation only or not.
  So it's reasonable to change this to Eina_Bool.
  

Author:       seoz
Date:         2011-03-18 08:02:49 -0700 (Fri, 18 Mar 2011)
New Revision: 57851
Trac:         http://trac.enlightenment.org/e/changeset/57851

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-03-18 14:29:48 UTC (rev 57850)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-03-18 15:02:49 UTC (rev 57851)
@@ -1617,9 +1617,7 @@
 }
 
 static void
-_item_realize(Elm_Genlist_Item *it,
-              int               in,
-              int               calc)
+_item_realize(Elm_Genlist_Item *it, int in, Eina_Bool calc)
 {
    Elm_Genlist_Item *it2;
    const char *stacking;
@@ -1930,18 +1928,18 @@
                   if (!it->mincalcd) changed = EINA_TRUE;
                   if (changed)
                     {
-                       _item_realize(it, in, 1);
+                       _item_realize(it, in, EINA_TRUE);
                        _item_unrealize(it);
                     }
                }
              else
                {
-                  _item_realize(it, in, 1);
+                  _item_realize(it, in, EINA_TRUE);
                   _item_unrealize(it);
                }
           }
         else
-          _item_realize(it, in, 0);
+          _item_realize(it, in, EINA_FALSE);
         minh += it->minh;
         if (minw < it->minw) minw = it->minw;
         in++;
@@ -1969,7 +1967,7 @@
    EINA_LIST_FOREACH(itb->items, l, it)
      {
         if (it->delete_me) continue;
-        if (full) _item_realize(it, in, 0);
+        if (full) _item_realize(it, in, EINA_FALSE);
         in++;
      }
    itb->realized = EINA_TRUE;
@@ -2034,7 +2032,7 @@
           {
              if ((itb->realized) && (!it->realized))
                {
-                  if (vis) _item_realize(it, in, 0);
+                  if (vis) _item_realize(it, in, EINA_FALSE);
                }
              if (it->realized)
                {
@@ -2081,7 +2079,7 @@
         if (git->want_realize)
           {
              if (!git->realized)
-                _item_realize(git, 0, 0);
+                _item_realize(git, 0, EINA_FALSE);
              evas_object_resize(git->base.view, wd->minw, git->h);
              evas_object_move(git->base.view, git->scrl_x, git->scrl_y);
              evas_object_show(git->base.view);
@@ -2270,12 +2268,12 @@
                 if (it->realized)
                   {
                      _item_unrealize(it);
-                     _item_realize(it, num, 0);
+                     _item_realize(it, num, EINA_FALSE);
                      position = 1;
                   }
                 else
                   {
-                     _item_realize(it, num, 1);
+                     _item_realize(it, num, EINA_TRUE);
                      _item_unrealize(it);
                   }
                 if ((it->minw != itminw) || (it->minh != itminh))

Log:
Elementary elm_genlist.c: Formatting with ecrustify.
  

Author:       seoz
Date:         2011-03-22 00:54:24 -0700 (Tue, 22 Mar 2011)
New Revision: 57963
Trac:         http://trac.enlightenment.org/e/changeset/57963

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-03-22 07:51:17 UTC (rev 57962)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-03-22 07:54:24 UTC (rev 57963)
@@ -445,9 +445,11 @@
 static const char *widtype = NULL;
 static void      _item_cache_zero(Widget_Data *wd);
 static void      _del_hook(Evas_Object *obj);
-static void _mirrored_set(Evas_Object *obj, Eina_Bool rtl);
+static void      _mirrored_set(Evas_Object *obj,
+                               Eina_Bool    rtl);
 static void      _theme_hook(Evas_Object *obj);
-static void      _show_region_hook(void *data, Evas_Object *obj);
+static void      _show_region_hook(void        *data,
+                                   Evas_Object *obj);
 static void      _sizing_eval(Evas_Object *obj);
 static void      _item_unrealize(Elm_Genlist_Item *it);
 static void      _item_block_unrealize(Item_Block *itb);
@@ -725,7 +727,8 @@
 }
 
 static void
-_mirrored_set(Evas_Object *obj, Eina_Bool rtl)
+_mirrored_set(Evas_Object *obj,
+              Eina_Bool    rtl)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -748,23 +751,24 @@
    wd->item_width = wd->item_height = 0;
    wd->minw = wd->minh = wd->realminw = 0;
    EINA_INLIST_FOREACH(wd->blocks, itb)
-   {
-      Eina_List *l;
-      Elm_Genlist_Item *it;
+     {
+        Eina_List *l;
+        Elm_Genlist_Item *it;
 
-      if (itb->realized) _item_block_unrealize(itb);
-      EINA_LIST_FOREACH(itb->items, l, it)
-        it->mincalcd = EINA_FALSE;
+        if (itb->realized) _item_block_unrealize(itb);
+        EINA_LIST_FOREACH(itb->items, l, it)
+          it->mincalcd = EINA_FALSE;
 
-      itb->changed = EINA_TRUE;
-   }
+        itb->changed = EINA_TRUE;
+     }
    if (wd->calc_job) ecore_job_del(wd->calc_job);
    wd->calc_job = ecore_job_add(_calc_job, wd);
    _sizing_eval(obj);
 }
 
 static void
-_show_region_hook(void *data, Evas_Object *obj)
+_show_region_hook(void        *data,
+                  Evas_Object *obj)
 {
    Widget_Data *wd = elm_widget_data_get(data);
    Evas_Coord x, y, w, h;
@@ -796,9 +800,9 @@
 
              wd->prev_viewport_w = vw;
              EINA_INLIST_FOREACH(wd->blocks, itb)
-             {
-                itb->must_recalc = EINA_TRUE;
-             }
+               {
+                  itb->must_recalc = EINA_TRUE;
+               }
              if (wd->calc_job) ecore_job_del(wd->calc_job);
              wd->calc_job = ecore_job_add(_calc_job, wd);
           }
@@ -841,7 +845,7 @@
      {
         evas_object_raise(it->base.view);
         if ((it->group_item) && (it->group_item->realized))
-           evas_object_raise(it->group_item->base.view);
+          evas_object_raise(it->group_item->base.view);
      }
    it->highlighted = EINA_TRUE;
 }
@@ -1177,8 +1181,8 @@
      }
    if (it->wd->multi_timeout)
      {
-         it->wd->multi_timeout = EINA_FALSE;
-         return;
+        it->wd->multi_timeout = EINA_FALSE;
+        return;
      }
 
    Evas_Coord minw = 0, minh = 0;
@@ -1223,14 +1227,14 @@
                                                "multi,pinch,in", it);
           }
      }
-     it->wd->multi_timeout = EINA_FALSE;
+   it->wd->multi_timeout = EINA_FALSE;
 }
 
 static void
-_multi_down(void        *data,
-            Evas *evas  __UNUSED__,
+_multi_down(void            *data,
+            Evas *evas       __UNUSED__,
             Evas_Object *obj __UNUSED__,
-            void        *event_info)
+            void            *event_info)
 {
    Elm_Genlist_Item *it = data;
    Evas_Event_Multi_Down *ev = event_info;
@@ -1268,10 +1272,10 @@
 }
 
 static void
-_multi_up(void        *data,
-          Evas *evas  __UNUSED__,
+_multi_up(void            *data,
+          Evas *evas       __UNUSED__,
           Evas_Object *obj __UNUSED__,
-          void        *event_info)
+          void            *event_info)
 {
    Elm_Genlist_Item *it = data;
    Evas_Event_Multi_Up *ev = event_info;
@@ -1284,10 +1288,10 @@
 }
 
 static void
-_multi_move(void        *data,
-            Evas *evas  __UNUSED__,
+_multi_move(void            *data,
+            Evas *evas       __UNUSED__,
             Evas_Object *obj __UNUSED__,
-            void        *event_info)
+            void            *event_info)
 {
    Elm_Genlist_Item *it = data;
    Evas_Event_Multi_Move *ev = event_info;
@@ -1334,8 +1338,8 @@
    it->wd->wasselected = it->selected;
    _item_highlight(it);
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
-      if ((!it->disabled) && (!it->display_only))
-         evas_object_smart_callback_call(it->base.widget, "clicked", it);
+     if ((!it->disabled) && (!it->display_only))
+       evas_object_smart_callback_call(it->base.widget, "clicked", it);
    if (it->long_timer) ecore_timer_del(it->long_timer);
    if (it->swipe_timer) ecore_timer_del(it->swipe_timer);
    it->swipe_timer = ecore_timer_add(0.4, _swipe_cancel, it);
@@ -1590,20 +1594,20 @@
    if (it->flags & ELM_GENLIST_ITEM_SUBITEMS) tree = 1;
    odd = (it->order_num_in & 0x1);
    EINA_INLIST_FOREACH(it->wd->item_cache, itc)
-   {
-      if ((itc->selected) || (itc->disabled) || (itc->expanded))
-        continue;
-      if ((itc->tree == tree) &&
-          (itc->odd == odd) &&
-          (itc->compress == it->wd->compress) &&
-          (!strcmp(it->itc->item_style, itc->item_style)))
-        {
-           it->wd->item_cache = eina_inlist_remove(it->wd->item_cache,
-                                                   EINA_INLIST_GET(itc));
-           it->wd->item_cache_count--;
-           return itc;
-        }
-   }
+     {
+        if ((itc->selected) || (itc->disabled) || (itc->expanded))
+          continue;
+        if ((itc->tree == tree) &&
+            (itc->odd == odd) &&
+            (itc->compress == it->wd->compress) &&
+            (!strcmp(it->itc->item_style, itc->item_style)))
+          {
+             it->wd->item_cache = eina_inlist_remove(it->wd->item_cache,
+                                                     EINA_INLIST_GET(itc));
+             it->wd->item_cache_count--;
+             return itc;
+          }
+     }
    return NULL;
 }
 
@@ -1617,7 +1621,9 @@
 }
 
 static void
-_item_realize(Elm_Genlist_Item *it, int in, Eina_Bool calc)
+_item_realize(Elm_Genlist_Item *it,
+              int               in,
+              Eina_Bool         calc)
 {
    Elm_Genlist_Item *it2;
    const char *stacking;
@@ -1630,9 +1636,9 @@
    it->order_num_in = in;
 
    if (it->nocache)
-      it->nocache = EINA_FALSE;
+     it->nocache = EINA_FALSE;
    else
-      itc = _item_cache_find(it);
+     itc = _item_cache_find(it);
    if (itc)
      {
         it->base.view = itc->base_view;
@@ -1661,8 +1667,8 @@
 
         _elm_theme_object_set(it->base.widget, it->base.view, "genlist", buf,
                               elm_widget_style_get(it->base.widget));
-       edje_object_mirrored_set(it->base.view,
-             elm_widget_mirrored_get(it->base.widget));
+        edje_object_mirrored_set(it->base.view,
+                                 elm_widget_mirrored_get(it->base.widget));
         it->spacer =
           evas_object_rectangle_add(evas_object_evas_get(it->base.widget));
         evas_object_color_set(it->spacer, 0, 0, 0, 0);
@@ -1992,7 +1998,7 @@
                   it->want_unrealize = EINA_TRUE;
                }
              else
-                _item_unrealize(it);
+               _item_unrealize(it);
           }
      }
    if (!dragging)
@@ -2042,9 +2048,9 @@
                        if (git)
                          {
                             if (git->scrl_y < oy)
-                               git->scrl_y = oy;
+                              git->scrl_y = oy;
                             if ((git->scrl_y + git->h) > (it->scrl_y + it->h))
-                               git->scrl_y = (it->scrl_y + it->h) - git->h;
+                              git->scrl_y = (it->scrl_y + it->h) - git->h;
                             git->want_realize = EINA_TRUE;
                          }
                        evas_object_resize(it->base.view, it->w, it->h);
@@ -2061,7 +2067,7 @@
           }
         else
           {
-            if (vis) it->want_realize = EINA_TRUE;
+             if (vis) it->want_realize = EINA_TRUE;
           }
         y += it->h;
      }
@@ -2079,7 +2085,7 @@
         if (git->want_realize)
           {
              if (!git->realized)
-                _item_realize(git, 0, EINA_FALSE);
+               _item_realize(git, 0, EINA_FALSE);
              evas_object_resize(git->base.view, wd->minw, git->h);
              evas_object_move(git->base.view, git->scrl_x, git->scrl_y);
              evas_object_show(git->base.view);
@@ -2088,7 +2094,7 @@
         else if (!git->want_realize && git->realized)
           {
              if (!git->dragging)
-                _item_unrealize(git);
+               _item_unrealize(git);
           }
      }
 }
@@ -2125,82 +2131,82 @@
      }
 
    EINA_INLIST_FOREACH(wd->blocks, itb)
-   {
-      Eina_Bool showme = EINA_FALSE;
+     {
+        Eina_Bool showme = EINA_FALSE;
 
-      itb->num = in;
-      showme = itb->showme;
-      itb->showme = EINA_FALSE;
-      if (chb)
-        {
-           if (itb->realized) _item_block_unrealize(itb);
-        }
-      if ((itb->changed) || (changed) ||
-          ((itb->must_recalc) && (!did_must_recalc)))
-        {
-           if ((changed) || (itb->must_recalc))
-             {
-                Eina_List *l;
-                Elm_Genlist_Item *it;
-                EINA_LIST_FOREACH(itb->items, l, it)
-                  if (it->mincalcd) it->mincalcd = EINA_FALSE;
-                itb->changed = EINA_TRUE;
-                if (itb->must_recalc) did_must_recalc = EINA_TRUE;
-                itb->must_recalc = EINA_FALSE;
-             }
-           if (itb->realized) _item_block_unrealize(itb);
-           showme = _item_block_recalc(itb, in, 0, 1);
-           chb = itb;
-        }
-      itb->y = y;
-      itb->x = 0;
-      minh += itb->minh;
-      if (minw == -1) minw = itb->minw;
-      else if ((!itb->must_recalc) && (minw < itb->minw))
-        {
-           minw = itb->minw;
-           minw_change = 1;
-        }
-      itb->w = minw;
-      itb->h = itb->minh;
-      y += itb->h;
-      in += itb->count;
-      if ((showme) && (wd->show_item))
-        {
-           wd->show_item->showme = EINA_FALSE;
-           if (wd->bring_in)
-             elm_smart_scroller_region_bring_in(wd->scr,
-                                                wd->show_item->x +
-                                                wd->show_item->block->x,
-                                                wd->show_item->y +
-                                                wd->show_item->block->y,
-                                                wd->show_item->block->w,
-                                                wd->show_item->h);
-           else
-             elm_smart_scroller_child_region_show(wd->scr,
+        itb->num = in;
+        showme = itb->showme;
+        itb->showme = EINA_FALSE;
+        if (chb)
+          {
+             if (itb->realized) _item_block_unrealize(itb);
+          }
+        if ((itb->changed) || (changed) ||
+            ((itb->must_recalc) && (!did_must_recalc)))
+          {
+             if ((changed) || (itb->must_recalc))
+               {
+                  Eina_List *l;
+                  Elm_Genlist_Item *it;
+                  EINA_LIST_FOREACH(itb->items, l, it)
+                    if (it->mincalcd) it->mincalcd = EINA_FALSE;
+                  itb->changed = EINA_TRUE;
+                  if (itb->must_recalc) did_must_recalc = EINA_TRUE;
+                  itb->must_recalc = EINA_FALSE;
+               }
+             if (itb->realized) _item_block_unrealize(itb);
+             showme = _item_block_recalc(itb, in, 0, 1);
+             chb = itb;
+          }
+        itb->y = y;
+        itb->x = 0;
+        minh += itb->minh;
+        if (minw == -1) minw = itb->minw;
+        else if ((!itb->must_recalc) && (minw < itb->minw))
+          {
+             minw = itb->minw;
+             minw_change = 1;
+          }
+        itb->w = minw;
+        itb->h = itb->minh;
+        y += itb->h;
+        in += itb->count;
+        if ((showme) && (wd->show_item))
+          {
+             wd->show_item->showme = EINA_FALSE;
+             if (wd->bring_in)
+               elm_smart_scroller_region_bring_in(wd->scr,
                                                   wd->show_item->x +
                                                   wd->show_item->block->x,
                                                   wd->show_item->y +
                                                   wd->show_item->block->y,
                                                   wd->show_item->block->w,
                                                   wd->show_item->h);
-           wd->show_item = NULL;
-        }
-   }
+             else
+               elm_smart_scroller_child_region_show(wd->scr,
+                                                    wd->show_item->x +
+                                                    wd->show_item->block->x,
+                                                    wd->show_item->y +
+                                                    wd->show_item->block->y,
+                                                    wd->show_item->block->w,
+                                                    wd->show_item->h);
+             wd->show_item = NULL;
+          }
+     }
    if (minw_change)
      {
         EINA_INLIST_FOREACH(wd->blocks, itb)
-        {
-           itb->minw = minw;
-           itb->w = itb->minw;
-        }
+          {
+             itb->minw = minw;
+             itb->w = itb->minw;
+          }
      }
    if ((chb) && (EINA_INLIST_GET(chb)->next))
      {
         EINA_INLIST_FOREACH(EINA_INLIST_GET(chb)->next, itb)
-        {
-           if (itb->realized) _item_block_unrealize(itb);
-        }
+          {
+             if (itb->realized) _item_block_unrealize(itb);
+          }
      }
    wd->realminw = minw;
    if (minw < wd->w) minw = wd->w;
@@ -2244,52 +2250,52 @@
    wd->update_job = NULL;
    num = 0;
    EINA_INLIST_FOREACH(wd->blocks, itb)
-   {
-      Evas_Coord itminw, itminh;
-      Elm_Genlist_Item *it;
+     {
+        Evas_Coord itminw, itminh;
+        Elm_Genlist_Item *it;
 
-      if (!itb->updateme)
-        {
-           num += itb->count;
-           if (position)
-             _item_block_position(itb, num);
-           continue;
-        }
-      num0 = num;
-      recalc = 0;
-      EINA_LIST_FOREACH(itb->items, l2, it)
-        {
-           if (it->updateme)
-             {
-                itminw = it->w;
-                itminh = it->h;
+        if (!itb->updateme)
+          {
+             num += itb->count;
+             if (position)
+               _item_block_position(itb, num);
+             continue;
+          }
+        num0 = num;
+        recalc = 0;
+        EINA_LIST_FOREACH(itb->items, l2, it)
+          {
+             if (it->updateme)
+               {
+                  itminw = it->w;
+                  itminh = it->h;
 
-                it->updateme = EINA_FALSE;
-                if (it->realized)
-                  {
-                     _item_unrealize(it);
-                     _item_realize(it, num, EINA_FALSE);
-                     position = 1;
-                  }
-                else
-                  {
-                     _item_realize(it, num, EINA_TRUE);
-                     _item_unrealize(it);
-                  }
-                if ((it->minw != itminw) || (it->minh != itminh))
-                  recalc = 1;
-             }
-           num++;
-        }
-      itb->updateme = EINA_FALSE;
-      if (recalc)
-        {
-           position = 1;
-           itb->changed = EINA_TRUE;
-           _item_block_recalc(itb, num0, 0, 1);
-           _item_block_position(itb, num0);
-        }
-   }
+                  it->updateme = EINA_FALSE;
+                  if (it->realized)
+                    {
+                       _item_unrealize(it);
+                       _item_realize(it, num, EINA_FALSE);
+                       position = 1;
+                    }
+                  else
+                    {
+                       _item_realize(it, num, EINA_TRUE);
+                       _item_unrealize(it);
+                    }
+                  if ((it->minw != itminw) || (it->minh != itminh))
+                    recalc = 1;
+               }
+             num++;
+          }
+        itb->updateme = EINA_FALSE;
+        if (recalc)
+          {
+             position = 1;
+             itb->changed = EINA_TRUE;
+             _item_block_recalc(itb, num0, 0, 1);
+             _item_block_position(itb, num0);
+          }
+     }
    if (position)
      {
         if (wd->calc_job) ecore_job_del(wd->calc_job);
@@ -2320,23 +2326,23 @@
    sd->wd->pan_y = y;
 
    EINA_INLIST_FOREACH(sd->wd->blocks, itb)
-   {
-      if ((itb->y + itb->h) > y)
-        {
-           Elm_Genlist_Item *it;
-           Eina_List *l2;
+     {
+        if ((itb->y + itb->h) > y)
+          {
+             Elm_Genlist_Item *it;
+             Eina_List *l2;
 
-           EINA_LIST_FOREACH(itb->items, l2, it)
-             {
-                if ((itb->y + it->y) >= y)
-                  {
-                     sd->wd->anchor_item = it;
-                     sd->wd->anchor_y = -(itb->y + it->y - y);
-                     goto done;
-                  }
-             }
-        }
-   }
+             EINA_LIST_FOREACH(itb->items, l2, it)
+               {
+                  if ((itb->y + it->y) >= y)
+                    {
+                       sd->wd->anchor_item = it;
+                       sd->wd->anchor_y = -(itb->y + it->y - y);
+                       goto done;
+                    }
+               }
+          }
+     }
 done:
    evas_object_smart_changed(obj);
 }
@@ -2462,23 +2468,23 @@
         git->want_realize = EINA_FALSE;
      }
    EINA_INLIST_FOREACH(sd->wd->blocks, itb)
-   {
-      itb->w = sd->wd->minw;
-      if (ELM_RECTS_INTERSECT(itb->x - sd->wd->pan_x + ox,
-                              itb->y - sd->wd->pan_y + oy,
-                              itb->w, itb->h,
-                              cvx, cvy, cvw, cvh))
-        {
-           if ((!itb->realized) || (itb->changed))
-             _item_block_realize(itb, in, 0);
-           _item_block_position(itb, in);
-        }
-      else
-        {
-           if (itb->realized) _item_block_unrealize(itb);
-        }
-      in += itb->count;
-   }
+     {
+        itb->w = sd->wd->minw;
+        if (ELM_RECTS_INTERSECT(itb->x - sd->wd->pan_x + ox,
+                                itb->y - sd->wd->pan_y + oy,
+                                itb->w, itb->h,
+                                cvx, cvy, cvw, cvh))
+          {
+             if ((!itb->realized) || (itb->changed))
+               _item_block_realize(itb, in, 0);
+             _item_block_position(itb, in);
+          }
+        else
+          {
+             if (itb->realized) _item_block_unrealize(itb);
+          }
+        in += itb->count;
+     }
    _group_items_recalc(sd->wd);
 }
 
@@ -2834,7 +2840,7 @@
 
 static int
 _queue_process(Widget_Data *wd,
-                int          norender)
+               int          norender)
 {
    int n;
    Eina_Bool showme = EINA_FALSE;
@@ -2885,8 +2891,8 @@
         //xxx
         //printf("PROCESS TIME: %3.3f\n", ecore_time_get() - q_start);
         //xxx
-        wd->queue_idler = NULL;
-        return ECORE_CALLBACK_CANCEL;
+              wd->queue_idler = NULL;
+              return ECORE_CALLBACK_CANCEL;
      }
    return ECORE_CALLBACK_RENEW;
 }
@@ -2957,8 +2963,8 @@
         it->parent->items = eina_list_append(it->parent->items, it);
         if (!it2) it2 = it->parent;
         wd->items =
-           eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
-                                       EINA_INLIST_GET(it2));
+          eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
+                                      EINA_INLIST_GET(it2));
         it->rel = it2;
         it->rel->relcount++;
 
@@ -3007,7 +3013,7 @@
    if (!it->parent)
      {
         if (flags & ELM_GENLIST_ITEM_GROUP)
-           wd->group_items = eina_list_prepend(wd->group_items, it);
+          wd->group_items = eina_list_prepend(wd->group_items, it);
         wd->items = eina_inlist_prepend(wd->items, EINA_INLIST_GET(it));
         it->rel = NULL;
      }
@@ -3019,8 +3025,8 @@
         it->parent->items = eina_list_prepend(it->parent->items, it);
         if (!it2) it2 = it->parent;
         wd->items =
-           eina_inlist_prepend_relative(wd->items, EINA_INLIST_GET(it),
-                                        EINA_INLIST_GET(it2));
+          eina_inlist_prepend_relative(wd->items, EINA_INLIST_GET(it),
+                                       EINA_INLIST_GET(it2));
         it->rel = it2;
         it->rel->relcount++;
      }
@@ -3146,9 +3152,9 @@
 
         wd->clear_me = EINA_TRUE;
         EINA_INLIST_FOREACH(wd->items, it)
-        {
-           it->delete_me = EINA_TRUE;
-        }
+          {
+             it->delete_me = EINA_TRUE;
+          }
         return;
      }
    while (wd->items)
@@ -3331,23 +3337,23 @@
    Eina_Bool done = EINA_FALSE;
    if (!wd) return NULL;
    EINA_INLIST_FOREACH(wd->blocks, itb)
-   {
-      if (itb->realized)
-        {
-           Eina_List *l;
-           Elm_Genlist_Item *it;
+     {
+        if (itb->realized)
+          {
+             Eina_List *l;
+             Elm_Genlist_Item *it;
 
-           done = 1;
-           EINA_LIST_FOREACH(itb->items, l, it)
-             {
-                if (it->realized) list = eina_list_append(list, it);
-             }
-        }
-      else
-        {
-           if (done) break;
-        }
-   }
+             done = 1;
+             EINA_LIST_FOREACH(itb->items, l, it)
+               {
+                  if (it->realized) list = eina_list_append(list, it);
+               }
+          }
+        else
+          {
+             if (done) break;
+          }
+     }
    return list;
 }
 
@@ -3387,34 +3393,34 @@
    evas_object_geometry_get(wd->pan_smart, &ox, &oy, &ow, &oh);
    lasty = oy;
    EINA_INLIST_FOREACH(wd->blocks, itb)
-   {
-      Eina_List *l;
-      Elm_Genlist_Item *it;
+     {
+        Eina_List *l;
+        Elm_Genlist_Item *it;
 
-      if (!ELM_RECTS_INTERSECT(ox + itb->x - itb->wd->pan_x,
-                               oy + itb->y - itb->wd->pan_y,
-                               itb->w, itb->h, x, y, 1, 1))
-        continue;
-      EINA_LIST_FOREACH(itb->items, l, it)
-        {
-           Evas_Coord itx, ity;
+        if (!ELM_RECTS_INTERSECT(ox + itb->x - itb->wd->pan_x,
+                                 oy + itb->y - itb->wd->pan_y,
+                                 itb->w, itb->h, x, y, 1, 1))
+          continue;
+        EINA_LIST_FOREACH(itb->items, l, it)
+          {
+             Evas_Coord itx, ity;
 
-           itx = ox + itb->x + it->x - itb->wd->pan_x;
-           ity = oy + itb->y + it->y - itb->wd->pan_y;
-           if (ELM_RECTS_INTERSECT(itx, ity, it->w, it->h, x, y, 1, 1))
-             {
-                if (posret)
-                  {
-                     if (y <= (ity + (it->h / 4))) *posret = -1;
-                     else if (y >= (ity + it->h - (it->h / 4)))
-                       *posret = 1;
-                     else *posret = 0;
-                  }
-                return it;
-             }
-           lasty = ity + it->h;
-        }
-   }
+             itx = ox + itb->x + it->x - itb->wd->pan_x;
+             ity = oy + itb->y + it->y - itb->wd->pan_y;
+             if (ELM_RECTS_INTERSECT(itx, ity, it->w, it->h, x, y, 1, 1))
+               {
+                  if (posret)
+                    {
+                       if (y <= (ity + (it->h / 4))) *posret = -1;
+                       else if (y >= (ity + it->h - (it->h / 4)))
+                         *posret = 1;
+                       else *posret = 0;
+                    }
+                  return it;
+               }
+             lasty = ity + it->h;
+          }
+     }
    if (posret)
      {
         if (y > lasty) *posret = 1;
@@ -3808,7 +3814,7 @@
         it->wd->show_item = NULL;
      }
    if ((it->group_item) && (it->wd->pan_y > (it->y + it->block->y)))
-      gith = it->group_item->h;
+     gith = it->group_item->h;
    elm_smart_scroller_child_region_show(it->wd->scr,
                                         it->x + it->block->x,
                                         it->y + it->block->y - gith,
@@ -3845,7 +3851,7 @@
         it->wd->show_item = NULL;
      }
    if ((it->group_item) && (it->wd->pan_y > (it->y + it->block->y)))
-      gith = it->group_item->h;
+     gith = it->group_item->h;
    elm_smart_scroller_region_bring_in(it->wd->scr,
                                       it->x + it->block->x,
                                       it->y + it->block->y - gith,
@@ -4906,3 +4912,4 @@
    if (policy_h) *policy_h = (Elm_Scroller_Policy)s_policy_h;
    if (policy_v) *policy_v = (Elm_Scroller_Policy)s_policy_v;
 }
+

Log:
Elementary elm_widget.c: Used API_ENTRY, INTERNAL_ENTRY macros. Prevented segv.
  

Author:       seoz
Date:         2011-03-22 15:12:33 -0700 (Tue, 22 Mar 2011)
New Revision: 58001
Trac:         http://trac.enlightenment.org/e/changeset/58001

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-03-22 21:44:37 UTC (rev 58000)
+++ trunk/elementary/src/lib/elm_widget.c	2011-03-22 22:12:33 UTC (rev 58001)
@@ -140,8 +140,7 @@
 {
    for (; obj; obj = elm_widget_parent_get(obj))
      {
-        Smart_Data *sd = evas_object_smart_data_get(obj);
-        if (!sd) return;
+        INTERNAL_ENTRY;
         if (!sd->focused) return;
         sd->focused = 0;
      }
@@ -152,8 +151,7 @@
 {
    for (; obj; obj = elm_widget_parent_get(obj))
      {
-        Smart_Data *sd = evas_object_smart_data_get(obj);
-        if (!sd) return;
+        INTERNAL_ENTRY;
         if (sd->focused) return;
         sd->focused = 1;
      }
@@ -201,7 +199,7 @@
 static void
 _propagate_x_drag_lock(Evas_Object *obj, int dir)
 {
-   Smart_Data *sd = evas_object_smart_data_get(obj);
+   INTERNAL_ENTRY
    if (sd->parent_obj)
      {
         Smart_Data *sd2 = evas_object_smart_data_get(sd->parent_obj);
@@ -216,7 +214,7 @@
 static void
 _propagate_y_drag_lock(Evas_Object *obj, int dir)
 {
-   Smart_Data *sd = evas_object_smart_data_get(obj);
+   INTERNAL_ENTRY
    if (sd->parent_obj)
      {
         Smart_Data *sd2 = evas_object_smart_data_get(sd->parent_obj);
@@ -2769,28 +2767,28 @@
 /* happy debug functions */
 #ifdef ELM_DEBUG
 static void
-_sub_obj_tree_dump(const Evas_Object *o, int lvl)
+_sub_obj_tree_dump(const Evas_Object *obj, int lvl)
 {
    int i;
 
    for (i = 0; i < lvl*3; i++)
      putchar(' ');
 
-   if (_elm_widget_is(o))
+   if (_elm_widget_is(obj))
      {
         Eina_List *l;
-        Smart_Data *sd = evas_object_smart_data_get(o);
-        printf("+ %s(%p)\n", sd->type, o);
+        INTERNAL_ENTRY
+        printf("+ %s(%p)\n", sd->type, obj);
         if (sd->resize_obj)
           _sub_obj_tree_dump(sd->resize_obj, lvl + 1);
-        EINA_LIST_FOREACH(sd->subobjs, l, o)
+        EINA_LIST_FOREACH(sd->subobjs, l, obj)
           {
-             if (o != sd->resize_obj)
-               _sub_obj_tree_dump(o, lvl + 1);
+             if (obj != sd->resize_obj)
+               _sub_obj_tree_dump(obj, lvl + 1);
           }
      }
    else
-     printf("+ %s(%p)\n", evas_object_type_get(o), o);
+     printf("+ %s(%p)\n", evas_object_type_get(obj), obj);
 }
 
 static void
@@ -2798,9 +2796,8 @@
 {
    if (!_elm_widget_is(obj))
      return;
+   INTERNAL_ENTRY
 
-   Smart_Data *sd = evas_object_smart_data_get(obj);
-
    Eina_Bool visible = evas_object_visible_get(obj);
    Eina_Bool disabled = elm_widget_disabled_get(obj);
    Eina_Bool focused = elm_widget_focus_get(obj);

Log:
Elementary doxygen: Fixed for the consistency with the other widget's
  document format.
  
  Patch by Jihoon Kim <jihoon48.kim@...>
  

Author:       seoz
Date:         2011-03-22 17:40:47 -0700 (Tue, 22 Mar 2011)
New Revision: 58007
Trac:         http://trac.enlightenment.org/e/changeset/58007

Modified:
  trunk/elementary/src/lib/elm_notify.c trunk/elementary/src/lib/elm_panes.c trunk/elementary/src/lib/elm_slideshow.c 

Modified: trunk/elementary/src/lib/elm_notify.c
===================================================================
--- trunk/elementary/src/lib/elm_notify.c	2011-03-23 00:18:15 UTC (rev 58006)
+++ trunk/elementary/src/lib/elm_notify.c	2011-03-23 00:40:47 UTC (rev 58007)
@@ -3,7 +3,7 @@
 
 
 /**
- * @defgroup Notify notify
+ * @defgroup Notify Notify
  *
  * Display a window in a particular region of the application (top,
  * bottom, etc.  A timeout can be set to automatically close the

Modified: trunk/elementary/src/lib/elm_panes.c
===================================================================
--- trunk/elementary/src/lib/elm_panes.c	2011-03-23 00:18:15 UTC (rev 58006)
+++ trunk/elementary/src/lib/elm_panes.c	2011-03-23 00:40:47 UTC (rev 58007)
@@ -2,7 +2,7 @@
 #include "elm_priv.h"
 
 /**
- * @defgroup Panes panes
+ * @defgroup Panes Panes
  *
  */
 
@@ -201,7 +201,7 @@
  * @param parent The parent object
  * @return The new object or NULL if it cannot be created
  *
- * @ingroup Panel
+ * @ingroup Panes
  */
 EAPI Evas_Object *
 elm_panes_add(Evas_Object *parent)

Modified: trunk/elementary/src/lib/elm_slideshow.c
===================================================================
--- trunk/elementary/src/lib/elm_slideshow.c	2011-03-23 00:18:15 UTC (rev 58006)
+++ trunk/elementary/src/lib/elm_slideshow.c	2011-03-23 00:40:47 UTC (rev 58007)
@@ -2,7 +2,7 @@
 #include "elm_priv.h"
 
 /**
- * @defgroup Slideshow slideshow
+ * @defgroup Slideshow Slideshow
  *
  * This object display a list of object (generally a list of images) and some actions like
  * next/previous are used to navigate. The animations are defined in the theme,

Log:
Elementary elm_widget.c: Modification of last change in
  elm_widget_show_region_set function.
  
  Patch by WooHyun Jung <wh0705.jung@...>
  
  

Author:       seoz
Date:         2011-03-23 00:15:01 -0700 (Wed, 23 Mar 2011)
New Revision: 58015
Trac:         http://trac.enlightenment.org/e/changeset/58015

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-03-23 03:33:55 UTC (rev 58014)
+++ trunk/elementary/src/lib/elm_widget.c	2011-03-23 07:15:01 UTC (rev 58015)
@@ -1689,10 +1689,10 @@
    do
      {
         parent_obj = sd->parent_obj;
+        child_obj = sd->obj;
         if ((!parent_obj) || (!_elm_widget_is(parent_obj))) break;
         sd = evas_object_smart_data_get(parent_obj);
         if (!sd) break;
-        child_obj = sd->obj;
 
         evas_object_geometry_get(parent_obj, &px, &py, NULL, NULL);
         evas_object_geometry_get(child_obj, &cx, &cy, NULL, NULL);

Log:
Elementary elm_transit.c: Fixed doxygen.
  

Author:       seoz
Date:         2011-03-28 06:10:25 -0700 (Mon, 28 Mar 2011)
New Revision: 58153
Trac:         http://trac.enlightenment.org/e/changeset/58153

Modified:
  trunk/elementary/src/lib/elm_transit.c 

Modified: trunk/elementary/src/lib/elm_transit.c
===================================================================
--- trunk/elementary/src/lib/elm_transit.c	2011-03-28 11:59:34 UTC (rev 58152)
+++ trunk/elementary/src/lib/elm_transit.c	2011-03-28 13:10:25 UTC (rev 58153)
@@ -564,8 +564,8 @@
  * @note When you add an object with elm_transit_object_add(), its state from
  * evas_object_pass_events_get(obj) is saved, and it is applied when the
  * transit ends, if you change this state with evas_object_pass_events_set()
- * after add the object, this state will change again when @p transit stops to
- * run.
+ * after adding the object, this state will change again when @p transit stops
+ * to run.
  *
  * @param transit The transit object.
  * @param enabled Disable or enable.

Log:
Elementary elm_colorselector.c: Fixed indentation and removed trailing
  whitespaces.
  
  Patch by Jihoon Kim <jihoon48.kim@...>
  

Author:       seoz
Date:         2011-03-28 16:58:22 -0700 (Mon, 28 Mar 2011)
New Revision: 58163
Trac:         http://trac.enlightenment.org/e/changeset/58163

Modified:
  trunk/elementary/src/lib/elm_colorselector.c 

Modified: trunk/elementary/src/lib/elm_colorselector.c
===================================================================
--- trunk/elementary/src/lib/elm_colorselector.c	2011-03-28 23:18:32 UTC (rev 58162)
+++ trunk/elementary/src/lib/elm_colorselector.c	2011-03-28 23:58:22 UTC (rev 58163)
@@ -82,7 +82,7 @@
 
 #define SIG_CHANGED "changed"
 
-static const Evas_Smart_Cb_Description _signals[] = 
+static const Evas_Smart_Cb_Description _signals[] =
 {
    {SIG_CHANGED, ""},
    {NULL, NULL}
@@ -110,27 +110,27 @@
    if ((!wd) || (!wd->base)) return;
 
    _elm_theme_object_set(obj, wd->base, "colorselector", "bg",
-			 elm_widget_style_get(obj));
+                         elm_widget_style_get(obj));
 
    for (i = 0; i < 4; i++)
      {
-	evas_object_del(wd->cp[i]->colorbar);
-	wd->cp[i]->colorbar = NULL;
-	evas_object_del(wd->cp[i]->bar);
-	wd->cp[i]->bar = NULL;
-	evas_object_del(wd->cp[i]->lbt);
-	wd->cp[i]->lbt = NULL;
-	evas_object_del(wd->cp[i]->rbt);
-	wd->cp[i]->rbt = NULL;
-	if (i != 0)
-	  {
-	     evas_object_del(wd->cp[i]->bg_rect);
-	     wd->cp[i]->bg_rect = NULL;
-	  }
-	evas_object_del(wd->cp[i]->arrow);
-	wd->cp[i]->arrow = NULL;
-	evas_object_del(wd->cp[i]->touch_area);
-	wd->cp[i]->touch_area = NULL;
+        evas_object_del(wd->cp[i]->colorbar);
+        wd->cp[i]->colorbar = NULL;
+        evas_object_del(wd->cp[i]->bar);
+        wd->cp[i]->bar = NULL;
+        evas_object_del(wd->cp[i]->lbt);
+        wd->cp[i]->lbt = NULL;
+        evas_object_del(wd->cp[i]->rbt);
+        wd->cp[i]->rbt = NULL;
+        if (i != 0)
+          {
+             evas_object_del(wd->cp[i]->bg_rect);
+             wd->cp[i]->bg_rect = NULL;
+          }
+        evas_object_del(wd->cp[i]->arrow);
+        wd->cp[i]->arrow = NULL;
+        evas_object_del(wd->cp[i]->touch_area);
+        wd->cp[i]->touch_area = NULL;
      }
 
    _add_colorbar(obj);
@@ -161,13 +161,12 @@
    for (i = 0; i < 4; i++)
      {
         if (wd->cp[i]->bg_rect)
-             _colorselector_set_size_hints(wd->cp[i]->bg_rect, 1, 1);
+          _colorselector_set_size_hints(wd->cp[i]->bg_rect, 1, 1);
         _colorselector_set_size_hints(wd->cp[i]->bar, 1, 1);
         _colorselector_set_size_hints(wd->cp[i]->rbt, 1, 1);
         _colorselector_set_size_hints(wd->cp[i]->lbt, 1, 1);
 
         _colorselector_set_size_hints(wd->cp[i]->colorbar, 4, 1);
-
      }
 
    elm_coords_finger_size_adjust(4, &minw, 4, &minh);
@@ -239,26 +238,26 @@
    if (_s == 0.0) r = g = b = _l;
    else
      {
-	if (_h == 360.0) _h = 0.0;
-	_h /= 60.0;
-        
-	v = (_l <= 0.5) ? (_l * (1.0 + _s)) : (_l + _s - (_l * _s));
-	p = _l + _l - v;
+        if (_h == 360.0) _h = 0.0;
+        _h /= 60.0;
 
-	if (v) sv = (v - p) / v;
-	else sv = 0;
+        v = (_l <= 0.5) ? (_l * (1.0 + _s)) : (_l + _s - (_l * _s));
+        p = _l + _l - v;
 
-	i = (int)_h;
-	f = _h - i;
+        if (v) sv = (v - p) / v;
+        else sv = 0;
 
-	vsf = v * sv * f;
+        i = (int)_h;
+        f = _h - i;
 
-	t = p + vsf;
-	q = v - vsf;
+        vsf = v * sv * f;
 
-	switch (i)
-	  {
-          case 0:
+        t = p + vsf;
+        q = v - vsf;
+
+        switch (i)
+          {
+           case 0:
              r = v;
              g = t;
              b = p;
@@ -288,7 +287,7 @@
              g = p;
              b = q;
              break;
-	  }
+          }
      }
    i = (int)(r * 255.0);
    f = (r * 255.0) - i;
@@ -308,12 +307,20 @@
 {
    Widget_Data *wd = data;
 
-   if (wd->er > 127) wd->sr = 127 + (int)((double)(wd->er - 127) * wd->s);
-   else wd->sr = 127 - (int)((double)(127 - wd->er) * wd->s);
-   if (wd->eg > 127) wd->sg = 127 + (int)((double)(wd->eg - 127) * wd->s);
-   else wd->sg = 127 - (int)((double)(127 - wd->eg) * wd->s);
-   if (wd->eb > 127) wd->sb = 127 + (int)((double)(wd->eb - 127) * wd->s);
-   else wd->sb = 127 - (int)((double)(127 - wd->eb) * wd->s);
+   if (wd->er > 127)
+     wd->sr = 127 + (int)((double)(wd->er - 127) * wd->s);
+   else
+     wd->sr = 127 - (int)((double)(127 - wd->er) * wd->s);
+
+   if (wd->eg > 127)
+     wd->sg = 127 + (int)((double)(wd->eg - 127) * wd->s);
+   else
+     wd->sg = 127 - (int)((double)(127 - wd->eg) * wd->s);
+
+   if (wd->eb > 127)
+     wd->sb = 127 + (int)((double)(wd->eb - 127) * wd->s);
+   else
+     wd->sb = 127 - (int)((double)(127 - wd->eb) * wd->s);
 }
 
 static void
@@ -323,21 +330,21 @@
 
    if (wd->l > 0.5)
      {
-	wd->lr = wd->er + (int)((double)(255 - wd->er) * (wd->l - 0.5) * 2.0);
-	wd->lg = wd->eg + (int)((double)(255 - wd->eg) * (wd->l - 0.5) * 2.0);
-	wd->lb = wd->eb + (int)((double)(255 - wd->eb) * (wd->l - 0.5) * 2.0);
+        wd->lr = wd->er + (int)((double)(255 - wd->er) * (wd->l - 0.5) * 2.0);
+        wd->lg = wd->eg + (int)((double)(255 - wd->eg) * (wd->l - 0.5) * 2.0);
+        wd->lb = wd->eb + (int)((double)(255 - wd->eb) * (wd->l - 0.5) * 2.0);
      }
    else if (wd->l < 0.5)
      {
-	wd->lr = (double)wd->er * wd->l * 2.0;
-	wd->lg = (double)wd->eg * wd->l * 2.0;
-	wd->lb = (double)wd->eb * wd->l * 2.0;
+        wd->lr = (double)wd->er * wd->l * 2.0;
+        wd->lg = (double)wd->eg * wd->l * 2.0;
+        wd->lb = (double)wd->eb * wd->l * 2.0;
      }
    else
      {
-	wd->lr = wd->er;
-	wd->lg = wd->eg;
-	wd->lb = wd->eb;
+        wd->lr = wd->er;
+        wd->lg = wd->eg;
+        wd->lb = wd->eb;
      }
 }
 
@@ -352,7 +359,7 @@
      {
      case HUE:
         wd->h = 360.0 * x;
-        
+
         if (x < one_six)
           {
              wd->er = 255;
@@ -389,42 +396,38 @@
              wd->eg = 0;
              wd->eb = 255 - (int)(255.0 * (x - (5.0 * one_six)) * 6.0);
           }
-        
+
         evas_object_color_set(wd->cp[0]->arrow, wd->er, wd->eg, wd->eb, 255);
         evas_object_color_set(wd->cp[1]->bg_rect, wd->er, wd->eg, wd->eb, 255);
         evas_object_color_set(wd->cp[2]->bg_rect, wd->er, wd->eg, wd->eb, 255);
         evas_object_color_set(wd->cp[3]->bar, wd->er, wd->eg, wd->eb, 255);
-        
+
         _color_with_saturation(wd);
         evas_object_color_set(wd->cp[1]->arrow, wd->sr, wd->sg, wd->sb, 255);
-        
+
         _color_with_lightness(wd);
         evas_object_color_set(wd->cp[2]->arrow, wd->lr, wd->lg, wd->lb, 255);
-        
-        evas_object_color_set(wd->cp[3]->arrow, 
+
+        evas_object_color_set(wd->cp[3]->arrow,
                               (wd->er * wd->a) / 255,
-                              (wd->eg * wd->a) / 255, 
+                              (wd->eg * wd->a) / 255,
                               (wd->eb * wd->a) / 255,
                               wd->a);
         break;
-        
      case SATURATION:
         wd->s = 1.0 - x;
         _color_with_saturation(wd);
         evas_object_color_set(wd->cp[1]->arrow, wd->sr, wd->sg, wd->sb, 255);
         break;
-        
      case LIGHTNESS:
         wd->l = x;
         _color_with_lightness(wd);
         evas_object_color_set(wd->cp[2]->arrow, wd->lr, wd->lg, wd->lb, 255);
         break;
-        
      case ALPHA:
         wd->a = 255.0 * x;
         evas_object_color_set(wd->cp[3]->arrow, wd->er, wd->eg, wd->eb, wd->a);
         break;
-        
      default:
         break;
      }
@@ -475,21 +478,21 @@
    edje_object_part_drag_value_get(cp->colorbar, "elm.arrow", &x, &y);
    if (cp->button_state == L_BUTTON_PRESSED)
      {
-	x -= 1.0 / BASE_STEP;
-	if (x < 0.0) x = 0.0;
-	edje_object_part_drag_value_set(cp->colorbar, "elm.arrow", x, y);
-	_draw_rects(data, x);
-	evas_object_smart_callback_call(cp->parent, SIG_CHANGED, NULL);
-	return EINA_TRUE;
+        x -= 1.0 / BASE_STEP;
+        if (x < 0.0) x = 0.0;
+        edje_object_part_drag_value_set(cp->colorbar, "elm.arrow", x, y);
+        _draw_rects(data, x);
+        evas_object_smart_callback_call(cp->parent, SIG_CHANGED, NULL);
+        return EINA_TRUE;
      }
    else if (cp->button_state == R_BUTTON_PRESSED)
      {
-	x += 1.0 / BASE_STEP;
-	if (x > 1.0) x = 1.0;
-	edje_object_part_drag_value_set(cp->colorbar, "elm.arrow", x, y);
-	_draw_rects(data, x);
-	evas_object_smart_callback_call(cp->parent, SIG_CHANGED, NULL);
-	return EINA_TRUE;
+        x += 1.0 / BASE_STEP;
+        if (x > 1.0) x = 1.0;
+        edje_object_part_drag_value_set(cp->colorbar, "elm.arrow", x, y);
+        _draw_rects(data, x);
+        evas_object_smart_callback_call(cp->parent, SIG_CHANGED, NULL);
+        return EINA_TRUE;
      }
    wd->mv_timer = NULL;
    return EINA_FALSE;
@@ -500,7 +503,7 @@
 {
    Colorselector_Data *cp = data;
    Widget_Data *wd = elm_widget_data_get(cp->parent);
-   
+
    if (wd->mv_timer) ecore_timer_del(wd->mv_timer);
    wd->mv_timer = ecore_timer_add(0.01, _mv_timer, cp);
 
@@ -516,7 +519,7 @@
    double x, y;
 
    edje_object_signal_emit(cp->lbt, "elm,state,left,button,down",
-			   "left_button");
+                           "left_button");
    edje_object_part_drag_value_get(cp->colorbar, "elm.arrow", &x, &y);
 
    switch(cp->color_type)
@@ -533,8 +536,8 @@
       case ALPHA :
          x -= 1.0 / ALP_STEP;
          break;
-      default : 
-         break;         
+      default :
+         break;
      }
 
    if (x < 0.0) x = 0.0;
@@ -555,7 +558,7 @@
    double x, y;
 
    edje_object_signal_emit(cp->rbt, "elm,state,right,button,down",
-			   "right_button");
+                           "right_button");
    edje_object_part_drag_value_get(cp->colorbar, "elm.arrow", &x, &y);
 
    switch(cp->color_type)
@@ -572,8 +575,8 @@
       case ALPHA :
          x += 1.0 / ALP_STEP;
          break;
-      default : 
-         break;         
+      default :
+         break;
      }
 
    if (x > 1.0) x = 1.0;
@@ -593,13 +596,13 @@
 
    if (wd->lp_timer)
      {
-	ecore_timer_del(wd->lp_timer);
-	wd->lp_timer = NULL;
+        ecore_timer_del(wd->lp_timer);
+        wd->lp_timer = NULL;
      }
    if (wd->mv_timer)
      {
-	ecore_timer_del(wd->mv_timer);
-	wd->mv_timer = NULL;
+        ecore_timer_del(wd->mv_timer);
+        wd->mv_timer = NULL;
      }
 
    cp->button_state = BUTTON_RELEASED;
@@ -614,18 +617,18 @@
 
    if (wd->lp_timer)
      {
-	ecore_timer_del(wd->lp_timer);
-	wd->lp_timer = NULL;
+        ecore_timer_del(wd->lp_timer);
+        wd->lp_timer = NULL;
      }
    if (wd->mv_timer)
      {
-	ecore_timer_del(wd->mv_timer);
-	wd->mv_timer = NULL;
+        ecore_timer_del(wd->mv_timer);
+        wd->mv_timer = NULL;
      }
 
    cp->button_state = BUTTON_RELEASED;
    edje_object_signal_emit(cp->rbt, "elm,state,right,button,up",
-			   "right_button");
+                           "right_button");
 }
 
 static void
@@ -644,8 +647,8 @@
 
    for (i = 0; i < 4; i++)
      {
-	wd->cp[i] = ELM_NEW(Colorselector_Data);
-	wd->cp[i]->parent = obj;
+        wd->cp[i] = ELM_NEW(Colorselector_Data);
+        wd->cp[i]->parent = obj;
         switch(i)
           {
            case 0 :
@@ -660,51 +663,51 @@
            case 3 :
               wd->cp[i]->color_type = ALPHA;
               break;
-           default : 
-              break;         
+           default :
+              break;
           }
         /* load colorbar area */
-	wd->cp[i]->colorbar = edje_object_add(e);
-	_elm_theme_object_set(obj, wd->cp[i]->colorbar, "colorselector", "base",
-			      "default");
-	snprintf(colorbar_name, sizeof(colorbar_name), "colorbar_%d", i);
-	snprintf(colorbar_s, sizeof(colorbar_s), "elm.colorbar_%d", i);
-	edje_object_signal_callback_add(wd->cp[i]->colorbar, "drag", "*",
-					_arrow_cb, wd->cp[i]);
-	edje_object_part_swallow(wd->base, colorbar_s, wd->cp[i]->colorbar);
-	elm_widget_sub_object_add(obj, wd->cp[i]->colorbar);
+        wd->cp[i]->colorbar = edje_object_add(e);
+        _elm_theme_object_set(obj, wd->cp[i]->colorbar, "colorselector", "base",
+                              "default");
+        snprintf(colorbar_name, sizeof(colorbar_name), "colorbar_%d", i);
+        snprintf(colorbar_s, sizeof(colorbar_s), "elm.colorbar_%d", i);
+        edje_object_signal_callback_add(wd->cp[i]->colorbar, "drag", "*",
+                                        _arrow_cb, wd->cp[i]);
+        edje_object_part_swallow(wd->base, colorbar_s, wd->cp[i]->colorbar);
+        elm_widget_sub_object_add(obj, wd->cp[i]->colorbar);
 
-	/* load colorbar image */
-	wd->cp[i]->bar = edje_object_add(e);
-	_elm_theme_object_set(obj, wd->cp[i]->bar, "colorselector", "image",
-			      colorbar_name);
-	edje_object_part_swallow(wd->cp[i]->colorbar, "elm.bar",
+        /* load colorbar image */
+        wd->cp[i]->bar = edje_object_add(e);
+        _elm_theme_object_set(obj, wd->cp[i]->bar, "colorselector", "image",
+                              colorbar_name);
+        edje_object_part_swallow(wd->cp[i]->colorbar, "elm.bar",
                                  wd->cp[i]->bar);
-	elm_widget_sub_object_add(obj, wd->cp[i]->bar);
+        elm_widget_sub_object_add(obj, wd->cp[i]->bar);
 
-	/* provide expanded touch area */
-	wd->cp[i]->touch_area = evas_object_rectangle_add(e);
-	evas_object_color_set(wd->cp[i]->touch_area, 0, 0, 0, 0);
-	edje_object_part_swallow(wd->cp[i]->colorbar, "elm.arrow_bg",
-				 wd->cp[i]->touch_area);
-	evas_object_event_callback_add(wd->cp[i]->touch_area,
-				       EVAS_CALLBACK_MOUSE_DOWN, _colorbar_cb,
-				       wd->cp[i]);
-	elm_widget_sub_object_add(obj, wd->cp[i]->touch_area);
+        /* provide expanded touch area */
+        wd->cp[i]->touch_area = evas_object_rectangle_add(e);
+        evas_object_color_set(wd->cp[i]->touch_area, 0, 0, 0, 0);
+        edje_object_part_swallow(wd->cp[i]->colorbar, "elm.arrow_bg",
+                                 wd->cp[i]->touch_area);
+        evas_object_event_callback_add(wd->cp[i]->touch_area,
+                                       EVAS_CALLBACK_MOUSE_DOWN, _colorbar_cb,
+                                       wd->cp[i]);
+        elm_widget_sub_object_add(obj, wd->cp[i]->touch_area);
 
-	/* load background rectangle of the colorbar. used for
-	   changing color of the opacity bar */
-	if ((i == 1) || (i == 2))
-	  {
-	     wd->cp[i]->bg_rect = evas_object_rectangle_add(e);
+        /* load background rectangle of the colorbar. used for
+           changing color of the opacity bar */
+        if ((i == 1) || (i == 2))
+          {
+             wd->cp[i]->bg_rect = evas_object_rectangle_add(e);
              evas_object_color_set(wd->cp[i]->bg_rect, wd->er, wd->eg, wd->eb,
                                    255);
-	     edje_object_part_swallow(wd->cp[i]->colorbar, "elm.bar_bg",
-				      wd->cp[i]->bg_rect);
+             edje_object_part_swallow(wd->cp[i]->colorbar, "elm.bar_bg",
+                                      wd->cp[i]->bg_rect);
 
-	     elm_widget_sub_object_add(obj, wd->cp[i]->bg_rect);
-	  }
-	if (i == 3)
+             elm_widget_sub_object_add(obj, wd->cp[i]->bg_rect);
+          }
+        if (i == 3)
           {
              wd->cp[i]->bg_rect = edje_object_add(e);
              _elm_theme_object_set(obj, wd->cp[i]->bg_rect, "colorselector",
@@ -714,42 +717,41 @@
              elm_widget_sub_object_add(obj, wd->cp[i]->bg_rect);
              evas_object_color_set(wd->cp[i]->bar, wd->er, wd->eg, wd->eb, 255);
           }
-	/* load arrow image, pointing the colorbar */
-	wd->cp[i]->arrow = edje_object_add(e);
-	_elm_theme_object_set(obj, wd->cp[i]->arrow, "colorselector", "image",
-			      "updown");
-	edje_object_part_swallow(wd->cp[i]->colorbar, "elm.arrow_icon",
-				 wd->cp[i]->arrow);
-	elm_widget_sub_object_add(obj, wd->cp[i]->arrow);
-	if (i == 2)
-	  evas_object_color_set(wd->cp[i]->arrow, 0, 0, 0, 255);
-	else
-	  evas_object_color_set(wd->cp[i]->arrow, wd->er, wd->eg, wd->eb, 255);
+        /* load arrow image, pointing the colorbar */
+        wd->cp[i]->arrow = edje_object_add(e);
+        _elm_theme_object_set(obj, wd->cp[i]->arrow, "colorselector", "image",
+                              "updown");
+        edje_object_part_swallow(wd->cp[i]->colorbar, "elm.arrow_icon",
+                                 wd->cp[i]->arrow);
+        elm_widget_sub_object_add(obj, wd->cp[i]->arrow);
+        if (i == 2)
+          evas_object_color_set(wd->cp[i]->arrow, 0, 0, 0, 255);
+        else
+          evas_object_color_set(wd->cp[i]->arrow, wd->er, wd->eg, wd->eb, 255);
 
-	/* load left button */
-	wd->cp[i]->lbt = edje_object_add(e);
-	_elm_theme_object_set(obj, wd->cp[i]->lbt, "colorselector", "button",
-			      "left");
-	evas_object_event_callback_add(wd->cp[i]->lbt, EVAS_CALLBACK_MOUSE_DOWN,
-				       _left_button_down_cb, wd->cp[i]);
-	evas_object_event_callback_add(wd->cp[i]->lbt, EVAS_CALLBACK_MOUSE_UP,
-				       _left_button_up_cb, wd->cp[i]);
-	edje_object_part_swallow(wd->cp[i]->colorbar, "elm.l_button",
-				 wd->cp[i]->lbt);
-	elm_widget_sub_object_add(obj, wd->cp[i]->lbt);
+        /* load left button */
+        wd->cp[i]->lbt = edje_object_add(e);
+        _elm_theme_object_set(obj, wd->cp[i]->lbt, "colorselector", "button",
+                              "left");
+        evas_object_event_callback_add(wd->cp[i]->lbt, EVAS_CALLBACK_MOUSE_DOWN,
+                                       _left_button_down_cb, wd->cp[i]);
+        evas_object_event_callback_add(wd->cp[i]->lbt, EVAS_CALLBACK_MOUSE_UP,
+                                       _left_button_up_cb, wd->cp[i]);
+        edje_object_part_swallow(wd->cp[i]->colorbar, "elm.l_button",
+                                 wd->cp[i]->lbt);
+        elm_widget_sub_object_add(obj, wd->cp[i]->lbt);
 
-	/* load right button */
-	wd->cp[i]->rbt = edje_object_add(e);
-	_elm_theme_object_set(obj, wd->cp[i]->rbt, "colorselector", "button",
-			      "right");
-	evas_object_event_callback_add(wd->cp[i]->rbt, EVAS_CALLBACK_MOUSE_DOWN,
-				       _right_button_down_cb, wd->cp[i]);
-	evas_object_event_callback_add(wd->cp[i]->rbt, EVAS_CALLBACK_MOUSE_UP,
-				       _right_button_up_cb, wd->cp[i]);
-	edje_object_part_swallow(wd->cp[i]->colorbar, "elm.r_button",
-				 wd->cp[i]->rbt);
-	elm_widget_sub_object_add(obj, wd->cp[i]->rbt);
-
+        /* load right button */
+        wd->cp[i]->rbt = edje_object_add(e);
+        _elm_theme_object_set(obj, wd->cp[i]->rbt, "colorselector", "button",
+                              "right");
+        evas_object_event_callback_add(wd->cp[i]->rbt, EVAS_CALLBACK_MOUSE_DOWN,
+                                       _right_button_down_cb, wd->cp[i]);
+        evas_object_event_callback_add(wd->cp[i]->rbt, EVAS_CALLBACK_MOUSE_UP,
+                                       _right_button_up_cb, wd->cp[i]);
+        edje_object_part_swallow(wd->cp[i]->colorbar, "elm.r_button",
+                                 wd->cp[i]->rbt);
+        elm_widget_sub_object_add(obj, wd->cp[i]->rbt);
      }
 }
 
@@ -839,11 +841,11 @@
 /**
  * Set a color for the colorselector
  *
- * @param obj	Colorselector object
- * @param r	r-value of color
- * @param g	g-value of color
- * @param b	b-value of color
- * @param a	a-value of color
+ * @param obj   Colorselector object
+ * @param r     r-value of color
+ * @param g     g-value of color
+ * @param b     b-value of color
+ * @param a     a-value of color
  *
  * @ingroup Colorselector
  */
@@ -857,11 +859,11 @@
 /**
  * Get a color from the colorselector
  *
- * @param obj	Colorselector object
- * @param r	integer pointer for r-value of color
- * @param g	integer pointer for g-value of color
- * @param b	integer pointer for b-value of color
- * @param a	integer pointer for a-value of color
+ * @param obj   Colorselector object
+ * @param r     integer pointer for r-value of color
+ * @param g     integer pointer for g-value of color
+ * @param b     integer pointer for b-value of color
+ * @param a     integer pointer for a-value of color
  *
  * @ingroup Colorselector
  */

Log:
Elementary elm_genlist.c: Replaced unicode to ascii in genlist doxygen.
  

Author:       seoz
Date:         2011-03-29 03:38:51 -0700 (Tue, 29 Mar 2011)
New Revision: 58176
Trac:         http://trac.enlightenment.org/e/changeset/58176

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-03-29 09:46:35 UTC (rev 58175)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-03-29 10:38:51 UTC (rev 58176)
@@ -141,11 +141,11 @@
  * details.
  *
  * An item in the genlist world can have 0 or more text labels (they can be
- * regular text or textblock – that's up to the style to determine), 0 or
+ * regular text or textblock - that's up to the style to determine), 0 or
  * more icons (which are simply objects swallowed into the genlist item) and
  * 0 or more boolean states that can be used for check, radio or other
  * indicators by the edje theme style. An item may be one of several styles
- * (Elementary provides 4 by default - “default”, “double_label”, "group_index"
+ * (Elementary provides 4 by default - "default", "double_label", "group_index"
  * and "icon_top_text_bottom", but this can be extended by system or
  * application custom themes/overlays/extensions).
  *
@@ -154,12 +154,12 @@
  * a structure with information about that type of item (genlist may contain
  * multiple different items with different classes, states and styles).
  * Genlist will call the functions in this struct (methods) when an item is
- * “realized” (that is created dynamically while scrolling). All objects will
+ * "realized" (that is created dynamically while scrolling). All objects will
  * simply be deleted  when no longer needed with evas_object_del(). The
  * Elm_Genlist_Item_Class structure contains the following members:
  *
  * item_style - This is a constant string and simply defines the name of the
- * item style. It must be specified and the default should be “default”.
+ * item style. It must be specified and the default should be "default".
  *
  * func.label_get - This function is called when an actual item object is
  * created. The data parameter is the data parameter passed to
@@ -184,7 +184,7 @@
  * parameter is the genlist object and the part parameter is the string name
  * of the state part in the edje design that is listed as one of the possible
  * states that can be set. Return 0 for false or 1 for true. Genlist will
- * emit a signal to the edje object with “elm,state,XXX,active” “elm” when
+ * emit a signal to the edje object with "elm,state,XXX,active" "elm" when
  * true (the default is false), where XXX is the name of the part.
  *
  * func.del - This is called when elm_genlist_item_del() is called on an
@@ -266,7 +266,7 @@
  * viewport of the scroller. If it is ELM_LIST_LIMIT, items will be expanded
  * to the viewport width and limited to that size. This can be combined with
  * a different style that uses edjes' ellipsis feature (cutting text off like
- * this: “tex...”).
+ * this: "tex...").
  *
  * Items will only call their selection func and callback when first becoming
  * selected. Any further clicks will do nothing, unless you enable always

Log:
Elementary elm_genlist.c: Code refactoring and indentation fix.
  

Author:       seoz
Date:         2011-03-29 05:43:03 -0700 (Tue, 29 Mar 2011)
New Revision: 58178
Trac:         http://trac.enlightenment.org/e/changeset/58178

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-03-29 11:56:51 UTC (rev 58177)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-03-29 12:43:03 UTC (rev 58178)
@@ -1753,18 +1753,20 @@
    if ((calc) && (it->wd->homogeneous) && ((it->wd->item_width) || ((it->wd->item_width) && (it->wd->group_item_width))))
      {
         /* homogenous genlist shortcut */
-         if ((it->flags & ELM_GENLIST_ITEM_GROUP) && (!it->mincalcd))
-           {
-              it->w = it->minw = it->wd->group_item_width;
-              it->h = it->minh = it->wd->group_item_height;
-              it->mincalcd = EINA_TRUE;
-           }
-         else if (!it->mincalcd)
-           {
-              it->w = it->minw = it->wd->item_width;
-              it->h = it->minh = it->wd->item_height;
-              it->mincalcd = EINA_TRUE;
-           }
+        if (!it->mincalcd)
+          {
+             if (it->flags & ELM_GENLIST_ITEM_GROUP)
+               {
+                  it->w = it->minw = it->wd->group_item_width;
+                  it->h = it->minh = it->wd->group_item_height;
+               }
+             else
+               {
+                  it->w = it->minw = it->wd->item_width;
+                  it->h = it->minh = it->wd->item_height;
+               }
+             it->mincalcd = EINA_TRUE;
+          }
      }
    else
      {

Log:
Elementary elm_genlist.c: Indentation fix by manual.
  
  Ecrustify indentation needs to be fixed for the lines behind comments.
  

Author:       seoz
Date:         2011-03-29 18:35:15 -0700 (Tue, 29 Mar 2011)
New Revision: 58191
Trac:         http://trac.enlightenment.org/e/changeset/58191

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-03-29 19:14:39 UTC (rev 58190)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-03-30 01:35:15 UTC (rev 58191)
@@ -2907,8 +2907,8 @@
         //xxx
         //printf("PROCESS TIME: %3.3f\n", ecore_time_get() - q_start);
         //xxx
-              wd->queue_idler = NULL;
-              return ECORE_CALLBACK_CANCEL;
+        wd->queue_idler = NULL;
+        return ECORE_CALLBACK_CANCEL;
      }
    return ECORE_CALLBACK_RENEW;
 }

Log:
Elementary elm_widget.h: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-04-01 01:05:24 -0700 (Fri, 01 Apr 2011)
New Revision: 58246
Trac:         http://trac.enlightenment.org/e/changeset/58246

Modified:
  trunk/elementary/src/lib/elm_widget.h 

Modified: trunk/elementary/src/lib/elm_widget.h
===================================================================
--- trunk/elementary/src/lib/elm_widget.h	2011-04-01 06:26:58 UTC (rev 58245)
+++ trunk/elementary/src/lib/elm_widget.h	2011-04-01 08:05:24 UTC (rev 58246)
@@ -5,33 +5,33 @@
  * CODE. THIS IS ELEMENTARY'S INTERNAL WIDGET API (for now) AND IS NOT
  * FINAL. CALL elm_widget_api_check(ELM_INTERNAL_API_VERSION) TO CHECK IT
  * AT RUNTIME
- * 
+ *
  * How to make your own widget? like this:
- * 
+ *
  * #include <Elementary.h>
  * #include "elm_priv.h"
- * 
+ *
  * typedef struct _Widget_Data Widget_Data;
- *    
+ *
  * struct _Widget_Data
  * {
  *   Evas_Object *sub;
  *   // add any other widget data here too
  * };
- * 
+ *
  * static const char *widtype = NULL;
  * static void _del_hook(Evas_Object *obj);
  * static void _theme_hook(Evas_Object *obj);
  * static void _disable_hook(Evas_Object *obj);
  * static void _sizing_eval(Evas_Object *obj);
  * static void _on_focus_hook(void *data, Evas_Object *obj);
- * 
+ *
  * static const char SIG_CLICKED[] = "clicked";
  * static const Evas_Smart_Cb_Description _signals[] = {
  *   {SIG_CLICKED, ""},
  *   {NULL, NULL}
  * };
- * 
+ *
  * static void
  * _del_hook(Evas_Object *obj)
  * {
@@ -40,7 +40,7 @@
  *    // delete hook - on delete of object delete object struct etc.
  *    free(wd);
  * }
- * 
+ *
  * static void
  * _on_focus_hook(void *data __UNUSED__, Evas_Object *obj)
  * {
@@ -59,17 +59,17 @@
  *         evas_object_focus_set(wd->sub, EINA_FALSE);
  *      }
  * }
- * 
+ *
  * static void
  * _theme_hook(Evas_Object *obj)
  * {
  *    Widget_Data *wd = elm_widget_data_get(obj);
  *    if (!wd) return;
  *    // handle change in theme/scale etc.
- *    elm_widget_theme_object_set(obj, wd->sub, "mywidget", "base", 
+ *    elm_widget_theme_object_set(obj, wd->sub, "mywidget", "base",
  *                                elm_widget_style_get(obj));
  * }
- * 
+ *
  * static void
  * _disable_hook(Evas_Object *obj)
  * {
@@ -81,7 +81,7 @@
  *    else
  *      edje_object_signal_emit(wd->sub, "elm,state,enabled", "elm");
  * }
- * 
+ *
  * static void
  * _sizing_eval(Evas_Object *obj)
  * {
@@ -94,7 +94,7 @@
  *    evas_object_size_hint_min_set(obj, minw, minh);
  *    evas_object_size_hint_max_set(obj, maxw, maxh);
  * }
- * 
+ *
  * // actual api to create your widget. add more to manipulate it as needed
  * // mark your calls with EAPI to make them "external api" calls.
  * EAPI Evas_Object *
@@ -103,7 +103,7 @@
  *    Evas_Object *obj;
  *    Evas *e;
  *    Widget_Data *wd;
- * 
+ *
  *    // ALWAYS call this - this checks that your widget matches that of
  *    // elementary and that the api hasn't broken. if it has this returns
  *    // false and you need to handle this error gracefully
@@ -111,7 +111,7 @@
  *
  *    // standard widget setup and allocate wd, create obj given parent etc.
  *    ELM_WIDGET_STANDARD_SETUP(wd, Widget_Data, parent, e, obj, NULL);
- * 
+ *
  *    // give it a type name and set up a mywidget type string if needed
  *    ELM_SET_WIDTYPE(widtype, "mywidget");
  *    elm_widget_type_set(obj, "mywidget");
@@ -125,7 +125,7 @@
  *    elm_widget_disable_hook_set(obj, _disable_hook);
  *    // this widget can focus (true means yes it can, false means it can't)
  *    elm_widget_can_focus_set(obj, EINA_TRUE);
- * 
+ *
  *    // for this widget we will add 1 sub object that is an edje object
  *    wd->sub = edje_object_add(e);
  *    // set the theme. this follows a scheme for group name like this:
@@ -143,17 +143,17 @@
  *    // set this sub object as the "resize object". widgets get 1 resize
  *    // object that is resized along with the object wrapper.
  *    elm_widget_resize_object_set(obj, wd->sub);
- * 
+ *
  *    // evaluate sizing of the widget (minimum size calc etc.). optional but
  *    // not a bad idea to do here. it will get queued for later anyway
  *    _sizing_eval(obj);
- * 
+ *
  *    // register the smart callback descriptions so we can have some runtime
  *    // info as to what the smart callback strings mean
  *    evas_object_smart_callbacks_descriptions_set(obj, _signals);
  *    return obj;
  * }
- * 
+ *
  * // example - do "whatever" to the widget (here just emit a signal)
  * EAPI void
  * elm_mywidget_whatever(Evas_Object *obj)
@@ -166,11 +166,11 @@
  *    // do whatever you like
  *    edje_object_signal_emit(wd->sub, "elm,state,action,whatever", "elm");
  * }
- * 
+ *
  * // you can add more - you need to see elementary's code to know how to
  * // handle all cases. remember this api is not stable and may change. it's
  * // internal
- * 
+ *
  */
 
 #ifndef ELM_INTERNAL_API_ARGESFSDFEFC
@@ -197,7 +197,7 @@
    /* ef1 ~~ efl, el3 ~~ elm */
 #define ELM_WIDGET_ITEM_MAGIC 0xef1e1301
    EINA_MAGIC;
-   
+
    Evas_Object   *widget; /**< the owner widget that owns this item */
    Evas_Object   *view; /**< the base view object */
    const void    *data; /**< item specific data */

Log:
Elementary elm_genlist.c: Fixed formatting.
  
  Used ecrustify for formatting.
  

Author:       seoz
Date:         2011-04-01 09:33:58 -0700 (Fri, 01 Apr 2011)
New Revision: 58263
Trac:         http://trac.enlightenment.org/e/changeset/58263

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-01 16:09:48 UTC (rev 58262)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-01 16:33:58 UTC (rev 58263)
@@ -369,53 +369,53 @@
    Elm_Genlist_Item             *group_item;
    Elm_Genlist_Item_Flags        flags;
    struct
-     {
-        Evas_Smart_Cb func;
-        const void   *data;
-     } func;
+   {
+      Evas_Smart_Cb func;
+      const void   *data;
+   } func;
 
-   Evas_Object      *spacer;
-   Eina_List        *labels, *icons, *states, *icon_objs;
-   Ecore_Timer      *long_timer;
-   Ecore_Timer      *swipe_timer;
-   Evas_Coord        dx, dy;
-   Evas_Coord        scrl_x, scrl_y;
+   Evas_Object                  *spacer;
+   Eina_List                    *labels, *icons, *states, *icon_objs;
+   Ecore_Timer                  *long_timer;
+   Ecore_Timer                  *swipe_timer;
+   Evas_Coord                    dx, dy;
+   Evas_Coord                    scrl_x, scrl_y;
 
-   Elm_Genlist_Item *rel;
+   Elm_Genlist_Item             *rel;
 
    struct
-     {
-        const void                 *data;
-        Elm_Tooltip_Item_Content_Cb content_cb;
-        Evas_Smart_Cb               del_cb;
-        const char                 *style;
-     } tooltip;
+   {
+      const void                 *data;
+      Elm_Tooltip_Item_Content_Cb content_cb;
+      Evas_Smart_Cb               del_cb;
+      const char                 *style;
+   } tooltip;
 
-   const char *mouse_cursor;
+   const char                   *mouse_cursor;
 
-   int         relcount;
-   int         walking;
-   int         expanded_depth;
-   int         order_num_in;
+   int                           relcount;
+   int                           walking;
+   int                           expanded_depth;
+   int                           order_num_in;
 
-   Eina_Bool   before : 1;
+   Eina_Bool                     before : 1;
 
-   Eina_Bool   want_unrealize : 1;
-   Eina_Bool   want_realize : 1;
-   Eina_Bool   realized : 1;
-   Eina_Bool   selected : 1;
-   Eina_Bool   highlighted : 1;
-   Eina_Bool   expanded : 1;
-   Eina_Bool   disabled : 1;
-   Eina_Bool   display_only : 1;
-   Eina_Bool   mincalcd : 1;
-   Eina_Bool   queued : 1;
-   Eina_Bool   showme : 1;
-   Eina_Bool   delete_me : 1;
-   Eina_Bool   down : 1;
-   Eina_Bool   dragging : 1;
-   Eina_Bool   updateme : 1;
-   Eina_Bool   nocache : 1;
+   Eina_Bool                     want_unrealize : 1;
+   Eina_Bool                     want_realize : 1;
+   Eina_Bool                     realized : 1;
+   Eina_Bool                     selected : 1;
+   Eina_Bool                     highlighted : 1;
+   Eina_Bool                     expanded : 1;
+   Eina_Bool                     disabled : 1;
+   Eina_Bool                     display_only : 1;
+   Eina_Bool                     mincalcd : 1;
+   Eina_Bool                     queued : 1;
+   Eina_Bool                     showme : 1;
+   Eina_Bool                     delete_me : 1;
+   Eina_Bool                     down : 1;
+   Eina_Bool                     dragging : 1;
+   Eina_Bool                     updateme : 1;
+   Eina_Bool                     nocache : 1;
 };
 
 struct _Item_Cache
@@ -435,7 +435,7 @@
 };
 
 #define ELM_GENLIST_ITEM_FROM_INLIST(item) \
-   ((item) ? EINA_INLIST_CONTAINER_GET(item, Elm_Genlist_Item) : NULL)
+  ((item) ? EINA_INLIST_CONTAINER_GET(item, Elm_Genlist_Item) : NULL)
 
 struct _Pan
 {
@@ -473,7 +473,7 @@
 
 static Eina_Bool
 _event_hook(Evas_Object       *obj,
-            Evas_Object *src   __UNUSED__,
+            Evas_Object       *src __UNUSED__,
             Evas_Callback_Type type,
             void              *event_info)
 {
@@ -686,7 +686,7 @@
 }
 
 static void
-_on_focus_hook(void *data   __UNUSED__,
+_on_focus_hook(void        *data __UNUSED__,
                Evas_Object *obj)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
@@ -760,7 +760,7 @@
 
         if (itb->realized) _item_block_unrealize(itb);
         EINA_LIST_FOREACH(itb->items, l, it)
-           it->mincalcd = EINA_FALSE;
+          it->mincalcd = EINA_FALSE;
 
         itb->changed = EINA_TRUE;
      }
@@ -821,7 +821,7 @@
         else if ((maxw > 0) && (vw > maxw))
           vw = maxw;
         edje_object_size_min_calc
-           (elm_smart_scroller_edje_object_get(wd->scr), &vmw, &vmh);
+          (elm_smart_scroller_edje_object_get(wd->scr), &vmw, &vmh);
         minw = vmw + minw;
      }
    else
@@ -829,7 +829,7 @@
         Evas_Coord vmw, vmh;
 
         edje_object_size_min_calc
-           (elm_smart_scroller_edje_object_get(wd->scr), &vmw, &vmh);
+          (elm_smart_scroller_edje_object_get(wd->scr), &vmw, &vmh);
         minw = vmw;
         minh = vmh;
      }
@@ -911,7 +911,7 @@
                        itbn->changed = EINA_TRUE;
                     }
                   it->wd->blocks =
-                     eina_inlist_remove(it->wd->blocks, EINA_INLIST_GET(itb));
+                    eina_inlist_remove(it->wd->blocks, EINA_INLIST_GET(itb));
                   free(itb);
                }
           }
@@ -1009,7 +1009,7 @@
 
 static void
 _mouse_move(void        *data,
-            Evas *evas   __UNUSED__,
+            Evas        *evas __UNUSED__,
             Evas_Object *obj,
             void        *event_info)
 {
@@ -1234,10 +1234,10 @@
 }
 
 static void
-_multi_down(void            *data,
-            Evas *evas       __UNUSED__,
+_multi_down(void        *data,
+            Evas        *evas __UNUSED__,
             Evas_Object *obj __UNUSED__,
-            void            *event_info)
+            void        *event_info)
 {
    Elm_Genlist_Item *it = data;
    Evas_Event_Multi_Down *ev = event_info;
@@ -1275,10 +1275,10 @@
 }
 
 static void
-_multi_up(void            *data,
-          Evas *evas       __UNUSED__,
+_multi_up(void        *data,
+          Evas        *evas __UNUSED__,
           Evas_Object *obj __UNUSED__,
-          void            *event_info)
+          void        *event_info)
 {
    Elm_Genlist_Item *it = data;
    Evas_Event_Multi_Up *ev = event_info;
@@ -1291,10 +1291,10 @@
 }
 
 static void
-_multi_move(void            *data,
-            Evas *evas       __UNUSED__,
+_multi_move(void        *data,
+            Evas        *evas __UNUSED__,
             Evas_Object *obj __UNUSED__,
-            void            *event_info)
+            void        *event_info)
 {
    Elm_Genlist_Item *it = data;
    Evas_Event_Multi_Move *ev = event_info;
@@ -1306,7 +1306,7 @@
 
 static void
 _mouse_down(void        *data,
-            Evas *evas   __UNUSED__,
+            Evas        *evas __UNUSED__,
             Evas_Object *obj,
             void        *event_info)
 {
@@ -1356,10 +1356,10 @@
 }
 
 static void
-_mouse_up(void            *data,
-          Evas *evas       __UNUSED__,
+_mouse_up(void        *data,
+          Evas        *evas __UNUSED__,
           Evas_Object *obj __UNUSED__,
-          void            *event_info)
+          void        *event_info)
 {
    Elm_Genlist_Item *it = data;
    Evas_Event_Mouse_Up *ev = event_info;
@@ -1449,7 +1449,7 @@
              Elm_Genlist_Item *it2;
 
              EINA_LIST_FOREACH_SAFE(it->wd->selected, l, l_next, it2)
-                if (it2 != it) _item_unselect(it2);
+               if (it2 != it) _item_unselect(it2);
              //_item_highlight(it);
              //_item_select(it);
           }
@@ -1459,10 +1459,10 @@
 }
 
 static void
-_signal_expand_toggle(void                *data,
-                      Evas_Object *obj     __UNUSED__,
-                      const char *emission __UNUSED__,
-                      const char *source   __UNUSED__)
+_signal_expand_toggle(void        *data,
+                      Evas_Object *obj __UNUSED__,
+                      const char  *emission __UNUSED__,
+                      const char  *source __UNUSED__)
 {
    Elm_Genlist_Item *it = data;
 
@@ -1473,10 +1473,10 @@
 }
 
 static void
-_signal_expand(void                *data,
-               Evas_Object *obj     __UNUSED__,
-               const char *emission __UNUSED__,
-               const char *source   __UNUSED__)
+_signal_expand(void        *data,
+               Evas_Object *obj __UNUSED__,
+               const char  *emission __UNUSED__,
+               const char  *source __UNUSED__)
 {
    Elm_Genlist_Item *it = data;
 
@@ -1485,10 +1485,10 @@
 }
 
 static void
-_signal_contract(void                *data,
-                 Evas_Object *obj     __UNUSED__,
-                 const char *emission __UNUSED__,
-                 const char *source   __UNUSED__)
+_signal_contract(void        *data,
+                 Evas_Object *obj __UNUSED__,
+                 const char  *emission __UNUSED__,
+                 const char  *source __UNUSED__)
 {
    Elm_Genlist_Item *it = data;
 
@@ -1673,7 +1673,7 @@
         edje_object_mirrored_set(it->base.view,
                                  elm_widget_mirrored_get(it->base.widget));
         it->spacer =
-           evas_object_rectangle_add(evas_object_evas_get(it->base.widget));
+          evas_object_rectangle_add(evas_object_evas_get(it->base.widget));
         evas_object_color_set(it->spacer, 0, 0, 0, 0);
         elm_widget_sub_object_add(it->base.widget, it->spacer);
      }
@@ -1776,12 +1776,12 @@
              const char *key;
 
              it->labels =
-                elm_widget_stringlist_get(edje_object_data_get(it->base.view,
-                                                               "labels"));
+               elm_widget_stringlist_get(edje_object_data_get(it->base.view,
+                                                              "labels"));
              EINA_LIST_FOREACH(it->labels, l, key)
                {
                   char *s = it->itc->func.label_get
-                     ((void *)it->base.data, it->base.widget, l->data);
+                      ((void *)it->base.data, it->base.widget, l->data);
 
                   if (s)
                     {
@@ -1798,12 +1798,12 @@
              const char *key;
 
              it->icons =
-                elm_widget_stringlist_get(edje_object_data_get(it->base.view,
-                                                               "icons"));
+               elm_widget_stringlist_get(edje_object_data_get(it->base.view,
+                                                              "icons"));
              EINA_LIST_FOREACH(it->icons, l, key)
                {
                   Evas_Object *ic = it->itc->func.icon_get
-                     ((void *)it->base.data, it->base.widget, l->data);
+                      ((void *)it->base.data, it->base.widget, l->data);
 
                   if (ic)
                     {
@@ -1820,12 +1820,12 @@
              const char *key;
 
              it->states =
-                elm_widget_stringlist_get(edje_object_data_get(it->base.view,
-                                                               "states"));
+               elm_widget_stringlist_get(edje_object_data_get(it->base.view,
+                                                              "states"));
              EINA_LIST_FOREACH(it->states, l, key)
                {
                   Eina_Bool on = it->itc->func.state_get
-                     ((void *)it->base.data, it->base.widget, l->data);
+                      ((void *)it->base.data, it->base.widget, l->data);
 
                   if (on)
                     {
@@ -1919,7 +1919,7 @@
    elm_widget_stringlist_free(it->states);
 
    EINA_LIST_FREE(it->icon_objs, icon)
-      evas_object_del(icon);
+     evas_object_del(icon);
 
    it->states = NULL;
    it->realized = EINA_FALSE;
@@ -2165,7 +2165,7 @@
                   Eina_List *l;
                   Elm_Genlist_Item *it;
                   EINA_LIST_FOREACH(itb->items, l, it)
-                     if (it->mincalcd) it->mincalcd = EINA_FALSE;
+                    if (it->mincalcd) it->mincalcd = EINA_FALSE;
                   itb->changed = EINA_TRUE;
                   if (itb->must_recalc) did_must_recalc = EINA_TRUE;
                   itb->must_recalc = EINA_FALSE;
@@ -2393,8 +2393,8 @@
 
 static void
 _pan_min_get(Evas_Object *obj __UNUSED__,
-             Evas_Coord      *x,
-             Evas_Coord      *y)
+             Evas_Coord  *x,
+             Evas_Coord  *y)
 {
    if (x) *x = 0;
    if (y) *y = 0;
@@ -2506,8 +2506,8 @@
 
 static void
 _pan_move(Evas_Object *obj,
-          Evas_Coord x __UNUSED__,
-          Evas_Coord y __UNUSED__)
+          Evas_Coord   x __UNUSED__,
+          Evas_Coord   y __UNUSED__)
 {
    Pan *sd = evas_object_smart_data_get(obj);
 
@@ -2516,9 +2516,9 @@
 }
 
 static void
-_hold_on(void *data       __UNUSED__,
-         Evas_Object     *obj,
-         void *event_info __UNUSED__)
+_hold_on(void        *data __UNUSED__,
+         Evas_Object *obj,
+         void        *event_info __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -2526,9 +2526,9 @@
 }
 
 static void
-_hold_off(void *data       __UNUSED__,
-          Evas_Object     *obj,
-          void *event_info __UNUSED__)
+_hold_off(void        *data __UNUSED__,
+          Evas_Object *obj,
+          void        *event_info __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -2536,9 +2536,9 @@
 }
 
 static void
-_freeze_on(void *data       __UNUSED__,
-           Evas_Object     *obj,
-           void *event_info __UNUSED__)
+_freeze_on(void        *data __UNUSED__,
+           Evas_Object *obj,
+           void        *event_info __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -2546,9 +2546,9 @@
 }
 
 static void
-_freeze_off(void *data       __UNUSED__,
-            Evas_Object     *obj,
-            void *event_info __UNUSED__)
+_freeze_off(void        *data __UNUSED__,
+            Evas_Object *obj,
+            void        *event_info __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -2556,36 +2556,36 @@
 }
 
 static void
-_scroll_edge_left(void            *data,
+_scroll_edge_left(void        *data,
                   Evas_Object *scr __UNUSED__,
-                  void *event_info __UNUSED__)
+                  void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, "scroll,edge,left", NULL);
 }
 
 static void
-_scroll_edge_right(void            *data,
+_scroll_edge_right(void        *data,
                    Evas_Object *scr __UNUSED__,
-                   void *event_info __UNUSED__)
+                   void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, "scroll,edge,right", NULL);
 }
 
 static void
-_scroll_edge_top(void            *data,
+_scroll_edge_top(void        *data,
                  Evas_Object *scr __UNUSED__,
-                 void *event_info __UNUSED__)
+                 void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, "scroll,edge,top", NULL);
 }
 
 static void
-_scroll_edge_bottom(void            *data,
+_scroll_edge_bottom(void        *data,
                     Evas_Object *scr __UNUSED__,
-                    void *event_info __UNUSED__)
+                    void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, "scroll,edge,bottom", NULL);
@@ -2723,7 +2723,7 @@
              if (!it->rel->block)
                {
                   wd->blocks =
-                     eina_inlist_append(wd->blocks, EINA_INLIST_GET(itb));
+                    eina_inlist_append(wd->blocks, EINA_INLIST_GET(itb));
                   itb->items = eina_list_append(itb->items, it);
                }
              else
@@ -2731,18 +2731,18 @@
                   if (it->before)
                     {
                        wd->blocks = eina_inlist_prepend_relative
-                          (wd->blocks, EINA_INLIST_GET(itb),
+                           (wd->blocks, EINA_INLIST_GET(itb),
                            EINA_INLIST_GET(it->rel->block));
                        itb->items =
-                          eina_list_prepend_relative(itb->items, it, it->rel);
+                         eina_list_prepend_relative(itb->items, it, it->rel);
                     }
                   else
                     {
                        wd->blocks = eina_inlist_append_relative
-                          (wd->blocks, EINA_INLIST_GET(itb),
+                           (wd->blocks, EINA_INLIST_GET(itb),
                            EINA_INLIST_GET(it->rel->block));
                        itb->items =
-                          eina_list_append_relative(itb->items, it, it->rel);
+                         eina_list_append_relative(itb->items, it, it->rel);
                     }
                }
           }
@@ -2759,8 +2759,8 @@
                             if (!itb) return;
                             itb->wd = wd;
                             wd->blocks =
-                               eina_inlist_prepend(wd->blocks,
-                                                   EINA_INLIST_GET(itb));
+                              eina_inlist_prepend(wd->blocks,
+                                                  EINA_INLIST_GET(itb));
                          }
                     }
                   else
@@ -2769,7 +2769,7 @@
                        if (!itb) return;
                        itb->wd = wd;
                        wd->blocks =
-                          eina_inlist_prepend(wd->blocks, EINA_INLIST_GET(itb));
+                         eina_inlist_prepend(wd->blocks, EINA_INLIST_GET(itb));
                     }
                   itb->items = eina_list_prepend(itb->items, it);
                }
@@ -2784,8 +2784,8 @@
                             if (!itb) return;
                             itb->wd = wd;
                             wd->blocks =
-                               eina_inlist_append(wd->blocks,
-                                                  EINA_INLIST_GET(itb));
+                              eina_inlist_append(wd->blocks,
+                                                 EINA_INLIST_GET(itb));
                          }
                     }
                   else
@@ -2794,7 +2794,7 @@
                        if (!itb) return;
                        itb->wd = wd;
                        wd->blocks =
-                          eina_inlist_append(wd->blocks, EINA_INLIST_GET(itb));
+                         eina_inlist_append(wd->blocks, EINA_INLIST_GET(itb));
                     }
                   itb->items = eina_list_append(itb->items, it);
                }
@@ -2832,8 +2832,8 @@
         if (!itb2) return;
         itb2->wd = wd;
         wd->blocks =
-           eina_inlist_append_relative(wd->blocks, EINA_INLIST_GET(itb2),
-                                       EINA_INLIST_GET(itb));
+          eina_inlist_append_relative(wd->blocks, EINA_INLIST_GET(itb2),
+                                      EINA_INLIST_GET(itb));
         itb2->changed = EINA_TRUE;
         while ((itb->count > newc) && (itb->items))
           {
@@ -2976,8 +2976,8 @@
         it->parent->items = eina_list_append(it->parent->items, it);
         if (!it2) it2 = it->parent;
         wd->items =
-           eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
-                                       EINA_INLIST_GET(it2));
+          eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
+                                      EINA_INLIST_GET(it2));
         it->rel = it2;
         it->rel->relcount++;
 
@@ -3038,8 +3038,8 @@
         it->parent->items = eina_list_prepend(it->parent->items, it);
         if (!it2) it2 = it->parent;
         wd->items =
-           eina_inlist_prepend_relative(wd->items, EINA_INLIST_GET(it),
-                                        EINA_INLIST_GET(it2));
+          eina_inlist_prepend_relative(wd->items, EINA_INLIST_GET(it),
+                                       EINA_INLIST_GET(it2));
         it->rel = it2;
         it->rel->relcount++;
      }
@@ -3179,7 +3179,7 @@
              wd->anchor_item = ELM_GENLIST_ITEM_FROM_INLIST(EINA_INLIST_GET(it)->next);
              if (!wd->anchor_item)
                wd->anchor_item =
-                  ELM_GENLIST_ITEM_FROM_INLIST(EINA_INLIST_GET(it)->prev);
+                 ELM_GENLIST_ITEM_FROM_INLIST(EINA_INLIST_GET(it)->prev);
           }
         wd->items = eina_inlist_remove(wd->items, wd->items);
         if (it->flags & ELM_GENLIST_ITEM_GROUP)
@@ -3583,9 +3583,9 @@
    Elm_Genlist_Item *it2;
 
    EINA_LIST_FOREACH(it->items, l, it2)
-      tl = eina_list_append(tl, it2);
+     tl = eina_list_append(tl, it2);
    EINA_LIST_FREE(tl, it2)
-      elm_genlist_item_del(it2);
+     elm_genlist_item_del(it2);
 }
 
 /**
@@ -4194,7 +4194,7 @@
 static Evas_Object *
 _elm_genlist_item_label_create(void        *data,
                                Evas_Object *obj,
-                               void *item   __UNUSED__)
+                               void        *item __UNUSED__)
 {
    Evas_Object *label = elm_label_add(obj);
    if (!label)
@@ -4205,9 +4205,9 @@
 }
 
 static void
-_elm_genlist_item_label_del_cb(void            *data,
+_elm_genlist_item_label_del_cb(void        *data,
                                Evas_Object *obj __UNUSED__,
-                               void *event_info __UNUSED__)
+                               void        *event_info __UNUSED__)
 {
    eina_stringshare_del(data);
 }

Log:
Elementary: Use pre-defined type Edje_Signal_Cb instead of describing all of its parameters.
  

Author:       seoz
Date:         2011-04-02 22:32:17 -0700 (Sat, 02 Apr 2011)
New Revision: 58283
Trac:         http://trac.enlightenment.org/e/changeset/58283

Modified:
  trunk/elementary/src/lib/elc_scrolled_entry.c trunk/elementary/src/lib/elm_button.c trunk/elementary/src/lib/elm_calendar.c trunk/elementary/src/lib/elm_clock.c trunk/elementary/src/lib/elm_entry.c trunk/elementary/src/lib/elm_hover.c trunk/elementary/src/lib/elm_icon.c trunk/elementary/src/lib/elm_index.c trunk/elementary/src/lib/elm_layout.c trunk/elementary/src/lib/elm_list.c trunk/elementary/src/lib/elm_panel.c trunk/elementary/src/lib/elm_scroller.c trunk/elementary/src/lib/elm_spinner.c trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_widget.h 

Modified: trunk/elementary/src/lib/elc_scrolled_entry.c
===================================================================
--- trunk/elementary/src/lib/elc_scrolled_entry.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elc_scrolled_entry.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -184,7 +184,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -194,7 +194,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data __UNUSED__)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    elm_object_signal_callback_del(wd->entry, emission, source, func_cb);

Modified: trunk/elementary/src/lib/elm_button.c
===================================================================
--- trunk/elementary/src/lib/elm_button.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_button.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -152,7 +152,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -160,7 +160,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_del_full(wd->btn, emission, source, func_cb,

Modified: trunk/elementary/src/lib/elm_calendar.c
===================================================================
--- trunk/elementary/src/lib/elm_calendar.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_calendar.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -471,7 +471,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -480,7 +480,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;

Modified: trunk/elementary/src/lib/elm_clock.c
===================================================================
--- trunk/elementary/src/lib/elm_clock.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_clock.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -105,7 +105,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    int i;
@@ -120,7 +120,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    int i;

Modified: trunk/elementary/src/lib/elm_entry.c
===================================================================
--- trunk/elementary/src/lib/elm_entry.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_entry.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -655,7 +655,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -663,7 +663,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_del_full(wd->ent, emission, source, func_cb,

Modified: trunk/elementary/src/lib/elm_hover.c
===================================================================
--- trunk/elementary/src/lib/elm_hover.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_hover.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -168,7 +168,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd;
 
@@ -180,7 +180,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd;
 

Modified: trunk/elementary/src/lib/elm_icon.c
===================================================================
--- trunk/elementary/src/lib/elm_icon.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_icon.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -96,7 +96,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -107,7 +107,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;

Modified: trunk/elementary/src/lib/elm_index.c
===================================================================
--- trunk/elementary/src/lib/elm_index.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_index.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -76,7 +76,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -84,7 +84,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_del_full(wd->base, emission, source, func_cb,

Modified: trunk/elementary/src/lib/elm_layout.c
===================================================================
--- trunk/elementary/src/lib/elm_layout.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_layout.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -127,14 +127,14 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_add(wd->lay, emission, source, func_cb, data);
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_del_full(wd->lay, emission, source, func_cb,

Modified: trunk/elementary/src/lib/elm_list.c
===================================================================
--- trunk/elementary/src/lib/elm_list.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_list.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -519,7 +519,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_add(elm_smart_scroller_edje_object_get(wd->scr),
@@ -527,7 +527,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_del_full(

Modified: trunk/elementary/src/lib/elm_panel.c
===================================================================
--- trunk/elementary/src/lib/elm_panel.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_panel.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -123,7 +123,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -132,7 +132,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_del_full(

Modified: trunk/elementary/src/lib/elm_scroller.c
===================================================================
--- trunk/elementary/src/lib/elm_scroller.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_scroller.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -238,7 +238,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -247,7 +247,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_del_full(

Modified: trunk/elementary/src/lib/elm_spinner.c
===================================================================
--- trunk/elementary/src/lib/elm_spinner.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_spinner.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -98,7 +98,7 @@
 }
 
 static void
-_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_add_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -107,7 +107,7 @@
 }
 
 static void
-_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+_signal_callback_del_hook(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_callback_del_full(wd->spinner, emission, source,

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_widget.c	2011-04-03 05:32:17 UTC (rev 58283)
@@ -34,13 +34,9 @@
    void         (*signal_func) (Evas_Object *obj, const char *emission,
                                 const char *source);
    void         (*callback_add_func) (Evas_Object *obj, const char *emission,
-                                      const char *source, void (*func) (void *data,
-                                                                        Evas_Object *o, const char *emission,
-                                                                        const char *source), void *data);
+                                      const char *source, Edje_Signal_Cb func, void *data);
    void         (*callback_del_func) (Evas_Object *obj, const char *emission,
-                                      const char *source, void (*func) (void *data,
-                                                                        Evas_Object *o, const char *emission,
-                                                                        const char *source), void *data);
+                                      const char *source, Edje_Signal_Cb func, void *data);
    void         (*changed_func) (Evas_Object *obj);
    Eina_Bool    (*focus_next_func) (const Evas_Object *obj, Elm_Focus_Direction dir,
                                     Evas_Object **next);
@@ -451,14 +447,14 @@
 }
 
 EAPI void
-elm_widget_signal_callback_add_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data))
+elm_widget_signal_callback_add_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data))
 {
    API_ENTRY return;
    sd->callback_add_func = func;
 }
 
 EAPI void
-elm_widget_signal_callback_del_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data))
+elm_widget_signal_callback_del_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data))
 {
    API_ENTRY return;
    sd->callback_del_func = func;
@@ -1439,7 +1435,7 @@
 }
 
 EAPI void
-elm_widget_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, void (*func) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+elm_widget_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func, void *data)
 {
    Edje_Signal_Data *esd;
    API_ENTRY return;
@@ -1459,7 +1455,7 @@
 }
 
 EAPI void *
-elm_widget_signal_callback_del(Evas_Object *obj, const char *emission, const char *source, void (*func) (void *data, Evas_Object *o, const char *emission, const char *source))
+elm_widget_signal_callback_del(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func)
 {
    Edje_Signal_Data *esd;
    Eina_List *l;

Modified: trunk/elementary/src/lib/elm_widget.h
===================================================================
--- trunk/elementary/src/lib/elm_widget.h	2011-04-03 03:51:40 UTC (rev 58282)
+++ trunk/elementary/src/lib/elm_widget.h	2011-04-03 05:32:17 UTC (rev 58283)
@@ -219,8 +219,8 @@
 EAPI void             elm_widget_event_hook_set(Evas_Object *obj, Eina_Bool (*func) (Evas_Object *obj, Evas_Object *source, Evas_Callback_Type type, void *event_info));
 EAPI void             elm_widget_changed_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj));
 EAPI void             elm_widget_signal_emit_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source));
-EAPI void             elm_widget_signal_callback_add_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data));
-EAPI void             elm_widget_signal_callback_del_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, void (*func_cb) (void *data, Evas_Object *o, const char *emission, const char *source), void *data));
+EAPI void             elm_widget_signal_callback_add_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data));
+EAPI void             elm_widget_signal_callback_del_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data));
 EAPI void             elm_widget_theme(Evas_Object *obj);
 EAPI void             elm_widget_theme_specific(Evas_Object *obj, Elm_Theme *th, Eina_Bool force);
 EAPI void             elm_widget_focus_next_hook_set(Evas_Object *obj, Eina_Bool (*func) (const Evas_Object *obj, Elm_Focus_Direction dir, Evas_Object **next));

Log:
Elementary elm_widget.c: Removed ; after INTERNAL_ENTRY.
  

Author:       seoz
Date:         2011-04-02 22:48:00 -0700 (Sat, 02 Apr 2011)
New Revision: 58284
Trac:         http://trac.enlightenment.org/e/changeset/58284

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-04-03 05:32:17 UTC (rev 58283)
+++ trunk/elementary/src/lib/elm_widget.c	2011-04-03 05:48:00 UTC (rev 58284)
@@ -136,7 +136,7 @@
 {
    for (; obj; obj = elm_widget_parent_get(obj))
      {
-        INTERNAL_ENTRY;
+        INTERNAL_ENTRY
         if (!sd->focused) return;
         sd->focused = 0;
      }
@@ -147,7 +147,7 @@
 {
    for (; obj; obj = elm_widget_parent_get(obj))
      {
-        INTERNAL_ENTRY;
+        INTERNAL_ENTRY
         if (sd->focused) return;
         sd->focused = 1;
      }
@@ -225,7 +225,7 @@
 static void
 _propagate_event(void *data, Evas *e __UNUSED__, Evas_Object *obj, void *event_info)
 {
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    Evas_Callback_Type type = (Evas_Callback_Type)(long) data;
    Evas_Event_Flags *event_flags = NULL;
 
@@ -2561,7 +2561,7 @@
    Evas_Object *newest = NULL;
    unsigned int newest_focus_order = 0;
 
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
 
    if (!sd->focused) return;
    if (!sd->parent_obj) return;
@@ -2584,7 +2584,7 @@
    Evas_Object *sobj;
    Edje_Signal_Data *esd;
 
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
 
    if (sd->del_pre_func) sd->del_pre_func(obj);
    if (sd->resize_obj)
@@ -2629,7 +2629,7 @@
 static void
 _smart_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y)
 {
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    sd->x = x;
    sd->y = y;
    _smart_reconfigure(sd);
@@ -2638,7 +2638,7 @@
 static void
 _smart_resize(Evas_Object *obj, Evas_Coord w, Evas_Coord h)
 {
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    sd->w = w;
    sd->h = h;
    _smart_reconfigure(sd);
@@ -2649,7 +2649,7 @@
 {
    Eina_List *list;
    Evas_Object *o;
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    if ((list = evas_object_smart_members_get(obj)))
      {
         EINA_LIST_FREE(list, o)
@@ -2665,7 +2665,7 @@
 {
    Eina_List *list;
    Evas_Object *o;
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    list = evas_object_smart_members_get(obj);
    EINA_LIST_FREE(list, o)
      {
@@ -2679,7 +2679,7 @@
 {
    Eina_List *list;
    Evas_Object *o;
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    if ((list = evas_object_smart_members_get(obj)))
      {
         EINA_LIST_FREE(list, o)
@@ -2695,7 +2695,7 @@
 {
    Eina_List *list;
    Evas_Object *o;
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    if ((list = evas_object_smart_members_get(obj)))
      {
         EINA_LIST_FREE(list, o)
@@ -2711,7 +2711,7 @@
 {
    Eina_List *list;
    Evas_Object *o;
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    if ((list = evas_object_smart_members_get(obj)))
      {
         EINA_LIST_FREE(list, o)
@@ -2725,7 +2725,7 @@
 static void
 _smart_calculate(Evas_Object *obj)
 {
-   INTERNAL_ENTRY;
+   INTERNAL_ENTRY
    if (sd->changed_func) sd->changed_func(obj);
 }

Log:
Elementary elm_widget.c: Fix formatting.
  
  Used ecrustify then fixed manually. Ecrustify still has wrong formatting.
  

Author:       seoz
Date:         2011-04-02 23:43:17 -0700 (Sat, 02 Apr 2011)
New Revision: 58285
Trac:         http://trac.enlightenment.org/e/changeset/58285

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-04-03 05:48:00 UTC (rev 58284)
+++ trunk/elementary/src/lib/elm_widget.c	2011-04-03 06:43:17 UTC (rev 58285)
@@ -3,112 +3,147 @@
 
 static const char SMART_NAME[] = "elm_widget";
 
-#define API_ENTRY \
-   Smart_Data *sd = evas_object_smart_data_get(obj); \
-   if ((!obj) || (!sd) || (!_elm_widget_is(obj)))
-#define INTERNAL_ENTRY \
-   Smart_Data *sd = evas_object_smart_data_get(obj); \
-   if (!sd) return;
+#define API_ENTRY                                    \
+  Smart_Data * sd = evas_object_smart_data_get(obj); \
+  if ((!obj) || (!sd) || (!_elm_widget_is(obj)))
+#define INTERNAL_ENTRY                               \
+  Smart_Data * sd = evas_object_smart_data_get(obj); \
+  if (!sd) return;
 
-typedef struct _Smart_Data Smart_Data;
-typedef struct _Edje_Signal_Data Edje_Signal_Data;
+typedef struct _Smart_Data        Smart_Data;
+typedef struct _Edje_Signal_Data  Edje_Signal_Data;
 typedef struct _Elm_Event_Cb_Data Elm_Event_Cb_Data;
 
 struct _Smart_Data
 {
-   Evas_Object   *obj;
-   const char    *type;
-   Evas_Object   *parent_obj;
-   Evas_Coord     x, y, w, h;
-   Eina_List     *subobjs;
-   Evas_Object   *resize_obj;
-   Evas_Object   *hover_obj;
-   Eina_List     *tooltips, *cursors;
-   void         (*del_func) (Evas_Object *obj);
-   void         (*del_pre_func) (Evas_Object *obj);
-   void         (*focus_func) (Evas_Object *obj);
-   void         (*activate_func) (Evas_Object *obj);
-   void         (*disable_func) (Evas_Object *obj);
-   void         (*theme_func) (Evas_Object *obj);
-   Eina_Bool    (*event_func) (Evas_Object *obj, Evas_Object *source, Evas_Callback_Type type, void *event_info);
-   void         (*signal_func) (Evas_Object *obj, const char *emission,
-                                const char *source);
-   void         (*callback_add_func) (Evas_Object *obj, const char *emission,
-                                      const char *source, Edje_Signal_Cb func, void *data);
-   void         (*callback_del_func) (Evas_Object *obj, const char *emission,
-                                      const char *source, Edje_Signal_Cb func, void *data);
-   void         (*changed_func) (Evas_Object *obj);
-   Eina_Bool    (*focus_next_func) (const Evas_Object *obj, Elm_Focus_Direction dir,
-                                    Evas_Object **next);
-   void         (*on_focus_func) (void *data, Evas_Object *obj);
-   void          *on_focus_data;
-   void         (*on_change_func) (void *data, Evas_Object *obj);
-   void          *on_change_data;
-   void         (*on_show_region_func) (void *data, Evas_Object *obj);
-   void          *on_show_region_data;
-   void         (*focus_region_func) (Evas_Object *obj, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h);
-   void         (*on_focus_region_func) (const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h);
-   void          *data;
-   Evas_Coord     rx, ry, rw, rh;
-   int            scroll_hold;
-   int            scroll_freeze;
-   double         scale;
-   Elm_Theme     *theme;
-   const char    *style;
-   unsigned int   focus_order;
-   Eina_Bool      focus_order_on_calc;
+   Evas_Object *obj;
+   const char  *type;
+   Evas_Object *parent_obj;
+   Evas_Coord   x, y, w, h;
+   Eina_List   *subobjs;
+   Evas_Object *resize_obj;
+   Evas_Object *hover_obj;
+   Eina_List   *tooltips, *cursors;
+   void       (*del_func)(Evas_Object *obj);
+   void       (*del_pre_func)(Evas_Object *obj);
+   void       (*focus_func)(Evas_Object *obj);
+   void       (*activate_func)(Evas_Object *obj);
+   void       (*disable_func)(Evas_Object *obj);
+   void       (*theme_func)(Evas_Object *obj);
+   Eina_Bool  (*event_func)(Evas_Object       *obj,
+                            Evas_Object       *source,
+                            Evas_Callback_Type type,
+                            void              *event_info);
+   void       (*signal_func)(Evas_Object *obj,
+                             const char  *emission,
+                             const char  *source);
+   void       (*callback_add_func)(Evas_Object   *obj,
+                                   const char    *emission,
+                                   const char    *source,
+                                   Edje_Signal_Cb func,
+                                   void          *data);
+   void       (*callback_del_func)(Evas_Object   *obj,
+                                   const char    *emission,
+                                   const char    *source,
+                                   Edje_Signal_Cb func,
+                                   void          *data);
+   void       (*changed_func)(Evas_Object *obj);
+   Eina_Bool  (*focus_next_func)(const Evas_Object  *obj,
+                                 Elm_Focus_Direction dir,
+                                 Evas_Object       **next);
+   void       (*on_focus_func)(void        *data,
+                               Evas_Object *obj);
+   void        *on_focus_data;
+   void       (*on_change_func)(void        *data,
+                                Evas_Object *obj);
+   void        *on_change_data;
+   void       (*on_show_region_func)(void        *data,
+                                     Evas_Object *obj);
+   void        *on_show_region_data;
+   void       (*focus_region_func)(Evas_Object *obj,
+                                   Evas_Coord   x,
+                                   Evas_Coord   y,
+                                   Evas_Coord   w,
+                                   Evas_Coord   h);
+   void       (*on_focus_region_func)(const Evas_Object *obj,
+                                      Evas_Coord        *x,
+                                      Evas_Coord        *y,
+                                      Evas_Coord        *w,
+                                      Evas_Coord        *h);
+   void        *data;
+   Evas_Coord   rx, ry, rw, rh;
+   int          scroll_hold;
+   int          scroll_freeze;
+   double       scale;
+   Elm_Theme   *theme;
+   const char  *style;
+   unsigned int focus_order;
+   Eina_Bool    focus_order_on_calc;
 
-   int            child_drag_x_locked;
-   int            child_drag_y_locked;
+   int          child_drag_x_locked;
+   int          child_drag_y_locked;
 
-   Eina_List     *edje_signals;
+   Eina_List   *edje_signals;
 
-   Eina_Bool      drag_x_locked : 1;
-   Eina_Bool      drag_y_locked : 1;
+   Eina_Bool    drag_x_locked : 1;
+   Eina_Bool    drag_y_locked : 1;
 
-   Eina_Bool      can_focus : 1;
-   Eina_Bool      child_can_focus : 1;
-   Eina_Bool      focused : 1;
-   Eina_Bool      highlight_ignore : 1;
-   Eina_Bool      highlight_in_theme : 1;
-   Eina_Bool      disabled : 1;
-   Eina_Bool      is_mirrored : 1;
-   Eina_Bool      mirrored_auto_mode : 1; /* This is TRUE by default */
+   Eina_Bool    can_focus : 1;
+   Eina_Bool    child_can_focus : 1;
+   Eina_Bool    focused : 1;
+   Eina_Bool    highlight_ignore : 1;
+   Eina_Bool    highlight_in_theme : 1;
+   Eina_Bool    disabled : 1;
+   Eina_Bool    is_mirrored : 1;
+   Eina_Bool    mirrored_auto_mode : 1;   /* This is TRUE by default */
 
-   Eina_List     *focus_chain;
-   Eina_List     *event_cb;
+   Eina_List   *focus_chain;
+   Eina_List   *event_cb;
 };
 
 struct _Edje_Signal_Data
 {
-   Evas_Object *obj;
+   Evas_Object   *obj;
    Edje_Signal_Cb func;
-   const char *emission;
-   const char *source;
-   void *data;
+   const char    *emission;
+   const char    *source;
+   void          *data;
 };
 
-struct _Elm_Event_Cb_Data {
-     Elm_Event_Cb func;
-     const void *data;
+struct _Elm_Event_Cb_Data
+{
+   Elm_Event_Cb func;
+   const void  *data;
 };
 
 /* local subsystem functions */
 static void _smart_reconfigure(Smart_Data *sd);
 static void _smart_add(Evas_Object *obj);
 static void _smart_del(Evas_Object *obj);
-static void _smart_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y);
-static void _smart_resize(Evas_Object *obj, Evas_Coord w, Evas_Coord h);
+static void _smart_move(Evas_Object *obj,
+                        Evas_Coord   x,
+                        Evas_Coord   y);
+static void _smart_resize(Evas_Object *obj,
+                          Evas_Coord   w,
+                          Evas_Coord   h);
 static void _smart_show(Evas_Object *obj);
 static void _smart_hide(Evas_Object *obj);
-static void _smart_color_set(Evas_Object *obj, int r, int g, int b, int a);
-static void _smart_clip_set(Evas_Object *obj, Evas_Object * clip);
+static void _smart_color_set(Evas_Object *obj,
+                             int          r,
+                             int          g,
+                             int          b,
+                             int          a);
+static void _smart_clip_set(Evas_Object *obj,
+                            Evas_Object *clip);
 static void _smart_clip_unset(Evas_Object *obj);
 static void _smart_calculate(Evas_Object *obj);
 static void _smart_init(void);
 
-static void _if_focused_revert(Evas_Object *obj, Eina_Bool can_focus_only);
-static Evas_Object *_newest_focus_order_get(Evas_Object *obj, unsigned int *newest_focus_order, Eina_Bool can_focus_only);
+static void _if_focused_revert(Evas_Object *obj,
+                               Eina_Bool    can_focus_only);
+static Evas_Object *_newest_focus_order_get(Evas_Object  *obj,
+                                            unsigned int *newest_focus_order,
+                                            Eina_Bool     can_focus_only);
 
 /* local subsystem globals */
 static Evas_Smart *_e_smart = NULL;
@@ -154,7 +189,10 @@
 }
 
 static void
-_sub_obj_del(void *data, Evas *e __UNUSED__, Evas_Object *obj, void *event_info __UNUSED__)
+_sub_obj_del(void        *data,
+             Evas        *e __UNUSED__,
+             Evas_Object *obj,
+             void        *event_info __UNUSED__)
 {
    Smart_Data *sd = data;
 
@@ -172,13 +210,19 @@
 }
 
 static void
-_sub_obj_hide(void *data __UNUSED__, Evas *e __UNUSED__, Evas_Object *obj, void *event_info __UNUSED__)
+_sub_obj_hide(void        *data __UNUSED__,
+              Evas        *e __UNUSED__,
+              Evas_Object *obj,
+              void        *event_info __UNUSED__)
 {
    _if_focused_revert(obj, EINA_TRUE);
 }
 
 static void
-_sub_obj_mouse_down(void *data __UNUSED__, Evas *e __UNUSED__, Evas_Object *obj, void *event_info __UNUSED__)
+_sub_obj_mouse_down(void        *data __UNUSED__,
+                    Evas        *e __UNUSED__,
+                    Evas_Object *obj,
+                    void        *event_info __UNUSED__)
 {
    Evas_Object *o = obj;
    do
@@ -193,64 +237,66 @@
 }
 
 static void
-_propagate_x_drag_lock(Evas_Object *obj, int dir)
+_propagate_x_drag_lock(Evas_Object *obj,
+                       int          dir)
 {
    INTERNAL_ENTRY
-      if (sd->parent_obj)
-        {
-           Smart_Data *sd2 = evas_object_smart_data_get(sd->parent_obj);
-           if (sd2)
-             {
-                sd2->child_drag_x_locked += dir;
-                _propagate_x_drag_lock(sd->parent_obj, dir);
-             }
-        }
+   if (sd->parent_obj)
+     {
+        Smart_Data *sd2 = evas_object_smart_data_get(sd->parent_obj);
+        if (sd2)
+          {
+             sd2->child_drag_x_locked += dir;
+             _propagate_x_drag_lock(sd->parent_obj, dir);
+          }
+     }
 }
 
 static void
-_propagate_y_drag_lock(Evas_Object *obj, int dir)
+_propagate_y_drag_lock(Evas_Object *obj,
+                       int          dir)
 {
    INTERNAL_ENTRY
-      if (sd->parent_obj)
-        {
-           Smart_Data *sd2 = evas_object_smart_data_get(sd->parent_obj);
-           if (sd2)
-             {
-                sd2->child_drag_y_locked += dir;
-                _propagate_y_drag_lock(sd->parent_obj, dir);
-             }
-        }
+   if (sd->parent_obj)
+     {
+        Smart_Data *sd2 = evas_object_smart_data_get(sd->parent_obj);
+        if (sd2)
+          {
+             sd2->child_drag_y_locked += dir;
+             _propagate_y_drag_lock(sd->parent_obj, dir);
+          }
+     }
 }
 
 static void
-_propagate_event(void *data, Evas *e __UNUSED__, Evas_Object *obj, void *event_info)
+_propagate_event(void        *data,
+                 Evas        *e __UNUSED__,
+                 Evas_Object *obj,
+                 void        *event_info)
 {
    INTERNAL_ENTRY
-   Evas_Callback_Type type = (Evas_Callback_Type)(long) data;
+   Evas_Callback_Type type = (Evas_Callback_Type)(long)data;
    Evas_Event_Flags *event_flags = NULL;
 
    switch (type)
      {
       case EVAS_CALLBACK_KEY_DOWN:
-           {
-              Evas_Event_Key_Down *ev = event_info;
-              event_flags = &(ev->event_flags);
-              break;
-           }
+        Evas_Event_Key_Down *ev = event_info;
+        event_flags = &(ev->event_flags);
+        break;
+
       case EVAS_CALLBACK_KEY_UP:
-           {
-              Evas_Event_Key_Up *ev = event_info;
-              event_flags = &(ev->event_flags);
-              break;
-           }
+        Evas_Event_Key_Up *ev = event_info;
+        event_flags = &(ev->event_flags);
+        break;
+
       case EVAS_CALLBACK_MOUSE_WHEEL:
-           {
-              Evas_Event_Mouse_Wheel *ev = event_info;
-              event_flags = &(ev->event_flags);
-              break;
-           }
+        Evas_Event_Mouse_Wheel *ev = event_info;
+        event_flags = &(ev->event_flags);
+        break;
+
       default:
-         break;
+        break;
      }
 
    elm_widget_event_propagate(obj, type, event_info, event_flags);
@@ -295,7 +341,10 @@
 }
 
 static void
-_elm_object_focus_chain_del_cb(void *data, Evas *e __UNUSED__, Evas_Object *obj, void *event_info __UNUSED__)
+_elm_object_focus_chain_del_cb(void        *data,
+                               Evas        *e __UNUSED__,
+                               Evas_Object *obj,
+                               void        *event_info __UNUSED__)
 {
    Smart_Data *sd = data;
 
@@ -384,77 +433,101 @@
 }
 
 EAPI void
-elm_widget_del_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj))
+elm_widget_del_hook_set(Evas_Object *obj,
+                        void       (*func)(Evas_Object *obj))
 {
    API_ENTRY return;
    sd->del_func = func;
 }
 
 EAPI void
-elm_widget_del_pre_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj))
+elm_widget_del_pre_hook_set(Evas_Object *obj,
+                            void       (*func)(Evas_Object *obj))
 {
    API_ENTRY return;
    sd->del_pre_func = func;
 }
 
 EAPI void
-elm_widget_focus_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj))
+elm_widget_focus_hook_set(Evas_Object *obj,
+                          void       (*func)(Evas_Object *obj))
 {
    API_ENTRY return;
    sd->focus_func = func;
 }
 
 EAPI void
-elm_widget_activate_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj))
+elm_widget_activate_hook_set(Evas_Object *obj,
+                             void       (*func)(Evas_Object *obj))
 {
    API_ENTRY return;
    sd->activate_func = func;
 }
 
 EAPI void
-elm_widget_disable_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj))
+elm_widget_disable_hook_set(Evas_Object *obj,
+                            void       (*func)(Evas_Object *obj))
 {
    API_ENTRY return;
    sd->disable_func = func;
 }
 
 EAPI void
-elm_widget_theme_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj))
+elm_widget_theme_hook_set(Evas_Object *obj,
+                          void       (*func)(Evas_Object *obj))
 {
    API_ENTRY return;
    sd->theme_func = func;
 }
 
 EAPI void
-elm_widget_event_hook_set(Evas_Object *obj, Eina_Bool (*func) (Evas_Object *obj, Evas_Object *source, Evas_Callback_Type type, void *event_info))
+elm_widget_event_hook_set(Evas_Object *obj,
+                          Eina_Bool  (*func)(Evas_Object       *obj,
+                                             Evas_Object       *source,
+                                             Evas_Callback_Type type,
+                                             void              *event_info))
 {
    API_ENTRY return;
    sd->event_func = func;
 }
 
 EAPI void
-elm_widget_changed_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj))
+elm_widget_changed_hook_set(Evas_Object *obj,
+                            void       (*func)(Evas_Object *obj))
 {
    API_ENTRY return;
    sd->changed_func = func;
 }
 
 EAPI void
-elm_widget_signal_emit_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source))
+elm_widget_signal_emit_hook_set(Evas_Object *obj,
+                                void       (*func)(Evas_Object *obj,
+                                                   const char *emission,
+                                                   const char *source))
 {
    API_ENTRY return;
    sd->signal_func = func;
 }
 
 EAPI void
-elm_widget_signal_callback_add_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data))
+elm_widget_signal_callback_add_hook_set(Evas_Object *obj,
+                                        void       (*func)(Evas_Object   *obj,
+                                                           const char    *emission,
+                                                           const char    *source,
+                                                           Edje_Signal_Cb func_cb,
+                                                           void          *data))
 {
    API_ENTRY return;
    sd->callback_add_func = func;
 }
 
 EAPI void
-elm_widget_signal_callback_del_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func_cb, void *data))
+elm_widget_signal_callback_del_hook_set(Evas_Object *obj,
+                                        void       (*func)(Evas_Object   *obj,
+                                                           const char    *emission,
+                                                           const char    *source,
+                                                           Edje_Signal_Cb func_cb,
+                                                           void          *data))
 {
    API_ENTRY return;
    sd->callback_del_func = func;
@@ -478,7 +551,9 @@
 }
 
 EAPI void
-elm_widget_theme_specific(Evas_Object *obj, Elm_Theme *th, Eina_Bool force)
+elm_widget_theme_specific(Evas_Object *obj,
+                          Elm_Theme   *th,
+                          Eina_Bool    force)
 {
    const Eina_List *l;
    Evas_Object *child;
@@ -507,7 +582,7 @@
      }
    if (!force) return;
    EINA_LIST_FOREACH(sd->subobjs, l, child)
-      elm_widget_theme_specific(child, th, force);
+     elm_widget_theme_specific(child, th, force);
    if (sd->resize_obj) elm_widget_theme(sd->resize_obj);
    if (sd->hover_obj) elm_widget_theme(sd->hover_obj);
    EINA_LIST_FOREACH(sd->tooltips, l, tt) elm_tooltip_theme(tt);
@@ -526,7 +601,10 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_focus_next_hook_set(Evas_Object *obj, Eina_Bool (*func) (const Evas_Object *obj, Elm_Focus_Direction dir, Evas_Object **next))
+elm_widget_focus_next_hook_set(Evas_Object *obj,
+                               Eina_Bool  (*func)(const Evas_Object   *obj,
+                                                   Elm_Focus_Direction dir,
+                                                   Evas_Object       **next))
 {
    API_ENTRY return;
    sd->focus_next_func = func;
@@ -553,7 +631,8 @@
  * @param mirrored EINA_TRUE to set mirrored mode. EINA_FALSE to unset.
  */
 EAPI void
-elm_widget_mirrored_set(Evas_Object *obj, Eina_Bool mirrored)
+elm_widget_mirrored_set(Evas_Object *obj,
+                        Eina_Bool    mirrored)
 {
    API_ENTRY return;
    if (sd->is_mirrored != mirrored)
@@ -604,7 +683,8 @@
  * @param automatic EINA_TRUE for auto mirrored mode. EINA_FALSE for manual.
  */
 EAPI void
-elm_widget_mirrored_automatic_set(Evas_Object *obj, Eina_Bool automatic)
+elm_widget_mirrored_automatic_set(Evas_Object *obj,
+                                  Eina_Bool    automatic)
 {
    API_ENTRY return;
    if (sd->mirrored_auto_mode != automatic)
@@ -619,7 +699,10 @@
 }
 
 EAPI void
-elm_widget_on_focus_hook_set(Evas_Object *obj, void (*func) (void *data, Evas_Object *obj), void *data)
+elm_widget_on_focus_hook_set(Evas_Object *obj,
+                             void       (*func)(void *data,
+                                                Evas_Object *obj),
+                             void        *data)
 {
    API_ENTRY return;
    sd->on_focus_func = func;
@@ -627,7 +710,10 @@
 }
 
 EAPI void
-elm_widget_on_change_hook_set(Evas_Object *obj, void (*func) (void *data, Evas_Object *obj), void *data)
+elm_widget_on_change_hook_set(Evas_Object *obj,
+                              void       (*func)(void *data,
+                                                 Evas_Object *obj),
+                              void        *data)
 {
    API_ENTRY return;
    sd->on_change_func = func;
@@ -635,7 +721,10 @@
 }
 
 EAPI void
-elm_widget_on_show_region_hook_set(Evas_Object *obj, void (*func) (void *data, Evas_Object *obj), void *data)
+elm_widget_on_show_region_hook_set(Evas_Object *obj,
+                                   void       (*func)(void *data,
+                                                      Evas_Object *obj),
+                                   void        *data)
 {
    API_ENTRY return;
    sd->on_show_region_func = func;
@@ -658,7 +747,12 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_focus_region_hook_set(Evas_Object *obj, void (*func) (Evas_Object *obj, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h))
+elm_widget_focus_region_hook_set(Evas_Object *obj,
+                                 void       (*func)(Evas_Object *obj,
+                                                    Evas_Coord x,
+                                                    Evas_Coord y,
+                                                    Evas_Coord w,
+                                                    Evas_Coord h))
 {
    API_ENTRY return;
    sd->focus_region_func = func;
@@ -680,14 +774,20 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_on_focus_region_hook_set(Evas_Object *obj, void (*func) (const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h))
+elm_widget_on_focus_region_hook_set(Evas_Object *obj,
+                                    void       (*func)(const Evas_Object *obj,
+                                                       Evas_Coord *x,
+                                                       Evas_Coord *y,
+                                                       Evas_Coord *w,
+                                                       Evas_Coord *h))
 {
    API_ENTRY return;
    sd->on_focus_region_func = func;
 }
 
 EAPI void
-elm_widget_data_set(Evas_Object *obj, void *data)
+elm_widget_data_set(Evas_Object *obj,
+                    void        *data)
 {
    API_ENTRY return;
    sd->data = data;
@@ -701,7 +801,8 @@
 }
 
 EAPI void
-elm_widget_sub_object_add(Evas_Object *obj, Evas_Object *sobj)
+elm_widget_sub_object_add(Evas_Object *obj,
+                          Evas_Object *sobj)
 {
    API_ENTRY return;
    double scale, pscale = elm_widget_scale_get(sobj);
@@ -747,7 +848,8 @@
 }
 
 EAPI void
-elm_widget_sub_object_del(Evas_Object *obj, Evas_Object *sobj)
+elm_widget_sub_object_del(Evas_Object *obj,
+                          Evas_Object *sobj)
 {
    Evas_Object *sobj_parent;
    API_ENTRY return;
@@ -797,7 +899,8 @@
 }
 
 EAPI void
-elm_widget_resize_object_set(Evas_Object *obj, Evas_Object *sobj)
+elm_widget_resize_object_set(Evas_Object *obj,
+                             Evas_Object *sobj)
 {
    API_ENTRY return;
    // orphan previous resize obj
@@ -871,7 +974,8 @@
 }
 
 EAPI void
-elm_widget_hover_object_set(Evas_Object *obj, Evas_Object *sobj)
+elm_widget_hover_object_set(Evas_Object *obj,
+                            Evas_Object *sobj)
 {
    API_ENTRY return;
    if (sd->hover_obj)
@@ -889,7 +993,8 @@
 }
 
 EAPI void
-elm_widget_can_focus_set(Evas_Object *obj, Eina_Bool can_focus)
+elm_widget_can_focus_set(Evas_Object *obj,
+                         Eina_Bool    can_focus)
 {
    API_ENTRY return;
    sd->can_focus = can_focus;
@@ -897,10 +1002,10 @@
      {
         evas_object_event_callback_add(obj, EVAS_CALLBACK_KEY_DOWN,
                                        _propagate_event,
-                                       (void *)(long) EVAS_CALLBACK_KEY_DOWN);
+                                       (void *)(long)EVAS_CALLBACK_KEY_DOWN);
         evas_object_event_callback_add(obj, EVAS_CALLBACK_KEY_UP,
                                        _propagate_event,
-                                       (void *)(long) EVAS_CALLBACK_KEY_UP);
+                                       (void *)(long)EVAS_CALLBACK_KEY_UP);
         evas_object_event_callback_add(obj, EVAS_CALLBACK_MOUSE_WHEEL,
                                        _propagate_event,
                                        (void *)(long)EVAS_CALLBACK_MOUSE_WHEEL);
@@ -931,7 +1036,8 @@
 }
 
 EAPI void
-elm_widget_highlight_ignore_set(Evas_Object *obj, Eina_Bool ignore)
+elm_widget_highlight_ignore_set(Evas_Object *obj,
+                                Eina_Bool    ignore)
 {
    API_ENTRY return;
    sd->highlight_ignore = !!ignore;
@@ -945,7 +1051,8 @@
 }
 
 EAPI void
-elm_widget_highlight_in_theme_set(Evas_Object *obj, Eina_Bool highlight)
+elm_widget_highlight_in_theme_set(Evas_Object *obj,
+                                  Eina_Bool    highlight)
 {
    API_ENTRY return;
    sd->highlight_in_theme = !!highlight;
@@ -1025,7 +1132,9 @@
 }
 
 EAPI void
-elm_widget_event_callback_add(Evas_Object *obj, Elm_Event_Cb func, const void *data)
+elm_widget_event_callback_add(Evas_Object *obj,
+                              Elm_Event_Cb func,
+                              const void  *data)
 {
    API_ENTRY return;
    EINA_SAFETY_ON_NULL_RETURN(func);
@@ -1036,24 +1145,29 @@
 }
 
 EAPI void *
-elm_widget_event_callback_del(Evas_Object *obj, Elm_Event_Cb func, const void *data)
+elm_widget_event_callback_del(Evas_Object *obj,
+                              Elm_Event_Cb func,
+                              const void  *data)
 {
    API_ENTRY return NULL;
    EINA_SAFETY_ON_NULL_RETURN_VAL(func, NULL);
    Eina_List *l;
    Elm_Event_Cb_Data *ecd;
    EINA_LIST_FOREACH(sd->event_cb, l, ecd)
-      if ((ecd->func == func) && (ecd->data == data))
-        {
-           free(ecd);
-           sd->event_cb = eina_list_remove_list(sd->event_cb, l);
-           return (void *)data;
-        }
+     if ((ecd->func == func) && (ecd->data == data))
+       {
+          free(ecd);
+          sd->event_cb = eina_list_remove_list(sd->event_cb, l);
+          return (void *)data;
+       }
    return NULL;
 }
 
 EAPI Eina_Bool
-elm_widget_event_propagate(Evas_Object *obj, Evas_Callback_Type type, void *event_info, Evas_Event_Flags *event_flags)
+elm_widget_event_propagate(Evas_Object       *obj,
+                           Evas_Callback_Type type,
+                           void              *event_info,
+                           Evas_Event_Flags  *event_flags)
 {
    API_ENTRY return EINA_FALSE; //TODO reduce.
    if (!_elm_widget_is(obj)) return EINA_FALSE;
@@ -1099,7 +1213,8 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_focus_custom_chain_set(Evas_Object *obj, Eina_List *objs)
+elm_widget_focus_custom_chain_set(Evas_Object *obj,
+                                  Eina_List   *objs)
 {
    API_ENTRY return;
    if (!sd->focus_next_func)
@@ -1131,7 +1246,7 @@
 elm_widget_focus_custom_chain_get(const Evas_Object *obj)
 {
    API_ENTRY return NULL;
-   return (const Eina_List *) sd->focus_chain;
+   return (const Eina_List *)sd->focus_chain;
 }
 
 /**
@@ -1173,7 +1288,9 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_focus_custom_chain_append(Evas_Object *obj, Evas_Object *child, Evas_Object *relative_child)
+elm_widget_focus_custom_chain_append(Evas_Object *obj,
+                                     Evas_Object *child,
+                                     Evas_Object *relative_child)
 {
    API_ENTRY return;
    EINA_SAFETY_ON_NULL_RETURN(child);
@@ -1209,7 +1326,9 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_focus_custom_chain_prepend(Evas_Object *obj, Evas_Object *child, Evas_Object *relative_child)
+elm_widget_focus_custom_chain_prepend(Evas_Object *obj,
+                                      Evas_Object *child,
+                                      Evas_Object *relative_child)
 {
    API_ENTRY return;
    EINA_SAFETY_ON_NULL_RETURN(child);
@@ -1244,7 +1363,8 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_focus_cycle(Evas_Object *obj, Elm_Focus_Direction dir)
+elm_widget_focus_cycle(Evas_Object        *obj,
+                       Elm_Focus_Direction dir)
 {
    Evas_Object *target = NULL;
    if (!_elm_widget_is(obj))
@@ -1269,7 +1389,9 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_focus_direction_go(Evas_Object *obj __UNUSED__, int x __UNUSED__, int y __UNUSED__)
+elm_widget_focus_direction_go(Evas_Object *obj __UNUSED__,
+                              int          x __UNUSED__,
+                              int          y __UNUSED__)
 {
    return; /* TODO */
 }
@@ -1292,7 +1414,9 @@
  * @ingroup Widget
  */
 EAPI Eina_Bool
-elm_widget_focus_next_get(const Evas_Object *obj, Elm_Focus_Direction dir, Evas_Object **next)
+elm_widget_focus_next_get(const Evas_Object  *obj,
+                          Elm_Focus_Direction dir,
+                          Evas_Object       **next)
 {
    if (!next)
      return EINA_FALSE;
@@ -1316,7 +1440,6 @@
    return !elm_widget_focus_get(obj);
 }
 
-
 /**
  * @internal
  *
@@ -1337,9 +1460,13 @@
  * @ingroup Widget
  */
 EAPI Eina_Bool
-elm_widget_focus_list_next_get(const Evas_Object *obj, const Eina_List *items, void *(*list_data_get) (const Eina_List *list), Elm_Focus_Direction dir, Evas_Object **next)
+elm_widget_focus_list_next_get(const Evas_Object  *obj,
+                               const Eina_List    *items,
+                               void *(*list_data_get)(const Eina_List * list),
+                               Elm_Focus_Direction dir,
+                               Evas_Object       **next)
 {
-   Eina_List *(*list_next) (const Eina_List *list);
+   Eina_List *(*list_next)(const Eina_List * list);
 
    if (!next)
      return EINA_FALSE;
@@ -1398,7 +1525,7 @@
    l = items;
 
    /* Get First possible */
-   for (;l != start; l = list_next(l))
+   for (; l != start; l = list_next(l))
      {
         Evas_Object *tmp = NULL;
         Evas_Object *cur = list_data_get(l);
@@ -1420,7 +1547,9 @@
 }
 
 EAPI void
-elm_widget_signal_emit(Evas_Object *obj, const char *emission, const char *source)
+elm_widget_signal_emit(Evas_Object *obj,
+                       const char  *emission,
+                       const char  *source)
 {
    API_ENTRY return;
    if (!sd->signal_func) return;
@@ -1428,14 +1557,21 @@
 }
 
 static void
-_edje_signal_callback(void *data, Evas_Object *obj __UNUSED__, const char *emission, const char *source)
+_edje_signal_callback(void        *data,
+                      Evas_Object *obj __UNUSED__,
+                      const char  *emission,
+                      const char  *source)
 {
    Edje_Signal_Data *esd = data;
    esd->func(esd->data, esd->obj, emission, source);
 }
 
 EAPI void
-elm_widget_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func, void *data)
+elm_widget_signal_callback_add(Evas_Object   *obj,
+                               const char    *emission,
+                               const char    *source,
+                               Edje_Signal_Cb func,
+                               void          *data)
 {
    Edje_Signal_Data *esd;
    API_ENTRY return;
@@ -1455,7 +1591,10 @@
 }
 
 EAPI void *
-elm_widget_signal_callback_del(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func)
+elm_widget_signal_callback_del(Evas_Object   *obj,
+                               const char    *emission,
+                               const char    *source,
+                               Edje_Signal_Cb func)
 {
    Edje_Signal_Data *esd;
    Eina_List *l;
@@ -1481,7 +1620,8 @@
 }
 
 EAPI void
-elm_widget_focus_set(Evas_Object *obj, int first)
+elm_widget_focus_set(Evas_Object *obj,
+                     int          first)
 {
    API_ENTRY return;
    if (!sd->focused)
@@ -1637,7 +1777,8 @@
 }
 
 EAPI void
-elm_widget_disabled_set(Evas_Object *obj, int disabled)
+elm_widget_disabled_set(Evas_Object *obj,
+                        int          disabled)
 {
    API_ENTRY return;
 
@@ -1668,7 +1809,11 @@
 }
 
 EAPI void
-elm_widget_show_region_set(Evas_Object *obj, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h)
+elm_widget_show_region_set(Evas_Object *obj,
+                           Evas_Coord   x,
+                           Evas_Coord   y,
+                           Evas_Coord   w,
+                           Evas_Coord   h)
 {
    Evas_Object *parent_obj, *child_obj;
    Evas_Coord px, py, cx, cy;
@@ -1709,7 +1854,11 @@
 }
 
 EAPI void
-elm_widget_show_region_get(const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h)
+elm_widget_show_region_get(const Evas_Object *obj,
+                           Evas_Coord        *x,
+                           Evas_Coord        *y,
+                           Evas_Coord        *w,
+                           Evas_Coord        *h)
 {
    API_ENTRY return;
    if (x) *x = sd->rx;
@@ -1739,7 +1888,11 @@
  * @ingroup Widget
  */
 EAPI void
-elm_widget_focus_region_get(const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h)
+elm_widget_focus_region_get(const Evas_Object *obj,
+                            Evas_Coord        *x,
+                            Evas_Coord        *y,
+                            Evas_Coord        *w,
+                            Evas_Coord        *h)
 {
    Smart_Data *sd;
 
@@ -1815,7 +1968,8 @@
 }
 
 EAPI void
-elm_widget_scale_set(Evas_Object *obj, double scale)
+elm_widget_scale_set(Evas_Object *obj,
+                     double       scale)
 {
    API_ENTRY return;
    if (scale <= 0.0) scale = 0.0;
@@ -1842,7 +1996,8 @@
 }
 
 EAPI void
-elm_widget_theme_set(Evas_Object *obj, Elm_Theme *th)
+elm_widget_theme_set(Evas_Object *obj,
+                     Elm_Theme   *th)
 {
    API_ENTRY return;
    if (sd->theme != th)
@@ -1869,7 +2024,8 @@
 }
 
 EAPI void
-elm_widget_style_set(Evas_Object *obj, const char *style)
+elm_widget_style_set(Evas_Object *obj,
+                     const char  *style)
 {
    API_ENTRY return;
 
@@ -1886,7 +2042,8 @@
 }
 
 EAPI void
-elm_widget_type_set(Evas_Object *obj, const char *type)
+elm_widget_type_set(Evas_Object *obj,
+                    const char  *type)
 {
    API_ENTRY return;
    eina_stringshare_replace(&sd->type, type);
@@ -1901,35 +2058,40 @@
 }
 
 EAPI void
-elm_widget_tooltip_add(Evas_Object *obj, Elm_Tooltip *tt)
+elm_widget_tooltip_add(Evas_Object *obj,
+                       Elm_Tooltip *tt)
 {
    API_ENTRY return;
    sd->tooltips = eina_list_append(sd->tooltips, tt);
 }
 
 EAPI void
-elm_widget_tooltip_del(Evas_Object *obj, Elm_Tooltip *tt)
+elm_widget_tooltip_del(Evas_Object *obj,
+                       Elm_Tooltip *tt)
 {
    API_ENTRY return;
    sd->tooltips = eina_list_remove(sd->tooltips, tt);
 }
 
 EAPI void
-elm_widget_cursor_add(Evas_Object *obj, Elm_Cursor *cur)
+elm_widget_cursor_add(Evas_Object *obj,
+                      Elm_Cursor  *cur)
 {
    API_ENTRY return;
    sd->cursors = eina_list_append(sd->cursors, cur);
 }
 
 EAPI void
-elm_widget_cursor_del(Evas_Object *obj, Elm_Cursor *cur)
+elm_widget_cursor_del(Evas_Object *obj,
+                      Elm_Cursor  *cur)
 {
    API_ENTRY return;
    sd->cursors = eina_list_remove(sd->cursors, cur);
 }
 
 EAPI void
-elm_widget_drag_lock_x_set(Evas_Object *obj, Eina_Bool lock)
+elm_widget_drag_lock_x_set(Evas_Object *obj,
+                           Eina_Bool    lock)
 {
    API_ENTRY return;
    if (sd->drag_x_locked == lock) return;
@@ -1939,7 +2101,8 @@
 }
 
 EAPI void
-elm_widget_drag_lock_y_set(Evas_Object *obj, Eina_Bool lock)
+elm_widget_drag_lock_y_set(Evas_Object *obj,
+                           Eina_Bool    lock)
 {
    API_ENTRY return;
    if (sd->drag_y_locked == lock) return;
@@ -1977,14 +2140,19 @@
 }
 
 EAPI Eina_Bool
-elm_widget_theme_object_set(Evas_Object *obj, Evas_Object *edj, const char *wname, const char *welement, const char *wstyle)
+elm_widget_theme_object_set(Evas_Object *obj,
+                            Evas_Object *edj,
+                            const char  *wname,
+                            const char  *welement,
+                            const char  *wstyle)
 {
    API_ENTRY return EINA_FALSE;
    return _elm_theme_object_set(obj, edj, wname, welement, wstyle);
 }
 
 EAPI Eina_Bool
-elm_widget_type_check(const Evas_Object *obj, const char *type)
+elm_widget_type_check(const Evas_Object *obj,
+                      const char        *type)
 {
    const char *provided, *expected = "(unknown)";
    static int abort_on_warn = -1;
@@ -2070,7 +2238,8 @@
  * @ingroup Widget
  */
 EAPI Elm_Widget_Item *
-_elm_widget_item_new(Evas_Object *widget, size_t alloc_size)
+_elm_widget_item_new(Evas_Object *widget,
+                     size_t       alloc_size)
 {
    if (!_elm_widget_is(widget))
      return NULL;
@@ -2162,7 +2331,8 @@
  * @ingroup Widget
  */
 EAPI void
-_elm_widget_item_del_cb_set(Elm_Widget_Item *item, Evas_Smart_Cb del_cb)
+_elm_widget_item_del_cb_set(Elm_Widget_Item *item,
+                            Evas_Smart_Cb    del_cb)
 {
    ELM_WIDGET_ITEM_CHECK_OR_RETURN(item);
 
@@ -2188,7 +2358,8 @@
  * @ingroup Widget
  */
 EAPI void
-_elm_widget_item_data_set(Elm_Widget_Item *item, const void *data)
+_elm_widget_item_data_set(Elm_Widget_Item *item,
+                          const void      *data)
 {
    ELM_WIDGET_ITEM_CHECK_OR_RETURN(item);
    if ((item->data) && (item->data != data))
@@ -2216,14 +2387,16 @@
 
 struct _Elm_Widget_Item_Tooltip
 {
-   Elm_Widget_Item             *item;
-   Elm_Tooltip_Item_Content_Cb  func;
-   Evas_Smart_Cb                del_cb;
-   const void                  *data;
+   Elm_Widget_Item            *item;
+   Elm_Tooltip_Item_Content_Cb func;
+   Evas_Smart_Cb               del_cb;
+   const void                 *data;
 };
 
 static Evas_Object *
-_elm_widget_item_tooltip_label_create(void *data, Evas_Object *obj, void *item __UNUSED__)
+_elm_widget_item_tooltip_label_create(void        *data,
+                                      Evas_Object *obj,
+                                      void        *item __UNUSED__)
 {
    Evas_Object *label = elm_label_add(obj);
    if (!label)
@@ -2234,7 +2407,9 @@
 }
 
 static void
-_elm_widget_item_tooltip_label_del_cb(void *data, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
+_elm_widget_item_tooltip_label_del_cb(void        *data,
+                                      Evas_Object *obj __UNUSED__,
+                                      void        *event_info __UNUSED__)
 {
    eina_stringshare_del(data);
 }
@@ -2253,26 +2428,30 @@
  * @ingroup Widget
  */
 EAPI void
-_elm_widget_item_tooltip_text_set(Elm_Widget_Item *item, const char *text)
+_elm_widget_item_tooltip_text_set(Elm_Widget_Item *item,
+                                  const char      *text)
 {
    ELM_WIDGET_ITEM_CHECK_OR_RETURN(item);
    EINA_SAFETY_ON_NULL_RETURN(text);
 
    text = eina_stringshare_add(text);
    _elm_widget_item_tooltip_content_cb_set
-      (item, _elm_widget_item_tooltip_label_create, text,
-       _elm_widget_item_tooltip_label_del_cb);
+     (item, _elm_widget_item_tooltip_label_create, text,
+     _elm_widget_item_tooltip_label_del_cb);
 }
 
 static Evas_Object *
-_elm_widget_item_tooltip_create(void *data, Evas_Object *obj)
+_elm_widget_item_tooltip_create(void        *data,
+                                Evas_Object *obj)
 {
    Elm_Widget_Item_Tooltip *wit = data;
    return wit->func((void *)wit->data, obj, wit->item);
 }
 
 static void
-_elm_widget_item_tooltip_del_cb(void *data, Evas_Object *obj, void *event_info __UNUSED__)
+_elm_widget_item_tooltip_del_cb(void        *data,
+                                Evas_Object *obj,
+                                void        *event_info __UNUSED__)
 {
    Elm_Widget_Item_Tooltip *wit = data;
    if (wit->del_cb) wit->del_cb((void *)wit->data, obj, wit->item);
@@ -2302,7 +2481,10 @@
  * @ingroup Widget
  */
 EAPI void
-_elm_widget_item_tooltip_content_cb_set(Elm_Widget_Item *item, Elm_Tooltip_Item_Content_Cb func, const void *data, Evas_Smart_Cb del_cb)
+_elm_widget_item_tooltip_content_cb_set(Elm_Widget_Item            *item,
+                                        Elm_Tooltip_Item_Content_Cb func,
+                                        const void                 *data,
+                                        Evas_Smart_Cb               del_cb)
 {
    Elm_Widget_Item_Tooltip *wit;
 
@@ -2322,8 +2504,8 @@
    wit->del_cb = del_cb;
 
    elm_object_sub_tooltip_content_cb_set
-      (item->view, item->widget, _elm_widget_item_tooltip_create, wit,
-       _elm_widget_item_tooltip_del_cb);
+     (item->view, item->widget, _elm_widget_item_tooltip_create, wit,
+     _elm_widget_item_tooltip_del_cb);
 
    return;
 
@@ -2371,7 +2553,8 @@
  * @ingroup Widget
  */
 EAPI void
-_elm_widget_item_tooltip_style_set(Elm_Widget_Item *item, const char *style)
+_elm_widget_item_tooltip_style_set(Elm_Widget_Item *item,
+                                   const char      *style)
 {
    ELM_WIDGET_ITEM_CHECK_OR_RETURN(item);
    elm_object_tooltip_style_set(item->view, style);
@@ -2396,7 +2579,8 @@
 }
 
 EAPI void
-_elm_widget_item_cursor_set(Elm_Widget_Item *item, const char *cursor)
+_elm_widget_item_cursor_set(Elm_Widget_Item *item,
+                            const char      *cursor)
 {
    ELM_WIDGET_ITEM_CHECK_OR_RETURN(item);
    elm_object_sub_cursor_set(item->view, item->widget, cursor);
@@ -2430,7 +2614,8 @@
  * @ingroup Widget
  */
 EAPI void
-_elm_widget_item_cursor_style_set(Elm_Widget_Item *item, const char *style)
+_elm_widget_item_cursor_style_set(Elm_Widget_Item *item,
+                                  const char      *style)
 {
    ELM_WIDGET_ITEM_CHECK_OR_RETURN(item);
    elm_object_cursor_style_set(item->view, style);
@@ -2471,7 +2656,8 @@
  * @ingroup Widget
  */
 EAPI void
-_elm_widget_item_cursor_engine_only_set(Elm_Widget_Item *item, Eina_Bool engine_only)
+_elm_widget_item_cursor_engine_only_set(Elm_Widget_Item *item,
+                                        Eina_Bool        engine_only)
 {
    ELM_WIDGET_ITEM_CHECK_OR_RETURN(item);
    elm_object_cursor_engine_only_set(item->view, engine_only);
@@ -2527,7 +2713,9 @@
 }
 
 static Evas_Object *
-_newest_focus_order_get(Evas_Object *obj, unsigned int *newest_focus_order, Eina_Bool can_focus_only)
+_newest_focus_order_get(Evas_Object  *obj,
+                        unsigned int *newest_focus_order,
+                        Eina_Bool     can_focus_only)
 {
    const Eina_List *l;
    Evas_Object *child, *ret, *best;
@@ -2555,7 +2743,8 @@
 }
 
 static void
-_if_focused_revert(Evas_Object *obj, Eina_Bool can_focus_only)
+_if_focused_revert(Evas_Object *obj,
+                   Eina_Bool    can_focus_only)
 {
    Evas_Object *top;
    Evas_Object *newest = NULL;
@@ -2627,7 +2816,9 @@
 }
 
 static void
-_smart_move(Evas_Object *obj, Evas_Coord x, Evas_Coord y)
+_smart_move(Evas_Object *obj,
+            Evas_Coord   x,
+            Evas_Coord   y)
 {
    INTERNAL_ENTRY
    sd->x = x;
@@ -2636,7 +2827,9 @@
 }
 
 static void
-_smart_resize(Evas_Object *obj, Evas_Coord w, Evas_Coord h)
+_smart_resize(Evas_Object *obj,
+              Evas_Coord   w,
+              Evas_Coord   h)
 {
    INTERNAL_ENTRY
    sd->w = w;
@@ -2666,7 +2859,7 @@
    Eina_List *list;
    Evas_Object *o;
    INTERNAL_ENTRY
-   list = evas_object_smart_members_get(obj);
+     list = evas_object_smart_members_get(obj);
    EINA_LIST_FREE(list, o)
      {
         if (evas_object_data_get(o, "_elm_leaveme")) continue;
@@ -2675,7 +2868,11 @@
 }
 
 static void
-_smart_color_set(Evas_Object *obj, int r, int g, int b, int a)
+_smart_color_set(Evas_Object *obj,
+                 int          r,
+                 int          g,
+                 int          b,
+                 int          a)
 {
    Eina_List *list;
    Evas_Object *o;
@@ -2691,7 +2888,8 @@
 }
 
 static void
-_smart_clip_set(Evas_Object *obj, Evas_Object *clip)
+_smart_clip_set(Evas_Object *obj,
+                Evas_Object *clip)
 {
    Eina_List *list;
    Evas_Object *o;
@@ -2734,47 +2932,50 @@
 _smart_init(void)
 {
    if (_e_smart) return;
-     {
-        static const Evas_Smart_Class sc =
-          {
-             SMART_NAME,
-             EVAS_SMART_CLASS_VERSION,
-             _smart_add,
-             _smart_del,
-             _smart_move,
-             _smart_resize,
-             _smart_show,
-             _smart_hide,
-             _smart_color_set,
-             _smart_clip_set,
-             _smart_clip_unset,
-             _smart_calculate,
-             NULL,
-             NULL,
-             NULL,
-             NULL,
-             NULL,
-             NULL
-          };
-        _e_smart = evas_smart_class_new(&sc);
-     }
+   {
+      static const Evas_Smart_Class sc =
+      {
+         SMART_NAME,
+         EVAS_SMART_CLASS_VERSION,
+         _smart_add,
+         _smart_del,
+         _smart_move,
+         _smart_resize,
+         _smart_show,
+         _smart_hide,
+         _smart_color_set,
+         _smart_clip_set,
+         _smart_clip_unset,
+         _smart_calculate,
+         NULL,
+         NULL,
+         NULL,
+         NULL,
+         NULL,
+         NULL
+      };
+      _e_smart = evas_smart_class_new(&sc);
+   }
 }
 
 /* happy debug functions */
 #ifdef ELM_DEBUG
 static void
-_sub_obj_tree_dump(const Evas_Object *obj, int lvl)
+_sub_obj_tree_dump(const Evas_Object *obj,
+                   int                lvl)
 {
    int i;
 
-   for (i = 0; i < lvl*3; i++)
+   for (i = 0; i < lvl * 3; i++)
      putchar(' ');
 
    if (_elm_widget_is(obj))
      {
         Eina_List *l;
         INTERNAL_ENTRY
-           printf("+ %s(%p)\n", sd->type, obj);
+        printf("+ %s(%p)\n",
+               sd->type,
+               obj);
         if (sd->resize_obj)
           _sub_obj_tree_dump(sd->resize_obj, lvl + 1);
         EINA_LIST_FOREACH(sd->subobjs, l, obj)
@@ -2788,13 +2989,14 @@
 }
 
 static void
-_sub_obj_tree_dot_dump(const Evas_Object *obj, FILE *output)
+_sub_obj_tree_dot_dump(const Evas_Object *obj,
+                       FILE              *output)
 {
    if (!_elm_widget_is(obj))
      return;
    INTERNAL_ENTRY
 
-      Eina_Bool visible = evas_object_visible_get(obj);
+   Eina_Bool visible = evas_object_visible_get(obj);
    Eina_Bool disabled = elm_widget_disabled_get(obj);
    Eina_Bool focused = elm_widget_focus_get(obj);
    Eina_Bool can_focus = elm_widget_can_focus_get(obj);
@@ -2813,7 +3015,7 @@
      }
 
    fprintf(output, "\"%p\" [ label = \"{%p|%s|%s|visible: %d|"
-           "disabled: %d|focused: %d/%d|focus order:%d}\"", obj, obj, sd->type,
+                   "disabled: %d|focused: %d/%d|focus order:%d}\"", obj, obj, sd->type,
            evas_object_name_get(obj), visible, disabled, focused, can_focus,
            sd->focus_order);
 
@@ -2826,13 +3028,12 @@
    if ((disabled) || (!visible))
      fprintf(output, ", color=gray");
 
-
    fprintf(output, " ];\n");
 
    Eina_List *l;
    Evas_Object *o;
    EINA_LIST_FOREACH(sd->subobjs, l, o)
-      _sub_obj_tree_dot_dump(o, output);
+     _sub_obj_tree_dot_dump(o, output);
 }
 #endif
 
@@ -2848,12 +3049,13 @@
 }
 
 EAPI void
-elm_widget_tree_dot_dump(const Evas_Object *top, FILE *output)
+elm_widget_tree_dot_dump(const Evas_Object *top,
+                         FILE              *output)
 {
 #ifdef ELM_DEBUG
    if (!_elm_widget_is(top))
      return;
-   fprintf(output, "graph "" { node [shape=record];\n");
+   fprintf(output, "graph " " { node [shape=record];\n");
    _sub_obj_tree_dot_dump(top, output);
    fprintf(output, "}\n");
 #else
@@ -2861,4 +3063,4 @@
    (void)top;
    (void)output;
 #endif
-}
+}
\ No newline at end of file

Log:
Elementary: Fixed wrong smart callback signal name. clicked -> clicked,double
  
  Unified double-click smart callback signal name to "clicked,double".
  Wrong signal name "clicked" is still there.
  But this will be removed soon after fixing all codes in trunk.
  

Author:       seoz
Date:         2011-04-03 02:36:47 -0700 (Sun, 03 Apr 2011)
New Revision: 58293
Trac:         http://trac.enlightenment.org/e/changeset/58293

Modified:
  trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_list.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-04-03 09:29:40 UTC (rev 58292)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-04-03 09:36:47 UTC (rev 58293)
@@ -12,7 +12,7 @@
  *
  * Signals that you can add callbacks for are:
  *
- * clicked - The user has double-clicked or pressed enter on
+ * clicked,double - The user has double-clicked or pressed enter on
  * a item. The event_infoparameter is the Gengrid item
  * that was double-clicked.
  *
@@ -436,7 +436,8 @@
             (!strcmp(ev->keyname, "space")))
      {
         item = elm_gengrid_selected_item_get(obj);
-        evas_object_smart_callback_call(item->wd->self, "clicked", item);
+        evas_object_smart_callback_call(item->wd->self, "clicked,double", item);
+        evas_object_smart_callback_call(item->wd->self, "clicked", item); // will be removed
      }
    else return EINA_FALSE;
 
@@ -851,7 +852,10 @@
    item->wd->wasselected = item->selected;
    _item_hilight(item);
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
-     evas_object_smart_callback_call(item->wd->self, "clicked", item);
+     {
+        evas_object_smart_callback_call(item->wd->self, "clicked,double", item);
+        evas_object_smart_callback_call(item->wd->self, "clicked", item); // will be removed
+     }
    if (item->long_timer) ecore_timer_del(item->long_timer);
    if (item->realized)
      item->long_timer = ecore_timer_add(_elm_config->longpress_timeout,

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-03 09:29:40 UTC (rev 58292)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-03 09:36:47 UTC (rev 58293)
@@ -17,7 +17,7 @@
  *
  * Signals that you can add callbacks for are:
  *
- * clicked - This is called when a user has double-clicked an item. The
+ * clicked,double - This is called when a user has double-clicked an item. The
  * event_info parameter is the genlist item that was double-clicked.
  *
  * selected - This is called when a user has made an item selected. The
@@ -1342,7 +1342,10 @@
    _item_highlight(it);
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
      if ((!it->disabled) && (!it->display_only))
-       evas_object_smart_callback_call(it->base.widget, "clicked", it);
+       {
+          evas_object_smart_callback_call(it->base.widget, "clicked,double", it);
+          evas_object_smart_callback_call(it->base.widget, "clicked", it); // will be removed
+       }
    if (it->long_timer) ecore_timer_del(it->long_timer);
    if (it->swipe_timer) ecore_timer_del(it->swipe_timer);
    it->swipe_timer = ecore_timer_add(0.4, _swipe_cancel, it);

Modified: trunk/elementary/src/lib/elm_list.c
===================================================================
--- trunk/elementary/src/lib/elm_list.c	2011-04-03 09:29:40 UTC (rev 58292)
+++ trunk/elementary/src/lib/elm_list.c	2011-04-03 09:36:47 UTC (rev 58293)
@@ -888,7 +888,10 @@
    it->swipe_timer = ecore_timer_add(0.4, _swipe_cancel, it);
    /* Always call the callbacks last - the user may delete our context! */
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
-     evas_object_smart_callback_call(it->base.widget, "clicked", it);
+     {
+        evas_object_smart_callback_call(it->base.widget, "clicked,double", it);
+        evas_object_smart_callback_call(it->base.widget, "clicked", it); // will be removed
+     }
    wd->swipe = EINA_FALSE;
    wd->movements = 0;

Log:
Elementary elm_gengrid.c: Fixed doxygen.
  

Author:       seoz
Date:         2011-04-03 09:06:06 -0700 (Sun, 03 Apr 2011)
New Revision: 58303
Trac:         http://trac.enlightenment.org/e/changeset/58303

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-04-03 14:32:32 UTC (rev 58302)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-04-03 16:06:06 UTC (rev 58303)
@@ -13,7 +13,7 @@
  * Signals that you can add callbacks for are:
  *
  * clicked,double - The user has double-clicked or pressed enter on
- * a item. The event_infoparameter is the Gengrid item
+ * an item. The event_info parameter is the Gengrid item
  * that was double-clicked.
  *
  * selected - The user has made an item selected. The event_info

Log:
Elementary elm_genlist.c: Fixed genlist doxygen.
  

Author:       seoz
Date:         2011-04-04 21:30:34 -0700 (Mon, 04 Apr 2011)
New Revision: 58343
Trac:         http://trac.enlightenment.org/e/changeset/58343

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-05 02:04:28 UTC (rev 58342)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-05 04:30:34 UTC (rev 58343)
@@ -187,71 +187,96 @@
  * per application with elm_theme_extension_add(). If you absolutely must
  * have a specific style that overrides any theme the user or system sets up
  * you can use elm_theme_overlay_add() to add such a file.
- 
-  * clicked,double - This is called when a user has double-clicked an item. The
+ *
+ * Signals that you can add callbacks for are:
+ *
+ * "clicked,double" - This is called when a user has double-clicked an item. The
  * event_info parameter is the genlist item that was double-clicked.
  *
- * selected - This is called when a user has made an item selected. The
+ * "selected" - This is called when a user has made an item selected. The
  * event_info parameter is the genlist item that was selected.
  *
- * unselected - This is called when a user has made an item unselected. The
+ * "unselected" - This is called when a user has made an item unselected. The
  * event_info parameter is the genlist item that was unselected.
  *
- * expanded - This is called when elm_genlist_item_expanded_set() is called
+ * "expanded" - This is called when elm_genlist_item_expanded_set() is called
  * and the item is now meant to be expanded. The event_info parameter is the
  * genlist item that was indicated to expand. It is the job of this callback
  * to then fill in the child items.
  *
- * contracted - This is called when elm_genlist_item_expanded_set() is called
+ * "contracted" - This is called when elm_genlist_item_expanded_set() is called
  * and the item is now meant to be contracted. The event_info parameter is
  * the genlist item that was indicated to contract. It is the job of this
  * callback to then delete the child items.
  *
- * expand,request - This is called when a user has indicated they want to
+ * "expand,request" - This is called when a user has indicated they want to
  * expand a tree branch item. The callback should decide if the item can
  * expand (has any children) and then call elm_genlist_item_expanded_set()
  * appropriately to set the state. The event_info parameter is the genlist
  * item that was indicated to expand.
  *
- * contract,request - This is called when a user has indicated they want to
+ * "contract,request" - This is called when a user has indicated they want to
  * contract a tree branch item. The callback should decide if the item can
  * contract (has any children) and then call elm_genlist_item_expanded_set()
  * appropriately to set the state. The event_info parameter is the genlist
  * item that was indicated to contract.
  *
- * realized - This is called when the item in the list is created as a real
+ * "realized" - This is called when the item in the list is created as a real
  * evas object. event_info parameter is the genlist item that was created.
  * The object may be deleted at any time, so it is up to the caller to
  * not use the object pointer from elm_genlist_item_object_get() in a way
  * where it may point to freed objects.
  *
- * unrealized - This is called just before an item is unrealized. After
+ * "unrealized" - This is called just before an item is unrealized. After
  * this call icon objects provided will be deleted and the item object
  * itself delete or be put into a floating cache.
  *
- * Signals that you can add callbacks for are:
+ * "drag,start,up" - This is called when the item in the list has been dragged
+ * (not scrolled) up.
  *
- * "drag,start,up" - This is called when the item in the list has been dragged
- *                   (not scrolled) up.
  * "drag,start,down" - This is called when the item in the list has been dragged
- *                     (not scrolled) down.
+ * (not scrolled) down.
+ *
  * "drag,start,left" - This is called when the item in the list has been dragged
- *                     (not scrolled) left.
+ * (not scrolled) left.
+ *
  * "drag,start,right" - This is called when the item in the list has been dragged
- *                      (not scrolled) right.
- * "drag,stop" - This is called when the item in the list has stopped being dragged.
+ * (not scrolled) right.
+ *
+ * "drag,stop" - This is called when the item in the list has stopped being
+ * dragged.
+ *
  * "drag" - This is called when the item in the list is being dragged.
+ *
  * "longpressed" - This is called when the item is pressed for a certain amount
- *                 of time. By default it's 1 second.
- * "scroll,edge,top" - This is called when the genlist is scrolled until the top edge.
- * "scroll,edge,bottom" - This is called when the genlist is scrolled until the bottom edge.
- * "scroll,edge,left" - This is called when the genlist is scrolled until the left edge.
- * "scroll,edge,right" - This is called when the genlist is scrolled until the right edge.
- * "multi,swipe,left" - This is called when the genlist is multi-touch swiped left.
- * "multi,swipe,right" - This is called when the genlist is multi-touch swiped right.
+ * of time. By default it's 1 second.
+ *
+ * "scroll,edge,top" - This is called when the genlist is scrolled until the
+ * top edge.
+ *
+ * "scroll,edge,bottom" - This is called when the genlist is scrolled until the
+ * bottom edge.
+ *
+ * "scroll,edge,left" - This is called when the genlist is scrolled until the
+ * left edge.
+ *
+ * "scroll,edge,right" - This is called when the genlist is scrolled until the
+ * right edge.
+ *
+ * "multi,swipe,left" - This is called when the genlist is multi-touch swiped
+ * left.
+ *
+ * "multi,swipe,right" - This is called when the genlist is multi-touch swiped
+ * right.
+ *
  * "multi,swipe,up" - This is called when the genlist is multi-touch swiped up.
- * "multi,swipe,down" - This is called when the genlist is multi-touch swiped down.
- * "multi,pinch,out" - This is called when the genlist is multi-touch pinched out.
+ *
+ * "multi,swipe,down" - This is called when the genlist is multi-touch swiped
+ * down.
+ *
+ * "multi,pinch,out" - This is called when the genlist is multi-touch pinched
+ * out.
+ *
  * "multi,pinch,in" - This is called when the genlist is multi-touch pinched in.
  */

Log:
Elementary elm_genlist.c: Fixed formatting. Fits to ecrustify.
  

Author:       seoz
Date:         2011-04-06 17:58:29 -0700 (Wed, 06 Apr 2011)
New Revision: 58401
Trac:         http://trac.enlightenment.org/e/changeset/58401

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-06 23:59:52 UTC (rev 58400)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-07 00:58:29 UTC (rev 58401)
@@ -443,7 +443,9 @@
                              Evas_Object       *src,
                              Evas_Callback_Type type,
                              void              *event_info);
-static void      _signal_emit_hook(Evas_Object *obj, const char *emission, const char *source);
+static void      _signal_emit_hook(Evas_Object *obj,
+                                   const char *emission,
+                                   const char *source);
 static Eina_Bool _deselect_all_items(Widget_Data *wd);
 static void      _pan_calculate(Evas_Object *obj);
 
@@ -816,7 +818,9 @@
 }
 
 static void
-_signal_emit_hook(Evas_Object *obj, const char *emission, const char *source)
+_signal_emit_hook(Evas_Object *obj,
+                  const char  *emission,
+                  const char  *source)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    edje_object_signal_emit(elm_smart_scroller_edje_object_get(wd->scr),

Log:
Elementary genlist: Removed unnecessary 'const'.
  

Author:       seoz
Date:         2011-04-07 09:16:01 -0700 (Thu, 07 Apr 2011)
New Revision: 58458
Trac:         http://trac.enlightenment.org/e/changeset/58458

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-04-07 15:25:19 UTC (rev 58457)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-04-07 16:16:01 UTC (rev 58458)
@@ -1844,7 +1844,7 @@
    EAPI const char        *elm_genlist_item_cursor_style_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
    EAPI void               elm_genlist_item_cursor_engine_only_set(Elm_Genlist_Item *item, Eina_Bool engine_only) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool          elm_genlist_item_cursor_engine_only_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
-   EAPI void               elm_genlist_realized_items_update(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void               elm_genlist_realized_items_update(Evas_Object *obj) EINA_ARG_NONNULL(1);
    /* smart callbacks called:
     * "clicked,double" - This is called when a user has double-clicked an item. The
     *                    event_info parameter is the genlist item that was double-clicked.

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-07 15:25:19 UTC (rev 58457)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-07 16:16:01 UTC (rev 58458)
@@ -4932,7 +4932,7 @@
  * @ingroup Genlist
  */
 EAPI void
-elm_genlist_realized_items_update(const Evas_Object *obj)
+elm_genlist_realized_items_update(Evas_Object *obj)
 {
    ELM_CHECK_WIDTYPE(obj, widtype);

Log:
Elementary genlist: Removed unnecessary blank lines.
  

Author:       seoz
Date:         2011-04-07 09:20:29 -0700 (Thu, 07 Apr 2011)
New Revision: 58459
Trac:         http://trac.enlightenment.org/e/changeset/58459

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-07 16:16:01 UTC (rev 58458)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-07 16:20:29 UTC (rev 58459)
@@ -4943,5 +4943,3 @@
    EINA_LIST_FOREACH(list, l, it)
      elm_genlist_item_update(it);
 }
-
-

Log:
Elementary map: Fixed map bug and added null check routine.
  

Author:       seoz
Date:         2011-04-08 05:13:29 -0700 (Fri, 08 Apr 2011)
New Revision: 58489
Trac:         http://trac.enlightenment.org/e/changeset/58489

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-04-08 11:08:58 UTC (rev 58488)
+++ trunk/elementary/src/lib/elm_map.c	2011-04-08 12:13:29 UTC (rev 58489)
@@ -51,7 +51,7 @@
 #define DEST_DIR_ZOOM_PATH "/tmp/elm_map/%d/%d/"
 #define DEST_DIR_PATH DEST_DIR_ZOOM_PATH"%d/"
 #define DEST_FILE_PATH "%s%d.png"
-#define DEST_XML_FILE "/tmp/elm_map-XXXXXX.xml"
+#define DEST_XML_FILE "/tmp/elm_map-XXXXXX"
 
 #define ROUTE_YOURS_URL "http://www.yournavigation.org/api/dev/route.php"
 #define ROUTE_TYPE_MOTORCAR "motocar"
@@ -4204,6 +4204,7 @@
 EAPI void
 elm_map_route_color_set(Elm_Map_Route *route, int r, int g , int b, int a)
 {
+   EINA_SAFETY_ON_NULL_RETURN(route);
    route->color.r = r;
    route->color.g = g;
    route->color.b = b;
@@ -4224,6 +4225,7 @@
 EAPI void
 elm_map_route_color_get(Elm_Map_Route *route, int *r, int *g , int *b, int *a)
 {
+   EINA_SAFETY_ON_NULL_RETURN(route);
    if (*r) *r = route->color.r;
    if (*g) *g = route->color.g;
    if (*b) *b = route->color.b;
@@ -4241,6 +4243,7 @@
 EAPI double
 elm_map_route_distance_get(Elm_Map_Route *route)
 {
+   EINA_SAFETY_ON_NULL_RETURN_VAL(route, 0.0);
    return route->info.distance;
 }
 
@@ -4256,6 +4259,7 @@
 EAPI const char*
 elm_map_route_node_get(Elm_Map_Route *route)
 {
+   EINA_SAFETY_ON_NULL_RETURN_VAL(route, NULL);
    return route->info.nodes;
 }
 
@@ -4271,6 +4275,7 @@
 EAPI const char*
 elm_map_route_waypoint_get(Elm_Map_Route *route)
 {
+   EINA_SAFETY_ON_NULL_RETURN_VAL(route, NULL);
    return route->info.waypoints;
 }

Log:
Elementary src/lib: Removed all trailing whitespaces.
  

Author:       seoz
Date:         2011-04-08 07:36:29 -0700 (Fri, 08 Apr 2011)
New Revision: 58492
Trac:         http://trac.enlightenment.org/e/changeset/58492

Modified:
  trunk/elementary/src/lib/elc_fileselector_button.c trunk/elementary/src/lib/elm_bg.c trunk/elementary/src/lib/elm_box.c trunk/elementary/src/lib/elm_entry.c trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_index.c trunk/elementary/src/lib/elm_main.c trunk/elementary/src/lib/elm_map.c trunk/elementary/src/lib/elm_menu.c trunk/elementary/src/lib/elm_photocam.c trunk/elementary/src/lib/elm_separator.c trunk/elementary/src/lib/elm_slider.c trunk/elementary/src/lib/elm_toggle.c trunk/elementary/src/lib/elm_transit.c trunk/elementary/src/lib/els_icon.c 

Modified: trunk/elementary/src/lib/elc_fileselector_button.c
===================================================================
--- trunk/elementary/src/lib/elc_fileselector_button.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elc_fileselector_button.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -10,8 +10,8 @@
  * exposed as an evas_object_smart_callback_call() of the button.
  *
  * Signals that you can add callbacks for are:
- * 
- * "file,chosen" - the user has selected a path, whose string pointer comes 
+ *
+ * "file,chosen" - the user has selected a path, whose string pointer comes
  *                 as event info
  *
  */

Modified: trunk/elementary/src/lib/elm_bg.c
===================================================================
--- trunk/elementary/src/lib/elm_bg.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_bg.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -49,7 +49,7 @@
    if (wd->overlay)
      edje_object_part_swallow(wd->base, "elm.swallow.content", wd->overlay);
 
-   // FIXME: if i don't do this, bg doesnt calc correctly. why?   
+   // FIXME: if i don't do this, bg doesnt calc correctly. why?
    evas_object_geometry_get(wd->base, NULL, NULL, &w, &h);
    evas_object_resize(wd->base, w, h);
 }
@@ -236,7 +236,7 @@
  * @param obj The bg object
  * @param option The desired background option (TILE, SCALE)
  *
- * This sets the option used for manipulating the display of the background 
+ * This sets the option used for manipulating the display of the background
  * image. The image can be tiled or scaled.
  *
  * @ingroup Bg

Modified: trunk/elementary/src/lib/elm_box.c
===================================================================
--- trunk/elementary/src/lib/elm_box.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_box.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -835,7 +835,7 @@
  * @param obj The Elm_Box
  * @param horizontal The horizontal space between elements
  * @param vertical The vertical space between elements
- * 
+ *
  * @ingroup Box
  */
 EAPI void
@@ -871,7 +871,7 @@
  * @param obj The Elm_Box
  * @param horizontal The horizontal alignment of elements
  * @param vertical The vertical alignment of elements
- * 
+ *
  * @ingroup Box
  */
 EAPI void

Modified: trunk/elementary/src/lib/elm_entry.c
===================================================================
--- trunk/elementary/src/lib/elm_entry.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_entry.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -73,9 +73,9 @@
  * The file to load and save to is specified by elm_entry_file_set().
  *
  * Signals that you can add callbacks for are:
- * 
+ *
  * "changed" - The text within the entry was changed
- * "activated" - The entry has had editing finished and changes are to be committed 
+ * "activated" - The entry has had editing finished and changes are to be committed
                  (generally when enter key is pressed)
  * "press" - The entry has been clicked
  * "longpressed" - The entry has been clicked for a couple seconds

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -101,7 +101,7 @@
  * absolutely must have a specific style that overrides any theme the
  * user or system sets up you can use elm_theme_overlay_add() to add
  * such a file.
- * 
+ *
  * Signals that you can add callbacks for are:
  *
  * "clicked,double" - The user has double-clicked or pressed enter on
@@ -115,7 +115,7 @@
  *              as a real evas object. event_info is the Gengrid item that was
  *              created. The object may be deleted at any time, so it is up to
  *              the caller to not use the object pointer from
- *              elm_gengrid_item_object_get() in a way where it may point to 
+ *              elm_gengrid_item_object_get() in a way where it may point to
  *              freed objects.
  * "unrealized" - This is called when the real evas object for this item
  *                is deleted. event_info is the Gengrid item that was created.

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -208,7 +208,7 @@
  * "expand,request" - This is called when a user has indicated they want to
  *                    expand a tree branch item. The callback should decide if
  *                    the item can expand (has any children) and then call
- *                    elm_genlist_item_expanded_set() appropriately to set the 
+ *                    elm_genlist_item_expanded_set() appropriately to set the
  *                    state. The event_info parameter is the genlist item that
  *                    was indicated to expand.
  * "contract,request" - This is called when a user has indicated they want to
@@ -220,7 +220,7 @@
  * "realized" - This is called when the item in the list is created as a real
  *              evas object. event_info parameter is the genlist item that was
  *              created. The object may be deleted at any time, so it is up to
- *              the caller to not use the object pointer from 
+ *              the caller to not use the object pointer from
  *              elm_genlist_item_object_get() in a way  where it may point to
  *              freed objects.
  * "unrealized" - This is called just before an item is unrealized. After this
@@ -232,7 +232,7 @@
  *                     (not scrolled) down.
  * "drag,start,left" - This is called when the item in the list has been dragged
  *                     (not scrolled) left.
- * "drag,start,right" - This is called when the item in the list has been 
+ * "drag,start,right" - This is called when the item in the list has been
  *                      dragged (not scrolled) right.
  * "drag,stop" - This is called when the item in the list has stopped being
  *               dragged.

Modified: trunk/elementary/src/lib/elm_index.c
===================================================================
--- trunk/elementary/src/lib/elm_index.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_index.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -13,7 +13,7 @@
  * "delay,changed" - when the selected index item changes, but after some small i
  *                   dle period
  * "selected" - when the user releases a finger and selects an item
- * "level,up" - when the user moves a finger from the first level to the second 
+ * "level,up" - when the user moves a finger from the first level to the second
  *              level
  * "level,down" - when the user moves a finger from the second level to the first *                level
  */

Modified: trunk/elementary/src/lib/elm_main.c
===================================================================
--- trunk/elementary/src/lib/elm_main.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_main.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -2014,7 +2014,7 @@
  * Set the configured cache flush enabled state for all applications on the
  * display
  *
- * This sets the globally configured cache flush enabled state for all 
+ * This sets the globally configured cache flush enabled state for all
  * applications on the display.
  *
  * @param size The cache flush enabled state
@@ -3347,7 +3347,7 @@
  * @param data A pointer to data to pass in to the callback function.
  * @ingroup General
  */
-EAPI void 
+EAPI void
 elm_object_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, void (*func) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
 {
     EINA_SAFETY_ON_NULL_RETURN(obj);

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_map.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -61,7 +61,7 @@
 #define YOURS_DESCRIPTION "description"
 #define YOURS_COORDINATES "coordinates"
 
-// TODO: fix monav & ors url 
+// TODO: fix monav & ors url
 #define ROUTE_MONAV_URL "http://"
 #define ROUTE_ORS_URL "http:///"
 
@@ -4076,7 +4076,7 @@
         free(route);
         return NULL;
      }
-   
+
    route->con_url = ecore_con_url_new(NULL);
    route->ud.fname = strdup(buf);
    INF("xml file : %s", route->ud.fname);

Modified: trunk/elementary/src/lib/elm_menu.c
===================================================================
--- trunk/elementary/src/lib/elm_menu.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_menu.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -10,7 +10,7 @@
  *
  * Signals that you can add callbacks for are:
  *
- * "clicked" - the user clicked the empty space in the menu to dismiss. 
+ * "clicked" - the user clicked the empty space in the menu to dismiss.
  *             event_info is NULL.
  */
 

Modified: trunk/elementary/src/lib/elm_photocam.c
===================================================================
--- trunk/elementary/src/lib/elm_photocam.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_photocam.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -22,7 +22,7 @@
  * "loaded" - This is called when the image file load is complete for the first
  *            view (low resolution blurry version).
  * "load,details" - Photo detailed data load begins.
- * "loaded,details" - This is called when the image file load is complete for 
+ * "loaded,details" - This is called when the image file load is complete for
  *                    the detailed image data (full resolution needed).
  * "zoom,start" - Zoom animation started.
  * "zoom,stop" - Zoom animation stopped.

Modified: trunk/elementary/src/lib/elm_separator.c
===================================================================
--- trunk/elementary/src/lib/elm_separator.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_separator.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -4,7 +4,7 @@
 /**
  * @defgroup Separator Separator
  *
- * A separator is a widget that adds a very thin object to separate other 
+ * A separator is a widget that adds a very thin object to separate other
  * objects.
  * A separator can be vertical or horizontal.
  */

Modified: trunk/elementary/src/lib/elm_slider.c
===================================================================
--- trunk/elementary/src/lib/elm_slider.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_slider.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -32,8 +32,8 @@
  * "slider,drag,start" - dragging the slider indicator around has started
  * "slider,drag,stop" - dragging the slider indicator around has stopped
  * "delay,changed" - A short time after the value is changed by the user.
- *                   This will be called only when the user stops dragging for 
- *                   a very short period or when they release their 
+ *                   This will be called only when the user stops dragging for
+ *                   a very short period or when they release their
  *                   finger/mouse, so it avoids possibly expensive reactions to
  *                   the value change.
  */

Modified: trunk/elementary/src/lib/elm_toggle.c
===================================================================
--- trunk/elementary/src/lib/elm_toggle.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_toggle.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -9,8 +9,8 @@
  *
  * Signals that you can add callbacks for are:
  *
- * "changed" - Whenever the toggle value has been changed.  Is not called until 
- *             the toggle is released by the cursor (assuming it has been 
+ * "changed" - Whenever the toggle value has been changed.  Is not called until
+ *             the toggle is released by the cursor (assuming it has been
  *             triggered by the cursor in the first place).
  */
 

Modified: trunk/elementary/src/lib/elm_transit.c
===================================================================
--- trunk/elementary/src/lib/elm_transit.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/elm_transit.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -1021,13 +1021,13 @@
 }
 
 /**
- * Makes the chain relationship between two transits. 
+ * Makes the chain relationship between two transits.
  *
  * @note @p transit can not be NULL. Transit would have multiple chain transits.
- * @note @p chain_transit can not be NULL. Chain transits could be chained to the only one transit. 
+ * @note @p chain_transit can not be NULL. Chain transits could be chained to the only one transit.
  *
- * @param transit The transit object.  
- * @param chain_transit The chain transit object. This transit will be operated  *                      after transit is done. 
+ * @param transit The transit object.
+ * @param chain_transit The chain transit object. This transit will be operated  *                      after transit is done.
  *
  * @ingroup Transit
  */
@@ -1048,12 +1048,12 @@
 }
 
 /**
- * Get the current chain transit list.  
+ * Get the current chain transit list.
  *
  * @note @p transit can not be NULL.
  *
- * @param transit The transit object.  
- * @return chain transit list. 
+ * @param transit The transit object.
+ * @return chain transit list.
  *
  * @ingroup Transit
  */

Modified: trunk/elementary/src/lib/els_icon.c
===================================================================
--- trunk/elementary/src/lib/els_icon.c	2011-04-08 14:30:48 UTC (rev 58491)
+++ trunk/elementary/src/lib/els_icon.c	2011-04-08 14:36:29 UTC (rev 58492)
@@ -74,7 +74,7 @@
         sd->obj = evas_object_image_add(evas_object_evas_get(obj));
         evas_object_image_scale_hint_set(sd->obj, EVAS_IMAGE_SCALE_HINT_STATIC);
         evas_object_smart_member_add(sd->obj, obj);
-        evas_object_event_callback_add(sd->obj, EVAS_CALLBACK_IMAGE_PRELOADED, 
+        evas_object_event_callback_add(sd->obj, EVAS_CALLBACK_IMAGE_PRELOADED,
                                        _preloaded, sd);
         evas_object_clip_set(sd->obj, pclip);
         sd->edje = EINA_FALSE;

Log:
Elementary actionslider: Fixed doxygen.
  

Author:       seoz
Date:         2011-04-08 09:56:09 -0700 (Fri, 08 Apr 2011)
New Revision: 58494
Trac:         http://trac.enlightenment.org/e/changeset/58494

Modified:
  trunk/elementary/src/lib/elm_actionslider.c 

Modified: trunk/elementary/src/lib/elm_actionslider.c
===================================================================
--- trunk/elementary/src/lib/elm_actionslider.c	2011-04-08 16:10:16 UTC (rev 58493)
+++ trunk/elementary/src/lib/elm_actionslider.c	2011-04-08 16:56:09 UTC (rev 58494)
@@ -1,7 +1,7 @@
 /**
  * @addtogroup Actionslider Actionslider
  *
- * A magnet slider is a switcher for 3 labels with customizable
+ * A actionslider is a switcher for 3 labels with customizable
  * magnet properties. When the position is set with magnet, the knob
  * will be moved to it if it's nearest the magnetized position.
  *

Log:
Elementary list: Fixed doxygen for "clicked,double" callback.
  

Author:       seoz
Date:         2011-04-12 07:16:41 -0700 (Tue, 12 Apr 2011)
New Revision: 58595
Trac:         http://trac.enlightenment.org/e/changeset/58595

Modified:
  trunk/elementary/src/lib/elm_list.c 

Modified: trunk/elementary/src/lib/elm_list.c
===================================================================
--- trunk/elementary/src/lib/elm_list.c	2011-04-12 14:00:50 UTC (rev 58594)
+++ trunk/elementary/src/lib/elm_list.c	2011-04-12 14:16:41 UTC (rev 58595)
@@ -11,7 +11,7 @@
  *
  * Signals that you can add callbacks for are:
  *
- * "clicked" - when the user double-clicked an item
+ * "clicked,double" - when the user double-clicked an item
  * "selected" - when the user selected an item
  * "unselected" - when the user selected an item
  * "longpressed" - an item in the hoversel list is long-pressed

Log:
Elementary gengrid: Fixed doxygen typo.
  

Author:       seoz
Date:         2011-04-12 10:32:36 -0700 (Tue, 12 Apr 2011)
New Revision: 58597
Trac:         http://trac.enlightenment.org/e/changeset/58597

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-04-12 17:29:59 UTC (rev 58596)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-04-12 17:32:36 UTC (rev 58597)
@@ -975,11 +975,11 @@
    EAPI Elm_Gengrid_Item  *elm_gengrid_item_insert_after(Evas_Object *obj, const Elm_Gengrid_Item_Class *gic, const void *data, Elm_Gengrid_Item *relative, Evas_Smart_Cb func, const void *func_data) EINA_ARG_NONNULL(1);
    /* smart callbacks called:
     *
-    * selected - User has selected a item.
-    * unselected - User has unselected a item.
-    * clicked,double - User has double-clicked or pressed enter on a item.
-    * realized - An evas object for a item was built.
-    * unrealized - An evas object for a item was deleted.
+    * selected - User has selected an item.
+    * unselected - User has unselected an item.
+    * clicked,double - User has double-clicked or pressed enter on an item.
+    * realized - An evas object for an item was built.
+    * unrealized - An evas object for an item was deleted.
     * changed - An item has been added, removed, resized or moved,
     * or gengrid has been resized or horizontal property has been changed.
     * scroll - the content has been scrolled (moved).

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-04-12 17:29:59 UTC (rev 58596)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-04-12 17:32:36 UTC (rev 58597)
@@ -24,7 +24,7 @@
  * application provides a structure with information about that type
  * of item (Gengrid may contain multiple different items with
  * different classes, states and styles). Gengrid will call the
- * functions in this struct (methods) when a item is "realized" (that
+ * functions in this struct (methods) when an item is "realized" (that
  * is created dynamically while scrolling). All objects will simply be
  * deleted when no longer needed with evas_object_del(). The
  * Elm_GenGrid_Item_Class structure contains the following members:
@@ -61,7 +61,7 @@
  * where XXX is the name of the part.
  *
  * func.del - This is called when elm_gengrid_item_del() is called on
- * a item or elm_gengrid_clear() is called on the Gengrid. This is
+ * an item or elm_gengrid_clear() is called on the Gengrid. This is
  * intended for use when actual Gengrid items are deleted, so any
  * backing data attached to the item (e.g. its data parameter on
  * creation) can be deleted.
@@ -75,14 +75,14 @@
  * only valid as long as no items are modified (added, deleted,
  * selected or unselected).
  *
- * If a item changes (state of boolean changes, label or icons
+ * If an item changes (state of boolean changes, label or icons
  * change), then use elm_gengrid_item_update() to have Gengrid update
  * the item with the new state. Gengrid will re-realize the item thus
  * call the functions in the _Elm_Gengrid_Item_Class for that item.
  *
- * To programmatically (un)select a item use
+ * To programmatically (un)select an item use
  * elm_gengrid_item_selected_set().  To get its selected state use
- * elm_gengrid_item_selected_get(). To make a item disabled (unable to
+ * elm_gengrid_item_selected_get(). To make an item disabled (unable to
  * be selected and appear differently) use
  * elm_gengrid_item_disabled_set() to set this and
  * elm_gengrid_item_disabled_get() to get the disabled state.
@@ -105,7 +105,7 @@
  * Signals that you can add callbacks for are:
  *
  * "clicked,double" - The user has double-clicked or pressed enter on
- *                    a item. The event_infoparameter is the Gengrid item
+ *                    an item. The event_infoparameter is the Gengrid item
  *                    that was double-clicked.
  * "selected" - The user has made an item selected. The event_info
  *              parameter is the Gengrid item that was selected.
@@ -1874,7 +1874,7 @@
 }
 
 /**
- * Remove a item from the Gengrid.
+ * Remove an item from the Gengrid.
  *
  * @param item The item to be removed.
  * @return @c EINA_TRUE on success or @c EINA_FALSE otherwise.
@@ -2034,7 +2034,7 @@
 }
 
 /**
- * Returns the data associated to a item
+ * Returns the data associated to an item
  *
  * This returns the data value passed on the elm_gengrid_item_append()
  * and related item addition calls.
@@ -2055,7 +2055,7 @@
 }
 
 /**
- * Set the data item from the gengrid item
+ * Set the datan item from the gengrid item
  *
  * This set the data value passed on the elm_gengrid_item_append() and
  * related item addition calls. This function will also call
@@ -2184,9 +2184,9 @@
 }
 
 /**
- * Set the selected state of a item.
+ * Set the selected state of an item.
  *
- * This sets the selected state of a item. If multi-select is not
+ * This sets the selected state of an item. If multi-select is not
  * enabled and selected is EINA_TRUE, previously selected items are
  * unselected.
  *
@@ -2221,9 +2221,9 @@
 }
 
 /**
- * Get the selected state of a item.
+ * Get the selected state of an item.
  *
- * This gets the selected state of a item (1 selected, 0 not selected).
+ * This gets the selected state of an item (1 selected, 0 not selected).
  *
  * @param item The item
  * @return The selected state
@@ -2238,7 +2238,7 @@
 }
 
 /**
- * Sets the disabled state of a item.
+ * Sets the disabled state of an item.
  *
  * A disabled item cannot be selected or unselected. It will also
  * change appearance to disabled. This sets the disabled state (1
@@ -2267,7 +2267,7 @@
 }
 
 /**
- * Get the disabled state of a item.
+ * Get the disabled state of an item.
  *
  * This gets the disabled state of the given item.
  *
@@ -2341,7 +2341,7 @@
  * @param data what to provide to @a func as callback data/context.
  * @param del_cb called when data is not needed anymore, either when
  *        another callback replaces @func, the tooltip is unset with
- *        elm_gengrid_item_tooltip_unset() or the owner @a item
+ *        elm_gengrid_item_tooltip_unset() or the owner @an item
  *        dies. This callback receives as the first parameter the
  *        given @a data, and @c event_info is the item.
  *

Log:
Elementary genlist: Avoid bringing/showing items in a queue.
  
  Items in a queue were not added to blocks yet. So it's impossible to
  calculate its position.
  

Author:       seoz
Date:         2011-04-12 18:48:11 -0700 (Tue, 12 Apr 2011)
New Revision: 58612
Trac:         http://trac.enlightenment.org/e/changeset/58612

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-12 23:48:40 UTC (rev 58611)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-13 01:48:11 UTC (rev 58612)
@@ -2180,7 +2180,7 @@
         itb->h = itb->minh;
         y += itb->h;
         in += itb->count;
-        if ((showme) && (wd->show_item))
+        if ((showme) && (wd->show_item) && (!wd->show_item->queued))
           {
              wd->show_item->showme = EINA_FALSE;
              if (wd->bring_in)

Log:
Elementary genlist: Do not call "realized"/"unrealized" smart
  callbacks if those are internal size calculation purpose.
  

Author:       seoz
Date:         2011-04-14 04:41:07 -0700 (Thu, 14 Apr 2011)
New Revision: 58660
Trac:         http://trac.enlightenment.org/e/changeset/58660

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-14 11:37:09 UTC (rev 58659)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-14 11:41:07 UTC (rev 58660)
@@ -430,7 +430,7 @@
 static void      _show_region_hook(void        *data,
                                    Evas_Object *obj);
 static void      _sizing_eval(Evas_Object *obj);
-static void      _item_unrealize(Elm_Genlist_Item *it);
+static void      _item_unrealize(Elm_Genlist_Item *it, Eina_Bool calc);
 static void      _item_block_unrealize(Item_Block *itb);
 static void      _calc_job(void *data);
 static void      _on_focus_hook(void        *data,
@@ -916,7 +916,7 @@
    it->wd->walking -= it->walking;
    if (it->wd->show_item == it) it->wd->show_item = NULL;
    if (it->selected) it->wd->selected = eina_list_remove(it->wd->selected, it);
-   if (it->realized) _item_unrealize(it);
+   if (it->realized) _item_unrealize(it, EINA_FALSE);
    if (it->block) _item_block_del(it);
    if ((!it->delete_me) && (it->itc->func.del))
      it->itc->func.del((void *)it->base.data, it->base.widget);
@@ -1410,7 +1410,7 @@
      {
         if (it->want_unrealize)
           {
-             _item_unrealize(it);
+             _item_unrealize(it, EINA_FALSE);
              if (it->block->want_unrealize)
                _item_block_unrealize(it->block);
           }
@@ -1878,16 +1878,16 @@
    it->want_unrealize = EINA_FALSE;
 
    if (itc) _item_cache_free(itc);
-   evas_object_smart_callback_call(it->base.widget, "realized", it);
+   if (!calc) evas_object_smart_callback_call(it->base.widget, "realized", it);
 }
 
 static void
-_item_unrealize(Elm_Genlist_Item *it)
+_item_unrealize(Elm_Genlist_Item *it, Eina_Bool calc)
 {
    Evas_Object *icon;
 
    if (!it->realized) return;
-   evas_object_smart_callback_call(it->base.widget, "unrealized", it);
+   if (!calc) evas_object_smart_callback_call(it->base.widget, "unrealized", it);
    if (it->long_timer)
      {
         ecore_timer_del(it->long_timer);
@@ -1944,13 +1944,13 @@
                   if (changed)
                     {
                        _item_realize(it, in, EINA_TRUE);
-                       _item_unrealize(it);
+                       _item_unrealize(it, EINA_TRUE);
                     }
                }
              else
                {
                   _item_realize(it, in, EINA_TRUE);
-                  _item_unrealize(it);
+                  _item_unrealize(it, EINA_TRUE);
                }
           }
         else
@@ -2007,7 +2007,7 @@
                   it->want_unrealize = EINA_TRUE;
                }
              else
-               _item_unrealize(it);
+               _item_unrealize(it, EINA_FALSE);
           }
      }
    if (!dragging)
@@ -2069,7 +2069,7 @@
                     }
                   else
                     {
-                       if (!it->dragging) _item_unrealize(it);
+                       if (!it->dragging) _item_unrealize(it, EINA_FALSE);
                     }
                }
              in++;
@@ -2103,7 +2103,7 @@
         else if (!git->want_realize && git->realized)
           {
              if (!git->dragging)
-               _item_unrealize(git);
+               _item_unrealize(git, EINA_FALSE);
           }
      }
 }
@@ -2282,14 +2282,14 @@
                   it->updateme = EINA_FALSE;
                   if (it->realized)
                     {
-                       _item_unrealize(it);
+                       _item_unrealize(it, EINA_FALSE);
                        _item_realize(it, num, EINA_FALSE);
                        position = 1;
                     }
                   else
                     {
                        _item_realize(it, num, EINA_TRUE);
-                       _item_unrealize(it);
+                       _item_unrealize(it, EINA_TRUE);
                     }
                   if ((it->minw != itminw) || (it->minh != itminh))
                     recalc = 1;
@@ -3179,7 +3179,7 @@
         if (it->flags & ELM_GENLIST_ITEM_GROUP)
           it->wd->group_items = eina_list_remove(it->wd->group_items, it);
         elm_widget_item_pre_notify_del(it);
-        if (it->realized) _item_unrealize(it);
+        if (it->realized) _item_unrealize(it, EINA_FALSE);
         if (((wd->clear_me) || (!it->delete_me)) && (it->itc->func.del))
           it->itc->func.del((void *)it->base.data, it->base.widget);
         if (it->long_timer) ecore_timer_del(it->long_timer);
@@ -4041,7 +4041,7 @@
                                               it);
         if (it->block)
           {
-             if (it->realized) _item_unrealize(it);
+             if (it->realized) _item_unrealize(it, EINA_FALSE);
              it->block->changed = EINA_TRUE;
              if (it->wd->calc_job) ecore_job_del(it->wd->calc_job);
              it->wd->calc_job = ecore_job_add(_calc_job, it->wd);

Log:
Elementary map: Fixed doxygen, removed trailing whitespaces.
  

Author:       seoz
Date:         2011-04-18 00:37:49 -0700 (Mon, 18 Apr 2011)
New Revision: 58704
Trac:         http://trac.enlightenment.org/e/changeset/58704

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-04-18 06:42:47 UTC (rev 58703)
+++ trunk/elementary/src/lib/elm_map.c	2011-04-18 07:37:49 UTC (rev 58704)
@@ -3409,8 +3409,9 @@
  * @param obj The map object
  * @param lon the longitude
  * @param lat the latitude
- * @param name the adress 
  *
+ * @return name the address
+ *
  * @ingroup Map
  */
 EAPI Elm_Map_Name *
@@ -3424,10 +3425,11 @@
  * Convert a name (address) into a geographic coordinate (longitude, latitude).
  *
  * @param obj The map object
- * @param name the adress 
- * @param lon the longitude correspond to x
+ * @param name the address
  * @param lat the latitude correspond to y
  *
+ * @return name the address
+ *
  * @ingroup Map
  */
 EAPI Elm_Map_Name *
@@ -3445,6 +3447,7 @@
  * @param lon the longitude
  * @param lat the latitude
  * @param clas the class to use
+ * @param clas_group the class group
  * @param data the data passed to the callbacks
  *
  * @return The marker object

Log:
Elementary gengrid: Fixed a warning.
  

Author:       seoz
Date:         2011-04-18 17:58:39 -0700 (Mon, 18 Apr 2011)
New Revision: 58721
Trac:         http://trac.enlightenment.org/e/changeset/58721

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-04-18 20:02:12 UTC (rev 58720)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-04-19 00:58:39 UTC (rev 58721)
@@ -1937,7 +1937,7 @@
 EAPI Eina_Bool
 elm_gengrid_horizontal_get(const Evas_Object *obj)
 {
-   ELM_CHECK_WIDTYPE(obj, widtype);
+   ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE;
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return EINA_FALSE;
    return wd->horizontal;

Log:
Elementary conform: Fixing indentation, coding guideline. Patch by
  Prince <prince.dubey@...>
  

Author:       seoz
Date:         2011-04-19 00:31:59 -0700 (Tue, 19 Apr 2011)
New Revision: 58730
Trac:         http://trac.enlightenment.org/e/changeset/58730

Modified:
  trunk/elementary/src/lib/elm_conform.c 

Modified: trunk/elementary/src/lib/elm_conform.c
===================================================================
--- trunk/elementary/src/lib/elm_conform.c	2011-04-19 06:16:21 UTC (rev 58729)
+++ trunk/elementary/src/lib/elm_conform.c	2011-04-19 07:31:59 UTC (rev 58730)
@@ -16,11 +16,12 @@
    Evas_Object *shelf, *panel;
    Evas_Object *content;
    Ecore_Event_Handler *prop_hdl;
-   struct {
-        Ecore_Animator *animator; // animaton timer
-        double start; // time started
-        Evas_Coord auto_x, auto_y; // desired delta
-        Evas_Coord x, y; // current delta
+   struct
+   {
+      Ecore_Animator *animator; // animaton timer
+      double start; // time started
+      Evas_Coord auto_x, auto_y; // desired delta
+      Evas_Coord x, y; // current delta
    } delta;
 };
 
@@ -37,6 +38,7 @@
 _del_hook(Evas_Object *obj)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
+
    if (!wd) return;
    if (wd->prop_hdl) ecore_event_handler_del(wd->prop_hdl);
    free(wd);
@@ -46,6 +48,7 @@
 _mirrored_set(Evas_Object *obj, Eina_Bool rtl)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
+
    if (!wd) return;
    edje_object_mirrored_set(wd->base, rtl);
 }
@@ -54,13 +57,17 @@
 _theme_hook(Evas_Object *obj)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
+
    if (!wd) return;
    _elm_widget_mirrored_reload(obj);
    _mirrored_set(obj, elm_widget_mirrored_get(obj));
-   _elm_theme_object_set(obj, wd->base, "conformant", "base", elm_widget_style_get(obj));
+   _elm_theme_object_set(obj, wd->base, "conformant", "base",
+                         elm_widget_style_get(obj));
+
    if (wd->content)
      edje_object_part_swallow(wd->base, "elm.swallow.content", wd->content);
-   edje_object_scale_set(wd->base, elm_widget_scale_get(obj) * _elm_config->scale);
+   edje_object_scale_set(wd->base, elm_widget_scale_get(obj)
+                         * _elm_config->scale);
    _sizing_eval(obj);
 }
 
@@ -69,6 +76,7 @@
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    Evas_Coord mw = -1, mh = -1;
+
    if (!wd) return;
    edje_object_size_min_calc(wd->base, &mw, &mh);
    evas_object_size_hint_min_set(obj, mw, mh);
@@ -76,9 +84,12 @@
 }
 
 static void
-_changed_size_hints(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
+_changed_size_hints(void *data, Evas *e __UNUSED__,
+                    Evas_Object *obj __UNUSED__,
+                    void *event_info __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(data);
+
    if (!wd) return;
    _sizing_eval(data);
 }
@@ -88,10 +99,12 @@
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    Evas_Object *sub = event_info;
+
    if (!wd) return;
    if (sub == wd->content)
      {
-        evas_object_event_callback_del_full(sub, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
+        evas_object_event_callback_del_full(sub,
+                                            EVAS_CALLBACK_CHANGED_SIZE_HINTS,
                                             _changed_size_hints, obj);
         wd->content = NULL;
         _sizing_eval(obj);
@@ -156,6 +169,7 @@
 #ifdef HAVE_ELEMENTARY_X
    Ecore_X_Event_Window_Property *ev;
    Widget_Data *wd = elm_widget_data_get(data);
+
    if (!wd) return ECORE_CALLBACK_PASS_ON;
    ev = event;
    if (ev->atom == ECORE_X_ATOM_E_ILLUME_ZONE)
@@ -297,6 +311,7 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
+
    if (!wd) return;
    if (wd->content == content) return;
    if (wd->content) evas_object_del(wd->content);
@@ -304,7 +319,8 @@
    if (content)
      {
         elm_widget_sub_object_add(obj, content);
-        evas_object_event_callback_add(content, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
+        evas_object_event_callback_add(content,
+                                       EVAS_CALLBACK_CHANGED_SIZE_HINTS,
                                        _changed_size_hints, obj);
         edje_object_part_swallow(wd->base, "elm.swallow.content", content);
      }
@@ -326,6 +342,7 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
+
    if (!wd) return NULL;
    return wd->content;
 }
@@ -346,6 +363,7 @@
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
    Evas_Object *content;
+
    if (!wd) return NULL;
    if (!wd->content) return NULL;
    content = wd->content;

Log:
Elementary genlist: Refactoring for structure packing.
  

Author:       seoz
Date:         2011-04-21 05:05:02 -0700 (Thu, 21 Apr 2011)
New Revision: 58793
Trac:         http://trac.enlightenment.org/e/changeset/58793

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-21 11:54:16 UTC (rev 58792)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-21 12:05:02 UTC (rev 58793)
@@ -272,16 +272,14 @@
    Pan              *pan;
    Evas_Coord        pan_x, pan_y, w, h, minw, minh, realminw, prev_viewport_w;
    Ecore_Job        *calc_job, *update_job;
-   Ecore_Idler      *queue_idler;
-   Ecore_Idler      *must_recalc_idler;
+   Ecore_Idler      *queue_idler, *must_recalc_idler;
    Eina_List        *queue, *selected;
-   Elm_Genlist_Item *show_item;
-   Elm_Genlist_Item *last_selected_item;
+   Elm_Genlist_Item *show_item, *last_selected_item, *anchor_item, *mode_item;
    Eina_Inlist      *item_cache;
-   Elm_Genlist_Item *anchor_item;
    Evas_Coord        anchor_y;
    Elm_List_Mode     mode;
-   Ecore_Timer      *multi_timer;
+   Ecore_Timer      *multi_timer, *scr_hold_timer;
+   const char       *mode_type;
    Evas_Coord        prev_x, prev_y, prev_mx, prev_my;
    Evas_Coord        cur_x, cur_y, cur_mx, cur_my;
    Eina_Bool         mouse_down : 1;
@@ -315,9 +313,6 @@
    int               group_item_height;
    int               max_items_per_block;
    double            longpress_timeout;
-   const char       *mode_type;
-   Elm_Genlist_Item *mode_item;
-   Ecore_Timer      *scr_hold_timer;
 };
 
 struct _Item_Block

Log:
Elementary genlist: Removed unnecesssary code.
  

Author:       seoz
Date:         2011-04-21 05:07:31 -0700 (Thu, 21 Apr 2011)
New Revision: 58794
Trac:         http://trac.enlightenment.org/e/changeset/58794

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-21 12:05:02 UTC (rev 58793)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-21 12:07:31 UTC (rev 58794)
@@ -2659,7 +2659,6 @@
                          elm_widget_style_get(it->base.widget));
    edje_object_mirrored_set(it->mode_view,
                             elm_widget_mirrored_get(it->base.widget));
-   elm_widget_sub_object_add(it->base.widget, it->spacer);
 
    /* signal callback add */
    evas_object_event_callback_add(it->mode_view, EVAS_CALLBACK_MOUSE_DOWN,

Log:
Elementary entry: Fixed indentation. Patch by Jihoon Kim
  <jihoon48.kim@...>
  

Author:       seoz
Date:         2011-04-21 19:29:54 -0700 (Thu, 21 Apr 2011)
New Revision: 58819
Trac:         http://trac.enlightenment.org/e/changeset/58819

Modified:
  trunk/elementary/src/lib/elm_entry.c 

Modified: trunk/elementary/src/lib/elm_entry.c
===================================================================
--- trunk/elementary/src/lib/elm_entry.c	2011-04-22 01:40:48 UTC (rev 58818)
+++ trunk/elementary/src/lib/elm_entry.c	2011-04-22 02:29:54 UTC (rev 58819)
@@ -504,9 +504,9 @@
    entries = eina_list_remove(entries, obj);
 #ifdef HAVE_ELEMENTARY_X
    if (wd->sel_notify_handler)
-      ecore_event_handler_del(wd->sel_notify_handler);
+     ecore_event_handler_del(wd->sel_notify_handler);
    if (wd->sel_clear_handler)
-      ecore_event_handler_del(wd->sel_clear_handler);
+     ecore_event_handler_del(wd->sel_clear_handler);
 #endif
    if (wd->cut_sel) eina_stringshare_del(wd->cut_sel);
    if (wd->text) eina_stringshare_del(wd->text);
@@ -548,7 +548,7 @@
    t = eina_stringshare_add(elm_entry_entry_get(obj));
    _elm_theme_object_set(obj, wd->ent, "entry", _getbase(obj), elm_widget_style_get(obj));
    if (_elm_config->desktop_entry)
-      edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_TRUE);
+     edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_TRUE);
    elm_entry_entry_set(obj, t);
    eina_stringshare_del(t);
    if (elm_widget_disabled_get(obj))
@@ -590,7 +590,7 @@
    elm_coords_finger_size_adjust(1, NULL, 1, &minh);
    evas_object_size_hint_min_set(data, -1, minh);
    if (wd->single_line)
-      evas_object_size_hint_max_set(data, -1, minh);
+     evas_object_size_hint_max_set(data, -1, minh);
 
    if (wd->deferred_cur)
      elm_widget_show_region_set(data, wd->cx, wd->cy, wd->cw, wd->ch);
@@ -619,7 +619,7 @@
         elm_coords_finger_size_adjust(1, &minw, 1, &minh);
         evas_object_size_hint_min_set(obj, minw, minh);
         if (wd->single_line)
-           evas_object_size_hint_max_set(obj, -1, minh);
+          evas_object_size_hint_max_set(obj, -1, minh);
      }
 }
 
@@ -695,8 +695,8 @@
         ch = 1;
      }
    else
-      edje_object_part_text_cursor_geometry_get(wd->ent, "elm.text",
-                                                &cx, &cy, &cw, &ch);
+     edje_object_part_text_cursor_geometry_get(wd->ent, "elm.text",
+                                               &cx, &cy, &cw, &ch);
    evas_object_size_hint_min_get(wd->hoversel, &mw, &mh);
    if (cw < mw)
      {
@@ -760,7 +760,7 @@
         if (!_elm_config->desktop_entry)
           {
              if (!wd->password)
-                edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_TRUE);
+               edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_TRUE);
           }
      }
    elm_widget_scroll_freeze_pop(data);
@@ -778,11 +778,11 @@
    if (!_elm_config->desktop_entry)
      {
         if (!wd->password)
-           edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_TRUE);
+          edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_TRUE);
      }
    edje_object_signal_emit(wd->ent, "elm,state,select,on", "elm");
    if (!_elm_config->desktop_entry)
-      elm_widget_scroll_hold_push(data);
+     elm_widget_scroll_hold_push(data);
 }
 
 static void
@@ -825,10 +825,10 @@
    /* Store it */
    wd->selmode = EINA_FALSE;
    if (!_elm_config->desktop_entry)
-      edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_FALSE);
+     edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_FALSE);
    edje_object_signal_emit(wd->ent, "elm,state,select,off", "elm");
    if (!_elm_config->desktop_entry)
-      elm_widget_scroll_hold_pop(data);
+     elm_widget_scroll_hold_pop(data);
    _store_selection(ELM_SEL_CLIPBOARD, data);
    edje_object_part_text_insert(wd->ent, "elm.text", "");
    edje_object_part_text_select_none(wd->ent, "elm.text");
@@ -857,10 +857,10 @@
    if (!wd) return;
    wd->selmode = EINA_FALSE;
    if (!_elm_config->desktop_entry)
-      edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_FALSE);
+     edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_FALSE);
    edje_object_signal_emit(wd->ent, "elm,state,select,off", "elm");
    if (!_elm_config->desktop_entry)
-      elm_widget_scroll_hold_pop(data);
+     elm_widget_scroll_hold_pop(data);
    edje_object_part_text_select_none(wd->ent, "elm.text");
 }
 
@@ -925,14 +925,14 @@
                   if (!_elm_config->desktop_entry)
                     {
                        if (!wd->password)
-                          elm_hoversel_item_add(wd->hoversel, E_("Select"), NULL, ELM_ICON_NONE,
-                                                _select, obj);
+                         elm_hoversel_item_add(wd->hoversel, E_("Select"), NULL, ELM_ICON_NONE,
+                                               _select, obj);
                     }
                   if (1) // need way to detect if someone has a selection
                     {
                        if (wd->editable)
-                          elm_hoversel_item_add(wd->hoversel, E_("Paste"), NULL, ELM_ICON_NONE,
-                                                _paste, obj);
+                         elm_hoversel_item_add(wd->hoversel, E_("Paste"), NULL, ELM_ICON_NONE,
+                                               _paste, obj);
                     }
                }
           }
@@ -1446,7 +1446,6 @@
    return ECORE_CALLBACK_PASS_ON;
 }
 
-
 static Eina_Bool
 _drag_drop_cb(void *data __UNUSED__, Evas_Object *obj, Elm_Selection_Data *drop)
 {
@@ -1618,7 +1617,7 @@
                                    _signal_mouse_double, obj);
    edje_object_part_text_set(wd->ent, "elm.text", "");
    if (_elm_config->desktop_entry)
-      edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_TRUE);
+     edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_TRUE);
    elm_widget_resize_object_set(obj, wd->ent);
    _sizing_eval(obj);
 
@@ -1652,7 +1651,6 @@
    return obj;
 }
 
-
 /**
  * This sets the entry object not to line wrap.  All input will
  * be on a single line, and the entry box will extend with user input.
@@ -1719,7 +1717,6 @@
    _theme_hook(obj);
 }
 
-
 /**
  * This returns whether password mode is enabled.
  * See also elm_entry_password_set().
@@ -1788,7 +1785,6 @@
    return wd->text;
 }
 
-
 /**
  * This returns EINA_TRUE if the entry is empty/there was an error
  * and EINA_FALSE if it is not empty.
@@ -1980,7 +1976,7 @@
      {
         wd->selmode = EINA_FALSE;
         if (!_elm_config->desktop_entry)
-           edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_FALSE);
+          edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_FALSE);
         edje_object_signal_emit(wd->ent, "elm,state,select,off", "elm");
      }
    wd->have_selection = EINA_FALSE;
@@ -2004,7 +2000,7 @@
      {
         wd->selmode = EINA_FALSE;
         if (!_elm_config->desktop_entry)
-           edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_FALSE);
+          edje_object_part_text_select_allow_set(wd->ent, "elm.text", EINA_FALSE);
         edje_object_signal_emit(wd->ent, "elm,state,select,off", "elm");
      }
    wd->have_selection = EINA_TRUE;
@@ -2911,7 +2907,6 @@
    return wd->autosave;
 }
 
-
 /**
  * Control pasting of text and images for the widget.
  *

Log:
Elementary genlist: Fixed implicit declaration warning.
  

Author:       seoz
Date:         2011-04-22 04:54:29 -0700 (Fri, 22 Apr 2011)
New Revision: 58825
Trac:         http://trac.enlightenment.org/e/changeset/58825

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-22 11:47:14 UTC (rev 58824)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-22 11:54:29 UTC (rev 58825)
@@ -1,5 +1,6 @@
 #include <Elementary.h>
 #include <Elementary_Cursor.h>
+#include <assert.h>
 #include "elm_priv.h"
 
 #define SWIPE_MOVES         12

Log:
Elementary slideshow: Fixed warnings, fixed spacing and removed unnecessary blank lines.
  

Author:       seoz
Date:         2011-04-22 05:06:00 -0700 (Fri, 22 Apr 2011)
New Revision: 58826
Trac:         http://trac.enlightenment.org/e/changeset/58826

Modified:
  trunk/elementary/src/lib/elm_slideshow.c 

Modified: trunk/elementary/src/lib/elm_slideshow.c
===================================================================
--- trunk/elementary/src/lib/elm_slideshow.c	2011-04-22 11:54:29 UTC (rev 58825)
+++ trunk/elementary/src/lib/elm_slideshow.c	2011-04-22 12:06:00 UTC (rev 58826)
@@ -74,8 +74,6 @@
    {NULL, NULL}
 };
 
-
-
 static Eina_Bool
 _event_hook(Evas_Object *obj, Evas_Object *src __UNUSED__, Evas_Callback_Type type, void *event_info)
 {
@@ -185,7 +183,7 @@
 {
    Widget_Data *wd = elm_widget_data_get(item->base.widget);
    Elm_Slideshow_Item* prev = eina_list_data_get(eina_list_prev(item->l));
-   if((!prev) && (wd->loop))
+   if ((!prev) && (wd->loop))
      prev = eina_list_data_get(eina_list_last(item->l));
    return prev;
 }
@@ -194,12 +192,11 @@
 {
    Widget_Data *wd = elm_widget_data_get(item->base.widget);
    Elm_Slideshow_Item* next = eina_list_data_get(eina_list_next(item->l));
-   if((!next) && (wd->loop))
+   if ((!next) && (wd->loop))
      next = eina_list_data_get(wd->items);
    return next;
 }
 
-
 static void
 _changed_size_hints(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
 {
@@ -289,12 +286,12 @@
 
    //delete unused items
    lc = wd->count_item_pre_before + wd->count_item_pre_after + 1;
-   while (eina_list_count(wd->items_built) > lc)
+   while ((int)eina_list_count(wd->items_built) > lc)
      {
         item = eina_list_data_get(wd->items_built);
         wd->items_built = eina_list_remove_list(wd->items_built,
                                                 wd->items_built);
-        if(item->itc->func.del)
+        if (item->itc->func.del)
           item->itc->func.del((void*)item->base.data, item->base.view);
         evas_object_del(item->base.view);
         item->base.view = NULL;
@@ -309,7 +306,7 @@
    if (!wd) return;
 
    item = wd->previous;
-   if(item)
+   if (item)
      {
         edje_object_part_unswallow(NULL, item->base.view);
         evas_object_hide(item->base.view);
@@ -328,7 +325,6 @@
    edje_object_part_swallow(wd->slideshow, "elm.swallow.1", item->base.view);
 }
 
-
 static Eina_Bool
 _timer_cb(void *data)
 {
@@ -340,8 +336,6 @@
    return ECORE_CALLBACK_CANCEL;
 }
 
-
-
 /**
  * Add a new slideshow to the parent
  *
@@ -758,7 +752,6 @@
      }
 }
 
-
 /**
  * Delete the item
  *
@@ -810,7 +803,6 @@
    return wd->items;
 }
 
-
 /**
  * Returns the current item displayed
  *
@@ -875,8 +867,6 @@
    return wd->count_item_pre_before;
 }
 
-
-
 /**
  * Set max amount of cached items before current
  *
@@ -912,8 +902,6 @@
    return wd->count_item_pre_after;
 }
 
-
-
 /**
  * Set max amount of cached items after current
  *
@@ -931,4 +919,3 @@
    if (count < 0) count = 0;
    wd->count_item_pre_after = count;
 }
-

Log:
Elementary genlist: Fixed indentation.
  
  Use space instead of tab.
  

Author:       seoz
Date:         2011-04-22 05:22:57 -0700 (Fri, 22 Apr 2011)
New Revision: 58827
Trac:         http://trac.enlightenment.org/e/changeset/58827

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-22 12:06:00 UTC (rev 58826)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-22 12:22:57 UTC (rev 58827)
@@ -201,7 +201,7 @@
  * "expanded" - This is called when elm_genlist_item_expanded_set() is called
  *              and the item is now meant to be expanded. The event_info
  *              parameter is the genlist item that was indicated to expand. It
- *       	is the job of this callback to then fill in the child items.
+ *              is the job of this callback to then fill in the child items.
  * "contracted" - This is called when elm_genlist_item_expanded_set() is called
  *                and the item is now meant to be contracted. The event_info
  *                parameter is the genlist item that was indicated to contract.
@@ -1648,10 +1648,10 @@
 {
    if (!it->nostacking)
      {
-       if ((it->order_num_in & 0x1) ^ it->stacking_even)
-	 evas_object_lower(it->base.view);
-       else
-	 evas_object_raise(it->base.view);
+        if ((it->order_num_in & 0x1) ^ it->stacking_even)
+          evas_object_lower(it->base.view);
+        else
+          evas_object_raise(it->base.view);
      }
 
    if (it->order_num_in & 0x1)
@@ -1663,39 +1663,39 @@
 static void
 _elm_genlist_item_state_update(Elm_Genlist_Item *it, Item_Cache *itc)
 {
-  if (itc)
-    {
-      if (it->selected != itc->selected)
-	{
-	  if (it->selected)
-	    edje_object_signal_emit(it->base.view,
-				    "elm,state,selected", "elm");
-	}
-      if (it->disabled != itc->disabled)
-	{
-	  if (it->disabled)
-	    edje_object_signal_emit(it->base.view,
-				    "elm,state,disabled", "elm");
-	}
-      if (it->expanded != itc->expanded)
-	{
-	  if (it->expanded)
-	    edje_object_signal_emit(it->base.view,
-				    "elm,state,expanded", "elm");
-	}
-    }
-  else
-    {
-      if (it->selected)
-	edje_object_signal_emit(it->base.view,
-				"elm,state,selected", "elm");
-      if (it->disabled)
-	edje_object_signal_emit(it->base.view,
-				"elm,state,disabled", "elm");
-      if (it->expanded)
-	edje_object_signal_emit(it->base.view,
-				"elm,state,expanded", "elm");
-    }
+   if (itc)
+     {
+        if (it->selected != itc->selected)
+          {
+             if (it->selected)
+               edje_object_signal_emit(it->base.view,
+                                       "elm,state,selected", "elm");
+          }
+        if (it->disabled != itc->disabled)
+          {
+             if (it->disabled)
+               edje_object_signal_emit(it->base.view,
+                                       "elm,state,disabled", "elm");
+          }
+        if (it->expanded != itc->expanded)
+          {
+             if (it->expanded)
+               edje_object_signal_emit(it->base.view,
+                                       "elm,state,expanded", "elm");
+          }
+     }
+   else
+     {
+        if (it->selected)
+          edje_object_signal_emit(it->base.view,
+                                  "elm,state,selected", "elm");
+        if (it->disabled)
+          edje_object_signal_emit(it->base.view,
+                                  "elm,state,disabled", "elm");
+        if (it->expanded)
+          edje_object_signal_emit(it->base.view,
+                                  "elm,state,expanded", "elm");
+     }
 }
 
 static void
@@ -1709,8 +1709,8 @@
 
 static void
 _item_label_realize(Elm_Genlist_Item *it,
-		    Evas_Object *target,
-		    const Eina_List *source)
+                    Evas_Object *target,
+                    const Eina_List *source)
 {
    if (it->itc->func.label_get)
      {
@@ -1729,18 +1729,18 @@
                   edje_object_part_text_set(target, key, s);
                   free(s);
                }
-	     else
-	       {
-		  edje_object_part_text_set(target, key, "");
-	       }
+             else
+               {
+                  edje_object_part_text_set(target, key, "");
+               }
           }
      }
 }
 
 static Eina_List *
 _item_icon_realize(Elm_Genlist_Item *it,
-		   Evas_Object *target,
-		   Eina_List *source)
+                   Evas_Object *target,
+                   Eina_List *source)
 {
    Eina_List *res = NULL;
 
@@ -1759,7 +1759,7 @@
 
              if (ic)
                {
-		  res = eina_list_append(res, ic);
+                  res = eina_list_append(res, ic);
                   edje_object_part_swallow(it->mode_view, key, ic);
                   evas_object_show(ic);
                   elm_widget_sub_object_add(it->base.widget, ic);
@@ -1772,14 +1772,14 @@
 
 static void
 _item_state_realize(Elm_Genlist_Item *it,
-		    Evas_Object *target,
-		    Eina_List *source)
+                    Evas_Object *target,
+                    Eina_List *source)
 {
    if (it->itc->func.state_get)
      {
         const Eina_List *l;
         const char *key;
-	char buf[4096];
+        char buf[4096];
 
         it->mode_states =
            elm_widget_stringlist_get(edje_object_data_get(target, "states"));
@@ -1793,11 +1793,11 @@
                   snprintf(buf, sizeof(buf), "elm,state,%s,active", key);
                   edje_object_signal_emit(target, buf, "elm");
                }
-	     else
-	       {
-		  snprintf(buf, sizeof(buf), "elm,state,%s,passive", key);
-		  edje_object_signal_emit(target, buf, "elm");
-	       }
+             else
+               {
+                  snprintf(buf, sizeof(buf), "elm,state,%s,passive", key);
+                  edje_object_signal_emit(target, buf, "elm");
+               }
           }
      }
 }
@@ -1816,13 +1816,13 @@
    if (it->delete_me) return ;
    if (it->realized)
      {
-       if (it->order_num_in != in)
-	 {
-	   it->order_num_in = in;
-	   _elm_genlist_item_odd_even_update(it);
-	   _elm_genlist_item_state_update(it, NULL);
-	 }
-       return;
+        if (it->order_num_in != in)
+          {
+             it->order_num_in = in;
+             _elm_genlist_item_odd_even_update(it);
+             _elm_genlist_item_state_update(it, NULL);
+          }
+        return;
      }
    it->order_num_in = in;
 
@@ -1840,7 +1840,7 @@
    else
      {
         const char *stacking_even;
-	const char *stacking;
+        const char *stacking;
 
         it->base.view = edje_object_add(evas_object_evas_get(it->base.widget));
         edje_object_scale_set(it->base.view,
@@ -1861,13 +1861,13 @@
         _elm_theme_object_set(it->base.widget, it->base.view, "genlist", buf,
                               elm_widget_style_get(it->base.widget));
 
-	stacking_even = edje_object_data_get(it->base.view, "stacking_even");
-	if (!stacking_even) stacking_even = "above";
-	it->stacking_even = !!strcmp("above", stacking_even);
+        stacking_even = edje_object_data_get(it->base.view, "stacking_even");
+        if (!stacking_even) stacking_even = "above";
+        it->stacking_even = !!strcmp("above", stacking_even);
 
-	stacking = edje_object_data_get(it->base.view, "stacking");
-	if (!stacking) stacking = "yes";
-	it->nostacking = !!strcmp("yes", stacking);
+        stacking = edje_object_data_get(it->base.view, "stacking");
+        if (!stacking) stacking = "yes";
+        it->nostacking = !!strcmp("yes", stacking);
 
         edje_object_mirrored_set(it->base.view,
                                  elm_widget_mirrored_get(it->base.widget));
@@ -1911,7 +1911,7 @@
         evas_object_event_callback_add(it->base.view, EVAS_CALLBACK_MULTI_MOVE,
                                        _multi_move, it);
 
-	_elm_genlist_item_state_update(it, itc);
+        _elm_genlist_item_state_update(it, itc);
      }
 
    if ((calc) && (it->wd->homogeneous) && ((it->wd->item_width) || ((it->wd->item_width) && (it->wd->group_item_width))))
@@ -1934,13 +1934,13 @@
      }
    else
      {
-	/* FIXME: If you see that assert, please notify us and we 
-	   will clean our mess */
-	assert(eina_list_count(it->icon_objs) != 0);
+        /* FIXME: If you see that assert, please notify us and we 
+           will clean our mess */
+        assert(eina_list_count(it->icon_objs) != 0);
 
         _item_label_realize(it, it->base.view, it->labels);
-	it->icon_objs = _item_icon_realize(it, it->base.view, it->icons);
-	_item_state_realize(it, it->base.view, it->states);
+        it->icon_objs = _item_icon_realize(it, it->base.view, it->icons);
+        _item_state_realize(it, it->base.view, it->states);
 
         if (!it->mincalcd)
           {

Log:
Elementary notify: Fixed documentation.
  

Author:       seoz
Date:         2011-04-26 17:51:31 -0700 (Tue, 26 Apr 2011)
New Revision: 58941
Trac:         http://trac.enlightenment.org/e/changeset/58941

Modified:
  trunk/elementary/src/lib/elm_notify.c 

Modified: trunk/elementary/src/lib/elm_notify.c
===================================================================
--- trunk/elementary/src/lib/elm_notify.c	2011-04-26 19:32:17 UTC (rev 58940)
+++ trunk/elementary/src/lib/elm_notify.c	2011-04-27 00:51:31 UTC (rev 58941)
@@ -545,7 +545,7 @@
 /**
  * Set the notify parent
  *
- * Once the parent object is set, a previously set one will be desconected
+ * Once the parent object is set, a previously set one will be disconnected
  * and replaced.
  *
  * @param obj The notify object

Log:
Elementary notify: Fixed formatting. Removed unnecessary blank lines.
  

Author:       seoz
Date:         2011-04-26 17:53:52 -0700 (Tue, 26 Apr 2011)
New Revision: 58942
Trac:         http://trac.enlightenment.org/e/changeset/58942

Modified:
  trunk/elementary/src/lib/elm_notify.c 

Modified: trunk/elementary/src/lib/elm_notify.c
===================================================================
--- trunk/elementary/src/lib/elm_notify.c	2011-04-27 00:51:31 UTC (rev 58941)
+++ trunk/elementary/src/lib/elm_notify.c	2011-04-27 00:53:52 UTC (rev 58942)
@@ -1,7 +1,6 @@
 #include <Elementary.h>
 #include "elm_priv.h"
 
-
 /**
  * @defgroup Notify Notify
  *
@@ -123,7 +122,6 @@
    return orient;
 }
 
-
 static void
 _notify_theme_apply(Evas_Object *obj)
 {
@@ -729,4 +727,3 @@
    if (!wd) return EINA_FALSE;
    return wd->repeat_events;
 }
-

Log:
Elementary genlist: Moved signal doxygen to header file.
  
  This is a first action of doxygen movement. All doxygen will be moved to
  headers after all.
  

Author:       seoz
Date:         2011-04-26 19:41:11 -0700 (Tue, 26 Apr 2011)
New Revision: 58943
Trac:         http://trac.enlightenment.org/e/changeset/58943

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-04-27 00:53:52 UTC (rev 58942)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-04-27 02:41:11 UTC (rev 58943)
@@ -1863,70 +1863,80 @@
    EAPI void               elm_genlist_item_mode_set(Elm_Genlist_Item *it, const char *mode_type, Eina_Bool mode_set) EINA_ARG_NONNULL(1, 2);
    EAPI const char        *elm_genlist_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI const Elm_Genlist_Item *elm_genlist_mode_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
-   /* smart callbacks called:
-    * "clicked,double" - This is called when a user has double-clicked an item. The
-    *                    event_info parameter is the genlist item that was double-clicked.
+   /** Signals that you can add callbacks for are:
+    * "clicked,double" - This is called when a user has double-clicked an item.
+    *                    The event_info parameter is the genlist item that was
+    *                    double-clicked.
     * "selected" - This is called when a user has made an item selected. The
     *              event_info parameter is the genlist item that was selected.
     * "unselected" - This is called when a user has made an item unselected. The
-    *                 event_info parameter is the genlist item that was unselected.
+    *                 event_info parameter is the genlist item that was
+    *                 unselected.
     * "expanded" - This is called when elm_genlist_item_expanded_set() is called
-    *              and the item is now meant to be expanded. The event_info parameter is the
-    *              genlist item that was indicated to expand. It is the job of this callback
-    *              to then fill in the child items.
-    * "contracted" - This is called when elm_genlist_item_expanded_set() is called
-    *                and the item is now meant to be contracted. The event_info parameter is
-    *                the genlist item that was indicated to contract. It is the job of this
-    *                callback to then delete the child items.
+    *              and the item is now meant to be expanded. The event_info
+    *              parameter is the genlist item that was indicated to expand.
+    *              It is the job of this callback to then fill in the child
+    *              items.
+    * "contracted" - This is called when elm_genlist_item_expanded_set() is
+    *                called and the item is now meant to be contracted. The
+    *                event_info parameter is the genlist item that was indicated
+    *                to contract. It is the job of this callback to then delete
+    *                the child items.
     * "expand,request" - This is called when a user has indicated they want to
-    *                    expand a tree branch item. The callback should decide if the item can
-    *                    expand (has any children) and then call elm_genlist_item_expanded_set()
-    *                    appropriately to set the state. The event_info parameter is the genlist
-    *                    item that was indicated to expand.
+    *                    expand a tree branch item. The callback should decide
+    *                    if the item can expand (has any children) and then call
+    *                    elm_genlist_item_expanded_set() appropriately to set
+    *                    the state. The event_info parameter is the genlist item
+    *                    that was indicated to expand.
     * "contract,request" - This is called when a user has indicated they want to
-    *                      contract a tree branch item. The callback should decide if the item can
-    *                      contract (has any children) and then call elm_genlist_item_expanded_set()
-    *                      appropriately to set the state. The event_info parameter is the genlist
-    *                      item that was indicated to contract.
+    *                      contract a tree branch item. The callback should
+    *                      decide if the item can contract (has any children)
+    *                      and then call elm_genlist_item_expanded_set()
+    *                      appropriately to set the state. The event_info
+    *                      parameter is the genlist item that was indicated to
+    *                      contract.
     * "realized" - This is called when the item in the list is created as a real
-    *              evas object. event_info parameter is the genlist item that was created.
-    *              The object may be deleted at any time, so it is up to the caller to
-    *              not use the object pointer from elm_genlist_item_object_get() in a way
-    *              where it may point to freed objects.
+    *              evas object. event_info parameter is the genlist item that
+    *              was created. The object may be deleted at any time, so it is
+    *              up to the caller to not use the object pointer from
+    *              elm_genlist_item_object_get() in a way where it may point to
+    *              freed objects.
     * "unrealized" - This is called just before an item is unrealized. After
-    *                this call icon objects provided will be deleted and the item object
-    *                itself delete or be put into a floating cache.
-    * "drag,start,up" - This is called when the item in the list has been dragged 
-    *                   (not scrolled) up.
-    * "drag,start,down" - This is called when the item in the list has been dragged 
-    *                     (not scrolled) down.
-    * "drag,start,left" - This is called when the item in the list has been dragged i
-    *                     (not scrolled) left.
-    * "drag,start,right" - This is called when the item in the list has been dragged
-    *                      (not scrolled) right.
+    *                this call icon objects provided will be deleted and the
+    *                item object itself delete or be put into a floating cache.
+    * "drag,start,up" - This is called when the item in the list has been
+    *                   dragged (not scrolled) up.
+    * "drag,start,down" - This is called when the item in the list has been
+    *                     dragged (not scrolled) down.
+    * "drag,start,left" - This is called when the item in the list has been
+    *                     dragged (not scrolled) left.
+    * "drag,start,right" - This is called when the item in the list has been
+    *                      dragged (not scrolled) right.
     * "drag,stop" - This is called when the item in the list has stopped being
     *               dragged.
     * "drag" - This is called when the item in the list is being dragged.
-    * "longpressed" - This is called when the item is pressed for a certain amount
-    *                 of time. By default it's 1 second.
+    * "longpressed" - This is called when the item is pressed for a certain
+    *                 amount of time. By default it's 1 second.
     * "scroll,edge,top" - This is called when the genlist is scrolled until the
     *                     top edge.
-    * "scroll,edge,bottom" - This is called when the genlist is scrolled until the
-    *                         bottom edge.
+    * "scroll,edge,bottom" - This is called when the genlist is scrolled until
+    *                        the bottom edge.
     * "scroll,edge,left" - This is called when the genlist is scrolled until the
     *                      left edge.
-    * "scroll,edge,right" - This is called when the genlist is scrolled until the
-    *                       right edge.
+    * "scroll,edge,right" - This is called when the genlist is scrolled until
+    *                       the right edge.
     * "multi,swipe,left" - This is called when the genlist is multi-touch swiped
     *                       left.
-    * "multi,swipe,right" - This is called when the genlist is multi-touch swiped
-    *                       right.
-    * "multi,swipe,up" - This is called when the genlist is multi-touch swiped up.
+    * "multi,swipe,right" - This is called when the genlist is multi-touch
+    *                       swiped right.
+    * "multi,swipe,up" - This is called when the genlist is multi-touch swiped
+    *                    up.
     * "multi,swipe,down" - This is called when the genlist is multi-touch swiped
     *                      down.
     * "multi,pinch,out" - This is called when the genlist is multi-touch pinched
     *                     out.
-    * "multi,pinch,in" - This is called when the genlist is multi-touch pinched in.
+    * "multi,pinch,in" - This is called when the genlist is multi-touch pinched
+    *                    in.
     */
 
    /* check */

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-27 00:53:52 UTC (rev 58942)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-27 02:41:11 UTC (rev 58943)
@@ -190,75 +190,6 @@
  * have a specific style that overrides any theme the user or system sets up
  * you can use elm_theme_overlay_add() to add such a file.
  *
- * Signals that you can add callbacks for are:
- *
- * "clicked,double" - This is called when a user has double-clicked an item. The
- *                    event_info parameter is the genlist item that was double-c
- *                    licked.
- * "selected" - This is called when a user has made an item selected. The
- *              event_info parameter is the genlist item that was selected.
- * "unselected" - This is called when a user has made an item unselected. The
- *                 event_info parameter is the genlist item that was unselected.
- * "expanded" - This is called when elm_genlist_item_expanded_set() is called
- *              and the item is now meant to be expanded. The event_info
- *              parameter is the genlist item that was indicated to expand. It
- *              is the job of this callback to then fill in the child items.
- * "contracted" - This is called when elm_genlist_item_expanded_set() is called
- *                and the item is now meant to be contracted. The event_info
- *                parameter is the genlist item that was indicated to contract.
- *                It is the job of this callback to then delete the child items.
- * "expand,request" - This is called when a user has indicated they want to
- *                    expand a tree branch item. The callback should decide if
- *                    the item can expand (has any children) and then call
- *                    elm_genlist_item_expanded_set() appropriately to set the
- *                    state. The event_info parameter is the genlist item that
- *                    was indicated to expand.
- * "contract,request" - This is called when a user has indicated they want to
- *                      contract a tree branch item. The callback should decide
- *                      if the item can contract (has any children) and then
- *                      call elm_genlist_item_expanded_set() appropriately to
- *                      set the state. The event_info parameter is the genlist
- *                      item that was indicated to contract.
- * "realized" - This is called when the item in the list is created as a real
- *              evas object. event_info parameter is the genlist item that was
- *              created. The object may be deleted at any time, so it is up to
- *              the caller to not use the object pointer from
- *              elm_genlist_item_object_get() in a way  where it may point to
- *              freed objects.
- * "unrealized" - This is called just before an item is unrealized. After this
- *                call icon objects provided will be deleted and the item object
- *                itself delete or be put into a floating cache.
- * "drag,start,up" - This is called when the item in the list has been dragged
- *                   (not scrolled) up.
- * "drag,start,down" - This is called when the item in the list has been dragged
- *                     (not scrolled) down.
- * "drag,start,left" - This is called when the item in the list has been dragged
- *                     (not scrolled) left.
- * "drag,start,right" - This is called when the item in the list has been
- *                      dragged (not scrolled) right.
- * "drag,stop" - This is called when the item in the list has stopped being
- *               dragged.
- * "drag" - This is called when the item in the list is being dragged.
- * "longpressed" - This is called when the item is pressed for a certain amount
- *                 of time. By default it's 1 second.
- * "scroll,edge,top" - This is called when the genlist is scrolled until the
- *                     top edge.
- * "scroll,edge,bottom" - This is called when the genlist is scrolled until the
- *                         bottom edge.
- * "scroll,edge,left" - This is called when the genlist is scrolled until the
- *                      left edge.
- * "scroll,edge,right" - This is called when the genlist is scrolled until the
- *                       right edge.
- * "multi,swipe,left" - This is called when the genlist is multi-touch swiped
- *                       left.
- * "multi,swipe,right" - This is called when the genlist is multi-touch swiped
- *                       right.
- * "multi,swipe,up" - This is called when the genlist is multi-touch swiped up.
- * "multi,swipe,down" - This is called when the genlist is multi-touch swiped
- *                      down.
- * "multi,pinch,out" - This is called when the genlist is multi-touch pinched
- *                     out.
- * "multi,pinch,in" - This is called when the genlist is multi-touch pinched in.
  */
 
 typedef struct _Widget_Data Widget_Data;

Log:
Elementary: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-04-26 19:42:50 -0700 (Tue, 26 Apr 2011)
New Revision: 58944
Trac:         http://trac.enlightenment.org/e/changeset/58944

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_main.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-04-27 02:41:11 UTC (rev 58943)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-04-27 02:42:50 UTC (rev 58944)
@@ -240,7 +240,7 @@
    EAPI const char  *elm_app_lib_dir_get(void);
    EAPI const char  *elm_app_data_dir_get(void);
    EAPI const char  *elm_app_locale_dir_get(void);
-         
+
    EAPI void         elm_quicklaunch_mode_set(Eina_Bool ql_on);
    EAPI Eina_Bool    elm_quicklaunch_mode_get(void);
    EAPI int          elm_quicklaunch_init(int argc, char **argv);

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-27 02:41:11 UTC (rev 58943)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-27 02:42:50 UTC (rev 58944)
@@ -1862,7 +1862,7 @@
      }
    else
      {
-        /* FIXME: If you see that assert, please notify us and we 
+        /* FIXME: If you see that assert, please notify us and we
            will clean our mess */
         assert(eina_list_count(it->icon_objs) == 0);
 

Modified: trunk/elementary/src/lib/elm_main.c
===================================================================
--- trunk/elementary/src/lib/elm_main.c	2011-04-27 02:41:11 UTC (rev 58943)
+++ trunk/elementary/src/lib/elm_main.c	2011-04-27 02:42:50 UTC (rev 58944)
@@ -344,10 +344,10 @@
    char **argv = NULL;
    const char *dirs[4] = { NULL, NULL, NULL, NULL };
    char *caps = NULL, *p1, *p2;
-   
+
    if (app_pfx) return;
    if (!app_domain) return;
-   
+
    ecore_app_args_get(&argc, &argv);
    if (argc < 1) return;
 
@@ -445,7 +445,7 @@
    if (_elm_init_count > 0) return _elm_init_count;
    _elm_win_shutdown();
    while (_elm_win_deferred_free) ecore_main_loop_iterate();
-// wrningz :(   
+// wrningz :(
 //   _prefix_shutdown();
    elm_quicklaunch_sub_shutdown();
    elm_quicklaunch_shutdown();
@@ -493,7 +493,7 @@
    app_prefix_dir = eina_prefix_get(app_pfx);
    return app_prefix_dir;
 }
-   
+
 EAPI const char *
 elm_app_bin_dir_get(void)
 {
@@ -644,7 +644,7 @@
 
    if (argv) _elm_appname = strdup(ecore_file_file_get(argv[0]));
 
-   pfx = eina_prefix_new(NULL, elm_init, 
+   pfx = eina_prefix_new(NULL, elm_init,
                          "ELM", "elementary", "config/profile.cfg",
                          PACKAGE_LIB_DIR, /* don't have a bin dir currently */
                          PACKAGE_LIB_DIR,

Log:
Elementary elm_conform.c: Fixed warnings.
  

Author:       seoz
Date:         2011-04-27 06:53:25 -0700 (Wed, 27 Apr 2011)
New Revision: 58960
Trac:         http://trac.enlightenment.org/e/changeset/58960

Modified:
  trunk/elementary/src/lib/elm_conform.c 

Modified: trunk/elementary/src/lib/elm_conform.c
===================================================================
--- trunk/elementary/src/lib/elm_conform.c	2011-04-27 13:09:37 UTC (rev 58959)
+++ trunk/elementary/src/lib/elm_conform.c	2011-04-27 13:53:25 UTC (rev 58960)
@@ -262,8 +262,8 @@
  */
 
 static void
-_conformant_move_resize_event_cb(void *data, Evas *e, Evas_Object *obj,
-                                 void *event_info)
+_conformant_move_resize_event_cb(void *data __UNUSED__, Evas *e __UNUSED__,
+                                 Evas_Object *obj, void *event_info __UNUSED__)
 {
    Conformant_Part_Type part_type;
    Widget_Data *wd = elm_widget_data_get(obj);

Log:
Elementary els_scroller.c: Refactored code.
  
  Changed unsigned char to Eina_Bool. Changed 0 to EINA_FALSE for Eina_Bool type variables. Removed unnecessary blank line. Added braces in if statements.
  

Author:       seoz
Date:         2011-04-27 08:31:31 -0700 (Wed, 27 Apr 2011)
New Revision: 58964
Trac:         http://trac.enlightenment.org/e/changeset/58964

Modified:
  trunk/elementary/src/lib/els_scroller.c 

Modified: trunk/elementary/src/lib/els_scroller.c
===================================================================
--- trunk/elementary/src/lib/els_scroller.c	2011-04-27 14:59:22 UTC (rev 58963)
+++ trunk/elementary/src/lib/els_scroller.c	2011-04-27 15:31:31 UTC (rev 58964)
@@ -102,8 +102,8 @@
    unsigned char bouncemey : 1;
    unsigned char bounce_horiz : 1;
    unsigned char bounce_vert : 1;
-   unsigned char momentum_animator_disabled :1;
-   unsigned char bounce_animator_disabled :1;
+   Eina_Bool momentum_animator_disabled :1;
+   Eina_Bool bounce_animator_disabled :1;
    Eina_Bool is_mirrored : 1;
 };
 
@@ -859,7 +859,7 @@
    if ((!sd->widget) ||
        (!elm_widget_drag_child_locked_x_get(sd->widget)))
      {
-        if (!sd->down.bounce_x_animator && !sd->bounce_animator_disabled)
+        if ((!sd->down.bounce_x_animator) && (!sd->bounce_animator_disabled))
           {
              if (sd->bouncemex)
                {
@@ -881,7 +881,7 @@
    if ((!sd->widget) ||
        (!elm_widget_drag_child_locked_y_get(sd->widget)))
      {
-        if (!sd->down.bounce_y_animator && !sd->bounce_animator_disabled)
+        if ((!sd->down.bounce_y_animator) && (!sd->bounce_animator_disabled))
           {
              if (sd->bouncemey)
                {
@@ -1792,7 +1792,7 @@
                                  oy = -sd->down.dy;
                                  if (!_smart_do_page(sd))
                                    {
-                                      if (!sd->down.momentum_animator && !sd->momentum_animator_disabled)
+                                      if ((!sd->down.momentum_animator) && (!sd->momentum_animator_disabled))
                                         {
                                            sd->down.momentum_animator = ecore_animator_add(_smart_momentum_animator, sd);
                                            ev->event_flags |= EVAS_EVENT_FLAG_ON_SCROLL;
@@ -2549,8 +2549,8 @@
    sd->bounce_vert = 1;
 
    sd->one_dir_at_a_time = 1;
-   sd->momentum_animator_disabled = 0;
-   sd->bounce_animator_disabled = 0;
+   sd->momentum_animator_disabled = EINA_FALSE;
+   sd->bounce_animator_disabled = EINA_FALSE;
 
    o = edje_object_add(evas_object_evas_get(obj));
    evas_object_propagate_events_set(o, 0);
@@ -2695,4 +2695,3 @@
         _smart = evas_smart_class_new(&sc);
      }
 }
-

Log:
Elementary: Use !! to Eina_Bool substitution in EAPIs.
  

Author:       seoz
Date:         2011-04-27 09:06:11 -0700 (Wed, 27 Apr 2011)
New Revision: 58968
Trac:         http://trac.enlightenment.org/e/changeset/58968

Modified:
  trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_menu.c trunk/elementary/src/lib/elm_toolbar.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-04-27 16:01:47 UTC (rev 58967)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-04-27 16:06:11 UTC (rev 58968)
@@ -2313,7 +2313,7 @@
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(item);
    if (item->disabled == disabled) return;
    if (item->delete_me) return;
-   item->disabled = disabled;
+   item->disabled = !!disabled;
    if (item->realized)
      {
         if (item->disabled)

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-04-27 16:01:47 UTC (rev 58967)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-04-27 16:06:11 UTC (rev 58968)
@@ -3907,7 +3907,7 @@
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
    if (it->disabled == disabled) return;
    if (it->delete_me) return;
-   it->disabled = disabled;
+   it->disabled = !!disabled;
    if (it->realized)
      {
         if (it->disabled)

Modified: trunk/elementary/src/lib/elm_menu.c
===================================================================
--- trunk/elementary/src/lib/elm_menu.c	2011-04-27 16:01:47 UTC (rev 58967)
+++ trunk/elementary/src/lib/elm_menu.c	2011-04-27 16:06:11 UTC (rev 58968)
@@ -779,7 +779,7 @@
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(item);
    if (disabled == item->disabled) return;
-   item->disabled = disabled;
+   item->disabled = !!disabled;
    if (disabled)
      {
         edje_object_signal_emit(item->base.view, "elm,state,disabled", "elm");

Modified: trunk/elementary/src/lib/elm_toolbar.c
===================================================================
--- trunk/elementary/src/lib/elm_toolbar.c	2011-04-27 16:01:47 UTC (rev 58967)
+++ trunk/elementary/src/lib/elm_toolbar.c	2011-04-27 16:06:11 UTC (rev 58968)
@@ -213,7 +213,7 @@
 
    if (!wd) return;
    if (it->disabled == disabled) return;
-   it->disabled = disabled;
+   it->disabled = !!disabled;
    if (it->disabled)
      {
         edje_object_signal_emit(it->base.view, "elm,state,disabled", "elm");

Log:
Elementary elm_widget: Use Eina_Bool instead of int for boolean type.
  

Author:       seoz
Date:         2011-04-27 09:12:56 -0700 (Wed, 27 Apr 2011)
New Revision: 58969
Trac:         http://trac.enlightenment.org/e/changeset/58969

Modified:
  trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_widget.h 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-04-27 16:06:11 UTC (rev 58968)
+++ trunk/elementary/src/lib/elm_widget.c	2011-04-27 16:12:56 UTC (rev 58969)
@@ -1775,12 +1775,12 @@
 
 EAPI void
 elm_widget_disabled_set(Evas_Object *obj,
-                        int          disabled)
+                        Eina_Bool    disabled)
 {
    API_ENTRY return;
 
    if (sd->disabled == disabled) return;
-   sd->disabled = disabled;
+   sd->disabled = !!disabled;
    if (sd->focused)
      {
         Evas_Object *o, *parent;
@@ -1798,7 +1798,7 @@
    if (sd->disable_func) sd->disable_func(obj);
 }
 
-EAPI int
+EAPI Eina_Bool
 elm_widget_disabled_get(const Evas_Object *obj)
 {
    API_ENTRY return 0;

Modified: trunk/elementary/src/lib/elm_widget.h
===================================================================
--- trunk/elementary/src/lib/elm_widget.h	2011-04-27 16:06:11 UTC (rev 58968)
+++ trunk/elementary/src/lib/elm_widget.h	2011-04-27 16:12:56 UTC (rev 58969)
@@ -268,8 +268,8 @@
 EAPI void             elm_widget_focus_steal(Evas_Object *obj);
 EAPI void             elm_widget_activate(Evas_Object *obj);
 EAPI void             elm_widget_change(Evas_Object *obj);
-EAPI void             elm_widget_disabled_set(Evas_Object *obj, int disabled);
-EAPI int              elm_widget_disabled_get(const Evas_Object *obj);
+EAPI void             elm_widget_disabled_set(Evas_Object *obj, Eina_Bool disabled);
+EAPI Eina_Bool        elm_widget_disabled_get(const Evas_Object *obj);
 EAPI void             elm_widget_show_region_set(Evas_Object *obj, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h);
 EAPI void             elm_widget_show_region_get(const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h);
 EAPI void             elm_widget_focus_region_get(const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h);

Log:
Elementary thumb: Fixed warning.
  

Author:       seoz
Date:         2011-04-27 17:33:46 -0700 (Wed, 27 Apr 2011)
New Revision: 58981
Trac:         http://trac.enlightenment.org/e/changeset/58981

Modified:
  trunk/elementary/src/lib/elm_thumb.c 

Modified: trunk/elementary/src/lib/elm_thumb.c
===================================================================
--- trunk/elementary/src/lib/elm_thumb.c	2011-04-27 19:44:57 UTC (rev 58980)
+++ trunk/elementary/src/lib/elm_thumb.c	2011-04-28 00:33:46 UTC (rev 58981)
@@ -245,7 +245,7 @@
 }
 
 static void
-_thumb_exists(Ethumb_Client *client, Ethumb_Exists *thread,
+_thumb_exists(Ethumb_Client *client __UNUSED__, Ethumb_Exists *thread,
               Eina_Bool exists, void *data)
 {
    Widget_Data *wd = data;

Log:
Elementary thumb: Added ethumb check routine.
  

Author:       seoz
Date:         2011-04-27 19:01:13 -0700 (Wed, 27 Apr 2011)
New Revision: 58982
Trac:         http://trac.enlightenment.org/e/changeset/58982

Modified:
  trunk/elementary/src/lib/elm_thumb.c 

Modified: trunk/elementary/src/lib/elm_thumb.c
===================================================================
--- trunk/elementary/src/lib/elm_thumb.c	2011-04-28 00:33:46 UTC (rev 58981)
+++ trunk/elementary/src/lib/elm_thumb.c	2011-04-28 02:01:13 UTC (rev 58982)
@@ -35,7 +35,9 @@
         int id;
         const char *file;
         const char *key;
+#ifdef HAVE_ELEMENTARY_ETHUMB
         Ethumb_Exists *exists;
+#endif
      } thumb;
    Ecore_Event_Handler *eeh;
    Elm_Thumb_Animation_Setting anim_setting;
@@ -473,12 +475,12 @@
    wd->key = NULL;
    wd->eeh = NULL;
    wd->thumb.id = -1;
-   wd->thumb.exists = NULL;
    wd->on_hold = EINA_FALSE;
    wd->is_video = EINA_FALSE;
    wd->was_video = EINA_FALSE;
 
 #ifdef HAVE_ELEMENTARY_ETHUMB
+   wd->thumb.exists = NULL;
    evas_object_event_callback_add(obj, EVAS_CALLBACK_MOUSE_DOWN,
                                   _mouse_down_cb, wd);
    evas_object_event_callback_add(obj, EVAS_CALLBACK_MOUSE_UP,

Log:
Elementary map: Added wd vadidation check routine to EAPIs.
  

Author:       seoz
Date:         2011-04-27 21:16:00 -0700 (Wed, 27 Apr 2011)
New Revision: 58986
Trac:         http://trac.enlightenment.org/e/changeset/58986

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-04-28 02:47:12 UTC (rev 58985)
+++ trunk/elementary/src/lib/elm_map.c	2011-04-28 04:16:00 UTC (rev 58986)
@@ -3550,6 +3550,7 @@
 elm_map_utils_convert_coord_into_geo(const Evas_Object *obj, int x, int y, int size, double *lon, double *lat)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return;
    int zoom = floor(log(size/256) / log(2));
 
    if (elm_map_source_get(obj) == ELM_MAP_SOURCE_MODULE)
@@ -3583,6 +3584,7 @@
 elm_map_utils_convert_geo_into_coord(const Evas_Object *obj, double lon, double lat, int size, int *x, int *y)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return;
    int zoom = floor(log(size/256) / log(2));
 
    if (elm_map_source_get(obj) == ELM_MAP_SOURCE_MODULE)
@@ -4853,6 +4855,7 @@
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
 
+   if (!wd) return;
    wd->rotate.d = degree;
    wd->rotate.cx = cx;
    wd->rotate.cy = cy;
@@ -4875,6 +4878,7 @@
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
 
+   if (!wd) return;
    if (degree) *degree = wd->rotate.d;
    if (cx) *cx = wd->rotate.cx;
    if (cy) *cy = wd->rotate.cy;
@@ -4894,6 +4898,7 @@
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
 
+   if (!wd) return;
    if ((!wd->wheel_disabled) && (disabled))
      evas_object_event_callback_del_full(wd->rect, EVAS_CALLBACK_MOUSE_WHEEL, _mouse_wheel_cb, obj);
    else if ((wd->wheel_disabled) && (!disabled))
@@ -4914,6 +4919,7 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE;
    Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return EINA_FALSE;
    return wd->wheel_disabled;
 }

Log:
Elementary icon: Fixed doxygen typo.
  

Author:       seoz
Date:         2011-04-28 01:10:34 -0700 (Thu, 28 Apr 2011)
New Revision: 58990
Trac:         http://trac.enlightenment.org/e/changeset/58990

Modified:
  trunk/elementary/src/lib/elm_icon.c 

Modified: trunk/elementary/src/lib/elm_icon.c
===================================================================
--- trunk/elementary/src/lib/elm_icon.c	2011-04-28 07:51:46 UTC (rev 58989)
+++ trunk/elementary/src/lib/elm_icon.c	2011-04-28 08:10:34 UTC (rev 58990)
@@ -356,7 +356,7 @@
 }
 
 /**
- * Set the theme, as standard, for a icon.
+ * Set the theme, as standard, for an icon.
  * If theme was not found and it is the absolute path of an image file, this
  * image will be used.
  *
@@ -418,7 +418,7 @@
 }
 
 /**
- * Get the theme, as standard, for a icon
+ * Get the theme, as standard, for an icon
  *
  * @param obj The icon object
  * @return The theme name
@@ -468,7 +468,7 @@
 }
 
 /**
- * Set the smooth effect for a icon
+ * Set the smooth effect for an icon
  *
  * @param obj The icon object
  * @param smooth A bool to set (or no) smooth effect
@@ -488,7 +488,7 @@
 }
 
 /**
- * Get the smooth effect for a icon
+ * Get the smooth effect for an icon
  *
  * @param obj The icon object
  * @return If setted smooth effect

Log:
Elementary map: Use !! to Eina_Bool substitution in EAPIs.
  

Author:       seoz
Date:         2011-04-28 08:12:28 -0700 (Thu, 28 Apr 2011)
New Revision: 59008
Trac:         http://trac.enlightenment.org/e/changeset/59008

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-04-28 15:10:25 UTC (rev 59007)
+++ trunk/elementary/src/lib/elm_map.c	2011-04-28 15:12:28 UTC (rev 59008)
@@ -4968,7 +4968,7 @@
      evas_object_event_callback_del_full(wd->rect, EVAS_CALLBACK_MOUSE_WHEEL, _mouse_wheel_cb, obj);
    else if ((wd->wheel_disabled) && (!disabled))
      evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_MOUSE_WHEEL, _mouse_wheel_cb, obj);
-   wd->wheel_disabled = disabled;
+   wd->wheel_disabled = !!disabled;
 }
 
 /**

Log:
Elementary main: Fixed doxygen typo.
  

Author:       seoz
Date:         2011-04-28 08:25:16 -0700 (Thu, 28 Apr 2011)
New Revision: 59009
Trac:         http://trac.enlightenment.org/e/changeset/59009

Modified:
  trunk/elementary/src/lib/elm_main.c 

Modified: trunk/elementary/src/lib/elm_main.c
===================================================================
--- trunk/elementary/src/lib/elm_main.c	2011-04-28 15:12:28 UTC (rev 59008)
+++ trunk/elementary/src/lib/elm_main.c	2011-04-28 15:25:16 UTC (rev 59009)
@@ -159,7 +159,7 @@
 @endverbatim
  *
  * Note sudo was assumed to get root permissions, as this would install in
- * /usr/local which is system-owned. Ue any way you like to gain root, or
+ * /usr/local which is system-owned. Use any way you like to gain root, or
  * specify a different prefix with configure:
  *
 @verbatim
@@ -188,7 +188,7 @@
  * included (that is sources for your application, not libraries it depends
  * on like Elementary). It builds cleanly in a buildroot and does not
  * contain any files that are temporarily generated like binaries and other
- * build-gnerated files, so the tarball is clean, and no need to worry
+ * build-generated files, so the tarball is clean, and no need to worry
  * about cleaning up your tree before packaging.
  *
 @verbatim
@@ -1174,7 +1174,7 @@
 /**
  * @defgroup UI-Mirroring Selective Widget mirroring
  *
- * These functions allow you to set ui-miroring on specific widgets or whe
+ * These functions allow you to set ui-mirroring on specific widgets or the
  * whole interface. Widgets can be in one of two modes, automatic and manual.
  * Automatic means they'll be changed according to the system mirroring mode
  * and manual means only explicit changes will matter. You are not supposed to

Log:
Elementary table: Fixed wrong API name. Patch by Lionel Orry
  <lionel.orry@...>
  
  From Lionel Orry:
  Hi devs,
  
  while working on the ffi-efl Ruby bindings for the EFL, I noticed a
  wrong declaration in Elementary.h:
  s/elm_table_homogeneous_get/elm_table_homogenous_get/.
  
  The patch can be found here: http://pastie.org/1846490
  
  To apply:
  
  cd <path/to/elementary>
  wget -O - http://pastie.org/pastes/1846490/download | patch -p0
  
  Thanks in advance,
  Lionel
  

Author:       seoz
Date:         2011-04-29 02:04:48 -0700 (Fri, 29 Apr 2011)
New Revision: 59033
Trac:         http://trac.enlightenment.org/e/changeset/59033

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-04-29 07:39:28 UTC (rev 59032)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-04-29 09:04:48 UTC (rev 59033)
@@ -900,7 +900,7 @@
    /* table */
    EAPI Evas_Object *elm_table_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_homogenous_set(Evas_Object *obj, Eina_Bool homogenous) EINA_ARG_NONNULL(1);
-   EAPI Eina_Bool    elm_table_homogeneous_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool    elm_table_homogenous_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_padding_set(Evas_Object *obj, Evas_Coord horizontal, Evas_Coord vertical) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_padding_get(const Evas_Object *obj, Evas_Coord *horizontal, Evas_Coord *vertical) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_pack(Evas_Object *obj, Evas_Object *subobj, int x, int y, int w, int h) EINA_ARG_NONNULL(1);

Log:
Elementary gengrid: Fixed bug. Patch by Jeonghyun Yun
  <hj0506.yun@...>
  
  From Jeonghyun Yun.
  Hello.
  
  I attached the patch file for calc_job bug.
  
  I found ecore_magic_fail problem when ecore_job_del(wd->calc_job).
  wd->calc_job should also to be NULL when pan_smart's cvw and cvh is 0 in
  calc_job().
  
  Please check about this patch.
  
  Thanks.
  

Author:       seoz
Date:         2011-04-29 03:50:55 -0700 (Fri, 29 Apr 2011)
New Revision: 59034
Trac:         http://trac.enlightenment.org/e/changeset/59034

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-04-29 09:04:48 UTC (rev 59033)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-04-29 10:50:55 UTC (rev 59034)
@@ -1339,9 +1339,9 @@
           }
 
         wd->nmax = nmax;
-        wd->calc_job = NULL;
         evas_object_smart_changed(wd->pan_smart);
      }
+   wd->calc_job = NULL;
 }
 
 static void

Log:
Elementary layout: Removed 'const' from elm_layout_content_get() API.
  
  This API callers can handle layout content. ex)
  evas_object_del(content);
  

Author:       seoz
Date:         2011-04-29 05:33:36 -0700 (Fri, 29 Apr 2011)
New Revision: 59035
Trac:         http://trac.enlightenment.org/e/changeset/59035

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_layout.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-04-29 10:50:55 UTC (rev 59034)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-04-29 12:33:36 UTC (rev 59035)
@@ -1043,7 +1043,7 @@
    EAPI Eina_Bool          elm_layout_file_set(Evas_Object *obj, const char *file, const char *group) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool          elm_layout_theme_set(Evas_Object *obj, const char *clas, const char *group, const char *style) EINA_ARG_NONNULL(1);
    EAPI void               elm_layout_content_set(Evas_Object *obj, const char *swallow, Evas_Object *content) EINA_ARG_NONNULL(1);
-   EAPI const Evas_Object *elm_layout_content_get(const Evas_Object *obj, const char *swallow) EINA_ARG_NONNULL(1);
+   EAPI Evas_Object       *elm_layout_content_get(const Evas_Object *obj, const char *swallow) EINA_ARG_NONNULL(1);
    EAPI Evas_Object       *elm_layout_content_unset(Evas_Object *obj, const char *swallow) EINA_ARG_NONNULL(1);
    EAPI void               elm_layout_text_set(Evas_Object *obj, const char *part, const char *text) EINA_ARG_NONNULL(1);
    EAPI const char        *elm_layout_text_get(const Evas_Object *obj, const char *part) EINA_ARG_NONNULL(1);

Modified: trunk/elementary/src/lib/elm_layout.c
===================================================================
--- trunk/elementary/src/lib/elm_layout.c	2011-04-29 10:50:55 UTC (rev 59034)
+++ trunk/elementary/src/lib/elm_layout.c	2011-04-29 12:33:36 UTC (rev 59035)
@@ -464,7 +464,7 @@
  *
  * @ingroup Layout
  */
-EAPI const Evas_Object *
+EAPI Evas_Object *
 elm_layout_content_get(const Evas_Object *obj, const char *swallow)
 {
    Widget_Data *wd = elm_widget_data_get(obj);

Log:
Elementary thumb: Fixed warnings.
  

Author:       seoz
Date:         2011-04-29 05:40:47 -0700 (Fri, 29 Apr 2011)
New Revision: 59037
Trac:         http://trac.enlightenment.org/e/changeset/59037

Modified:
  trunk/elementary/src/lib/elm_thumb.c 

Modified: trunk/elementary/src/lib/elm_thumb.c
===================================================================
--- trunk/elementary/src/lib/elm_thumb.c	2011-04-29 12:37:31 UTC (rev 59036)
+++ trunk/elementary/src/lib/elm_thumb.c	2011-04-29 12:40:47 UTC (rev 59037)
@@ -84,8 +84,10 @@
 
 struct _Ethumb_Client *_elm_ethumb_client = NULL;
 Eina_Bool _elm_ethumb_connected = EINA_FALSE;
+#ifdef HAVE_ELEMENTARY_ETHUMB
 static Eina_List *retry = NULL;
 static int pending_request = 0;
+#endif
 
 EAPI int ELM_ECORE_EVENT_ETHUMB_CONNECT = 0;

Log:
Elementary genlist: Fixed warning. Spank raster.
  

Author:       seoz
Date:         2011-05-03 10:32:18 -0700 (Tue, 03 May 2011)
New Revision: 59154
Trac:         http://trac.enlightenment.org/e/changeset/59154

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-03 16:18:17 UTC (rev 59153)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-03 17:32:18 UTC (rev 59154)
@@ -1965,7 +1965,7 @@
 _item_block_recalc(Item_Block *itb,
                    int         in,
                    int         qadd,
-                   int         norender)
+                   int         norender __UNUSED__)
 {
    const Eina_List *l;
    Elm_Genlist_Item *it;

Log:
Elementary genlist: Fixed item disabled set bug and disabled swallow
  objects as well.
  

Author:       seoz
Date:         2011-05-05 19:07:00 -0700 (Thu, 05 May 2011)
New Revision: 59228
Trac:         http://trac.enlightenment.org/e/changeset/59228

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-05 21:56:12 UTC (rev 59227)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-06 02:07:00 UTC (rev 59228)
@@ -1694,6 +1694,8 @@
                   edje_object_part_swallow(target, key, ic);
                   evas_object_show(ic);
                   elm_widget_sub_object_add(it->base.widget, ic);
+                  if (it->disabled)
+                    elm_widget_disabled_set(ic, EINA_TRUE);
                }
           }
      }
@@ -3789,7 +3791,7 @@
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
    Widget_Data *wd = elm_widget_data_get(it->base.widget);
    if (!wd) return;
-   if (it->delete_me) return;
+   if ((it->delete_me) && (it->disabled)) return;
    selected = !!selected;
    if (it->selected == selected) return;
 
@@ -3905,15 +3907,21 @@
                               Eina_Bool         disabled)
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
+   Eina_List *l;
+   Evas_Object *obj;
    if (it->disabled == disabled) return;
    if (it->delete_me) return;
    it->disabled = !!disabled;
+   if (it->selected)
+     elm_genlist_item_selected_set(it, EINA_FALSE);
    if (it->realized)
      {
         if (it->disabled)
           edje_object_signal_emit(it->base.view, "elm,state,disabled", "elm");
         else
           edje_object_signal_emit(it->base.view, "elm,state,enabled", "elm");
+        EINA_LIST_FOREACH(it->icon_objs, l, obj)
+          elm_widget_disabled_set(obj, disabled);
      }
 }

Log:
Elementary genlist: Fixed item disabled set bug more and fixed my
  previous commit.
  

Author:       seoz
Date:         2011-05-05 19:59:49 -0700 (Thu, 05 May 2011)
New Revision: 59229
Trac:         http://trac.enlightenment.org/e/changeset/59229

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-06 02:07:00 UTC (rev 59228)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-06 02:59:49 UTC (rev 59229)
@@ -3791,7 +3791,7 @@
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
    Widget_Data *wd = elm_widget_data_get(it->base.widget);
    if (!wd) return;
-   if ((it->delete_me) && (it->disabled)) return;
+   if ((it->delete_me) || (it->disabled)) return;
    selected = !!selected;
    if (it->selected == selected) return;
 
@@ -5162,6 +5162,7 @@
 
    if (!wd) return;
    if (!mode_type) return;
+   if ((it->delete_me) || (it->disabled)) return;
 
    if ((wd->mode_item == it) &&
        (!strcmp(mode_type, wd->mode_type)) &&

Log:
Elementary slideshow: Fixed doxygen typo.
  

Author:       seoz
Date:         2011-05-06 16:29:55 -0700 (Fri, 06 May 2011)
New Revision: 59254
Trac:         http://trac.enlightenment.org/e/changeset/59254

Modified:
  trunk/elementary/src/lib/elm_slideshow.c 

Modified: trunk/elementary/src/lib/elm_slideshow.c
===================================================================
--- trunk/elementary/src/lib/elm_slideshow.c	2011-05-06 19:14:39 UTC (rev 59253)
+++ trunk/elementary/src/lib/elm_slideshow.c	2011-05-06 23:29:55 UTC (rev 59254)
@@ -11,7 +11,7 @@
  *
  * The slideshow use 2 callbacks to create and delete the objects displayed. When an item
  * is displayed the function itc->func.get() is called. This function should create the object,
- * for example the object can be an evas_object_image or a photocam. When a object is no more
+ * for example the object can be an evas_object_image or a photocam. When an object is no more
  * displayed the function itc->func.del() is called, the user can delete the dana associated to the item.
  *
  * Signals that you can add callbacks for are:
@@ -395,7 +395,7 @@
 }
 
 /**
- * Add a object in the list. The object can be a evas object image or a elm photo for example.
+ * Add an object in the list. The object can be a evas object image or a elm photo for example.
  *
  * @param obj The slideshow object
  * @aram itc Callbacks used to create the object and delete the data associated when the item is deleted.
@@ -425,7 +425,7 @@
 }
 
 /**
- * Insert a object in the list. The object can be a evas object image or a elm photo for example.
+ * Insert an object in the list. The object can be a evas object image or a elm photo for example.
  *
  * @param obj The slideshow object
  * @aram itc Callbacks used to create the object and delete the data associated when the item is deleted.

Log:
Elementary genlist: Use signal callback table.
  

Author:       seoz
Date:         2011-05-06 17:30:39 -0700 (Fri, 06 May 2011)
New Revision: 59255
Trac:         http://trac.enlightenment.org/e/changeset/59255

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-06 23:29:55 UTC (rev 59254)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-07 00:30:39 UTC (rev 59255)
@@ -391,6 +391,65 @@
 
 static Evas_Smart_Class _pan_sc = EVAS_SMART_CLASS_INIT_VERSION;
 
+static const char SIG_CLICKED_DOUBLE[] = "clicked,double";
+static const char SIG_SELECTED[] = "selected";
+static const char SIG_UNSELECTED[] = "unselected";
+static const char SIG_EXPANDED[] = "expanded";
+static const char SIG_CONTRACTED[] = "contracted";
+static const char SIG_EXPAND_REQUEST[] = "expand,request";
+static const char SIG_CONTRACT_REQUEST[] = "contract,request";
+static const char SIG_REALIZED[] = "realized";
+static const char SIG_UNREALIZED[] = "unrealized";
+static const char SIG_DRAG_START_UP[] = "drag,start,up";
+static const char SIG_DRAG_START_DOWN[] = "drag,start,down";
+static const char SIG_DRAG_START_LEFT[] = "drag,start,left";
+static const char SIG_DRAG_START_RIGHT[] = "drag,start,right";
+static const char SIG_DRAG_STOP[] = "drag,stop";
+static const char SIG_DRAG[] = "drag";
+static const char SIG_LONGPRESSED[] = "longpressed";
+static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top";
+static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom";
+static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left";
+static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right";
+static const char SIG_MULTI_SWIPE_LEFT[] = "multi,swipe,left";
+static const char SIG_MULTI_SWIPE_RIGHT[] = "multi,swipe,right";
+static const char SIG_MULTI_SWIPE_UP[] = "multi,swipe,up";
+static const char SIG_MULTI_SWIPE_DOWN[] = "multi,swipe,down";
+static const char SIG_MULTI_PINCH_OUT[] = "multi,pinch,out";
+static const char SIG_MULTI_PINCH_IN[] = "multi,pinch,in";
+static const char SIG_SWIPE[] = "swipe";
+
+static const Evas_Smart_Cb_Description _signals[] = {
+   {SIG_CLICKED_DOUBLE, ""},
+   {SIG_SELECTED, ""},
+   {SIG_UNSELECTED, ""},
+   {SIG_EXPANDED, ""},
+   {SIG_CONTRACTED, ""},
+   {SIG_EXPAND_REQUEST, ""},
+   {SIG_CONTRACT_REQUEST, ""},
+   {SIG_REALIZED, ""},
+   {SIG_UNREALIZED, ""},
+   {SIG_DRAG_START_UP, ""},
+   {SIG_DRAG_START_DOWN, ""},
+   {SIG_DRAG_START_LEFT, ""},
+   {SIG_DRAG_START_RIGHT, ""},
+   {SIG_DRAG_STOP, ""},
+   {SIG_DRAG, ""},
+   {SIG_LONGPRESSED, ""},
+   {SIG_SCROLL_EDGE_TOP, ""},
+   {SIG_SCROLL_EDGE_BOTTOM, ""},
+   {SIG_SCROLL_EDGE_LEFT, ""},
+   {SIG_SCROLL_EDGE_RIGHT, ""},
+   {SIG_MULTI_SWIPE_LEFT, ""},
+   {SIG_MULTI_SWIPE_RIGHT, ""},
+   {SIG_MULTI_SWIPE_UP, ""},
+   {SIG_MULTI_SWIPE_DOWN, ""},
+   {SIG_MULTI_PINCH_OUT, ""},
+   {SIG_MULTI_PINCH_IN, ""},
+   {SIG_SWIPE, ""},
+   {NULL, NULL}
+};
+
 static Eina_Bool
 _event_hook(Evas_Object       *obj,
             Evas_Object       *src __UNUSED__,
@@ -904,7 +963,7 @@
    it->wd->walking++;
    if (it->func.func) it->func.func((void *)it->func.data, it->base.widget, it);
    if (!it->delete_me)
-     evas_object_smart_callback_call(it->base.widget, "selected", it);
+     evas_object_smart_callback_call(it->base.widget, SIG_SELECTED, it);
    it->walking--;
    it->wd->walking--;
    if ((it->wd->clear_me) && (!it->wd->walking))
@@ -938,7 +997,7 @@
      {
         it->selected = EINA_FALSE;
         it->wd->selected = eina_list_remove(it->wd->selected, it);
-        evas_object_smart_callback_call(it->base.widget, "unselected", it);
+        evas_object_smart_callback_call(it->base.widget, SIG_UNSELECTED, it);
      }
 }
 
@@ -985,7 +1044,7 @@
              ecore_timer_del(it->long_timer);
              it->long_timer = NULL;
           }
-        evas_object_smart_callback_call(it->base.widget, "drag", it);
+        evas_object_smart_callback_call(it->base.widget, SIG_DRAG, it);
         return;
      }
    if ((!it->down) /* || (it->wd->on_hold)*/ || (it->wd->longpressed))
@@ -1024,30 +1083,30 @@
           {
              if (ady > adx)
                evas_object_smart_callback_call(it->base.widget,
-                                               "drag,start,up", it);
+                                               SIG_DRAG_START_UP, it);
              else
                {
                   if (dx < 0)
                     evas_object_smart_callback_call(it->base.widget,
-                                                    "drag,start,left", it);
+                                                    SIG_DRAG_START_LEFT, it);
                   else
                     evas_object_smart_callback_call(it->base.widget,
-                                                    "drag,start,right", it);
+                                                    SIG_DRAG_START_RIGHT, it);
                }
           }
         else
           {
              if (ady > adx)
                evas_object_smart_callback_call(it->base.widget,
-                                               "drag,start,down", it);
+                                               SIG_DRAG_START_DOWN, it);
              else
                {
                   if (dx < 0)
                     evas_object_smart_callback_call(it->base.widget,
-                                                    "drag,start,left", it);
+                                                    SIG_DRAG_START_LEFT, it);
                   else
                     evas_object_smart_callback_call(it->base.widget,
-                                                    "drag,start,right", it);
+                                                    SIG_DRAG_START_RIGHT, it);
                }
           }
      }
@@ -1062,7 +1121,7 @@
    if ((it->disabled) || (it->dragging) || (it->display_only))
      return ECORE_CALLBACK_CANCEL;
    it->wd->longpressed = EINA_TRUE;
-   evas_object_smart_callback_call(it->base.widget, "longpressed", it);
+   evas_object_smart_callback_call(it->base.widget, SIG_LONGPRESSED, it);
    return ECORE_CALLBACK_CANCEL;
 }
 
@@ -1082,7 +1141,7 @@
 
    sum /= it->wd->movements;
    if (abs(sum - it->wd->history[0].x) <= 10) return;
-   evas_object_smart_callback_call(it->base.widget, "swipe", it);
+   evas_object_smart_callback_call(it->base.widget, SIG_SWIPE, it);
 }
 
 static Eina_Bool
@@ -1138,31 +1197,31 @@
           {
              if ((it->wd->cur_x > it->wd->prev_x) && (it->wd->cur_mx > it->wd->prev_mx))
                evas_object_smart_callback_call(it->base.widget,
-                                               "multi,swipe,right", it);
+                                               SIG_MULTI_SWIPE_RIGHT, it);
              else if ((it->wd->cur_x < it->wd->prev_x) && (it->wd->cur_mx < it->wd->prev_mx))
                evas_object_smart_callback_call(it->base.widget,
-                                               "multi,swipe,left", it);
+                                               SIG_MULTI_SWIPE_LEFT, it);
              else if (abs(it->wd->cur_x - it->wd->cur_mx) > abs(it->wd->prev_x - it->wd->prev_mx))
                evas_object_smart_callback_call(it->base.widget,
-                                               "multi,pinch,out", it);
+                                               SIG_MULTI_PINCH_OUT, it);
              else
                evas_object_smart_callback_call(it->base.widget,
-                                               "multi,pinch,in", it);
+                                               SIG_MULTI_PINCH_IN, it);
           }
         else
           {
              if ((it->wd->cur_y > it->wd->prev_y) && (it->wd->cur_my > it->wd->prev_my))
                evas_object_smart_callback_call(it->base.widget,
-                                               "multi,swipe,down", it);
+                                               SIG_MULTI_SWIPE_DOWN, it);
              else if ((it->wd->cur_y < it->wd->prev_y) && (it->wd->cur_my < it->wd->prev_my))
                evas_object_smart_callback_call(it->base.widget,
-                                               "multi,swipe,up", it);
+                                               SIG_MULTI_SWIPE_UP, it);
              else if (abs(it->wd->cur_y - it->wd->cur_my) > abs(it->wd->prev_y - it->wd->prev_my))
                evas_object_smart_callback_call(it->base.widget,
-                                               "multi,pinch,out", it);
+                                               SIG_MULTI_PINCH_OUT, it);
              else
                evas_object_smart_callback_call(it->base.widget,
-                                               "multi,pinch,in", it);
+                                               SIG_MULTI_PINCH_IN, it);
           }
      }
    it->wd->multi_timeout = EINA_FALSE;
@@ -1194,7 +1253,7 @@
    if (it->dragging)
      {
         it->dragging = EINA_FALSE;
-        evas_object_smart_callback_call(it->base.widget, "drag,stop", it);
+        evas_object_smart_callback_call(it->base.widget, SIG_DRAG_STOP, it);
      }
    if (it->swipe_timer)
      {
@@ -1278,7 +1337,7 @@
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
      if ((!it->disabled) && (!it->display_only))
        {
-          evas_object_smart_callback_call(it->base.widget, "clicked,double", it);
+          evas_object_smart_callback_call(it->base.widget, SIG_CLICKED_DOUBLE, it);
           evas_object_smart_callback_call(it->base.widget, "clicked", it); // will be removed
        }
    if (it->long_timer) ecore_timer_del(it->long_timer);
@@ -1322,7 +1381,7 @@
    if (it->dragging)
      {
         it->dragging = EINA_FALSE;
-        evas_object_smart_callback_call(it->base.widget, "drag,stop", it);
+        evas_object_smart_callback_call(it->base.widget, SIG_DRAG_STOP, it);
         dragged = 1;
      }
    if (it->swipe_timer)
@@ -1405,9 +1464,9 @@
    Elm_Genlist_Item *it = data;
 
    if (it->expanded)
-     evas_object_smart_callback_call(it->base.widget, "contract,request", it);
+     evas_object_smart_callback_call(it->base.widget, SIG_CONTRACT_REQUEST, it);
    else
-     evas_object_smart_callback_call(it->base.widget, "expand,request", it);
+     evas_object_smart_callback_call(it->base.widget, SIG_EXPAND_REQUEST, it);
 }
 
 static void
@@ -1419,7 +1478,7 @@
    Elm_Genlist_Item *it = data;
 
    if (!it->expanded)
-     evas_object_smart_callback_call(it->base.widget, "expand,request", it);
+     evas_object_smart_callback_call(it->base.widget, SIG_EXPAND_REQUEST, it);
 }
 
 static void
@@ -1431,7 +1490,7 @@
    Elm_Genlist_Item *it = data;
 
    if (it->expanded)
-     evas_object_smart_callback_call(it->base.widget, "contract,request", it);
+     evas_object_smart_callback_call(it->base.widget, SIG_CONTRACT_REQUEST, it);
 }
 
 static Eina_Bool
@@ -1920,7 +1979,7 @@
    it->want_unrealize = EINA_FALSE;
 
    if (itc) _item_cache_free(itc);
-   if (!calc) evas_object_smart_callback_call(it->base.widget, "realized", it);
+   if (!calc) evas_object_smart_callback_call(it->base.widget, SIG_REALIZED, it);
 }
 
 static void
@@ -1929,7 +1988,7 @@
    Evas_Object *icon;
 
    if (!it->realized) return;
-   if (!calc) evas_object_smart_callback_call(it->base.widget, "unrealized", it);
+   if (!calc) evas_object_smart_callback_call(it->base.widget, SIG_UNREALIZED, it);
    if (it->long_timer)
      {
         ecore_timer_del(it->long_timer);
@@ -2609,7 +2668,7 @@
                   void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
-   evas_object_smart_callback_call(obj, "scroll,edge,left", NULL);
+   evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_LEFT, NULL);
 }
 
 static void
@@ -2618,7 +2677,7 @@
                    void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
-   evas_object_smart_callback_call(obj, "scroll,edge,right", NULL);
+   evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_RIGHT, NULL);
 }
 
 static void
@@ -2627,7 +2686,7 @@
                  void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
-   evas_object_smart_callback_call(obj, "scroll,edge,top", NULL);
+   evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_TOP, NULL);
 }
 
 static void
@@ -2636,7 +2695,7 @@
                     void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
-   evas_object_smart_callback_call(obj, "scroll,edge,bottom", NULL);
+   evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_BOTTOM, NULL);
 }
 
 static void
@@ -2849,6 +2908,8 @@
                              &minw, &minh);
    evas_object_size_hint_min_set(obj, minw, minh);
 
+   evas_object_smart_callbacks_descriptions_set(obj, _signals);
+
    _mirrored_set(obj, elm_widget_mirrored_get(obj));
    _sizing_eval(obj);
    return obj;
@@ -3848,13 +3909,13 @@
      {
         if (it->realized)
           edje_object_signal_emit(it->base.view, "elm,state,expanded", "elm");
-        evas_object_smart_callback_call(it->base.widget, "expanded", it);
+        evas_object_smart_callback_call(it->base.widget, SIG_EXPANDED, it);
      }
    else
      {
         if (it->realized)
           edje_object_signal_emit(it->base.view, "elm,state,contracted", "elm");
-        evas_object_smart_callback_call(it->base.widget, "contracted", it);
+        evas_object_smart_callback_call(it->base.widget, SIG_CONTRACTED, it);
      }
 }

Log:
Elementary genlist: Added "swipe" signal to doxygen.
  

Author:       seoz
Date:         2011-05-06 17:31:17 -0700 (Fri, 06 May 2011)
New Revision: 59256
Trac:         http://trac.enlightenment.org/e/changeset/59256

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-05-07 00:30:39 UTC (rev 59255)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-05-07 00:31:17 UTC (rev 59256)
@@ -1955,6 +1955,7 @@
     *                     out.
     * "multi,pinch,in" - This is called when the genlist is multi-touch pinched
     *                    in.
+    * "swipe" - This is called when the genlist is swiped.
     */
 
    /* check */

Log:
Elementary slideshow: Fixed warnings. Removed unnecessary line.
  

Author:       seoz
Date:         2011-05-10 05:59:57 -0700 (Tue, 10 May 2011)
New Revision: 59309
Trac:         http://trac.enlightenment.org/e/changeset/59309

Modified:
  trunk/elementary/src/lib/elm_slideshow.c 

Modified: trunk/elementary/src/lib/elm_slideshow.c
===================================================================
--- trunk/elementary/src/lib/elm_slideshow.c	2011-05-10 09:06:51 UTC (rev 59308)
+++ trunk/elementary/src/lib/elm_slideshow.c	2011-05-10 12:59:57 UTC (rev 59309)
@@ -971,7 +971,7 @@
 EAPI Elm_Slideshow_Item *
 elm_slideshow_item_nth_get(const Evas_Object *obj, unsigned int nth)
 {
-   ELM_CHECK_WIDTYPE(obj, widtype);
+   ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return NULL;
    return eina_list_nth(wd->items, nth);
@@ -988,9 +988,8 @@
 EAPI unsigned int
 elm_slideshow_count_get(const Evas_Object *obj)
 {
-   ELM_CHECK_WIDTYPE(obj, widtype);
+   ELM_CHECK_WIDTYPE(obj, widtype) 0;
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return 0;
    return eina_list_count(wd->items);
 }
-

Log:
Elementary genlist: Fixed elm_genlist_compress_mode_set().
  
  If compress mode is false, homogeneous mode needs to be false too.
  

Author:       seoz
Date:         2011-05-12 23:10:13 -0700 (Thu, 12 May 2011)
New Revision: 59361
Trac:         http://trac.enlightenment.org/e/changeset/59361

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-13 05:49:36 UTC (rev 59360)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-13 06:10:13 UTC (rev 59361)
@@ -4888,6 +4888,7 @@
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
    wd->compress = compress;
+   if (!compress) elm_genlist_homogeneous_set(obj, EINA_FALSE);
 }
 
 /**

Log:
Elementary elm_config.c: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-05-13 09:55:24 -0700 (Fri, 13 May 2011)
New Revision: 59370
Trac:         http://trac.enlightenment.org/e/changeset/59370

Modified:
  trunk/elementary/src/lib/elm_config.c 

Modified: trunk/elementary/src/lib/elm_config.c
===================================================================
--- trunk/elementary/src/lib/elm_config.c	2011-05-13 11:39:04 UTC (rev 59369)
+++ trunk/elementary/src/lib/elm_config.c	2011-05-13 16:55:24 UTC (rev 59370)
@@ -1438,7 +1438,7 @@
         else if ((!strncmp(s, "shot:", 5)))
           eina_stringshare_replace(&_elm_config->engine, s);
      }
-   
+
    s = getenv("ELM_VSYNC");
    if (s) _elm_config->vsync = !!atoi(s);

Log:
Elementary elm_layout.c: Removed unnecessary lines. Sorry I don't like
  you :)
  

Author:       seoz
Date:         2011-05-13 20:24:46 -0700 (Fri, 13 May 2011)
New Revision: 59373
Trac:         http://trac.enlightenment.org/e/changeset/59373

Modified:
  trunk/elementary/src/lib/elm_layout.c 

Modified: trunk/elementary/src/lib/elm_layout.c
===================================================================
--- trunk/elementary/src/lib/elm_layout.c	2011-05-14 01:22:55 UTC (rev 59372)
+++ trunk/elementary/src/lib/elm_layout.c	2011-05-14 03:24:46 UTC (rev 59373)
@@ -1278,6 +1278,3 @@
    EINA_SAFETY_ON_NULL_RETURN_VAL(pc->obj, EINA_FALSE);
    return elm_object_cursor_engine_only_get(pc->obj);
 }
-
-
-

Log:
Elementary map: Removed Eina.h include. Eina.h is already included in Elementary.h.
  

Author:       seoz
Date:         2011-05-15 10:26:59 -0700 (Sun, 15 May 2011)
New Revision: 59410
Trac:         http://trac.enlightenment.org/e/changeset/59410

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-05-15 16:14:17 UTC (rev 59409)
+++ trunk/elementary/src/lib/elm_map.c	2011-05-15 17:26:59 UTC (rev 59410)
@@ -1,4 +1,3 @@
-#include <Eina.h>
 #include <Ecore_Con.h>
 #include "Elementary.h"
 #include "elm_priv.h"

Log:
Elementary elm_transit.c: Fixed warnings.
  

Author:       seoz
Date:         2011-05-20 23:28:25 -0700 (Fri, 20 May 2011)
New Revision: 59561
Trac:         http://trac.enlightenment.org/e/changeset/59561

Modified:
  trunk/elementary/src/lib/elm_transit.c 

Modified: trunk/elementary/src/lib/elm_transit.c
===================================================================
--- trunk/elementary/src/lib/elm_transit.c	2011-05-21 06:23:33 UTC (rev 59560)
+++ trunk/elementary/src/lib/elm_transit.c	2011-05-21 06:28:25 UTC (rev 59561)
@@ -133,7 +133,7 @@
 }
 
 static Eina_Bool
-_hash_foreach_pass_events_set(const Eina_Hash *hash, const void *key, void *data, void *fdata)
+_hash_foreach_pass_events_set(const Eina_Hash *hash __UNUSED__, const void *key, void *data __UNUSED__, void *fdata)
 {
    Elm_Transit *transit = fdata;
    evas_object_pass_events_set((Evas_Object*) key, transit->event_enabled);
@@ -141,7 +141,7 @@
 }
 
 static Eina_Bool
-_hash_foreach_obj_states_save(const Eina_Hash *hash, const void *key, void *data, void *fdata)
+_hash_foreach_obj_states_save(const Eina_Hash *hash __UNUSED__, const void *key, void *data, void *fdata __UNUSED__)
 {
    _elm_transit_obj_states_save((Evas_Object *) key, (Elm_Obj_Data *) data);
    return EINA_TRUE;
@@ -619,8 +619,6 @@
 elm_transit_event_enabled_set(Elm_Transit *transit, Eina_Bool enabled)
 {
    ELM_TRANSIT_CHECK_OR_RETURN(transit);
-   Evas_Object *obj;
-   Elm_Obj_Data *obj_data;
 
    if (transit->event_enabled == enabled) return;
    transit->event_enabled = !!enabled;
@@ -982,9 +980,6 @@
 EAPI void
 elm_transit_objects_final_state_keep_set(Elm_Transit *transit, Eina_Bool state_keep)
 {
-   Evas_Object *obj;
-   Elm_Obj_Data *obj_data;
-
    ELM_TRANSIT_CHECK_OR_RETURN(transit);
    if (transit->state_keep == state_keep) return;
    if (transit->animator) return;

Log:
Elementary genlist: Removed unnecessary/deprecated codes due to
  internal changes.
  

Author:       seoz
Date:         2011-05-23 05:19:42 -0700 (Mon, 23 May 2011)
New Revision: 59622
Trac:         http://trac.enlightenment.org/e/changeset/59622

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-23 11:22:41 UTC (rev 59621)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-23 12:19:42 UTC (rev 59622)
@@ -2025,8 +2025,7 @@
 static Eina_Bool
 _item_block_recalc(Item_Block *itb,
                    int         in,
-                   int         qadd,
-                   int         norender __UNUSED__)
+                   int         qadd)
 {
    const Eina_List *l;
    Elm_Genlist_Item *it;
@@ -2068,8 +2067,6 @@
    itb->minw = minw;
    itb->minh = minh;
    itb->changed = EINA_FALSE;
-   /* force an evas norender to garbage collect deleted objects */
-//   if (norender) evas_norender(evas_object_evas_get(itb->wd->obj));
    return showme;
 }
 
@@ -2278,7 +2275,7 @@
                   itb->must_recalc = EINA_FALSE;
                }
              if (itb->realized) _item_block_unrealize(itb);
-             showme = _item_block_recalc(itb, in, 0, 1);
+             showme = _item_block_recalc(itb, in, 0);
              chb = itb;
           }
         itb->y = y;
@@ -2415,7 +2412,7 @@
           {
              position = 1;
              itb->changed = EINA_TRUE;
-             _item_block_recalc(itb, num0, 0, 1);
+             _item_block_recalc(itb, num0, 0);
              _item_block_position(itb, num0);
           }
      }
@@ -3086,8 +3083,7 @@
 }
 
 static int
-_queue_process(Widget_Data *wd,
-               int          norender)
+_queue_process(Widget_Data *wd)
 {
    int n;
    Eina_Bool showme = EINA_FALSE;
@@ -3105,8 +3101,7 @@
         t = ecore_time_get();
         if (it->block->changed)
           {
-             showme = _item_block_recalc(it->block, it->block->num, 1,
-                                         norender);
+             showme = _item_block_recalc(it->block, it->block->num, 1);
              it->block->changed = 0;
           }
         if (showme) it->block->showme = EINA_TRUE;
@@ -3127,7 +3122,7 @@
    //static double q_start = 0.0;
    //if (q_start == 0.0) q_start = ecore_time_get();
    //xxx
-   if (_queue_process(wd, 1) > 0) *wakeup = EINA_TRUE;
+   if (_queue_process(wd) > 0) *wakeup = EINA_TRUE;
    if (!wd->queue)
      {
         //xxx
@@ -3169,7 +3164,7 @@
              ecore_idle_enterer_del(wd->queue_idle_enterer);
              wd->queue_idle_enterer = NULL;
           }
-        _queue_process(wd, 0);
+        _queue_process(wd);
      }
    if (!wd->queue_idle_enterer)
       wd->queue_idle_enterer = ecore_idle_enterer_add(_item_idle_enterer, wd);

Log:
Elementary genlist: Removed unnecessary height_for_width codes.
  

Author:       seoz
Date:         2011-05-24 03:51:26 -0700 (Tue, 24 May 2011)
New Revision: 59647
Trac:         http://trac.enlightenment.org/e/changeset/59647

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-24 10:41:37 UTC (rev 59646)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-24 10:51:26 UTC (rev 59647)
@@ -1937,8 +1937,6 @@
           {
              Evas_Coord mw = -1, mh = -1;
 
-             if (it->wd->height_for_width) mw = it->wd->w;
-
              if (!it->display_only)
                elm_coords_finger_size_adjust(1, &mw, 1, &mh);
              if (it->wd->height_for_width) mw = it->wd->prev_viewport_w;
@@ -2245,10 +2243,7 @@
    t0 = ecore_time_get();
    evas_object_geometry_get(wd->pan_smart, NULL, NULL, &ow, &wd->h);
    if (wd->w != ow)
-     {
-        wd->w = ow;
-        //        if (wd->height_for_width) changed = EINA_TRUE;
-     }
+     wd->w = ow;
 
    EINA_INLIST_FOREACH(wd->blocks, itb)
      {

Log:
Elementary genlist: Refactoring. Separated _item_unhighlight() from
  _item_unselect().
  
  1. _item_select() and _item_highlight() are also separated. Each
  function can be called separately. This will be introduced in later
  commit.
  2. 'unhighlight' sounds weird but there is no other good names.
  3. Call _item_unhighlight() before _item_unselect() for selected items.
  

Author:       seoz
Date:         2011-05-24 04:41:00 -0700 (Tue, 24 May 2011)
New Revision: 59652
Trac:         http://trac.enlightenment.org/e/changeset/59652

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-24 11:31:32 UTC (rev 59651)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-24 11:41:00 UTC (rev 59652)
@@ -848,6 +848,22 @@
 }
 
 static void
+_item_unhighlight(Elm_Genlist_Item *it)
+{
+   const char *stacking, *selectraise;
+   if ((it->delete_me) || (!it->highlighted)) return;
+   edje_object_signal_emit(it->base.view, "elm,state,unselected", "elm");
+   stacking = edje_object_data_get(it->base.view, "stacking");
+   selectraise = edje_object_data_get(it->base.view, "selectraise");
+   if (!it->nostacking)
+     {
+       if ((it->order_num_in & 0x1) ^ it->stacking_even) evas_object_lower(it->base.view);
+       else evas_object_raise(it->base.view);
+     }
+   it->highlighted = EINA_FALSE;
+}
+
+static void
 _item_block_del(Elm_Genlist_Item *it)
 {
    Eina_Inlist *il;
@@ -981,24 +997,10 @@
 static void
 _item_unselect(Elm_Genlist_Item *it)
 {
-   const char *stacking, *selectraise;
-
-   if ((it->delete_me) || (!it->highlighted)) return;
-   edje_object_signal_emit(it->base.view, "elm,state,unselected", "elm");
-   stacking = edje_object_data_get(it->base.view, "stacking");
-   selectraise = edje_object_data_get(it->base.view, "selectraise");
-   if (!it->nostacking)
-     {
-       if ((it->order_num_in & 0x1) ^ it->stacking_even) evas_object_lower(it->base.view);
-       else evas_object_raise(it->base.view);
-     }
-   it->highlighted = EINA_FALSE;
-   if (it->selected)
-     {
-        it->selected = EINA_FALSE;
-        it->wd->selected = eina_list_remove(it->wd->selected, it);
-        evas_object_smart_callback_call(it->base.widget, SIG_UNSELECTED, it);
-     }
+   if ((it->delete_me) || (!it->selected)) return;
+   it->selected = EINA_FALSE;
+   it->wd->selected = eina_list_remove(it->wd->selected, it);
+   evas_object_smart_callback_call(it->base.widget, SIG_UNSELECTED, it);
 }
 
 static void
@@ -1017,7 +1019,10 @@
           {
              it->wd->on_hold = EINA_TRUE;
              if (!it->wd->wasselected)
-               _item_unselect(it);
+               {
+                  _item_unhighlight(it);
+                  _item_unselect(it);
+               }
           }
      }
    if (it->wd->multitouched)
@@ -1078,7 +1083,10 @@
              it->long_timer = NULL;
           }
         if (!it->wd->wasselected)
-          _item_unselect(it);
+          {
+             _item_unhighlight(it);
+             _item_unselect(it);
+          }
         if (dy < 0)
           {
              if (ady > adx)
@@ -1242,7 +1250,11 @@
    it->wd->multitouched = EINA_TRUE;
    it->wd->prev_mx = ev->canvas.x;
    it->wd->prev_my = ev->canvas.y;
-   if (!it->wd->wasselected) _item_unselect(it);
+   if (!it->wd->wasselected)
+     {
+        _item_unhighlight(it);
+        _item_unselect(it);
+     }
    it->wd->wasselected = EINA_FALSE;
    it->wd->longpressed = EINA_FALSE;
    if (it->long_timer)
@@ -1406,7 +1418,10 @@
      {
         it->wd->longpressed = EINA_FALSE;
         if (!it->wd->wasselected)
-          _item_unselect(it);
+          {
+             _item_unhighlight(it);
+             _item_unselect(it);
+          }
         it->wd->wasselected = EINA_FALSE;
         return;
      }
@@ -1428,7 +1443,11 @@
              _item_highlight(it);
              _item_select(it);
           }
-        else _item_unselect(it);
+        else
+          {
+             _item_unhighlight(it);
+             _item_unselect(it);
+          }
      }
    else
      {
@@ -1437,7 +1456,11 @@
              Widget_Data *wd = it->wd;
              if (wd)
                {
-                  while (wd->selected) _item_unselect(wd->selected->data);
+                  while (wd->selected)
+                    {
+                       _item_unhighlight(wd->selected->data);
+                       _item_unselect(wd->selected->data);
+                    }
                }
           }
         else
@@ -1446,7 +1469,11 @@
              Elm_Genlist_Item *it2;
 
              EINA_LIST_FOREACH_SAFE(it->wd->selected, l, l_next, it2)
-               if (it2 != it) _item_unselect(it2);
+                if (it2 != it)
+                  {
+                     _item_unhighlight(it2);
+                     _item_unselect(it2);
+                  }
              //_item_highlight(it);
              //_item_select(it);
           }
@@ -3851,13 +3878,19 @@
         if (!wd->multi)
           {
              while (wd->selected)
-               _item_unselect(wd->selected->data);
+               {
+                  _item_unhighlight(wd->selected->data);
+                  _item_unselect(wd->selected->data);
+               }
           }
         _item_highlight(it);
         _item_select(it);
      }
    else
-     _item_unselect(it);
+     {
+        _item_unhighlight(it);
+        _item_unselect(it);
+     }
 }
 
 /**

Log:
Elementary calendar: Fixed warnings from -Wshadow option.
  

Author:       seoz
Date:         2011-05-24 05:57:44 -0700 (Tue, 24 May 2011)
New Revision: 59653
Trac:         http://trac.enlightenment.org/e/changeset/59653

Modified:
  trunk/elementary/src/lib/elm_calendar.c 

Modified: trunk/elementary/src/lib/elm_calendar.c
===================================================================
--- trunk/elementary/src/lib/elm_calendar.c	2011-05-24 11:41:00 UTC (rev 59652)
+++ trunk/elementary/src/lib/elm_calendar.c	2011-05-24 12:57:44 UTC (rev 59653)
@@ -42,7 +42,7 @@
    int year_min, year_max, spin_speed;
    int today_it, selected_it, first_day_it;
    Ecore_Timer *spin, *update_timer;
-   char * (*format_func) (struct tm *stime);
+   char * (*format_func) (struct tm *selected_time);
    const char *weekdays[7];
    struct tm current_time, selected_time;
    Day_Color day_color[42]; // EINA_DEPRECATED
@@ -120,12 +120,12 @@
 }
 
 static inline int
-_maxdays_get(struct tm *time)
+_maxdays_get(struct tm *selected_time)
 {
    int month, year;
 
-   month = time->tm_mon;
-   year = time->tm_year + 1900;
+   month = selected_time->tm_mon;
+   year = selected_time->tm_year + 1900;
 
    return _days_in_month[((!(year % 4)) &&
                           ((!(year % 400)) ||
@@ -168,10 +168,10 @@
 }
 
 static char *
-_format_month_year(struct tm *stime)
+_format_month_year(struct tm *selected_time)
 {
    char buf[32];
-   if (!strftime(buf, sizeof(buf), "%B %Y", stime)) return NULL;
+   if (!strftime(buf, sizeof(buf), "%B %Y", selected_time)) return NULL;
    return strdup(buf);
 }
 
@@ -337,21 +337,21 @@
    EINA_LIST_FOREACH(wd->marks, l, mark)
      {
         struct tm *mtime = &mark->mark_time;
-        int mon = wd->selected_time.tm_mon;
+        int month = wd->selected_time.tm_mon;
         int year = wd->selected_time.tm_year;
         int mday_it = mtime->tm_mday + wd->first_day_it - 1;
 
         switch (mark->repeat)
           {
            case ELM_CALENDAR_UNIQUE:
-              if ((mtime->tm_mon == mon) && (mtime->tm_year == year))
+              if ((mtime->tm_mon == month) && (mtime->tm_year == year))
                 _cit_mark(wd->calendar, mday_it, mark->mark_type);
               break;
            case ELM_CALENDAR_DAILY:
-              if (((mtime->tm_year == year) && (mtime->tm_mon < mon)) ||
+              if (((mtime->tm_year == year) && (mtime->tm_mon < month)) ||
                   (mtime->tm_year < year))
                 day = 1;
-              else if ((mtime->tm_year == year) && (mtime->tm_mon == mon))
+              else if ((mtime->tm_year == year) && (mtime->tm_mon == month))
                 day = mtime->tm_mday;
               else
                 break;
@@ -360,10 +360,10 @@
                           mark->mark_type);
               break;
            case ELM_CALENDAR_WEEKLY:
-              if (((mtime->tm_year == year) && (mtime->tm_mon < mon)) ||
+              if (((mtime->tm_year == year) && (mtime->tm_mon < month)) ||
                   (mtime->tm_year < year))
                 day = 1;
-              else if ((mtime->tm_year == year) && (mtime->tm_mon == mon))
+              else if ((mtime->tm_year == year) && (mtime->tm_mon == month))
                 day = mtime->tm_mday;
               else
                 break;
@@ -374,12 +374,12 @@
               break;
            case ELM_CALENDAR_MONTHLY:
               if (((mtime->tm_year < year) ||
-                   ((mtime->tm_year == year) && (mtime->tm_mon <= mon))) &&
+                   ((mtime->tm_year == year) && (mtime->tm_mon <= month))) &&
                   (mtime->tm_mday <= maxdays))
                 _cit_mark(wd->calendar, mday_it, mark->mark_type);
               break;
            case ELM_CALENDAR_ANNUALLY:
-              if ((mtime->tm_year <= year) && (mtime->tm_mon == mon) &&
+              if ((mtime->tm_year <= year) && (mtime->tm_mon == month) &&
                   (mtime->tm_mday <= maxdays))
                 _cit_mark(wd->calendar, mday_it, mark->mark_type);
               break;
@@ -1076,10 +1076,10 @@
  * Example:
  * @code
  * static char *
- * _format_month_year(struct tm *stime)
+ * _format_month_year(struct tm *selected_time)
  * {
  *    char buf[32];
- *    if (!strftime(buf, sizeof(buf), "%B %Y", stime)) return NULL;
+ *    if (!strftime(buf, sizeof(buf), "%B %Y", selected_time)) return NULL;
  *    return strdup(buf);
  * }
  * elm_calendar_format_function_set(calendar, _format_month_year);
@@ -1092,7 +1092,7 @@
  * @ingroup Calendar
  */
 EAPI void
-elm_calendar_format_function_set(Evas_Object *obj, char * (*format_function) (struct tm *stime))
+elm_calendar_format_function_set(Evas_Object *obj, char * (*format_function) (struct tm *selected_time))
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);

Log:
Elementary genlist: Fixed bug in single selection mode to prevent
  multiple selection. Patch by Hyoyoung Chang <hyoyoung.chang@...>
  
  On Tue, May 24, 2011 at 7:43 PM, Hyoyoung Chang
  <hyoyoung.chang@...> wrote:
  Dear Elementary developers.
  
  I made a oneline patch.
  It's about in single selection mode of elm_genlist.
  In single selection mode, some multi touching can make multi selected items.
  
  It can't easy reproduce at PC environment(like as mouse+keyboard), but if you have multi touching device you can easily reproduce.
  
  Reproduce step is putting two pointing device on genlist.
  1. ?\194?\160 ?\194?\160 ?\194?\160long pressing one pointer.
  2. ?\194?\160 ?\194?\160 ?\194?\160Short press another one pointer.
  3. ?\194?\160 ?\194?\160 ?\194?\160And repeat alternating press two device
  Then you can find multi selected items in single selection mode.
  
  So my approach is if a item is not selection and just only
  highlighted, then make it with _item_unselection()
  

Author:       seoz
Date:         2011-05-24 20:01:51 -0700 (Tue, 24 May 2011)
New Revision: 59659
Trac:         http://trac.enlightenment.org/e/changeset/59659

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-24 21:20:06 UTC (rev 59658)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-25 03:01:51 UTC (rev 59659)
@@ -1379,6 +1379,7 @@
    it->wd->mouse_down = EINA_FALSE;
    if (it->wd->multitouched)
      {
+        if ((!it->wd->multi) && (!it->selected) && (it->highlighted)) _item_unhighlight(it);
         if (it->wd->multi_down) return;
         _multi_touch_gesture_eval(data);
         return;

Log:
Elementary genlist: Fixed warnings and removed unnecessary lines.
  

Author:       seoz
Date:         2011-05-26 18:02:16 -0700 (Thu, 26 May 2011)
New Revision: 59707
Trac:         http://trac.enlightenment.org/e/changeset/59707

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-26 17:11:54 UTC (rev 59706)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-27 01:02:16 UTC (rev 59707)
@@ -3371,8 +3371,6 @@
    return it;
 }
 
-
-
 /**
  * Insert a new item into the sorted genlist object
  *
@@ -3398,12 +3396,6 @@
                                Evas_Smart_Cb                 func,
                                const void                   *func_data)
 {
-
-   Elm_Genlist_Item *search = NULL;
-   Eina_Inlist *s;
-   Eina_Accessor *ea;
-   int ret, min, max, i;
-
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return NULL;

Log:
Elementary lib: Removed trailing whitespaces except for flip.
  

Author:       seoz
Date:         2011-05-29 19:31:21 -0700 (Sun, 29 May 2011)
New Revision: 59796
Trac:         http://trac.enlightenment.org/e/changeset/59796

Modified:
  trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_transit.c trunk/elementary/src/lib/els_box.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-05-30 02:11:21 UTC (rev 59795)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-05-30 02:31:21 UTC (rev 59796)
@@ -937,7 +937,7 @@
 _item_del(Elm_Genlist_Item *it)
 {
    Evas_Object *tob = it->wd->obj;
-   
+
    evas_event_freeze(evas_object_evas_get(tob));
    elm_widget_item_pre_notify_del(it);
    elm_genlist_item_subitems_clear(it);
@@ -1553,7 +1553,7 @@
    Elm_Genlist_Item *it = data;
    if ((it->delete_me) || (!it->realized) || (!it->mode_view)) return;
    char buf[1024];
-   
+
    evas_event_freeze(evas_object_evas_get(obj));
    it->nocache = EINA_FALSE;
    _mode_item_unrealize(it);
@@ -2443,7 +2443,7 @@
    if (!wd) return;
    wd->update_job = NULL;
    num = 0;
-   
+
    evas_event_freeze(evas_object_evas_get(wd->obj));
    EINA_INLIST_FOREACH(wd->blocks, itb)
      {

Modified: trunk/elementary/src/lib/elm_transit.c
===================================================================
--- trunk/elementary/src/lib/elm_transit.c	2011-05-30 02:11:21 UTC (rev 59795)
+++ trunk/elementary/src/lib/elm_transit.c	2011-05-30 02:31:21 UTC (rev 59796)
@@ -603,7 +603,7 @@
    Elm_Obj_Data *obj_data;
    Eina_List * list;
 
-//TODO: Check the remove case of the same objects in this transit. 
+//TODO: Check the remove case of the same objects in this transit.
    obj_data = ELM_NEW(Elm_Obj_Data);
    obj_data->pass_events = evas_object_pass_events_get(obj);
    if (!transit->event_enabled)
@@ -1075,7 +1075,7 @@
  * @note @p chain_transit can not be NULL. Chain transits could be chained to the only one transit.
  *
  * @param transit The transit object.
- * @param chain_transit The chain transit object. This transit will be operated  
+ * @param chain_transit The chain transit object. This transit will be operated
  *        after transit is done.
  *
  * @ingroup Transit

Modified: trunk/elementary/src/lib/els_box.c
===================================================================
--- trunk/elementary/src/lib/els_box.c	2011-05-30 02:11:21 UTC (rev 59795)
+++ trunk/elementary/src/lib/els_box.c	2011-05-30 02:31:21 UTC (rev 59796)
@@ -69,7 +69,7 @@
    evas_object_size_hint_min_get(o, &minw, &minh);
    evas_object_size_hint_align_get(o, &ax, &ay);
    count = eina_list_count(priv->children);
-   
+
    if (w < minw)
      {
         x = x + ((w - minw) * (1.0 - ax));

Log:
Elementary genlist: Fixed event freeze problem with mode item.
  

Author:       seoz
Date:         2011-06-01 04:46:24 -0700 (Wed, 01 Jun 2011)
New Revision: 59864
Trac:         http://trac.enlightenment.org/e/changeset/59864

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-01 10:59:30 UTC (rev 59863)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-01 11:46:24 UTC (rev 59864)
@@ -1554,13 +1554,13 @@
    if ((it->delete_me) || (!it->realized) || (!it->mode_view)) return;
    char buf[1024];
 
-   evas_event_freeze(evas_object_evas_get(obj));
+//   evas_event_freeze(evas_object_evas_get(obj));
    it->nocache = EINA_FALSE;
    _mode_item_unrealize(it);
    snprintf(buf, sizeof(buf), "elm,state,%s,passive,finished", it->wd->mode_type);
    edje_object_signal_callback_del_full(obj, buf, "elm", _mode_finished_signal_cb, it);
-   evas_event_thaw(evas_object_evas_get(obj));
-   evas_event_thaw_eval(evas_object_evas_get(obj));
+//   evas_event_thaw(evas_object_evas_get(obj));
+//   evas_event_thaw_eval(evas_object_evas_get(obj));
 }
 
 static void

Log:
Elementary genlist: Fixed formatting.
  

Author:       seoz
Date:         2011-06-01 22:40:30 -0700 (Wed, 01 Jun 2011)
New Revision: 59887
Trac:         http://trac.enlightenment.org/e/changeset/59887

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-02 05:19:16 UTC (rev 59886)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-02 05:40:30 UTC (rev 59887)
@@ -556,7 +556,7 @@
         else
           y += page_y;
      }
-   else if(((!strcmp(ev->keyname, "Return")) ||
+   else if (((!strcmp(ev->keyname, "Return")) ||
             (!strcmp(ev->keyname, "KP_Enter")) ||
             (!strcmp(ev->keyname, "space")))
            && (!wd->multi) && (wd->selected))
@@ -582,7 +582,7 @@
 _deselect_all_items(Widget_Data *wd)
 {
    if (!wd->selected) return EINA_FALSE;
-   while(wd->selected)
+   while (wd->selected)
      elm_genlist_item_selected_set(wd->selected->data, EINA_FALSE);
 
    return EINA_TRUE;
@@ -2715,7 +2715,7 @@
           }
      }
 done:
-   if(!sd->wd->item_moving_effect_timer) evas_object_smart_changed(obj);
+   if (!sd->wd->item_moving_effect_timer) evas_object_smart_changed(obj);
 }
 
 static void

Log:
Elementary glview: Added 'const' to the obj parameters in elm_xxx_get() APIs.
  

Author:       seoz
Date:         2011-06-03 10:48:45 -0700 (Fri, 03 Jun 2011)
New Revision: 59920
Trac:         http://trac.enlightenment.org/e/changeset/59920

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_glview.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-06-03 17:44:24 UTC (rev 59919)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-06-03 17:48:45 UTC (rev 59920)
@@ -809,8 +809,8 @@
 
    EAPI Evas_Object     *elm_glview_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
    EAPI void             elm_glview_size_set(Evas_Object *obj, Evas_Coord width, Evas_Coord height) EINA_ARG_NONNULL(1);
-   EAPI void             elm_glview_size_get(Evas_Object *obj, Evas_Coord *width, Evas_Coord *height) EINA_ARG_NONNULL(1);
-   EAPI Evas_GL_API     *elm_glview_gl_api_get(Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void             elm_glview_size_get(const Evas_Object *obj, Evas_Coord *width, Evas_Coord *height) EINA_ARG_NONNULL(1);
+   EAPI Evas_GL_API     *elm_glview_gl_api_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool        elm_glview_mode_set(Evas_Object *obj, Elm_GLView_Mode mode) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool        elm_glview_scale_policy_set(Evas_Object *obj, Elm_GLView_Resize_Policy policy) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool        elm_glview_render_policy_set(Evas_Object *obj, Elm_GLView_Render_Policy policy) EINA_ARG_NONNULL(1);

Modified: trunk/elementary/src/lib/elm_glview.c
===================================================================
--- trunk/elementary/src/lib/elm_glview.c	2011-06-03 17:44:24 UTC (rev 59919)
+++ trunk/elementary/src/lib/elm_glview.c	2011-06-03 17:48:45 UTC (rev 59920)
@@ -273,7 +273,7 @@
  * @ingroup GLView
  */
 EAPI Evas_GL_API *
-elm_glview_gl_api_get(Evas_Object *obj)
+elm_glview_gl_api_get(const Evas_Object *obj)
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
@@ -433,7 +433,7 @@
  * @ingroup GLView
  */
 EAPI void
-elm_glview_size_get(Evas_Object *obj, int *width, int *height)
+elm_glview_size_get(const Evas_Object *obj, int *width, int *height)
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);

Log:
Elementary glview: Fixed formatting.
  
  Followed E coding style. Refer http://trac.enlightenment.org/e/wiki/ECoding. I have no idea about struct initialization though.
  1. Fixed indentation.
  2. Removed unnecessary lines.
  3. Etc...
  

Author:       seoz
Date:         2011-06-03 10:58:08 -0700 (Fri, 03 Jun 2011)
New Revision: 59921
Trac:         http://trac.enlightenment.org/e/changeset/59921

Modified:
  trunk/elementary/src/lib/elm_glview.c 

Modified: trunk/elementary/src/lib/elm_glview.c
===================================================================
--- trunk/elementary/src/lib/elm_glview.c	2011-06-03 17:48:45 UTC (rev 59920)
+++ trunk/elementary/src/lib/elm_glview.c	2011-06-03 17:58:08 UTC (rev 59921)
@@ -127,7 +127,6 @@
      }
 }
 
-
 static Eina_Bool
 _render_cb(void *obj)
 {
@@ -146,7 +145,7 @@
 
    // Depending on the policy return true or false
    if (wd->render_policy == ELM_GLVIEW_RENDER_POLICY_ON_DEMAND)
-      return EINA_TRUE;
+     return EINA_TRUE;
    else if (wd->render_policy == ELM_GLVIEW_RENDER_POLICY_ALWAYS)
      {
         // Return false so it only runs once
@@ -170,30 +169,27 @@
    switch (wd->render_policy)
      {
       case ELM_GLVIEW_RENDER_POLICY_ON_DEMAND:
-        // Delete idle_enterer if it for some reason is around
-        if (wd->render_idle_enterer)
-          {
-             ecore_idle_enterer_del(wd->render_idle_enterer);
-             wd->render_idle_enterer = NULL;
-          }
+         // Delete idle_enterer if it for some reason is around
+         if (wd->render_idle_enterer)
+           {
+              ecore_idle_enterer_del(wd->render_idle_enterer);
+              wd->render_idle_enterer = NULL;
+           }
 
-        // Set pixel getter callback
-        evas_object_image_pixels_get_callback_set
-           (wd->glview_image, (Evas_Object_Image_Pixels_Get_Cb)_render_cb, obj);
-        break;
+         // Set pixel getter callback
+         evas_object_image_pixels_get_callback_set
+            (wd->glview_image, (Evas_Object_Image_Pixels_Get_Cb)_render_cb, obj);
+         break;
       case ELM_GLVIEW_RENDER_POLICY_ALWAYS:
-
-        // Unset the pixel getter callback if set already
-        evas_object_image_pixels_get_callback_set(wd->glview_image, NULL, NULL);
-        break;
+         // Unset the pixel getter callback if set already
+         evas_object_image_pixels_get_callback_set(wd->glview_image, NULL, NULL);
+         break;
       default:
-        ERR("Invalid Render Policy.\n");
-        return;
+         ERR("Invalid Render Policy.\n");
+         return;
      }
 }
 
-
-
 /**
  * Add a new glview to the parent
  *
@@ -259,9 +255,7 @@
              return NULL;
           }
      }
-
    return obj;
-
 }
 
 /**
@@ -277,7 +271,6 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Widget_Data *wd = elm_widget_data_get(obj);
-
    if (!wd) return NULL;
 
    return evas_gl_api_get(wd->evasgl);
@@ -305,19 +298,19 @@
 
    // Set the configs
    if (mode & ELM_GLVIEW_ALPHA)
-      cfg.color_format = EVAS_GL_RGBA_8;
+     cfg.color_format = EVAS_GL_RGBA_8;
 
    if (mode & ELM_GLVIEW_DEPTH)
-      cfg.depth_bits = EVAS_GL_DEPTH_BIT_24;
+     cfg.depth_bits = EVAS_GL_DEPTH_BIT_24;
 
    if (mode & ELM_GLVIEW_STENCIL)
-      cfg.stencil_bits = EVAS_GL_STENCIL_BIT_8;
+     cfg.stencil_bits = EVAS_GL_STENCIL_BIT_8;
 
    // Check for Alpha Channel and enable it
    if (mode & ELM_GLVIEW_ALPHA)
-      evas_object_image_alpha_set(wd->glview_image, EINA_TRUE);
+     evas_object_image_alpha_set(wd->glview_image, EINA_TRUE);
    else
-      evas_object_image_alpha_set(wd->glview_image, EINA_FALSE);
+     evas_object_image_alpha_set(wd->glview_image, EINA_FALSE);
 
    wd->mode   = mode;
    wd->config = cfg;
@@ -352,11 +345,11 @@
      {
       case ELM_GLVIEW_RESIZE_POLICY_RECREATE:
       case ELM_GLVIEW_RESIZE_POLICY_SCALE:
-        wd->scale_policy = policy;
-        return EINA_TRUE;
+         wd->scale_policy = policy;
+         return EINA_TRUE;
       default:
-        ERR("Invalid Scale Policy.\n");
-        return EINA_FALSE;
+         ERR("Invalid Scale Policy.\n");
+         return EINA_FALSE;
      }
    _glview_update_surface(obj);
    elm_glview_changed_set(obj);
@@ -459,11 +452,9 @@
    if (!wd) return;
 
    wd->render_func = func;
-
    _set_render_policy_callback(obj);
 }
 
-
 /**
  * Notifies that there has been changes in the GLView.
  *
@@ -476,18 +467,14 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
-
    if (!wd) return;
 
    evas_object_image_pixels_dirty_set(wd->glview_image, EINA_TRUE);
-
    if (wd->render_policy == ELM_GLVIEW_RENDER_POLICY_ALWAYS)
      {
         if (!wd->render_idle_enterer)
-
-           wd->render_idle_enterer = ecore_idle_enterer_before_add((Ecore_Task_Cb)_render_cb, obj);
+          wd->render_idle_enterer = ecore_idle_enterer_before_add((Ecore_Task_Cb)_render_cb, obj);
      }
-
 }
 
 /* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-2f0^-2{2(0W1st0 :*/

Log:
Elementary gengrid: Use Evas_Smart_Cb_Description for smart callbacks.
  

Author:       seoz
Date:         2011-06-06 18:01:29 -0700 (Mon, 06 Jun 2011)
New Revision: 60014
Trac:         http://trac.enlightenment.org/e/changeset/60014

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-06-07 00:46:22 UTC (rev 60013)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-06-07 01:01:29 UTC (rev 60014)
@@ -268,6 +268,7 @@
 static const char SIG_SCROLL[] = "scroll";
 static const char SIG_SCROLL_DRAG_START[] = "scroll,drag,start";
 static const char SIG_SCROLL_DRAG_STOP[] = "scroll,drag,stop";
+static const char SIG_MOVED[] = "moved";
 
 static const Evas_Smart_Cb_Description _signals[] = {
        {SIG_CLICKED_DOUBLE, ""},
@@ -285,6 +286,7 @@
        {SIG_SCROLL, ""},
        {SIG_SCROLL_DRAG_START, ""},
        {SIG_SCROLL_DRAG_STOP, ""},
+       {SIG_MOVED, ""},
        {NULL, NULL}
 };
 
@@ -956,7 +958,7 @@
         if (item->wd->calc_job) ecore_job_del(item->wd->calc_job);
           item->wd->calc_job = ecore_job_add(_calc_job, item->wd);
 
-        evas_object_smart_callback_call(item->wd->self, "moved", item->wd->reorder_item);
+        evas_object_smart_callback_call(item->wd->self, SIG_MOVED, item->wd->reorder_item);
         item->wd->reorder_item = NULL;
         elm_smart_scroller_hold_set(item->wd->scr, EINA_FALSE);
         elm_smart_scroller_bounce_allow_set(item->wd->scr, item->wd->h_bounce, item->wd->v_bounce);

Log:
Elementary pager: Fixed warnings.
  

Author:       seoz
Date:         2011-06-08 03:38:36 -0700 (Wed, 08 Jun 2011)
New Revision: 60084
Trac:         http://trac.enlightenment.org/e/changeset/60084

Modified:
  trunk/elementary/src/lib/elm_pager.c 

Modified: trunk/elementary/src/lib/elm_pager.c
===================================================================
--- trunk/elementary/src/lib/elm_pager.c	2011-06-08 08:57:26 UTC (rev 60083)
+++ trunk/elementary/src/lib/elm_pager.c	2011-06-08 10:38:36 UTC (rev 60084)
@@ -108,7 +108,7 @@
    Widget_Data *wd = elm_widget_data_get(obj);
    Item *it;
    Eina_List *l;
-   if (!wd) return;
+   if (!wd) return NULL;
 
    EINA_LIST_FOREACH(wd->stack, l, it)
      {
@@ -232,7 +232,7 @@
 }
 
 static void
-_content_del(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info)
+_content_del(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(data);
    Eina_List *l;

Log:
Elementary genlist: Removed internal routine in _item_block_realize().
  
  Genlist items are realized separately. So block realize doesn't mean
  realizing all items in the block. This function and
  _item_block_unrealize() will be refactored later again.
  

Author:       seoz
Date:         2011-06-08 03:48:20 -0700 (Wed, 08 Jun 2011)
New Revision: 60085
Trac:         http://trac.enlightenment.org/e/changeset/60085

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-08 10:38:36 UTC (rev 60084)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-08 10:48:20 UTC (rev 60085)
@@ -2219,25 +2219,11 @@
 }
 
 static void
-_item_block_realize(Item_Block *itb,
-                    int         in,
-                    int         full)
+_item_block_realize(Item_Block *itb)
 {
-   const Eina_List *l;
-   Elm_Genlist_Item *it;
-
    if (itb->realized) return;
-   evas_event_freeze(evas_object_evas_get(itb->wd->obj));
-   EINA_LIST_FOREACH(itb->items, l, it)
-     {
-        if (it->delete_me) continue;
-        if (full) _item_realize(it, in, EINA_FALSE);
-        in++;
-     }
    itb->realized = EINA_TRUE;
    itb->want_unrealize = EINA_FALSE;
-   evas_event_thaw(evas_object_evas_get(itb->wd->obj));
-   evas_event_thaw_eval(evas_object_evas_get(itb->wd->obj));
 }
 
 static void
@@ -2871,7 +2857,7 @@
                                 cvx, cvy, cvw, cvh))
           {
              if ((!itb->realized) || (itb->changed))
-               _item_block_realize(itb, in, 0);
+               _item_block_realize(itb);
              _item_block_position(itb, in);
           }
         else

Log:
Elementary genlist: Refactoring.
  
  1. Changed int for 0/1 to Eina_Bool.
  2. Removed unnecessary variable. Don't need to assign macro to
  variable. Just use macro.
  3. Fixed indentation.
  

Author:       seoz
Date:         2011-06-08 03:58:00 -0700 (Wed, 08 Jun 2011)
New Revision: 60086
Trac:         http://trac.enlightenment.org/e/changeset/60086

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-08 10:48:20 UTC (rev 60085)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-08 10:58:00 UTC (rev 60086)
@@ -2170,7 +2170,7 @@
 static Eina_Bool
 _item_block_recalc(Item_Block *itb,
                    int         in,
-                   int         qadd)
+                   Eina_Bool   qadd)
 {
    const Eina_List *l;
    Elm_Genlist_Item *it;
@@ -2304,13 +2304,12 @@
 {
    Elm_Genlist_Item *it = data;
    Eina_Bool down = EINA_FALSE;
-   double time, t;
+   double t;
    int y, dy = it->h / 10 * _elm_config->scale, diff;
-   time = REORDER_EFFECT_TIME;
 
    t = ((0.0 > (t = ecore_loop_time_get()-it->wd->start_time)) ? 0.0 : t);
 
-   if (t <= time) y = (1 * sin((t / time) * (M_PI / 2)) * dy);
+   if (t <= REORDER_EFFECT_TIME) y = (1 * sin((t / REORDER_EFFECT_TIME) * (M_PI / 2)) * dy);
    else y = dy;
 
    diff = abs(it->old_scrl_y - it->scrl_y);
@@ -2528,7 +2527,7 @@
                   itb->must_recalc = EINA_FALSE;
                }
              if (itb->realized) _item_block_unrealize(itb);
-             showme = _item_block_recalc(itb, in, 0);
+             showme = _item_block_recalc(itb, in, EINA_FALSE);
              chb = itb;
           }
         itb->y = y;
@@ -2670,7 +2669,7 @@
           {
              position = EINA_TRUE;
              itb->changed = EINA_TRUE;
-             _item_block_recalc(itb, num0, 0);
+             _item_block_recalc(itb, num0, EINA_FALSE);
              _item_block_position(itb, num0);
           }
      }
@@ -3384,7 +3383,7 @@
         t = ecore_time_get();
         if (it->block->changed)
           {
-             showme = _item_block_recalc(it->block, it->block->num, 1);
+             showme = _item_block_recalc(it->block, it->block->num, EINA_TRUE);
              it->block->changed = 0;
           }
         if (showme) it->block->showme = EINA_TRUE;
@@ -3457,7 +3456,7 @@
 //   evas_event_thaw(evas_object_evas_get(wd->obj));
 //   evas_event_thaw_eval(evas_object_evas_get(wd->obj));
    if (!wd->queue_idle_enterer)
-      wd->queue_idle_enterer = ecore_idle_enterer_add(_item_idle_enterer, wd);
+     wd->queue_idle_enterer = ecore_idle_enterer_add(_item_idle_enterer, wd);
 }
 
 static int

Log:
Elementary genlist: Fixed "Genlist 4" test case.
  
  Using evas_event_freeze/thaw in _item_realize, _item_block_recalc and _queue_process breaks "Genlist 4" test case which is using textblock.
  We need to re-examine evas_event_freeze/thaw. They are so tricky :(
  

Author:       seoz
Date:         2011-06-08 09:56:50 -0700 (Wed, 08 Jun 2011)
New Revision: 60092
Trac:         http://trac.enlightenment.org/e/changeset/60092

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-08 16:33:21 UTC (rev 60091)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-08 16:56:50 UTC (rev 60092)
@@ -1935,7 +1935,7 @@
    Item_Cache *itc = NULL;
 
    if (it->delete_me) return;
-   evas_event_freeze(evas_object_evas_get(it->wd->obj));
+   //evas_event_freeze(evas_object_evas_get(it->wd->obj));
    if (it->realized)
      {
         if (it->order_num_in != in)
@@ -1944,8 +1944,8 @@
              _elm_genlist_item_odd_even_update(it);
              _elm_genlist_item_state_update(it, NULL);
           }
-        evas_event_thaw(evas_object_evas_get(it->wd->obj));
-        evas_event_thaw_eval(evas_object_evas_get(it->wd->obj));
+        //evas_event_thaw(evas_object_evas_get(it->wd->obj));
+        //evas_event_thaw_eval(evas_object_evas_get(it->wd->obj));
         return;
      }
    it->order_num_in = in;
@@ -2112,8 +2112,8 @@
    it->want_unrealize = EINA_FALSE;
 
    if (itc) _item_cache_free(itc);
-   evas_event_thaw(evas_object_evas_get(it->wd->obj));
-   evas_event_thaw_eval(evas_object_evas_get(it->wd->obj));
+   //evas_event_thaw(evas_object_evas_get(it->wd->obj));
+   //evas_event_thaw_eval(evas_object_evas_get(it->wd->obj));
    if (!calc)
      evas_object_smart_callback_call(it->base.widget, SIG_REALIZED, it);
 }
@@ -2178,7 +2178,7 @@
    Eina_Bool showme = EINA_FALSE, changed = EINA_FALSE;
    Evas_Coord y = 0;
 
-   evas_event_freeze(evas_object_evas_get(itb->wd->obj));
+   //evas_event_freeze(evas_object_evas_get(itb->wd->obj));
    itb->num = in;
    EINA_LIST_FOREACH(itb->items, l, it)
      {
@@ -2213,8 +2213,8 @@
    itb->minw = minw;
    itb->minh = minh;
    itb->changed = EINA_FALSE;
-   evas_event_thaw(evas_object_evas_get(itb->wd->obj));
-   evas_event_thaw_eval(evas_object_evas_get(itb->wd->obj));
+   //evas_event_thaw(evas_object_evas_get(itb->wd->obj));
+   //evas_event_thaw_eval(evas_object_evas_get(itb->wd->obj));
    return showme;
 }
 
@@ -3371,7 +3371,7 @@
    double t0, t;
 
    t0 = ecore_time_get();
-   evas_event_freeze(evas_object_evas_get(wd->obj));
+   //evas_event_freeze(evas_object_evas_get(wd->obj));
    for (n = 0; (wd->queue) && (n < 128); n++)
      {
         Elm_Genlist_Item *it;
@@ -3392,8 +3392,8 @@
              if ((t - t0) > (ecore_animator_frametime_get())) break;
           }
      }
-   evas_event_thaw(evas_object_evas_get(wd->obj));
-   evas_event_thaw_eval(evas_object_evas_get(wd->obj));
+   //evas_event_thaw(evas_object_evas_get(wd->obj));
+   //evas_event_thaw_eval(evas_object_evas_get(wd->obj));
    return n;
 }

Log:
Elementary genlist: Indentation fix for reorder patch.
  

Author:       seoz
Date:         2011-06-08 19:54:04 -0700 (Wed, 08 Jun 2011)
New Revision: 60110
Trac:         http://trac.enlightenment.org/e/changeset/60110

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-09 02:45:59 UTC (rev 60109)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-09 02:54:04 UTC (rev 60110)
@@ -2415,18 +2415,18 @@
                               }
                          }
                        if (!it->move_effect_enabled)
-                          {
-                             {
-                                if (it->mode_view)
-                                  _item_position(it, it->mode_view, it->scrl_x,
-                                                 it->scrl_y);
-                                else
-                                  _item_position(it, it->base.view, it->scrl_x,
-                                                 it->scrl_y);
-                             }
-                           it->old_scrl_x = it->scrl_x;
-                           it->old_scrl_y = it->scrl_y;
-                          }
+                         {
+                              {
+                                 if (it->mode_view)
+                                   _item_position(it, it->mode_view, it->scrl_x,
+                                                  it->scrl_y);
+                                 else
+                                   _item_position(it, it->base.view, it->scrl_x,
+                                                  it->scrl_y);
+                              }
+                            it->old_scrl_x = it->scrl_x;
+                            it->old_scrl_y = it->scrl_y;
+                         }
                     }
                   else
                     {

Log:
Elementary label: Fixed warnings.
  

Author:       seoz
Date:         2011-06-09 08:39:58 -0700 (Thu, 09 Jun 2011)
New Revision: 60137
Trac:         http://trac.enlightenment.org/e/changeset/60137

Modified:
  trunk/elementary/src/lib/elm_label.c 

Modified: trunk/elementary/src/lib/elm_label.c
===================================================================
--- trunk/elementary/src/lib/elm_label.c	2011-06-09 15:32:08 UTC (rev 60136)
+++ trunk/elementary/src/lib/elm_label.c	2011-06-09 15:39:58 UTC (rev 60137)
@@ -375,7 +375,7 @@
      {
         const Evas_Object *tb;
         char *_kvalue;
-        double ellipsis;
+        double ellipsis = 0.0;
         Eina_Bool found_key = EINA_FALSE;
         if (_get_value_in_key_string(wd->format, "ellipsis", &_kvalue) == 0)
           {

Log:
Elm segment_control: Fixed shadow declaration warnings.
  

Author:       seoz
Date:         2011-06-09 22:12:28 -0700 (Thu, 09 Jun 2011)
New Revision: 60166
Trac:         http://trac.enlightenment.org/e/changeset/60166

Modified:
  trunk/elementary/src/lib/elm_segment_control.c 

Modified: trunk/elementary/src/lib/elm_segment_control.c
===================================================================
--- trunk/elementary/src/lib/elm_segment_control.c	2011-06-10 05:07:21 UTC (rev 60165)
+++ trunk/elementary/src/lib/elm_segment_control.c	2011-06-10 05:12:28 UTC (rev 60166)
@@ -358,7 +358,7 @@
    Eina_List *l;
    Elm_Segment_Item *it;
    Eina_Bool rtl;
-   int index = 0;
+   int idx = 0;
 
    _position_items(wd);
 
@@ -389,10 +389,10 @@
    rtl = elm_widget_mirrored_get(wd->obj);
    EINA_LIST_FOREACH(wd->seg_items, l, it)
      {
-        it->seg_index = index;
+        it->seg_index = idx;
 
         //Set the segment type
-        if (index == 0)
+        if (idx == 0)
           {
              if (rtl)
                edje_object_signal_emit(it->base.view,
@@ -401,7 +401,7 @@
                edje_object_signal_emit(it->base.view,
                                        "elm,type,segment,left", "elm");
           }
-        else if (index == (wd->item_count - 1))
+        else if (idx == (wd->item_count - 1))
           {
              if (rtl)
                edje_object_signal_emit(it->base.view,
@@ -426,12 +426,12 @@
           edje_object_signal_emit(it->base.view, "elm,state,disabled", "elm");
 
         _swallow_item_objects(it);
-        index++;
+        idx++;
      }
 }
 
 static Elm_Segment_Item *
-_item_find(const Evas_Object *obj, int index)
+_item_find(const Evas_Object *obj, int idx)
 {
    Widget_Data *wd;
    Elm_Segment_Item *it;
@@ -439,7 +439,7 @@
    wd = elm_widget_data_get(obj);
    if (!wd) return NULL;
 
-   it = eina_list_nth(wd->seg_items, index);
+   it = eina_list_nth(wd->seg_items, idx);
    return it;
 }
 
@@ -577,7 +577,7 @@
  */
 EAPI Elm_Segment_Item *
 elm_segment_control_item_insert_at(Evas_Object *obj, Evas_Object *icon,
-                                   const char *label, int index)
+                                   const char *label, int idx)
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Elm_Segment_Item *it, *it_rel;
@@ -585,12 +585,12 @@
 
    wd = elm_widget_data_get(obj);
    if (!wd) return NULL;
-   if (index < 0) index = 0;
+   if (idx < 0) idx = 0;
 
    it = _item_new(obj, icon, label);
    if (!it) return NULL;
 
-   it_rel = _item_find(obj, index);
+   it_rel = _item_find(obj, idx);
    if (it_rel)
      wd->seg_items = eina_list_prepend_relative(wd->seg_items, it, it_rel);
    else
@@ -628,7 +628,7 @@
  * @ingroup SegmentControl
  */
 EAPI void
-elm_segment_control_item_del_at(Evas_Object *obj, int index)
+elm_segment_control_item_del_at(Evas_Object *obj, int idx)
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Elm_Segment_Item *it;
@@ -637,7 +637,7 @@
    wd = elm_widget_data_get(obj);
    if (!wd) return;
 
-   it = _item_find(obj, index);
+   it = _item_find(obj, idx);
    if (!it) return;
    _item_free(it);
    _update_list(wd);
@@ -652,12 +652,12 @@
  * @ingroup SegmentControl
  */
 EAPI const char*
-elm_segment_control_item_label_get(const Evas_Object *obj, int index)
+elm_segment_control_item_label_get(const Evas_Object *obj, int idx)
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Elm_Segment_Item *it;
 
-   it = _item_find(obj, index);
+   it = _item_find(obj, idx);
    if (it) return it->label;
 
    return NULL;
@@ -698,12 +698,12 @@
  * @ingroup SegmentControl
  */
 EAPI Evas_Object *
-elm_segment_control_item_icon_get(const Evas_Object *obj, int index)
+elm_segment_control_item_icon_get(const Evas_Object *obj, int idx)
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Elm_Segment_Item *it;
 
-   it = _item_find(obj, index);
+   it = _item_find(obj, idx);
    if (it) return it->icon;
 
    return NULL;
@@ -802,7 +802,7 @@
  * @ingroup SegmentControl
  */
 EAPI void
-elm_segment_control_item_selected_set(Elm_Segment_Item *it, Eina_Bool select)
+elm_segment_control_item_selected_set(Elm_Segment_Item *it, Eina_Bool selected)
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
    Widget_Data *wd;
@@ -813,12 +813,12 @@
    if (it == wd->selected_item)
      {
         //already in selected state.
-        if (select) return;
+        if (selected) return;
 
         //unselect case
         _segment_off(it);
      }
-   else if (select)
+   else if (selected)
      _segment_on(it);
 
    return;
@@ -833,12 +833,12 @@
  * @ingroup SegmentControl
  */
 EAPI Elm_Segment_Item *
-elm_segment_control_item_get(const Evas_Object *obj, int index)
+elm_segment_control_item_get(const Evas_Object *obj, int idx)
 {
    ELM_CHECK_WIDTYPE(obj, widtype) NULL;
    Elm_Segment_Item *it;
 
-   it = _item_find(obj, index);
+   it = _item_find(obj, idx);
 
    return it;
 }

Log:
Elm win: Added more docs.
  

Author:       seoz
Date:         2011-06-10 00:35:07 -0700 (Fri, 10 Jun 2011)
New Revision: 60181
Trac:         http://trac.enlightenment.org/e/changeset/60181

Modified:
  trunk/elementary/src/lib/elm_win.c 

Modified: trunk/elementary/src/lib/elm_win.c
===================================================================
--- trunk/elementary/src/lib/elm_win.c	2011-06-10 07:28:30 UTC (rev 60180)
+++ trunk/elementary/src/lib/elm_win.c	2011-06-10 07:35:07 UTC (rev 60181)
@@ -1580,7 +1580,8 @@
 }
 
 /**
- * Add @p subobj as a resize object of window @p obj.
+ * Add @p subobj as a resize object of window @p obj. Note, do not move and
+ * resize window and sub object at the same time. It will cause problem.
  *
  * @param obj The window object
  * @param subobj The resize object to add

Log:
Elm scroller: Fixed 'may be used uninitialized' warnings.
  

Author:       seoz
Date:         2011-06-11 09:43:20 -0700 (Sat, 11 Jun 2011)
New Revision: 60231
Trac:         http://trac.enlightenment.org/e/changeset/60231

Modified:
  trunk/elementary/src/lib/els_scroller.c 

Modified: trunk/elementary/src/lib/els_scroller.c
===================================================================
--- trunk/elementary/src/lib/els_scroller.c	2011-06-11 16:41:35 UTC (rev 60230)
+++ trunk/elementary/src/lib/els_scroller.c	2011-06-11 16:43:20 UTC (rev 60231)
@@ -1673,7 +1673,7 @@
    if (_elm_config->scroll_smooth_amount > 0.0)
      {
         int i, count = 0;
-        Evas_Coord basex, basey, x, y;
+        Evas_Coord basex = 0, basey = 0, x, y;
         double dt, t, tdiff, tnow, twin;
         struct {
            Evas_Coord x, y, dx, dy;

Log:
elm achorblock: Fixed doxygen.
  

Author:       seoz
Date:         2011-06-13 09:28:11 -0700 (Mon, 13 Jun 2011)
New Revision: 60276
Trac:         http://trac.enlightenment.org/e/changeset/60276

Modified:
  trunk/elementary/src/lib/elc_anchorblock.c 

Modified: trunk/elementary/src/lib/elc_anchorblock.c
===================================================================
--- trunk/elementary/src/lib/elc_anchorblock.c	2011-06-13 16:04:55 UTC (rev 60275)
+++ trunk/elementary/src/lib/elc_anchorblock.c	2011-06-13 16:28:11 UTC (rev 60276)
@@ -4,7 +4,7 @@
 /**
  * @defgroup Anchorblock Anchorblock
  *
- * Anchorblock is for displaying tet that contains markup with anchors like:
+ * Anchorblock is for displaying text that contains markup with anchors like:
  * \<a href=1234\>something\</\> in it. These will be drawn differently and will
  * be able to be clicked on by the user to display a popup. This popup then
  * is intended to contain extra options such as "call", "add to contacts",

Log:
elm genlist, photocam, map: Fixed wrong signal emitting.
  

Author:       seoz
Date:         2011-06-14 22:30:23 -0700 (Tue, 14 Jun 2011)
New Revision: 60325
Trac:         http://trac.enlightenment.org/e/changeset/60325

Modified:
  trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_map.c trunk/elementary/src/lib/elm_photocam.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-15 05:21:26 UTC (rev 60324)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-15 05:30:23 UTC (rev 60325)
@@ -692,14 +692,14 @@
    if (!wd) return;
    if (elm_widget_focus_get(obj))
      {
-        edje_object_signal_emit(wd->obj, "elm,action,focus", "elm");
+        elm_object_signal_emit(wd->obj, "elm,action,focus", "elm");
         evas_object_focus_set(wd->obj, EINA_TRUE);
         if ((wd->selected) && (!wd->last_selected_item))
           wd->last_selected_item = eina_list_data_get(wd->selected);
      }
    else
      {
-        edje_object_signal_emit(wd->obj, "elm,action,unfocus", "elm");
+        elm_object_signal_emit(wd->obj, "elm,action,unfocus", "elm");
         evas_object_focus_set(wd->obj, EINA_FALSE);
      }
 }

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-06-15 05:21:26 UTC (rev 60324)
+++ trunk/elementary/src/lib/elm_map.c	2011-06-15 05:30:23 UTC (rev 60325)
@@ -2266,12 +2266,12 @@
    if (!wd) return;
    if (elm_widget_focus_get(obj))
      {
-        edje_object_signal_emit(wd->obj, "elm,action,focus", "elm");
+        edje_object_signal_emit(elm_smart_scroller_edje_object_get(wd->scr), "elm,action,focus", "elm");
         evas_object_focus_set(wd->obj, EINA_TRUE);
      }
    else
      {
-        edje_object_signal_emit(wd->obj, "elm,action,unfocus", "elm");
+        edje_object_signal_emit(elm_smart_scroller_edje_object_get(wd->scr), "elm,action,unfocus", "elm");
         evas_object_focus_set(wd->obj, EINA_FALSE);
      }
 }

Modified: trunk/elementary/src/lib/elm_photocam.c
===================================================================
--- trunk/elementary/src/lib/elm_photocam.c	2011-06-15 05:21:26 UTC (rev 60324)
+++ trunk/elementary/src/lib/elm_photocam.c	2011-06-15 05:30:23 UTC (rev 60325)
@@ -731,12 +731,12 @@
    if (!wd) return;
    if (elm_widget_focus_get(obj))
      {
-        edje_object_signal_emit(wd->obj, "elm,action,focus", "elm");
+        edje_object_signal_emit(elm_smart_scroller_edje_object_get(wd->scr), "elm,action,focus", "elm");
         evas_object_focus_set(wd->obj, EINA_TRUE);
      }
    else
      {
-        edje_object_signal_emit(wd->obj, "elm,action,unfocus", "elm");
+        edje_object_signal_emit(elm_smart_scroller_edje_object_get(wd->scr), "elm,action,unfocus", "elm");
         evas_object_focus_set(wd->obj, EINA_FALSE);
      }
 }

Log:
elm Elementary.h.in: Fixed documentation.
  

Author:       seoz
Date:         2011-06-15 17:59:22 -0700 (Wed, 15 Jun 2011)
New Revision: 60368
Trac:         http://trac.enlightenment.org/e/changeset/60368

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-06-15 22:10:35 UTC (rev 60367)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-06-16 00:59:22 UTC (rev 60368)
@@ -1940,7 +1940,7 @@
     * @until object_show
     * @note The greyed out area is a @ref Styles "style".
     *
-    * We are almost done, this next one is just a actionslider with all
+    * We are almost done, this next one is just an actionslider with all
     * positions magnetized and having every possible label:
     * @skipline actionslider_add
     * @skipline indicator_pos_set

Log:
elm notify: Removed 'unused parameter' warngin.
  

Author:       seoz
Date:         2011-06-19 18:19:51 -0700 (Sun, 19 Jun 2011)
New Revision: 60497
Trac:         http://trac.enlightenment.org/e/changeset/60497

Modified:
  trunk/elementary/src/lib/elm_notify.c 

Modified: trunk/elementary/src/lib/elm_notify.c
===================================================================
--- trunk/elementary/src/lib/elm_notify.c	2011-06-19 20:08:24 UTC (rev 60496)
+++ trunk/elementary/src/lib/elm_notify.c	2011-06-20 01:19:51 UTC (rev 60497)
@@ -396,7 +396,7 @@
 }
 
 static void
-_parent_del(void *data,  Evas *e __UNUSED__, Evas_Object *obj, void *event_info __UNUSED__)
+_parent_del(void *data,  Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(data);
    if (!wd) return;

Log:
elm genlist: Fixed indentation.
  

Author:       seoz
Date:         2011-06-23 02:51:03 -0700 (Thu, 23 Jun 2011)
New Revision: 60626
Trac:         http://trac.enlightenment.org/e/changeset/60626

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-23 08:52:51 UTC (rev 60625)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-23 09:51:03 UTC (rev 60626)
@@ -2285,7 +2285,7 @@
         it->block->reorder_offset = it->wd->reorder_it->h;
      }
    else
-      it->block->reorder_offset = 0;
+     it->block->reorder_offset = 0;
 
    it->scrl_y += it->block->reorder_offset;
 
@@ -2298,7 +2298,7 @@
         return it->wd->reorder_it->h;
      }
    else
-      return 0;
+     return 0;
 }
 
 static Eina_Bool
@@ -3577,8 +3577,8 @@
         it->parent->items = eina_list_append(it->parent->items, it);
         if (!it2) it2 = it->parent;
         wd->items =
-           eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
-                                       EINA_INLIST_GET(it2));
+          eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
+                                      EINA_INLIST_GET(it2));
         it->rel = it2;
         it->rel->relcount++;

Log:
elm: Fixed wrong vim formatting.
  

Author:       seoz
Date:         2011-06-26 19:54:41 -0700 (Sun, 26 Jun 2011)
New Revision: 60714
Trac:         http://trac.enlightenment.org/e/changeset/60714

Modified:
  trunk/elementary/src/lib/elm_cnp_helper.c trunk/elementary/src/lib/elm_glview.c trunk/elementary/src/lib/elm_image.c trunk/elementary/src/lib/elm_photo.c trunk/elementary/src/lib/elm_route.c trunk/elementary/src/lib/elm_thumb.c trunk/elementary/src/lib/els_icon.c 

Modified: trunk/elementary/src/lib/elm_cnp_helper.c
===================================================================
--- trunk/elementary/src/lib/elm_cnp_helper.c	2011-06-27 02:19:41 UTC (rev 60713)
+++ trunk/elementary/src/lib/elm_cnp_helper.c	2011-06-27 02:54:41 UTC (rev 60714)
@@ -1650,4 +1650,4 @@
 }
 #endif
 
-/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-2f0^-2{2(0W1st0 :*/
+/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-3f0^-2{2(0W1st0 :*/

Modified: trunk/elementary/src/lib/elm_glview.c
===================================================================
--- trunk/elementary/src/lib/elm_glview.c	2011-06-27 02:19:41 UTC (rev 60713)
+++ trunk/elementary/src/lib/elm_glview.c	2011-06-27 02:54:41 UTC (rev 60714)
@@ -579,4 +579,4 @@
      }
 }
 
-/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-2f0^-2{2(0W1st0 :*/
+/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-3f0^-2{2(0W1st0 :*/

Modified: trunk/elementary/src/lib/elm_image.c
===================================================================
--- trunk/elementary/src/lib/elm_image.c	2011-06-27 02:19:41 UTC (rev 60713)
+++ trunk/elementary/src/lib/elm_image.c	2011-06-27 02:54:41 UTC (rev 60714)
@@ -509,4 +509,4 @@
    return _els_smart_icon_object_get(wd->img);
 }
 
-/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-2f0^-2{2(0W1st0 :*/
+/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-3f0^-2{2(0W1st0 :*/

Modified: trunk/elementary/src/lib/elm_photo.c
===================================================================
--- trunk/elementary/src/lib/elm_photo.c	2011-06-27 02:19:41 UTC (rev 60713)
+++ trunk/elementary/src/lib/elm_photo.c	2011-06-27 02:54:41 UTC (rev 60714)
@@ -361,4 +361,4 @@
    _els_smart_icon_edit_set(wd->img, set, obj);
 }
 
-/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-2f0^-2{2(0W1st0 :*/
+/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-3f0^-2{2(0W1st0 :*/

Modified: trunk/elementary/src/lib/elm_route.c
===================================================================
--- trunk/elementary/src/lib/elm_route.c	2011-06-27 02:19:41 UTC (rev 60713)
+++ trunk/elementary/src/lib/elm_route.c	2011-06-27 02:54:41 UTC (rev 60714)
@@ -295,4 +295,4 @@
    return wd->lat_max;
 }
 
-/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-2f0^-2{2(0W1st0 :*/
+/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-3f0^-2{2(0W1st0 :*/

Modified: trunk/elementary/src/lib/elm_thumb.c
===================================================================
--- trunk/elementary/src/lib/elm_thumb.c	2011-06-27 02:19:41 UTC (rev 60713)
+++ trunk/elementary/src/lib/elm_thumb.c	2011-06-27 02:54:41 UTC (rev 60714)
@@ -945,4 +945,4 @@
    return wd->edit;
 }
 
-/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-2f0^-2{2(0W1st0 :*/
+/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-3f0^-2{2(0W1st0 :*/

Modified: trunk/elementary/src/lib/els_icon.c
===================================================================
--- trunk/elementary/src/lib/els_icon.c	2011-06-27 02:19:41 UTC (rev 60713)
+++ trunk/elementary/src/lib/els_icon.c	2011-06-27 02:54:41 UTC (rev 60714)
@@ -726,4 +726,4 @@
 
    return EINA_TRUE;
 }
-/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-2f0^-2{2(0W1st0 :*/
+/* vim:set ts=8 sw=3 sts=3 expandtab cino=>5n-3f0^-2{2(0W1st0 :*/

Log:
elm route: Fixed indentation.
  

Author:       seoz
Date:         2011-06-26 19:55:52 -0700 (Sun, 26 Jun 2011)
New Revision: 60715
Trac:         http://trac.enlightenment.org/e/changeset/60715

Modified:
  trunk/elementary/src/lib/elm_route.c 

Modified: trunk/elementary/src/lib/elm_route.c
===================================================================
--- trunk/elementary/src/lib/elm_route.c	2011-06-27 02:54:41 UTC (rev 60714)
+++ trunk/elementary/src/lib/elm_route.c	2011-06-27 02:55:52 UTC (rev 60715)
@@ -79,7 +79,7 @@
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
-  //TODO
+   //TODO
    _sizing_eval(obj);
 }
 
@@ -95,25 +95,25 @@
    evas_object_geometry_get(obj, &x, &y, &w, &h);
 
    EINA_LIST_FOREACH(wd->segments, l, segment)
-   {
-      if(wd->must_calc_segments || segment->must_calc)
-      {
+     {
+        if(wd->must_calc_segments || segment->must_calc)
+          {
 
 #ifdef ELM_EMAP
-         segment->start_x = (emap_route_node_lon_get(segment->node_start)- wd->lon_min) / (float)(wd->lon_max - wd->lon_min);
-         segment->start_y = 1 - (emap_route_node_lat_get(segment->node_start) - wd->lat_min) / (float)(wd->lat_max - wd->lat_min);
-         segment->end_x = (emap_route_node_lon_get(segment->node_end) - wd->lon_min) / (float)(wd->lon_max - wd->lon_min);
-         segment->end_y = 1 - (emap_route_node_lat_get(segment->node_end) - wd->lat_min) / (float)(wd->lat_max - wd->lat_min);
+             segment->start_x = (emap_route_node_lon_get(segment->node_start)- wd->lon_min) / (float)(wd->lon_max - wd->lon_min);
+             segment->start_y = 1 - (emap_route_node_lat_get(segment->node_start) - wd->lat_min) / (float)(wd->lat_max - wd->lat_min);
+             segment->end_x = (emap_route_node_lon_get(segment->node_end) - wd->lon_min) / (float)(wd->lon_max - wd->lon_min);
+             segment->end_y = 1 - (emap_route_node_lat_get(segment->node_end) - wd->lat_min) / (float)(wd->lat_max - wd->lat_min);
 #endif
-         segment->must_calc = EINA_FALSE;
-      }
+             segment->must_calc = EINA_FALSE;
+          }
 
-      start_x = x+(int)(segment->start_x*w);
-      start_y = y+(int)(segment->start_y*h);
-      end_x = x+(int)(segment->end_x*w);
-      end_y = y+(int)(segment->end_y*h);
-      evas_object_line_xy_set(segment->obj, start_x, start_y, end_x, end_y);
-   }
+        start_x = x+(int)(segment->start_x*w);
+        start_y = y+(int)(segment->start_y*h);
+        end_x = x+(int)(segment->end_x*w);
+        end_y = y+(int)(segment->end_y*h);
+        evas_object_line_xy_set(segment->obj, start_x, start_y, end_x, end_y);
+     }
 
    wd->must_calc_segments = EINA_FALSE;
 }
@@ -133,10 +133,10 @@
 #endif
 
    EINA_LIST_FREE(wd->segments, segment)
-   {
-      evas_object_del(segment->obj);
-      free(segment);
-   }
+     {
+        evas_object_del(segment->obj);
+        free(segment);
+     }
 }
 
 static void
@@ -145,26 +145,26 @@
    Widget_Data *wd = elm_widget_data_get(obj);
 
    if(wd->lon_min > lon)
-   {
-      wd->lon_min = lon;
-      wd->must_calc_segments = EINA_TRUE;
-   }
+     {
+        wd->lon_min = lon;
+        wd->must_calc_segments = EINA_TRUE;
+     }
    if(wd->lat_min > lat)
-   {
-      wd->lat_min = lat;
-      wd->must_calc_segments = EINA_TRUE;
-   }
+     {
+        wd->lat_min = lat;
+        wd->must_calc_segments = EINA_TRUE;
+     }
 
    if(wd->lon_max < lon)
-   {
-      wd->lon_max = lon;
-      wd->must_calc_segments = EINA_TRUE;
-   }
+     {
+        wd->lon_max = lon;
+        wd->must_calc_segments = EINA_TRUE;
+     }
    if(wd->lat_max < lat)
-   {
-      wd->lat_max = lat;
-      wd->must_calc_segments = EINA_TRUE;
-   }
+     {
+        wd->lat_max = lat;
+        wd->must_calc_segments = EINA_TRUE;
+     }
 }
 
 /**
@@ -237,27 +237,27 @@
    _clear_route(obj);
 
    EINA_LIST_FOREACH(emap_route_nodes_get(wd->emap), l, node)
-   {
-      if(node_prev)
-      {
-         Segment *segment = calloc(1, sizeof(Segment));
-         segment->node_start = node_prev;
-         segment->node_end = node;
+     {
+        if(node_prev)
+          {
+             Segment *segment = calloc(1, sizeof(Segment));
+             segment->node_start = node_prev;
+             segment->node_end = node;
 
-         o = evas_object_line_add(evas_object_evas_get(obj));
-         segment->obj = o;
-         evas_object_smart_member_add(o, obj);
-         evas_object_show(o);
+             o = evas_object_line_add(evas_object_evas_get(obj));
+             segment->obj = o;
+             evas_object_smart_member_add(o, obj);
+             evas_object_show(o);
 
-         segment->must_calc = EINA_TRUE;
+             segment->must_calc = EINA_TRUE;
 
-         _update_lon_lat_min_max(obj, emap_route_node_lon_get(node_prev), emap_route_node_lat_get(node_prev));
-         _update_lon_lat_min_max(obj, emap_route_node_lon_get(node), emap_route_node_lat_get(node));
+             _update_lon_lat_min_max(obj, emap_route_node_lon_get(node_prev), emap_route_node_lat_get(node_prev));
+             _update_lon_lat_min_max(obj, emap_route_node_lon_get(node), emap_route_node_lat_get(node));
 
-         wd->segments = eina_list_append(wd->segments, segment);
-      }
-      node_prev = node;
-   }
+             wd->segments = eina_list_append(wd->segments, segment);
+          }
+        node_prev = node;
+     }
 
    _sizing_eval(obj);
 }

Log:
elm route: Fixed warnings.
  

Author:       seoz
Date:         2011-06-26 20:03:16 -0700 (Sun, 26 Jun 2011)
New Revision: 60716
Trac:         http://trac.enlightenment.org/e/changeset/60716

Modified:
  trunk/elementary/src/lib/elm_route.c 

Modified: trunk/elementary/src/lib/elm_route.c
===================================================================
--- trunk/elementary/src/lib/elm_route.c	2011-06-27 02:55:52 UTC (rev 60715)
+++ trunk/elementary/src/lib/elm_route.c	2011-06-27 03:03:16 UTC (rev 60716)
@@ -47,12 +47,13 @@
 static void _theme_hook(Evas_Object *obj);
 static void _sizing_eval(Evas_Object *obj);
 static void _clear_route(Evas_Object *obj);
+#ifdef ELM_EMAP
 static void _update_lon_lat_min_max(Evas_Object *obj, double lon, double lat);
+#endif
 
 static void
 _del_hook(Evas_Object *obj)
 {
-   Evas_Object *segment;
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
 
@@ -68,7 +69,7 @@
 }
 
 static void
-_mirrored_set(Evas_Object *obj, Eina_Bool rtl)
+_mirrored_set(Evas_Object *obj, Eina_Bool rtl __UNUSED__)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
@@ -139,6 +140,7 @@
      }
 }
 
+#ifdef ELM_EMAP
 static void
 _update_lon_lat_min_max(Evas_Object *obj, double lon, double lat)
 {
@@ -166,6 +168,7 @@
         wd->must_calc_segments = EINA_TRUE;
      }
 }
+#endif
 
 /**
  * Add a new route to the parent
@@ -181,7 +184,6 @@
    Evas_Object *obj;
    Evas *e;
    Widget_Data *wd;
-   Evas_Object *icon;
 
    ELM_WIDGET_STANDARD_SETUP(wd, Widget_Data, parent, e, obj, NULL);

Log:
elm genlist: Mark TODO to moved function.
  
  Change moved callback in item class to smart callback.
  

Author:       seoz
Date:         2011-06-26 20:06:33 -0700 (Sun, 26 Jun 2011)
New Revision: 60717
Trac:         http://trac.enlightenment.org/e/changeset/60717

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-06-27 03:03:16 UTC (rev 60716)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-06-27 03:06:33 UTC (rev 60717)
@@ -3609,7 +3609,7 @@
              GenlistItemIconGetFunc   icon_get;
              GenlistItemStateGetFunc  state_get;
              GenlistItemDelFunc       del;
-             GenlistItemMovedFunc     moved;
+             GenlistItemMovedFunc     moved; // TODO: do not use this. change this to smart callback.
           } func;
         const char                *mode_item_style;
      };

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-27 03:03:16 UTC (rev 60716)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-27 03:06:33 UTC (rev 60717)
@@ -3517,6 +3517,7 @@
    if (after->group_item) it->group_item = after->group_item;
    _item_queue(it->wd, it);
 
+   // TODO: change this to smart callback
    if (it->itc->func.moved)
      it->itc->func.moved(it->base.widget, it, after, EINA_TRUE);
 }
@@ -3536,6 +3537,7 @@
    if (before->group_item) it->group_item = before->group_item;
    _item_queue(it->wd, it);
 
+   // TODO: change this to smart callback
    if (it->itc->func.moved)
      it->itc->func.moved(it->base.widget, it, before, EINA_FALSE);
 }

Log:
elm map: Fixed 'unused parameter' warnings.
  

Author:       seoz
Date:         2011-06-27 23:58:35 -0700 (Mon, 27 Jun 2011)
New Revision: 60745
Trac:         http://trac.enlightenment.org/e/changeset/60745

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-06-28 02:10:36 UTC (rev 60744)
+++ trunk/elementary/src/lib/elm_map.c	2011-06-28 06:58:35 UTC (rev 60745)
@@ -799,7 +799,11 @@
 }
 
 static void
+#ifdef ELM_EMAP
 track_place(Evas_Object *obj, Grid *g __UNUSED__, Evas_Coord px, Evas_Coord py, Evas_Coord ox __UNUSED__, Evas_Coord oy __UNUSED__, Evas_Coord ow, Evas_Coord oh)
+#else
+track_place(Evas_Object *obj __UNUSED__, Grid *g __UNUSED__, Evas_Coord px __UNUSED__, Evas_Coord py __UNUSED__, Evas_Coord ox __UNUSED__, Evas_Coord oy __UNUSED__, Evas_Coord ow __UNUSED__, Evas_Coord oh __UNUSED__)
+#endif
 {
 #ifdef ELM_EMAP
    ELM_CHECK_WIDTYPE(obj, widtype);

Log:
elm genlist: Removed unnecessary variable.
  

Author:       seoz
Date:         2011-06-28 00:13:28 -0700 (Tue, 28 Jun 2011)
New Revision: 60747
Trac:         http://trac.enlightenment.org/e/changeset/60747

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-06-28 07:02:37 UTC (rev 60746)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-06-28 07:13:28 UTC (rev 60747)
@@ -296,7 +296,7 @@
    Ecore_Timer                  *long_timer;
    Ecore_Timer                  *swipe_timer;
    Evas_Coord                    dx, dy;
-   Evas_Coord                    scrl_x, scrl_y, old_scrl_x, old_scrl_y;
+   Evas_Coord                    scrl_x, scrl_y, old_scrl_y;
 
    Elm_Genlist_Item             *rel;
    Evas_Object                  *mode_view;
@@ -2427,7 +2427,6 @@
                                    _item_position(it, it->base.view, it->scrl_x,
                                                   it->scrl_y);
                               }
-                            it->old_scrl_x = it->scrl_x;
                             it->old_scrl_y = it->scrl_y;
                          }
                     }

Log:
elm route: Fixed formatting.
  

Author:       seoz
Date:         2011-06-29 18:35:41 -0700 (Wed, 29 Jun 2011)
New Revision: 60850
Trac:         http://trac.enlightenment.org/e/changeset/60850

Modified:
  trunk/elementary/src/lib/elm_route.c 

Modified: trunk/elementary/src/lib/elm_route.c
===================================================================
--- trunk/elementary/src/lib/elm_route.c	2011-06-30 01:33:38 UTC (rev 60849)
+++ trunk/elementary/src/lib/elm_route.c	2011-06-30 01:35:41 UTC (rev 60850)
@@ -97,7 +97,7 @@
 
    EINA_LIST_FOREACH(wd->segments, l, segment)
      {
-        if(wd->must_calc_segments || segment->must_calc)
+        if (wd->must_calc_segments || segment->must_calc)
           {
 
 #ifdef ELM_EMAP
@@ -146,23 +146,23 @@
 {
    Widget_Data *wd = elm_widget_data_get(obj);
 
-   if(wd->lon_min > lon)
+   if (wd->lon_min > lon)
      {
         wd->lon_min = lon;
         wd->must_calc_segments = EINA_TRUE;
      }
-   if(wd->lat_min > lat)
+   if (wd->lat_min > lat)
      {
         wd->lat_min = lat;
         wd->must_calc_segments = EINA_TRUE;
      }
 
-   if(wd->lon_max < lon)
+   if (wd->lon_max < lon)
      {
         wd->lon_max = lon;
         wd->must_calc_segments = EINA_TRUE;
      }
-   if(wd->lat_max < lat)
+   if (wd->lat_max < lat)
      {
         wd->lat_max = lat;
         wd->must_calc_segments = EINA_TRUE;
@@ -240,7 +240,7 @@
 
    EINA_LIST_FOREACH(emap_route_nodes_get(wd->emap), l, node)
      {
-        if(node_prev)
+        if (node_prev)
           {
              Segment *segment = calloc(1, sizeof(Segment));
              segment->node_start = node_prev;

Log:
elm route: Changed return value of elm_route_emap_set() API from
  Eina_Bool to void.
  
  EFL uses void as a xxx_set() API's return value.
  

Author:       seoz
Date:         2011-06-29 19:10:46 -0700 (Wed, 29 Jun 2011)
New Revision: 60852
Trac:         http://trac.enlightenment.org/e/changeset/60852

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_route.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-06-30 01:46:12 UTC (rev 60851)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-06-30 02:10:46 UTC (rev 60852)
@@ -4899,7 +4899,7 @@
    /* Route */
    EAPI Evas_Object *elm_route_add(Evas_Object *parent);
 #ifdef ELM_EMAP
-   EAPI Eina_Bool elm_route_emap_set(Evas_Object *obj, EMap_Route *emap);
+   EAPI void elm_route_emap_set(Evas_Object *obj, EMap_Route *emap);
 #endif
    EAPI double elm_route_lon_min_get(Evas_Object *obj);
    EAPI double elm_route_lat_min_get(Evas_Object *obj);

Modified: trunk/elementary/src/lib/elm_route.c
===================================================================
--- trunk/elementary/src/lib/elm_route.c	2011-06-30 01:46:12 UTC (rev 60851)
+++ trunk/elementary/src/lib/elm_route.c	2011-06-30 02:10:46 UTC (rev 60852)
@@ -223,17 +223,17 @@
  *
  * @ingroup Route
  */
-EAPI Eina_Bool
+EAPI void
 elm_route_emap_set(Evas_Object *obj, EMap_Route *emap)
 {
    EMap_Route_Node *node, *node_prev = NULL;
    Evas_Object *o;
    Eina_List *l;
 
-   ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE;
+   ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
 
-   if (!wd) return EINA_FALSE;
+   if (!wd) return;
    wd->emap = emap;
 
    _clear_route(obj);

Log:
elm: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-07-05 09:59:23 -0700 (Tue, 05 Jul 2011)
New Revision: 61057
Trac:         http://trac.enlightenment.org/e/changeset/61057

Modified:
  trunk/elementary/src/lib/elm_cnp_helper.c trunk/elementary/src/lib/elm_win.c 

Modified: trunk/elementary/src/lib/elm_cnp_helper.c
===================================================================
--- trunk/elementary/src/lib/elm_cnp_helper.c	2011-07-05 16:36:50 UTC (rev 61056)
+++ trunk/elementary/src/lib/elm_cnp_helper.c	2011-07-05 16:59:23 UTC (rev 61057)
@@ -1609,7 +1609,7 @@
      }
 
    eina_mmap_safety_enabled_set(EINA_TRUE);
-   
+
    info->map = mmap(NULL, size, PROT_READ|PROT_WRITE, MAP_SHARED, info->fd, 0);
    if (info->map == MAP_FAILED)
      {

Modified: trunk/elementary/src/lib/elm_win.c
===================================================================
--- trunk/elementary/src/lib/elm_win.c	2011-07-05 16:36:50 UTC (rev 61056)
+++ trunk/elementary/src/lib/elm_win.c	2011-07-05 16:59:23 UTC (rev 61057)
@@ -51,7 +51,7 @@
  * output to the file specified by the file option (and then exit). If no
  * delay is given, the default is 0.5 seconds. If no file is given the
  * default output file is "out.png". Repeat option is for continous
- * capturing screenshots. Repeat range is from 1 to 999 and 
+ * capturing screenshots. Repeat range is from 1 to 999 and
  * filename is fixed to "out001.png"
  * Some examples of using the shot engine:
  *
@@ -211,7 +211,7 @@
                     {
                        repname = malloc(sizeof(char)*(strlen(tmp) + 16));
                        strncpy(repname, tmp, dotptr - tmp);
-                       sprintf(repname + (dotptr - tmp), "%03i", 
+                       sprintf(repname + (dotptr - tmp), "%03i",
                                win->shot.shot_counter + 1);
                        strcat(repname, dotptr);
                        return repname;
@@ -221,7 +221,7 @@
      }
    free(tmp);
    if (!win->shot.repeat_count) return strdup("out.png");
-   else 
+   else
      {
         repname = malloc(sizeof(char) * 24);
         sprintf(repname, "out%03i.png", win->shot.shot_counter + 1);
@@ -315,7 +315,7 @@
      {
         int remainshot = (win->shot.repeat_count - win->shot.shot_counter);
         if (remainshot > 0) return EINA_TRUE;
-     } 
+     }
    win->shot.timer = NULL;
    elm_exit();
    return EINA_FALSE;

Log:
elm genlist: Fixed delayed signal processing issue. Patch by Jaehwan Kim <jae.hwan.kim@...>
  
  2011/7/5 Jaehwan Kim <jae.hwan.kim@...>:
  >
  > Dear all,
  >
  > In target, elm_genlist sometime blink while it realize again.
  > It is why the signal like "elm,state,selected" isn't processed immediatly.
  > So it show default state and then change to seleted state.
  > _item_realize have to process the signals immediatly.
  > It add a line "edje_object_message_signal_process" in the last of the _item_realize.
  > Please check the patch.
  >
  > Thanks.
  

Author:       seoz
Date:         2011-07-05 10:17:14 -0700 (Tue, 05 Jul 2011)
New Revision: 61061
Trac:         http://trac.enlightenment.org/e/changeset/61061

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-07-05 17:13:28 UTC (rev 61060)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-07-05 17:17:14 UTC (rev 61061)
@@ -2119,6 +2119,7 @@
    //evas_event_thaw_eval(evas_object_evas_get(it->wd->obj));
    if (!calc)
      evas_object_smart_callback_call(it->base.widget, SIG_REALIZED, it);
+   edje_object_message_signal_process(it->base.view);
 }
 
 static void

Log:
elm Elementary.h.in: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-07-06 19:31:26 -0700 (Wed, 06 Jul 2011)
New Revision: 61102
Trac:         http://trac.enlightenment.org/e/changeset/61102

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-07-07 02:21:18 UTC (rev 61101)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-07-07 02:31:26 UTC (rev 61102)
@@ -2361,14 +2361,14 @@
     * @image html  widget/button/preview-00.png
     * @image html  widget/button/preview-01.png
     * @image html  widget/button/preview-02.png
-    * 
+    *
     * This is a push-button. Press it and run some function. It can contain
     * a simple label and icon object and it also has an autorepeat feature.
     *
     * This widgets emits the following signals:
     * @li "clicked": the user clicked the button (press/release).
     * @li "repeated": the user pressed the button without releasing it.
-    * @li "pressed": button was pressed. 
+    * @li "pressed": button was pressed.
     * @li "unpressed": button was released after being pressed.
     * In all three cases, the @c event parameter of the callback will be
     * @c NULL.
@@ -2695,7 +2695,7 @@
    EAPI void         elm_table_clear(Evas_Object *obj, Eina_Bool clear) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_pack_set(Evas_Object *subobj, int x, int y, int w, int h) EINA_ARG_NONNULL(1);
    EAPI void         elm_table_pack_get(Evas_Object *subobj, int *x, int *y, int *w, int *h) EINA_ARG_NONNULL(1);
-         
+
    /* gengrid */
    typedef struct _Elm_Gengrid_Item_Class Elm_Gengrid_Item_Class;
    typedef struct _Elm_Gengrid_Item_Class_Func Elm_Gengrid_Item_Class_Func;
@@ -3082,7 +3082,7 @@
    EAPI void         elm_entry_scrollbar_policy_set(Evas_Object *obj, Elm_Scroller_Policy h, Elm_Scroller_Policy v);
    EAPI void         elm_entry_bounce_set(Evas_Object *obj, Eina_Bool h_bounce, Eina_Bool v_bounce);
    EAPI void         elm_entry_bounce_get(const Evas_Object *obj, Eina_Bool *h_bounce, Eina_Bool *v_bounce);
-         
+
    /* pre-made filters for entries */
    typedef struct _Elm_Entry_Filter_Limit_Size Elm_Entry_Filter_Limit_Size;
    struct _Elm_Entry_Filter_Limit_Size

Log:
elm layout: Fixed theme hook bug.
  

Author:       seoz
Date:         2011-07-06 21:48:49 -0700 (Wed, 06 Jul 2011)
New Revision: 61103
Trac:         http://trac.enlightenment.org/e/changeset/61103

Modified:
  trunk/elementary/src/lib/elm_layout.c 

Modified: trunk/elementary/src/lib/elm_layout.c
===================================================================
--- trunk/elementary/src/lib/elm_layout.c	2011-07-07 02:31:26 UTC (rev 61102)
+++ trunk/elementary/src/lib/elm_layout.c	2011-07-07 04:48:49 UTC (rev 61103)
@@ -21,6 +21,7 @@
    Eina_List *subs;
    Eina_List *parts_cursors;
    Eina_Bool needs_size_calc:1;
+   const char *clas, *group, *style;
 };
 
 struct _Subinfo
@@ -102,6 +103,7 @@
    if (!wd) return;
    _elm_widget_mirrored_reload(obj);
    _mirrored_set(obj, elm_widget_mirrored_get(obj));
+   _elm_theme_object_set(obj, wd->lay, wd->clas, wd->group, wd->style);
    edje_object_scale_set(wd->lay, elm_widget_scale_get(obj) *
                          _elm_config->scale);
    _sizing_eval(wd);
@@ -451,6 +453,9 @@
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return EINA_FALSE;
    Eina_Bool ret = _elm_theme_object_set(obj, wd->lay, clas, group, style);
+   wd->clas = clas;
+   wd->group = group;
+   wd->style = style;
    if (ret)
      {
         _parts_text_fix(wd);

Log:
elm genlist/list/gengrid: Removed deprecated signal "clicked". Use
  "clicked,double" instead.
  
  The name was wrong and I added a proper signals few months ago. Not I
  removed wrong signals.
  

Author:       seoz
Date:         2011-07-07 05:49:39 -0700 (Thu, 07 Jul 2011)
New Revision: 61115
Trac:         http://trac.enlightenment.org/e/changeset/61115

Modified:
  trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_list.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-07-07 11:55:05 UTC (rev 61114)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-07-07 12:49:39 UTC (rev 61115)
@@ -472,7 +472,6 @@
      {
         item = elm_gengrid_selected_item_get(obj);
         evas_object_smart_callback_call(item->wd->self, SIG_CLICKED_DOUBLE, item);
-        evas_object_smart_callback_call(item->wd->self, "clicked", item); // will be removed
      }
    else return EINA_FALSE;
 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-07-07 11:55:05 UTC (rev 61114)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-07-07 12:49:39 UTC (rev 61115)
@@ -1418,10 +1418,7 @@
    _item_highlight(it);
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
      if ((!it->disabled) && (!it->display_only))
-       {
-          evas_object_smart_callback_call(it->base.widget, SIG_CLICKED_DOUBLE, it);
-          evas_object_smart_callback_call(it->base.widget, "clicked", it); // will be removed
-       }
+       evas_object_smart_callback_call(it->base.widget, SIG_CLICKED_DOUBLE, it);
    if (it->long_timer) ecore_timer_del(it->long_timer);
    if (it->swipe_timer) ecore_timer_del(it->swipe_timer);
    it->swipe_timer = ecore_timer_add(0.4, _swipe_cancel, it);

Modified: trunk/elementary/src/lib/elm_list.c
===================================================================
--- trunk/elementary/src/lib/elm_list.c	2011-07-07 11:55:05 UTC (rev 61114)
+++ trunk/elementary/src/lib/elm_list.c	2011-07-07 12:49:39 UTC (rev 61115)
@@ -931,10 +931,7 @@
    it->swipe_timer = ecore_timer_add(0.4, _swipe_cancel, it);
    /* Always call the callbacks last - the user may delete our context! */
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
-     {
-        evas_object_smart_callback_call(it->base.widget, SIG_CLICKED_DOUBLE, it);
-        evas_object_smart_callback_call(it->base.widget, "clicked", it); // will be removed
-     }
+     evas_object_smart_callback_call(it->base.widget, SIG_CLICKED_DOUBLE, it);
    wd->swipe = EINA_FALSE;
    wd->movements = 0;

Log:
elm Elementary.h.in: Unified the way of using EINA_ARG_NOTNULL.
  
  I put semicolon at the end of declarations.
  EAPI elm_xxxx(yyyyy) EINA_ARG_NOTNULL(1);
  

Author:       seoz
Date:         2011-07-07 06:07:05 -0700 (Thu, 07 Jul 2011)
New Revision: 61116
Trac:         http://trac.enlightenment.org/e/changeset/61116

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-07-07 12:49:39 UTC (rev 61115)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-07-07 13:07:05 UTC (rev 61116)
@@ -1605,8 +1605,8 @@
    EAPI int          elm_win_quickpanel_priority_minor_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    EAPI void         elm_win_quickpanel_zone_set(Evas_Object *obj, int zone) EINA_ARG_NONNULL(1);
    EAPI int          elm_win_quickpanel_zone_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
-   EAPI void         elm_win_prop_focus_skip_set(Evas_Object *obj, Eina_Bool skip); EINA_ARG_NONNULL(1);
-   EAPI void         elm_win_illume_command_send(Evas_Object *obj, Elm_Illume_Command command, void *params); EINA_ARG_NONNULL(1);
+   EAPI void         elm_win_prop_focus_skip_set(Evas_Object *obj, Eina_Bool skip) EINA_ARG_NONNULL(1);
+   EAPI void         elm_win_illume_command_send(Evas_Object *obj, Elm_Illume_Command command, void *params) EINA_ARG_NONNULL(1);
    EAPI Evas_Object *elm_win_inlined_image_object_get(Evas_Object *obj);
    EAPI void         elm_win_focus_highlight_enabled_set(Evas_Object *obj, Eina_Bool enabled) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool    elm_win_focus_highlight_enabled_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
@@ -2665,11 +2665,11 @@
 
    /* frame */
    EAPI Evas_Object *elm_frame_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
-   EINA_DEPRECATED EAPI void         elm_frame_label_set(Evas_Object *obj, const char *label); EINA_ARG_NONNULL(1)
-   EINA_DEPRECATED EAPI const char  *elm_frame_label_get(const Evas_Object *obj); EINA_ARG_NONNULL(1)
-   EAPI void         elm_frame_content_set(Evas_Object *obj, Evas_Object *content); EINA_ARG_NONNULL(1)
-   EAPI Evas_Object *elm_frame_content_get(const Evas_Object *obj); EINA_ARG_NONNULL(1)
-   EAPI Evas_Object *elm_frame_content_unset(Evas_Object *obj); EINA_ARG_NONNULL(1)
+   EINA_DEPRECATED EAPI void         elm_frame_label_set(Evas_Object *obj, const char *label) EINA_ARG_NONNULL(1);
+   EINA_DEPRECATED EAPI const char  *elm_frame_label_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void         elm_frame_content_set(Evas_Object *obj, Evas_Object *content) EINA_ARG_NONNULL(1);
+   EAPI Evas_Object *elm_frame_content_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Evas_Object *elm_frame_content_unset(Evas_Object *obj) EINA_ARG_NONNULL(1);
    /* available styles:
     * default
     * pad_small
@@ -4512,14 +4512,14 @@
 
    /* check */
    EAPI Evas_Object *elm_check_add(Evas_Object *parent) EINA_ARG_NONNULL(1);
-   EINA_DEPRECATED EAPI void         elm_check_label_set(Evas_Object *obj, const char *label); EINA_ARG_NONNULL(1)
-   EINA_DEPRECATED EAPI const char  *elm_check_label_get(const Evas_Object *obj); EINA_ARG_NONNULL(1)
-   EAPI void         elm_check_icon_set(Evas_Object *obj, Evas_Object *icon); EINA_ARG_NONNULL(1)
-   EAPI Evas_Object *elm_check_icon_get(const Evas_Object *obj); EINA_ARG_NONNULL(1)
-   EAPI Evas_Object *elm_check_icon_unset(Evas_Object *obj); EINA_ARG_NONNULL(1)
-   EAPI void         elm_check_state_set(Evas_Object *obj, Eina_Bool state); EINA_ARG_NONNULL(1)
-   EAPI Eina_Bool    elm_check_state_get(const Evas_Object *obj); EINA_ARG_NONNULL(1)
-   EAPI void         elm_check_state_pointer_set(Evas_Object *obj, Eina_Bool *statep); EINA_ARG_NONNULL(1)
+   EINA_DEPRECATED EAPI void         elm_check_label_set(Evas_Object *obj, const char *label) EINA_ARG_NONNULL(1);
+   EINA_DEPRECATED EAPI const char  *elm_check_label_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void         elm_check_icon_set(Evas_Object *obj, Evas_Object *icon) EINA_ARG_NONNULL(1);
+   EAPI Evas_Object *elm_check_icon_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Evas_Object *elm_check_icon_unset(Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void         elm_check_state_set(Evas_Object *obj, Eina_Bool state) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool    elm_check_state_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void         elm_check_state_pointer_set(Evas_Object *obj, Eina_Bool *statep) EINA_ARG_NONNULL(1);
    /* smart callbacks called:
     * "changed" - This is called whenever the user changes the state of one of the check object.
     */
@@ -5293,7 +5293,7 @@
     * @param[in] cs Curve style. Default is ELM_ANIMATOR_CURVE_LINEAR
     * @deprecated Use @ref Transit instead.
     */
-   EINA_DEPRECATED EAPI Elm_Animator_Curve_Style elm_animator_curve_style_get(const Elm_Animator *animator); EINA_ARG_NONNULL(1);
+   EINA_DEPRECATED EAPI Elm_Animator_Curve_Style elm_animator_curve_style_get(const Elm_Animator *animator) EINA_ARG_NONNULL(1);
    /**
     * @brief Sets wether the animation should be automatically reversed.
     *

Log:
elm module: Added guard code.
  

Author:       seoz
Date:         2011-07-07 07:50:50 -0700 (Thu, 07 Jul 2011)
New Revision: 61120
Trac:         http://trac.enlightenment.org/e/changeset/61120

Modified:
  trunk/elementary/src/lib/elm_module.c 

Modified: trunk/elementary/src/lib/elm_module.c
===================================================================
--- trunk/elementary/src/lib/elm_module.c	2011-07-07 14:41:10 UTC (rev 61119)
+++ trunk/elementary/src/lib/elm_module.c	2011-07-07 14:50:50 UTC (rev 61120)
@@ -133,8 +133,11 @@
                }
              else
                {
-                  dlclose(m->handle);
-                  m->handle = NULL;
+                  if (m->handle)
+                    {
+                       dlclose(m->handle);
+                       m->handle = NULL;
+                    }
                   return EINA_FALSE;
                }
           }
@@ -158,8 +161,11 @@
                }
              else
                {
-                  dlclose(m->handle);
-                  m->handle = NULL;
+                  if (m->handle)
+                    {
+                       dlclose(m->handle);
+                       m->handle = NULL;
+                    }
                   return EINA_FALSE;
                }
           }

Log:
elm icon: Fixed indentation.
  

Author:       seoz
Date:         2011-07-07 21:07:38 -0700 (Thu, 07 Jul 2011)
New Revision: 61142
Trac:         http://trac.enlightenment.org/e/changeset/61142

Modified:
  trunk/elementary/src/lib/elm_icon.c 

Modified: trunk/elementary/src/lib/elm_icon.c
===================================================================
--- trunk/elementary/src/lib/elm_icon.c	2011-07-08 02:24:56 UTC (rev 61141)
+++ trunk/elementary/src/lib/elm_icon.c	2011-07-08 04:07:38 UTC (rev 61142)
@@ -654,7 +654,7 @@
      {
       case ELM_ICON_LOOKUP_FDO:
          ret = _icon_freedesktop_set(wd, obj, name, _icon_size_min_get(wd->img));
-	 if (ret && fdo) *fdo = EINA_TRUE;
+         if (ret && fdo) *fdo = EINA_TRUE;
          break;
       case ELM_ICON_LOOKUP_THEME:
          ret = _icon_standard_set(wd, obj, name);

Log:
elm conform: Eina_Bool parameter is added to API
  elm_widget_show_region_set to set the show region always. Earlier, the
  API expects some change, to redo the job. Patch by Prince Kumar Dubey
  <prince.dubey@...>
  
  ------- Original Message -------
  Sender : PRINCE KUMAR DUBEY<prince.dubey@...>
  Date : 2011-05-20 17:41 (GMT+09:00)
  Title : [E-devel] [Patch] elm_conform patch
  
  Hi Mr Seo,
  Can you please send the attached patch of elm_conformant to EFL ope-src community.
  Change Log:
  Eina_Bool parameter is added to API elm_widget_show_region_set to set
  the show region always. Earlier, the API expects some change, to redo the job.
  This enhancement is already approved by raster in gerrit review.
  
  Thank you.
  Regards,
  
  Prince
  

Author:       seoz
Date:         2011-07-08 00:50:36 -0700 (Fri, 08 Jul 2011)
New Revision: 61148
Trac:         http://trac.enlightenment.org/e/changeset/61148

Modified:
  trunk/elementary/src/lib/elm_conform.c trunk/elementary/src/lib/elm_entry.c trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_widget.h 

Modified: trunk/elementary/src/lib/elm_conform.c
===================================================================
--- trunk/elementary/src/lib/elm_conform.c	2011-07-08 06:38:56 UTC (rev 61147)
+++ trunk/elementary/src/lib/elm_conform.c	2011-07-08 07:50:36 UTC (rev 61148)
@@ -355,7 +355,7 @@
         if (h < _elm_config->finger_size)
           h = _elm_config->finger_size;
 
-        elm_widget_show_region_set(focus_obj, x, y, w, h);
+        elm_widget_show_region_set(focus_obj, x, y, w, h, EINA_TRUE);
      }
 }
 

Modified: trunk/elementary/src/lib/elm_entry.c
===================================================================
--- trunk/elementary/src/lib/elm_entry.c	2011-07-08 06:38:56 UTC (rev 61147)
+++ trunk/elementary/src/lib/elm_entry.c	2011-07-08 07:50:36 UTC (rev 61148)
@@ -636,7 +636,7 @@
               &cx, &cy, &cw, &ch);
         if (wd->cur_changed)
           {
-             elm_widget_show_region_set(obj, cx, cy, cw, ch);
+             elm_widget_show_region_set(obj, cx, cy, cw, ch, EINA_FALSE);
              wd->cur_changed = EINA_FALSE;
           }
      }
@@ -679,7 +679,7 @@
                                                   &cx, &cy, &cw, &ch);
         if (wd->cur_changed)
           {
-             elm_widget_show_region_set(data, cx, cy, cw, ch);
+             elm_widget_show_region_set(data, cx, cy, cw, ch, EINA_FALSE);
              wd->cur_changed = EINA_FALSE;
           }
      }

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-07-08 06:38:56 UTC (rev 61147)
+++ trunk/elementary/src/lib/elm_widget.c	2011-07-08 07:50:36 UTC (rev 61148)
@@ -1833,13 +1833,15 @@
                            Evas_Coord   x,
                            Evas_Coord   y,
                            Evas_Coord   w,
-                           Evas_Coord   h)
+                           Evas_Coord   h,
+                           Eina_Bool    forceshow)
 {
    Evas_Object *parent_obj, *child_obj;
    Evas_Coord px, py, cx, cy;
 
    API_ENTRY return;
-   if ((x == sd->rx) && (y == sd->ry) && (w == sd->rw) && (h == sd->rh)) return;
+   if (!forceshow && (x == sd->rx) && (y == sd->ry)
+            && (w == sd->rw) && (h == sd->rh)) return;
    sd->rx = x;
    sd->ry = y;
    sd->rw = w;

Modified: trunk/elementary/src/lib/elm_widget.h
===================================================================
--- trunk/elementary/src/lib/elm_widget.h	2011-07-08 06:38:56 UTC (rev 61147)
+++ trunk/elementary/src/lib/elm_widget.h	2011-07-08 07:50:36 UTC (rev 61148)
@@ -272,7 +272,7 @@
 EAPI void             elm_widget_change(Evas_Object *obj);
 EAPI void             elm_widget_disabled_set(Evas_Object *obj, Eina_Bool disabled);
 EAPI Eina_Bool        elm_widget_disabled_get(const Evas_Object *obj);
-EAPI void             elm_widget_show_region_set(Evas_Object *obj, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h);
+EAPI void             elm_widget_show_region_set(Evas_Object *obj, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h, Eina_Bool forceshow);
 EAPI void             elm_widget_show_region_get(const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h);
 EAPI void             elm_widget_focus_region_get(const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h);
 EAPI void             elm_widget_scroll_hold_push(Evas_Object *obj);

Log:
elm entry: Fixed indentation.
  

Author:       seoz
Date:         2011-07-11 21:51:39 -0700 (Mon, 11 Jul 2011)
New Revision: 61265
Trac:         http://trac.enlightenment.org/e/changeset/61265

Modified:
  trunk/elementary/src/lib/elm_entry.c 

Modified: trunk/elementary/src/lib/elm_entry.c
===================================================================
--- trunk/elementary/src/lib/elm_entry.c	2011-07-12 03:51:51 UTC (rev 61264)
+++ trunk/elementary/src/lib/elm_entry.c	2011-07-12 04:51:39 UTC (rev 61265)
@@ -76,7 +76,7 @@
  *
  * "changed" - The text within the entry was changed
  * "activated" - The entry has had editing finished and changes are to be committed
-                 (generally when enter key is pressed)
+ *               (generally when enter key is pressed)
  * "press" - The entry has been clicked
  * "longpressed" - The entry has been clicked for a couple seconds
  * "clicked" - The entry has been clicked
@@ -599,9 +599,9 @@
         edj = elm_smart_scroller_edje_object_get(wd->scroller);
         str = edje_object_data_get(edj, "focus_highlight");
         if ((str) && (!strcmp(str, "on")))
-           elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
+          elm_widget_highlight_in_theme_set(obj, EINA_TRUE);
         else
-           elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
+          elm_widget_highlight_in_theme_set(obj, EINA_FALSE);
      }
    _sizing_eval(obj);
 }
@@ -633,7 +633,7 @@
      {
         Evas_Coord cx, cy, cw, ch;
         edje_object_part_text_cursor_geometry_get(wd->ent, "elm.text",
-              &cx, &cy, &cw, &ch);
+                                                  &cx, &cy, &cw, &ch);
         if (wd->cur_changed)
           {
              elm_widget_show_region_set(obj, cx, cy, cw, ch, EINA_FALSE);
@@ -641,7 +641,7 @@
           }
      }
    else
-      wd->deferred_cur = EINA_TRUE;
+     wd->deferred_cur = EINA_TRUE;
 }
 
 static void
@@ -668,9 +668,9 @@
      }
    evas_object_size_hint_min_set(data, minw, minh);
    if (wd->single_line)
-      evas_object_size_hint_max_set(data, -1, minh);
+     evas_object_size_hint_max_set(data, -1, minh);
    else
-      evas_object_size_hint_max_set(data, -1, -1);
+     evas_object_size_hint_max_set(data, -1, -1);
 
    if (wd->deferred_cur)
      {
@@ -706,7 +706,7 @@
              evas_object_resize(wd->scroller, resw, resh);
              edje_object_size_min_calc
                 (elm_smart_scroller_edje_object_get(wd->scroller),
-                    &vmw, &vmh);
+                 &vmw, &vmh);
              elm_smart_scroller_child_viewport_size_get(wd->scroller, &vw, &vh);
              edje_object_size_min_restricted_calc(wd->ent, &minw, &minh, vw, 0);
              wd->entmw = minw;
@@ -721,9 +721,9 @@
              evas_object_resize(wd->ent, vw, vh);
              evas_object_size_hint_min_set(obj, w, h);
              if (wd->single_line)
-                evas_object_size_hint_max_set(obj, -1, h);
+               evas_object_size_hint_max_set(obj, -1, h);
              else
-                evas_object_size_hint_max_set(obj, -1, -1);
+               evas_object_size_hint_max_set(obj, -1, -1);
           }
         else
           {
@@ -753,14 +753,14 @@
              evas_object_resize(wd->ent, vw, vh);
              edje_object_size_min_calc
                 (elm_smart_scroller_edje_object_get(wd->scroller),
-                    &vmw, &vmh);
+                 &vmw, &vmh);
              if (wd->single_line) h = vmh + minh;
              else h = vmh;
              evas_object_size_hint_min_set(obj, w, h);
              if (wd->single_line)
-                evas_object_size_hint_max_set(obj, -1, h);
+               evas_object_size_hint_max_set(obj, -1, h);
              else
-                evas_object_size_hint_max_set(obj, -1, -1);
+               evas_object_size_hint_max_set(obj, -1, -1);
           }
         else
           {
@@ -770,9 +770,9 @@
              elm_coords_finger_size_adjust(1, &minw, 1, &minh);
              evas_object_size_hint_min_set(obj, minw, minh);
              if (wd->single_line)
-                evas_object_size_hint_max_set(obj, -1, minh);
+               evas_object_size_hint_max_set(obj, -1, minh);
              else
-                evas_object_size_hint_max_set(obj, -1, -1);
+               evas_object_size_hint_max_set(obj, -1, -1);
           }
      }
 
@@ -809,8 +809,8 @@
    if (!wd) return;
    edje_object_signal_emit(wd->ent, emission, source);
    if (wd->scroller)
-      edje_object_signal_emit(elm_smart_scroller_edje_object_get(wd->scroller),
-                              emission, source);
+     edje_object_signal_emit(elm_smart_scroller_edje_object_get(wd->scroller),
+                             emission, source);
 }
 
 static void
@@ -820,8 +820,8 @@
    if (!wd) return;
    edje_object_signal_callback_add(wd->ent, emission, source, func_cb, data);
    if (wd->scroller)
-      edje_object_signal_callback_add(elm_smart_scroller_edje_object_get(wd->scroller),
-                                      emission, source, func_cb, data);
+     edje_object_signal_callback_add(elm_smart_scroller_edje_object_get(wd->scroller),
+                                     emission, source, func_cb, data);
 }
 
 static void
@@ -831,8 +831,8 @@
    edje_object_signal_callback_del_full(wd->ent, emission, source, func_cb,
                                         data);
    if (wd->scroller)
-      edje_object_signal_callback_del_full(elm_smart_scroller_edje_object_get(wd->scroller),
-                                           emission, source, func_cb, data);
+     edje_object_signal_callback_del_full(elm_smart_scroller_edje_object_get(wd->scroller),
+                                          emission, source, func_cb, data);
 }
 
 static void
@@ -847,7 +847,7 @@
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (wd->scroll)
-      elm_smart_scroller_child_region_show(wd->scroller, x, y, w, h);
+     elm_smart_scroller_child_region_show(wd->scroller, x, y, w, h);
 }
 
 static void
@@ -858,7 +858,7 @@
    if (!wd) return;
    elm_widget_show_region_get(obj, &x, &y, &w, &h);
    if (wd->scroll)
-      elm_smart_scroller_child_region_show(wd->scroller, x, y, w, h);
+     elm_smart_scroller_child_region_show(wd->scroller, x, y, w, h);
 }
 
 static void
@@ -1759,7 +1759,7 @@
         /* Go to the start of the nearest codepoint, because we don't want
          * to cut it in the middle */
         eina_unicode_utf8_get_prev(wd->append_text_left,
-              &wd->append_text_position);
+                                   &wd->append_text_position);
      }
    else
      {
@@ -1770,7 +1770,7 @@
    wd->append_text_left[wd->append_text_position] = '\0';
 
    edje_object_part_text_append(wd->ent, "elm.text",
-         wd->append_text_left + start);
+                                wd->append_text_left + start);
 
    wd->append_text_left[wd->append_text_position] = backup;
 
@@ -2086,9 +2086,9 @@
    if (wd->scroller)
      {
         if (wd->single_line)
-           elm_smart_scroller_policy_set(wd->scroller,
-                                         ELM_SMART_SCROLLER_POLICY_OFF,
-                                         ELM_SMART_SCROLLER_POLICY_OFF);
+          elm_smart_scroller_policy_set(wd->scroller,
+                                        ELM_SMART_SCROLLER_POLICY_OFF,
+                                        ELM_SMART_SCROLLER_POLICY_OFF);
         else
           {
              const Elm_Scroller_Policy map[3] =
@@ -3544,9 +3544,9 @@
    Widget_Data *wd = elm_widget_data_get(obj);
    if ((!wd) || (!wd->icon)) return;
    if (setting)
-      evas_object_hide(wd->icon);
+     evas_object_hide(wd->icon);
    else
-      evas_object_show(wd->icon);
+     evas_object_show(wd->icon);
    _sizing_eval(obj);
 }
 
@@ -3649,9 +3649,9 @@
    Widget_Data *wd = elm_widget_data_get(obj);
    if ((!wd) || (!wd->end)) return;
    if (setting)
-      evas_object_hide(wd->end);
+     evas_object_hide(wd->end);
    else
-      evas_object_show(wd->end);
+     evas_object_show(wd->end);
    _sizing_eval(obj);
 }

Log:
elm gengrid: Fixed documentation typo.
  

Author:       seoz
Date:         2011-07-12 02:03:18 -0700 (Tue, 12 Jul 2011)
New Revision: 61271
Trac:         http://trac.enlightenment.org/e/changeset/61271

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-07-12 08:22:16 UTC (rev 61270)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-07-12 09:03:18 UTC (rev 61271)
@@ -2908,7 +2908,7 @@
     * or gengrid has been resized or horizontal property has been changed.
     * scroll - the content has been scrolled (moved).
     * "scroll,drag,start" - dragging the contents around has started.
-    * "scroll,drat,stop" - dragging the contents around has stopped.
+    * "scroll,drag,stop" - dragging the contents around has stopped.
     * drag - Gengrid is being dragged.
     * "drag,start,up" - Gengrid has been dragged (not scrolled) up.
     * "drag,start,down" - Gengrid has been dragged (not scrolled) down.

Log:
elm genscroller: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-07-12 02:52:52 -0700 (Tue, 12 Jul 2011)
New Revision: 61276
Trac:         http://trac.enlightenment.org/e/changeset/61276

Modified:
  trunk/elementary/src/lib/elm_genscroller.c 

Modified: trunk/elementary/src/lib/elm_genscroller.c
===================================================================
--- trunk/elementary/src/lib/elm_genscroller.c	2011-07-12 09:12:20 UTC (rev 61275)
+++ trunk/elementary/src/lib/elm_genscroller.c	2011-07-12 09:52:52 UTC (rev 61276)
@@ -15,7 +15,7 @@
    Evas_Object      *obj, *scr, *pan_smart;
    Pan              *pan;
    Evas_Coord        pan_x, pan_y, minw, minh;
-   
+
    struct {
       int w, h;
       Evas_Coord total_w, total_h;
@@ -457,7 +457,7 @@
  * P |  | |  | |  | |  | |  | |  |
  * A |  | |  | |  | |  | |  | |  |
  * N +--+ +--+ +--+ +--+ +--+ +--+
- * 
+ *
  */
 
 static Span *
@@ -466,9 +466,9 @@
    Span *sp;
    int i, num, bucket;
    Evas_Coord p;
-   
+
    static int lv = 0;
-   
+
    sp = calloc(1, sizeof(Span));
    for (i = 0; i < lv; i++) printf(" ");
    printf("SP: %i tot\n", total);
@@ -477,7 +477,7 @@
    sp->total_child_count = total;
    sp->pos = pos;
    if (bucketsize == 1) return sp;
-   
+
    // get max number of children per bucket
    num = bucket = (bucketsize + (levels - 1)) / levels;
    sp->child = calloc(levels, sizeof(Span *));
@@ -513,7 +513,7 @@
 _span_first(Span *sp)
 {
    Span *sp2;
-   
+
    if (!sp->child) return sp;
    sp2 = _span_first(sp->child[0]);
    return sp2;
@@ -523,7 +523,7 @@
 _span_last(Span *sp)
 {
    Span *sp2;
-   
+
    if (!sp->child) return sp;
    sp2 = _span_last(sp->child[sp->child_count - 1]);
    return sp2;
@@ -582,7 +582,7 @@
 {
    Span *spp;
    Evas_Coord pos = sp->pos;
-   
+
    for (spp = sp->parent; spp; spp = spp->parent)
       pos += spp->pos;
    return pos;
@@ -593,8 +593,8 @@
 {
    Span *spp, *spp_prev;
    int i, num = 0;
-   
-   for (spp_prev = sp, spp = sp->parent; spp; 
+
+   for (spp_prev = sp, spp = sp->parent; spp;
         spp_prev = spp, spp = spp->parent)
      {
         if (spp->child)
@@ -647,7 +647,7 @@
 {
    int i, n, cnt, reduce = 0, deleted = 0, delstart = -1, num2, done;
    Evas_Coord deleted_size = 0, size;
-   
+
    if (!sp->child)
      {
         *delsize = sp->size;
@@ -710,7 +710,7 @@
 {
    Span *sp2;
    int i, j, n, src;
-   
+
    if (num < 0) return;
 next:
    // total child count and size go up by what we are inserting
@@ -762,7 +762,7 @@
      {
         // we have some children - find a spot and plug 'er in
         Span **child;
-        
+
         src = 0;
         // alloc a new child array and copy in old child ptrs from old array
         // up until the insertion point (num)
@@ -908,7 +908,7 @@
 
      {
         Span *sp0, *sp;
-        
+
         sp0 = _span_build(46, 10, 4);
         sp = _span_first(sp0);
         if (sp) printf("first @ %i [%i], size %i\n", sp->pos, _span_real_pos_get(sp), sp->size);
@@ -917,8 +917,8 @@
         for (sp = _span_first(sp0); sp; sp = _span_next(sp))
           {
              if (sp) printf("  @ %i [%i], size %i t: %i %i\n",
-                            sp->pos, 
-                            _span_real_pos_get(sp), 
+                            sp->pos,
+                            _span_real_pos_get(sp),
                             sp->size,
                             sp->child_count,
                             sp->total_child_count);
@@ -954,7 +954,7 @@
         if (sp) printf("sp pos 455 @ %i [%i]\n", _span_real_pos_get(sp), _span_real_num_get(sp));
         sp = _span_pos_get(sp0, 461);
         if (sp) printf("sp pos 461 @ %i [%i]\n", _span_real_pos_get(sp), _span_real_num_get(sp));
-        
+
         printf("del @13, 11 spans\n");
         _span_del(sp0, 13, 11);
         for (sp = _span_first(sp0); sp; sp = _span_next(sp))

Log:
elm genlist: Added _item_realize() function declaration.
  

Author:       seoz
Date:         2011-07-14 00:22:04 -0700 (Thu, 14 Jul 2011)
New Revision: 61359
Trac:         http://trac.enlightenment.org/e/changeset/61359

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-07-14 07:18:11 UTC (rev 61358)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-07-14 07:22:04 UTC (rev 61359)
@@ -373,6 +373,9 @@
 static void      _show_region_hook(void        *data,
                                    Evas_Object *obj);
 static void      _sizing_eval(Evas_Object *obj);
+static void      _item_realize(Elm_Genlist_Item *it,
+                               int               in,
+                               Eina_Bool         calc);
 static void      _item_unrealize(Elm_Genlist_Item *it,
                                  Eina_Bool         calc);
 static void      _item_block_unrealize(Item_Block *itb);

Log:
elm genlist: Removed elm_genlist_item_update() from
  elm_genlist_item_data_set(). So please call elm_genlist_item_update()
  when you need it.
  

Author:       seoz
Date:         2011-07-21 00:10:17 -0700 (Thu, 21 Jul 2011)
New Revision: 61546
Trac:         http://trac.enlightenment.org/e/changeset/61546

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-07-21 01:04:02 UTC (rev 61545)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-07-21 07:10:17 UTC (rev 61546)
@@ -4777,9 +4777,9 @@
  * Set the data item from the genlist item
  *
  * This set the data value passed on the elm_genlist_item_append() and
- * related item addition calls. This function will also call
- * elm_genlist_item_update() so the item will be updated to reflect the
- * new data.
+ * related item addition calls. This function will not call
+ * elm_genlist_item_update() anymore. So call elm_genlist_item_update()
+ * manually only when it's needed.
  *
  * @param it The item
  * @param data The new data pointer to set
@@ -4792,7 +4792,6 @@
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
    elm_widget_item_data_set(it, data);
-   elm_genlist_item_update(it);
 }
 
 /**

Log:
elm check: Fixed elm_check_state_set() issue. Call
  edje_object_message_signal_process() to process the signals right away.
  

Author:       seoz
Date:         2011-07-22 02:03:40 -0700 (Fri, 22 Jul 2011)
New Revision: 61582
Trac:         http://trac.enlightenment.org/e/changeset/61582

Modified:
  trunk/elementary/src/lib/elm_check.c 

Modified: trunk/elementary/src/lib/elm_check.c
===================================================================
--- trunk/elementary/src/lib/elm_check.c	2011-07-22 08:39:46 UTC (rev 61581)
+++ trunk/elementary/src/lib/elm_check.c	2011-07-22 09:03:40 UTC (rev 61582)
@@ -355,6 +355,7 @@
         else
           edje_object_signal_emit(wd->chk, "elm,state,check,off", "elm");
      }
+   edje_object_message_signal_process(wd->chk);
 }
 
 EAPI Eina_Bool

Log:
elm Elementary.h.in: Fixed typos.
  

Author:       seoz
Date:         2011-07-22 03:42:33 -0700 (Fri, 22 Jul 2011)
New Revision: 61584
Trac:         http://trac.enlightenment.org/e/changeset/61584

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-07-22 09:08:58 UTC (rev 61583)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-07-22 10:42:33 UTC (rev 61584)
@@ -7285,7 +7285,7 @@
    /** @defgroup Elm_Gesture_Layer Gesture Layer */
    /**
     * @enum _Elm_Gesture_Types
-    * Emum of supported gesture types.
+    * Enum of supported gesture types.
     * @ingroup Elm_Gesture_Layer
     */
    enum _Elm_Gesture_Types
@@ -7309,14 +7309,14 @@
 
    /**
     * @typedef Elm_Gesture_Types
-    * Type for Emum of supported gesture types.
+    * Type for Enum of supported gesture types.
     * @ingroup Elm_Gesture_Layer
     */
    typedef enum _Elm_Gesture_Types Elm_Gesture_Types;
 
    /**
     * @enum _Elm_Gesture_State
-    * Emum of gesture states.
+    * Enum of gesture states.
     * @ingroup Elm_Gesture_Layer
     */
    enum _Elm_Gesture_State

Log:
elm Elementary.h.in: Use 'typedef' with enum definition.
  

Author:       seoz
Date:         2011-07-22 03:50:38 -0700 (Fri, 22 Jul 2011)
New Revision: 61585
Trac:         http://trac.enlightenment.org/e/changeset/61585

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-07-22 10:42:33 UTC (rev 61584)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-07-22 10:50:38 UTC (rev 61585)
@@ -7288,7 +7288,7 @@
     * Enum of supported gesture types.
     * @ingroup Elm_Gesture_Layer
     */
-   enum _Elm_Gesture_Types
+   typedef enum _Elm_Gesture_Types
      {
         ELM_GESTURE_FIRST = 0,
 
@@ -7305,34 +7305,21 @@
         ELM_GESTURE_ROTATE, /**< Rotate */
 
         ELM_GESTURE_LAST
-     };
+     } Elm_Gesture_Types;
 
    /**
-    * @typedef Elm_Gesture_Types
-    * Type for Enum of supported gesture types.
-    * @ingroup Elm_Gesture_Layer
-    */
-   typedef enum _Elm_Gesture_Types Elm_Gesture_Types;
-
-   /**
     * @enum _Elm_Gesture_State
     * Enum of gesture states.
     * @ingroup Elm_Gesture_Layer
     */
-   enum _Elm_Gesture_State
+   typedef enum _Elm_Gesture_State
      {
         ELM_GESTURE_STATE_UNDEFINED = -1, /**< Gesture not STARTed */
         ELM_GESTURE_STATE_START,          /**< Gesture STARTed     */
         ELM_GESTURE_STATE_MOVE,           /**< Gesture is ongoing  */
         ELM_GESTURE_STATE_END,            /**< Gesture completed   */
         ELM_GESTURE_STATE_ABORT    /**< Onging gesture was ABORTed */
-     };
-   /**
-    * @typedef Elm_Gesture_State
-    * gesture states.
-    * @ingroup Elm_Gesture_Layer
-    */
-   typedef enum _Elm_Gesture_State Elm_Gesture_State;
+     } Elm_Gesture_State;
 
    /**
     * @struct _Elm_Gesture_Taps_Info

Log:
elm Elementary.h.in: Used typedef for function pointer.
  

Author:       seoz
Date:         2011-07-22 04:10:10 -0700 (Fri, 22 Jul 2011)
New Revision: 61586
Trac:         http://trac.enlightenment.org/e/changeset/61586

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_main.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-07-22 10:50:38 UTC (rev 61585)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-07-22 11:10:10 UTC (rev 61586)
@@ -1128,8 +1128,8 @@
    EAPI Eina_Bool        elm_object_scroll_lock_y_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    EAPI void             elm_object_signal_emit(Evas_Object *obj, const char *emission, const char *source) EINA_ARG_NONNULL(1);
-   EAPI void             elm_object_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, void (*func) (void *data, Evas_Object *o, const char *emission, const char *source), void *data) EINA_ARG_NONNULL(1, 4);
-   EAPI void            *elm_object_signal_callback_del(Evas_Object *obj, const char *emission, const char *source, void (*func) (void *data, Evas_Object *o, const char *emission, const char *source)) EINA_ARG_NONNULL(1, 4);
+   EAPI void             elm_object_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func, void *data) EINA_ARG_NONNULL(1, 4);
+   EAPI void            *elm_object_signal_callback_del(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func) EINA_ARG_NONNULL(1, 4);
 
    EAPI void             elm_object_event_callback_add(Evas_Object *obj, Elm_Event_Cb func, const void *data) EINA_ARG_NONNULL(1, 2);
    EAPI void            *elm_object_event_callback_del(Evas_Object *obj, Elm_Event_Cb func, const void *data) EINA_ARG_NONNULL(1, 2);

Modified: trunk/elementary/src/lib/elm_main.c
===================================================================
--- trunk/elementary/src/lib/elm_main.c	2011-07-22 10:50:38 UTC (rev 61585)
+++ trunk/elementary/src/lib/elm_main.c	2011-07-22 11:10:10 UTC (rev 61586)
@@ -3249,7 +3249,7 @@
  * @ingroup General
  */
 EAPI void
-elm_object_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, void (*func) (void *data, Evas_Object *o, const char *emission, const char *source), void *data)
+elm_object_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func, void *data)
 {
     EINA_SAFETY_ON_NULL_RETURN(obj);
     EINA_SAFETY_ON_NULL_RETURN(func);
@@ -3274,7 +3274,7 @@
  * @ingroup General
  */
 EAPI void *
-elm_object_signal_callback_del(Evas_Object *obj, const char *emission, const char *source, void (*func) (void *data, Evas_Object *o, const char *emission, const char *source))
+elm_object_signal_callback_del(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func)
 {
     EINA_SAFETY_ON_NULL_RETURN_VAL(obj, NULL);
     EINA_SAFETY_ON_NULL_RETURN_VAL(func, NULL);

Log:
elm: Fixed document typo.
  

Author:       seoz
Date:         2011-07-24 23:36:59 -0700 (Sun, 24 Jul 2011)
New Revision: 61664
Trac:         http://trac.enlightenment.org/e/changeset/61664

Modified:
  trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-07-25 04:05:58 UTC (rev 61663)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-07-25 06:36:59 UTC (rev 61664)
@@ -2352,9 +2352,9 @@
 }
 
 /**
- * Set the datan item from the gengrid item
+ * Set the data item from the gengrid item
  *
- * This set the data value passed on the elm_gengrid_item_append() and
+ * This sets the data value passed on the elm_gengrid_item_append() and
  * related item addition calls. This function will also call
  * elm_gengrid_item_update() so the item will be updated to reflect
  * the new data.

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-07-25 04:05:58 UTC (rev 61663)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-07-25 06:36:59 UTC (rev 61664)
@@ -4776,7 +4776,7 @@
 /**
  * Set the data item from the genlist item
  *
- * This set the data value passed on the elm_genlist_item_append() and
+ * This sets the data value passed on the elm_genlist_item_append() and
  * related item addition calls. This function will not call
  * elm_genlist_item_update() anymore. So call elm_genlist_item_update()
  * manually only when it's needed.

Log:
elm gengrid: Removed elm_gengrid_item_update() from elm_gengrid_item_data_set(). So please call elm_gengrid_item_update() when you need it.
  
  This change is same as a genlist change in the following link.
  http://www.mail-archive.com/enlightenment-devel@...>
  

Author:       seoz
Date:         2011-07-25 02:02:41 -0700 (Mon, 25 Jul 2011)
New Revision: 61674
Trac:         http://trac.enlightenment.org/e/changeset/61674

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-07-25 08:48:47 UTC (rev 61673)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-07-25 09:02:41 UTC (rev 61674)
@@ -2355,9 +2355,9 @@
  * Set the data item from the gengrid item
  *
  * This sets the data value passed on the elm_gengrid_item_append() and
- * related item addition calls. This function will also call
- * elm_gengrid_item_update() so the item will be updated to reflect
- * the new data.
+ * related item addition calls. This function will not call
+ * elm_gengrid_item_update() anymore. So call elm_gengrid_item_update()
+ * manually only when it's needed.
  *
  * @param item The item
  * @param data The new data pointer to set
@@ -2370,7 +2370,6 @@
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(item);
    elm_widget_item_data_set(item, data);
-   elm_gengrid_item_update(item);
 }
 
 EAPI const Elm_Gengrid_Item_Class *

Log:
elm genscroller: Fixed warnings while raster is not working on this :)
  hooray! lol!
  

Author:       seoz
Date:         2011-07-25 23:07:54 -0700 (Mon, 25 Jul 2011)
New Revision: 61727
Trac:         http://trac.enlightenment.org/e/changeset/61727

Modified:
  trunk/elementary/src/lib/elm_genscroller.c 

Modified: trunk/elementary/src/lib/elm_genscroller.c
===================================================================
--- trunk/elementary/src/lib/elm_genscroller.c	2011-07-26 05:57:32 UTC (rev 61726)
+++ trunk/elementary/src/lib/elm_genscroller.c	2011-07-26 06:07:54 UTC (rev 61727)
@@ -1002,7 +1002,7 @@
 }
 
 EAPI void
-elm_genscroller_world_size_get(Evas_Object *obj, Evas_Coord *w, Evas_Coord *h)
+elm_genscroller_world_size_get(Evas_Object *obj __UNUSED__, Evas_Coord *w __UNUSED__, Evas_Coord *h __UNUSED__)
 {
 }
 
@@ -1017,41 +1017,41 @@
 }
 
 EAPI void
-elm_genscroller_cell_size_get(Evas_Object *obj, int *w, int *h)
+elm_genscroller_cell_size_get(Evas_Object *obj __UNUSED__, int *w __UNUSED__, int *h __UNUSED__)
 {
 }
 
 EAPI void
-elm_genscroller_cell_all_size_set(Evas_Object *obj, Evas_Coord w, Evas_Coord h)
+elm_genscroller_cell_all_size_set(Evas_Object *obj __UNUSED__, Evas_Coord w __UNUSED__, Evas_Coord h __UNUSED__)
 {
 }
 
 EAPI void
-elm_genscroller_cell_row_size_set(Evas_Object *obj, int y, Evas_Coord h)
+elm_genscroller_cell_row_size_set(Evas_Object *obj __UNUSED__, int y __UNUSED__, Evas_Coord h __UNUSED__)
 {
 }
 
 EAPI void
-elm_genscroller_cell_col_size_set(Evas_Object *obj, int x, Evas_Coord w)
+elm_genscroller_cell_col_size_set(Evas_Object *obj __UNUSED__, int x __UNUSED__, Evas_Coord w __UNUSED__)
 {
 }
 
 EAPI void
-elm_genscroller_cell_rows_insert(Evas_Object *obj, int y, int rows)
+elm_genscroller_cell_rows_insert(Evas_Object *obj __UNUSED__, int y __UNUSED__, int rows __UNUSED__)
 {
 }
 
 EAPI void
-elm_genscroller_cell_rows_del(Evas_Object *obj, int y, int rows)
+elm_genscroller_cell_rows_del(Evas_Object *obj __UNUSED__, int y __UNUSED__, int rows __UNUSED__)
 {
 }
 
 EAPI void
-elm_genscroller_cell_cols_insert(Evas_Object *obj, int x, int cols)
+elm_genscroller_cell_cols_insert(Evas_Object *obj __UNUSED__, int x __UNUSED__, int cols __UNUSED__)
 {
 }
 
 EAPI void
-elm_genscroller_cell_cols_del(Evas_Object *obj, int x, int cols)
+elm_genscroller_cell_cols_del(Evas_Object *obj __UNUSED__, int x __UNUSED__, int cols __UNUSED__)
 {
 }

Log:
elm gengrid: Fixed indentation for signal description.
  

Author:       seoz
Date:         2011-07-26 00:00:19 -0700 (Tue, 26 Jul 2011)
New Revision: 61729
Trac:         http://trac.enlightenment.org/e/changeset/61729

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-07-26 06:44:12 UTC (rev 61728)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-07-26 07:00:19 UTC (rev 61729)
@@ -143,24 +143,24 @@
 static const char SIG_MOVED[] = "moved";
 
 static const Evas_Smart_Cb_Description _signals[] = {
-       {SIG_ACTIVATED, ""},
-       {SIG_CLICKED_DOUBLE, ""},
-       {SIG_SELECTED, ""},
-       {SIG_UNSELECTED, ""},
-       {SIG_REALIZED, ""},
-       {SIG_UNREALIZED, ""},
-       {SIG_CHANGED, ""},
-       {SIG_DRAG_START_UP, ""},
-       {SIG_DRAG_START_DOWN, ""},
-       {SIG_DRAG_START_LEFT, ""},
-       {SIG_DRAG_START_RIGHT, ""},
-       {SIG_DRAG_STOP, ""},
-       {SIG_DRAG, ""},
-       {SIG_SCROLL, ""},
-       {SIG_SCROLL_DRAG_START, ""},
-       {SIG_SCROLL_DRAG_STOP, ""},
-       {SIG_MOVED, ""},
-       {NULL, NULL}
+   {SIG_ACTIVATED, ""},
+   {SIG_CLICKED_DOUBLE, ""},
+   {SIG_SELECTED, ""},
+   {SIG_UNSELECTED, ""},
+   {SIG_REALIZED, ""},
+   {SIG_UNREALIZED, ""},
+   {SIG_CHANGED, ""},
+   {SIG_DRAG_START_UP, ""},
+   {SIG_DRAG_START_DOWN, ""},
+   {SIG_DRAG_START_LEFT, ""},
+   {SIG_DRAG_START_RIGHT, ""},
+   {SIG_DRAG_STOP, ""},
+   {SIG_DRAG, ""},
+   {SIG_SCROLL, ""},
+   {SIG_SCROLL_DRAG_START, ""},
+   {SIG_SCROLL_DRAG_STOP, ""},
+   {SIG_MOVED, ""},
+   {NULL, NULL}
 };
 
 static Eina_Compare_Cb _elm_gengrid_item_compare_cb;

Log:
elm tooltip: Fixed warnings.
  

Author:       seoz
Date:         2011-07-26 05:35:54 -0700 (Tue, 26 Jul 2011)
New Revision: 61758
Trac:         http://trac.enlightenment.org/e/changeset/61758

Modified:
  trunk/elementary/src/lib/els_tooltip.c 

Modified: trunk/elementary/src/lib/els_tooltip.c
===================================================================
--- trunk/elementary/src/lib/els_tooltip.c	2011-07-26 12:13:32 UTC (rev 61757)
+++ trunk/elementary/src/lib/els_tooltip.c	2011-07-26 12:35:54 UTC (rev 61758)
@@ -246,7 +246,7 @@
    double rel_x, rel_y;
    Eina_Bool inside_eventarea;
 #ifdef HAVE_ELEMENTARY_X
-   Ecore_X_Window xwin;
+   Ecore_X_Window xwin = 0;
 #endif
 
    _elm_tooltip_reconfigure_job_stop(tt);

Log:
elm Elementary.h.in: Fixed typo.
  

Author:       seoz
Date:         2011-07-26 18:51:27 -0700 (Tue, 26 Jul 2011)
New Revision: 61781
Trac:         http://trac.enlightenment.org/e/changeset/61781

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-07-26 21:36:14 UTC (rev 61780)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-07-27 01:51:27 UTC (rev 61781)
@@ -10693,7 +10693,7 @@
     *
     * @param obj The actionslider object
     * @return The indicator label
-    * @deprecated use elm_object_text_set() instead.
+    * @deprecated use elm_object_text_get() instead.
     */
    EINA_DEPRECATED EAPI const char           *elm_actionslider_indicator_label_get(Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**

Log:
elm Elementary.h.in: Fixed doxygen alignment.
  

Author:       seoz
Date:         2011-07-31 21:01:53 -0700 (Sun, 31 Jul 2011)
New Revision: 61931
Trac:         http://trac.enlightenment.org/e/changeset/61931

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-01 00:49:46 UTC (rev 61930)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-01 04:01:53 UTC (rev 61931)
@@ -12690,7 +12690,7 @@
     *
     * @image html img/widget/genlist/preview-01.png
     * @image latex img/widget/genlist/preview-01.eps
-   *
+    *
     * - icon_top_text_bottom
     *
     * @image html img/widget/genlist/preview-02.png

Log:
elm: Removed trailing whitespaces before I work on.
  

Author:       seoz
Date:         2011-07-31 23:46:43 -0700 (Sun, 31 Jul 2011)
New Revision: 61933
Trac:         http://trac.enlightenment.org/e/changeset/61933

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_menu.c trunk/elementary/src/lib/els_scroller.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-01 05:06:49 UTC (rev 61932)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-01 06:46:43 UTC (rev 61933)
@@ -715,7 +715,7 @@
     *
     * @param obj The Elementary object
     * @param item The content id to set (NULL for the default content)
-    * @param content The new content of the object 
+    * @param content The new content of the object
     *
     * @note Elementary objects may have many contents
     *

Modified: trunk/elementary/src/lib/elm_menu.c
===================================================================
--- trunk/elementary/src/lib/elm_menu.c	2011-08-01 05:06:49 UTC (rev 61932)
+++ trunk/elementary/src/lib/elm_menu.c	2011-08-01 06:46:43 UTC (rev 61933)
@@ -785,7 +785,7 @@
         elm_widget_sub_object_del(item->base.widget, item->content);
         evas_object_del(item->content);
      }
-     
+
    item->content = obj;
 
    elm_widget_sub_object_add(item->base.widget, item->content);

Modified: trunk/elementary/src/lib/els_scroller.c
===================================================================
--- trunk/elementary/src/lib/els_scroller.c	2011-08-01 05:06:49 UTC (rev 61932)
+++ trunk/elementary/src/lib/els_scroller.c	2011-08-01 06:46:43 UTC (rev 61933)
@@ -972,7 +972,7 @@
      edje_object_signal_emit(sd->edje_obj, "elm,action,scroll", "elm");
    if (!sd->down.bounce_x_animator)
      {
-        if (((x < minx) && (0 <= sd->down.dx)) || 
+        if (((x < minx) && (0 <= sd->down.dx)) ||
             ((x > (mx + minx)) && (0 >= sd->down.dx)))
           {
              sd->bouncemex = 1;
@@ -983,7 +983,7 @@
      }
    if (!sd->down.bounce_y_animator)
      {
-        if (((y < miny) && (0 <= sd->down.dy)) || 
+        if (((y < miny) && (0 <= sd->down.dy)) ||
             ((y > (my + miny)) && (0 >= sd->down.dy)))
           {
              sd->bouncemey = 1;

Log:
elm win: Refactoring. Removed unused local variable.
  

Author:       seoz
Date:         2011-07-31 23:49:58 -0700 (Sun, 31 Jul 2011)
New Revision: 61934
Trac:         http://trac.enlightenment.org/e/changeset/61934

Modified:
  trunk/elementary/src/lib/elm_win.c 

Modified: trunk/elementary/src/lib/elm_win.c
===================================================================
--- trunk/elementary/src/lib/elm_win.c	2011-08-01 06:46:43 UTC (rev 61933)
+++ trunk/elementary/src/lib/elm_win.c	2011-08-01 06:49:58 UTC (rev 61934)
@@ -2557,7 +2557,6 @@
 EAPI Ecore_X_Window
 elm_win_xwindow_get(const Evas_Object *obj)
 {
-   Ecore_X_Window xwin = 0;
    Elm_Win *win;
    const char *type;
 
@@ -2567,10 +2566,10 @@
    if (type != widtype) return _elm_ee_win_get(obj);
 #ifdef HAVE_ELEMENTARY_X
    win = elm_widget_data_get(obj);
-   if (!win) return xwin;
+   if (!win) return 0;
    if (win->xwin) return win->xwin;
    if (win->parent) return elm_win_xwindow_get(win->parent);
 #endif
-   return xwin;
+   return 0;
    win = NULL;
 }

Log:
elm genlist: Fixed comment typo.
  

Author:       seoz
Date:         2011-08-01 23:29:54 -0700 (Mon, 01 Aug 2011)
New Revision: 61979
Trac:         http://trac.enlightenment.org/e/changeset/61979

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-08-02 06:19:44 UTC (rev 61978)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-08-02 06:29:54 UTC (rev 61979)
@@ -3596,7 +3596,7 @@
    Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
                                     func_data);
    if (!it) return NULL;
-   /* It make no sense to insert after in an empty list with after != NULL, something really bad is happening in your app. */
+   /* It makes no sense to insert after in an empty list with after != NULL, something really bad is happening in your app. */
    EINA_SAFETY_ON_NULL_RETURN_VAL(wd->items, NULL);
 
    wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),

Log:
elm genlist: Fixed item addition routine for group child items.
  

Author:       seoz
Date:         2011-08-01 23:50:34 -0700 (Mon, 01 Aug 2011)
New Revision: 61980
Trac:         http://trac.enlightenment.org/e/changeset/61980

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-08-02 06:29:54 UTC (rev 61979)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-08-02 06:50:34 UTC (rev 61980)
@@ -3054,6 +3054,14 @@
    it->func.data = func_data;
    it->mouse_cursor = NULL;
    it->expanded_depth = 0;
+
+   if (it->parent)
+     {
+        if (it->parent->flags & ELM_GENLIST_ITEM_GROUP)
+          it->group_item = parent;
+        else if (it->parent->group_item)
+          it->group_item = it->parent->group_item;
+     }
    return it;
 }
 
@@ -3399,11 +3407,6 @@
                                       EINA_INLIST_GET(it2));
         it->rel = it2;
         it->rel->relcount++;
-
-        if (it->parent->flags & ELM_GENLIST_ITEM_GROUP)
-          it->group_item = parent;
-        else if (it->parent->group_item)
-          it->group_item = it->parent->group_item;
      }
    it->before = EINA_FALSE;
    _item_queue(wd, it);
@@ -3467,8 +3470,15 @@
    Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
                                     func_data);
    if (!it) return NULL;
-   if (it->parent)
+   if (!it->parent)
      {
+        if ((flags & ELM_GENLIST_ITEM_GROUP) &&
+            (before->flags & ELM_GENLIST_ITEM_GROUP))
+          wd->group_items = eina_list_prepend_relative(wd->group_items, it,
+                                                       before);
+     }
+   else
+     {
         it->parent->items = eina_list_prepend_relative(it->parent->items, it,
                                                        before);
      }
@@ -3526,11 +3536,6 @@
              wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it), EINA_INLIST_GET(rel));
              it->before = EINA_TRUE;
           }
-
-        if (it->parent->flags & ELM_GENLIST_ITEM_GROUP)
-          it->group_item = parent;
-        else if (it->parent->group_item)
-          it->group_item = it->parent->group_item;
      }
    else
      {
@@ -3601,8 +3606,15 @@
 
    wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
                                            EINA_INLIST_GET(after));
-   if (it->parent)
+   if (!it->parent)
      {
+        if ((flags & ELM_GENLIST_ITEM_GROUP) &&
+            (after->flags & ELM_GENLIST_ITEM_GROUP))
+          wd->group_items = eina_list_append_relative(wd->group_items, it,
+                                                      after);
+     }
+   else
+     {
         it->parent->items = eina_list_append_relative(it->parent->items, it,
                                                       after);
      }

Log:
elm genlist: Added more guard code and moved some codes for the
  readability.
  

Author:       seoz
Date:         2011-08-01 23:54:10 -0700 (Mon, 01 Aug 2011)
New Revision: 61981
Trac:         http://trac.enlightenment.org/e/changeset/61981

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-08-02 06:50:34 UTC (rev 61980)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-08-02 06:54:10 UTC (rev 61981)
@@ -3470,6 +3470,9 @@
    Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
                                     func_data);
    if (!it) return NULL;
+   /* It makes no sense to insert before in an empty list with before != NULL, something really bad is happening in your app. */
+   EINA_SAFETY_ON_NULL_RETURN_VAL(wd->items, NULL);
+
    if (!it->parent)
      {
         if ((flags & ELM_GENLIST_ITEM_GROUP) &&
@@ -3604,8 +3607,6 @@
    /* It makes no sense to insert after in an empty list with after != NULL, something really bad is happening in your app. */
    EINA_SAFETY_ON_NULL_RETURN_VAL(wd->items, NULL);
 
-   wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
-                                           EINA_INLIST_GET(after));
    if (!it->parent)
      {
         if ((flags & ELM_GENLIST_ITEM_GROUP) &&
@@ -3618,6 +3619,8 @@
         it->parent->items = eina_list_append_relative(it->parent->items, it,
                                                       after);
      }
+   wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
+                                           EINA_INLIST_GET(after));
    it->rel = after;
    it->rel->relcount++;
    it->before = EINA_FALSE;

Log:
elm genlist: Refactoring. Moved code for the readability.
  

Author:       seoz
Date:         2011-08-01 23:59:45 -0700 (Mon, 01 Aug 2011)
New Revision: 61983
Trac:         http://trac.enlightenment.org/e/changeset/61983

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-08-02 06:54:55 UTC (rev 61982)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-08-02 06:59:45 UTC (rev 61983)
@@ -3454,6 +3454,47 @@
 }
 
 EAPI Elm_Genlist_Item *
+elm_genlist_item_insert_after(Evas_Object                  *obj,
+                              const Elm_Genlist_Item_Class *itc,
+                              const void                   *data,
+                              Elm_Genlist_Item             *parent,
+                              Elm_Genlist_Item             *after,
+                              Elm_Genlist_Item_Flags        flags,
+                              Evas_Smart_Cb                 func,
+                              const void                   *func_data)
+{
+   ELM_CHECK_WIDTYPE(obj, widtype) NULL;
+   EINA_SAFETY_ON_NULL_RETURN_VAL(after, NULL);
+   Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return NULL;
+   Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
+                                    func_data);
+   if (!it) return NULL;
+   /* It makes no sense to insert after in an empty list with after != NULL, something really bad is happening in your app. */
+   EINA_SAFETY_ON_NULL_RETURN_VAL(wd->items, NULL);
+
+   if (!it->parent)
+     {
+        if ((flags & ELM_GENLIST_ITEM_GROUP) &&
+            (after->flags & ELM_GENLIST_ITEM_GROUP))
+          wd->group_items = eina_list_append_relative(wd->group_items, it,
+                                                      after);
+     }
+   else
+     {
+        it->parent->items = eina_list_append_relative(it->parent->items, it,
+                                                      after);
+     }
+   wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
+                                           EINA_INLIST_GET(after));
+   it->rel = after;
+   it->rel->relcount++;
+   it->before = EINA_FALSE;
+   _item_queue(wd, it);
+   return it;
+}
+
+EAPI Elm_Genlist_Item *
 elm_genlist_item_insert_before(Evas_Object                  *obj,
                                const Elm_Genlist_Item_Class *itc,
                                const void                   *data,
@@ -3587,47 +3628,6 @@
                                                 _elm_genlist_item_compare_data, func, func_data);
 }
 
-EAPI Elm_Genlist_Item *
-elm_genlist_item_insert_after(Evas_Object                  *obj,
-                              const Elm_Genlist_Item_Class *itc,
-                              const void                   *data,
-                              Elm_Genlist_Item             *parent,
-                              Elm_Genlist_Item             *after,
-                              Elm_Genlist_Item_Flags        flags,
-                              Evas_Smart_Cb                 func,
-                              const void                   *func_data)
-{
-   ELM_CHECK_WIDTYPE(obj, widtype) NULL;
-   EINA_SAFETY_ON_NULL_RETURN_VAL(after, NULL);
-   Widget_Data *wd = elm_widget_data_get(obj);
-   if (!wd) return NULL;
-   Elm_Genlist_Item *it = _item_new(wd, itc, data, parent, flags, func,
-                                    func_data);
-   if (!it) return NULL;
-   /* It makes no sense to insert after in an empty list with after != NULL, something really bad is happening in your app. */
-   EINA_SAFETY_ON_NULL_RETURN_VAL(wd->items, NULL);
-
-   if (!it->parent)
-     {
-        if ((flags & ELM_GENLIST_ITEM_GROUP) &&
-            (after->flags & ELM_GENLIST_ITEM_GROUP))
-          wd->group_items = eina_list_append_relative(wd->group_items, it,
-                                                      after);
-     }
-   else
-     {
-        it->parent->items = eina_list_append_relative(it->parent->items, it,
-                                                      after);
-     }
-   wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
-                                           EINA_INLIST_GET(after));
-   it->rel = after;
-   it->rel->relcount++;
-   it->before = EINA_FALSE;
-   _item_queue(wd, it);
-   return it;
-}
-
 EAPI void
 elm_genlist_clear(Evas_Object *obj)
 {

Log:
elm focus: Added elm_object_focus_set() API. Use this instead elm_object_focus/unfocus().
  

Author:       seoz
Date:         2011-08-03 04:46:23 -0700 (Wed, 03 Aug 2011)
New Revision: 62049
Trac:         http://trac.enlightenment.org/e/changeset/62049

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_main.c trunk/elementary/src/lib/elm_notify.c trunk/elementary/src/lib/elm_pager.c trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_win.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-03 11:14:30 UTC (rev 62048)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-03 11:46:23 UTC (rev 62049)
@@ -1144,6 +1144,25 @@
    EAPI Eina_Bool        elm_object_focus_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    /**
+    * Set/unset focus to a given Elementary object.
+    *
+    * @param obj The Elementary object to operate on.
+    * @param enable @c EINA_TRUE Set focus to a given object,
+    *               @c EINA_FALSE Unset focus to a given object.
+    *
+    * @note When you set focus to this object, if it can handle focus, will
+    * take the focus away from the one who had it previously and will, for
+    * now on, be the one receiving input events. Unsetting focus will remove
+    * the focus from @p obj, passing it back to the previous element in the
+    * focus chain list.
+    *
+    * @see elm_object_focus_get(), elm_object_focus_custom_chain_get()
+    *
+    * @ingroup Focus
+    */
+   EAPI void             elm_object_focus_set(Evas_Object *obj, Eina_Bool focus) EINA_ARG_NONNULL(1);
+
+   /**
     * Make a given Elementary object the focused one.
     *
     * @param obj The Elementary object to make focused.
@@ -1153,10 +1172,11 @@
     * the one receiving input events.
     *
     * @see elm_object_focus_get()
+    * @deprecated use elm_object_focus_set() instead.
     *
     * @ingroup Focus
     */
-   EAPI void             elm_object_focus(Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EINA_DEPRECATED EAPI void             elm_object_focus(Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    /**
     * Remove the focus from an Elementary object
@@ -1167,10 +1187,11 @@
     * previous element in the focus chain list.
     *
     * @see elm_object_focus() and elm_object_focus_custom_chain_get()
+    * @deprecated use elm_object_focus_set() instead.
     *
     * @ingroup Focus
     */
-   EAPI void             elm_object_unfocus(Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EINA_DEPRECATED EAPI void             elm_object_unfocus(Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    /**
     * Set the ability for an Element object to be focused

Modified: trunk/elementary/src/lib/elm_main.c
===================================================================
--- trunk/elementary/src/lib/elm_main.c	2011-08-03 11:14:30 UTC (rev 62048)
+++ trunk/elementary/src/lib/elm_main.c	2011-08-03 11:46:23 UTC (rev 62049)
@@ -2256,21 +2256,34 @@
 }
 
 EAPI void
+elm_object_focus_set(Evas_Object *obj,
+                     Eina_Bool    focus)
+{
+   EINA_SAFETY_ON_NULL_RETURN(obj);
+   if (focus)
+     {
+        if (elm_widget_focus_get(obj)) return;
+        elm_widget_focus_cycle(obj, ELM_FOCUS_NEXT);
+     }
+   else
+     {
+        if (!elm_widget_can_focus_get(obj)) return;
+        elm_widget_focused_object_clear(obj);
+     }
+}
+
+EAPI void
 elm_object_focus(Evas_Object *obj)
 {
    EINA_SAFETY_ON_NULL_RETURN(obj);
-   if (elm_widget_focus_get(obj))
-     return;
-
-   elm_widget_focus_cycle(obj, ELM_FOCUS_NEXT);
+   elm_object_focus_set(obj, EINA_TRUE);
 }
 
 EAPI void
 elm_object_unfocus(Evas_Object *obj)
 {
    EINA_SAFETY_ON_NULL_RETURN(obj);
-   if (!elm_widget_can_focus_get(obj)) return;
-   elm_widget_focused_object_clear(obj);
+   elm_object_focus_set(obj, EINA_FALSE);
 }
 
 EAPI void

Modified: trunk/elementary/src/lib/elm_notify.c
===================================================================
--- trunk/elementary/src/lib/elm_notify.c	2011-08-03 11:14:30 UTC (rev 62048)
+++ trunk/elementary/src/lib/elm_notify.c	2011-08-03 11:46:23 UTC (rev 62049)
@@ -363,7 +363,7 @@
    if (!wd->repeat_events)
      evas_object_show(wd->block_events);
    _timer_init(obj, wd);
-   elm_object_focus(obj);
+   elm_object_focus_set(obj, EINA_TRUE);
 }
 
 static void

Modified: trunk/elementary/src/lib/elm_pager.c
===================================================================
--- trunk/elementary/src/lib/elm_pager.c	2011-08-03 11:14:30 UTC (rev 62048)
+++ trunk/elementary/src/lib/elm_pager.c	2011-08-03 11:46:23 UTC (rev 62049)
@@ -177,7 +177,7 @@
         if (wd->oldtop)
           {
              if (elm_object_focus_get(wd->oldtop->content))
-               elm_object_focus(wd->top->content);
+               elm_object_focus_set(wd->top->content, EINA_TRUE);
              if (wd->oldtop->popme)
                edje_object_signal_emit(o, "elm,action,show", "elm");
              else

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-08-03 11:14:30 UTC (rev 62048)
+++ trunk/elementary/src/lib/elm_widget.c	2011-08-03 11:46:23 UTC (rev 62049)
@@ -3036,8 +3036,8 @@
         newest = _newest_focus_order_get(top, &newest_focus_order, can_focus_only);
         if (newest)
           {
-             elm_object_unfocus(newest);
-             elm_object_focus(newest);
+             elm_object_focus_set(newest, EINA_FALSE);
+             elm_object_focus_set(newest, EINA_TRUE);
           }
      }
 }

Modified: trunk/elementary/src/lib/elm_win.c
===================================================================
--- trunk/elementary/src/lib/elm_win.c	2011-08-03 11:14:30 UTC (rev 62048)
+++ trunk/elementary/src/lib/elm_win.c	2011-08-03 11:46:23 UTC (rev 62049)
@@ -414,7 +414,7 @@
 {
    Elm_Win *win = data;
 
-   elm_object_focus(obj);
+   elm_object_focus_set(obj, EINA_TRUE);
    if (win->shot.info) _shot_handle(win);
 }
 
@@ -2489,7 +2489,7 @@
    evas_object_raise(obj);
    evas_object_show(obj);
    edje_object_signal_emit(wd->frm, "elm,action,show", "elm");
-   elm_object_focus(obj);
+   elm_object_focus_set(obj, EINA_TRUE);
 }
 
 EAPI void

Log:
elm genlist: Modified genlist object reference checking.
  
  On Thu, Aug 4, 2011 at 7:11 PM, Hyoyoung Chang
  <hyoyoung.chang@...> wrote:
  > Yeah, you're right.
  > Could review improve version of previous patch?
  > I attached it.
  

Author:       seoz
Date:         2011-08-07 22:42:29 -0700 (Sun, 07 Aug 2011)
New Revision: 62190
Trac:         http://trac.enlightenment.org/e/changeset/62190

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-08-08 00:58:10 UTC (rev 62189)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-08-08 05:42:29 UTC (rev 62190)
@@ -540,12 +540,6 @@
    if (wd->multi_timer) ecore_timer_del(wd->multi_timer);
    if (wd->mode_type) eina_stringshare_del(wd->mode_type);
    if (wd->scr_hold_timer) ecore_timer_del(wd->scr_hold_timer);
-   if (wd->walking > 0)
-     {
-        wd->walking = 0;
-        elm_genlist_clear(obj);
-     }
-
    free(wd);
 }
 
@@ -833,16 +827,10 @@
    it->selected = EINA_TRUE;
    it->wd->selected = eina_list_append(it->wd->selected, it);
 call:
+   evas_object_ref(it->base.widget);
    it->walking++;
    it->wd->walking++;
-   if (it->func.func)
-     {
-        Evas_Object *baseobj = it->base.widget;
-        const char *objtype = NULL;
-        it->func.func((void *)it->func.data, it->base.widget, it);
-        objtype = evas_object_type_get(baseobj);
-        if ((!objtype) || (!strcmp(objtype,""))) return;
-     }
+   if (it->func.func) it->func.func((void *)it->func.data, it->base.widget, it);
    if (!it->delete_me)
      evas_object_smart_callback_call(it->base.widget, SIG_SELECTED, it);
    it->walking--;
@@ -857,6 +845,7 @@
           }
      }
    it->wd->last_selected_item = it;
+   evas_object_unref(it->base.widget);
 }
 
 static void

Log:
elm: Fixed genlist/gengrid callback function pointer typedef name. Follow EFL's naming
  convention. Elm_{widget}_{callback_name}_Cb. I will remove deprecated
  typedefs a week later.
  
  GridItemLabelGetFunc -> Elm_Gengrid_Item_Label_Get_Cb
  GridItemIconGetFunc -> Elm_Gengrid_Item_Icon_Get_Cb
  GridItemStateGetFunc -> Elm_Gengrid_Item_State_Get_Cb
  GridItemDelFunc -> Elm_Gengrid_Item_Del_Cb
  
  GenlistItemLabelGetFunc -> Elm_Genlist_Item_Label_Get_Cb
  GenlistItemIconGetFunc -> Elm_Genlist_Item_Icon_Get_Cb
  GenlistItemStateGetFunc -> Elm_Genlist_Item_State_Get_Cb
  GenlistItemDelFunc -> Elm_Genlist_Item_Del_Cb
  

Author:       seoz
Date:         2011-08-09 19:20:40 -0700 (Tue, 09 Aug 2011)
New Revision: 62272
Trac:         http://trac.enlightenment.org/e/changeset/62272

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-10 01:05:22 UTC (rev 62271)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-10 02:20:40 UTC (rev 62272)
@@ -5972,7 +5972,7 @@
     * of the existing text parts in the Edje group implementing the
     * item's theme. This function @b must return a strdup'()ed string,
     * as the caller will free() it when done. See
-    * #GridItemLabelGetFunc.
+    * #Elm_Gengrid_Item_Label_Get_Cb.
     * - @c func.icon_get - This function is called when an item object
     * is actually created. The @c data parameter will point to the
     * same data passed to elm_gengrid_item_append() and related item
@@ -5982,7 +5982,7 @@
     * item's theme. It must return @c NULL, when no icon is desired,
     * or a valid object handle, otherwise. The object will be deleted
     * by the gengrid on its deletion or when the item is "unrealized".
-    * See #GridItemIconGetFunc.
+    * See #Elm_Gengrid_Item_Icon_Get_Cb.
     * - @c func.state_get - This function is called when an item
     * object is actually created. The @c data parameter will point to
     * the same data passed to elm_gengrid_item_append() and related
@@ -5994,12 +5994,12 @@
     * with @c "elm,state,XXX,active" and @c "elm" as "emission" and
     * "source" arguments, respectively, when the state is true (the
     * default is false), where @c XXX is the name of the (state) part.
-    * See #GridItemStateGetFunc.
+    * See #Elm_Gengrid_Item_State_Get_Cb.
     * - @c func.del - This is called when elm_gengrid_item_del() is
     * called on an item or elm_gengrid_clear() is called on the
     * gengrid. This is intended for use when gengrid items are
     * deleted, so any data attached to the item (e.g. its data
-    * parameter on creation) can be deleted. See #GridItemDelFunc.
+    * parameter on creation) can be deleted. See #Elm_Gengrid_Item_Del_Cb.
     *
     * @section Gengrid_Usage_Hints Usage hints
     *
@@ -6097,11 +6097,16 @@
    typedef struct _Elm_Gengrid_Item_Class Elm_Gengrid_Item_Class; /**< Gengrid item class definition structs */
    typedef struct _Elm_Gengrid_Item_Class_Func Elm_Gengrid_Item_Class_Func; /**< Class functions for gengrid item classes. */
    typedef struct _Elm_Gengrid_Item Elm_Gengrid_Item; /**< Gengrid item handles */
-   typedef char        *(*GridItemLabelGetFunc) (void *data, Evas_Object *obj, const char *part); /**< Label fetching class function for gengrid item classes. */
-   typedef Evas_Object *(*GridItemIconGetFunc)  (void *data, Evas_Object *obj, const char *part); /**< Icon fetching class function for gengrid item classes. */
-   typedef Eina_Bool    (*GridItemStateGetFunc) (void *data, Evas_Object *obj, const char *part); /**< State fetching class function for gengrid item classes. */
-   typedef void         (*GridItemDelFunc)      (void *data, Evas_Object *obj); /**< Deletion class function for gengrid item classes. */
+   typedef char        *(*Elm_Gengrid_Item_Label_Get_Cb) (void *data, Evas_Object *obj, const char *part); /**< Label fetching class function for gengrid item classes. */
+   typedef Evas_Object *(*Elm_Gengrid_Item_Icon_Get_Cb)  (void *data, Evas_Object *obj, const char *part); /**< Icon fetching class function for gengrid item classes. */
+   typedef Eina_Bool    (*Elm_Gengrid_Item_State_Get_Cb) (void *data, Evas_Object *obj, const char *part); /**< State fetching class function for gengrid item classes. */
+   typedef void         (*Elm_Gengrid_Item_Del_Cb)      (void *data, Evas_Object *obj); /**< Deletion class function for gengrid item classes. */
 
+   typedef char        *(*GridItemLabelGetFunc) (void *data, Evas_Object *obj, const char *part); /** DEPRECATED. Use Elm_Gengrid_Item_Label_Get_Cb. */
+   typedef Evas_Object *(*GridItemIconGetFunc)  (void *data, Evas_Object *obj, const char *part); /** DEPRECATED. Use Elm_Gengrid_Item_Icon_Get_Cb. */
+   typedef Eina_Bool    (*GridItemStateGetFunc) (void *data, Evas_Object *obj, const char *part); /** DEPRECATED. Use Elm_Gengrid_Item_State_Get_Cb. */
+   typedef void         (*GridItemDelFunc)      (void *data, Evas_Object *obj); /** DEPRECATED. Use Elm_Gengrid_Item_Del_Cb. */
+
    /**
     * @struct _Elm_Gengrid_Item_Class
     *
@@ -6113,10 +6118,10 @@
         const char             *item_style;
         struct _Elm_Gengrid_Item_Class_Func
           {
-             GridItemLabelGetFunc  label_get;
-             GridItemIconGetFunc   icon_get;
-             GridItemStateGetFunc  state_get;
-             GridItemDelFunc       del;
+             Elm_Gengrid_Item_Label_Get_Cb label_get;
+             Elm_Gengrid_Item_Icon_Get_Cb  icon_get;
+             Elm_Gengrid_Item_State_Get_Cb state_get;
+             Elm_Gengrid_Item_Del_Cb       del;
           } func;
      }; /**< #Elm_Gengrid_Item_Class member definitions */
 
@@ -14419,23 +14424,23 @@
     * - @c label_get - The @c part parameter is the name string of one of the
     *   existing text parts in the Edje group implementing the item's theme.
     *   This function @b must return a strdup'()ed string, as the caller will
-    *   free() it when done. See #GenlistItemLabelGetFunc.
+    *   free() it when done. See #Elm_Genlist_Item_Label_Get_Cb.
     * - @c icon_get - The @c part parameter is the name string of one of the
     *   existing (icon) swallow parts in the Edje group implementing the item's
     *   theme. It must return @c NULL, when no icon is desired, or a valid
     *   object handle, otherwise.  The object will be deleted by the genlist on
     *   its deletion or when the item is "unrealized".  See
-    *   #GenlistItemIconGetFunc.
+    *   #Elm_Genlist_Item_Icon_Get_Cb.
     * - @c func.state_get - The @c part parameter is the name string of one of
     *   the state parts in the Edje group implementing the item's theme. Return
     *   @c EINA_FALSE for false/off or @c EINA_TRUE for true/on. Genlists will
     *   emit a signal to its theming Edje object with @c "elm,state,XXX,active"
     *   and @c "elm" as "emission" and "source" arguments, respectively, when
     *   the state is true (the default is false), where @c XXX is the name of
-    *   the (state) part.  See #GenlistItemStateGetFunc.
+    *   the (state) part.  See #Elm_Genlist_Item_State_Get_Cb.
     * - @c func.del - This is intended for use when genlist items are deleted,
     *   so any data attached to the item (e.g. its data parameter on creation)
-    *   can be deleted. See #GenlistItemDelFunc.
+    *   can be deleted. See #Elm_Genlist_Item_Del_Cb.
     *
     * available item styles:
     * - default
@@ -14710,12 +14715,17 @@
    typedef struct _Elm_Genlist_Item_Class Elm_Genlist_Item_Class;  /**< Genlist item class definition structs */
    typedef struct _Elm_Genlist_Item       Elm_Genlist_Item; /**< Item of Elm_Genlist. Sub-type of Elm_Widget_Item */
    typedef struct _Elm_Genlist_Item_Class_Func Elm_Genlist_Item_Class_Func; /**< Class functions for genlist item class */
-   typedef char        *(*GenlistItemLabelGetFunc) (void *data, Evas_Object *obj, const char *part); /**< Label fetching class function for genlist item classes. */
-   typedef Evas_Object *(*GenlistItemIconGetFunc)  (void *data, Evas_Object *obj, const char *part); /**< Icon fetching class function for genlist item classes. */
-   typedef Eina_Bool    (*GenlistItemStateGetFunc) (void *data, Evas_Object *obj, const char *part); /**< State fetching class function for genlist item classes. */
-   typedef void         (*GenlistItemDelFunc)      (void *data, Evas_Object *obj); /**< Deletion class function for genlist item classes. */
-   typedef void         (*GenlistItemMovedFunc)    (Evas_Object *obj, Elm_Genlist_Item *item, Elm_Genlist_Item *rel_item, Eina_Bool move_after);
+   typedef char        *(*Elm_Genlist_Item_Label_Get_Cb) (void *data, Evas_Object *obj, const char *part); /**< Label fetching class function for genlist item classes. */
+   typedef Evas_Object *(*Elm_Genlist_Item_Icon_Get_Cb)  (void *data, Evas_Object *obj, const char *part); /**< Icon fetching class function for genlist item classes. */
+   typedef Eina_Bool    (*Elm_Genlist_Item_State_Get_Cb) (void *data, Evas_Object *obj, const char *part); /**< State fetching class function for genlist item classes. */
+   typedef void         (*Elm_Genlist_Item_Del_Cb)      (void *data, Evas_Object *obj); /**< Deletion class function for genlist item classes. */
+   typedef void         (*GenlistItemMovedFunc)    (Evas_Object *obj, Elm_Genlist_Item *item, Elm_Genlist_Item *rel_item, Eina_Bool move_after); /** TODO: remove this by SeoZ **/
 
+   typedef char        *(*GenlistItemLabelGetFunc) (void *data, Evas_Object *obj, const char *part); /** DEPRECATED. Use Elm_Genlist_Item_Label_Get_Cb instead. */
+   typedef Evas_Object *(*GenlistItemIconGetFunc)  (void *data, Evas_Object *obj, const char *part); /** DEPRECATED. Use Elm_Genlist_Item_Icon_Get_Cb instead. */
+   typedef Eina_Bool    (*GenlistItemStateGetFunc) (void *data, Evas_Object *obj, const char *part); /** DEPRECATED. Use Elm_Genlist_Item_State_Get_Cb instead. */
+   typedef void         (*GenlistItemDelFunc)      (void *data, Evas_Object *obj); /** DEPRECATED. Use Elm_Genlist_Item_Del_Cb instead. */
+
    /**
     * @struct _Elm_Genlist_Item_Class
     *
@@ -14731,10 +14741,10 @@
         const char                *item_style; /**< style of this class. */
         struct
           {
-             GenlistItemLabelGetFunc  label_get; /**< Label fetching class function for genlist item classes.*/
-             GenlistItemIconGetFunc   icon_get; /**< Icon fetching class function for genlist item classes. */
-             GenlistItemStateGetFunc  state_get; /**< State fetching class function for genlist item classes. */
-             GenlistItemDelFunc       del; /**< Deletion class function for genlist item classes. */
+             Elm_Genlist_Item_Label_Get_Cb  label_get; /**< Label fetching class function for genlist item classes.*/
+             Elm_Genlist_Item_Icon_Get_Cb   icon_get; /**< Icon fetching class function for genlist item classes. */
+             Elm_Genlist_Item_State_Get_Cb  state_get; /**< State fetching class function for genlist item classes. */
+             Elm_Genlist_Item_Del_Cb        del; /**< Deletion class function for genlist item classes. */
              GenlistItemMovedFunc     moved; // TODO: do not use this. change this to smart callback.
           } func;
         const char                *mode_item_style;

Log:
elm Elementary.h.in: Refactoring. Removed trailing whitespaces before
  I work on.
  

Author:       seoz
Date:         2011-08-10 17:42:29 -0700 (Wed, 10 Aug 2011)
New Revision: 62325
Trac:         http://trac.enlightenment.org/e/changeset/62325

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-10 23:55:40 UTC (rev 62324)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-11 00:42:29 UTC (rev 62325)
@@ -176,7 +176,7 @@
  * There is a more advanced way of making use of the quicklaunch infrastructure
  * in Elementary (which will not be covered here due to its more advanced
  * nature).
- * 
+ *
  * Now let's actually create an interactive "Hello World" gui that you can
  * click the ok button to exit. It's more code because this now does something
  * much more significant, but it's still very simple:
@@ -195,20 +195,20 @@
 elm_main(int argc, char **argv)
 {
    Evas_Object *win, *bg, *box, *lab, *btn;
-   
+
    // new window - do the usual and give it a name, title and delete handler
    win = elm_win_add(NULL, "hello", ELM_WIN_BASIC);
    elm_win_title_set(win, "Hello");
    // when the user clicks "close" on a window there is a request to delete
    evas_object_smart_callback_add(win, "delete,request", on_done, NULL);
-   
+
    // add a standard bg
    bg = elm_bg_add(win);
    // add object as a resize object for the window (controls window minimum
    // size as well as gets resized if window is resized)
    elm_win_resize_object_add(win, bg);
    evas_object_show(bg);
-   
+
    // add a box object - default is vertical. a box holds children in a row,
    // either horizontally or vertically. nothing more.
    box = elm_box_add(win);
@@ -218,7 +218,7 @@
    // size as well as gets resized if window is resized)
    elm_win_resize_object_add(win, box);
    evas_object_show(box);
-   
+
    // add a label widget, set the text and put it in the pad frame
    lab = elm_label_add(win);
    // set default text of the label
@@ -226,7 +226,7 @@
    // pack the label at the end of the box
    elm_box_pack_end(box, lab);
    evas_object_show(lab);
-   
+
    // add an ok button
    btn = elm_button_add(win);
    // set default text of button to "OK"
@@ -236,17 +236,17 @@
    evas_object_show(btn);
    // call on_done when button is clicked
    evas_object_smart_callback_add(btn, "clicked", on_done, NULL);
-   
+
    // now we are done, show the window
    evas_object_show(win);
-   
+
    // run the mainloop and process events and callbacks
    elm_run();
    return 0;
 }
 ELM_MAIN()
 @endcode
-   * 
+   *
    */
 
 /**
@@ -1075,7 +1075,7 @@
     */
 
    /**
-    * @brief Flush all caches. 
+    * @brief Flush all caches.
     *
     * Frees all data that was in cache and is not currently being used to reduce
     * memory usage. This frees Edje's, Evas' and Eet's cache. This is equivalent
@@ -26102,7 +26102,7 @@
    EAPI Evas_Object *elm_factory_add(Evas_Object *parent);
    EAPI void         elm_factory_content_set(Evas_Object *obj, Evas_Object *content);
    EAPI Evas_Object *elm_factory_content_get(const Evas_Object *obj);
-   
+
    EAPI Evas_Object *elm_video_add(Evas_Object *parent);
    EAPI void elm_video_file_set(Evas_Object *video, const char *filename);
    EAPI void elm_video_uri_set(Evas_Object *video, const char *uri);

Log:
elm Elementary.h.in: Moved the documents to the right place.
  

Author:       seoz
Date:         2011-08-10 17:54:28 -0700 (Wed, 10 Aug 2011)
New Revision: 62326
Trac:         http://trac.enlightenment.org/e/changeset/62326

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-11 00:42:29 UTC (rev 62325)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-11 00:54:28 UTC (rev 62326)
@@ -26103,6 +26103,25 @@
    EAPI void         elm_factory_content_set(Evas_Object *obj, Evas_Object *content);
    EAPI Evas_Object *elm_factory_content_get(const Evas_Object *obj);
 
+   /**
+    * @defgroup Video Video
+    *
+    * This object display an player that let you control an Elm_Video
+    * object. It take care of updating it's content according to what is
+    * going on inside the Emotion object. It does activate the remember
+    * function on the linked Elm_Video object.
+    *
+    * Signals that you cann add callback for are :
+    *
+    * "forward,clicked" - the user clicked the forward button.
+    * "info,clicked" - the user clicked the info button.
+    * "next,clicked" - the user clicked the next button.
+    * "pause,clicked" - the user clicked the pause button.
+    * "play,clicked" - the user clicked the play button.
+    * "prev,clicked" - the user clicked the prev button.
+    * "rewind,clicked" - the user clicked the rewind button.
+    * "stop,clicked" - the user clicked the stop button.
+    */
    EAPI Evas_Object *elm_video_add(Evas_Object *parent);
    EAPI void elm_video_file_set(Evas_Object *video, const char *filename);
    EAPI void elm_video_uri_set(Evas_Object *video, const char *uri);
@@ -26143,26 +26162,6 @@
    EAPI void                elm_naviframe_item_title_visible_set(Elm_Object_Item *it, Eina_Bool visible) EINA_ARG_NONNULL(1);
    EAPI Eina_Bool           elm_naviframe_item_title_visible_get(const Elm_Object_Item *it) EINA_ARG_NONNULL(1);
 
-   /**
-    * @defgroup Video Video
-    *
-    * This object display an player that let you control an Elm_Video
-    * object. It take care of updating it's content according to what is
-    * going on inside the Emotion object. It does activate the remember
-    * function on the linked Elm_Video object.
-    *
-    * Signals that you cann add callback for are :
-    *
-    * "forward,clicked" - the user clicked the forward button.
-    * "info,clicked" - the user clicked the info button.
-    * "next,clicked" - the user clicked the next button.
-    * "pause,clicked" - the user clicked the pause button.
-    * "play,clicked" - the user clicked the play button.
-    * "prev,clicked" - the user clicked the prev button.
-    * "rewind,clicked" - the user clicked the rewind button.
-    * "stop,clicked" - the user clicked the stop button.
-    */
-
 #ifdef __cplusplus
 }
 #endif

Log:
elm Elementary.h.in: Fixed doxygen typo.
  

Author:       seoz
Date:         2011-08-13 09:42:39 -0700 (Sat, 13 Aug 2011)
New Revision: 62425
Trac:         http://trac.enlightenment.org/e/changeset/62425

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-13 16:36:44 UTC (rev 62424)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-13 16:42:39 UTC (rev 62425)
@@ -4634,12 +4634,12 @@
     */
    EAPI Eina_Bool             elm_icon_no_scale_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
-    * Set if the object is (up/down) resizeable.
+    * Set if the object is (up/down) resizable.
     *
     * @param obj The icon object
-    * @param scale_up A bool to set if the object is resizeable up. Default is
+    * @param scale_up A bool to set if the object is resizable up. Default is
     * @c EINA_TRUE.
-    * @param scale_down A bool to set if the object is resizeable down. Default
+    * @param scale_down A bool to set if the object is resizable down. Default
     * is @c EINA_TRUE.
     *
     * This function limits the icon object resize ability. If @p scale_up is set to
@@ -4652,11 +4652,11 @@
     */
    EAPI void                  elm_icon_scale_set(Evas_Object *obj, Eina_Bool scale_up, Eina_Bool scale_down) EINA_ARG_NONNULL(1);
    /**
-    * Get if the object is (up/down) resizeable.
+    * Get if the object is (up/down) resizable.
     *
     * @param obj The icon object
-    * @param scale_up A bool to set if the object is resizeable up
-    * @param scale_down A bool to set if the object is resizeable down
+    * @param scale_up A bool to set if the object is resizable up
+    * @param scale_down A bool to set if the object is resizable down
     *
     * @see elm_icon_scale_set()
     *
@@ -5007,12 +5007,12 @@
     */
    EAPI Eina_Bool        elm_image_no_scale_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
-    * Set if the object is (up/down) resizeable.
+    * Set if the object is (up/down) resizable.
     *
     * @param obj The image object
-    * @param scale_up A bool to set if the object is resizeable up. Default is
+    * @param scale_up A bool to set if the object is resizable up. Default is
     * @c EINA_TRUE.
-    * @param scale_down A bool to set if the object is resizeable down. Default
+    * @param scale_down A bool to set if the object is resizable down. Default
     * is @c EINA_TRUE.
     *
     * This function limits the image resize ability. If @p scale_up is set to
@@ -5025,11 +5025,11 @@
     */
    EAPI void             elm_image_scale_set(Evas_Object *obj, Eina_Bool scale_up, Eina_Bool scale_down) EINA_ARG_NONNULL(1);
    /**
-    * Get if the object is (up/down) resizeable.
+    * Get if the object is (up/down) resizable.
     *
     * @param obj The image object
-    * @param scale_up A bool to set if the object is resizeable up
-    * @param scale_down A bool to set if the object is resizeable down
+    * @param scale_up A bool to set if the object is resizable up
+    * @param scale_down A bool to set if the object is resizable down
     *
     * @see elm_image_scale_set()
     *

Log:
elm Elementary.h.in: Fixed typo in documentation.
  

Author:       seoz
Date:         2011-08-18 09:59:51 -0700 (Thu, 18 Aug 2011)
New Revision: 62570
Trac:         http://trac.enlightenment.org/e/changeset/62570

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-18 15:05:57 UTC (rev 62569)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-18 16:59:51 UTC (rev 62570)
@@ -65,7 +65,7 @@
  *
  * To use autotools (which helps in many ways in the long run, like being able
  * to immediately create releases of your software directly from your tree
- * and ensure everything needed to buiuld it is there) you will need a
+ * and ensure everything needed to build it is there) you will need a
  * configure.ac, Makefile.am and autogen.sh file.
  *
  * configure.ac:
@@ -507,7 +507,7 @@
     */
     typedef enum _Elm_Policy
     {
-        ELM_POLICY_QUIT, /**< under which circunstances the application
+        ELM_POLICY_QUIT, /**< under which circumstances the application
                           * should quit automatically. @see
                           * Elm_Policy_Quit.
                           */
@@ -593,7 +593,7 @@
     * @return The init counter value.
     *
     * This function initializes Elementary and increments a counter of
-    * the number of calls to it. It returs the new counter's value.
+    * the number of calls to it. It returns the new counter's value.
     *
     * @warning This call is exported only for use by the @c ELM_MAIN()
     * macro. There is no need to use this if you use this macro (which
@@ -2819,7 +2819,7 @@
    EAPI void             elm_object_signal_callback_add(Evas_Object *obj, const char *emission, const char *source, Edje_Signal_Cb func, void *data) EINA_ARG_NONNULL(1, 4);
 
    /**
-    * Remove a signal-triggered callback from an widget edje object.
+    * Remove a signal-triggered callback from a widget edje object.
     *
     * This function removes a callback, previoulsy attached to a
     * signal emitted by the edje object of the obj.  The parameters
@@ -2890,7 +2890,7 @@
    EAPI void             elm_object_event_callback_add(Evas_Object *obj, Elm_Event_Cb func, const void *data) EINA_ARG_NONNULL(1, 2);
 
    /**
-    * Remove a event callback from an widget.
+    * Remove an event callback from a widget.
     *
     * This function removes a callback, previoulsy attached to event emission
     * by the @p obj.

Log:
elm: Removed trailing whitespaces.
  
  I always try to maintain elm with no trailing whitespaces. Please do not commit trailing whitespaces anymore.
  I think maintaining a library clean is a good job. Once it gets mess, it's hard to fix them all at once.
  1. Removing trailing whitespaces.
  2. Fixing indentations.
  3. Removing build errors and warnings.
  

Author:       seoz
Date:         2011-08-19 08:26:04 -0700 (Fri, 19 Aug 2011)
New Revision: 62595
Trac:         http://trac.enlightenment.org/e/changeset/62595

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_access.c trunk/elementary/src/lib/elm_button.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-19 15:18:04 UTC (rev 62594)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-19 15:26:04 UTC (rev 62595)
@@ -6922,10 +6922,10 @@
     * Current page means the page which meet the top-left of the viewport.
     * If there are two or more pages in the viewport, it returns the number of page
     * which meet the top-left of the viewport.
-    * 
-    * @see elm_scroller_last_page_get() 
-    * @see elm_scroller_page_show() 
-    * @see elm_scroller_page_brint_in() 
+    *
+    * @see elm_scroller_last_page_get()
+    * @see elm_scroller_page_show()
+    * @see elm_scroller_page_brint_in()
     */
    EAPI void         elm_scroller_current_page_get(Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
    /**
@@ -6938,9 +6938,9 @@
     * The page number starts from 0. 0 is the first page.
     * This returns the last page number among the pages.
     *
-    * @see elm_scroller_current_page_get() 
-    * @see elm_scroller_page_show() 
-    * @see elm_scroller_page_brint_in() 
+    * @see elm_scroller_current_page_get()
+    * @see elm_scroller_page_show()
+    * @see elm_scroller_page_brint_in()
     */
    EAPI void         elm_scroller_last_page_get(Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
    /**

Modified: trunk/elementary/src/lib/elm_access.c
===================================================================
--- trunk/elementary/src/lib/elm_access.c	2011-08-19 15:18:04 UTC (rev 62594)
+++ trunk/elementary/src/lib/elm_access.c	2011-08-19 15:26:04 UTC (rev 62595)
@@ -111,7 +111,7 @@
 _access_obj_del_cb(void *data, Evas *e __UNUSED__, Evas_Object *obj, void *event_info __UNUSED__)
 {
    Elm_Access_Info *ac;
-   
+
    evas_object_event_callback_del_full(obj, EVAS_CALLBACK_MOUSE_IN,
                                        _access_obj_mouse_in_cb, data);
    evas_object_event_callback_del_full(obj, EVAS_CALLBACK_MOUSE_OUT,
@@ -178,7 +178,7 @@
 {
    Elm_Access_Item *ai;
    Eina_List *l;
-   
+
    if (!ac) return NULL;
    EINA_LIST_FOREACH(ac->items, l, ai)
      {
@@ -266,7 +266,7 @@
 _elm_access_object_register(Evas_Object *obj, Evas_Object *hoverobj)
 {
    Elm_Access_Info *ac;
-   
+
    evas_object_event_callback_add(hoverobj, EVAS_CALLBACK_MOUSE_IN,
                                   _access_obj_mouse_in_cb, obj);
    evas_object_event_callback_add(hoverobj, EVAS_CALLBACK_MOUSE_OUT,

Modified: trunk/elementary/src/lib/elm_button.c
===================================================================
--- trunk/elementary/src/lib/elm_button.c	2011-08-19 15:18:04 UTC (rev 62594)
+++ trunk/elementary/src/lib/elm_button.c	2011-08-19 15:26:04 UTC (rev 62595)
@@ -212,7 +212,7 @@
         wd->timer = NULL;
      }
    wd->repeating = EINA_FALSE;
-   if ((_elm_config->access_mode == ELM_ACCESS_MODE_OFF) || 
+   if ((_elm_config->access_mode == ELM_ACCESS_MODE_OFF) ||
        (_elm_access_2nd_click_timeout(obj)))
      {
         if (_elm_config->access_mode != ELM_ACCESS_MODE_OFF)
@@ -382,7 +382,7 @@
    // TODO: convert Elementary to subclassing of Evas_Smart_Class
    // TODO: and save some bytes, making descriptions per-class and not instance!
    evas_object_smart_callbacks_descriptions_set(obj, _signals);
-   
+
    _elm_access_object_register(obj, wd->btn);
    _elm_access_text_set(_elm_access_object_get(obj),
                         ELM_ACCESS_TYPE, E_("Button"));

Log:
elm Elementary.h.in: Updated authors.
  

Author:       seoz
Date:         2011-08-22 18:44:46 -0700 (Mon, 22 Aug 2011)
New Revision: 62707
Trac:         http://trac.enlightenment.org/e/changeset/62707

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-22 23:40:05 UTC (rev 62706)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-23 01:44:46 UTC (rev 62707)
@@ -293,6 +293,10 @@
 @author Shinwoo Kim <kimcinoo@...>
 @author Govindaraju SM <govi.sm@...> <govism@...>
 @author Prince Kumar Dubey <prince.dubey@...> <prince.dubey@...>
+@author Sung W. Park <sungwoo@...>
+@author Thierry el Borgi <thierry@...>
+@author Shilpa Singh <shilpa.singh@...> <shilpasingh.o@...>
+@author Chanwook Jung <joey.jung@...>
 
 Please contact <enlightenment-devel@...> to get in
 contact with the developers and maintainers.

Log:
elm genlist: Added "scroll,anim,start", "scroll,anim,stop",
  "scroll,drag,start", "scroll,drag,stop" smart callbacks to genlist.
  elm gengrid: Added "scroll,anim,start", "scroll,anim,stop" smart
  callbacks to genlist.
  

Author:       seoz
Date:         2011-08-22 21:02:26 -0700 (Mon, 22 Aug 2011)
New Revision: 62710
Trac:         http://trac.enlightenment.org/e/changeset/62710

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-23 03:28:27 UTC (rev 62709)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-23 04:02:26 UTC (rev 62710)
@@ -7747,6 +7747,10 @@
     * - @c "changed" - Called when an item is added, removed, resized
     *   or moved and when the gengrid is resized or gets "horizontal"
     *   property changes.
+    * - @c "scroll,anim,start" - This is called when scrolling animation has
+    *   started.
+    * - @c "scroll,anim,stop" - This is called when scrolling animation has
+    *   stopped.
     * - @c "drag,start,up" - Called when the item in the gengrid has
     *   been dragged (not scrolled) up.
     * - @c "drag,start,down" - Called when the item in the gengrid has
@@ -16634,6 +16638,14 @@
     * - @c "drag" - This is called when the item in the list is being dragged.
     * - @c "longpressed" - This is called when the item is pressed for a certain
     *   amount of time. By default it's 1 second.
+    * - @c "scroll,anim,start" - This is called when scrolling animation has
+    *   started.
+    * - @c "scroll,anim,stop" - This is called when scrolling animation has
+    *   stopped.
+    * - @c "scroll,drag,start" - This is called when dragging the content has
+    *   started.
+    * - @c "scroll,drag,stop" - This is called when dragging the content has
+    *   stopped.
     * - @c "scroll,edge,top" - This is called when the genlist is scrolled until
     *   the top edge.
     * - @c "scroll,edge,bottom" - This is called when the genlist is scrolled

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-08-23 03:28:27 UTC (rev 62709)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-08-23 04:02:26 UTC (rev 62710)
@@ -139,6 +139,8 @@
 static const char SIG_DRAG_STOP[] = "drag,stop";
 static const char SIG_DRAG[] = "drag";
 static const char SIG_SCROLL[] = "scroll";
+static const char SIG_SCROLL_ANIM_START[] = "scroll,anim,start";
+static const char SIG_SCROLL_ANIM_STOP[] = "scroll,anim,stop";
 static const char SIG_SCROLL_DRAG_START[] = "scroll,drag,start";
 static const char SIG_SCROLL_DRAG_STOP[] = "scroll,drag,stop";
 static const char SIG_MOVED[] = "moved";
@@ -158,6 +160,8 @@
    {SIG_DRAG_STOP, ""},
    {SIG_DRAG, ""},
    {SIG_SCROLL, ""},
+   {SIG_SCROLL_ANIM_START, ""},
+   {SIG_SCROLL_ANIM_STOP, ""},
    {SIG_SCROLL_DRAG_START, ""},
    {SIG_SCROLL_DRAG_STOP, ""},
    {SIG_MOVED, ""},
@@ -1585,6 +1589,22 @@
 }
 
 static void
+_scr_anim_start(void        *data,
+                Evas_Object *obj __UNUSED__,
+                void        *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_ANIM_START, NULL);
+}
+
+static void
+_scrl_anim_stop(void        *data,
+                Evas_Object *obj __UNUSED__,
+                void        *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_ANIM_STOP, NULL);
+}
+
+static void
 _scr_drag_start(void            *data,
                 Evas_Object *obj __UNUSED__,
                 void *event_info __UNUSED__)
@@ -1655,6 +1675,8 @@
                                        "default");
    elm_widget_resize_object_set(obj, wd->scr);
 
+   evas_object_smart_callback_add(wd->scr, "animate,start", _scroll_anim_start, obj);
+   evas_object_smart_callback_add(wd->scr, "animate,stop", _scroll_anim_stop, obj);
    evas_object_smart_callback_add(wd->scr, "drag,start", _scr_drag_start, obj);
    evas_object_smart_callback_add(wd->scr, "drag,stop", _scr_drag_stop, obj);
    evas_object_smart_callback_add(wd->scr, "scroll", _scr_scroll, obj);

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-08-23 03:28:27 UTC (rev 62709)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-08-23 04:02:26 UTC (rev 62710)
@@ -245,6 +245,10 @@
 static const char SIG_DRAG_STOP[] = "drag,stop";
 static const char SIG_DRAG[] = "drag";
 static const char SIG_LONGPRESSED[] = "longpressed";
+static const char SIG_SCROLL_ANIM_START[] = "scroll,anim,start";
+static const char SIG_SCROLL_ANIM_STOP[] = "scroll,anim,stop";
+static const char SIG_SCROLL_DRAG_START[] = "scroll,drag,start";
+static const char SIG_SCROLL_DRAG_STOP[] = "scroll,drag,stop";
 static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top";
 static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom";
 static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left";
@@ -275,6 +279,10 @@
    {SIG_DRAG_STOP, ""},
    {SIG_DRAG, ""},
    {SIG_LONGPRESSED, ""},
+   {SIG_SCROLL_ANIM_START, ""},
+   {SIG_SCROLL_ANIM_STOP, ""},
+   {SIG_SCROLL_DRAG_START, ""},
+   {SIG_SCROLL_DRAG_STOP, ""},
    {SIG_SCROLL_EDGE_TOP, ""},
    {SIG_SCROLL_EDGE_BOTTOM, ""},
    {SIG_SCROLL_EDGE_LEFT, ""},
@@ -2766,6 +2774,38 @@
 }
 
 static void
+_scr_anim_start(void        *data,
+                Evas_Object *obj __UNUSED__,
+                void        *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_ANIM_START, NULL);
+}
+
+static void
+_scr_anim_stop(void        *data,
+               Evas_Object *obj __UNUSED__,
+               void        *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_ANIM_STOP, NULL);
+}
+
+static void
+_scr_drag_start(void            *data,
+                Evas_Object     *obj __UNUSED__,
+                void            *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_DRAG_START, NULL);
+}
+
+static void
+_scr_drag_stop(void            *data,
+               Evas_Object     *obj __UNUSED__,
+               void            *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_DRAG_STOP, NULL);
+}
+
+static void
 _scroll_edge_left(void        *data,
                   Evas_Object *scr __UNUSED__,
                   void        *event_info __UNUSED__)
@@ -3002,6 +3042,10 @@
                                        _elm_config->thumbscroll_bounce_enable);
    elm_widget_resize_object_set(obj, wd->scr);
 
+   evas_object_smart_callback_add(wd->scr, "animate,start", _scr_anim_start, obj);
+   evas_object_smart_callback_add(wd->scr, "animate,stop", _scr_anim_stop, obj);
+   evas_object_smart_callback_add(wd->scr, "drag,start", _scr_drag_start, obj);
+   evas_object_smart_callback_add(wd->scr, "drag,stop", _scr_drag_stop, obj);
    evas_object_smart_callback_add(wd->scr, "edge,left", _scroll_edge_left, obj);
    evas_object_smart_callback_add(wd->scr, "edge,right", _scroll_edge_right,
                                   obj);

Log:
elm gengrid: Oops, I added more changes to the previous commit.
  

Author:       seoz
Date:         2011-08-22 21:04:44 -0700 (Mon, 22 Aug 2011)
New Revision: 62711
Trac:         http://trac.enlightenment.org/e/changeset/62711

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-08-23 04:02:26 UTC (rev 62710)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-08-23 04:04:44 UTC (rev 62711)
@@ -1597,7 +1597,7 @@
 }
 
 static void
-_scrl_anim_stop(void        *data,
+_scr_anim_stop(void        *data,
                 Evas_Object *obj __UNUSED__,
                 void        *event_info __UNUSED__)
 {
@@ -1675,8 +1675,8 @@
                                        "default");
    elm_widget_resize_object_set(obj, wd->scr);
 
-   evas_object_smart_callback_add(wd->scr, "animate,start", _scroll_anim_start, obj);
-   evas_object_smart_callback_add(wd->scr, "animate,stop", _scroll_anim_stop, obj);
+   evas_object_smart_callback_add(wd->scr, "animate,start", _scr_anim_start, obj);
+   evas_object_smart_callback_add(wd->scr, "animate,stop", _scr_anim_stop, obj);
    evas_object_smart_callback_add(wd->scr, "drag,start", _scr_drag_start, obj);
    evas_object_smart_callback_add(wd->scr, "drag,stop", _scr_drag_stop, obj);
    evas_object_smart_callback_add(wd->scr, "scroll", _scr_scroll, obj);

Log:
elm entry/label: Changed internal function name to the right one.
  

Author:       seoz
Date:         2011-08-23 05:22:47 -0700 (Tue, 23 Aug 2011)
New Revision: 62718
Trac:         http://trac.enlightenment.org/e/changeset/62718

Modified:
  trunk/elementary/src/lib/elm_entry.c trunk/elementary/src/lib/elm_label.c 

Modified: trunk/elementary/src/lib/elm_entry.c
===================================================================
--- trunk/elementary/src/lib/elm_entry.c	2011-08-23 12:04:52 UTC (rev 62717)
+++ trunk/elementary/src/lib/elm_entry.c	2011-08-23 12:22:47 UTC (rev 62718)
@@ -570,7 +570,7 @@
 }
 
 static void
-_elm_win_recalc_job(void *data)
+_elm_deferred_recalc_job(void *data)
 {
    Widget_Data *wd = elm_widget_data_get(data);
    Evas_Coord minh = -1, resw = -1, minw = -1, fw = 0, fh = 0;
@@ -681,7 +681,7 @@
         else
           {
              if (wd->deferred_recalc_job) ecore_job_del(wd->deferred_recalc_job);
-             wd->deferred_recalc_job = ecore_job_add(_elm_win_recalc_job, obj);
+             wd->deferred_recalc_job = ecore_job_add(_elm_deferred_recalc_job, obj);
           }
      }
    else

Modified: trunk/elementary/src/lib/elm_label.c
===================================================================
--- trunk/elementary/src/lib/elm_label.c	2011-08-23 12:04:52 UTC (rev 62717)
+++ trunk/elementary/src/lib/elm_label.c	2011-08-23 12:22:47 UTC (rev 62718)
@@ -35,7 +35,7 @@
 static void _label_sliding_change(Evas_Object *obj);
 
 static void
-_elm_win_recalc_job(void *data)
+_elm_recalc_job(void *data)
 {
    Widget_Data *wd = elm_widget_data_get(data);
    Evas_Coord minw = -1, minh = -1;
@@ -123,10 +123,10 @@
         if ((resw == wd->lastw) && (!wd->changed)) return;
         wd->changed = EINA_FALSE;
         wd->lastw = resw;
-        _elm_win_recalc_job(obj);
+        _elm_recalc_job(obj);
         // FIXME: works ok. but NOT for genlist. what should genlist do?
         //        if (wd->deferred_recalc_job) ecore_job_del(wd->deferred_recalc_job);
-        //        wd->deferred_recalc_job = ecore_job_add(_elm_win_recalc_job, obj);
+        //        wd->deferred_recalc_job = ecore_job_add(_elm_recalc_job, obj);
      }
    else
      {

Log:
elm toolbar: Fixed build warnings.
  

Author:       seoz
Date:         2011-08-24 01:10:48 -0700 (Wed, 24 Aug 2011)
New Revision: 62736
Trac:         http://trac.enlightenment.org/e/changeset/62736

Modified:
  trunk/elementary/src/lib/elm_toolbar.c 

Modified: trunk/elementary/src/lib/elm_toolbar.c
===================================================================
--- trunk/elementary/src/lib/elm_toolbar.c	2011-08-24 07:02:26 UTC (rev 62735)
+++ trunk/elementary/src/lib/elm_toolbar.c	2011-08-24 08:10:48 UTC (rev 62736)
@@ -637,7 +637,7 @@
 _access_info_cb(void *data __UNUSED__, Evas_Object *obj __UNUSED__, Elm_Widget_Item *item __UNUSED__)
 {
    Elm_Toolbar_Item *it = (Elm_Toolbar_Item *)item;
-   char *txt = item->access_info;
+   char *txt = (char *)item->access_info;
    if (!txt) txt = (char *)it->label;
    if (txt) return strdup(txt);
    return txt;

Log:
elm: Removed trailing whitespaces.
  
  Raster finished accessibility. So I fixed it too.
  

Author:       seoz
Date:         2011-08-24 01:11:58 -0700 (Wed, 24 Aug 2011)
New Revision: 62737
Trac:         http://trac.enlightenment.org/e/changeset/62737

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_access.c trunk/elementary/src/lib/elm_check.c trunk/elementary/src/lib/elm_toolbar.c trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-24 08:10:48 UTC (rev 62736)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-24 08:11:58 UTC (rev 62737)
@@ -1082,8 +1082,8 @@
     * @ingroup General
     */
    EAPI void elm_object_item_access_info_set(Elm_Object_Item *it, const char *txt);
-         
 
+
 #define elm_object_item_text_get(it) elm_object_item_text_part_get((it), NULL)
 
    /**

Modified: trunk/elementary/src/lib/elm_access.c
===================================================================
--- trunk/elementary/src/lib/elm_access.c	2011-08-24 08:10:48 UTC (rev 62736)
+++ trunk/elementary/src/lib/elm_access.c	2011-08-24 08:11:58 UTC (rev 62737)
@@ -177,7 +177,7 @@
 {
    Evas_Coord x, y;
    Evas_Object *o;
-   
+
    o = evas_object_name_find(evas_object_evas_get(obj), "_elm_access_disp");
    if (!o) return;
    evas_object_geometry_get(obj, &x, &y, NULL, NULL);
@@ -189,7 +189,7 @@
 {
    Evas_Coord w, h;
    Evas_Object *o;
-   
+
    o = evas_object_name_find(evas_object_evas_get(obj), "_elm_access_disp");
    if (!o) return;
    evas_object_geometry_get(obj, NULL, NULL, &w, &h);
@@ -322,7 +322,7 @@
 {
    Evas_Object *o;
    Evas_Coord x, y, w, h;
-   
+
    o = evas_object_name_find(evas_object_evas_get(obj), "_elm_access_disp");
    if (!o)
      {
@@ -367,7 +367,7 @@
 _elm_access_object_unhilight(Evas_Object *obj)
 {
    Evas_Object *o, *ptarget;
-   
+
    o = evas_object_name_find(evas_object_evas_get(obj), "_elm_access_disp");
    if (!o) return;
    ptarget = evas_object_data_get(o, "_elm_access_target");
@@ -460,7 +460,7 @@
 {
    Elm_Access_Info *ac = ((Elm_Widget_Item *)data)->access;
    if (!ac) return;
-   
+
    _elm_access_object_unhilight(((Elm_Widget_Item *)data)->view);
    if (ac->delay_timer)
      {

Modified: trunk/elementary/src/lib/elm_check.c
===================================================================
--- trunk/elementary/src/lib/elm_check.c	2011-08-24 08:10:48 UTC (rev 62736)
+++ trunk/elementary/src/lib/elm_check.c	2011-08-24 08:11:58 UTC (rev 62737)
@@ -314,7 +314,7 @@
    // TODO: convert Elementary to subclassing of Evas_Smart_Class
    // TODO: and save some bytes, making descriptions per-class and not instance!
    evas_object_smart_callbacks_descriptions_set(obj, _signals);
-   
+
    _elm_access_object_register(obj, wd->chk);
    _elm_access_text_set(_elm_access_object_get(obj),
                         ELM_ACCESS_TYPE, E_("Check"));

Modified: trunk/elementary/src/lib/elm_toolbar.c
===================================================================
--- trunk/elementary/src/lib/elm_toolbar.c	2011-08-24 08:10:48 UTC (rev 62736)
+++ trunk/elementary/src/lib/elm_toolbar.c	2011-08-24 08:11:58 UTC (rev 62737)
@@ -598,7 +598,7 @@
 _select(void *data, Evas_Object *obj __UNUSED__, const char *emission __UNUSED__, const char *source __UNUSED__)
 {
    Elm_Toolbar_Item *it = data;
-   
+
    if ((_elm_config->access_mode == ELM_ACCESS_MODE_OFF) ||
        (_elm_access_2nd_click_timeout(it->base.view)))
      {
@@ -689,7 +689,7 @@
                             ELM_ACCESS_INFO, _access_info_cb, it);
    _elm_access_callback_set(_elm_access_item_get((Elm_Widget_Item *)it),
                             ELM_ACCESS_STATE, _access_state_cb, it);
-   
+
    if (_item_icon_set(icon_obj, "toolbar/", icon))
      {
         it->icon = icon_obj;

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-08-24 08:10:48 UTC (rev 62736)
+++ trunk/elementary/src/lib/elm_widget.c	2011-08-24 08:11:58 UTC (rev 62737)
@@ -2572,7 +2572,7 @@
 
    if (item->view)
      evas_object_del(item->view);
-   
+
    if (item->access)
      {
         _elm_access_clear(item->access);

Log:
elm toolbar: Fixed toolbar access function. Thanks to Gustavo Barbieri.
  

Author:       seoz
Date:         2011-08-24 09:13:13 -0700 (Wed, 24 Aug 2011)
New Revision: 62751
Trac:         http://trac.enlightenment.org/e/changeset/62751

Modified:
  trunk/elementary/src/lib/elm_toolbar.c 

Modified: trunk/elementary/src/lib/elm_toolbar.c
===================================================================
--- trunk/elementary/src/lib/elm_toolbar.c	2011-08-24 15:54:02 UTC (rev 62750)
+++ trunk/elementary/src/lib/elm_toolbar.c	2011-08-24 16:13:13 UTC (rev 62751)
@@ -634,13 +634,13 @@
 }
 
 static char *
-_access_info_cb(void *data __UNUSED__, Evas_Object *obj __UNUSED__, Elm_Widget_Item *item __UNUSED__)
+_access_info_cb(void *data __UNUSED__, Evas_Object *obj __UNUSED__, Elm_Widget_Item *item)
 {
    Elm_Toolbar_Item *it = (Elm_Toolbar_Item *)item;
-   char *txt = (char *)item->access_info;
-   if (!txt) txt = (char *)it->label;
+   const char *txt = item->access_info;
+   if (!txt) txt = it->label;
    if (txt) return strdup(txt);
-   return txt;
+   return NULL;
 }
 
 static char *

Log:
elm Elementary.h.in: Removed unnecessary spacing.
  

Author:       seoz
Date:         2011-08-25 10:17:35 -0700 (Thu, 25 Aug 2011)
New Revision: 62829
Trac:         http://trac.enlightenment.org/e/changeset/62829

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-25 16:53:18 UTC (rev 62828)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-25 17:17:35 UTC (rev 62829)
@@ -16638,7 +16638,7 @@
     *
     * In general to indicate how the genlist should expand items horizontally to
     * fill the list area, use elm_genlist_horizontal_set(). Valid modes are
-    * ELM_LIST_LIMIT and ELM_LIST_SCROLL . The default is ELM_LIST_SCROLL. This
+    * ELM_LIST_LIMIT and ELM_LIST_SCROLL. The default is ELM_LIST_SCROLL. This
     * mode means that if items are too wide to fit, the scroller will scroll
     * horizontally. Otherwise items are expanded to fill the width of the
     * viewport of the scroller. If it is ELM_LIST_LIMIT, items will be expanded

Log:
elm list/gengrid: Fixed typo in internal functions and variables. hilight -> highlight.
  
  Hilight is a common mis-spelling of highlight. http://en.wiktionary.org/wiki/hilight 
  

Author:       seoz
Date:         2011-08-25 10:19:22 -0700 (Thu, 25 Aug 2011)
New Revision: 62830
Trac:         http://trac.enlightenment.org/e/changeset/62830

Modified:
  trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_list.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-08-25 17:17:35 UTC (rev 62829)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-08-25 17:19:22 UTC (rev 62830)
@@ -53,7 +53,7 @@
    Eina_Bool   display_only : 1;
    Eina_Bool   disabled : 1;
    Eina_Bool   selected : 1;
-   Eina_Bool   hilighted : 1;
+   Eina_Bool   highlighted : 1;
    Eina_Bool   moving : 1;
 };
 
@@ -101,7 +101,7 @@
 };
 
 static const char *widtype = NULL;
-static void      _item_hilight(Elm_Gengrid_Item *item);
+static void      _item_highlight(Elm_Gengrid_Item *item);
 static void      _item_unrealize(Elm_Gengrid_Item *item);
 static void      _item_select(Elm_Gengrid_Item *item);
 static void      _item_unselect(Elm_Gengrid_Item *item);
@@ -786,7 +786,7 @@
    if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD) item->wd->on_hold = EINA_TRUE;
    else item->wd->on_hold = EINA_FALSE;
    item->wd->wasselected = item->selected;
-   _item_hilight(item);
+   _item_highlight(item);
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
      {
         evas_object_smart_callback_call(item->wd->self, SIG_CLICKED_DOUBLE, item);
@@ -858,7 +858,7 @@
      {
         if (!item->selected)
           {
-             _item_hilight(item);
+             _item_highlight(item);
              _item_select(item);
           }
         else _item_unselect(item);
@@ -878,17 +878,17 @@
              EINA_LIST_FOREACH_SAFE(item->wd->selected, l, l_next, item2)
                 if (item2 != item) _item_unselect(item2);
           }
-        _item_hilight(item);
+        _item_highlight(item);
         _item_select(item);
      }
 }
 
 static void
-_item_hilight(Elm_Gengrid_Item *item)
+_item_highlight(Elm_Gengrid_Item *item)
 {
-   if ((item->wd->no_select) || (item->delete_me) || (item->hilighted)) return;
+   if ((item->wd->no_select) || (item->delete_me) || (item->highlighted)) return;
    edje_object_signal_emit(item->base.view, "elm,state,selected", "elm");
-   item->hilighted = EINA_TRUE;
+   item->highlighted = EINA_TRUE;
 }
 
 static void
@@ -1341,9 +1341,9 @@
 static void
 _item_unselect(Elm_Gengrid_Item *item)
 {
-   if ((item->delete_me) || (!item->hilighted)) return;
+   if ((item->delete_me) || (!item->highlighted)) return;
    edje_object_signal_emit(item->base.view, "elm,state,unselected", "elm");
-   item->hilighted = EINA_FALSE;
+   item->highlighted = EINA_FALSE;
    if (item->selected)
      {
         item->selected = EINA_FALSE;
@@ -2133,7 +2133,7 @@
              while (wd->selected)
                _item_unselect(wd->selected->data);
           }
-        _item_hilight(item);
+        _item_highlight(item);
         _item_select(item);
      }
    else

Modified: trunk/elementary/src/lib/elm_list.c
===================================================================
--- trunk/elementary/src/lib/elm_list.c	2011-08-25 17:17:35 UTC (rev 62829)
+++ trunk/elementary/src/lib/elm_list.c	2011-08-25 17:19:22 UTC (rev 62830)
@@ -46,7 +46,7 @@
    Eina_Bool is_separator : 1;
    Eina_Bool fixed : 1;
    Eina_Bool selected : 1;
-   Eina_Bool hilighted : 1;
+   Eina_Bool highlighted : 1;
    Eina_Bool dummy_icon : 1;
    Eina_Bool dummy_end : 1;
 };
@@ -493,7 +493,7 @@
         _signal_emit_hook(obj, "elm,state,disabled", "elm");
         elm_widget_scroll_freeze_push(obj);
         elm_widget_scroll_hold_push(obj);
-        /* FIXME: if we get to have a way to only un-hilight items
+        /* FIXME: if we get to have a way to only un-highlight items
          * in the future, keeping them selected... */
         _deselect_all_items(wd);
      }
@@ -687,7 +687,7 @@
 }
 
 static void
-_item_hilight(Elm_List_Item *it)
+_item_highlight(Elm_List_Item *it)
 {
    Evas_Object *obj = it->base.widget;
    Widget_Data *wd = elm_widget_data_get(obj);
@@ -695,7 +695,7 @@
 
    if (!wd) return;
    ELM_LIST_ITEM_CHECK_DELETED_RETURN(it);
-   if (it->hilighted) return;
+   if (it->highlighted) return;
 
    evas_object_ref(obj);
    _elm_list_walk(wd);
@@ -704,7 +704,7 @@
    selectraise = edje_object_data_get(it->base.view, "selectraise");
    if ((selectraise) && (!strcmp(selectraise, "on")))
      evas_object_raise(it->base.view);
-   it->hilighted = EINA_TRUE;
+   it->highlighted = EINA_TRUE;
 
    _elm_list_unwalk(wd);
    evas_object_unref(obj);
@@ -747,7 +747,7 @@
 
    if (!wd) return;
    ELM_LIST_ITEM_CHECK_DELETED_RETURN(it);
-   if (!it->hilighted) return;
+   if (!it->highlighted) return;
 
    evas_object_ref(obj);
    _elm_list_walk(wd);
@@ -760,7 +760,7 @@
         if ((stacking) && (!strcmp(stacking, "below")))
           evas_object_lower(it->base.view);
      }
-   it->hilighted = EINA_FALSE;
+   it->highlighted = EINA_FALSE;
    if (it->selected)
      {
         it->selected = EINA_FALSE;
@@ -915,7 +915,7 @@
    evas_object_ref(obj2);
    _elm_list_walk(wd);
 
-   _item_hilight(it);
+   _item_highlight(it);
    wd->longpressed = EINA_FALSE;
    if (it->long_timer) ecore_timer_del(it->long_timer);
    it->long_timer = ecore_timer_add(_elm_config->longpress_timeout, _long_press, it);
@@ -982,7 +982,7 @@
      {
         if (!it->selected)
           {
-             _item_hilight(it);
+             _item_highlight(it);
              _item_select(it);
           }
         else _item_unselect(it);
@@ -993,7 +993,7 @@
           {
              while (wd->selected)
                _item_unselect(wd->selected->data);
-             _item_hilight(it);
+             _item_highlight(it);
              _item_select(it);
           }
         else
@@ -1003,7 +1003,7 @@
 
              EINA_LIST_FOREACH_SAFE(wd->selected, l, l_next, it2)
                 if (it2 != it) _item_unselect(it2);
-             _item_hilight(it);
+             _item_highlight(it);
              _item_select(it);
           }
      }
@@ -1218,7 +1218,7 @@
                   evas_object_size_hint_min_set(it->base.view, mw, mh);
                   evas_object_show(it->base.view);
                }
-             if ((it->selected) || (it->hilighted))
+             if ((it->selected) || (it->highlighted))
                {
                   const char *selectraise;
 
@@ -1682,7 +1682,7 @@
              while (wd->selected)
                _item_unselect(wd->selected->data);
           }
-        _item_hilight(it);
+        _item_highlight(it);
         _item_select(it);
      }
    else

Log:
elm genlist: Reverted r62645 patch. This needs to be refined.
  

Author:       seoz
Date:         2011-08-26 04:32:26 -0700 (Fri, 26 Aug 2011)
New Revision: 62855
Trac:         http://trac.enlightenment.org/e/changeset/62855

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-08-26 10:09:40 UTC (rev 62854)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-08-26 11:32:26 UTC (rev 62855)
@@ -3545,28 +3545,17 @@
      {
         if ((flags & ELM_GENLIST_ITEM_GROUP) &&
             (after->flags & ELM_GENLIST_ITEM_GROUP))
-          {
-             Elm_Genlist_Item *it2 = NULL;
-             Eina_List *ll = eina_list_last(after->items);
-             if (ll) it2 = ll->data;
-             else it2 = after;
-
-             wd->items =
-                eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
-                                            EINA_INLIST_GET(it2));
-             it->rel = it2;
-             wd->group_items = eina_list_append_relative(wd->group_items, it,
-                                                         after);
-          }
+          wd->group_items = eina_list_append_relative(wd->group_items, it,
+                                                      after);
      }
    else
      {
         it->parent->items = eina_list_append_relative(it->parent->items, it,
                                                       after);
-        wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
-                                                EINA_INLIST_GET(after));
-        it->rel = after;
      }
+   wd->items = eina_inlist_append_relative(wd->items, EINA_INLIST_GET(it),
+                                           EINA_INLIST_GET(after));
+   it->rel = after;
    it->rel->relcount++;
    it->before = EINA_FALSE;
    _item_queue(wd, it);

Log:
elm els_tooltip.c: Fixed warings.
  

Author:       seoz
Date:         2011-08-28 21:00:37 -0700 (Sun, 28 Aug 2011)
New Revision: 62930
Trac:         http://trac.enlightenment.org/e/changeset/62930

Modified:
  trunk/elementary/src/lib/els_tooltip.c 

Modified: trunk/elementary/src/lib/els_tooltip.c
===================================================================
--- trunk/elementary/src/lib/els_tooltip.c	2011-08-29 04:00:17 UTC (rev 62929)
+++ trunk/elementary/src/lib/els_tooltip.c	2011-08-29 04:00:37 UTC (rev 62930)
@@ -842,7 +842,7 @@
 EAPI const char *
 elm_object_tooltip_style_get(const Evas_Object *obj)
 {
-   ELM_CHECK_WID_IS(obj);
+   ELM_CHECK_WID_IS(obj) NULL;
    ELM_TOOLTIP_GET_OR_RETURN(tt, obj, NULL);
    return tt->style ? tt->style : "default";
 }
@@ -890,7 +890,7 @@
 EAPI Eina_Bool
 elm_tooltip_size_restrict_disable(Evas_Object *obj, Eina_Bool disable)
 {
-   ELM_CHECK_WID_IS(obj);
+   ELM_CHECK_WID_IS(obj) EINA_FALSE;
    ELM_TOOLTIP_GET_OR_RETURN(tt, obj, EINA_FALSE);
    return tt->free_size = disable;
 }
@@ -907,7 +907,7 @@
 EAPI Eina_Bool
 elm_tooltip_size_restrict_disabled_get(const Evas_Object *obj)
 {
-   ELM_CHECK_WID_IS(obj);
+   ELM_CHECK_WID_IS(obj) EINA_FALSE;
    ELM_TOOLTIP_GET_OR_RETURN(tt, obj, EINA_FALSE);
    return tt->free_size;
 }

Log:
elm Elementary.h.in: Fixed typo.
  

Author:       seoz
Date:         2011-08-29 08:15:39 -0700 (Mon, 29 Aug 2011)
New Revision: 62950
Trac:         http://trac.enlightenment.org/e/changeset/62950

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-29 14:46:24 UTC (rev 62949)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-29 15:15:39 UTC (rev 62950)
@@ -6907,7 +6907,7 @@
     * @param policy_v Vertical scrollbar policy
     *
     * This sets the scrollbar visibility policy for the given scroller.
-    * ELM_SCROLLER_POLICY_AUTO means the scrollber is made visible if it is
+    * ELM_SCROLLER_POLICY_AUTO means the scrollbar is made visible if it is
     * needed, and otherwise kept hidden. ELM_SCROLLER_POLICY_ON turns it on all
     * the time, and ELM_SCROLLER_POLICY_OFF always keeps it off. This applies
     * respectively for the horizontal and vertical scrollbars.
@@ -14900,7 +14900,7 @@
     * @param policy_v Vertical scrollbar policy.
     *
     * This sets the scrollbar visibility policy for the given scroller.
-    * #ELM_SCROLLER_POLICY_AUTO means the scrollber is made visible if it
+    * #ELM_SCROLLER_POLICY_AUTO means the scrollbar is made visible if it
     * is needed, and otherwise kept hidden. #ELM_SCROLLER_POLICY_ON turns
     * it on all the time, and #ELM_SCROLLER_POLICY_OFF always keeps it off.
     * This applies respectively for the horizontal and vertical scrollbars.
@@ -24179,7 +24179,7 @@
     * @param policy_v Vertical scrollbar policy.
     *
     * This sets the scrollbar visibility policy for the given scroller.
-    * #ELM_SCROLLER_POLICY_AUTO means the scrollber is made visible if it
+    * #ELM_SCROLLER_POLICY_AUTO means the scrollbar is made visible if it
     * is needed, and otherwise kept hidden. #ELM_SCROLLER_POLICY_ON turns
     * it on all the time, and #ELM_SCROLLER_POLICY_OFF always keeps it off.
     * This applies respectively for the horizontal and vertical scrollbars.

Log:
elm list: Fixed elm_list_scroller_policy_set(). Closed ticket #842.
  

Author:       seoz
Date:         2011-08-29 09:13:35 -0700 (Mon, 29 Aug 2011)
New Revision: 62956
Trac:         http://trac.enlightenment.org/e/changeset/62956

Modified:
  trunk/elementary/src/lib/elm_list.c 

Modified: trunk/elementary/src/lib/elm_list.c
===================================================================
--- trunk/elementary/src/lib/elm_list.c	2011-08-29 16:07:01 UTC (rev 62955)
+++ trunk/elementary/src/lib/elm_list.c	2011-08-29 16:13:35 UTC (rev 62956)
@@ -2013,11 +2013,11 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
-   if (!wd) return;
+   if ((!wd) || (!wd->scr)) return;
    if ((policy_h >= ELM_SCROLLER_POLICY_LAST) ||
        (policy_v >= ELM_SCROLLER_POLICY_LAST))
-     if (wd->scr)
-       elm_smart_scroller_policy_set(wd->scr, policy_h, policy_v);
+     return;
+   elm_smart_scroller_policy_set(wd->scr, policy_h, policy_v);
 }
 
 EAPI void

Log:
elm: Refactoring. Modified elm_{widget}_scroller_policy_set() API.
  

Author:       seoz
Date:         2011-08-29 09:30:14 -0700 (Mon, 29 Aug 2011)
New Revision: 62957
Trac:         http://trac.enlightenment.org/e/changeset/62957

Modified:
  trunk/elementary/src/lib/elm_diskselector.c trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_scroller.c 

Modified: trunk/elementary/src/lib/elm_diskselector.c
===================================================================
--- trunk/elementary/src/lib/elm_diskselector.c	2011-08-29 16:13:35 UTC (rev 62956)
+++ trunk/elementary/src/lib/elm_diskselector.c	2011-08-29 16:30:14 UTC (rev 62957)
@@ -964,10 +964,11 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
-   if (!wd) return;
-   if ((policy_h >= 3) || (policy_v >= 3)) return;
-   if (wd->scroller)
-     elm_smart_scroller_policy_set(wd->scroller, policy_h, policy_v);
+   if ((!wd) || (!wd->scroller)) return;
+   if ((policy_h >= ELM_SCROLLER_POLICY_LAST) ||
+       (policy_v >= ELM_SCROLLER_POLICY_LAST))
+     return;
+   elm_smart_scroller_policy_set(wd->scroller, policy_h, policy_v);
 }
 
 EAPI void

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-08-29 16:13:35 UTC (rev 62956)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-08-29 16:30:14 UTC (rev 62957)
@@ -4756,12 +4756,11 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
-   if (!wd) return;
+   if ((!wd) || (!wd->scr)) return;
    if ((policy_h >= ELM_SCROLLER_POLICY_LAST) ||
        (policy_v >= ELM_SCROLLER_POLICY_LAST))
      return;
-   if (wd->scr)
-     elm_smart_scroller_policy_set(wd->scr, policy_h, policy_v);
+   elm_smart_scroller_policy_set(wd->scr, policy_h, policy_v);
 }
 
 EAPI void

Modified: trunk/elementary/src/lib/elm_scroller.c
===================================================================
--- trunk/elementary/src/lib/elm_scroller.c	2011-08-29 16:13:35 UTC (rev 62956)
+++ trunk/elementary/src/lib/elm_scroller.c	2011-08-29 16:30:14 UTC (rev 62957)
@@ -568,15 +568,11 @@
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
-   const Elm_Scroller_Policy map[3] =
-     {
-        ELM_SMART_SCROLLER_POLICY_AUTO,
-        ELM_SMART_SCROLLER_POLICY_ON,
-        ELM_SMART_SCROLLER_POLICY_OFF
-     };
    if ((!wd) || (!wd->scr)) return;
-   if ((policy_h >= 3) || (policy_v >= 3)) return;
-   elm_smart_scroller_policy_set(wd->scr, map[policy_h], map[policy_v]);
+   if ((policy_h >= ELM_SCROLLER_POLICY_LAST) ||
+       (policy_v >= ELM_SCROLLER_POLICY_LAST))
+     return;
+   elm_smart_scroller_policy_set(wd->scr, policy_h, policy_v);
 }
 
 EAPI void

Log:
elm Elementary.h.in: Removed duplicated callback description.
  

Author:       seoz
Date:         2011-08-31 01:34:43 -0700 (Wed, 31 Aug 2011)
New Revision: 63016
Trac:         http://trac.enlightenment.org/e/changeset/63016

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-08-31 00:08:52 UTC (rev 63015)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-08-31 08:34:43 UTC (rev 63016)
@@ -5312,10 +5312,6 @@
     */
    EAPI Eina_Bool        elm_image_aspect_ratio_retained_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
 
-   /* smart callbacks called:
-    * "clicked" - the user clicked the image
-    */
-
    /**
     * @}
     */

Log:
elm els_scroller.c: Fixed formatting.
  
  Fixed indentation. Fixed spacing.
  

Author:       seoz
Date:         2011-09-01 21:52:18 -0700 (Thu, 01 Sep 2011)
New Revision: 63084
Trac:         http://trac.enlightenment.org/e/changeset/63084

Modified:
  trunk/elementary/src/lib/els_scroller.c 

Modified: trunk/elementary/src/lib/els_scroller.c
===================================================================
--- trunk/elementary/src/lib/els_scroller.c	2011-09-02 04:09:17 UTC (rev 63083)
+++ trunk/elementary/src/lib/els_scroller.c	2011-09-02 04:52:18 UTC (rev 63084)
@@ -332,7 +332,7 @@
              ecore_animator_del(sd->down.momentum_animator);
              sd->down.momentum_animator = NULL;
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
           }
      }
 }
@@ -396,13 +396,13 @@
     * adjust a bit. */
    elm_smart_scroller_child_viewport_size_get(sd->smart_obj, &sd->ww, &sd->wh);
    if (x < 0)
-      sd->wx = 0;
+     sd->wx = 0;
    else if ((x + sd->ww) > cw)
-      sd->wx = cw - sd->ww;
+     sd->wx = cw - sd->ww;
    else if (sd->is_mirrored)
-      sd->wx = _elm_smart_scroller_x_mirrored_get(sd->smart_obj, x);
+     sd->wx = _elm_smart_scroller_x_mirrored_get(sd->smart_obj, x);
    else
-      sd->wx = x;
+     sd->wx = x;
    if (y < 0) sd->wy = 0;
    else if ((y + sd->wh) > ch) sd->wy = ch - sd->wh;
    else sd->wy = y;
@@ -445,7 +445,7 @@
    tt = 1.0 - (tt * tt);
    sd->pan_func.get(sd->pan_obj, &px, &py);
    px = (sd->scrollto.x.start * (1.0 - tt)) +
-     (sd->scrollto.x.end * tt);
+      (sd->scrollto.x.end * tt);
    if (t >= sd->scrollto.x.t_end)
      {
         px = sd->scrollto.x.end;
@@ -480,7 +480,7 @@
         sd->down.pdx = 0;
         sd->down.pdy = 0;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
 }
 
@@ -517,7 +517,7 @@
         sd->down.bounce_x_animator = NULL;
         _smart_momentum_end(sd);
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    sd->bouncemex = 0;
 }
@@ -535,7 +535,7 @@
    tt = 1.0 - (tt * tt);
    sd->pan_func.get(sd->pan_obj, &px, &py);
    py = (sd->scrollto.y.start * (1.0 - tt)) +
-     (sd->scrollto.y.end * tt);
+      (sd->scrollto.y.end * tt);
    if (t >= sd->scrollto.y.t_end)
      {
         py = sd->scrollto.y.end;
@@ -583,7 +583,7 @@
         sd->down.bounce_y_animator = NULL;
         _smart_momentum_end(sd);
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    sd->bouncemey = 0;
 }
@@ -688,14 +688,14 @@
              if (sd->down.momentum_animator)
                sd->down.bounce_x_hold = 1;
              if ((!sd->down.bounce_y_animator) &&
-                      (!sd->scrollto.y.animator))
+                 (!sd->scrollto.y.animator))
                _smart_anim_stop(sd->smart_obj);
              sd->down.bounce_x_animator = NULL;
              sd->down.pdx = 0;
              sd->bouncemex = 0;
              _smart_momentum_end(sd);
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
              return ECORE_CALLBACK_CANCEL;
           }
      }
@@ -735,7 +735,7 @@
              sd->bouncemey = 0;
              _smart_momentum_end(sd);
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
              return ECORE_CALLBACK_CANCEL;
           }
      }
@@ -756,19 +756,19 @@
    sd->pan_func.get(sd->pan_obj, &px, &py);
    switch (dir)
      {
-     case LEFT:
+      case LEFT:
         if (px > minx) return EINA_TRUE;
         break;
-     case RIGHT:
+      case RIGHT:
         if ((px - minx) < mx) return EINA_TRUE;
         break;
-     case UP:
+      case UP:
         if (py > miny) return EINA_TRUE;
         break;
-     case DOWN:
+      case DOWN:
         if ((py - miny) < my) return EINA_TRUE;
         break;
-     default:
+      default:
         break;
      }
    return EINA_FALSE;
@@ -797,13 +797,13 @@
              if ((sd->down.dir_y) && !can_scroll(sd, sd->down.vdir))
                {
                   sd->down.dir_y = 0;
-                  }
-                  }
-                  if ((!sd->down.dir_x) && (!sd->down.dir_y))
-                  {
-                  sd->down.cancelled = 1;
-                  }
-         */
+               }
+           }
+        if ((!sd->down.dir_x) && (!sd->down.dir_y))
+          {
+             sd->down.cancelled = 1;
+          }
+        */
         dt = dt / (_elm_config->thumbscroll_friction + sd->down.extra_time);
         if (dt > 1.0) dt = 1.0;
         p = 1.0 - ((1.0 - dt) * (1.0 - dt));
@@ -854,7 +854,7 @@
              sd->down.pdx = 0;
              sd->down.pdy = 0;
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
              return ECORE_CALLBACK_CANCEL;
           }
      }
@@ -874,14 +874,14 @@
         ecore_animator_del(sd->down.onhold_animator);
         sd->down.onhold_animator = NULL;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    if (sd->down.hold_animator)
      {
         ecore_animator_del(sd->down.hold_animator);
         sd->down.hold_animator = NULL;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    sd->pan_func.max_get(sd->pan_obj, &mx, &my);
    sd->pan_func.min_get(sd->pan_obj, &minx, &miny);
@@ -992,7 +992,7 @@
              bounce_eval(sd);
           }
         else
-           sd->bouncemex = 0;
+          sd->bouncemex = 0;
      }
    if (!sd->down.bounce_y_animator)
      {
@@ -1003,7 +1003,7 @@
              bounce_eval(sd);
           }
         else
-           sd->bouncemey = 0;
+          sd->bouncemey = 0;
      }
    if ((x != px) || (y != py))
      {
@@ -1074,7 +1074,7 @@
         sd->down.bounce_x_animator = NULL;
         sd->bouncemex = 0;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    if (sd->down.bounce_y_animator)
      {
@@ -1082,7 +1082,7 @@
         sd->down.bounce_y_animator = NULL;
         sd->bouncemey = 0;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    if (sd->down.hold_animator)
      {
@@ -1090,7 +1090,7 @@
         sd->down.hold_animator = NULL;
         _smart_drag_stop(sd->smart_obj);
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    if (sd->down.momentum_animator)
      {
@@ -1103,7 +1103,7 @@
         sd->down.pdx = 0;
         sd->down.pdy = 0;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
 
    x = nx;
@@ -1126,7 +1126,7 @@
 elm_smart_scroller_child_region_set(Evas_Object *obj, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h)
 {
    if (_elm_smart_scroller_child_region_show_internal(obj, &x, &y, w, h))
-      elm_smart_scroller_child_pos_set(obj, x, y);
+     elm_smart_scroller_child_pos_set(obj, x, y);
 }
 
 /* Set should be used for setting the wanted position, for example a user scroll
@@ -1140,7 +1140,7 @@
    sd->ww = w;
    sd->wh = h;
    if (_elm_smart_scroller_child_region_show_internal(obj, &x, &y, w, h))
-      elm_smart_scroller_child_pos_set(obj, x, y);
+     elm_smart_scroller_child_pos_set(obj, x, y);
 }
 
 void
@@ -1263,7 +1263,7 @@
              edje_object_part_swallow(sd->edje_obj, "elm.scrollbar.base", base);
           }
         if (!_elm_config->thumbscroll_enable)
-           evas_object_size_hint_min_set(base, mw, mh);
+          evas_object_size_hint_min_set(base, mw, mh);
      }
    sd->vbar_visible = !sd->vbar_visible;
    sd->hbar_visible = !sd->hbar_visible;
@@ -1289,7 +1289,7 @@
              ecore_animator_del(sd->down.onhold_animator);
              sd->down.onhold_animator = NULL;
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
           }
      }
    else
@@ -1327,10 +1327,10 @@
 elm_smart_scroller_paging_get(Evas_Object *obj, double *pagerel_h, double *pagerel_v, Evas_Coord *pagesize_h, Evas_Coord *pagesize_v)
 {
    API_ENTRY return;
-   if(pagerel_h) *pagerel_h = sd->pagerel_h;
-   if(pagerel_v) *pagerel_v = sd->pagerel_v;
-   if(pagesize_h) *pagesize_h = sd->pagesize_h;
-   if(pagesize_v) *pagesize_v = sd->pagesize_v;
+   if (pagerel_h) *pagerel_h = sd->pagerel_h;
+   if (pagerel_v) *pagerel_v = sd->pagerel_v;
+   if (pagesize_h) *pagesize_h = sd->pagesize_h;
+   if (pagesize_v) *pagesize_v = sd->pagesize_v;
 }
 
 void
@@ -1352,16 +1352,16 @@
    if (pagenumber_h)
      {
         if (sd->pagesize_h > 0)
-           *pagenumber_h = cw / sd->pagesize_h + 1;
+          *pagenumber_h = cw / sd->pagesize_h + 1;
         else
-           *pagenumber_h = 0;
+          *pagenumber_h = 0;
      }
    if (pagenumber_v)
      {
         if (sd->pagesize_v > 0)
-           *pagenumber_v = ch / sd->pagesize_v + 1;
+          *pagenumber_v = ch / sd->pagesize_v + 1;
         else
-           *pagenumber_v = 0;
+          *pagenumber_v = 0;
      }
 }
 
@@ -1374,7 +1374,7 @@
    if (pagenumber_h) x = sd->pagesize_h * pagenumber_h;
    if (pagenumber_v) y = sd->pagesize_v * pagenumber_v;
    if (_elm_smart_scroller_child_region_show_internal(obj, &x, &y, w, h))
-      elm_smart_scroller_child_pos_set(obj, x, y);
+     elm_smart_scroller_child_pos_set(obj, x, y);
 }
 
 void
@@ -1559,7 +1559,7 @@
         sd->down.bounce_x_animator = NULL;
         sd->bouncemex = 0;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    if (sd->down.bounce_y_animator)
      {
@@ -1567,7 +1567,7 @@
         sd->down.bounce_y_animator = NULL;
         sd->bouncemey = 0;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    _elm_smart_scroller_wanted_region_set(sd->smart_obj);
 }
@@ -1611,7 +1611,7 @@
         sd->down.bounce_x_animator = NULL;
         sd->bouncemex = 0;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    if (sd->down.bounce_y_animator)
      {
@@ -1619,7 +1619,7 @@
         sd->down.bounce_y_animator = NULL;
         sd->bouncemey = 0;
         if (sd->child.resized)
-           _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
      }
    if (!ev->direction)
      y += ev->z * sd->step.y;
@@ -1671,7 +1671,7 @@
              sd->down.bounce_x_animator = NULL;
              sd->bouncemex = 0;
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
           }
         if (sd->down.bounce_y_animator)
           {
@@ -1679,7 +1679,7 @@
              sd->down.bounce_y_animator = NULL;
              sd->bouncemey = 0;
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
           }
         if (sd->down.hold_animator)
           {
@@ -1687,7 +1687,7 @@
              sd->down.hold_animator = NULL;
              _smart_drag_stop(sd->smart_obj);
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
           }
         if (sd->down.momentum_animator)
           {
@@ -1698,7 +1698,7 @@
              sd->down.ax = 0;
              sd->down.ay = 0;
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
           }
         if (ev->button == 1)
           {
@@ -1755,20 +1755,20 @@
    sd->pan_func.min_get(sd->pan_obj, &minx, &miny);
 
    if (*x < minx)
-      *x += (minx - *x) * _elm_config->thumbscroll_border_friction;
+     *x += (minx - *x) * _elm_config->thumbscroll_border_friction;
    else if (sd->child.w <= sd->w)
-      *x += (sd->down.sx - *x) * _elm_config->thumbscroll_border_friction;
+     *x += (sd->down.sx - *x) * _elm_config->thumbscroll_border_friction;
    else if ((sd->child.w - sd->w + minx) < *x)
-      *x += (sd->child.w - sd->w + minx - *x) *
-      _elm_config->thumbscroll_border_friction;
+     *x += (sd->child.w - sd->w + minx - *x) *
+        _elm_config->thumbscroll_border_friction;
 
    if (*y < miny)
-      *y += (miny - *y) * _elm_config->thumbscroll_border_friction;
+     *y += (miny - *y) * _elm_config->thumbscroll_border_friction;
    else if (sd->child.h <= sd->h)
-      *y += (sd->down.sy - *y) * _elm_config->thumbscroll_border_friction;
+     *y += (sd->down.sy - *y) * _elm_config->thumbscroll_border_friction;
    else if ((sd->child.h - sd->h + miny) < *y)
-      *y += (sd->child.h - sd->h + miny - *y) *
-      _elm_config->thumbscroll_border_friction;
+     *y += (sd->child.h - sd->h + miny - *y) *
+        _elm_config->thumbscroll_border_friction;
 }
 
 static Eina_Bool
@@ -1785,8 +1785,8 @@
         Evas_Coord basex = 0, basey = 0, x, y;
         double dt, t, tdiff, tnow, twin;
         struct {
-           Evas_Coord x, y, dx, dy;
-           double t, dt;
+             Evas_Coord x, y, dx, dy;
+             double t, dt;
         } pos[60];
 
         tdiff = sd->down.hist.est_timestamp_diff;
@@ -1854,7 +1854,7 @@
              WEIGHT(fx, sd->down.hold_x, _elm_config->scroll_smooth_amount);
              WEIGHT(fy, sd->down.hold_y, _elm_config->scroll_smooth_amount);
           }
-//        printf("%3.5f %i %i\n", ecore_time_get(), sd->down.hold_y, fy);
+        //        printf("%3.5f %i %i\n", ecore_time_get(), sd->down.hold_y, fy);
      }
 
    elm_smart_scroller_child_pos_get(sd->smart_obj, &ox, &oy);
@@ -1862,13 +1862,13 @@
      {
         if ((!sd->widget) ||
             (!elm_widget_drag_child_locked_x_get(sd->widget)))
-           ox = fx;
+          ox = fx;
      }
    if (sd->down.dir_y)
      {
         if ((!sd->widget) ||
             (!elm_widget_drag_child_locked_y_get(sd->widget)))
-           oy = fy;
+          oy = fy;
      }
 
    elm_smart_scroller_child_pos_set(sd->smart_obj, ox, oy);
@@ -1912,7 +1912,7 @@
                   ecore_animator_del(sd->down.onhold_animator);
                   sd->down.onhold_animator = NULL;
                   if (sd->child.resized)
-                     _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+                    _elm_smart_scroller_wanted_region_set(sd->smart_obj);
                }
              x = ev->canvas.x - sd->down.x;
              y = ev->canvas.y - sd->down.y;
@@ -2017,7 +2017,7 @@
                             ecore_animator_del(sd->down.hold_animator);
                             sd->down.hold_animator = NULL;
                             if (sd->child.resized)
-                               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+                              _elm_smart_scroller_wanted_region_set(sd->smart_obj);
                          }
                     }
                   else
@@ -2080,7 +2080,7 @@
                        ecore_animator_del(sd->down.hold_animator);
                        sd->down.hold_animator = NULL;
                        if (sd->child.resized)
-                          _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+                         _elm_smart_scroller_wanted_region_set(sd->smart_obj);
                     }
                }
              if (sd->down.scroll)
@@ -2104,7 +2104,7 @@
              _update_wanted_coordinates(sd, x, y);
 
              if (sd->child.resized)
-                _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
 
              if (!_smart_do_page(sd))
                bounce_eval(sd);
@@ -2454,7 +2454,7 @@
                             ecore_animator_del(sd->down.onhold_animator);
                             sd->down.onhold_animator = NULL;
                             if (sd->child.resized)
-                               _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+                              _elm_smart_scroller_wanted_region_set(sd->smart_obj);
                          }
                     }
                }

Log:
elm scroller: Added 'const' to the first Evas_Object parameter of
  getters.
  

Author:       seoz
Date:         2011-09-01 21:53:48 -0700 (Thu, 01 Sep 2011)
New Revision: 63085
Trac:         http://trac.enlightenment.org/e/changeset/63085

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_scroller.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-09-02 04:52:18 UTC (rev 63084)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-09-02 04:53:48 UTC (rev 63085)
@@ -7018,7 +7018,7 @@
     * @see elm_scroller_page_show()
     * @see elm_scroller_page_brint_in()
     */
-   EAPI void         elm_scroller_current_page_get(Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
+   EAPI void         elm_scroller_current_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
    /**
     * @brief Get scroll last page number.
     *
@@ -7033,7 +7033,7 @@
     * @see elm_scroller_page_show()
     * @see elm_scroller_page_brint_in()
     */
-   EAPI void         elm_scroller_last_page_get(Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
+   EAPI void         elm_scroller_last_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
    /**
     * Show a specific virtual region within the scroller content object by page number.
     *

Modified: trunk/elementary/src/lib/elm_scroller.c
===================================================================
--- trunk/elementary/src/lib/elm_scroller.c	2011-09-02 04:52:18 UTC (rev 63084)
+++ trunk/elementary/src/lib/elm_scroller.c	2011-09-02 04:53:48 UTC (rev 63085)
@@ -650,7 +650,7 @@
 }
 
 EAPI void
-elm_scroller_current_page_get(Evas_Object *obj, int *h_pagenumber, int *v_pagenumber)
+elm_scroller_current_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber)
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
@@ -660,7 +660,7 @@
 }
 
 EAPI void
-elm_scroller_last_page_get(Evas_Object *obj, int *h_pagenumber, int *v_pagenumber)
+elm_scroller_last_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber)
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);

Log:
elm Elementary.h.in: Fixed typo.
  

Author:       seoz
Date:         2011-09-03 21:28:02 -0700 (Sat, 03 Sep 2011)
New Revision: 63149
Trac:         http://trac.enlightenment.org/e/changeset/63149

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-09-04 04:14:43 UTC (rev 63148)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-09-04 04:28:02 UTC (rev 63149)
@@ -26112,7 +26112,7 @@
     * positioned at left.
     *
     * @see elm_segment_control_item_add()
-    * @see elm_segment_control_count_get()
+    * @see elm_segment_control_item_count_get()
     * @see elm_segment_control_item_del()
     *
     * @ingroup SegmentControl

Log:
elm genlist: Fixed formatting.
  

Author:       seoz
Date:         2011-09-05 05:14:20 -0700 (Mon, 05 Sep 2011)
New Revision: 63194
Trac:         http://trac.enlightenment.org/e/changeset/63194

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-09-05 12:11:34 UTC (rev 63193)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-09-05 12:14:20 UTC (rev 63194)
@@ -938,10 +938,12 @@
              if (!it->wd->reorder_start_y)
                it->wd->reorder_start_y = it->block->y + it->y;
 
-             if (it_scrl_y < oy) y_pos = oy;
-             else if (it_scrl_y + it->wd->reorder_it->h > oy+oh)
-                y_pos = oy + oh - it->wd->reorder_it->h;
-             else y_pos = it_scrl_y;
+             if (it_scrl_y < oy)
+               y_pos = oy;
+             else if (it_scrl_y + it->wd->reorder_it->h > oy + oh)
+               y_pos = oy + oh - it->wd->reorder_it->h;
+             else
+               y_pos = it_scrl_y;
 
              _item_position(it, it->base.view, it->scrl_x, y_pos);
 
@@ -2127,7 +2129,7 @@
      {
         it->block->reorder_offset = it->wd->reorder_it->h * -1;
         if (it->block->count == 1)
-           it->wd->reorder_rel = it;
+          it->wd->reorder_rel = it;
      }
    else if ((it->wd->reorder_start_y >= it->block->y) &&
             (roy - oy + (roh / 2) <= it->block->y - it->wd->pan_y))
@@ -2246,7 +2248,7 @@
                   if (vis)
                     {
                        if (it->wd->reorder_mode)
-                          y += _get_space_for_reorder_item(it);
+                         y += _get_space_for_reorder_item(it);
                        git = it->group_item;
                        if (git)
                          {

Log:
elm genlist: Fixed reordering mode bug.
  
  1. Fixed floating item bug while reordering.
  2. Fixed moving an item out of range bug while reordering.
  

Author:       seoz
Date:         2011-09-05 05:16:36 -0700 (Mon, 05 Sep 2011)
New Revision: 63195
Trac:         http://trac.enlightenment.org/e/changeset/63195

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-09-05 12:14:20 UTC (rev 63194)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-09-05 12:16:36 UTC (rev 63195)
@@ -1029,6 +1029,7 @@
 
         evas_object_raise(it->base.view);
         elm_smart_scroller_hold_set(it->wd->scr, EINA_TRUE);
+        elm_smart_scroller_bounce_allow_set(it->wd->scr, EINA_FALSE, EINA_FALSE);
 
         list = elm_genlist_realized_items_get(it->wd->obj);
         EINA_LIST_FOREACH(list, l, it_tmp)
@@ -1331,24 +1332,22 @@
      {
         Evas_Coord it_scrl_y = ev->canvas.y - it->wd->reorder_it->dy;
 
-        if (it->wd->reorder_rel)
+        if (it->wd->reorder_rel && (it->wd->reorder_it->parent == it->wd->reorder_rel->parent))
           {
-             if (it->wd->reorder_it->parent == it->wd->reorder_rel->parent)
-               {
-                  if (it_scrl_y <= it->wd->reorder_rel->scrl_y)
-                     _item_move_before(it->wd->reorder_it, it->wd->reorder_rel);
-                  else
-                     _item_move_after(it->wd->reorder_it, it->wd->reorder_rel);
-               }
+             if (it_scrl_y <= it->wd->reorder_rel->scrl_y)
+               _item_move_before(it->wd->reorder_it, it->wd->reorder_rel);
              else
-               {
-                  if (it->wd->calc_job) ecore_job_del(it->wd->calc_job);
-                  it->wd->calc_job = ecore_job_add(_calc_job, it->wd);
-               }
+               _item_move_after(it->wd->reorder_it, it->wd->reorder_rel);
           }
+        else
+          {
+             if (it->wd->calc_job) ecore_job_del(it->wd->calc_job);
+             it->wd->calc_job = ecore_job_add(_calc_job, it->wd);
+          }
         edje_object_signal_emit(it->base.view, "elm,state,reorder,disabled", "elm");
         it->wd->reorder_it = it->wd->reorder_rel = NULL;
         elm_smart_scroller_hold_set(it->wd->scr, EINA_FALSE);
+        elm_smart_scroller_bounce_allow_set(it->wd->scr, EINA_FALSE, EINA_TRUE);
      }
    if (it->wd->longpressed)
      {

Log:
elm diskselector: Fixed elm_diskselector_item_selected_set() hanging bug. Patch by Hyoyoung Chang <hyoyoung.chang@...> 
  
  On Wed, Sep 7, 2011 at 6:51 PM, Hyoyoung Chang <hyoyoung.chang@...> wrote:
  > Dear developers.
  >
  > This patch is fixing - hangs after using elm_diskselector_item_selected_set.
  > Elm_diskselector add a idler and remove in _move_scroller with checking
  > wd->idler
  > But in elm_diskselector_item_selected_set, it's not use wd->idler.
  > So idler is called infinite.
  >
  > It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854 )
  >
  > Thank you
  
  On Wed, Sep 7, 2011 at 7:00 PM, Hyoyoung Chang <hyoyoung.chang@...> wrote:
  > I omitted about credit.
  > With cnook, I can easily find this bug.
  > Thanks to cnook
  

Author:       seoz
Date:         2011-09-07 08:02:27 -0700 (Wed, 07 Sep 2011)
New Revision: 63269
Trac:         http://trac.enlightenment.org/e/changeset/63269

Modified:
  trunk/elementary/src/lib/elm_diskselector.c 

Modified: trunk/elementary/src/lib/elm_diskselector.c
===================================================================
--- trunk/elementary/src/lib/elm_diskselector.c	2011-09-07 12:30:30 UTC (rev 63268)
+++ trunk/elementary/src/lib/elm_diskselector.c	2011-09-07 15:02:27 UTC (rev 63269)
@@ -1181,7 +1181,7 @@
      }
 
    if (!wd->idler)
-     ecore_idler_add(_move_scroller, it->base.widget);
+     wd->idler = ecore_idler_add(_move_scroller, it->base.widget);
 }
 
 EAPI Eina_Bool

Log:
elm elm_widget.c: Fixed indentation.
  

Author:       seoz
Date:         2011-09-13 09:59:25 -0700 (Tue, 13 Sep 2011)
New Revision: 63361
Trac:         http://trac.enlightenment.org/e/changeset/63361

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-09-13 16:58:10 UTC (rev 63360)
+++ trunk/elementary/src/lib/elm_widget.c	2011-09-13 16:59:25 UTC (rev 63361)
@@ -3400,30 +3400,30 @@
 _smart_init(void)
 {
    if (_e_smart) return;
-   {
-      static const Evas_Smart_Class sc =
-      {
-         SMART_NAME,
-         EVAS_SMART_CLASS_VERSION,
-         _smart_add,
-         _smart_del,
-         _smart_move,
-         _smart_resize,
-         _smart_show,
-         _smart_hide,
-         _smart_color_set,
-         _smart_clip_set,
-         _smart_clip_unset,
-         _smart_calculate,
-         NULL,
-         NULL,
-         NULL,
-         NULL,
-         NULL,
-         NULL
-      };
-      _e_smart = evas_smart_class_new(&sc);
-   }
+     {
+        static const Evas_Smart_Class sc =
+          {
+             SMART_NAME,
+             EVAS_SMART_CLASS_VERSION,
+             _smart_add,
+             _smart_del,
+             _smart_move,
+             _smart_resize,
+             _smart_show,
+             _smart_hide,
+             _smart_color_set,
+             _smart_clip_set,
+             _smart_clip_unset,
+             _smart_calculate,
+             NULL,
+             NULL,
+             NULL,
+             NULL,
+             NULL,
+             NULL
+          };
+        _e_smart = evas_smart_class_new(&sc);
+     }
 }
 
 /* happy debug functions */

Log:
elm button: Added _del_pre_hook to button. This reduces unnecessary calculations
  and min setttings.
  

Author:       seoz
Date:         2011-09-14 02:53:11 -0700 (Wed, 14 Sep 2011)
New Revision: 63378
Trac:         http://trac.enlightenment.org/e/changeset/63378

Modified:
  trunk/elementary/src/lib/elm_button.c 

Modified: trunk/elementary/src/lib/elm_button.c
===================================================================
--- trunk/elementary/src/lib/elm_button.c	2011-09-14 09:51:38 UTC (rev 63377)
+++ trunk/elementary/src/lib/elm_button.c	2011-09-14 09:53:11 UTC (rev 63378)
@@ -7,15 +7,17 @@
 {
    Evas_Object *btn, *icon;
    const char *label;
-   Eina_Bool autorepeat;
-   Eina_Bool repeating;
    double ar_threshold;
    double ar_interval;
    Ecore_Timer *timer;
+   Eina_Bool autorepeat : 1;
+   Eina_Bool repeating : 1;
+   Eina_Bool delete_me : 1;
 };
 
 static const char *widtype = NULL;
 static void _del_hook(Evas_Object *obj);
+static void _del_pre_hook(Evas_Object *obj);
 static void _theme_hook(Evas_Object *obj);
 static void _disable_hook(Evas_Object *obj);
 static void _sizing_eval(Evas_Object *obj);
@@ -62,6 +64,14 @@
 }
 
 static void
+_del_pre_hook(Evas_Object *obj)
+{
+   Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return;
+   wd->delete_me = EINA_TRUE;
+}
+
+static void
 _del_hook(Evas_Object *obj)
 {
    Widget_Data *wd = elm_widget_data_get(obj);
@@ -169,6 +179,7 @@
    Evas_Coord minw = -1, minh = -1;
 
    if (!wd) return;
+   if (wd->delete_me) return;
    elm_coords_finger_size_adjust(1, &minw, 1, &minh);
    edje_object_size_min_restricted_calc(wd->btn, &minw, &minh, minw, minh);
    elm_coords_finger_size_adjust(1, &minw, 1, &minh);
@@ -354,6 +365,7 @@
    elm_widget_on_focus_hook_set(obj, _on_focus_hook, NULL);
    elm_widget_data_set(obj, wd);
    elm_widget_del_hook_set(obj, _del_hook);
+   elm_widget_del_pre_hook_set(obj, _del_pre_hook);
    elm_widget_theme_hook_set(obj, _theme_hook);
    elm_widget_disable_hook_set(obj, _disable_hook);
    elm_widget_can_focus_set(obj, EINA_TRUE);

Log:
elm icon: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-09-14 19:20:26 -0700 (Wed, 14 Sep 2011)
New Revision: 63404
Trac:         http://trac.enlightenment.org/e/changeset/63404

Modified:
  trunk/elementary/src/lib/elm_icon.c 

Modified: trunk/elementary/src/lib/elm_icon.c
===================================================================
--- trunk/elementary/src/lib/elm_icon.c	2011-09-15 02:16:37 UTC (rev 63403)
+++ trunk/elementary/src/lib/elm_icon.c	2011-09-15 02:20:26 UTC (rev 63404)
@@ -713,7 +713,7 @@
    if (!wd) return;
 
 #ifdef HAVE_ELEMENTARY_ETHUMB
-   evas_object_event_callback_del_full(obj, EVAS_CALLBACK_RESIZE, 
+   evas_object_event_callback_del_full(obj, EVAS_CALLBACK_RESIZE,
 				       _elm_icon_standard_resize, wd);
    evas_object_event_callback_del_full(obj, EVAS_CALLBACK_RESIZE,
 				       _elm_icon_thumb_resize, wd);

Log:
elm: Removed trailing whitespaces.
  

Author:       seoz
Date:         2011-09-21 03:37:23 -0700 (Wed, 21 Sep 2011)
New Revision: 63512
Trac:         http://trac.enlightenment.org/e/changeset/63512

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_widget.c trunk/elementary/src/lib/elm_widget.h 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-09-21 10:35:03 UTC (rev 63511)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-09-21 10:37:23 UTC (rev 63512)
@@ -26659,37 +26659,37 @@
    EAPI void elm_player_video_set(Evas_Object *player, Evas_Object *video);
 
    /**
-    * @defgroup Naviframe Naviframe 
+    * @defgroup Naviframe Naviframe
     *
     * @brief Naviframe is a kind of view manager for the applications.
     *
-    * Naviframe provies functions to switch the different pages with stack 
+    * Naviframe provies functions to switch the different pages with stack
     * mechanism. It means if one page(item) needs to be changed to the new one,
     * then naviframe would push the new page to it's internal stack. Of course,
-    * it can be back to the previous page by popping the top page. Naviframe 
-    * provides some transition effect while the pages are switching (such as 
+    * it can be back to the previous page by popping the top page. Naviframe
+    * provides some transition effect while the pages are switching (such as
     * pager).
     *
     * Since the each item could keep the different styles, users could keep the
-    * same look & feel for the pages or different styles for the items in it's 
-    * application. 
-    * 
+    * same look & feel for the pages or different styles for the items in it's
+    * application.
+    *
     * Signals that you can add callback for are:
     *
     * @li "transition,finished" - When the transition is finished in changing
-    *     the item 
+    *     the item
     * @li "title,clicked" - User clicked title area
-    * 
+    *
     * Default contents parts for the naviframe items that you can use for are:
-    * 
-    * @li "elm.swallow.content" - The main content of the page 
+    *
+    * @li "elm.swallow.content" - The main content of the page
     * @li "elm.swallow.prev_btn" - The button to go to the previous page
-    * @li "elm.swallow.next_btn" - The button to go to the next page 
+    * @li "elm.swallow.next_btn" - The button to go to the next page
     *
     * Default text parts for the naviframe items that you can use for are:
-    * 
-    * @li "elm.text.title" - The title label in the title area 
     *
+    * @li "elm.text.title" - The title label in the title area
+    *
     * @ref tutorial_naviframe gives a good overview of the usage of the API.
     * @{
     */
@@ -26704,23 +26704,23 @@
     * @brief Push a new item to the top of the naviframe stack (and show it).
     *
     * @param obj The naviframe object
-    * @param title_label The label in the title area. The name of the title 
+    * @param title_label The label in the title area. The name of the title
     *        label part is "elm.text.title"
-    * @param prev_btn The button to go to the previous item. If it is NULL, 
+    * @param prev_btn The button to go to the previous item. If it is NULL,
     *        then naviframe will create a back button automatically. The name of
     *        the prev_btn part is "elm.swallow.prev_btn"
     * @param next_btn The button to go to the next item. Or It could be just an
     *        extra function button. The name of the next_btn part is
     *        "elm.swallow.next_btn"
-    * @param content The main content object. The name of content part is 
+    * @param content The main content object. The name of content part is
     *        "elm.swallow.content"
     * @param item_style The current item style name. @c NULL would be default.
     * @return The created item or @c NULL upon failure.
     *
-    * The item pushed becomes one page of the naviframe, this item will be 
+    * The item pushed becomes one page of the naviframe, this item will be
     * deleted when it is popped.
     *
-    * @see also elm_naviframe_item_style_set()    
+    * @see also elm_naviframe_item_style_set()
     *
     * The following styles are available for this item:
     * @li @c "default"
@@ -26730,54 +26730,54 @@
     * @brief Pop an item that is on top of the stack
     *
     * @param obj The naviframe object
-    * @return @c NULL or the content object(if the 
+    * @return @c NULL or the content object(if the
     *         elm_naviframe_content_preserve_on_pop_get is true).
     *
     * This pops an item that is on the top(visible) of the naviframe, makes it
-    * disappear, then deletes the item. The item that was underneath it on the 
+    * disappear, then deletes the item. The item that was underneath it on the
     * stack will become visible.
-    *  
+    *
     * @see also elm_naviframe_content_preserve_on_pop_get()
     */
    EAPI Evas_Object        *elm_naviframe_item_pop(Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
-    * @brief Pop the items between the top and the above one on the given item. 
+    * @brief Pop the items between the top and the above one on the given item.
     *
-    * @param it The naviframe item 
+    * @param it The naviframe item
     */
    EAPI void                elm_naviframe_item_pop_to(Elm_Object_Item *it) EINA_ARG_NONNULL(1);
    /**
-    * @brief preserve the content objects when items are popped.  
+    * @brief preserve the content objects when items are popped.
     *
-    * @param obj The naviframe object 
+    * @param obj The naviframe object
     * @param preserve Enable the preserve mode if EINA_TRUE, disable otherwise
     *
     * @see also elm_naviframe_content_preserve_on_pop_get()
     */
    EAPI void                elm_naviframe_content_preserve_on_pop_set(Evas_Object *obj, Eina_Bool preserve) EINA_ARG_NONNULL(1);
    /**
-    * @brief Get a value whether preserve mode is enabled or not.  
+    * @brief Get a value whether preserve mode is enabled or not.
     *
     * @param obj The naviframe object
-    * @return If @c EINA_TRUE, preserve mode is enabled 
+    * @return If @c EINA_TRUE, preserve mode is enabled
     *
     * @see also elm_naviframe_content_preserve_on_pop_set()
     */
    EAPI Eina_Bool           elm_naviframe_content_preserve_on_pop_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
-    * @brief Get a top item on the naviframe stack  
+    * @brief Get a top item on the naviframe stack
     *
     * @param obj The naviframe object
-    * @return The top item on the naviframe stack or @c NULL, if the stack is 
-    *         empty 
+    * @return The top item on the naviframe stack or @c NULL, if the stack is
+    *         empty
     */
    EAPI Elm_Object_Item    *elm_naviframe_top_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
-    * @brief Get a bottom item on the naviframe stack  
+    * @brief Get a bottom item on the naviframe stack
     *
     * @param obj The naviframe object
     * @return The bottom item on the naviframe stack or @c NULL, if the stack is
-    *         empty 
+    *         empty
     */
    EAPI Elm_Object_Item    *elm_naviframe_bottom_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
@@ -26785,7 +26785,7 @@
     *
     * @param obj The naviframe item
     * @param item_style The current item style name. @c NULL would be default
-    * 
+    *
     * The following styles are available for this item:
     * @li @c "default"
     *
@@ -26797,7 +26797,7 @@
     *
     * @param obj The naviframe item
     * @return The current item style name
-    * 
+    *
     * @see also elm_naviframe_item_style_set()
     */
    EAPI const char         *elm_naviframe_item_style_get(const Elm_Object_Item *it) EINA_ARG_NONNULL(1);
@@ -26805,20 +26805,20 @@
     * @brief Show/Hide the title area
     *
     * @param it The naviframe item
-    * @param visible If @c EINA_TRUE, title area will be visible, disable 
+    * @param visible If @c EINA_TRUE, title area will be visible, disable
     *        otherwise
-    * 
+    *
     * When the title area is invisible, then the controls would be hidden so as     * to expand the content area to full-size.
-    * 
+    *
     * @see also elm_naviframe_item_title_visible_get()
     */
    EAPI void                elm_naviframe_item_title_visible_set(Elm_Object_Item *it, Eina_Bool visible) EINA_ARG_NONNULL(1);
    /**
-    * @brief Get a value whether title area is visible or not. 
+    * @brief Get a value whether title area is visible or not.
     *
-    * @param it The naviframe item 
+    * @param it The naviframe item
     * @return If @c EINA_TRUE, title area is visible
-    * 
+    *
     * @see also elm_naviframe_item_title_visible_set()
     */
    EAPI Eina_Bool           elm_naviframe_item_title_visible_get(const Elm_Object_Item *it) EINA_ARG_NONNULL(1);

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-09-21 10:35:03 UTC (rev 63511)
+++ trunk/elementary/src/lib/elm_widget.c	2011-09-21 10:37:23 UTC (rev 63512)
@@ -2286,7 +2286,6 @@
    return sd->access_info;
 }
 
-
 EAPI Elm_Theme *
 elm_widget_theme_get(const Evas_Object *obj)
 {

Modified: trunk/elementary/src/lib/elm_widget.h
===================================================================
--- trunk/elementary/src/lib/elm_widget.h	2011-09-21 10:35:03 UTC (rev 63511)
+++ trunk/elementary/src/lib/elm_widget.h	2011-09-21 10:37:23 UTC (rev 63512)
@@ -451,7 +451,6 @@
 EAPI void             _elm_widget_item_signal_emit_hook_set(Elm_Widget_Item *it, Elm_Widget_On_Signal_Emit_Cb func);
 EAPI void             _elm_widget_item_access_info_set(Elm_Widget_Item *item, const char *txt);
 
-
 /* debug function. don't use it unless you are tracking parenting issues */
 EAPI void             elm_widget_tree_dump(const Evas_Object *top);
 EAPI void             elm_widget_tree_dot_dump(const Evas_Object *top, FILE *output);

Log:
elm map: Coding convention.
  

Author:       seoz
Date:         2011-09-21 03:44:06 -0700 (Wed, 21 Sep 2011)
New Revision: 63513
Trac:         http://trac.enlightenment.org/e/changeset/63513

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-09-21 10:37:23 UTC (rev 63512)
+++ trunk/elementary/src/lib/elm_map.c	2011-09-21 10:44:06 UTC (rev 63513)
@@ -735,6 +735,7 @@
 {
    ELM_CHECK_WIDTYPE(data, widtype);
    Widget_Data *wd = elm_widget_data_get(data);
+   int ow, oh, iw, ih;
    if ((!wd->pinch.cx) && (!wd->pinch.cy))
      {
         wd->pinch.cx = wd->rotate.cx;
@@ -742,10 +743,9 @@
      }
 
    evas_map_util_points_populate_from_object_full(wd->map, obj, 0);
-   int ow, oh, iw, ih;
    evas_object_image_size_get(obj, &iw, &ih);
    evas_object_geometry_get(obj, NULL, NULL, &ow, &oh);
-   if (ow < iw || oh < ih)
+   if ((ow < iw) || (oh < ih))
      {
         ow *= (double)iw / ow;
         oh *= (double)ih / oh;

Log:
elm genlist: Added genlist event hook boundary check routine.
  

Author:       seoz
Date:         2011-09-22 05:39:49 -0700 (Thu, 22 Sep 2011)
New Revision: 63536
Trac:         http://trac.enlightenment.org/e/changeset/63536

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-09-22 11:31:22 UTC (rev 63535)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-09-22 12:39:49 UTC (rev 63536)
@@ -212,6 +212,9 @@
                                    const char *source);
 static Eina_Bool _deselect_all_items(Widget_Data *wd);
 static void      _pan_calculate(Evas_Object *obj);
+static void      _pan_max_get(Evas_Object *obj,
+                              Evas_Coord  *x,
+                              Evas_Coord  *y);
 static void      _item_position(Elm_Genlist_Item *it,
                                 Evas_Object      *obj,
                                 Evas_Coord        it_x,
@@ -310,6 +313,7 @@
    if (type != EVAS_CALLBACK_KEY_DOWN) return EINA_FALSE;
    Evas_Event_Key_Down *ev = event_info;
    Widget_Data *wd = elm_widget_data_get(obj);
+   Evas_Coord pan_max_x = 0, pan_max_y = 0;
    if (!wd) return EINA_FALSE;
    if (!wd->items) return EINA_FALSE;
    if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD) return EINA_FALSE;
@@ -414,6 +418,11 @@
    else return EINA_FALSE;
 
    ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
+   _pan_max_get(wd->pan_smart, &pan_max_x, &pan_max_y);
+   if (x < 0) x = 0;
+   if (x > pan_max_x) x = pan_max_x;
+   if (y < 0) y = 0;
+   if (y > pan_max_y) y = pan_max_y;
    elm_smart_scroller_child_pos_set(wd->scr, x, y);
    return EINA_TRUE;
 }

Log:
elm els_scroller.c: Always check and delete hold_animator on mouse up.
  

Author:       seoz
Date:         2011-09-22 10:40:44 -0700 (Thu, 22 Sep 2011)
New Revision: 63539
Trac:         http://trac.enlightenment.org/e/changeset/63539

Modified:
  trunk/elementary/src/lib/els_scroller.c 

Modified: trunk/elementary/src/lib/els_scroller.c
===================================================================
--- trunk/elementary/src/lib/els_scroller.c	2011-09-22 14:10:04 UTC (rev 63538)
+++ trunk/elementary/src/lib/els_scroller.c	2011-09-22 17:40:44 UTC (rev 63539)
@@ -2024,13 +2024,6 @@
                                    }
                               }
                          }
-                       if (sd->down.hold_animator)
-                         {
-                            ecore_animator_del(sd->down.hold_animator);
-                            sd->down.hold_animator = NULL;
-                            if (sd->child.resized)
-                              _elm_smart_scroller_wanted_region_set(sd->smart_obj);
-                         }
                     }
                   else
                     {
@@ -2087,14 +2080,14 @@
                             if (pgy != y) _smart_scrollto_y(sd, _elm_config->page_scroll_friction, pgy);
                          }
                     }
-                  if (sd->down.hold_animator)
-                    {
-                       ecore_animator_del(sd->down.hold_animator);
-                       sd->down.hold_animator = NULL;
-                       if (sd->child.resized)
-                         _elm_smart_scroller_wanted_region_set(sd->smart_obj);
-                    }
                }
+             if (sd->down.hold_animator)
+               {
+                  ecore_animator_del(sd->down.hold_animator);
+                  sd->down.hold_animator = NULL;
+                  if (sd->child.resized)
+                    _elm_smart_scroller_wanted_region_set(sd->smart_obj);
+               }
              if (sd->down.scroll)
                {
                   ev->event_flags |= EVAS_EVENT_FLAG_ON_SCROLL;

Log:
elm genlist: Changed internal variable name. old_pan_y ->
  reorder_old_pan_y.
  

Author:       seoz
Date:         2011-09-23 01:32:32 -0700 (Fri, 23 Sep 2011)
New Revision: 63561
Trac:         http://trac.enlightenment.org/e/changeset/63561

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-09-23 08:20:14 UTC (rev 63560)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-09-23 08:32:32 UTC (rev 63561)
@@ -20,7 +20,7 @@
    Eina_Inlist      *items, *blocks;
    Eina_List        *group_items;
    Pan              *pan;
-   Evas_Coord        pan_x, pan_y, old_pan_y, w, h, minw, minh, realminw, prev_viewport_w;
+   Evas_Coord        pan_x, pan_y, reorder_old_pan_y, w, h, minw, minh, realminw, prev_viewport_w;
    Ecore_Job        *calc_job, *update_job;
    Ecore_Idle_Enterer *queue_idle_enterer;
    Ecore_Idler        *must_recalc_idler;
@@ -2736,11 +2736,11 @@
       _group_items_recalc(sd->wd);
    if ((sd->wd->reorder_mode) && (sd->wd->reorder_it))
      {
-        if (sd->wd->pan_y != sd->wd->old_pan_y)
+        if (sd->wd->pan_y != sd->wd->reorder_old_pan_y)
            sd->wd->reorder_pan_move = EINA_TRUE;
         else sd->wd->reorder_pan_move = EINA_FALSE;
         evas_object_raise(sd->wd->reorder_it->base.view);
-        sd->wd->old_pan_y = sd->wd->pan_y;
+        sd->wd->reorder_old_pan_y = sd->wd->pan_y;
         sd->wd->start_time = ecore_loop_time_get();
      }
    _item_auto_scroll(sd->wd);
@@ -3800,7 +3800,7 @@
    wd->show_item = NULL;
    wd->pan_x = 0;
    wd->pan_y = 0;
-   wd->old_pan_y = 0;
+   wd->reorder_old_pan_y = 0;
    wd->minw = 0;
    wd->minh = 0;
    if (wd->pan_smart)

Log:
elm icon: Fixed build break from cedric commit r63537. Fixed build
  warnings.
  

Author:       seoz
Date:         2011-09-26 23:40:06 -0700 (Mon, 26 Sep 2011)
New Revision: 63621
Trac:         http://trac.enlightenment.org/e/changeset/63621

Modified:
  trunk/elementary/src/lib/elm_icon.c 

Modified: trunk/elementary/src/lib/elm_icon.c
===================================================================
--- trunk/elementary/src/lib/elm_icon.c	2011-09-27 06:16:34 UTC (rev 63620)
+++ trunk/elementary/src/lib/elm_icon.c	2011-09-27 06:40:06 UTC (rev 63621)
@@ -479,7 +479,11 @@
 }
 
 static Eina_Bool
+#ifdef ELM_EFREET
 _icon_file_set(Widget_Data *wd, Evas_Object *obj, const char *path)
+#else
+_icon_file_set(Widget_Data *wd __UNUSED__, Evas_Object *obj, const char *path)
+#endif
 {
    if (elm_icon_file_set(obj, path, NULL))
      {
@@ -493,7 +497,11 @@
 }
 
 static Eina_Bool
+#ifdef ELM_EFREET
 _icon_freedesktop_set(Widget_Data *wd, Evas_Object *obj, const char *name, int size)
+#else
+_icon_freedesktop_set(Widget_Data *wd __UNUSED__, Evas_Object *obj __UNUSED__, const char *name __UNUSED__, int size __UNUSED__)
+#endif
 {
 #ifdef ELM_EFREET
    const char *path;
@@ -696,11 +704,13 @@
        && (group == tmp_group || (group && tmp_group && !strcmp(group, tmp_group))))
      return EINA_TRUE;
 
+#ifdef ELM_EFREET
    if (!wd->freedesktop.use)
      {
         if (wd->stdicon) eina_stringshare_del(wd->stdicon);
-	wd->stdicon = NULL;
+        wd->stdicon = NULL;
      }
+#endif
    if (eina_str_has_extension(file, ".edj"))
      ret = _els_smart_icon_file_edje_set(wd->img, file, group);
    else

Log:
elm gengrid: Added "scroll,edge,top/bottom/left/right" smart callbacks.
  

Author:       seoz
Date:         2011-09-27 08:04:57 -0700 (Tue, 27 Sep 2011)
New Revision: 63625
Trac:         http://trac.enlightenment.org/e/changeset/63625

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-09-27 13:38:27 UTC (rev 63624)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-09-27 15:04:57 UTC (rev 63625)
@@ -7902,6 +7902,14 @@
     *   started.
     * - @c "scroll,drag,stop" - called when dragging the content has
     *   stopped.
+    * - @c "scroll,edge,top" - This is called when the gengrid is scrolled until
+    *   the top edge.
+    * - @c "scroll,edge,bottom" - This is called when the gengrid is scrolled
+    *   until the bottom edge.
+    * - @c "scroll,edge,left" - This is called when the gengrid is scrolled
+    *   until the left edge.
+    * - @c "scroll,edge,right" - This is called when the gengrid is scrolled
+    *   until the right edge.
     *
     * List of gengrid examples:
     * @li @ref gengrid_example

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-09-27 13:38:27 UTC (rev 63624)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-09-27 15:04:57 UTC (rev 63625)
@@ -152,6 +152,10 @@
 static const char SIG_SCROLL_ANIM_STOP[] = "scroll,anim,stop";
 static const char SIG_SCROLL_DRAG_START[] = "scroll,drag,start";
 static const char SIG_SCROLL_DRAG_STOP[] = "scroll,drag,stop";
+static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top";
+static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom";
+static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left";
+static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right";
 static const char SIG_MOVED[] = "moved";
 
 static const Evas_Smart_Cb_Description _signals[] = {
@@ -174,6 +178,10 @@
    {SIG_SCROLL_ANIM_STOP, ""},
    {SIG_SCROLL_DRAG_START, ""},
    {SIG_SCROLL_DRAG_STOP, ""},
+   {SIG_SCROLL_EDGE_TOP, ""},
+   {SIG_SCROLL_EDGE_BOTTOM, ""},
+   {SIG_SCROLL_EDGE_LEFT, ""},
+   {SIG_SCROLL_EDGE_RIGHT, ""},
    {SIG_MOVED, ""},
    {NULL, NULL}
 };
@@ -1856,6 +1864,38 @@
 }
 
 static void
+_scr_edge_left(void        *data,
+               Evas_Object *scr __UNUSED__,
+               void        *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_LEFT, NULL);
+}
+
+static void
+_scr_edge_right(void        *data,
+                Evas_Object *scr __UNUSED__,
+                void        *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_RIGHT, NULL);
+}
+
+static void
+_scr_edge_top(void        *data,
+              Evas_Object *scr __UNUSED__,
+              void        *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_TOP, NULL);
+}
+
+static void
+_scr_edge_bottom(void        *data,
+                 Evas_Object *scr __UNUSED__,
+                 void        *event_info __UNUSED__)
+{
+   evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_BOTTOM, NULL);
+}
+
+static void
 _scr_scroll(void            *data,
             Evas_Object *obj __UNUSED__,
             void *event_info __UNUSED__)
@@ -1914,6 +1954,11 @@
    evas_object_smart_callback_add(wd->scr, "animate,stop", _scr_anim_stop, obj);
    evas_object_smart_callback_add(wd->scr, "drag,start", _scr_drag_start, obj);
    evas_object_smart_callback_add(wd->scr, "drag,stop", _scr_drag_stop, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,left", _scr_edge_left, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,right", _scr_edge_right, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,top", _scr_edge_top, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,bottom", _scr_edge_bottom,
+                                  obj);
    evas_object_smart_callback_add(wd->scr, "scroll", _scr_scroll, obj);
 
    elm_smart_scroller_bounce_allow_set(wd->scr, bounce, bounce);

Log:
elm genlist: Removed unnecessary local variable.
  

Author:       seoz
Date:         2011-09-27 22:56:28 -0700 (Tue, 27 Sep 2011)
New Revision: 63638
Trac:         http://trac.enlightenment.org/e/changeset/63638

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-09-28 05:34:30 UTC (rev 63637)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-09-28 05:56:28 UTC (rev 63638)
@@ -2352,7 +2352,7 @@
    Evas_Coord minw = -1, minh = 0, y = 0, ow;
    int in = 0;
    double t0, t;
-   Eina_Bool minw_change = EINA_FALSE, changed = EINA_FALSE;
+   Eina_Bool minw_change = EINA_FALSE;
    Eina_Bool did_must_recalc = EINA_FALSE;
    if (!wd) return;
 
@@ -2373,10 +2373,9 @@
           {
              if (itb->realized) _item_block_unrealize(itb);
           }
-        if ((itb->changed) || (changed) ||
-            ((itb->must_recalc) && (!did_must_recalc)))
+        if ((itb->changed) || ((itb->must_recalc) && (!did_must_recalc)))
           {
-             if ((changed) || (itb->must_recalc))
+             if (itb->must_recalc)
                {
                   Eina_List *l;
                   Elm_Genlist_Item *it;

Log:
elm gengrid: Propagate Gengrid signals to the internal edje view. Patch by Benjamin Drucker <benjamin.t.drucker@...>
  
  On Tue, Oct 4, 2011 at 7:54 AM, Benjamin Drucker
  <benjamin.t.drucker@...> wrote:
  > Right now, signals coming from the gengrid's internal edje object are
  > propagated up to the gengrid object.
  > This patch enables the other direction as well: you can use the
  functions
  >
  > ?\194?\160elm_object_signal_callback_add(grid, ...)
  > ?\194?\160elm_object_signal_callback_del(grid, ...)
  >
  > to signal the gengrid's internal edje object.
  >
  > Please review, thanks.
  > -Ben
  

Author:       seoz
Date:         2011-10-03 18:24:08 -0700 (Mon, 03 Oct 2011)
New Revision: 63784
Trac:         http://trac.enlightenment.org/e/changeset/63784

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-10-04 00:59:18 UTC (rev 63783)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-10-04 01:24:08 UTC (rev 63784)
@@ -641,6 +641,32 @@
 }
 
 static void
+_signal_callback_add_hook(Evas_Object *obj,
+                          const char  *emission,
+                          const char  *source,
+                          Edje_Signal_Cb func_cb,
+                          void *data)
+{
+   Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return;
+   edje_object_signal_callback_add(elm_smart_scroller_edje_object_get(wd->scr),
+                                   emission, source, func_cb, data);
+}
+
+static void
+_signal_callback_del_hook(Evas_Object *obj,
+                          const char  *emission,
+                          const char  *source,
+                          Edje_Signal_Cb func_cb,
+                          void *data)
+{
+   Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return;
+   edje_object_signal_callback_del_full(elm_smart_scroller_edje_object_get(wd->scr),
+                                        emission, source, func_cb, data);
+}
+
+static void
 _mouse_move(void        *data,
             Evas *evas   __UNUSED__,
             Evas_Object *obj,
@@ -1952,6 +1978,8 @@
    elm_widget_theme_hook_set(obj, _theme_hook);
    elm_widget_signal_emit_hook_set(obj, _signal_emit_hook);
    elm_widget_can_focus_set(obj, EINA_TRUE);
+   elm_widget_signal_callback_add_hook_set(obj, _signal_callback_add_hook);
+   elm_widget_signal_callback_del_hook_set(obj, _signal_callback_del_hook);
    elm_widget_event_hook_set(obj, _event_hook);
 
    wd->scr = elm_smart_scroller_add(e);

Log:
elm genlist: Raise genlist group index when the group's sub item mode
  is changed.
  

Author:       seoz
Date:         2011-10-06 22:54:29 -0700 (Thu, 06 Oct 2011)
New Revision: 63898
Trac:         http://trac.enlightenment.org/e/changeset/63898

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-10-07 01:14:31 UTC (rev 63897)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-10-07 05:54:29 UTC (rev 63898)
@@ -1491,6 +1491,8 @@
    evas_event_freeze(te);
    it->nocache = EINA_FALSE;
    _mode_item_unrealize(it);
+   if (it->group_item)
+     evas_object_raise(it->group_item->base.view);
    snprintf(buf, sizeof(buf), "elm,state,%s,passive,finished", it->wd->mode_type);
    edje_object_signal_callback_del_full(obj, buf, "elm", _mode_finished_signal_cb, it);
    evas_event_thaw(te);
@@ -2972,6 +2974,8 @@
 
    evas_event_freeze(evas_object_evas_get(it->wd->obj));
    _mode_item_realize(it);
+   if (it->group_item)
+     evas_object_raise(it->group_item->base.view);
    _item_position(it, it->mode_view, it->scrl_x, it->scrl_y);
    evas_event_thaw(evas_object_evas_get(it->wd->obj));
    evas_event_thaw_eval(evas_object_evas_get(it->wd->obj));

Log:
elm genlist: Added comments for internal variables.
  

Author:       seoz
Date:         2011-10-12 08:23:55 -0700 (Wed, 12 Oct 2011)
New Revision: 64020
Trac:         http://trac.enlightenment.org/e/changeset/64020

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-10-12 12:19:31 UTC (rev 64019)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-10-12 15:23:55 UTC (rev 64020)
@@ -17,18 +17,24 @@
 struct _Widget_Data
 {
    Eina_Inlist_Sorted_State *state;
-   Evas_Object      *obj, *scr, *pan_smart;
-   Eina_Inlist      *items, *blocks;
-   Eina_List        *group_items;
-   Pan              *pan;
+   Evas_Object      *obj; /* the genlist object */
+   Evas_Object      *scr; /* a smart scroller object which is used internally in genlist */
+   Evas_Object      *pan_smart; /* "elm_genlist_pan" evas smart object. this is an extern pan of smart scroller(scr). */
+   Eina_Inlist      *items; /* inlist of all items */
+   Eina_Inlist      *blocks; /* inlist of all blocks. a block consists of a certain number of items. maximum number of items in a block is 'max_items_per_block'. */
+   Eina_List        *group_items; /* list of groups index items */
+   Pan              *pan; /* pan_smart object's smart data */
    Evas_Coord        pan_x, pan_y, reorder_old_pan_y, w, h, minw, minh, realminw, prev_viewport_w;
    Ecore_Job        *calc_job, *update_job;
    Ecore_Idle_Enterer *queue_idle_enterer;
    Ecore_Idler        *must_recalc_idler;
    Eina_List        *queue, *selected;
-   Elm_Genlist_Item *show_item, *last_selected_item, *anchor_item, *mode_item, *reorder_it, *reorder_rel, *expanded_item;
-   Eina_Inlist      *item_cache;
-   Evas_Coord        anchor_y, reorder_start_y;
+   Elm_Genlist_Item *show_item, *anchor_item, *mode_item, *reorder_rel, *expanded_item;
+   Elm_Genlist_Item *last_selected_item; /* the last selected item. */
+   Elm_Genlist_Item *reorder_it; /* an item which is longpressed and in the moving state. */
+   Eina_Inlist      *item_cache; /* an inlist of edje object item cache. */
+   Evas_Coord        anchor_y;
+   Evas_Coord        reorder_start_y; /* reorder item's initial y coordinate in the pan. */
    Elm_List_Mode     mode;
    Ecore_Timer      *multi_timer, *scr_hold_timer;
    Ecore_Animator   *reorder_move_animator;
@@ -62,15 +68,15 @@
    } history[SWIPE_MOVES];
    int               multi_device;
    int               item_cache_count;
-   int               item_cache_max;
+   int               item_cache_max; /* maximum number of cached items */
    int               movements;
    int               walking;
    int               item_width;
    int               item_height;
    int               group_item_width;
    int               group_item_height;
-   int               max_items_per_block;
-   double            longpress_timeout;
+   int               max_items_per_block; /* maximum number of items per block */
+   double            longpress_timeout; /* longpress timeout. this value comes from _elm_config by default. this can be changed by elm_genlist_longpress_timeout_set() */
 };
 
 struct _Item_Block

Log:
elm genlist: Clear last_selected_item when last_selected_item is
  deleted.
  

Author:       seoz
Date:         2011-10-12 20:47:57 -0700 (Wed, 12 Oct 2011)
New Revision: 64031
Trac:         http://trac.enlightenment.org/e/changeset/64031

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-10-13 02:22:29 UTC (rev 64030)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-10-13 03:47:57 UTC (rev 64031)
@@ -1702,6 +1702,15 @@
 }
 
 static void
+_item_del_hook(void *data __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info)
+{
+   Elm_Genlist_Item *it = event_info;
+   if (!it) return;
+   if (it->wd->last_selected_item == it)
+     it->wd->last_selected_item = NULL;
+}
+
+static void
 _item_label_realize(Elm_Genlist_Item *it,
                     Evas_Object *target,
                     Eina_List **source)
@@ -3158,6 +3167,7 @@
    it->mouse_cursor = NULL;
    it->expanded_depth = 0;
    elm_widget_item_text_get_hook_set(it, _item_label_hook);
+   elm_widget_item_del_cb_set(it, _item_del_hook);
 
    if (it->parent)
      {

Log:
elm scroller: Fixed wrong return value.
  

Author:       seoz
Date:         2011-10-14 17:44:11 -0700 (Fri, 14 Oct 2011)
New Revision: 64078
Trac:         http://trac.enlightenment.org/e/changeset/64078

Modified:
  trunk/elementary/src/lib/elm_scroller.c 

Modified: trunk/elementary/src/lib/elm_scroller.c
===================================================================
--- trunk/elementary/src/lib/elm_scroller.c	2011-10-14 18:24:08 UTC (rev 64077)
+++ trunk/elementary/src/lib/elm_scroller.c	2011-10-15 00:44:11 UTC (rev 64078)
@@ -722,9 +722,9 @@
 EAPI void
 elm_scroller_gravity_set(Evas_Object *obj, double x, double y)
 {
-   ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE;
+   ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
-   if (!wd) return EINA_FALSE;
+   if (!wd) return;
 
    elm_smart_scroller_gravity_set(wd->scr, x, y);
 }
@@ -732,9 +732,9 @@
 EAPI void
 elm_scroller_gravity_get(Evas_Object *obj, double *x, double *y)
 {
-   ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE;
+   ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);
-   if (!wd) return EINA_FALSE;
+   if (!wd) return;
 
    elm_smart_scroller_gravity_get(wd->scr, x, y);
 }

Log:
elm scroller: Added EINA_ARG_NONNULL to API declarations and added
  'const' to the first parameter of getter API.
  

Author:       seoz
Date:         2011-10-16 22:40:32 -0700 (Sun, 16 Oct 2011)
New Revision: 64122
Trac:         http://trac.enlightenment.org/e/changeset/64122

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_scroller.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-10-17 05:22:08 UTC (rev 64121)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-10-17 05:40:32 UTC (rev 64122)
@@ -7230,7 +7230,7 @@
     * This enables or disabled event propagation from the scroller content to
     * the scroller and its parent. By default event propagation is disabled.
     */
-   EAPI void         elm_scroller_propagate_events_set(Evas_Object *obj, Eina_Bool propagation);
+   EAPI void         elm_scroller_propagate_events_set(Evas_Object *obj, Eina_Bool propagation) EINA_ARG_NONNULL(1);
    /**
     * @brief Get event propagation for a scroller
     *
@@ -7241,7 +7241,7 @@
     *
     * @see elm_scroller_propagate_events_set()
     */
-   EAPI Eina_Bool    elm_scroller_propagate_events_get(const Evas_Object *obj);
+   EAPI Eina_Bool    elm_scroller_propagate_events_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
     * @brief Set scrolling gravity on a scroller
     *
@@ -7256,7 +7256,7 @@
     * To set y as 1.0 for upper growing child objects. And x is horizontal gravity.
     * By default 0.0 for x and y.
     */
-   EAPI void         elm_scroller_gravity_set(Evas_Object *obj, double x, double y);
+   EAPI void         elm_scroller_gravity_set(Evas_Object *obj, double x, double y) EINA_ARG_NONNULL(1);
    /**
     * @brief Get scrolling gravity values for a scroller
     *
@@ -7269,7 +7269,7 @@
     * @see elm_scroller_gravity_set()
     *
     */
-   EAPI void         elm_scroller_gravity_get(Evas_Object *obj, double *x, double *y);
+   EAPI void         elm_scroller_gravity_get(const Evas_Object *obj, double *x, double *y) EINA_ARG_NONNULL(1);
    /**
     * @}
     */

Modified: trunk/elementary/src/lib/elm_scroller.c
===================================================================
--- trunk/elementary/src/lib/elm_scroller.c	2011-10-17 05:22:08 UTC (rev 64121)
+++ trunk/elementary/src/lib/elm_scroller.c	2011-10-17 05:40:32 UTC (rev 64122)
@@ -730,7 +730,7 @@
 }
 
 EAPI void
-elm_scroller_gravity_get(Evas_Object *obj, double *x, double *y)
+elm_scroller_gravity_get(const Evas_Object *obj, double *x, double *y)
 {
    ELM_CHECK_WIDTYPE(obj, widtype);
    Widget_Data *wd = elm_widget_data_get(obj);

Log:
elm widget.c: Code refactorying. Check sobj first. We do not need to check sobj twice.
  

Author:       seoz
Date:         2011-10-19 10:07:15 -0700 (Wed, 19 Oct 2011)
New Revision: 64182
Trac:         http://trac.enlightenment.org/e/changeset/64182

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-10-19 16:09:14 UTC (rev 64181)
+++ trunk/elementary/src/lib/elm_widget.c	2011-10-19 17:07:15 UTC (rev 64182)
@@ -1010,56 +1010,54 @@
              if (elm_widget_focus_get(sd->resize_obj)) _unfocus_parents(obj);
           }
      }
+
+   if (!sobj) return;
+
    // orphan new resize obj
-   if (sobj)
+   evas_object_data_del(sobj, "elm-parent");
+   if (_elm_widget_is(sobj))
      {
-        evas_object_data_del(sobj, "elm-parent");
-        if (_elm_widget_is(sobj))
-          {
-             Smart_Data *sd2 = evas_object_smart_data_get(sobj);
-             if (sd2) sd2->parent_obj = NULL;
-             evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_HIDE,
-                                                 _sub_obj_hide, sd);
-          }
-        evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_DEL,
-                                            _sub_obj_del, sd);
-        evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_MOUSE_UP,
-                                            _sub_obj_mouse_up, sd);
-        evas_object_smart_member_del(sobj);
-        if (_elm_widget_is(sobj))
-          {
-             if (elm_widget_focus_get(sobj)) _unfocus_parents(obj);
-          }
+        Smart_Data *sd2 = evas_object_smart_data_get(sobj);
+        if (sd2) sd2->parent_obj = NULL;
+        evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_HIDE,
+                                            _sub_obj_hide, sd);
      }
+   evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_DEL,
+                                       _sub_obj_del, sd);
+   evas_object_event_callback_del_full(sobj, EVAS_CALLBACK_MOUSE_UP,
+                                       _sub_obj_mouse_up, sd);
+   evas_object_smart_member_del(sobj);
+   if (_elm_widget_is(sobj))
+     {
+        if (elm_widget_focus_get(sobj)) _unfocus_parents(obj);
+     }
+
    // set the resize obj up
    sd->resize_obj = sobj;
-   if (sd->resize_obj)
+   if (_elm_widget_is(sd->resize_obj))
      {
-        if (_elm_widget_is(sd->resize_obj))
+        Smart_Data *sd2 = evas_object_smart_data_get(sd->resize_obj);
+        if (sd2)
           {
-             Smart_Data *sd2 = evas_object_smart_data_get(sd->resize_obj);
-             if (sd2)
-               {
-                  sd2->parent_obj = obj;
-                  sd2->top_win_focused = sd->top_win_focused;
-               }
-             evas_object_event_callback_add(sobj, EVAS_CALLBACK_HIDE,
-                                            _sub_obj_hide, sd);
+             sd2->parent_obj = obj;
+             sd2->top_win_focused = sd->top_win_focused;
           }
-        evas_object_clip_set(sobj, evas_object_clip_get(obj));
-        evas_object_smart_member_add(sobj, obj);
-        evas_object_event_callback_add(sobj, EVAS_CALLBACK_DEL,
-                                       _sub_obj_del, sd);
-        evas_object_event_callback_add(sobj, EVAS_CALLBACK_MOUSE_UP,
-                                       _sub_obj_mouse_up, sd);
-        _smart_reconfigure(sd);
-        evas_object_data_set(sobj, "elm-parent", obj);
-        evas_object_smart_callback_call(obj, "sub-object-add", sobj);
-        if (_elm_widget_is(sobj))
-          {
-             if (elm_widget_focus_get(sobj)) _focus_parents(obj);
-          }
+        evas_object_event_callback_add(sobj, EVAS_CALLBACK_HIDE,
+                                       _sub_obj_hide, sd);
      }
+   evas_object_clip_set(sobj, evas_object_clip_get(obj));
+   evas_object_smart_member_add(sobj, obj);
+   evas_object_event_callback_add(sobj, EVAS_CALLBACK_DEL,
+                                  _sub_obj_del, sd);
+   evas_object_event_callback_add(sobj, EVAS_CALLBACK_MOUSE_UP,
+                                  _sub_obj_mouse_up, sd);
+   _smart_reconfigure(sd);
+   evas_object_data_set(sobj, "elm-parent", obj);
+   evas_object_smart_callback_call(obj, "sub-object-add", sobj);
+   if (_elm_widget_is(sobj))
+     {
+        if (elm_widget_focus_get(sobj)) _focus_parents(obj);
+     }
 }
 
 EAPI void

Log:
elm widget.c: Set resize_obj first.
  

Author:       seoz
Date:         2011-10-19 10:36:51 -0700 (Wed, 19 Oct 2011)
New Revision: 64185
Trac:         http://trac.enlightenment.org/e/changeset/64185

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-10-19 17:28:26 UTC (rev 64184)
+++ trunk/elementary/src/lib/elm_widget.c	2011-10-19 17:36:51 UTC (rev 64185)
@@ -1011,6 +1011,7 @@
           }
      }
 
+   sd->resize_obj = sobj;
    if (!sobj) return;
 
    // orphan new resize obj
@@ -1033,7 +1034,6 @@
      }
 
    // set the resize obj up
-   sd->resize_obj = sobj;
    if (_elm_widget_is(sd->resize_obj))
      {
         Smart_Data *sd2 = evas_object_smart_data_get(sd->resize_obj);

Log:
elm widget.c: Refactorying. Use same variable name as others. Easier to read the code.
  

Author:       seoz
Date:         2011-10-20 00:31:37 -0700 (Thu, 20 Oct 2011)
New Revision: 64192
Trac:         http://trac.enlightenment.org/e/changeset/64192

Modified:
  trunk/elementary/src/lib/elm_widget.c 

Modified: trunk/elementary/src/lib/elm_widget.c
===================================================================
--- trunk/elementary/src/lib/elm_widget.c	2011-10-20 06:39:03 UTC (rev 64191)
+++ trunk/elementary/src/lib/elm_widget.c	2011-10-20 07:31:37 UTC (rev 64192)
@@ -1034,9 +1034,9 @@
      }
 
    // set the resize obj up
-   if (_elm_widget_is(sd->resize_obj))
+   if (_elm_widget_is(sobj))
      {
-        Smart_Data *sd2 = evas_object_smart_data_get(sd->resize_obj);
+        Smart_Data *sd2 = evas_object_smart_data_get(sobj);
         if (sd2)
           {
              sd2->parent_obj = obj;

Log:
elm genlist/list/gengrid: Changed edge smart callback name. 'edge' callback is not scrolling. So "scroll,edge,up" -> "edge,up". elm_scroller already used this name.
  

Author:       seoz
Date:         2011-10-20 09:42:42 -0700 (Thu, 20 Oct 2011)
New Revision: 64200
Trac:         http://trac.enlightenment.org/e/changeset/64200

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_list.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-10-20 12:30:04 UTC (rev 64199)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-10-20 16:42:42 UTC (rev 64200)
@@ -8093,13 +8093,13 @@
     *   started.
     * - @c "scroll,drag,stop" - called when dragging the content has
     *   stopped.
-    * - @c "scroll,edge,top" - This is called when the gengrid is scrolled until
+    * - @c "edge,top" - This is called when the gengrid is scrolled until
     *   the top edge.
-    * - @c "scroll,edge,bottom" - This is called when the gengrid is scrolled
+    * - @c "edge,bottom" - This is called when the gengrid is scrolled
     *   until the bottom edge.
-    * - @c "scroll,edge,left" - This is called when the gengrid is scrolled
+    * - @c "edge,left" - This is called when the gengrid is scrolled
     *   until the left edge.
-    * - @c "scroll,edge,right" - This is called when the gengrid is scrolled
+    * - @c "edge,right" - This is called when the gengrid is scrolled
     *   until the right edge.
     *
     * List of gengrid examples:
@@ -15944,10 +15944,10 @@
     * - "selected" - when the user selected an item
     * - "unselected" - when the user unselected an item
     * - "longpressed" - an item in the list is long-pressed
-    * - "scroll,edge,top" - the list is scrolled until the top edge
-    * - "scroll,edge,bottom" - the list is scrolled until the bottom edge
-    * - "scroll,edge,left" - the list is scrolled until the left edge
-    * - "scroll,edge,right" - the list is scrolled until the right edge
+    * - "edge,top" - the list is scrolled until the top edge
+    * - "edge,bottom" - the list is scrolled until the bottom edge
+    * - "edge,left" - the list is scrolled until the left edge
+    * - "edge,right" - the list is scrolled until the right edge
     * - "language,changed" - the program's language changed
     *
     * Available styles for it:
@@ -18062,13 +18062,13 @@
     *   started.
     * - @c "scroll,drag,stop" - This is called when dragging the content has
     *   stopped.
-    * - @c "scroll,edge,top" - This is called when the genlist is scrolled until
+    * - @c "edge,top" - This is called when the genlist is scrolled until
     *   the top edge.
-    * - @c "scroll,edge,bottom" - This is called when the genlist is scrolled
+    * - @c "edge,bottom" - This is called when the genlist is scrolled
     *   until the bottom edge.
-    * - @c "scroll,edge,left" - This is called when the genlist is scrolled
+    * - @c "edge,left" - This is called when the genlist is scrolled
     *   until the left edge.
-    * - @c "scroll,edge,right" - This is called when the genlist is scrolled
+    * - @c "edge,right" - This is called when the genlist is scrolled
     *   until the right edge.
     * - @c "multi,swipe,left" - This is called when the genlist is multi-touch
     *   swiped left.

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-10-20 12:30:04 UTC (rev 64199)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-10-20 16:42:42 UTC (rev 64200)
@@ -153,10 +153,14 @@
 static const char SIG_SCROLL_ANIM_STOP[] = "scroll,anim,stop";
 static const char SIG_SCROLL_DRAG_START[] = "scroll,drag,start";
 static const char SIG_SCROLL_DRAG_STOP[] = "scroll,drag,stop";
-static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top";
-static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom";
-static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left";
-static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right";
+static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top"; // TODO : remove this
+static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom"; // TODO : remove this
+static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left"; // TODO : remove this
+static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right"; // TODO : remove this
+static const char SIG_EDGE_TOP[] = "edge,top";
+static const char SIG_EDGE_BOTTOM[] = "edge,bottom";
+static const char SIG_EDGE_LEFT[] = "edge,left";
+static const char SIG_EDGE_RIGHT[] = "edge,right";
 static const char SIG_MOVED[] = "moved";
 
 static const Evas_Smart_Cb_Description _signals[] = {
@@ -183,6 +187,10 @@
    {SIG_SCROLL_EDGE_BOTTOM, ""},
    {SIG_SCROLL_EDGE_LEFT, ""},
    {SIG_SCROLL_EDGE_RIGHT, ""},
+   {SIG_EDGE_TOP, ""},
+   {SIG_EDGE_BOTTOM, ""},
+   {SIG_EDGE_LEFT, ""},
+   {SIG_EDGE_RIGHT, ""},
    {SIG_MOVED, ""},
    {NULL, NULL}
 };
@@ -1901,35 +1909,39 @@
 }
 
 static void
-_scr_edge_left(void        *data,
-               Evas_Object *scr __UNUSED__,
-               void        *event_info __UNUSED__)
+_edge_left(void        *data,
+           Evas_Object *scr __UNUSED__,
+           void        *event_info __UNUSED__)
 {
    evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_LEFT, NULL);
+   evas_object_smart_callback_call(data, SIG_EDGE_LEFT, NULL);
 }
 
 static void
-_scr_edge_right(void        *data,
-                Evas_Object *scr __UNUSED__,
-                void        *event_info __UNUSED__)
+_edge_right(void        *data,
+            Evas_Object *scr __UNUSED__,
+            void        *event_info __UNUSED__)
 {
    evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_RIGHT, NULL);
+   evas_object_smart_callback_call(data, SIG_EDGE_RIGHT, NULL);
 }
 
 static void
-_scr_edge_top(void        *data,
-              Evas_Object *scr __UNUSED__,
-              void        *event_info __UNUSED__)
+_edge_top(void        *data,
+          Evas_Object *scr __UNUSED__,
+          void        *event_info __UNUSED__)
 {
    evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_TOP, NULL);
+   evas_object_smart_callback_call(data, SIG_EDGE_TOP, NULL);
 }
 
 static void
-_scr_edge_bottom(void        *data,
-                 Evas_Object *scr __UNUSED__,
-                 void        *event_info __UNUSED__)
+_edge_bottom(void        *data,
+             Evas_Object *scr __UNUSED__,
+             void        *event_info __UNUSED__)
 {
    evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_BOTTOM, NULL);
+   evas_object_smart_callback_call(data, SIG_EDGE_BOTTOM, NULL);
 }
 
 static void
@@ -1993,10 +2005,10 @@
    evas_object_smart_callback_add(wd->scr, "animate,stop", _scr_anim_stop, obj);
    evas_object_smart_callback_add(wd->scr, "drag,start", _scr_drag_start, obj);
    evas_object_smart_callback_add(wd->scr, "drag,stop", _scr_drag_stop, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,left", _scr_edge_left, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,right", _scr_edge_right, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,top", _scr_edge_top, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,bottom", _scr_edge_bottom,
+   evas_object_smart_callback_add(wd->scr, "edge,left", _edge_left, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,right", _edge_right, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,top", _edge_top, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,bottom", _edge_bottom,
                                   obj);
    evas_object_smart_callback_add(wd->scr, "scroll", _scr_scroll, obj);
 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-10-20 12:30:04 UTC (rev 64199)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-10-20 16:42:42 UTC (rev 64200)
@@ -261,10 +261,14 @@
 static const char SIG_SCROLL_ANIM_STOP[] = "scroll,anim,stop";
 static const char SIG_SCROLL_DRAG_START[] = "scroll,drag,start";
 static const char SIG_SCROLL_DRAG_STOP[] = "scroll,drag,stop";
-static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top";
-static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom";
-static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left";
-static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right";
+static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top"; // TODO : remove this 
+static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom"; // TODO : remove this 
+static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left"; // TODO : remove this 
+static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right"; // TODO : remove this 
+static const char SIG_EDGE_TOP[] = "edge,top";
+static const char SIG_EDGE_BOTTOM[] = "edge,bottom";
+static const char SIG_EDGE_LEFT[] = "edge,left";
+static const char SIG_EDGE_RIGHT[] = "edge,right";
 static const char SIG_MULTI_SWIPE_LEFT[] = "multi,swipe,left";
 static const char SIG_MULTI_SWIPE_RIGHT[] = "multi,swipe,right";
 static const char SIG_MULTI_SWIPE_UP[] = "multi,swipe,up";
@@ -299,6 +303,10 @@
    {SIG_SCROLL_EDGE_BOTTOM, ""},
    {SIG_SCROLL_EDGE_LEFT, ""},
    {SIG_SCROLL_EDGE_RIGHT, ""},
+   {SIG_EDGE_TOP, ""},
+   {SIG_EDGE_BOTTOM, ""},
+   {SIG_EDGE_LEFT, ""},
+   {SIG_EDGE_RIGHT, ""},
    {SIG_MULTI_SWIPE_LEFT, ""},
    {SIG_MULTI_SWIPE_RIGHT, ""},
    {SIG_MULTI_SWIPE_UP, ""},
@@ -2871,39 +2879,43 @@
 }
 
 static void
-_scroll_edge_left(void        *data,
-                  Evas_Object *scr __UNUSED__,
-                  void        *event_info __UNUSED__)
+_edge_left(void        *data,
+           Evas_Object *scr __UNUSED__,
+           void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_LEFT, NULL);
+   evas_object_smart_callback_call(obj, SIG_EDGE_LEFT, NULL);
 }
 
 static void
-_scroll_edge_right(void        *data,
-                   Evas_Object *scr __UNUSED__,
-                   void        *event_info __UNUSED__)
+_edge_right(void        *data,
+            Evas_Object *scr __UNUSED__,
+            void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_RIGHT, NULL);
+   evas_object_smart_callback_call(obj, SIG_EDGE_RIGHT, NULL);
 }
 
 static void
-_scroll_edge_top(void        *data,
-                 Evas_Object *scr __UNUSED__,
-                 void        *event_info __UNUSED__)
+_edge_top(void        *data,
+          Evas_Object *scr __UNUSED__,
+          void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_TOP, NULL);
+   evas_object_smart_callback_call(obj, SIG_EDGE_TOP, NULL);
 }
 
 static void
-_scroll_edge_bottom(void        *data,
-                    Evas_Object *scr __UNUSED__,
-                    void        *event_info __UNUSED__)
+_edge_bottom(void        *data,
+             Evas_Object *scr __UNUSED__,
+             void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_BOTTOM, NULL);
+   evas_object_smart_callback_call(obj, SIG_EDGE_BOTTOM, NULL);
 }
 
 static void
@@ -3114,12 +3126,10 @@
    evas_object_smart_callback_add(wd->scr, "animate,stop", _scr_anim_stop, obj);
    evas_object_smart_callback_add(wd->scr, "drag,start", _scr_drag_start, obj);
    evas_object_smart_callback_add(wd->scr, "drag,stop", _scr_drag_stop, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,left", _scroll_edge_left, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,right", _scroll_edge_right,
-                                  obj);
-   evas_object_smart_callback_add(wd->scr, "edge,top", _scroll_edge_top, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,bottom", _scroll_edge_bottom,
-                                  obj);
+   evas_object_smart_callback_add(wd->scr, "edge,left", _edge_left, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,right", _edge_right, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,top", _edge_top, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,bottom", _edge_bottom, obj);
 
    wd->obj = obj;
    wd->mode = ELM_LIST_SCROLL;

Modified: trunk/elementary/src/lib/elm_list.c
===================================================================
--- trunk/elementary/src/lib/elm_list.c	2011-10-20 12:30:04 UTC (rev 64199)
+++ trunk/elementary/src/lib/elm_list.c	2011-10-20 16:42:42 UTC (rev 64200)
@@ -66,10 +66,10 @@
 static void _mouse_down(void *data, Evas *evas, Evas_Object *obj, void *event_info);
 static void _mouse_up(void *data, Evas *evas, Evas_Object *obj, void *event_info);
 static void _mouse_move(void *data, Evas *evas, Evas_Object *obj, void *event_info);
-static void _scroll_edge_left(void *data, Evas_Object *scr, void *event_info);
-static void _scroll_edge_right(void *data, Evas_Object *scr, void *event_info);
-static void _scroll_edge_top(void *data, Evas_Object *scr, void *event_info);
-static void _scroll_edge_bottom(void *data, Evas_Object *scr, void *event_info);
+static void _edge_left(void *data, Evas_Object *scr, void *event_info);
+static void _edge_right(void *data, Evas_Object *scr, void *event_info);
+static void _edge_top(void *data, Evas_Object *scr, void *event_info);
+static void _edge_bottom(void *data, Evas_Object *scr, void *event_info);
 static Eina_Bool _item_multi_select_up(Widget_Data *wd);
 static Eina_Bool _item_multi_select_down(Widget_Data *wd);
 static Eina_Bool _item_single_select_up(Widget_Data *wd);
@@ -83,10 +83,14 @@
 static const char SIG_SELECTED[] = "selected";
 static const char SIG_UNSELECTED[] = "unselected";
 static const char SIG_LONGPRESSED[] = "longpressed";
-static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top";
-static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom";
-static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left";
-static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right";
+static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top"; // TODO : remove this
+static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom"; // TODO : remove this
+static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left"; // TODO : remove this
+static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right"; // TODO : remove this
+static const char SIG_EDGE_TOP[] = "edge,top";
+static const char SIG_EDGE_BOTTOM[] = "edge,bottom";
+static const char SIG_EDGE_LEFT[] = "edge,left";
+static const char SIG_EDGE_RIGHT[] = "edge,right";
 
 static const Evas_Smart_Cb_Description _signals[] = {
    {SIG_ACTIVATED, ""},
@@ -98,6 +102,10 @@
    {SIG_SCROLL_EDGE_BOTTOM, ""},
    {SIG_SCROLL_EDGE_LEFT, ""},
    {SIG_SCROLL_EDGE_RIGHT, ""},
+   {SIG_EDGE_TOP, ""},
+   {SIG_EDGE_BOTTOM, ""},
+   {SIG_EDGE_LEFT, ""},
+   {SIG_EDGE_RIGHT, ""},
    {NULL, NULL}
 };
 
@@ -837,31 +845,35 @@
 }
 
 static void
-_scroll_edge_left(void *data, Evas_Object *scr __UNUSED__, void *event_info __UNUSED__)
+_edge_left(void *data, Evas_Object *scr __UNUSED__, void *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_LEFT, NULL);
+   evas_object_smart_callback_call(obj, SIG_EDGE_LEFT, NULL);
 }
 
 static void
-_scroll_edge_right(void *data, Evas_Object *scr __UNUSED__, void *event_info __UNUSED__)
+_edge_right(void *data, Evas_Object *scr __UNUSED__, void *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_RIGHT, NULL);
+   evas_object_smart_callback_call(obj, SIG_EDGE_RIGHT, NULL);
 }
 
 static void
-_scroll_edge_top(void *data, Evas_Object *scr __UNUSED__, void *event_info __UNUSED__)
+_edge_top(void *data, Evas_Object *scr __UNUSED__, void *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_TOP, NULL);
+   evas_object_smart_callback_call(obj, SIG_EDGE_TOP, NULL);
 }
 
 static void
-_scroll_edge_bottom(void *data, Evas_Object *scr __UNUSED__, void *event_info __UNUSED__)
+_edge_bottom(void *data, Evas_Object *scr __UNUSED__, void *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
    evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_BOTTOM, NULL);
+   evas_object_smart_callback_call(obj, SIG_EDGE_BOTTOM, NULL);
 }
 
 static Eina_Bool
@@ -1357,10 +1369,10 @@
 
    wd->mode = ELM_LIST_SCROLL;
 
-   evas_object_smart_callback_add(wd->scr, "edge,left", _scroll_edge_left, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,right", _scroll_edge_right, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,top", _scroll_edge_top, obj);
-   evas_object_smart_callback_add(wd->scr, "edge,bottom", _scroll_edge_bottom, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,left", _edge_left, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,right", _edge_right, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,top", _edge_top, obj);
+   evas_object_smart_callback_add(wd->scr, "edge,bottom", _edge_bottom, obj);
 
    evas_object_smart_callback_add(obj, "sub-object-del", _sub_del, obj);
    evas_object_smart_callback_add(obj, "scroll-hold-on", _hold_on, obj);

Log:
elm gengrid: Refactorying. Moved some codes and removed unnecessary line.
  

Author:       seoz
Date:         2011-10-21 09:36:20 -0700 (Fri, 21 Oct 2011)
New Revision: 64261
Trac:         http://trac.enlightenment.org/e/changeset/64261

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-10-21 16:25:45 UTC (rev 64260)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-10-21 16:36:20 UTC (rev 64261)
@@ -1897,6 +1897,22 @@
    static Evas_Smart *smart = NULL;
    Eina_Bool bounce = _elm_config->thumbscroll_bounce_enable;
 
+   if (!smart)
+     {
+        static Evas_Smart_Class sc;
+
+        evas_object_smart_clipped_smart_set(&_pan_sc);
+        sc = _pan_sc;
+        sc.name = "elm_gengrid_pan";
+        sc.version = EVAS_SMART_CLASS_VERSION;
+        sc.add = _pan_add;
+        sc.del = _pan_del;
+        sc.resize = _pan_resize;
+        sc.move = _pan_move;
+        sc.calculate = _pan_calculate;
+        if (!(smart = evas_smart_class_new(&sc))) return NULL;
+     }
+
    ELM_WIDGET_STANDARD_SETUP(wd, Widget_Data, parent, e, obj, NULL);
 
    ELM_SET_WIDTYPE(widtype, "gengrid");
@@ -1917,6 +1933,7 @@
    elm_smart_scroller_widget_set(wd->scr, obj);
    elm_smart_scroller_object_theme_set(obj, wd->scr, "gengrid", "base",
                                        "default");
+   elm_smart_scroller_bounce_allow_set(wd->scr, bounce, bounce);
    elm_widget_resize_object_set(obj, wd->scr);
 
    evas_object_smart_callback_add(wd->scr, "animate,start", _scr_anim_start, obj);
@@ -1930,48 +1947,27 @@
                                   obj);
    evas_object_smart_callback_add(wd->scr, "scroll", _scr_scroll, obj);
 
-   elm_smart_scroller_bounce_allow_set(wd->scr, bounce, bounce);
-
    wd->self = obj;
    wd->align_x = 0.5;
    wd->align_y = 0.5;
    wd->h_bounce = bounce;
    wd->v_bounce = bounce;
-   wd->no_select = EINA_FALSE;
 
    evas_object_smart_callback_add(obj, "scroll-hold-on", _hold_on, obj);
    evas_object_smart_callback_add(obj, "scroll-hold-off", _hold_off, obj);
    evas_object_smart_callback_add(obj, "scroll-freeze-on", _freeze_on, obj);
    evas_object_smart_callback_add(obj, "scroll-freeze-off", _freeze_off, obj);
 
-   evas_object_smart_callbacks_descriptions_set(obj, _signals);
+   wd->pan_smart = evas_object_smart_add(e, smart);
+   wd->pan = evas_object_smart_data_get(wd->pan_smart);
+   wd->pan->wd = wd;
 
-   if (!smart)
-     {
-        static Evas_Smart_Class sc;
-
-        evas_object_smart_clipped_smart_set(&_pan_sc);
-        sc = _pan_sc;
-        sc.name = "elm_gengrid_pan";
-        sc.version = EVAS_SMART_CLASS_VERSION;
-        sc.add = _pan_add;
-        sc.del = _pan_del;
-        sc.resize = _pan_resize;
-        sc.move = _pan_move;
-        sc.calculate = _pan_calculate;
-        smart = evas_smart_class_new(&sc);
-     }
-   if (smart)
-     {
-        wd->pan_smart = evas_object_smart_add(e, smart);
-        wd->pan = evas_object_smart_data_get(wd->pan_smart);
-        wd->pan->wd = wd;
-     }
-
    elm_smart_scroller_extern_pan_set(wd->scr, wd->pan_smart,
                                      _pan_set, _pan_get, _pan_max_get,
                                      _pan_min_get, _pan_child_size_get);
 
+   evas_object_smart_callbacks_descriptions_set(obj, _signals);
+
    _mirrored_set(obj, elm_widget_mirrored_get(obj));
    return obj;
 }

Log:
elm gengrid: Changed widget data member 'self' to 'obj'. Sync with genlist.
  

Author:       seoz
Date:         2011-10-21 09:53:01 -0700 (Fri, 21 Oct 2011)
New Revision: 64262
Trac:         http://trac.enlightenment.org/e/changeset/64262

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-10-21 16:36:20 UTC (rev 64261)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-10-21 16:53:01 UTC (rev 64262)
@@ -29,7 +29,7 @@
 struct _Widget_Data
 {
    Eina_Inlist_Sorted_State *state;
-   Evas_Object *self;
+   Evas_Object      *obj; /* the gengrid object */
    Eina_List        *selected;
    Eina_List        *group_items; /* list of groups index items */
    Eina_Inlist      *items; /* inlist of all items */
@@ -51,7 +51,7 @@
    unsigned int      nmax;
    long              count;
    long              items_lost;
-   
+
    Eina_Bool         horizontal : 1;
    Eina_Bool         on_hold : 1;
    Eina_Bool         longpressed : 1;
@@ -337,7 +337,7 @@
             (!strcmp(ev->keyname, "space")))
      {
         it = elm_gengrid_selected_item_get(obj);
-        evas_object_smart_callback_call(it->wd->self, SIG_ACTIVATED, it);
+        evas_object_smart_callback_call(WIDGET(it), SIG_ACTIVATED, it);
      }
    else return EINA_FALSE;
 
@@ -546,15 +546,15 @@
    if (!wd) return;
    if (elm_widget_focus_get(obj))
      {
-        edje_object_signal_emit(wd->self, "elm,action,focus", "elm");
-        evas_object_focus_set(wd->self, EINA_TRUE);
+        edje_object_signal_emit(wd->obj, "elm,action,focus", "elm");
+        evas_object_focus_set(wd->obj, EINA_TRUE);
         if ((wd->selected) && (!wd->last_selected_item))
           wd->last_selected_item = eina_list_data_get(wd->selected);
      }
    else
      {
-        edje_object_signal_emit(wd->self, "elm,action,unfocus", "elm");
-        evas_object_focus_set(wd->self, EINA_FALSE);
+        edje_object_signal_emit(wd->obj, "elm,action,unfocus", "elm");
+        evas_object_focus_set(wd->obj, EINA_FALSE);
      }
 }
 
@@ -669,7 +669,7 @@
              ecore_timer_del(it->long_timer);
              it->long_timer = NULL;
           }
-        evas_object_smart_callback_call(it->wd->self, SIG_DRAG, it);
+        evas_object_smart_callback_call(WIDGET(it), SIG_DRAG, it);
         return;
      }
    if ((!it->down) || (it->wd->longpressed))
@@ -717,7 +717,7 @@
    if ((adx > minw) || (ady > minh))
      {
         const char *left_drag, *right_drag;
-        if (!elm_widget_mirrored_get(it->wd->self))
+        if (!elm_widget_mirrored_get(WIDGET(it)))
           {
              left_drag = SIG_DRAG_START_LEFT;
              right_drag = SIG_DRAG_START_RIGHT;
@@ -739,27 +739,27 @@
         if (dy < 0)
           {
              if (ady > adx)
-               evas_object_smart_callback_call(it->wd->self, SIG_DRAG_START_UP,
+               evas_object_smart_callback_call(WIDGET(it), SIG_DRAG_START_UP,
                                                it);
              else
                {
                   if (dx < 0)
-                    evas_object_smart_callback_call(it->wd->self,
+                    evas_object_smart_callback_call(WIDGET(it),
                                                     left_drag, it);
                }
           }
         else
           {
              if (ady > adx)
-               evas_object_smart_callback_call(it->wd->self,
+               evas_object_smart_callback_call(WIDGET(it),
                                                SIG_DRAG_START_DOWN, it);
              else
                {
                   if (dx < 0)
-                    evas_object_smart_callback_call(it->wd->self,
+                    evas_object_smart_callback_call(WIDGET(it),
                                                     left_drag, it);
                   else
-                    evas_object_smart_callback_call(it->wd->self,
+                    evas_object_smart_callback_call(WIDGET(it),
                                                     right_drag, it);
                }
           }
@@ -774,7 +774,7 @@
    it->long_timer = NULL;
    if ((it->disabled) || (it->dragging)) return ECORE_CALLBACK_CANCEL;
    it->wd->longpressed = EINA_TRUE;
-   evas_object_smart_callback_call(it->wd->self, SIG_LONGPRESSED, it);
+   evas_object_smart_callback_call(WIDGET(it), SIG_LONGPRESSED, it);
    if (it->wd->reorder_mode)
      {
         it->wd->reorder_it = it;
@@ -809,8 +809,8 @@
    _item_highlight(it);
    if (ev->flags & EVAS_BUTTON_DOUBLE_CLICK)
      {
-        evas_object_smart_callback_call(it->wd->self, SIG_CLICKED_DOUBLE, it);
-        evas_object_smart_callback_call(it->wd->self, SIG_ACTIVATED, it);
+        evas_object_smart_callback_call(WIDGET(it), SIG_CLICKED_DOUBLE, it);
+        evas_object_smart_callback_call(WIDGET(it), SIG_ACTIVATED, it);
      }
    if (it->long_timer) ecore_timer_del(it->long_timer);
    if (it->realized)
@@ -842,7 +842,7 @@
    if (it->dragging)
      {
         it->dragging = EINA_FALSE;
-        evas_object_smart_callback_call(it->wd->self, SIG_DRAG_STOP, it);
+        evas_object_smart_callback_call(WIDGET(it), SIG_DRAG_STOP, it);
         dragged = EINA_TRUE;
      }
    if (it->wd->on_hold)
@@ -853,7 +853,7 @@
      }
    if ((it->wd->reorder_mode) && (it->wd->reorder_it))
      {
-        evas_object_smart_callback_call(it->wd->self, SIG_MOVED, it->wd->reorder_it);
+        evas_object_smart_callback_call(WIDGET(it), SIG_MOVED, it->wd->reorder_it);
         it->wd->reorder_it = NULL;
         it->wd->move_effect_enabled = EINA_FALSE;
         if (it->wd->calc_job) ecore_job_del(it->wd->calc_job);
@@ -920,20 +920,20 @@
    char style[1024];
 
    if ((it->realized) || (it->delete_me)) return;
-   VIEW(it) = edje_object_add(evas_object_evas_get(it->wd->self));
-   edje_object_scale_set(VIEW(it), elm_widget_scale_get(it->wd->self) *
+   VIEW(it) = edje_object_add(evas_object_evas_get(WIDGET(it)));
+   edje_object_scale_set(VIEW(it), elm_widget_scale_get(WIDGET(it)) *
                          _elm_config->scale);
    edje_object_mirrored_set(VIEW(it), elm_widget_mirrored_get(WIDGET(it)));
    evas_object_smart_member_add(VIEW(it), it->wd->pan_smart);
-   elm_widget_sub_object_add(it->wd->self, VIEW(it));
+   elm_widget_sub_object_add(WIDGET(it), VIEW(it));
    snprintf(style, sizeof(style), "item/%s",
             it->itc->item_style ? it->itc->item_style : "default");
-   _elm_theme_object_set(it->wd->self, VIEW(it), "gengrid", style,
-                         elm_widget_style_get(it->wd->self));
+   _elm_theme_object_set(WIDGET(it), VIEW(it), "gengrid", style,
+                         elm_widget_style_get(WIDGET(it)));
    it->spacer =
-      evas_object_rectangle_add(evas_object_evas_get(it->wd->self));
+      evas_object_rectangle_add(evas_object_evas_get(WIDGET(it)));
    evas_object_color_set(it->spacer, 0, 0, 0, 0);
-   elm_widget_sub_object_add(it->wd->self, it->spacer);
+   elm_widget_sub_object_add(WIDGET(it), it->spacer);
    evas_object_size_hint_min_set(it->spacer, 2 * _elm_config->scale, 1);
    edje_object_part_swallow(VIEW(it), "elm.swallow.pad", it->spacer);
 
@@ -948,7 +948,7 @@
         EINA_LIST_FOREACH(it->labels, l, key)
           {
              char *s = it->itc->func.label_get
-                ((void *)it->base.data, it->wd->self, l->data);
+                ((void *)it->base.data, WIDGET(it), l->data);
              if (s)
                {
                   edje_object_part_text_set(VIEW(it), l->data, s);
@@ -968,13 +968,13 @@
         EINA_LIST_FOREACH(it->icons, l, key)
           {
              Evas_Object *ic = it->itc->func.icon_get
-                ((void *)it->base.data, it->wd->self, l->data);
+                ((void *)it->base.data, WIDGET(it), l->data);
              if (ic)
                {
                   it->icon_objs = eina_list_append(it->icon_objs, ic);
                   edje_object_part_swallow(VIEW(it), key, ic);
                   evas_object_show(ic);
-                  elm_widget_sub_object_add(it->wd->self, ic);
+                  elm_widget_sub_object_add(WIDGET(it), ic);
                }
           }
      }
@@ -990,7 +990,7 @@
         EINA_LIST_FOREACH(it->states, l, key)
           {
              Eina_Bool on = it->itc->func.state_get
-                ((void *)it->base.data, it->wd->self, l->data);
+                ((void *)it->base.data, WIDGET(it), l->data);
              if (on)
                {
                   snprintf(buf, sizeof(buf), "elm,state,%s,active", key);
@@ -1146,7 +1146,7 @@
           {
              _item_realize(it);
              if (!was_realized)
-               evas_object_smart_callback_call(it->wd->self, SIG_REALIZED, it);
+               evas_object_smart_callback_call(WIDGET(it), SIG_REALIZED, it);
              evas_object_move(VIEW(it), it->item->gx, it->item->gy);
              evas_object_resize(VIEW(it), iw, ih);
              evas_object_raise(VIEW(it));
@@ -1256,9 +1256,9 @@
              x = (cx * it->wd->item_width) - it->wd->pan_x + ox + alignw;
              y = (((cy - it->item->prev_group) * it->wd->item_height) + (it->item->prev_group * it->wd->group_item_height)) - it->wd->pan_y + oy + alignh;
           }
-        if (elm_widget_mirrored_get(it->wd->self))
+        if (elm_widget_mirrored_get(WIDGET(it)))
           {  /* Switch items side and componsate for pan_x when in RTL mode */
-             evas_object_geometry_get(it->wd->self, NULL, NULL, &ww, NULL);
+             evas_object_geometry_get(WIDGET(it), NULL, NULL, &ww, NULL);
              x = ww - x - it->wd->item_width - it->wd->pan_x - it->wd->pan_x;
           }
         iw = it->wd->item_width;
@@ -1270,7 +1270,7 @@
      {
         _item_realize(it);
         if (!was_realized)
-          evas_object_smart_callback_call(it->wd->self, SIG_REALIZED, it);
+          evas_object_smart_callback_call(WIDGET(it), SIG_REALIZED, it);
         if (it->parent)
           {
              if (it->wd->horizontal)
@@ -1468,9 +1468,9 @@
    it->walking++;
    it->wd->walking++;
    if (it->func.func)
-     it->func.func((void *)it->func.data, it->wd->self, it);
+     it->func.func((void *)it->func.data, WIDGET(it), it);
    if (!it->delete_me)
-     evas_object_smart_callback_call(it->wd->self, SIG_SELECTED, it);
+     evas_object_smart_callback_call(WIDGET(it), SIG_SELECTED, it);
    it->walking--;
    it->wd->walking--;
    it->wd->last_selected_item = it;
@@ -1493,7 +1493,7 @@
      {
         it->selected = EINA_FALSE;
         it->wd->selected = eina_list_remove(it->wd->selected, it);
-        evas_object_smart_callback_call(it->wd->self, SIG_UNSELECTED, it);
+        evas_object_smart_callback_call(WIDGET(it), SIG_UNSELECTED, it);
      }
 }
 
@@ -1740,7 +1740,7 @@
           }
         sd->wd->move_effect_enabled = EINA_FALSE;
      }
-   evas_object_smart_callback_call(sd->wd->self, SIG_CHANGED, NULL);
+   evas_object_smart_callback_call(sd->wd->obj, SIG_CHANGED, NULL);
 }
 
 static void
@@ -1947,7 +1947,7 @@
                                   obj);
    evas_object_smart_callback_add(wd->scr, "scroll", _scr_scroll, obj);
 
-   wd->self = obj;
+   wd->obj = obj;
    wd->align_x = 0.5;
    wd->align_y = 0.5;
    wd->h_bounce = bounce;
@@ -2279,7 +2279,7 @@
         elm_widget_item_pre_notify_del(it);
         if (it->realized) elm_gen_item_unrealize(it, EINA_FALSE, (Ecore_Cb)_item_unrealize_cb);
         if (it->itc->func.del)
-          it->itc->func.del((void *)it->base.data, wd->self);
+          it->itc->func.del((void *)it->base.data, wd->obj);
         if (it->long_timer) ecore_timer_del(it->long_timer);
         free(it->item);
         elm_widget_item_del(it);
@@ -2857,7 +2857,7 @@
 elm_gengrid_item_show(Elm_Gen_Item *it)
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
-   Widget_Data *wd = elm_widget_data_get(it->wd->self);
+   Widget_Data *wd = elm_widget_data_get(WIDGET(it));
    Evas_Coord minx = 0, miny = 0;
 
    if (!wd) return;
@@ -2885,7 +2885,7 @@
    if (it->delete_me) return;
 
    Evas_Coord minx = 0, miny = 0;
-   Widget_Data *wd = elm_widget_data_get(it->wd->self);
+   Widget_Data *wd = elm_widget_data_get(WIDGET(it));
    if (!wd) return;
    _pan_min_get(wd->pan_smart, &minx, &miny);

Log:
elm genlist/gengrid: No need to call elm_widget_data_get() if we know it. it->wd is a widget data.
  

Author:       seoz
Date:         2011-10-21 10:06:46 -0700 (Fri, 21 Oct 2011)
New Revision: 64263
Trac:         http://trac.enlightenment.org/e/changeset/64263

Modified:
  trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-10-21 16:53:01 UTC (rev 64262)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-10-21 17:06:46 UTC (rev 64263)
@@ -2857,7 +2857,7 @@
 elm_gengrid_item_show(Elm_Gen_Item *it)
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
-   Widget_Data *wd = elm_widget_data_get(WIDGET(it));
+   Widget_Data *wd = it->wd;
    Evas_Coord minx = 0, miny = 0;
 
    if (!wd) return;
@@ -2885,7 +2885,7 @@
    if (it->delete_me) return;
 
    Evas_Coord minx = 0, miny = 0;
-   Widget_Data *wd = elm_widget_data_get(WIDGET(it));
+   Widget_Data *wd = it->wd;
    if (!wd) return;
    _pan_min_get(wd->pan_smart, &minx, &miny);
 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-10-21 16:53:01 UTC (rev 64262)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-10-21 17:06:46 UTC (rev 64263)
@@ -3975,7 +3975,7 @@
                               Eina_Bool         selected)
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
-   Widget_Data *wd = elm_widget_data_get(WIDGET(it));
+   Widget_Data *wd = it->wd;
    if (!wd) return;
    if ((it->delete_me) || (it->disabled)) return;
    selected = !!selected;

Log:
elm genlist: Removed dead code. Patch by Hyoyoung Chang
  <hyoyoung@...>
  
  On Sun, Oct 23, 2011 at 8:44 PM, Hyoyoung Chang <hyoyoung@...>
  wrote:
  > Dear developers
  >
  > When i compile elementary, i found something to remove.
  > And this is for removing unused values in elm_genlist.
  >
  > Thank you.
  

Author:       seoz
Date:         2011-10-23 16:15:58 -0700 (Sun, 23 Oct 2011)
New Revision: 64331
Trac:         http://trac.enlightenment.org/e/changeset/64331

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-10-23 22:26:20 UTC (rev 64330)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-10-23 23:15:58 UTC (rev 64331)
@@ -706,11 +706,8 @@
 static void
 _item_unhighlight(Elm_Gen_Item *it)
 {
-   const char *stacking, *selectraise;
    if ((it->delete_me) || (!it->highlighted)) return;
    edje_object_signal_emit(VIEW(it), "elm,state,unselected", "elm");
-   stacking = edje_object_data_get(VIEW(it), "stacking");
-   selectraise = edje_object_data_get(VIEW(it), "selectraise");
    if (!it->item->nostacking)
      {
        if ((it->item->order_num_in & 0x1) ^ it->item->stacking_even) evas_object_lower(VIEW(it));
@@ -2300,12 +2297,10 @@
    Item_Block *itb, *chb = NULL;
    Evas_Coord minw = -1, minh = 0, y = 0, ow;
    int in = 0;
-   double t0, t;
    Eina_Bool minw_change = EINA_FALSE;
    Eina_Bool did_must_recalc = EINA_FALSE;
    if (!wd) return;
 
-   t0 = ecore_time_get();
    evas_object_geometry_get(wd->pan_smart, NULL, NULL, &ow, &wd->h);
    if (wd->w != ow)
      wd->w = ow;
@@ -2409,7 +2404,6 @@
              wd->anchor_y = it_y;
           }
      }
-   t = ecore_time_get();
    if (did_must_recalc)
      {
         if (!wd->must_recalc_idler)

Log:
elm map: Fixed internal function name.
  

Author:       seoz
Date:         2011-10-30 17:15:10 -0700 (Sun, 30 Oct 2011)
New Revision: 64537
Trac:         http://trac.enlightenment.org/e/changeset/64537

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-10-31 00:13:32 UTC (rev 64536)
+++ trunk/elementary/src/lib/elm_map.c	2011-10-31 00:15:10 UTC (rev 64537)
@@ -513,7 +513,7 @@
 static int _group_bubble_content_update(Marker_Group *group);
 static void _group_bubble_content_free(Marker_Group *group);
 static void marker_place(Evas_Object *obj, Grid *g, Evas_Coord px, Evas_Coord py, Evas_Coord ox, Evas_Coord oy, Evas_Coord ow, Evas_Coord oh);
-static void _bubble_sc_hits_changed_cb(void *data, Evas *e, Evas_Object *obj, void *event_info);
+static void _bubble_sc_hints_changed_cb(void *data, Evas *e, Evas_Object *obj, void *event_info);
 
 static void _mouse_down(void *data, Evas *evas, Evas_Object *obj, void *event_info);
 static void _mouse_up(void *data, Evas *evas, Evas_Object *obj, void *event_info);
@@ -2115,7 +2115,7 @@
                   EINA_LIST_FREE(group->markers, marker)
                     {
                        evas_object_event_callback_del_full(group->sc, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
-                                                           _bubble_sc_hits_changed_cb, group);
+                                                           _bubble_sc_hints_changed_cb, group);
                        if (free_marker) free(marker);
                     }
                   free(group);
@@ -2521,7 +2521,7 @@
    _group_bubble_place(group);
 }
 
-static void _bubble_sc_hits_changed_cb(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
+static void _bubble_sc_hints_changed_cb(void *data, Evas *e __UNUSED__, Evas_Object *obj __UNUSED__, void *event_info __UNUSED__)
 {
    _group_bubble_place(data);
 }
@@ -2557,7 +2557,7 @@
         elm_scroller_content_set(group->sc, group->bx);
 
         evas_object_event_callback_add(group->sc, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
-                                       _bubble_sc_hits_changed_cb, group);
+                                       _bubble_sc_hints_changed_cb, group);
      }
 
    EINA_LIST_FOREACH(group->markers, l, marker)
@@ -2601,7 +2601,7 @@
    if (!group->bubble) return;
    group->wd->opened_bubbles = eina_list_remove(group->wd->opened_bubbles, group);
    evas_object_event_callback_del_full(group->sc, EVAS_CALLBACK_CHANGED_SIZE_HINTS,
-                                       _bubble_sc_hits_changed_cb, group);
+                                       _bubble_sc_hints_changed_cb, group);
    evas_object_del(group->bubble);
    evas_object_del(group->rect);
    group->bubble = NULL;

Log:
elm genlist: Refine codes.
  

Author:       seoz
Date:         2011-11-18 01:12:27 -0800 (Fri, 18 Nov 2011)
New Revision: 65380
Trac:         http://trac.enlightenment.org/e/changeset/65380

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-11-18 08:49:59 UTC (rev 65379)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-11-18 09:12:27 UTC (rev 65380)
@@ -3263,12 +3263,9 @@
         it = wd->queue->data;
         wd->queue = eina_list_remove_list(wd->queue, wd->queue);
         it->item->queued = EINA_FALSE;
+        _item_block_add(wd, it);
         if (!wd->blocks)
-          {
-             _item_block_add(wd, it);
-             _item_block_realize(it->item->block);
-          }
-        else _item_block_add(wd, it);
+          _item_block_realize(it->item->block);
         t = ecore_time_get();
         if (it->item->block->changed)
           {

Log:
elm Elementary.h.in: Fix doxygen typo.
  

Author:       seoz
Date:         2011-11-20 23:47:28 -0800 (Sun, 20 Nov 2011)
New Revision: 65473
Trac:         http://trac.enlightenment.org/e/changeset/65473

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-11-21 06:44:40 UTC (rev 65472)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-11-21 07:47:28 UTC (rev 65473)
@@ -18296,7 +18296,7 @@
     * If the application wants multiple items to be able to be selected,
     * elm_genlist_multi_select_set() can enable this. If the list is
     * single-selection only (the default), then elm_genlist_selected_item_get()
-    * will return the selected item, if any, or NULL I none is selected. If the
+    * will return the selected item, if any, or NULL if none is selected. If the
     * list is multi-select then elm_genlist_selected_items_get() will return a
     * list (that is only valid as long as no items are modified (added, deleted,
     * selected or unselected)).

Log:
elm gengrid/genlist: Remove deprecated signals.
  
  This was already announced a month ago.
  http://trac.enlightenment.org/e/changeset/64200
  

Author:       seoz
Date:         2011-11-21 00:06:40 -0800 (Mon, 21 Nov 2011)
New Revision: 65474
Trac:         http://trac.enlightenment.org/e/changeset/65474

Modified:
  trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-11-21 07:47:28 UTC (rev 65473)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-11-21 08:06:40 UTC (rev 65474)
@@ -150,10 +150,6 @@
    {SIG_SCROLL_ANIM_STOP, ""},
    {SIG_SCROLL_DRAG_START, ""},
    {SIG_SCROLL_DRAG_STOP, ""},
-   {SIG_SCROLL_EDGE_TOP, ""},
-   {SIG_SCROLL_EDGE_BOTTOM, ""},
-   {SIG_SCROLL_EDGE_LEFT, ""},
-   {SIG_SCROLL_EDGE_RIGHT, ""},
    {SIG_EDGE_TOP, ""},
    {SIG_EDGE_BOTTOM, ""},
    {SIG_EDGE_LEFT, ""},
@@ -1785,7 +1781,6 @@
            Evas_Object *scr __UNUSED__,
            void        *event_info __UNUSED__)
 {
-   evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_LEFT, NULL);
    evas_object_smart_callback_call(data, SIG_EDGE_LEFT, NULL);
 }
 
@@ -1794,7 +1789,6 @@
             Evas_Object *scr __UNUSED__,
             void        *event_info __UNUSED__)
 {
-   evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_RIGHT, NULL);
    evas_object_smart_callback_call(data, SIG_EDGE_RIGHT, NULL);
 }
 
@@ -1803,7 +1797,6 @@
           Evas_Object *scr __UNUSED__,
           void        *event_info __UNUSED__)
 {
-   evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_TOP, NULL);
    evas_object_smart_callback_call(data, SIG_EDGE_TOP, NULL);
 }
 
@@ -1812,7 +1805,6 @@
              Evas_Object *scr __UNUSED__,
              void        *event_info __UNUSED__)
 {
-   evas_object_smart_callback_call(data, SIG_SCROLL_EDGE_BOTTOM, NULL);
    evas_object_smart_callback_call(data, SIG_EDGE_BOTTOM, NULL);
 }
 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-11-21 07:47:28 UTC (rev 65473)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-11-21 08:06:40 UTC (rev 65474)
@@ -234,10 +234,6 @@
 static const char SIG_SCROLL_ANIM_STOP[] = "scroll,anim,stop";
 static const char SIG_SCROLL_DRAG_START[] = "scroll,drag,start";
 static const char SIG_SCROLL_DRAG_STOP[] = "scroll,drag,stop";
-static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top"; // TODO : remove this
-static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom"; // TODO : remove this
-static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left"; // TODO : remove this
-static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right"; // TODO : remove this
 static const char SIG_EDGE_TOP[] = "edge,top";
 static const char SIG_EDGE_BOTTOM[] = "edge,bottom";
 static const char SIG_EDGE_LEFT[] = "edge,left";
@@ -273,10 +269,6 @@
    {SIG_SCROLL_ANIM_STOP, ""},
    {SIG_SCROLL_DRAG_START, ""},
    {SIG_SCROLL_DRAG_STOP, ""},
-   {SIG_SCROLL_EDGE_TOP, ""},
-   {SIG_SCROLL_EDGE_BOTTOM, ""},
-   {SIG_SCROLL_EDGE_LEFT, ""},
-   {SIG_SCROLL_EDGE_RIGHT, ""},
    {SIG_EDGE_TOP, ""},
    {SIG_EDGE_BOTTOM, ""},
    {SIG_EDGE_LEFT, ""},
@@ -2795,7 +2787,6 @@
            void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
-   evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_LEFT, NULL);
    evas_object_smart_callback_call(obj, SIG_EDGE_LEFT, NULL);
 }
 
@@ -2805,7 +2796,6 @@
             void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
-   evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_RIGHT, NULL);
    evas_object_smart_callback_call(obj, SIG_EDGE_RIGHT, NULL);
 }
 
@@ -2815,7 +2805,6 @@
           void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
-   evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_TOP, NULL);
    evas_object_smart_callback_call(obj, SIG_EDGE_TOP, NULL);
 }
 
@@ -2825,7 +2814,6 @@
              void        *event_info __UNUSED__)
 {
    Evas_Object *obj = data;
-   evas_object_smart_callback_call(obj, SIG_SCROLL_EDGE_BOTTOM, NULL);
    evas_object_smart_callback_call(obj, SIG_EDGE_BOTTOM, NULL);
 }

Log:
elm gengrid: Removed remaining deprecated signals.
  

Author:       seoz
Date:         2011-11-21 00:08:58 -0800 (Mon, 21 Nov 2011)
New Revision: 65475
Trac:         http://trac.enlightenment.org/e/changeset/65475

Modified:
  trunk/elementary/src/lib/elm_gengrid.c 

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-11-21 08:06:40 UTC (rev 65474)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-11-21 08:08:58 UTC (rev 65475)
@@ -120,10 +120,6 @@
 static const char SIG_SCROLL_ANIM_STOP[] = "scroll,anim,stop";
 static const char SIG_SCROLL_DRAG_START[] = "scroll,drag,start";
 static const char SIG_SCROLL_DRAG_STOP[] = "scroll,drag,stop";
-static const char SIG_SCROLL_EDGE_TOP[] = "scroll,edge,top"; // TODO : remove this
-static const char SIG_SCROLL_EDGE_BOTTOM[] = "scroll,edge,bottom"; // TODO : remove this
-static const char SIG_SCROLL_EDGE_LEFT[] = "scroll,edge,left"; // TODO : remove this
-static const char SIG_SCROLL_EDGE_RIGHT[] = "scroll,edge,right"; // TODO : remove this
 static const char SIG_EDGE_TOP[] = "edge,top";
 static const char SIG_EDGE_BOTTOM[] = "edge,bottom";
 static const char SIG_EDGE_LEFT[] = "edge,left";

Log:
elm Elementary.h.in: Fix documentation typo.
  

Author:       seoz
Date:         2011-11-21 01:30:09 -0800 (Mon, 21 Nov 2011)
New Revision: 65476
Trac:         http://trac.enlightenment.org/e/changeset/65476

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-11-21 08:08:58 UTC (rev 65475)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-11-21 09:30:09 UTC (rev 65476)
@@ -18197,7 +18197,7 @@
     *   theme. It must return @c NULL, when no content is desired, or a valid
     *   object handle, otherwise.  The object will be deleted by the genlist on
     *   its deletion or when the item is "unrealized".  See
-    *   #Elm_Genlist_Item_Icon_Get_Cb.
+    *   #Elm_Genlist_Item_Content_Get_Cb.
     * - @c func.state_get - The @c part parameter is the name string of one of
     *   the state parts in the Edje group implementing the item's theme. Return
     *   @c EINA_FALSE for false/off or @c EINA_TRUE for true/on. Genlists will

Log:
elm Elementary.h.in: Sync with AUTHORS.
  

Author:       seoz
Date:         2011-11-23 02:48:48 -0800 (Wed, 23 Nov 2011)
New Revision: 65536
Trac:         http://trac.enlightenment.org/e/changeset/65536

Modified:
  trunk/elementary/src/lib/Elementary.h.in 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-11-23 10:42:58 UTC (rev 65535)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-11-23 10:48:48 UTC (rev 65536)
@@ -254,7 +254,7 @@
 @author Michael Bouchaud <michael.bouchaud@...>
 @author Jonathan Atton (Watchwolf) <jonathan.atton@...>
 @author Brian Wang <brian.wang.0721@...>
-@... Mike Blumenkrantz (zmike) <mike@...>
+@author Mike Blumenkrantz (discomfitor/zmike) <michael.blumenkrantz@...>
 @author Samsung Electronics <tbd>
 @author Samsung SAIT <tbd>
 @author Brett Nash <nash@...>
@@ -284,13 +284,16 @@
 @author Shinwoo Kim <kimcinoo@...>
 @author Govindaraju SM <govi.sm@...> <govism@...>
 @author Prince Kumar Dubey <prince.dubey@...> <prince.dubey@...>
-@... Sung W. Park <sungwoo@...>
-@... Thierry el Borgi <thierry@...>
-@... Shilpa Singh <shilpa.singh@...> <shilpasingh.o@...>
-@... Chanwook Jung <joey.jung@...>
-@... Hyoyoung Chang <hyoyoung.chang@...>
-@... Guillaume "Kuri" Friloux <guillaume.friloux@...>
-@... Kim Yunhan <spbear@...>
+@author Sung W. Park <sungwoo@...>
+@author Thierry el Borgi <thierry@...>
+@author Shilpa Singh <shilpa.singh@...> <shilpasingh.o@...>
+@author Chanwook Jung <joey.jung@...>
+@author Hyoyoung Chang <hyoyoung.chang@...>
+@author Guillaume "Kuri" Friloux <guillaume.friloux@...>
+@author Kim Yunhan <spbear@...>
+@author Bluezery <ohpowel@...>
+@author Nicolas Aguirre <aguirre.nicolas@...>
+@author Sanjeev BA <iamsanjeev@...>
 
 Please contact <enlightenment-devel@...> to get in
 contact with the developers and maintainers.

Log:
elm toolbar: Applied the API change - elm_menu_item_disabled_set to elm_object_item_disabled_set.
  

Author:       seoz
Date:         2011-11-25 07:30:57 -0800 (Fri, 25 Nov 2011)
New Revision: 65598
Trac:         http://trac.enlightenment.org/e/changeset/65598

Modified:
  trunk/elementary/src/lib/elm_toolbar.c 

Modified: trunk/elementary/src/lib/elm_toolbar.c
===================================================================
--- trunk/elementary/src/lib/elm_toolbar.c	2011-11-25 11:52:35 UTC (rev 65597)
+++ trunk/elementary/src/lib/elm_toolbar.c	2011-11-25 15:30:57 UTC (rev 65598)
@@ -537,7 +537,7 @@
                             menu_it = elm_menu_item_add(menu, NULL,
                                                 it->icon_str, it->label,
                                                 _elm_toolbar_item_menu_cb, it);
-                            elm_menu_item_disabled_set(menu_it, it->disabled);
+                            elm_object_item_disabled_set(menu_it, it->disabled);
                             if (it->o_menu)
                               elm_menu_clone(it->o_menu, menu, menu_it);
                          }

Log:
elm genlist: Changed int to Eina_Bool in case it uses 1 or 0.
  

Author:       seoz
Date:         2011-11-29 00:54:19 -0800 (Tue, 29 Nov 2011)
New Revision: 65679
Trac:         http://trac.enlightenment.org/e/changeset/65679

Modified:
  trunk/elementary/src/lib/elm_genlist.c 

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-11-29 07:44:06 UTC (rev 65678)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-11-29 08:54:19 UTC (rev 65679)
@@ -2163,7 +2163,7 @@
    Elm_Gen_Item *it;
    Elm_Gen_Item *git;
    Evas_Coord y = 0, ox, oy, ow, oh, cvx, cvy, cvw, cvh;
-   int vis;
+   Eina_Bool vis = EINA_FALSE;
 
    evas_event_freeze(evas_object_evas_get(itb->wd->obj));
    evas_object_geometry_get(itb->wd->pan_smart, &ox, &oy, &ow, &oh);

Log:
elm gen/gengrid/genlist: Undeprecate some gengrid/genlist APIs and
  deprecate all elm_gen APIs.
  
  We will merge gengrid into genlist later and remove elm_gen.
  I updated http://trac.enlightenment.org/e/wiki/ElementaryChanges
  I will fix other libraries/programs in trunk soon.
  

Author:       seoz
Date:         2011-11-29 16:59:19 -0800 (Tue, 29 Nov 2011)
New Revision: 65700
Trac:         http://trac.enlightenment.org/e/changeset/65700

Modified:
  trunk/elementary/src/lib/Elementary.h.in trunk/elementary/src/lib/elc_fileselector.c trunk/elementary/src/lib/elm_gengrid.c trunk/elementary/src/lib/elm_genlist.c trunk/elementary/src/lib/elm_store.c 

Modified: trunk/elementary/src/lib/Elementary.h.in
===================================================================
--- trunk/elementary/src/lib/Elementary.h.in	2011-11-30 00:16:36 UTC (rev 65699)
+++ trunk/elementary/src/lib/Elementary.h.in	2011-11-30 00:59:19 UTC (rev 65700)
@@ -8000,28 +8000,29 @@
              Elm_Gen_Item_Del_Cb       del;
           } func;
      };
-   EAPI void elm_gen_clear(Evas_Object *obj);
-   EAPI void elm_gen_item_selected_set(Elm_Gen_Item *it, Eina_Bool selected);
-   EAPI Eina_Bool elm_gen_item_selected_get(const Elm_Gen_Item *it);
-   EAPI void elm_gen_always_select_mode_set(Evas_Object *obj, Eina_Bool always_select);
-   EAPI Eina_Bool elm_gen_always_select_mode_get(const Evas_Object *obj);
-   EAPI void elm_gen_no_select_mode_set(Evas_Object *obj, Eina_Bool no_select);
-   EAPI Eina_Bool elm_gen_no_select_mode_get(const Evas_Object *obj);
-   EAPI void elm_gen_bounce_set(Evas_Object *obj, Eina_Bool h_bounce, Eina_Bool v_bounce);
-   EAPI void elm_gen_bounce_get(const Evas_Object *obj, Eina_Bool *h_bounce, Eina_Bool *v_bounce);
-   EAPI void elm_gen_page_relative_set(Evas_Object *obj, double h_pagerel, double v_pagerel);
-   EAPI void elm_gen_page_relative_get(const Evas_Object *obj, double *h_pagerel, double *v_pagerel);
-   EAPI void elm_gen_page_size_set(Evas_Object *obj, Evas_Coord h_pagesize, Evas_Coord v_pagesize);
-   EAPI void elm_gen_current_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber);
-   EAPI void elm_gen_last_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber);
-   EAPI void elm_gen_page_show(const Evas_Object *obj, int h_pagenumber, int v_pagenumber);
-   EAPI void elm_gen_page_bring_in(const Evas_Object *obj, int h_pagenumber, int v_pagenumber);
-   EAPI Elm_Gen_Item *elm_gen_first_item_get(const Evas_Object *obj);
-   EAPI Elm_Gen_Item *elm_gen_last_item_get(const Evas_Object *obj);
-   EAPI Elm_Gen_Item *elm_gen_item_next_get(const Elm_Gen_Item *it);
-   EAPI Elm_Gen_Item *elm_gen_item_prev_get(const Elm_Gen_Item *it);
-   EAPI Evas_Object *elm_gen_item_widget_get(const Elm_Gen_Item *it);
+   EINA_DEPRECATED EAPI void elm_gen_clear(Evas_Object *obj);
+   EINA_DEPRECATED EAPI void elm_gen_item_selected_set(Elm_Gen_Item *it, Eina_Bool selected);
+   EINA_DEPRECATED EAPI Eina_Bool elm_gen_item_selected_get(const Elm_Gen_Item *it);
+   EINA_DEPRECATED EAPI void elm_gen_always_select_mode_set(Evas_Object *obj, Eina_Bool always_select);
+   EINA_DEPRECATED EAPI Eina_Bool elm_gen_always_select_mode_get(const Evas_Object *obj);
+   EINA_DEPRECATED EAPI void elm_gen_no_select_mode_set(Evas_Object *obj, Eina_Bool no_select);
+   EINA_DEPRECATED EAPI Eina_Bool elm_gen_no_select_mode_get(const Evas_Object *obj);
+   EINA_DEPRECATED EAPI void elm_gen_bounce_set(Evas_Object *obj, Eina_Bool h_bounce, Eina_Bool v_bounce);
+   EINA_DEPRECATED EAPI void elm_gen_bounce_get(const Evas_Object *obj, Eina_Bool *h_bounce, Eina_Bool *v_bounce);
+   EINA_DEPRECATED EAPI void elm_gen_page_relative_set(Evas_Object *obj, double h_pagerel, double v_pagerel);
+   EINA_DEPRECATED EAPI void elm_gen_page_relative_get(const Evas_Object *obj, double *h_pagerel, double *v_pagerel);
 
+   EINA_DEPRECATED EAPI void elm_gen_page_size_set(Evas_Object *obj, Evas_Coord h_pagesize, Evas_Coord v_pagesize);
+   EINA_DEPRECATED EAPI void elm_gen_current_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber);
+   EINA_DEPRECATED EAPI void elm_gen_last_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber);
+   EINA_DEPRECATED EAPI void elm_gen_page_show(const Evas_Object *obj, int h_pagenumber, int v_pagenumber);
+   EINA_DEPRECATED EAPI void elm_gen_page_bring_in(const Evas_Object *obj, int h_pagenumber, int v_pagenumber);
+   EINA_DEPRECATED EAPI Elm_Gen_Item *elm_gen_first_item_get(const Evas_Object *obj);
+   EINA_DEPRECATED EAPI Elm_Gen_Item *elm_gen_last_item_get(const Evas_Object *obj);
+   EINA_DEPRECATED EAPI Elm_Gen_Item *elm_gen_item_next_get(const Elm_Gen_Item *it);
+   EINA_DEPRECATED EAPI Elm_Gen_Item *elm_gen_item_prev_get(const Elm_Gen_Item *it);
+   EINA_DEPRECATED EAPI Evas_Object *elm_gen_item_widget_get(const Elm_Gen_Item *it);
+
    /**
     * @defgroup Gengrid Gengrid (Generic grid)
     *
@@ -8613,7 +8614,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void               elm_gengrid_always_select_mode_set(Evas_Object *obj, Eina_Bool always_select) EINA_ARG_NONNULL(1);
+   EAPI void               elm_gengrid_always_select_mode_set(Evas_Object *obj, Eina_Bool always_select) EINA_ARG_NONNULL(1);
 
    /**
     * Get whether items on a given gengrid widget have their selection
@@ -8628,7 +8629,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI Eina_Bool          elm_gengrid_always_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool          elm_gengrid_always_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    /**
     * Set whether items on a given gengrid widget can be selected or not.
@@ -8646,7 +8647,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void               elm_gengrid_no_select_mode_set(Evas_Object *obj, Eina_Bool no_select) EINA_ARG_NONNULL(1);
+   EAPI void               elm_gengrid_no_select_mode_set(Evas_Object *obj, Eina_Bool no_select) EINA_ARG_NONNULL(1);
 
    /**
     * Get whether items on a given gengrid widget can be selected or
@@ -8660,7 +8661,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI Eina_Bool          elm_gengrid_no_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool          elm_gengrid_no_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    /**
     * Enable or disable multi-selection in a given gengrid widget
@@ -8718,7 +8719,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void               elm_gengrid_bounce_set(Evas_Object *obj, Eina_Bool h_bounce, Eina_Bool v_bounce) EINA_ARG_NONNULL(1);
+   EAPI void               elm_gengrid_bounce_set(Evas_Object *obj, Eina_Bool h_bounce, Eina_Bool v_bounce) EINA_ARG_NONNULL(1);
 
    /**
     * Get whether bouncing effects are enabled or disabled, for a
@@ -8734,7 +8735,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void               elm_gengrid_bounce_get(const Evas_Object *obj, Eina_Bool *h_bounce, Eina_Bool *v_bounce) EINA_ARG_NONNULL(1);
+   EAPI void               elm_gengrid_bounce_get(const Evas_Object *obj, Eina_Bool *h_bounce, Eina_Bool *v_bounce) EINA_ARG_NONNULL(1);
 
    /**
     * Set a given gengrid widget's scrolling page size, relative to
@@ -8768,7 +8769,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void               elm_gengrid_page_relative_set(Evas_Object *obj, double h_pagerel, double v_pagerel) EINA_ARG_NONNULL(1);
+   EAPI void               elm_gengrid_page_relative_set(Evas_Object *obj, double h_pagerel, double v_pagerel) EINA_ARG_NONNULL(1);
 
    /**
     * Get a given gengrid widget's scrolling page size, relative to
@@ -8784,7 +8785,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void               elm_gengrid_page_relative_get(const Evas_Object *obj, double *h_pagerel, double *v_pagerel) EINA_ARG_NONNULL(1);
+   EAPI void               elm_gengrid_page_relative_get(const Evas_Object *obj, double *h_pagerel, double *v_pagerel) EINA_ARG_NONNULL(1);
 
    /**
     * Set a given gengrid widget's scrolling page size
@@ -8812,7 +8813,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void               elm_gengrid_page_size_set(Evas_Object *obj, Evas_Coord h_pagesize, Evas_Coord v_pagesize) EINA_ARG_NONNULL(1);
+   EAPI void               elm_gengrid_page_size_set(Evas_Object *obj, Evas_Coord h_pagesize, Evas_Coord v_pagesize) EINA_ARG_NONNULL(1);
 
    /**
     * @brief Get gengrid current page number.
@@ -8830,7 +8831,7 @@
     * @see elm_gengrid_page_show()
     * @see elm_gengrid_page_brint_in()
     */
-   EINA_DEPRECATED EAPI void         elm_gengrid_current_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
+   EAPI void         elm_gengrid_current_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
 
    /**
     * @brief Get scroll last page number.
@@ -8846,7 +8847,7 @@
     * @see elm_gengrid_page_show()
     * @see elm_gengrid_page_brint_in()
     */
-   EINA_DEPRECATED EAPI void         elm_gengrid_last_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
+   EAPI void         elm_gengrid_last_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber) EINA_ARG_NONNULL(1);
 
    /**
     * Show a specific virtual region within the gengrid content object by page number.
@@ -8870,7 +8871,7 @@
     *
     * @see elm_gengrid_page_bring_in()
     */
-   EINA_DEPRECATED EAPI void         elm_gengrid_page_show(const Evas_Object *obj, int h_pagenumber, int v_pagenumber) EINA_ARG_NONNULL(1);
+   EAPI void         elm_gengrid_page_show(const Evas_Object *obj, int h_pagenumber, int v_pagenumber) EINA_ARG_NONNULL(1);
 
    /**
     * Show a specific virtual region within the gengrid content object by page number.
@@ -8894,7 +8895,7 @@
     *
     * @see elm_gengrid_page_show()
     */
-    EINA_DEPRECATED EAPI void         elm_gengrid_page_bring_in(const Evas_Object *obj, int h_pagenumber, int v_pagenumber) EINA_ARG_NONNULL(1);
+    EAPI void         elm_gengrid_page_bring_in(const Evas_Object *obj, int h_pagenumber, int v_pagenumber) EINA_ARG_NONNULL(1);
 
    /**
     * Set the direction in which a given gengrid widget will expand while
@@ -8946,7 +8947,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI Elm_Gengrid_Item  *elm_gengrid_first_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Elm_Gengrid_Item  *elm_gengrid_first_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    /**
     * Get the last item in a given gengrid widget
@@ -8962,7 +8963,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI Elm_Gengrid_Item  *elm_gengrid_last_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Elm_Gengrid_Item  *elm_gengrid_last_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    /**
     * Get the @b next item in a gengrid widget's internal list of items,
@@ -8979,7 +8980,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI Elm_Gengrid_Item  *elm_gengrid_item_next_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Elm_Gengrid_Item  *elm_gengrid_item_next_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
 
    /**
     * Get the @b previous item in a gengrid widget's internal list of items,
@@ -8996,7 +8997,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI Elm_Gengrid_Item  *elm_gengrid_item_prev_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Elm_Gengrid_Item  *elm_gengrid_item_prev_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
 
    /**
     * Get the gengrid object's handle which contains a given gengrid
@@ -9009,7 +9010,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI Evas_Object       *elm_gengrid_item_gengrid_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Evas_Object       *elm_gengrid_item_gengrid_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
 
    /**
     * Remove a gengrid item from its parent, deleting it.
@@ -9130,7 +9131,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void elm_gengrid_item_selected_set(Elm_Gengrid_Item *item, Eina_Bool selected) EINA_ARG_NONNULL(1);
+   EAPI void elm_gengrid_item_selected_set(Elm_Gengrid_Item *item, Eina_Bool selected) EINA_ARG_NONNULL(1);
 
    /**
     * Get whether a given gengrid item is selected or not
@@ -9144,7 +9145,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI Eina_Bool elm_gengrid_item_selected_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool elm_gengrid_item_selected_get(const Elm_Gengrid_Item *item) EINA_ARG_NONNULL(1);
 
    /**
     * Get the real Evas object created to implement the view of a
@@ -9487,7 +9488,7 @@
     *
     * @ingroup Gengrid
     */
-   EINA_DEPRECATED EAPI void elm_gengrid_clear(Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void elm_gengrid_clear(Evas_Object *obj) EINA_ARG_NONNULL(1);
 
    /**
     * Get the selected item in a given gengrid widget
@@ -18269,7 +18270,7 @@
     * item before another item and elm_genlist_item_insert_after() inserts after
     * the indicated item.
     *
-    * The application can clear the list with elm_gen_clear() which deletes
+    * The application can clear the list with elm_genlist_clear() which deletes
     * all the items in the list and elm_genlist_item_del() will delete a specific
     * item. elm_genlist_item_subitems_clear() will clear all items that are
     * children of the indicated parent item.
@@ -18327,7 +18328,7 @@
     *
     * Items will only call their selection func and callback when first becoming
     * selected. Any further clicks will do nothing, unless you enable always
-    * select with elm_gen_always_select_mode_set(). This means even if
+    * select with elm_genlist_always_select_mode_set(). This means even if
     * selected, every click will make the selected callbacks be called.
     * elm_genlist_no_select_mode_set() will turn off the ability to select
     * items entirely and they will neither appear selected nor call selected
@@ -18559,7 +18560,7 @@
     *
     * @see elm_genlist_item_append()
     * @see elm_genlist_item_del()
-    * @see elm_gen_clear()
+    * @see elm_genlist_clear()
     *
     * @ingroup Genlist
     */
@@ -18571,13 +18572,11 @@
     *
     * This removes (and deletes) all items in @p obj, leaving it empty.
     *
-    * This is deprecated. Please use elm_gen_clear() instead.
-    * 
     * @see elm_genlist_item_del(), to remove just one item.
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI void elm_genlist_clear(Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI void elm_genlist_clear(Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
     * Enable or disable multi-selection in the genlist
     *
@@ -18648,17 +18647,15 @@
     *
     * Items will only call their selection func and callback when first
     * becoming selected. Any further clicks will do nothing, unless you
-    * enable always select with elm_gen_always_select_mode_set().
+    * enable always select with elm_genlist_always_select_mode_set().
     * This means that, even if selected, every click will make the selected
     * callbacks be called.
     * 
-    * This function is deprecated. please see elm_gen_always_select_mode_set()
-    *
     * @see elm_genlist_always_select_mode_get()
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI void              elm_genlist_always_select_mode_set(Evas_Object *obj, Eina_Bool always_select) EINA_ARG_NONNULL(1);
+   EAPI void              elm_genlist_always_select_mode_set(Evas_Object *obj, Eina_Bool always_select) EINA_ARG_NONNULL(1);
    /**
     * Get the always select mode.
     *
@@ -18670,7 +18667,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI Eina_Bool         elm_genlist_always_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool         elm_genlist_always_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
     * Enable/disable the no select mode.
     *
@@ -18685,7 +18682,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI void              elm_genlist_no_select_mode_set(Evas_Object *obj, Eina_Bool no_select) EINA_ARG_NONNULL(1);
+   EAPI void              elm_genlist_no_select_mode_set(Evas_Object *obj, Eina_Bool no_select) EINA_ARG_NONNULL(1);
    /**
     * Gets whether the no select mode is enabled.
     *
@@ -18697,7 +18694,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI Eina_Bool         elm_genlist_no_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool         elm_genlist_no_select_mode_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
     * Enable/disable compress mode.
     *
@@ -18779,7 +18776,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI void              elm_genlist_bounce_set(Evas_Object *obj, Eina_Bool h_bounce, Eina_Bool v_bounce) EINA_ARG_NONNULL(1);
+   EAPI void              elm_genlist_bounce_set(Evas_Object *obj, Eina_Bool h_bounce, Eina_Bool v_bounce) EINA_ARG_NONNULL(1);
    /**
     * Get whether the horizontal and vertical bouncing effect is enabled.
     *
@@ -18793,7 +18790,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI void              elm_genlist_bounce_get(const Evas_Object *obj, Eina_Bool *h_bounce, Eina_Bool *v_bounce) EINA_ARG_NONNULL(1);
+   EAPI void              elm_genlist_bounce_get(const Evas_Object *obj, Eina_Bool *h_bounce, Eina_Bool *v_bounce) EINA_ARG_NONNULL(1);
    /**
     * Enable/disable homogeneous mode.
     *
@@ -19111,7 +19108,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI Elm_Genlist_Item *elm_genlist_first_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Elm_Genlist_Item *elm_genlist_first_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
     * Get the last item in the genlist
     *
@@ -19121,7 +19118,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI Elm_Genlist_Item *elm_genlist_last_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
+   EAPI Elm_Genlist_Item *elm_genlist_last_item_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
    /**
     * Set the scrollbar policy
     *
@@ -19169,7 +19166,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI Elm_Genlist_Item  *elm_genlist_item_next_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Elm_Genlist_Item  *elm_genlist_item_next_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
    /**
     * Get the @b previous item in a genlist widget's internal list of items,
     * given a handle to one of those items.
@@ -19185,7 +19182,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI Elm_Genlist_Item  *elm_genlist_item_prev_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Elm_Genlist_Item  *elm_genlist_item_prev_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
    /**
     * Get the genlist object's handle which contains a given genlist
     * item
@@ -19195,11 +19192,9 @@
     *
     * This returns the genlist object itself that an item belongs to.
     *
-    * This function is deprecated. Please use elm_gen_item_widget_get()
-    * 
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI Evas_Object       *elm_genlist_item_genlist_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Evas_Object       *elm_genlist_item_genlist_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
    /**
     * Get the parent item of the given item
     *
@@ -19242,7 +19237,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI void elm_genlist_item_selected_set(Elm_Genlist_Item *item, Eina_Bool selected) EINA_ARG_NONNULL(1);
+   EAPI void elm_genlist_item_selected_set(Elm_Genlist_Item *item, Eina_Bool selected) EINA_ARG_NONNULL(1);
    /**
     * Get whether a given genlist item is selected or not
     *
@@ -19253,7 +19248,7 @@
     *
     * @ingroup Genlist
     */
-   EINA_DEPRECATED EAPI Eina_Bool elm_genlist_item_selected_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
+   EAPI Eina_Bool elm_genlist_item_selected_get(const Elm_Genlist_Item *item) EINA_ARG_NONNULL(1);
    /**
     * Sets the expanded state of an item.
     *

Modified: trunk/elementary/src/lib/elc_fileselector.c
===================================================================
--- trunk/elementary/src/lib/elc_fileselector.c	2011-11-30 00:16:36 UTC (rev 65699)
+++ trunk/elementary/src/lib/elc_fileselector.c	2011-11-30 00:59:19 UTC (rev 65700)
@@ -630,8 +630,8 @@
    evas_object_smart_callback_call(wr->obj, SIG_DIRECTORY_OPEN, (void *)wr->path);
    if (!wr->parent)
      {
-        elm_gen_clear(wr->wd->files_list);
-        elm_gen_clear(wr->wd->files_grid);
+        elm_genlist_clear(wr->wd->files_list);
+        elm_gengrid_clear(wr->wd->files_grid);
         eina_stringshare_replace(&wr->wd->path, wr->path);
         _do_anchors(wr->obj, wr->path);
      }

Modified: trunk/elementary/src/lib/elm_gengrid.c
===================================================================
--- trunk/elementary/src/lib/elm_gengrid.c	2011-11-30 00:16:36 UTC (rev 65699)
+++ trunk/elementary/src/lib/elm_gengrid.c	2011-11-30 00:59:19 UTC (rev 65700)
@@ -272,14 +272,14 @@
      }
    else if ((!strcmp(ev->keyname, "Home")) || (!strcmp(ev->keyname, "KP_Home")))
      {
-        it = elm_gen_first_item_get(obj);
+        it = elm_gengrid_first_item_get(obj);
         elm_gengrid_item_bring_in(it);
         ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
         return EINA_TRUE;
      }
    else if ((!strcmp(ev->keyname, "End")) || (!strcmp(ev->keyname, "KP_End")))
      {
-        it = elm_gen_last_item_get(obj);
+        it = elm_gengrid_last_item_get(obj);
         elm_gengrid_item_bring_in(it);
         ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
         return EINA_TRUE;
@@ -343,7 +343,7 @@
 {
    if (!wd->selected) return EINA_FALSE;
    while (wd->selected)
-     elm_gen_item_selected_set(wd->selected->data, EINA_FALSE);
+     elm_gengrid_item_selected_set(wd->selected->data, EINA_FALSE);
 
    return EINA_TRUE;
 }
@@ -353,17 +353,17 @@
 {
    if (!wd->selected) return EINA_FALSE;
 
-   Elm_Gen_Item *prev = elm_gen_item_prev_get(wd->last_selected_item);
+   Elm_Gen_Item *prev = elm_gengrid_item_prev_get(wd->last_selected_item);
    if (!prev) return EINA_TRUE;
-   if (elm_gen_item_selected_get(prev))
+   if (elm_gengrid_item_selected_get(prev))
      {
-        elm_gen_item_selected_set(wd->last_selected_item, EINA_FALSE);
+        elm_gengrid_item_selected_set(wd->last_selected_item, EINA_FALSE);
         wd->last_selected_item = prev;
         elm_gengrid_item_show(wd->last_selected_item);
      }
    else
      {
-        elm_gen_item_selected_set(prev, EINA_TRUE);
+        elm_gengrid_item_selected_set(prev, EINA_TRUE);
         elm_gengrid_item_show(prev);
      }
 
@@ -375,17 +375,17 @@
 {
    if (!wd->selected) return EINA_FALSE;
 
-   Elm_Gen_Item *next = elm_gen_item_next_get(wd->last_selected_item);
+   Elm_Gen_Item *next = elm_gengrid_item_next_get(wd->last_selected_item);
    if (!next) return EINA_TRUE;
-   if (elm_gen_item_selected_get(next))
+   if (elm_gengrid_item_selected_get(next))
      {
-        elm_gen_item_selected_set(wd->last_selected_item, EINA_FALSE);
+        elm_gengrid_item_selected_set(wd->last_selected_item, EINA_FALSE);
         wd->last_selected_item = next;
         elm_gengrid_item_show(wd->last_selected_item);
      }
    else
      {
-        elm_gen_item_selected_set(next, EINA_TRUE);
+        elm_gengrid_item_selected_set(next, EINA_TRUE);
         elm_gengrid_item_show(next);
      }
 
@@ -432,24 +432,24 @@
         prev = ELM_GEN_ITEM_FROM_INLIST(wd->items->last);
         while ((prev) && (prev->delete_me))
           prev = ELM_GEN_ITEM_FROM_INLIST(EINA_INLIST_GET(prev)->prev);
-        elm_gen_item_selected_set(prev, EINA_TRUE);
+        elm_gengrid_item_selected_set(prev, EINA_TRUE);
         elm_gengrid_item_show(prev);
         return EINA_TRUE;
      }
-   else prev = elm_gen_item_prev_get(wd->last_selected_item);
+   else prev = elm_gengrid_item_prev_get(wd->last_selected_item);
 
    if (!prev) return EINA_FALSE;
 
    for (i = 1; i < wd->nmax; i++)
      {
-        Elm_Gen_Item *tmp = elm_gen_item_prev_get(prev);
+        Elm_Gen_Item *tmp = elm_gengrid_item_prev_get(prev);
         if (!tmp) return EINA_FALSE;
         prev = tmp;
      }
 
    _deselect_all_items(wd);
 
-   elm_gen_item_selected_set(prev, EINA_TRUE);
+   elm_gengrid_item_selected_set(prev, EINA_TRUE);
    elm_gengrid_item_show(prev);
    return EINA_TRUE;
 }
@@ -466,24 +466,24 @@
         next = ELM_GEN_ITEM_FROM_INLIST(wd->items);
         while ((next) && (next->delete_me))
           next = ELM_GEN_ITEM_FROM_INLIST(EINA_INLIST_GET(next)->next);
-        elm_gen_item_selected_set(next, EINA_TRUE);
+        elm_gengrid_item_selected_set(next, EINA_TRUE);
         elm_gengrid_item_show(next);
         return EINA_TRUE;
      }
-   else next = elm_gen_item_next_get(wd->last_selected_item);
+   else next = elm_gengrid_item_next_get(wd->last_selected_item);
 
    if (!next) return EINA_FALSE;
 
    for (i = 1; i < wd->nmax; i++)
      {
-        Elm_Gen_Item *tmp = elm_gen_item_next_get(next);
+        Elm_Gen_Item *tmp = elm_gengrid_item_next_get(next);
         if (!tmp) return EINA_FALSE;
         next = tmp;
      }
 
    _deselect_all_items(wd);
 
-   elm_gen_item_selected_set(next, EINA_TRUE);
+   elm_gengrid_item_selected_set(next, EINA_TRUE);
    elm_gengrid_item_show(next);
    return EINA_TRUE;
 }
@@ -498,13 +498,13 @@
         while ((prev) && (prev->delete_me))
           prev = ELM_GEN_ITEM_FROM_INLIST(EINA_INLIST_GET(prev)->prev);
      }
-   else prev = elm_gen_item_prev_get(wd->last_selected_item);
+   else prev = elm_gengrid_item_prev_get(wd->last_selected_item);
 
    if (!prev) return EINA_FALSE;
 
    _deselect_all_items(wd);
 
-   elm_gen_item_selected_set(prev, EINA_TRUE);
+   elm_gengrid_item_selected_set(prev, EINA_TRUE);
    elm_gengrid_item_show(prev);
    return EINA_TRUE;
 }
@@ -519,13 +519,13 @@
         while ((next) && (next->delete_me))
           next = ELM_GEN_ITEM_FROM_INLIST(EINA_INLIST_GET(next)->next);
      }
-   else next = elm_gen_item_next_get(wd->last_selected_item);
+   else next = elm_gengrid_item_next_get(wd->last_selected_item);
 
    if (!next) return EINA_FALSE;
 
    _deselect_all_items(wd);
 
-   elm_gen_item_selected_set(next, EINA_TRUE);
+   elm_gengrid_item_selected_set(next, EINA_TRUE);
    elm_gengrid_item_show(next);
    return EINA_TRUE;
 }
@@ -584,7 +584,7 @@
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
-   elm_gen_clear(obj);
+   elm_gengrid_clear(obj);
    evas_object_del(wd->pan_smart);
    wd->pan_smart = NULL;
 }
@@ -2210,7 +2210,7 @@
 EAPI void
 elm_gengrid_clear(Evas_Object *obj)
 {
-   elm_gen_clear(obj);
+   elm_gengrid_clear(obj);
 }
 
 EAPI const Evas_Object *
@@ -2317,7 +2317,7 @@
 elm_gengrid_item_selected_set(Elm_Gen_Item *it,
                               Eina_Bool         selected)
 {
-   elm_gen_item_selected_set(it, selected);
+   elm_gengrid_item_selected_set(it, selected);
 }
 
 EAPI Eina_Bool
@@ -2549,26 +2549,26 @@
 elm_gengrid_always_select_mode_set(Evas_Object *obj,
                                    Eina_Bool    always_select)
 {
-   elm_gen_always_select_mode_set(obj, always_select);
+   elm_gengrid_always_select_mode_set(obj, always_select);
 }
 
 EAPI Eina_Bool
 elm_gengrid_always_select_mode_get(const Evas_Object *obj)
 {
-   return elm_gen_always_select_mode_get(obj);
+   return elm_gengrid_always_select_mode_get(obj);
 }
 
 EAPI void
 elm_gengrid_no_select_mode_set(Evas_Object *obj,
                                Eina_Bool    no_select)
 {
-   elm_gen_no_select_mode_set(obj, no_select);
+   elm_gengrid_no_select_mode_set(obj, no_select);
 }
 
 EAPI Eina_Bool
 elm_gengrid_no_select_mode_get(const Evas_Object *obj)
 {
-   return elm_gen_no_select_mode_get(obj);
+   return elm_gengrid_no_select_mode_get(obj);
 }
 
 EAPI void
@@ -2576,7 +2576,7 @@
                        Eina_Bool    h_bounce,
                        Eina_Bool    v_bounce)
 {
-   elm_gen_bounce_set(obj, h_bounce, v_bounce);
+   elm_gengrid_bounce_set(obj, h_bounce, v_bounce);
 }
 
 EAPI void
@@ -2584,7 +2584,7 @@
                        Eina_Bool         *h_bounce,
                        Eina_Bool         *v_bounce)
 {
-   return elm_gen_bounce_get(obj, h_bounce, v_bounce);
+   return elm_gengrid_bounce_get(obj, h_bounce, v_bounce);
 }
 
 EAPI void
@@ -2592,13 +2592,13 @@
                               double       h_pagerel,
                               double       v_pagerel)
 {
-   elm_gen_page_relative_set(obj, h_pagerel, v_pagerel);
+   elm_gengrid_page_relative_set(obj, h_pagerel, v_pagerel);
 }
 
 EAPI void
 elm_gengrid_page_relative_get(const Evas_Object *obj, double *h_pagerel, double *v_pagerel)
 {
-   elm_gen_page_relative_get(obj, h_pagerel, v_pagerel);
+   elm_gengrid_page_relative_get(obj, h_pagerel, v_pagerel);
 }
 
 EAPI void
@@ -2606,61 +2606,61 @@
                           Evas_Coord   h_pagesize,
                           Evas_Coord   v_pagesize)
 {
-   elm_gen_page_size_set(obj, h_pagesize, v_pagesize);
+   elm_gengrid_page_size_set(obj, h_pagesize, v_pagesize);
 }
 
 EAPI void
 elm_gengrid_current_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber)
 {
-   elm_gen_current_page_get(obj, h_pagenumber, v_pagenumber);
+   elm_gengrid_current_page_get(obj, h_pagenumber, v_pagenumber);
 }
 
 EAPI void
 elm_gengrid_last_page_get(const Evas_Object *obj, int *h_pagenumber, int *v_pagenumber)
 {
-   elm_gen_last_page_get(obj, h_pagenumber, v_pagenumber);
+   elm_gengrid_last_page_get(obj, h_pagenumber, v_pagenumber);
 }
 
 EAPI void
 elm_gengrid_page_show(const Evas_Object *obj, int h_pagenumber, int v_pagenumber)
 {
-   elm_gen_page_show(obj, h_pagenumber, v_pagenumber);
+   elm_gengrid_page_show(obj, h_pagenumber, v_pagenumber);
 }
 
 EAPI void
 elm_gengrid_page_bring_in(const Evas_Object *obj, int h_pagenumber, int v_pagenumber)
 {
-   elm_gen_page_bring_in(obj, h_pagenumber, v_pagenumber);
+   elm_gengrid_page_bring_in(obj, h_pagenumber, v_pagenumber);
 }
 
 EAPI Elm_Gen_Item *
 elm_gengrid_first_item_get(const Evas_Object *obj)
 {
-   return elm_gen_first_item_get(obj);
+   return elm_gengrid_first_item_get(obj);
 }
 
 EAPI Elm_Gen_Item *
 elm_gengrid_last_item_get(const Evas_Object *obj)
 {
-   return elm_gen_last_item_get(obj);
+   return elm_gengrid_last_item_get(obj);
 }
 
 EAPI Elm_Gen_Item *
 elm_gengrid_item_next_get(const Elm_Gen_Item *it)
 {
-   return elm_gen_item_next_get(it);
+   return elm_gengrid_item_next_get(it);
 }
 
 EAPI Elm_Gen_Item *
 elm_gengrid_item_prev_get(const Elm_Gen_Item *it)
 {
-   return elm_gen_item_prev_get(it);
+   return elm_gengrid_item_prev_get(it);
 }
 
 EAPI Evas_Object *
 elm_gengrid_item_gengrid_get(const Elm_Gen_Item *it)
 {
-   return elm_gen_item_widget_get(it);
+   return elm_gengrid_item_gengrid_get(it);
 }
 
 EAPI void

Modified: trunk/elementary/src/lib/elm_genlist.c
===================================================================
--- trunk/elementary/src/lib/elm_genlist.c	2011-11-30 00:16:36 UTC (rev 65699)
+++ trunk/elementary/src/lib/elm_genlist.c	2011-11-30 00:59:19 UTC (rev 65700)
@@ -76,9 +76,9 @@
    int               minw, minh;
    long              count;
    Evas_Coord        pan_x, pan_y;
-   Eina_Bool         reorder_mode : 1;
+   Eina_Bool         reorder_mode : 1; /* a flag for reorder mode enable/disable */
    Eina_Bool         on_hold : 1;
-   Eina_Bool         multi : 1;
+   Eina_Bool         multi : 1; /* a flag for item multi selection */
    Eina_Bool         no_select : 1;
    Eina_Bool         wasselected : 1;
    Eina_Bool         always_select : 1;
@@ -351,14 +351,14 @@
      }
    else if ((!strcmp(ev->keyname, "Home")) || (!strcmp(ev->keyname, "KP_Home")))
      {
-        it = elm_gen_first_item_get(obj);
+        it = elm_genlist_first_item_get(obj);
         elm_genlist_item_bring_in(it);
         ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
         return EINA_TRUE;
      }
    else if ((!strcmp(ev->keyname, "End")) || (!strcmp(ev->keyname, "KP_End")))
      {
-        it = elm_gen_last_item_get(obj);
+        it = elm_genlist_last_item_get(obj);
         elm_genlist_item_bring_in(it);
         ev->event_flags |= EVAS_EVENT_FLAG_ON_HOLD;
         return EINA_TRUE;
@@ -410,7 +410,7 @@
 {
    if (!wd->selected) return EINA_FALSE;
    while (wd->selected)
-     elm_gen_item_selected_set(wd->selected->data, EINA_FALSE);
+     elm_genlist_item_selected_set(wd->selected->data, EINA_FALSE);
 
    return EINA_TRUE;
 }
@@ -421,18 +421,18 @@
    if (!wd->selected) return EINA_FALSE;
    if (!wd->multi) return EINA_FALSE;
 
-   Elm_Gen_Item *prev = elm_gen_item_prev_get(wd->last_selected_item);
+   Elm_Gen_Item *prev = elm_genlist_item_prev_get(wd->last_selected_item);
    if (!prev) return EINA_TRUE;
 
-   if (elm_gen_item_selected_get(prev))
+   if (elm_genlist_item_selected_get(prev))
      {
-        elm_gen_item_selected_set(wd->last_selected_item, EINA_FALSE);
+        elm_genlist_item_selected_set(wd->last_selected_item, EINA_FALSE);
         wd->last_selected_item = prev;
         elm_genlist_item_show(wd->last_selected_item);
      }
    else
      {
-        elm_gen_item_selected_set(prev, EINA_TRUE);
+        elm_genlist_item_selected_set(prev, EINA_TRUE);
         elm_genlist_item_show(prev);
      }
    return EINA_TRUE;
@@ -444,18 +444,18 @@
    if (!wd->selected) return EINA_FALSE;
    if (!wd->multi) return EINA_FALSE;
 
-   Elm_Gen_Item *next = elm_gen_item_next_get(wd->last_selected_item);
+   Elm_Gen_Item *next = elm_genlist_item_next_get(wd->last_selected_item);
    if (!next) return EINA_TRUE;
 
-   if (elm_gen_item_selected_get(next))
+   if (elm_genlist_item_selected_get(next))
      {
-        elm_gen_item_selected_set(wd->last_selected_item, EINA_FALSE);
+        elm_genlist_item_selected_set(wd->last_selected_item, EINA_FALSE);
         wd->last_selected_item = next;
         elm_genlist_item_show(wd->last_selected_item);
      }
    else
      {
-        elm_gen_item_selected_set(next, EINA_TRUE);
+        elm_genlist_item_selected_set(next, EINA_TRUE);
         elm_genlist_item_show(next);
      }
    return EINA_TRUE;
@@ -471,13 +471,13 @@
         while ((prev) && (prev->delete_me))
           prev = ELM_GEN_ITEM_FROM_INLIST(EINA_INLIST_GET(prev)->prev);
      }
-   else prev = elm_gen_item_prev_get(wd->last_selected_item);
+   else prev = elm_genlist_item_prev_get(wd->last_selected_item);
 
    if (!prev) return EINA_FALSE;
 
    _deselect_all_items(wd);
 
-   elm_gen_item_selected_set(prev, EINA_TRUE);
+   elm_genlist_item_selected_set(prev, EINA_TRUE);
    elm_genlist_item_show(prev);
    return EINA_TRUE;
 }
@@ -492,13 +492,13 @@
         while ((next) && (next->delete_me))
           next = ELM_GEN_ITEM_FROM_INLIST(EINA_INLIST_GET(next)->next);
      }
-   else next = elm_gen_item_next_get(wd->last_selected_item);
+   else next = elm_genlist_item_next_get(wd->last_selected_item);
 
    if (!next) return EINA_FALSE;
 
    _deselect_all_items(wd);
 
-   elm_gen_item_selected_set(next, EINA_TRUE);
+   elm_genlist_item_selected_set(next, EINA_TRUE);
    elm_genlist_item_show(next);
    return EINA_TRUE;
 }
@@ -544,7 +544,7 @@
 {
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
-   elm_gen_clear(obj);
+   elm_genlist_clear(obj);
    evas_object_del(wd->pan_smart);
    wd->pan_smart = NULL;
 }
@@ -3703,7 +3703,7 @@
 EAPI void
 elm_genlist_clear(Evas_Object *obj)
 {
-   elm_gen_clear(obj);
+   elm_genlist_clear(obj);
 }
 
 EAPI void
@@ -3828,31 +3828,31 @@
 EAPI Elm_Gen_Item *
 elm_genlist_first_item_get(const Evas_Object *obj)
 {
-   return elm_gen_first_item_get(obj);
+   return elm_genlist_first_item_get(obj);
 }
 
 EAPI Elm_Gen_Item *
 elm_genlist_last_item_get(const Evas_Object *obj)
 {
-   return elm_gen_last_item_get(obj);
+   return elm_genlist_last_item_get(obj);
 }
 
 EAPI Elm_Gen_Item *
 elm_genlist_item_next_get(const Elm_Gen_Item *it)
 {
-   return elm_gen_item_next_get(it);
+   return elm_genlist_item_next_get(it);
 }
 
 EAPI Elm_Gen_Item *
 elm_genlist_item_prev_get(const Elm_Gen_Item *it)
 {
-   return elm_gen_item_prev_get(it);
+   return elm_genlist_item_prev_get(it);
 }
 
 EAPI Evas_Object *
 elm_genlist_item_genlist_get(const Elm_Gen_Item *it)
 {
-   return elm_gen_item_widget_get(it);
+   return elm_genlist_item_genlist_get(it);
 }
 
 EAPI Elm_Gen_Item *
@@ -3879,13 +3879,13 @@
 elm_genlist_item_selected_set(Elm_Gen_Item *it,
                               Eina_Bool         selected)
 {
-   elm_gen_item_selected_set(it, selected);
+   elm_genlist_item_selected_set(it, selected);
 }
 
 EAPI Eina_Bool
 elm_genlist_item_selected_get(const Elm_Gen_Item *it)
 {
-   return elm_gen_item_selected_get(it);
+   return elm_genlist_item_selected_get(it);
 }
 
 EAPI void
@@ -3937,7 +3937,7 @@
    if (it->delete_me) return;
    it->disabled = !!disabled;
    if (it->selected)
-     elm_gen_item_selected_set(it, EINA_FALSE);
+     elm_genlist_item_selected_set(it, EINA_FALSE);
    if (it->realized)
      {
         if (it->disabled)
@@ -4011,7 +4011,7 @@
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
    if (it->delete_me) return;
-   _item_move_before(it, elm_gen_first_item_get(WIDGET(it)));
+   _item_move_before(it, elm_genlist_first_item_get(WIDGET(it)));
 }
 
 EAPI void
@@ -4019,7 +4019,7 @@
 {
    ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
    if (it->delete_me) return;
-   _item_move_after(it, elm_gen_last_item_get(WIDGET(it)));
+   _item_move_after(it, elm_genlist_last_item_get(WIDGET(it)));
 }
 
 EAPI void
@@ -4488,26 +4488,26 @@
 elm_genlist_always_select_mode_set(Evas_Object *obj,
                                    Eina_Bool    always_select)
 {
-   elm_gen_always_select_mode_set(obj, always_select);
+   elm_genlist_always_select_mode_set(obj, always_select);
 }
 
 EAPI Eina_Bool
 elm_genlist_always_select_mode_get(const Evas_Object *obj)
 {
-   return elm_gen_always_select_mode_get(obj);
+   return elm_genlist_always_select_mode_get(obj);
 }
 
 EAPI void
 elm_genlist_no_select_mode_set(Evas_Object *obj,
                                Eina_Bool    no_select)
 {
-   elm_gen_no_select_mode_set(obj, no_select);
+   elm_genlist_no_select_mode_set(obj, no_select);
 }
 
 EAPI Eina_Bool
 elm_genlist_no_select_mode_get(const Evas_Object *obj)
 {
-   return elm_gen_no_select_mode_get(obj);
+   return elm_genlist_no_select_mode_get(obj);
 }
 
 EAPI void
@@ -4559,7 +4559,7 @@
                        Eina_Bool    h_bounce,
                        Eina_Bool    v_bounce)
 {
-   elm_gen_bounce_set(obj, h_bounce, v_bounce);
+   elm_genlist_bounce_set(obj, h_bounce, v_bounce);
 }
 
 EAPI void
@@ -4567,7 +4567,7 @@
                        Eina_Bool         *h_bounce,
                        Eina_Bool         *v_bounce)
 {
-   elm_gen_bounce_get(obj, h_bounce, v_bounce);
+   elm_genlist_bounce_get(obj, h_bounce, v_bounce);
 }
 
 EAPI void
@@ -4696,13 +4696,13 @@
      {
         EINA_LIST_FOREACH(wd->selected, l, it2)
           if (it2->realized)
-            elm_gen_item_selected_set(it2, EINA_FALSE);
+            elm_genlist_item_selected_set(it2, EINA_FALSE);
      }
    else
      {
         it2 = elm_genlist_selected_item_get(wd->obj);
         if ((it2) && (it2->realized))
-          elm_gen_item_selected_set(it2, EINA_FALSE);
+          elm_genlist_item_selected_set(it2, EINA_FALSE);
      }
 
    if (((wd->mode_type) && (strcmp(mode_type, wd->mode_type))) ||

Modified: trunk/elementary/src/lib/elm_store.c
===================================================================
--- trunk/elementary/src/lib/elm_store.c	2011-11-30 00:16:36 UTC (rev 65699)
+++ trunk/elementary/src/lib/elm_store.c	2011-11-30 00:59:19 UTC (rev 65700)
@@ -561,7 +561,7 @@
         evas_object_event_callback_del_full(st->genlist, EVAS_CALLBACK_DEL, _store_genlist_del, st);
         evas_object_smart_callback_del(st->genlist, "realized", _store_genlist_item_realized);
         evas_object_smart_callback_del(st->genlist, "unrealized", _store_genlist_item_unrealized);
-        elm_gen_clear(st->genlist);
+        elm_genlist_clear(st->genlist);
         st->genlist = NULL;
      }
    if (st->free) st->free(st);
@@ -578,14 +578,14 @@
         evas_object_event_callback_del_full(st->genlist, EVAS_CALLBACK_DEL, _store_genlist_del, st);
         evas_object_smart_callback_del(st->genlist, "realized", _store_genlist_item_realized);
         evas_object_smart_callback_del(st->genlist, "unrealized", _store_genlist_item_unrealized);
-        elm_gen_clear(st->genlist);
+        elm_genlist_clear(st->genlist);
      }
    st->genlist = obj;
    if (!st->genlist) return;
    evas_object_smart_callback_add(st->genlist, "realized", _store_genlist_item_realized, st);
    evas_object_smart_callback_add(st->genlist, "unrealized", _store_genlist_item_unrealized, st);
    evas_object_event_callback_add(st->genlist, EVAS_CALLBACK_DEL, _store_genlist_del, st);
-   elm_gen_clear(st->genlist);
+   elm_genlist_clear(st->genlist);
 }
 
 EAPI void

Log:
elm map: Add error handling to see the definite error log because
  sometimes evas_object_image_file_set() is failed. Patch by Bluezery
  <ohpowel@...>
  

Author:       seoz
Date:         2011-11-29 21:00:56 -0800 (Tue, 29 Nov 2011)
New Revision: 65707
Trac:         http://trac.enlightenment.org/e/changeset/65707

Modified:
  trunk/elementary/src/lib/elm_map.c 

Modified: trunk/elementary/src/lib/elm_map.c
===================================================================
--- trunk/elementary/src/lib/elm_map.c	2011-11-30 04:54:52 UTC (rev 65706)
+++ trunk/elementary/src/lib/elm_map.c	2011-11-30 05:00:56 UTC (rev 65707)
@@ -1187,21 +1187,21 @@
    gi->want = EINA_FALSE;
    gi->download = EINA_FALSE;
    evas_object_image_file_set(gi->img, gi->file, NULL);
-   if (evas_object_image_load_error_get(gi->img) != EVAS_LOAD_ERROR_NONE)
+   Evas_Load_Error err = evas_object_image_load_error_get(gi->img);
+   if (err != EVAS_LOAD_ERROR_NONE)
      {
-        ERR("Image loading error (%s)", gi->file);
+        ERR("Image loading error (%s): %s", gi->file, evas_load_error_str(err));
         ecore_file_remove(gi->file);
         gi->have = EINA_FALSE;
-        return;
      }
-
-   obj_rotate_zoom(gi->wd->obj, gi->img);
-   evas_object_show(gi->img);
-
-   //evas_object_text_text_set(gi->txt, gi->file);
-   //evas_object_show(gi->txt);
-
-   gi->have = EINA_TRUE;
+   else
+     {
+        obj_rotate_zoom(gi->wd->obj, gi->img);
+        evas_object_show(gi->img);
+        gi->have = EINA_TRUE;
+        //evas_object