Many good points and questions.
Personally, I would prefer SelectAll over Select(-1). Is it necessary? I
would say yes. Is it bloating out the module? I would say no - bloating can
become a major headache in some projects, but I would say we're a long way
from that happening.
Like you, I wouldn't be too confident in submitting anything via CVS. The
couple of minor things that have gone in where committed by Laurent and I
guess he would have looked at the code to see if it was "up to standard". So
in terms of peer review, I guess it comes down to whether Aldo, Laurent and
Steve are prepared to have a quick glance over the code before committing.
With Steve working through the request list, I would say using the
sourceforge tracker would be good place to add any generic suggestions. In
the cases where you have added new functionality, I guess the approach would
be to post a message to the lists and see what reaction there is?
----- Original Message -----
From: "Glenn W Munroe" <gwm@...>
Cc: <jez@...>; <Joe.Frazier@...>
Sent: Thursday, January 15, 2004 9:52 PM
Subject: [perl-win32-gui-users] (no subject)
> I've been doing a lot of work with listviews recently. I was pretty sure
> I'd identified a bug with the Select method, but can't reproduce it any
> more. While looking at that I added some functionality to my own copy of
> Listview.xs: Select(-1) to select all items in the list and an
> additional Deselect() method (for use when the list is in multiselect
> mode). The problem of adding functionality to an existing method is that
> you run the risk of breaking somebody else's code and the problem of
> adding methods is, as Jez White suggested, you bloat the module with
> "selfish" code (by the way, Jez, I fully agree with your comments and
> also with Joe's reminder of the importance of documentation).
> In my opinion, some kind of peer review would be useful before changing
> too much (for example, would a Selectall() method be preferable to the
> Select(-1) form--and is the new functionality really necessary at all?)
> Perhaps the active developers already do this? And what about additions
> from minor developers, such as me? I don't have write access to the CVS
> repository (and really don't feel confident enough to submit any code
> without such a peer review anyway). How is a good way to make
> suggestions like this? Through Tracker/Feature Request perhaps?
> Glenn 2
> The SF.Net email is sponsored by EclipseCon 2004
> Premiere Conference on Open Tools Development and Integration
> See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
> Perl-Win32-GUI-Users mailing list