Hi Lieven,
Thanks. Your instructions worked for me, and I think I might even understand them.
ALL:
How are other people finding the new Insteon code?
In the old code my "hops left" were always(?) 2. Now I see a mixture of 2's and 0's.
I have a few of these: "BUG! set_by loop detected with these objects: $Stairs_Light_KP_1, $Hall_Upstairs_KP_1"
and one of these: "WARN: deviceid of active message != received message source ($Bedroom_Lamp). IGNORING received message!!"
Is this codebase so much more "robust" it properly detects errors, or are these the result of bugs?
Regards,
Tom M.
On 2012-11-14, at 9:34 AM, Lieven Hollevoet <lieven@...> wrote:
> Hi Tom,
>
> maybe the sequence of instructions I sent you was misleading. The
>
>>> You might want to do a 'git pull upstream insteon' here as your fork is not up to date with the upstream repo.
>
> was not meant to be executed in-line with the other commands. If you want to pull the changes from insteon you first need to go for a 'git checkout insteon'. Sorry for the confusion, I focussed on (and tested) only the instructions that will get you to a branch containing the changes in merge_branch_phase1.
>
> So basically just execute the commands like this:
>
>>> git clone git@...
>>> cd misterhouse
>>> git remote add upstream git://github.com/hollie/misterhouse.git
>>> git fetch upstream
>>> git checkout -b branch_merge_phase1 upstream/branch_merge_phase1
>
>
> This should cause you to have an exact copy of the branch_merge_phase1 in the clone on your computer to test further on.
>
>> Thanks (and sorry for all the questions),
>
> No problem, I'm glad you're open to experimenting with git :-)
>
> Kind regards,
> Lieven.
>
>
> Op 14-nov.-2012, om 15:22 heeft Thomas MacLean <tmaclean@...> het volgende geschreven:
>
>> Hi Lieven,
>>
>> Thanks for your advice. I;m still getting stuck. I started from a clean clone of my fork, as you suggested. I also did the "git pull upstream insteon", but there I ran into trouble:
>>
>> tmaclean@... trunk]$ git remote add upstream git://github.com/hollie/misterhouse.git
>> [tmaclean@... trunk]$ git fetch upstream
>> tmaclean@... trunk]$ git pull upstream insteon
>>> From git://github.com/hollie/misterhouse
>> * branch insteon -> FETCH_HEAD
>> Auto-merging bin/mh
>> Auto-merging bin/mh.ini
>> Removing code/common/insteon_item_commands.pl
>> Auto-merging lib/Generic_Item.pm
>> Removing lib/Insteon_Device.pm
>> Removing lib/Insteon_Link.pm
>> Auto-merging lib/xPL_Items.pm
>> CONFLICT (content): Merge conflict in lib/xPL_Items.pm
>> Auto-merging web/bin/items.pl
>> CONFLICT (content): Merge conflict in web/bin/items.pl
>> Automatic merge failed; fix conflicts and then commit the result.
>>
>> Do I really want to pull your Insteon into my master?
>> How do I fix failed merges?
>>
>> Thanks (and sorry for all the questions),
>> Tom M.
>>
>>
>> On 2012-11-14, at 4:57 AM, Lieven Hollevoet <lieven@...> wrote:
>>
>>> Hello Tom,
>>>
>>> sure. So, what you basically did if I follow the flow of the commands you listed:
>>>
>>>> git remote add original https://github.com/hollie/misterhouse.git
>>>
>>> 1) you added a link to my repo, which is ok
>>>> git pull original master
>>>
>>> 2) you get all the changes from my master branch and merge them into your local master (-> this is what 'pull' does. pull=fetch+merge)
>>>> git push origin master
>>>
>>> 3) you published the changes applied in step 2 to your remote fork.
>>>
>>> Up to here all is fine.
>>>
>>>> One bad route is: git pull original branch_merge_phase1 .. this pulled your branch into my master. It complained about a bad merge for xPL_Items.pm.
>>>> I think I'd rather have branch that matches yours, no?
>>>
>>> But the next command is indeed not the way to go as you noticed. Basically what you did with the command is: you ask git to take my proposed new version of the insteon branch (=insteon+ all changes that were made to master since the branch between master and insteon) and you asked to to merge it into your master branch.
>>>
>>> If you followed the insteon/master merge thread you noticed I proposed to first bring insteon up to date with master (phase1) and only in a second stage we could then apply the up-to-date insteon back into master (phase2). I do indeed expect some conflicts to occur there, and I'm willing to take a shot at merging, but I would first like that more people test out the modified insteon branch.
>>>
>>> Sorry for all this text, but I'm trying to give you the context so that you see why the operation you tried to do did not work out as you expected.
>>>
>>> Now the cool thing with git is that I can try exactly the same commands as you are going to execute them on your pc, so I can duplicate your working environment to help you further.
>>>
>>> There are two ways to go: you can make a new clone and start from there, or you can fix the current clone you have (the one that has the merge changes in it).
>>>
>>> I'll explain the first way to go (so starting from scratch) as this will also help other mailing list members if they want to get the 'phase1' branch on their computer.
>>>
>>> 1) get a clone of your fork
>>> git clone git@...
>>> cd misterhouse
>>>
>>> Note 1: On my computer I use the read-only access link to your repo of course (git://github.com/tmaclean/misterhouse.git)
>>> Note 2: people who only want to try out the new insteon branch, there is an easy way just for testing that is descibed below *)
>>>
>>> 2) add the link to the upstream repo where you want to fetch changes from
>>> git remote add upstream git://github.com/hollie/misterhouse.git
>>>
>>> 3) get all changes from upstream but do not merge them
>>> git fetch upstream
>>>
>>> You might want to do a 'git pull upstream insteon' here as your fork is not up to date with the upstream repo.
>>>
>>> 4) now create the branch you want to create in your local clone:
>>> git checkout -b branch_merge_phase1 upstream/branch_merge_phase1
>>>
>>> Optionally commit it to your remote fork if you're happy with the results.
>>> git push origin branch_merge_phase1
>>>
>>> There are some steps, but they are only required because you have your fork and you want to keep it up to date.
>>>
>>>
>>>
>>> *) For people who just want to test out the new inteon branch merged with master changes, you only need to execute 2 commands:
>>>
>>> 1) git clone git://github.com/hollie/misterhouse.git misterhouse_testbranch
>>> 2) git checkout -b test_phase1 origin/branch_merge_phase1
>>>
>>> I hope this helps you further.
>>>
>>>
>>> As a question to all: when will we decide branch_merge_phase1 has been tested enough to go for an actual merge with insteon? I would like to do this first before spending time in merging the updated insteon with master.
>>>
>>>
>>> Kind regards,
>>> Lieven.
>>>
>>>
>>> Op 14-nov.-2012, om 04:19 heeft Thomas MacLean <tmaclean@...> het volgende geschreven:
>>>
>>>> Hi Lieven,
>>>>
>>>> not to confuse the matter too much , but... can you explain how I should pull your "branch_merge_phase1" from your repo into my fork?
>>>>
>>>> I had managed to re-synch up with:
>>>>
>>>>
>>>> but then I got a bit lost trying to get your branch into my fork.
>>>>
>>>>
>>>> Thanks for any guidance.
>>>>
>>>> Regards,
>>>> Tom
>>>>
>>>>
>>>> On 2012-11-07, at 4:20 PM, Lieven Hollevoet <lieven@...> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I just commited a branch that starts from insteon and that contains all changes of the master that were not in insteon.
>>>>>
>>>>> https://github.com/hollie/misterhouse/pull/12
>>>>>
>>>>> I had to merge 2 files manually. I did not try to run the code. Can an insteon developer test it please?
>>>>>
>>>>> git clone git@...
>>>>> cd misterhouse
>>>>> git checkout -b branch_merge_phase1 origin/branch_merge_phase1
>>>>>
>>>>> test and report back please
>>>>>
>>>>> If things don't work out and you can provide fixed then you need to go around your own fork so that you can create a pull request to me.
>>>>>
>>>>> Hope this branch works without big problems, then the merging operation is almost complete.
>>>>>
>>>>> I'm signing off for today, so I won't be able to follow-up on this until tomorrow evening-ish.
>>>>>
>>>>> Kind regards,
>>>>> Lieven.
>>>>>
>>>>> Op 7-nov.-2012, om 16:05 heeft Eloy Paris <peloy@...> het volgende geschreven:
>>>>>
>>>>>> On 11/07/2012 09:35 AM, Marc MERLIN wrote:
>>>>>>
>>>>>> [...]
>>>>>>
>>>>>>> Considering that we have svn left behind now, I actually think that it
>>>>>>> would be ok to collapse the two branches and make the new insteon code the
>>>>>>> master code.
>>>>>>
>>>>>> I would agree with this.
>>>>>>
>>>>>>> If it somehow breaks someone, they're not dead in the water because they can
>>>>>>> still fall back to the old code in svn, report the problem, and hopefully
>>>>>>> someone can help fix this in the new code.
>>>>>>>
>>>>>>> So while I can't call myself the backup insteon maintainer, I think it's
>>>>>>> time to fold both branches at least in git since the possible problems
>>>>>>> this might cause are likely far outweighed by the cost of those 2 branches.
>>>>>>
>>>>>> Yes.
>>>>>>
>>>>>> Also, exposing the INSTEON stack in the insteon branch to a wider
>>>>>> audience will hopefully help to iron out bugs and issues.
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Eloy Paris.-
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> LogMeIn Central: Instant, anywhere, Remote PC access and management.
>>>>>> Stay in control, update software, and manage PCs from one command center
>>>>>> Diagnose problems and improve visibility into emerging IT issues
>>>>>> Automate, monitor and manage. Do more in less time with Central
>>>>>> http://p.sf.net/sfu/logmein12331_d2d
>>>>>> ________________________________________________________
>>>>>> To unsubscribe from this list, go to: http://sourceforge.net/mail/?group_id=1365
>>>>>>
>>>>>
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> LogMeIn Central: Instant, anywhere, Remote PC access and management.
>>>>> Stay in control, update software, and manage PCs from one command center
>>>>> Diagnose problems and improve visibility into emerging IT issues
>>>>> Automate, monitor and manage. Do more in less time with Central
>>>>> http://p.sf.net/sfu/logmein12331_d2d
>>>>> ________________________________________________________
>>>>> To unsubscribe from this list, go to: http://sourceforge.net/mail/?group_id=1365
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Monitor your physical, virtual and cloud infrastructure from a single
>>>> web console. Get in-depth insight into apps, servers, databases, vmware,
>>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>>> Pricing starts from $795 for 25 servers or applications!
>>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>>> ________________________________________________________
>>>> To unsubscribe from this list, go to: http://sourceforge.net/mail/?group_id=1365
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Monitor your physical, virtual and cloud infrastructure from a single
>>> web console. Get in-depth insight into apps, servers, databases, vmware,
>>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>>> Pricing starts from $795 for 25 servers or applications!
>>> http://p.sf.net/sfu/zoho_dev2dev_nov
>>> ________________________________________________________
>>> To unsubscribe from this list, go to: http://sourceforge.net/mail/?group_id=1365
>>
>>
>> ------------------------------------------------------------------------------
>> Monitor your physical, virtual and cloud infrastructure from a single
>> web console. Get in-depth insight into apps, servers, databases, vmware,
>> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
>> Pricing starts from $795 for 25 servers or applications!
>> http://p.sf.net/sfu/zoho_dev2dev_nov
>> ________________________________________________________
>> To unsubscribe from this list, go to: http://sourceforge.net/mail/?group_id=1365
>>
>
>
> ------------------------------------------------------------------------------
> Monitor your physical, virtual and cloud infrastructure from a single
> web console. Get in-depth insight into apps, servers, databases, vmware,
> SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> Pricing starts from $795 for 25 servers or applications!
> http://p.sf.net/sfu/zoho_dev2dev_nov
> ________________________________________________________
> To unsubscribe from this list, go to: http://sourceforge.net/mail/?group_id=1365
|