| From Rob Sykes <aquegg@...>
| Sat, 3 Nov 2012 14:58:49 +0000 (GMT)
| Subject: [Audacity-devel] libsoxr/r12026
> ----- Original Message -----
> > From: Vaughan Johnson <vaughan@...>
> > To: audacity-quality <audacity-quality@...>; Rob Sykes <aquegg@...>; Audacity Developers List <audacity-devel@...>
> > Cc:
> > Sent: Saturday, 3 November 2012, 2:51
> > Subject: libsoxr/r12026
> > I think that not everybody on the libsoxr audacity-devel thread is on
> > the svn list, so here are my comments on r12026:
> > "This commit is partial effort toward more libsoxr integration, that
> > implements Rob Sykes's latest patch. I have no idea whether the
> > Linux-specific stuff from the patch (e.g., M4 file) is still correct in
> > this.
> I ran into a couple of compilation errors with this revision which I fixed as follows:
> Index: src/Resample.h
> --- src/Resample.h (revision 12026)
> +++ src/Resample.h (working copy)
> @@ -15,6 +15,7 @@
> #include "Audacity.h"
> #include <wx/string.h>
> +#include <wx/intl.h>
> #include "Prefs.h"
> #include "SampleFormat.h"
> Index: src/Resample.cpp
> --- src/Resample.cpp (revision 12026)
> +++ src/Resample.cpp (working copy)
> @@ -64,9 +64,8 @@
> - delete mHandle;
> - mHandle = NULL;
> + mHandle = NULL;
> //v Currently unused.
On Windows Unicode Release, I got:
c:\audacity svn\src\Resample.h(50) : error C3861: '_': identifier not
for which Rob's change to src/Resample.h (adding #include <wx/intl.h>
at the top) was sufficient to compile and link without error.
> For libsoxr, the current m4 stuff still seems okay; I have a small patch waiting in the wings to allow libsoxr to also be found as a system-lib (in anticipation of that happening in the near future). For the var-rate stuff, I think the patch I posted previously (http://dl.dropbox.com/u/8835547/m4-patch) will still be needed (perhaps with a couple of additional words to clarify the scope of the configurations as being either for const- or var-rate).
> I also have a minor patch to libsoxr standing by, to support the "distclean" target on unix.