DSpace

[ https://jira.duraspace.org/browse/DS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Van de Velde reassigned DS-1248:
--------------------------------------

    Assignee: Kevin Van de Velde
    
> Remove unused SolrLogger code for unsupported "metadata.item." settings
> -----------------------------------------------------------------------
>
>                 Key: DS-1248
>                 URL: https://jira.duraspace.org/browse/DS-1248
>             Project: DSpace
>          Issue Type: Bug
>          Components: Solr
>    Affects Versions: 1.8.2
>            Reporter: Peter Dietz
>            Assignee: Kevin Van de Velde
>             Fix For: 3.0
>
>
> This is related to DS-421 and is based on comments there from Peter Dietz:
> While looking through SolrLogger, I've noticed that the code to support stuffing metadata into Solr stats is still possible.
> https://github.com/DSpace/DSpace/blob/deb732e3cb2f36325cfda8aa28989695bfbd4cab/dspace-stats/src/main/java/org/dspace/statistics/SolrLogger.java#L137
> Even though its been removed from dspace.cfg.
> I would recommend removing all traces of metadataStorageInfo, IDEA says this would affect a number of files. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Van de Velde updated DS-1248:
-----------------------------------

    Status: Open  (was: Received)
    
> Remove unused SolrLogger code for unsupported "metadata.item." settings
> -----------------------------------------------------------------------
>
>                 Key: DS-1248
>                 URL: https://jira.duraspace.org/browse/DS-1248
>             Project: DSpace
>          Issue Type: Bug
>          Components: Solr
>    Affects Versions: 1.8.2
>            Reporter: Peter Dietz
>            Assignee: Kevin Van de Velde
>             Fix For: 3.0
>
>
> This is related to DS-421 and is based on comments there from Peter Dietz:
> While looking through SolrLogger, I've noticed that the code to support stuffing metadata into Solr stats is still possible.
> https://github.com/DSpace/DSpace/blob/deb732e3cb2f36325cfda8aa28989695bfbd4cab/dspace-stats/src/main/java/org/dspace/statistics/SolrLogger.java#L137
> Even though its been removed from dspace.cfg.
> I would recommend removing all traces of metadataStorageInfo, IDEA says this would affect a number of files. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26657#comment-26657 ] 

Kevin Van de Velde commented on DS-1248:
----------------------------------------

Pull request: https://github.com/DSpace/DSpace/pull/111
                
> Remove unused SolrLogger code for unsupported "metadata.item." settings
> -----------------------------------------------------------------------
>
>                 Key: DS-1248
>                 URL: https://jira.duraspace.org/browse/DS-1248
>             Project: DSpace
>          Issue Type: Bug
>          Components: Solr
>    Affects Versions: 1.8.2
>            Reporter: Peter Dietz
>            Assignee: Kevin Van de Velde
>             Fix For: 3.0
>
>
> This is related to DS-421 and is based on comments there from Peter Dietz:
> While looking through SolrLogger, I've noticed that the code to support stuffing metadata into Solr stats is still possible.
> https://github.com/DSpace/DSpace/blob/deb732e3cb2f36325cfda8aa28989695bfbd4cab/dspace-stats/src/main/java/org/dspace/statistics/SolrLogger.java#L137
> Even though its been removed from dspace.cfg.
> I would recommend removing all traces of metadataStorageInfo, IDEA says this would affect a number of files. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Van de Velde resolved DS-1248.
------------------------------------

    Resolution: Fixed

Pull request merged.
                
> Remove unused SolrLogger code for unsupported "metadata.item." settings
> -----------------------------------------------------------------------
>
>                 Key: DS-1248
>                 URL: https://jira.duraspace.org/browse/DS-1248
>             Project: DSpace
>          Issue Type: Bug
>          Components: Solr
>    Affects Versions: 1.8.2
>            Reporter: Peter Dietz
>            Assignee: Kevin Van de Velde
>             Fix For: 3.0
>
>
> This is related to DS-421 and is based on comments there from Peter Dietz:
> While looking through SolrLogger, I've noticed that the code to support stuffing metadata into Solr stats is still possible.
> https://github.com/DSpace/DSpace/blob/deb732e3cb2f36325cfda8aa28989695bfbd4cab/dspace-stats/src/main/java/org/dspace/statistics/SolrLogger.java#L137
> Even though its been removed from dspace.cfg.
> I would recommend removing all traces of metadataStorageInfo, IDEA says this would affect a number of files. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira