DSpace

<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#ffffff" style="background-color:#ffffff;color:#2e6174;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://testdrive.fedora-commons.org/images/logo.jpg" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://jira.duraspace.org/secure/useravatar?avatarId=10192" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="mdiggory" id="email_mdiggory" href="https://jira.duraspace.org/secure/ViewProfile.jspa?name=mdiggory" style="color:#326ca6;">Mark Diggory</a>
     commented on <img src="https://jira.duraspace.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://jira.duraspace.org/browse/DS-1182'>DS-1182</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style='color:#326ca6;text-decoration:none;' href='https://jira.duraspace.org/browse/DS-1182'><strong>Javamail: Getting Session object with getDefaultInstace</strong></a>
            </div>
                    </td>
    </tr>
</table>
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                        <tr valign="top">
    <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
        <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">This is an important issue that may limit the execution of more than one DSpace instance in a tomcat JVM, it seems sound and I think we could simply shift to use Session.getInstance in a static block of the Email.java class.
<br/>

<br/>
Likewise, a Singelton approach is exactly the strategy that the current architectural direction would go in if the ServiceManager were utilized as the mechanism to support EmailServices instead of the ConfigurationManager.getEMail(&quot;string&quot;) implementation.
<br/>

<br/>
In targeting architectural changes to support use of Services, the ConfigurationManager.getEMail(&quot;string&quot;) and portions of the Email.java internal code should be migrated to be a Service (EmailService) that the application maintainer can easily override with their own implementation.  The static methods that exist in the Manager would be retained in the code as convenience methods and reduce the need to migrate all usage at once.
<br/>

<br/>
Mark</div>
        <div style="color:#505050;padding:4px 0 0 0;">                </div>
    </td>
</tr>
                    </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your <a style='color:#326ca6;' href='https://jira.duraspace.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
            For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->

<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#ffffff" style="background-color:#ffffff;color:#2e6174;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://testdrive.fedora-commons.org/images/logo.jpg" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://jira.duraspace.org/secure/useravatar?ownerId=mwood&avatarId=10570" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="mwood" id="email_mwood" href="https://jira.duraspace.org/secure/ViewProfile.jspa?name=mwood" style="color:#326ca6;">Mark H. Wood</a>
     commented on <img src="https://jira.duraspace.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://jira.duraspace.org/browse/DS-1182'>DS-1182</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style='color:#326ca6;text-decoration:none;' href='https://jira.duraspace.org/browse/DS-1182'><strong>Javamail: Getting Session object with getDefaultInstace</strong></a>
            </div>
                    </td>
    </tr>
</table>
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                        <tr valign="top">
    <td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
        <div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;">Also, this is another external service connection that can be pushed out of DSpace altogether by getting the container to provide it out of JNDI.
<br/>

<br/>
Good catch!</div>
        <div style="color:#505050;padding:4px 0 0 0;">                </div>
    </td>
</tr>
                    </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your <a style='color:#326ca6;' href='https://jira.duraspace.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
            For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->

<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#ffffff" style="background-color:#ffffff;color:#2e6174;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://testdrive.fedora-commons.org/images/logo.jpg" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://jira.duraspace.org/secure/useravatar?avatarId=10192" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="tdonohue" id="email_tdonohue" href="https://jira.duraspace.org/secure/ViewProfile.jspa?name=tdonohue" style="color:#326ca6;">Tim Donohue</a>
     updated <img src="https://jira.duraspace.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://jira.duraspace.org/browse/DS-1182'>DS-1182</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style='color:#326ca6;text-decoration:none;' href='https://jira.duraspace.org/browse/DS-1182'><strong>Javamail: Getting Session object with getDefaultInstace</strong></a>
            </div>
                    </td>
    </tr>
</table>
        
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                                                    <tr valign="top">
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
            <strong style="font-weight:normal;color:#505050;">Change By:</strong>
        </td>
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                                <a class="user-hover" rel="tdonohue" id="email_tdonohue" href="https://jira.duraspace.org/secure/ViewProfile.jspa?name=tdonohue" style="color:#326ca6;">Tim Donohue</a>
                            (31/May/12 4:33 PM)
        </td>
    </tr>
            <tr valign="top">
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
            <strong style="font-weight:normal;color:#505050;">Status:</strong>
        </td>
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                    <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Received</span>
<span class="diffaddedchars" style="background-color:#ddfade;">Open</span>

        </td>
    </tr>
                            </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your <a style='color:#326ca6;' href='https://jira.duraspace.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
            For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->

<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#ffffff" style="background-color:#ffffff;color:#2e6174;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="http://testdrive.fedora-commons.org/images/logo.jpg" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://jira.duraspace.org/secure/useravatar?avatarId=10192" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="tdonohue" id="email_tdonohue" href="https://jira.duraspace.org/secure/ViewProfile.jspa?name=tdonohue" style="color:#326ca6;">Tim Donohue</a>
     updated <img src="https://jira.duraspace.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://jira.duraspace.org/browse/DS-1182'>DS-1182</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style='color:#326ca6;text-decoration:none;' href='https://jira.duraspace.org/browse/DS-1182'><strong>Javamail: Getting Session object with getDefaultInstace</strong></a>
            </div>
                    </td>
    </tr>
</table>
        
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                                                    <tr valign="top">
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
            <strong style="font-weight:normal;color:#505050;">Change By:</strong>
        </td>
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                                <a class="user-hover" rel="tdonohue" id="email_tdonohue" href="https://jira.duraspace.org/secure/ViewProfile.jspa?name=tdonohue" style="color:#326ca6;">Tim Donohue</a>
                            (31/May/12 4:43 PM)
        </td>
    </tr>
            <tr valign="top">
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
            <strong style="font-weight:normal;color:#505050;">Fix Version/s:</strong>
        </td>
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                    <span class="diffaddedchars" style="background-color:#ddfade;">3.0</span>

        </td>
    </tr>
                            </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your <a style='color:#326ca6;' href='https://jira.duraspace.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
            For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark H. Wood reassigned DS-1182:
--------------------------------

    Assignee: Mark H. Wood
    
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26260#comment-26260 ] 

Ivan Masár commented on DS-1182:
--------------------------------

So what's the verdict on this? Fix by using Session.getInstance() in 3.0 and move to services for 4.0?
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26267#comment-26267 ] 

Mark H. Wood commented on DS-1182:
----------------------------------

It looks like dspace-services will merge into DSpace, which means a couple of pulls can draw this in without release-coordination issues (other than:  is the code good enough for the next DSpace relese?)
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26274#comment-26274 ] 

João Melo commented on DS-1182:
-------------------------------

Hi Mark,

could you correct me if i am wrong. This is your proposal: https://github.com/mwoodiupui/DSpace/tree/DS-1182
Could you merge your pull (https://github.com/DSpace/dspace-services/pull/6) into it and pull for the change? It would be better to analyse it.

Anyway, i was diving into your code, it seems just fine, if you have a pull i would be available to test it and give some feedback.

Useful links:

Pull request (DSpace Services): https://github.com/DSpace/dspace-services/pull/6
Merge (DSpace Services -> DSpace): https://github.com/DSpace/DSpace/commit/0db0fea762799b40376965e0d13d89b81b9f7bfe
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26283#comment-26283 ] 

Mark H. Wood commented on DS-1182:
----------------------------------

I've started a new branch containing just a minimal bug-fix, that can go into DSpace 3.0 if the RT accepts it.  I consider this an interim step, and still plan to submit EmailService (and changes to use it) for 4.0.  Meanwhile, see https://github.com/DSpace/DSpace/pull/83
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26374#comment-26374 ] 

Ivan Masár commented on DS-1182:
--------------------------------

Do we close this and open a new ticket for 4.0 or leave it open?
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark H. Wood resolved DS-1182.
------------------------------

    Resolution: Fixed
    
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26675#comment-26675 ] 

DSpace @ Lyncode commented on DS-1182:
--------------------------------------

Hi Ivan, i'd propose to leave it open, mainly because this only happens in a very specific scenario. My opinion is that Mark's solution solves the problem, but  it would be better to wait for a confirmation from the community in order to close the ticket. At least, i think i could get some feedback from FCCN (from Portugal) which is currently facing this problem.
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Masár reopened DS-1182:
----------------------------


Per Joao's wish, reopening so that we keep it on the radar at least until 3.0 release.
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26679#comment-26679 ] 

Mark H. Wood commented on DS-1182:
----------------------------------

Hmmm, that's why I left it Resolved, not Closed, after about three weeks in tree with no negative comment.
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark H. Wood updated DS-1182:
-----------------------------

    Documentation Status: Not Required  (was: Needed)
    
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26680#comment-26680 ] 

Ivan Masár commented on DS-1182:
--------------------------------

Well, it was closed with the "resolved" status. That means it won't show up in the list of open bugs, so it goes under the radar. I don't mean to imply that it isn't fixed. I'll leave it up to you, Mark, sorry for interfering.
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.duraspace.org/browse/DS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Donohue resolved DS-1182.
-----------------------------

    Resolution: Fixed

I'm marking this as "resolved" as we have committed a fix.  "Resolved" essentially means that we believe it's fixed, but we encourage others to test it out to be sure (and it will be getting some Testathon testing)

Others are still more than welcome to test it out and verify. If it doesn't work, please let us know so that we can re-open. 
                
> Javamail: Getting Session object with getDefaultInstace
> -------------------------------------------------------
>
>                 Key: DS-1182
>                 URL: https://jira.duraspace.org/browse/DS-1182
>             Project: DSpace
>          Issue Type: Bug
>          Components: DSpace API, JSPUI
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2
>         Environment: Unix
>            Reporter: João Melo
>            Assignee: Mark H. Wood
>            Priority: Critical
>              Labels: Email, Javamail, SecurityException, Tomcat
>             Fix For: 3.0
>
>
> Context
> - Tomcat 6 with multiple hosts with one application per host (DSpace is one of them).
> - Local SMTP server with no Authentication required
> Problem
> As the Javamail API documentation[1] states, the method getDefaultInstance() - used in DSpace - returns an object shared among the JVM context. If, for some reason, another application (not DSpace) in tomcat refreshes the Authenticator instance within the default session, DSpace will start getting errors when trying to send emails (throwing SecurityException).
> Solution
> - A simple solution to this problem would be replacing all Session.getDefaultInstance() calls by Session.getInstance().
> - Another (more efficient) solution would be defining a singleton, calling the Session.getInstance using some wrapper that would replace all the Session.getDefaultInstance() calls.
> Resources
> [1] Javamail API getDefaultSession - http://javamail.kenai.com/nonav/javadocs/javax/mail/Session.html#getDefaultInstance(java.util.Properties)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira