Enlightenment

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------
Description changed by uartie:

Old description:

> This is a regression.  All app rendering is corrupted when using the
> wayland_shm engine (see [attachment:wayland_shm.corrupt-rendering.webm]).
> Also see [comment:4:ticket:1250] and
> [attachment:scrolling_wayland_shm.webm​​:ticket:1250]. The wayland_egl
> engine does not appear to be affected.
>
> ==== System ====
>
> || ecore || http://svn.enlightenment.org/svn/e/trunk/ecore 77199/77151 ||
> || edje || http://svn.enlightenment.org/svn/e/trunk/edje 77199/77174 ||
> || eet || http://svn.enlightenment.org/svn/e/trunk/eet 77199/77117 ||
> || eina || http://svn.enlightenment.org/svn/e/trunk/eina 77199/77113 ||
> || elementary || http://svn.enlightenment.org/svn/e/trunk/elementary
> 77199/77192 ||
> || embryo || http://svn.enlightenment.org/svn/e/trunk/embryo 77199/76491
> ||
> || emotion || http://svn.enlightenment.org/svn/e/trunk/emotion
> 77199/76438 ||
> || evas || http://svn.enlightenment.org/svn/e/trunk/evas 77199/77178 ||
> || wayland || (master) 56ea2e793b155c6476ff55d876bd6bb2c5170720 ||
> || weston || (master) 64b78fd65fab2dd13e058fa4c571a7879da7f060 ||
> || cairo || (master) 797441093a8346003552e0cf89aef2a644ff53ab ||
> || dri2proto || (master) 4eeacce4c4a300b938b7e3fb78a8e443c491780b ||
> || drm || (master) 2426a6a7112ae62755408a371831eddbe2d89d99 ||
> || glproto || (master) ec1eec4355ee4a6c5134f2178192f10b6d28a87a ||
> || kbproto || (master) 391a1f6de6315fc0196d407d800597488315cccb ||
> || libX11 || (master) d45b3fc19fbe95c41afc4e51d768df6d42332010 ||
> || libxkbcommon || (master) 92e07726b29d129d2ca793c3614353d35a1a6b40 ||
> || macros || (master) 0890e4003aacfa7113ab3f4e3ad7c5636f8e922a ||
> || mesa || (master) d239cb1ccfdf69ff587d5bc74c2174cf51c349b4 ||
> || pixman || (master) aff796d6cee4cb81f0352c2f7d0c994229bd5ca1 ||

New description:

 This is a regression.  All app rendering is corrupted when using the
 wayland_shm engine (see [attachment:wayland_shm.corrupt-rendering.webm]).
 Also see [comment:4:ticket:1250] and
 [attachment:scrolling_wayland_shm.webm​​:ticket:1250]. The wayland_egl
 engine does not appear to be affected.

 [[Image(wayland-screenshot.png,width=35%)]]

 ==== System ====

 || ecore || http://svn.enlightenment.org/svn/e/trunk/ecore 77199/77151 ||
 || edje || http://svn.enlightenment.org/svn/e/trunk/edje 77199/77174 ||
 || eet || http://svn.enlightenment.org/svn/e/trunk/eet 77199/77117 ||
 || eina || http://svn.enlightenment.org/svn/e/trunk/eina 77199/77113 ||
 || elementary || http://svn.enlightenment.org/svn/e/trunk/elementary
 77199/77192 ||
 || embryo || http://svn.enlightenment.org/svn/e/trunk/embryo 77199/76491
 ||
 || emotion || http://svn.enlightenment.org/svn/e/trunk/emotion 77199/76438
 ||
 || evas || http://svn.enlightenment.org/svn/e/trunk/evas 77199/77178 ||
 || wayland || (master) 56ea2e793b155c6476ff55d876bd6bb2c5170720 ||
 || weston || (master) 64b78fd65fab2dd13e058fa4c571a7879da7f060 ||
 || cairo || (master) 797441093a8346003552e0cf89aef2a644ff53ab ||
 || dri2proto || (master) 4eeacce4c4a300b938b7e3fb78a8e443c491780b ||
 || drm || (master) 2426a6a7112ae62755408a371831eddbe2d89d99 ||
 || glproto || (master) ec1eec4355ee4a6c5134f2178192f10b6d28a87a ||
 || kbproto || (master) 391a1f6de6315fc0196d407d800597488315cccb ||
 || libX11 || (master) d45b3fc19fbe95c41afc4e51d768df6d42332010 ||
 || libxkbcommon || (master) 92e07726b29d129d2ca793c3614353d35a1a6b40 ||
 || macros || (master) 0890e4003aacfa7113ab3f4e3ad7c5636f8e922a ||
 || mesa || (master) d239cb1ccfdf69ff587d5bc74c2174cf51c349b4 ||
 || pixman || (master) aff796d6cee4cb81f0352c2f7d0c994229bd5ca1 ||

--

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:1>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by etrunko):

 Gah, this can be my fault. Can you try this patch: http://fpaste.org/0ZFe/
 and see if it works?

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:2>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by etrunko):

 My tree is outdated, I tested with and without this patch and everything
 still works. I am updating to a recent version and to see what happens.

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:3>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by uartie):

 attached attachment:page_flip_test.c

 Also, note that the corruption can be seen when scrolling elementary_test
 (see #1250)

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:4>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by devilhorns):

 Ya know, there is a reason why I told Robert to have you send patches
 instead of direct commits :P Fix It !!!!

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:5>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by uartie):

 Replying to [comment:2 etrunko]:
 > Gah, this can be my fault. Can you try this patch:
 http://fpaste.org/oZ0L/ and see if it works?

 Unfortunately, this patch did *not* make a difference in the outcome :/

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:6>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by etrunko):

 Replying to [comment:5 devilhorns]:
 > Ya know, there is a reason why I told Robert to have you send patches
 instead of direct commits :P Fix It !!!!

 Not my fault :D. The patch I sent was basically a revert of my changes,
 which doesn't happen to interfere on the result. And as I told you, I
 always do lots of testing before commit.

 I was talking to uartie on IRC, I can't reproduce this behavior in my
 environment. Could it be something related to recent evas changes by
 raster? Any special configure options or enviroment variables being used?

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:7>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by devilhorns):

 Doubtful. Most of his stuff is wrt egl, not shm

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:8>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by devilhorns):

 I can't check it until Monday when I get in to work. If it's still broken
 then, let me know and I'll fix it

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:9>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by uartie):

 FWIW, the simple-shm weston client/demo renders properly.

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:10>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by jbkonno):

 FYI, the attached video stream documents the bug as seen in Weston-DRM.

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:11>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by rbradford):

 I don't believe this regression is tied to E* stack. It only appears when
 you run a sufficiently new mesa.

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:12>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by rbradford):

 The regression happened with an optimisation in Mesa:


 commit 413c4914129cd26ca87960852d8c0264c0fb29e7
 Author: Chad Versace <chad.versace@...>
 Date:   Tue Sep 4 12:15:29 2012 -0700

     intel: Improve teximage perf for Google Chrome paint rects (v3)

     This patch reduces the time spent in glTexImage and glTexSubImage by
     over 5x on Sandybridge for the workload described below.

     It adds a new fast path for glTexImage2D and glTexSubImage2D,
     intel_texsubimage_tiled_memcpy, which is optimized for Google Chrome's
     paint rectangles. The fast path is implemented only for 2D GL_BGRA
     textures for chipsets with a LLC.

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:13>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by uartie):

 Replying to [comment:13 rbradford]:
 > The regression happened with an optimisation in Mesa:
 >
 > {{{
 > commit 413c4914129cd26ca87960852d8c0264c0fb29e7
 > Author: Chad Versace <chad.versace@...>
 > Date:   Tue Sep 4 12:15:29 2012 -0700
 >
 >     intel: Improve teximage perf for Google Chrome paint rects (v3)
 >
 >     This patch reduces the time spent in glTexImage and glTexSubImage by
 >     over 5x on Sandybridge for the workload described below.
 >
 >     It adds a new fast path for glTexImage2D and glTexSubImage2D,
 >     intel_texsubimage_tiled_memcpy, which is optimized for Google
 Chrome's
 >     paint rectangles. The fast path is implemented only for 2D GL_BGRA
 >     textures for chipsets with a LLC.
 > }}}

 So do we know if E* will need to adapt to this change or is it just a bug
 that E* exposes that needs to be fixed in mesa itself?

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:14>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  new
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by rbradford):

 I think this is a Mesa or Weston bug. If you issue damage that covers the
 full surface (like simple-shm) then the drawing artefacts disappear.

 I was able to verify this by patching Ecore to damage the full surface
 area. I'll try and isolate if this is a Mesa issue or a Weston issue. It
 is not an EFL issue.

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:15>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  closed
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:  Invalid
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------
Changes (by rbradford):

 * status:  new => closed
 * resolution:   => Invalid


Comment:

 This is a > SandyBridge mesa bug that is due to an incorrect optimization
 being applied  to weston's use of glTexImage2D for updating a subregion of
 a texture.

 Closing as INVALID. You can track this bug in the Wayland bugzilla if you
 wish.

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:16>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project

#1577: [wayland_shm] Corrupted rendering on all apps (regression)
----------------------------------+-------------------------
 Reporter:  uartie                |       Owner:  devilhorns
     Type:  Bug                   |      Status:  closed
 Priority:  Blocker               |   Milestone:
Component:  evas                  |  Resolution:  Invalid
 Keywords:  wayland, wayland_shm  |  Blocked By:
 Blocking:  1250                  |
----------------------------------+-------------------------

Comment (by uartie):

 Mesa bug filed as fd.o [https://bugs.freedesktop.org/show_bug.cgi?id=55550
 #55550]

-- 
Ticket URL: <http://trac.enlightenment.org/e/ticket/1577#comment:17>
Enlightenment <http://www.enlightenment.org/>
Enlightenment Project