phpMyAdmin

Hi

Dne Tue, 1 May 2012 02:02:38 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> I'm identifying the refactoring points in 'display_tbl.lib.php' file. I am
> trying to break the tasks on following areas.
> 
> * As a library file this should not render the HTML codes in functions it
> selves. First, all the HTML content in functions stored in string and
> render at the bottom of the function.
> Next, return the string having the HTML content, instead of rendering it
> inside the function itself and, from the calling end render that content.
> Probably method names will be modified with adding 'get' phrase.
> 
> * Some naming conventions are used incorrectly. For method name in lib
> file, naming convention is used generally used as 'PMA_methodName'. But
> some are not following this.
> While correcting them, suggested conventions in my proposal [0] is going to
> applied.
> 
> * There are several functions having more than 200 lines. I'm intending to
> divide those functions to smaller ones. (PMA_displayTableNavigation(),
> PMA_displayTableHeaders(), PMA_displayTableBody(),
> PMA_displayVerticalTable(), PMA_displayTable())

I think all this should be rather wrapped in object, so it would be
PMA_Display::someFunction.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On Thu, May 3, 2012 at 4:38 PM, Michal Čihař <michal@...> wrote:

> Hi
>
> Dne Tue, 1 May 2012 02:02:38 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
> > I'm identifying the refactoring points in 'display_tbl.lib.php' file. I
> am
> > trying to break the tasks on following areas.
> >
> > * As a library file this should not render the HTML codes in functions it
> > selves. First, all the HTML content in functions stored in string and
> > render at the bottom of the function.
> > Next, return the string having the HTML content, instead of rendering it
> > inside the function itself and, from the calling end render that content.
> > Probably method names will be modified with adding 'get' phrase.
> >
> > * Some naming conventions are used incorrectly. For method name in lib
> > file, naming convention is used generally used as 'PMA_methodName'. But
> > some are not following this.
> > While correcting them, suggested conventions in my proposal [0] is going
> to
> > applied.
> >
> > * There are several functions having more than 200 lines. I'm intending
> to
> > divide those functions to smaller ones. (PMA_displayTableNavigation(),
> > PMA_displayTableHeaders(), PMA_displayTableBody(),
> > PMA_displayVerticalTable(), PMA_displayTable())
>
> I think all this should be rather wrapped in object, so it would be
> PMA_Display::someFunction.
>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Michal,

Thanks for your reply. I got the point Michal. After the mentioned tasks
plus making this as a class, I can use 'PMA_Display::someFunction' where
needed.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Sat, May 5, 2012 at 1:16 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Thu, May 3, 2012 at 4:38 PM, Michal Čihař <michal@...> wrote:
>
>> Hi
>>
>> Dne Tue, 1 May 2012 02:02:38 +0530
>> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>>
>> > I'm identifying the refactoring points in 'display_tbl.lib.php' file. I
>> am
>> > trying to break the tasks on following areas.
>> >
>> > * As a library file this should not render the HTML codes in functions
>> it
>> > selves. First, all the HTML content in functions stored in string and
>> > render at the bottom of the function.
>> > Next, return the string having the HTML content, instead of rendering it
>> > inside the function itself and, from the calling end render that
>> content.
>> > Probably method names will be modified with adding 'get' phrase.
>> >
>> > * Some naming conventions are used incorrectly. For method name in lib
>> > file, naming convention is used generally used as 'PMA_methodName'. But
>> > some are not following this.
>> > While correcting them, suggested conventions in my proposal [0] is
>> going to
>> > applied.
>> >
>> > * There are several functions having more than 200 lines. I'm intending
>> to
>> > divide those functions to smaller ones. (PMA_displayTableNavigation(),
>> > PMA_displayTableHeaders(), PMA_displayTableBody(),
>> > PMA_displayVerticalTable(), PMA_displayTable())
>>
>> I think all this should be rather wrapped in object, so it would be
>> PMA_Display::someFunction.
>>
>> --
>>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
> Hi Michal,
>
> Thanks for your reply. I got the point Michal. After the mentioned tasks
> plus making this as a class, I can use 'PMA_Display::someFunction' where
> needed.
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I am involving with some refactoring in "PMA_displayTableHeaders" function
in "display_tbl.lib.php" file.
As I mentioned in my previous mail, first I'm trying to render all HTML at
the bottom of the function itself.
But I'm facing some problems.

While current code rendering HTML codes using "echo", there are some
function calls which does not return anything but render HTML inside that.
Ex : "PMA_generate_slider_effect" function in common.lib.php file  ->  call
by 739 line in "display_tbl.lib.php" file.

There are several situations like that, in this function. Since they have
used in other files also (test cases also implemented for them), I do not
think to change those functions.

What I'm going to do is, remove HTML renderings everywhere inside the
function, as well as possible by assigning those HTML to a variable, and
render existing content in the variable before calling that kind of
function (as above mentioned).

Ex :
func {
    $tableHeadersHTML .= '';
    ----
    ----
    $tableHeadersHTML .= '<div>'
                                   . 'some html content';
    ----
    *echo $tableHeadersHTML; // render HTML content before another function
call which not just return a string of HTML*
    PMA_generate_slider_effect(params);
    ----
    // repeat the procedure
}

Before doing this, I would like to hear your suggestions on this.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On 07/05/12 09:27, Chanaka Dharmarathna wrote:
> On Sat, May 5, 2012 at 1:16 AM, Chanaka Dharmarathna<
> pe.chanaka.ck@...>  wrote:
>
>>
>>
>> On Thu, May 3, 2012 at 4:38 PM, Michal Čihař<michal@...>  wrote:
>>
>>> Hi
>>>
>>> Dne Tue, 1 May 2012 02:02:38 +0530
>>> Chanaka Dharmarathna<pe.chanaka.ck@...>  napsal(a):
>>>
>>>> I'm identifying the refactoring points in 'display_tbl.lib.php' file. I
>>> am
>>>> trying to break the tasks on following areas.
>>>>
>>>> * As a library file this should not render the HTML codes in functions
>>> it
>>>> selves. First, all the HTML content in functions stored in string and
>>>> render at the bottom of the function.
>>>> Next, return the string having the HTML content, instead of rendering it
>>>> inside the function itself and, from the calling end render that
>>> content.
>>>> Probably method names will be modified with adding 'get' phrase.
>>>>
>>>> * Some naming conventions are used incorrectly. For method name in lib
>>>> file, naming convention is used generally used as 'PMA_methodName'. But
>>>> some are not following this.
>>>> While correcting them, suggested conventions in my proposal [0] is
>>> going to
>>>> applied.
>>>>
>>>> * There are several functions having more than 200 lines. I'm intending
>>> to
>>>> divide those functions to smaller ones. (PMA_displayTableNavigation(),
>>>> PMA_displayTableHeaders(), PMA_displayTableBody(),
>>>> PMA_displayVerticalTable(), PMA_displayTable())
>>>
>>> I think all this should be rather wrapped in object, so it would be
>>> PMA_Display::someFunction.
>>>
>>> --
>>>         Michal Čihař | http://cihar.com | http://blog.cihar.com
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>>
>> Hi Michal,
>>
>> Thanks for your reply. I got the point Michal. After the mentioned tasks
>> plus making this as a class, I can use 'PMA_Display::someFunction' where
>> needed.
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> I am involving with some refactoring in "PMA_displayTableHeaders" function
> in "display_tbl.lib.php" file.
> As I mentioned in my previous mail, first I'm trying to render all HTML at
> the bottom of the function itself.
> But I'm facing some problems.
>
> While current code rendering HTML codes using "echo", there are some
> function calls which does not return anything but render HTML inside that.
> Ex : "PMA_generate_slider_effect" function in common.lib.php file  ->   call
> by 739 line in "display_tbl.lib.php" file.
>
> There are several situations like that, in this function. Since they have
> used in other files also (test cases also implemented for them), I do not
> think to change those functions.
>
> What I'm going to do is, remove HTML renderings everywhere inside the
> function, as well as possible by assigning those HTML to a variable, and
> render existing content in the variable before calling that kind of
> function (as above mentioned).
>
> Ex :
> func {
>      $tableHeadersHTML .= '';
>      ----
>      ----
>      $tableHeadersHTML .= '<div>'
>                                     . 'some html content';
>      ----
>      *echo $tableHeadersHTML; // render HTML content before another function
> call which not just return a string of HTML*
>      PMA_generate_slider_effect(params);
>      ----
>      // repeat the procedure
> }
>
> Before doing this, I would like to hear your suggestions on this.
>
> Regards !
>

I think that you should rewrite the PMA_generate_slider_effect function 
to output a string, like it should. I'd say don't worry about breaking 
test cases for functions that do things the wrong way around, besides 
those should simple enough to fix. As far as spotting other occurrences 
of the function in the code base, there are only 4 of them in total (and 
that includes the function declaration), so there is no excuse not to 
fix all of them. To find every occurrence, run:

git grep PMA_generate_slider_effect

Bye,
Rouslan

On Mon, May 7, 2012 at 6:24 PM, Rouslan Placella <rouslan@...:

> On 07/05/12 09:27, Chanaka Dharmarathna wrote:
> > On Sat, May 5, 2012 at 1:16 AM, Chanaka Dharmarathna<
> > pe.chanaka.ck@...>  wrote:
> >
> >>
> >>
> >> On Thu, May 3, 2012 at 4:38 PM, Michal Čihař<michal@...>  wrote:
> >>
> >>> Hi
> >>>
> >>> Dne Tue, 1 May 2012 02:02:38 +0530
> >>> Chanaka Dharmarathna<pe.chanaka.ck@...>  napsal(a):
> >>>
> >>>> I'm identifying the refactoring points in 'display_tbl.lib.php' file.
> I
> >>> am
> >>>> trying to break the tasks on following areas.
> >>>>
> >>>> * As a library file this should not render the HTML codes in functions
> >>> it
> >>>> selves. First, all the HTML content in functions stored in string and
> >>>> render at the bottom of the function.
> >>>> Next, return the string having the HTML content, instead of rendering
> it
> >>>> inside the function itself and, from the calling end render that
> >>> content.
> >>>> Probably method names will be modified with adding 'get' phrase.
> >>>>
> >>>> * Some naming conventions are used incorrectly. For method name in lib
> >>>> file, naming convention is used generally used as 'PMA_methodName'.
> But
> >>>> some are not following this.
> >>>> While correcting them, suggested conventions in my proposal [0] is
> >>> going to
> >>>> applied.
> >>>>
> >>>> * There are several functions having more than 200 lines. I'm
> intending
> >>> to
> >>>> divide those functions to smaller ones. (PMA_displayTableNavigation(),
> >>>> PMA_displayTableHeaders(), PMA_displayTableBody(),
> >>>> PMA_displayVerticalTable(), PMA_displayTable())
> >>>
> >>> I think all this should be rather wrapped in object, so it would be
> >>> PMA_Display::someFunction.
> >>>
> >>> --
> >>>         Michal Čihař | http://cihar.com | http://blog.cihar.com
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Live Security Virtual Conference
> >>> Exclusive live event will cover all the ways today's security and
> >>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>> will include endpoint security, mobile security and the latest in
> malware
> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>> _______________________________________________
> >>> Phpmyadmin-devel mailing list
> >>> Phpmyadmin-devel@...
> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>
> >>>
> >> Hi Michal,
> >>
> >> Thanks for your reply. I got the point Michal. After the mentioned tasks
> >> plus making this as a class, I can use 'PMA_Display::someFunction' where
> >> needed.
> >>
> >>
> >> Regards !
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >>
> > Hi Michal,
> >
> > I am involving with some refactoring in "PMA_displayTableHeaders"
> function
> > in "display_tbl.lib.php" file.
> > As I mentioned in my previous mail, first I'm trying to render all HTML
> at
> > the bottom of the function itself.
> > But I'm facing some problems.
> >
> > While current code rendering HTML codes using "echo", there are some
> > function calls which does not return anything but render HTML inside
> that.
> > Ex : "PMA_generate_slider_effect" function in common.lib.php file  ->
> call
> > by 739 line in "display_tbl.lib.php" file.
> >
> > There are several situations like that, in this function. Since they have
> > used in other files also (test cases also implemented for them), I do not
> > think to change those functions.
> >
> > What I'm going to do is, remove HTML renderings everywhere inside the
> > function, as well as possible by assigning those HTML to a variable, and
> > render existing content in the variable before calling that kind of
> > function (as above mentioned).
> >
> > Ex :
> > func {
> >      $tableHeadersHTML .= '';
> >      ----
> >      ----
> >      $tableHeadersHTML .= '<div>'
> >                                     . 'some html content';
> >      ----
> >      *echo $tableHeadersHTML; // render HTML content before another
> function
> > call which not just return a string of HTML*
> >      PMA_generate_slider_effect(params);
> >      ----
> >      // repeat the procedure
> > }
> >
> > Before doing this, I would like to hear your suggestions on this.
> >
> > Regards !
> >
>
> I think that you should rewrite the PMA_generate_slider_effect function
> to output a string, like it should. I'd say don't worry about breaking
> test cases for functions that do things the wrong way around, besides
> those should simple enough to fix. As far as spotting other occurrences
> of the function in the code base, there are only 4 of them in total (and
> that includes the function declaration), so there is no excuse not to
> fix all of them. To find every occurrence, run:
>
> git grep PMA_generate_slider_effect
>
> Bye,
> Rouslan
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Rouslan,

That's good idea. Its better to correct those things in good manner.
I'll try to rewrite that kind of functions. As well the tests.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Mon, May 7, 2012 at 10:07 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Mon, May 7, 2012 at 6:24 PM, Rouslan Placella <rouslan@...:
>
>> On 07/05/12 09:27, Chanaka Dharmarathna wrote:
>> > On Sat, May 5, 2012 at 1:16 AM, Chanaka Dharmarathna<
>> > pe.chanaka.ck@...>  wrote:
>> >
>> >>
>> >>
>> >> On Thu, May 3, 2012 at 4:38 PM, Michal Čihař<michal@...>  wrote:
>> >>
>> >>> Hi
>> >>>
>> >>> Dne Tue, 1 May 2012 02:02:38 +0530
>> >>> Chanaka Dharmarathna<pe.chanaka.ck@...>  napsal(a):
>> >>>
>> >>>> I'm identifying the refactoring points in 'display_tbl.lib.php'
>> file. I
>> >>> am
>> >>>> trying to break the tasks on following areas.
>> >>>>
>> >>>> * As a library file this should not render the HTML codes in
>> functions
>> >>> it
>> >>>> selves. First, all the HTML content in functions stored in string and
>> >>>> render at the bottom of the function.
>> >>>> Next, return the string having the HTML content, instead of
>> rendering it
>> >>>> inside the function itself and, from the calling end render that
>> >>> content.
>> >>>> Probably method names will be modified with adding 'get' phrase.
>> >>>>
>> >>>> * Some naming conventions are used incorrectly. For method name in
>> lib
>> >>>> file, naming convention is used generally used as 'PMA_methodName'.
>> But
>> >>>> some are not following this.
>> >>>> While correcting them, suggested conventions in my proposal [0] is
>> >>> going to
>> >>>> applied.
>> >>>>
>> >>>> * There are several functions having more than 200 lines. I'm
>> intending
>> >>> to
>> >>>> divide those functions to smaller ones.
>> (PMA_displayTableNavigation(),
>> >>>> PMA_displayTableHeaders(), PMA_displayTableBody(),
>> >>>> PMA_displayVerticalTable(), PMA_displayTable())
>> >>>
>> >>> I think all this should be rather wrapped in object, so it would be
>> >>> PMA_Display::someFunction.
>> >>>
>> >>> --
>> >>>         Michal Čihař | http://cihar.com | http://blog.cihar.com
>> >>>
>> >>>
>> >>>
>> ------------------------------------------------------------------------------
>> >>> Live Security Virtual Conference
>> >>> Exclusive live event will cover all the ways today's security and
>> >>> threat landscape has changed and how IT managers can respond.
>> Discussions
>> >>> will include endpoint security, mobile security and the latest in
>> malware
>> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>> _______________________________________________
>> >>> Phpmyadmin-devel mailing list
>> >>> Phpmyadmin-devel@...
>> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>
>> >>>
>> >> Hi Michal,
>> >>
>> >> Thanks for your reply. I got the point Michal. After the mentioned
>> tasks
>> >> plus making this as a class, I can use 'PMA_Display::someFunction'
>> where
>> >> needed.
>> >>
>> >>
>> >> Regards !
>> >> --
>> >> ____________________________________
>> >>
>> >> Chanaka Indrajith
>> >> Bsc.Computer Engineering Undergraduate
>> >> Faculty of Engineering
>> >> University of Peradeniya
>> >> Sri Lanka
>> >> ____________________________________
>> >>
>> >>
>> > Hi Michal,
>> >
>> > I am involving with some refactoring in "PMA_displayTableHeaders"
>> function
>> > in "display_tbl.lib.php" file.
>> > As I mentioned in my previous mail, first I'm trying to render all HTML
>> at
>> > the bottom of the function itself.
>> > But I'm facing some problems.
>> >
>> > While current code rendering HTML codes using "echo", there are some
>> > function calls which does not return anything but render HTML inside
>> that.
>> > Ex : "PMA_generate_slider_effect" function in common.lib.php file  ->
>> call
>> > by 739 line in "display_tbl.lib.php" file.
>> >
>> > There are several situations like that, in this function. Since they
>> have
>> > used in other files also (test cases also implemented for them), I do
>> not
>> > think to change those functions.
>> >
>> > What I'm going to do is, remove HTML renderings everywhere inside the
>> > function, as well as possible by assigning those HTML to a variable, and
>> > render existing content in the variable before calling that kind of
>> > function (as above mentioned).
>> >
>> > Ex :
>> > func {
>> >      $tableHeadersHTML .= '';
>> >      ----
>> >      ----
>> >      $tableHeadersHTML .= '<div>'
>> >                                     . 'some html content';
>> >      ----
>> >      *echo $tableHeadersHTML; // render HTML content before another
>> function
>> > call which not just return a string of HTML*
>> >      PMA_generate_slider_effect(params);
>> >      ----
>> >      // repeat the procedure
>> > }
>> >
>> > Before doing this, I would like to hear your suggestions on this.
>> >
>> > Regards !
>> >
>>
>> I think that you should rewrite the PMA_generate_slider_effect function
>> to output a string, like it should. I'd say don't worry about breaking
>> test cases for functions that do things the wrong way around, besides
>> those should simple enough to fix. As far as spotting other occurrences
>> of the function in the code base, there are only 4 of them in total (and
>> that includes the function declaration), so there is no excuse not to
>> fix all of them. To find every occurrence, run:
>>
>> git grep PMA_generate_slider_effect
>>
>> Bye,
>> Rouslan
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>
> Hi Rouslan,
>
> That's good idea. Its better to correct those things in good manner.
> I'll try to rewrite that kind of functions. As well the tests.
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Rouslan,

Do you have any idea of using different naming conventions for this
('PMA_generate_slider_effect') function than general. (not only this, there
are several functions)
Generally function names are like 'PMA_meaningfulDescription()'. This does
not use underscores after 'PMA_' part and use camel caps.
But here it is 'PMA_generate_slider_effect()'. Its different.

As well, Since this function is going to return a string after modifying,
the name should be change to give a meaning to the user (developer).
I'm thinking modify the name with 'get' phrase for that kind of functions.
Ex :- 'PMA_getSliderEffectGeneratingHtml()' instead of
'PMA_generate_slider_effect' (existing one)
Do you have any suggestions on that ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Le 2012-05-08 04:57, Chanaka Dharmarathna a écrit :
> On Mon, May 7, 2012 at 10:07 PM, Chanaka Dharmarathna <
> pe.chanaka.ck@...> wrote:
> 
>>
>>
>> On Mon, May 7, 2012 at 6:24 PM, Rouslan Placella <rouslan@...:
>>
>>> On 07/05/12 09:27, Chanaka Dharmarathna wrote:
>>>> On Sat, May 5, 2012 at 1:16 AM, Chanaka Dharmarathna<
>>>> pe.chanaka.ck@...>  wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, May 3, 2012 at 4:38 PM, Michal Čihař<michal@...>  wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> Dne Tue, 1 May 2012 02:02:38 +0530
>>>>>> Chanaka Dharmarathna<pe.chanaka.ck@...>  napsal(a):
>>>>>>
>>>>>>> I'm identifying the refactoring points in 'display_tbl.lib.php'
>>> file. I
>>>>>> am
>>>>>>> trying to break the tasks on following areas.
>>>>>>>
>>>>>>> * As a library file this should not render the HTML codes in
>>> functions
>>>>>> it
>>>>>>> selves. First, all the HTML content in functions stored in string and
>>>>>>> render at the bottom of the function.
>>>>>>> Next, return the string having the HTML content, instead of
>>> rendering it
>>>>>>> inside the function itself and, from the calling end render that
>>>>>> content.
>>>>>>> Probably method names will be modified with adding 'get' phrase.
>>>>>>>
>>>>>>> * Some naming conventions are used incorrectly. For method name in
>>> lib
>>>>>>> file, naming convention is used generally used as 'PMA_methodName'.
>>> But
>>>>>>> some are not following this.
>>>>>>> While correcting them, suggested conventions in my proposal [0] is
>>>>>> going to
>>>>>>> applied.
>>>>>>>
>>>>>>> * There are several functions having more than 200 lines. I'm
>>> intending
>>>>>> to
>>>>>>> divide those functions to smaller ones.
>>> (PMA_displayTableNavigation(),
>>>>>>> PMA_displayTableHeaders(), PMA_displayTableBody(),
>>>>>>> PMA_displayVerticalTable(), PMA_displayTable())
>>>>>>
>>>>>> I think all this should be rather wrapped in object, so it would be
>>>>>> PMA_Display::someFunction.
>>>>>>
>>>>>> --
>>>>>>         Michal Čihař | http://cihar.com | http://blog.cihar.com
>>>>>>
>>>>>>
>>>>>>
>>> ------------------------------------------------------------------------------
>>>>>> Live Security Virtual Conference
>>>>>> Exclusive live event will cover all the ways today's security and
>>>>>> threat landscape has changed and how IT managers can respond.
>>> Discussions
>>>>>> will include endpoint security, mobile security and the latest in
>>> malware
>>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>>>> _______________________________________________
>>>>>> Phpmyadmin-devel mailing list
>>>>>> Phpmyadmin-devel@...
>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>>>
>>>>>>
>>>>> Hi Michal,
>>>>>
>>>>> Thanks for your reply. I got the point Michal. After the mentioned
>>> tasks
>>>>> plus making this as a class, I can use 'PMA_Display::someFunction'
>>> where
>>>>> needed.
>>>>>
>>>>>
>>>>> Regards !
>>>>> --
>>>>> ____________________________________
>>>>>
>>>>> Chanaka Indrajith
>>>>> Bsc.Computer Engineering Undergraduate
>>>>> Faculty of Engineering
>>>>> University of Peradeniya
>>>>> Sri Lanka
>>>>> ____________________________________
>>>>>
>>>>>
>>>> Hi Michal,
>>>>
>>>> I am involving with some refactoring in "PMA_displayTableHeaders"
>>> function
>>>> in "display_tbl.lib.php" file.
>>>> As I mentioned in my previous mail, first I'm trying to render all HTML
>>> at
>>>> the bottom of the function itself.
>>>> But I'm facing some problems.
>>>>
>>>> While current code rendering HTML codes using "echo", there are some
>>>> function calls which does not return anything but render HTML inside
>>> that.
>>>> Ex : "PMA_generate_slider_effect" function in common.lib.php file  ->
>>> call
>>>> by 739 line in "display_tbl.lib.php" file.
>>>>
>>>> There are several situations like that, in this function. Since they
>>> have
>>>> used in other files also (test cases also implemented for them), I do
>>> not
>>>> think to change those functions.
>>>>
>>>> What I'm going to do is, remove HTML renderings everywhere inside the
>>>> function, as well as possible by assigning those HTML to a variable, and
>>>> render existing content in the variable before calling that kind of
>>>> function (as above mentioned).
>>>>
>>>> Ex :
>>>> func {
>>>>      $tableHeadersHTML .= '';
>>>>      ----
>>>>      ----
>>>>      $tableHeadersHTML .= '<div>'
>>>>                                     . 'some html content';
>>>>      ----
>>>>      *echo $tableHeadersHTML; // render HTML content before another
>>> function
>>>> call which not just return a string of HTML*
>>>>      PMA_generate_slider_effect(params);
>>>>      ----
>>>>      // repeat the procedure
>>>> }
>>>>
>>>> Before doing this, I would like to hear your suggestions on this.
>>>>
>>>> Regards !
>>>>
>>>
>>> I think that you should rewrite the PMA_generate_slider_effect function
>>> to output a string, like it should. I'd say don't worry about breaking
>>> test cases for functions that do things the wrong way around, besides
>>> those should simple enough to fix. As far as spotting other occurrences
>>> of the function in the code base, there are only 4 of them in total (and
>>> that includes the function declaration), so there is no excuse not to
>>> fix all of them. To find every occurrence, run:
>>>
>>> git grep PMA_generate_slider_effect
>>>
>>> Bye,
>>> Rouslan
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>
>> Hi Rouslan,
>>
>> That's good idea. Its better to correct those things in good manner.
>> I'll try to rewrite that kind of functions. As well the tests.
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Rouslan,
> 
> Do you have any idea of using different naming conventions for this
> ('PMA_generate_slider_effect') function than general. (not only this, there
> are several functions)
> Generally function names are like 'PMA_meaningfulDescription()'. This does
> not use underscores after 'PMA_' part and use camel caps.
> But here it is 'PMA_generate_slider_effect()'. Its different.
> 
> As well, Since this function is going to return a string after modifying,
> the name should be change to give a meaning to the user (developer).
> I'm thinking modify the name with 'get' phrase for that kind of functions.
> Ex :- 'PMA_getSliderEffectGeneratingHtml()' instead of
> 'PMA_generate_slider_effect' (existing one)
> Do you have any suggestions on that ?
> 
> Regards !

PMA_getDivForSliderEffect()

By the way, this is the naming convention for a global function (outside
a class). Will this be inside a class?

-- 
Marc Delisle
http://infomarc.info

On Tue, May 8, 2012 at 3:06 PM, Marc Delisle <marc@...> wrote:

> Le 2012-05-08 04:57, Chanaka Dharmarathna a écrit :
> > On Mon, May 7, 2012 at 10:07 PM, Chanaka Dharmarathna <
> > pe.chanaka.ck@...> wrote:
> >
> >>
> >>
> >> On Mon, May 7, 2012 at 6:24 PM, Rouslan Placella <rouslan@...
> >wrote:
> >>
> >>> On 07/05/12 09:27, Chanaka Dharmarathna wrote:
> >>>> On Sat, May 5, 2012 at 1:16 AM, Chanaka Dharmarathna<
> >>>> pe.chanaka.ck@...>  wrote:
> >>>>
> >>>>>
> >>>>>
> >>>>> On Thu, May 3, 2012 at 4:38 PM, Michal Čihař<michal@...>
>  wrote:
> >>>>>
> >>>>>> Hi
> >>>>>>
> >>>>>> Dne Tue, 1 May 2012 02:02:38 +0530
> >>>>>> Chanaka Dharmarathna<pe.chanaka.ck@...>  napsal(a):
> >>>>>>
> >>>>>>> I'm identifying the refactoring points in 'display_tbl.lib.php'
> >>> file. I
> >>>>>> am
> >>>>>>> trying to break the tasks on following areas.
> >>>>>>>
> >>>>>>> * As a library file this should not render the HTML codes in
> >>> functions
> >>>>>> it
> >>>>>>> selves. First, all the HTML content in functions stored in string
> and
> >>>>>>> render at the bottom of the function.
> >>>>>>> Next, return the string having the HTML content, instead of
> >>> rendering it
> >>>>>>> inside the function itself and, from the calling end render that
> >>>>>> content.
> >>>>>>> Probably method names will be modified with adding 'get' phrase.
> >>>>>>>
> >>>>>>> * Some naming conventions are used incorrectly. For method name in
> >>> lib
> >>>>>>> file, naming convention is used generally used as 'PMA_methodName'.
> >>> But
> >>>>>>> some are not following this.
> >>>>>>> While correcting them, suggested conventions in my proposal [0] is
> >>>>>> going to
> >>>>>>> applied.
> >>>>>>>
> >>>>>>> * There are several functions having more than 200 lines. I'm
> >>> intending
> >>>>>> to
> >>>>>>> divide those functions to smaller ones.
> >>> (PMA_displayTableNavigation(),
> >>>>>>> PMA_displayTableHeaders(), PMA_displayTableBody(),
> >>>>>>> PMA_displayVerticalTable(), PMA_displayTable())
> >>>>>>
> >>>>>> I think all this should be rather wrapped in object, so it would be
> >>>>>> PMA_Display::someFunction.
> >>>>>>
> >>>>>> --
> >>>>>>         Michal Čihař | http://cihar.com | http://blog.cihar.com
> >>>>>>
> >>>>>>
> >>>>>>
> >>>
> ------------------------------------------------------------------------------
> >>>>>> Live Security Virtual Conference
> >>>>>> Exclusive live event will cover all the ways today's security and
> >>>>>> threat landscape has changed and how IT managers can respond.
> >>> Discussions
> >>>>>> will include endpoint security, mobile security and the latest in
> >>> malware
> >>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>>>> _______________________________________________
> >>>>>> Phpmyadmin-devel mailing list
> >>>>>> Phpmyadmin-devel@...
> >>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>>>
> >>>>>>
> >>>>> Hi Michal,
> >>>>>
> >>>>> Thanks for your reply. I got the point Michal. After the mentioned
> >>> tasks
> >>>>> plus making this as a class, I can use 'PMA_Display::someFunction'
> >>> where
> >>>>> needed.
> >>>>>
> >>>>>
> >>>>> Regards !
> >>>>> --
> >>>>> ____________________________________
> >>>>>
> >>>>> Chanaka Indrajith
> >>>>> Bsc.Computer Engineering Undergraduate
> >>>>> Faculty of Engineering
> >>>>> University of Peradeniya
> >>>>> Sri Lanka
> >>>>> ____________________________________
> >>>>>
> >>>>>
> >>>> Hi Michal,
> >>>>
> >>>> I am involving with some refactoring in "PMA_displayTableHeaders"
> >>> function
> >>>> in "display_tbl.lib.php" file.
> >>>> As I mentioned in my previous mail, first I'm trying to render all
> HTML
> >>> at
> >>>> the bottom of the function itself.
> >>>> But I'm facing some problems.
> >>>>
> >>>> While current code rendering HTML codes using "echo", there are some
> >>>> function calls which does not return anything but render HTML inside
> >>> that.
> >>>> Ex : "PMA_generate_slider_effect" function in common.lib.php file  ->
> >>> call
> >>>> by 739 line in "display_tbl.lib.php" file.
> >>>>
> >>>> There are several situations like that, in this function. Since they
> >>> have
> >>>> used in other files also (test cases also implemented for them), I do
> >>> not
> >>>> think to change those functions.
> >>>>
> >>>> What I'm going to do is, remove HTML renderings everywhere inside the
> >>>> function, as well as possible by assigning those HTML to a variable,
> and
> >>>> render existing content in the variable before calling that kind of
> >>>> function (as above mentioned).
> >>>>
> >>>> Ex :
> >>>> func {
> >>>>      $tableHeadersHTML .= '';
> >>>>      ----
> >>>>      ----
> >>>>      $tableHeadersHTML .= '<div>'
> >>>>                                     . 'some html content';
> >>>>      ----
> >>>>      *echo $tableHeadersHTML; // render HTML content before another
> >>> function
> >>>> call which not just return a string of HTML*
> >>>>      PMA_generate_slider_effect(params);
> >>>>      ----
> >>>>      // repeat the procedure
> >>>> }
> >>>>
> >>>> Before doing this, I would like to hear your suggestions on this.
> >>>>
> >>>> Regards !
> >>>>
> >>>
> >>> I think that you should rewrite the PMA_generate_slider_effect function
> >>> to output a string, like it should. I'd say don't worry about breaking
> >>> test cases for functions that do things the wrong way around, besides
> >>> those should simple enough to fix. As far as spotting other occurrences
> >>> of the function in the code base, there are only 4 of them in total
> (and
> >>> that includes the function declaration), so there is no excuse not to
> >>> fix all of them. To find every occurrence, run:
> >>>
> >>> git grep PMA_generate_slider_effect
> >>>
> >>> Bye,
> >>> Rouslan
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Live Security Virtual Conference
> >>> Exclusive live event will cover all the ways today's security and
> >>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>> will include endpoint security, mobile security and the latest in
> malware
> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>> _______________________________________________
> >>> Phpmyadmin-devel mailing list
> >>> Phpmyadmin-devel@...
> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>
> >>
> >> Hi Rouslan,
> >>
> >> That's good idea. Its better to correct those things in good manner.
> >> I'll try to rewrite that kind of functions. As well the tests.
> >>
> >>
> >> Regards !
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >>
> > Hi Rouslan,
> >
> > Do you have any idea of using different naming conventions for this
> > ('PMA_generate_slider_effect') function than general. (not only this,
> there
> > are several functions)
> > Generally function names are like 'PMA_meaningfulDescription()'. This
> does
> > not use underscores after 'PMA_' part and use camel caps.
> > But here it is 'PMA_generate_slider_effect()'. Its different.
> >
> > As well, Since this function is going to return a string after modifying,
> > the name should be change to give a meaning to the user (developer).
> > I'm thinking modify the name with 'get' phrase for that kind of
> functions.
> > Ex :- 'PMA_getSliderEffectGeneratingHtml()' instead of
> > 'PMA_generate_slider_effect' (existing one)
> > Do you have any suggestions on that ?
> >
> > Regards !
>
> PMA_getDivForSliderEffect()
>
> By the way, this is the naming convention for a global function (outside
> a class). Will this be inside a class?
>
> --
> Marc Delisle
> http://infomarc.info
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Marc,

That name is seems pretty good. Thanks for suggesting.
And Marc, what about the naming convention of local (for a class) methods.

As I feel common.lib.php file should contain a class and this function will
be inside that.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Le 2012-05-08 09:01, Chanaka Dharmarathna a écrit :
(...)
>>> Hi Rouslan,
>>>
>>> Do you have any idea of using different naming conventions for this
>>> ('PMA_generate_slider_effect') function than general. (not only this,
>> there
>>> are several functions)
>>> Generally function names are like 'PMA_meaningfulDescription()'. This
>> does
>>> not use underscores after 'PMA_' part and use camel caps.
>>> But here it is 'PMA_generate_slider_effect()'. Its different.
>>>
>>> As well, Since this function is going to return a string after modifying,
>>> the name should be change to give a meaning to the user (developer).
>>> I'm thinking modify the name with 'get' phrase for that kind of
>> functions.
>>> Ex :- 'PMA_getSliderEffectGeneratingHtml()' instead of
>>> 'PMA_generate_slider_effect' (existing one)
>>> Do you have any suggestions on that ?
>>>
>>> Regards !
>>
>> PMA_getDivForSliderEffect()
>>
>> By the way, this is the naming convention for a global function (outside
>> a class). Will this be inside a class?
> 
> Hi Marc,
> 
> That name is seems pretty good. Thanks for suggesting.
> And Marc, what about the naming convention of local (for a class) methods.
> 
> As I feel common.lib.php file should contain a class and this function will
> be inside that.
> 
> Regards !

See "Class Variables and Methods" in [0].

[0] http://pear.php.net/manual/en/standards.naming.php


-- 
Marc Delisle
http://infomarc.info

On Tue, May 8, 2012 at 6:42 PM, Marc Delisle <marc@...> wrote:

> Le 2012-05-08 09:01, Chanaka Dharmarathna a écrit :
> (...)
> >>> Hi Rouslan,
> >>>
> >>> Do you have any idea of using different naming conventions for this
> >>> ('PMA_generate_slider_effect') function than general. (not only this,
> >> there
> >>> are several functions)
> >>> Generally function names are like 'PMA_meaningfulDescription()'. This
> >> does
> >>> not use underscores after 'PMA_' part and use camel caps.
> >>> But here it is 'PMA_generate_slider_effect()'. Its different.
> >>>
> >>> As well, Since this function is going to return a string after
> modifying,
> >>> the name should be change to give a meaning to the user (developer).
> >>> I'm thinking modify the name with 'get' phrase for that kind of
> >> functions.
> >>> Ex :- 'PMA_getSliderEffectGeneratingHtml()' instead of
> >>> 'PMA_generate_slider_effect' (existing one)
> >>> Do you have any suggestions on that ?
> >>>
> >>> Regards !
> >>
> >> PMA_getDivForSliderEffect()
> >>
> >> By the way, this is the naming convention for a global function (outside
> >> a class). Will this be inside a class?
> >
> > Hi Marc,
> >
> > That name is seems pretty good. Thanks for suggesting.
> > And Marc, what about the naming convention of local (for a class)
> methods.
> >
> > As I feel common.lib.php file should contain a class and this function
> will
> > be inside that.
> >
> > Regards !
>
> See "Class Variables and Methods" in [0].
>
> [0] http://pear.php.net/manual/en/standards.naming.php
>
>
> --
> Marc Delisle
> http://infomarc.info
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Marc,

I went through that document.
If the function is global, it will be like 'PMA_getDivForSliderEffect()'
And if it is a local function (for particular class), it will be like
'getDivForSliderEffect()'.

Though I went through that document before this, I couldn't get that point.
Thanks for pointing out that.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :

>>
>> See "Class Variables and Methods" in [0].
>>
>> [0] http://pear.php.net/manual/en/standards.naming.php

> Hi Marc,
> 
> I went through that document.
> If the function is global, it will be like 'PMA_getDivForSliderEffect()'
> And if it is a local function (for particular class), it will be like
> 'getDivForSliderEffect()'.

If this is a public method, yes. If a private one, prefix its name with
an underscore.

> 
> Though I went through that document before this, I couldn't get that point.
> Thanks for pointing out that.



-- 
Marc Delisle
http://infomarc.info

On Tue, May 8, 2012 at 7:08 PM, Marc Delisle <marc@...> wrote:

> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>
> >>
> >> See "Class Variables and Methods" in [0].
> >>
> >> [0] http://pear.php.net/manual/en/standards.naming.php
>
> > Hi Marc,
> >
> > I went through that document.
> > If the function is global, it will be like 'PMA_getDivForSliderEffect()'
> > And if it is a local function (for particular class), it will be like
> > 'getDivForSliderEffect()'.
>
> If this is a public method, yes. If a private one, prefix its name with
> an underscore.
>
> >
> > Though I went through that document before this, I couldn't get that
> point.
> > Thanks for pointing out that.
>
>
>
> --
> Marc Delisle
> http://infomarc.info
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Got it Marc.
Thanks.

-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle <marc@...> wrote:
>
>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>>
>> >>
>> >> See "Class Variables and Methods" in [0].
>> >>
>> >> [0] http://pear.php.net/manual/en/standards.naming.php
>>
>> > Hi Marc,
>> >
>> > I went through that document.
>> > If the function is global, it will be like 'PMA_getDivForSliderEffect()'
>> > And if it is a local function (for particular class), it will be like
>> > 'getDivForSliderEffect()'.
>>
>> If this is a public method, yes. If a private one, prefix its name with
>> an underscore.
>>
>> >
>> > Though I went through that document before this, I couldn't get that
>> point.
>> > Thanks for pointing out that.
>>
>>
>>
>> --
>> Marc Delisle
>> http://infomarc.info
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
> Got it Marc.
> Thanks.
>
>
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I just did my first commit to my repository [0].
In that commit I have done some refactoring on "PMA_displayTableHeaders()"
function in "display_tbl.php" file.
All HTML renderings by "echo"s were removed and those HTML was rendered at
the bottom of the function at once.
As well some related functions in "common.lib.php" file also were modified
in order to return a string of HTML content.
But the tests were not yet modified according to my modifications.
Since there was a conflict after my first local commit [1] (git commit), I
had to resolve conflicts and commit again. (that is [0])

I have already installed phpUnit framework.
It will be very helpful if you can suggest me some documentation to setup
and run tests in PMA (selenium etc).

I'm intending to do the above refactoring procedure to all the functions in
"display_tbl.lib.php" file before moving to any other task.

[0] :
https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
[1] :
https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On 08/05/12 20:32, Chanaka Dharmarathna wrote:
> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
> pe.chanaka.ck@...>  wrote:
>
>>
>>
>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>  wrote:
>>
>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>>>
>>>>>
>>>>> See "Class Variables and Methods" in [0].
>>>>>
>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
>>>
>>>> Hi Marc,
>>>>
>>>> I went through that document.
>>>> If the function is global, it will be like 'PMA_getDivForSliderEffect()'
>>>> And if it is a local function (for particular class), it will be like
>>>> 'getDivForSliderEffect()'.
>>>
>>> If this is a public method, yes. If a private one, prefix its name with
>>> an underscore.
>>>
>>>>
>>>> Though I went through that document before this, I couldn't get that
>>> point.
>>>> Thanks for pointing out that.
>>>
>>>
>>>
>>> --
>>> Marc Delisle
>>> http://infomarc.info
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>>
>> Got it Marc.
>> Thanks.
>>
>>
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> I just did my first commit to my repository [0].
> In that commit I have done some refactoring on "PMA_displayTableHeaders()"
> function in "display_tbl.php" file.
> All HTML renderings by "echo"s were removed and those HTML was rendered at
> the bottom of the function at once.
> As well some related functions in "common.lib.php" file also were modified
> in order to return a string of HTML content.
> But the tests were not yet modified according to my modifications.
> Since there was a conflict after my first local commit [1] (git commit), I
> had to resolve conflicts and commit again. (that is [0])
>
> I have already installed phpUnit framework.
> It will be very helpful if you can suggest me some documentation to setup
> and run tests in PMA (selenium etc).
>
> I'm intending to do the above refactoring procedure to all the functions in
> "display_tbl.lib.php" file before moving to any other task.
>
> [0] :
> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
> [1] :
> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
>
> Regards !

I had a very quick look at your commit. I think that you're indenting 
some lines incorrectly (but I stand to be corrected on this one). AFAIK, 
you don't need to line up the operators, just indent by 4 spaces. Example:

// THIS IS BAD
$radio_html .= '<label for="' . $html_field_id . '">'
             . $choice_label
             . '</label>';

// THIS IS GOOD
$radio_html .= '<label for="' . $html_field_id . '">'
     . $choice_label
     . '</label>';

// THIS IS ALSO GOOD
$radio_html .= '<label for="' . $html_field_id . '">';
$radio_html .= $choice_label;
$radio_html .= '</label>';

Bye,
Rouslan

On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella <rouslan@...:

> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
> > On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
> > pe.chanaka.ck@...>  wrote:
> >
> >>
> >>
> >> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
>  wrote:
> >>
> >>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
> >>>
> >>>>>
> >>>>> See "Class Variables and Methods" in [0].
> >>>>>
> >>>>> [0] http://pear.php.net/manual/en/standards.naming.php
> >>>
> >>>> Hi Marc,
> >>>>
> >>>> I went through that document.
> >>>> If the function is global, it will be like
> 'PMA_getDivForSliderEffect()'
> >>>> And if it is a local function (for particular class), it will be like
> >>>> 'getDivForSliderEffect()'.
> >>>
> >>> If this is a public method, yes. If a private one, prefix its name with
> >>> an underscore.
> >>>
> >>>>
> >>>> Though I went through that document before this, I couldn't get that
> >>> point.
> >>>> Thanks for pointing out that.
> >>>
> >>>
> >>>
> >>> --
> >>> Marc Delisle
> >>> http://infomarc.info
> >>>
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Live Security Virtual Conference
> >>> Exclusive live event will cover all the ways today's security and
> >>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>> will include endpoint security, mobile security and the latest in
> malware
> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>> _______________________________________________
> >>> Phpmyadmin-devel mailing list
> >>> Phpmyadmin-devel@...
> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>
> >>>
> >> Got it Marc.
> >> Thanks.
> >>
> >>
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >>
> > Hi Michal,
> >
> > I just did my first commit to my repository [0].
> > In that commit I have done some refactoring on
> "PMA_displayTableHeaders()"
> > function in "display_tbl.php" file.
> > All HTML renderings by "echo"s were removed and those HTML was rendered
> at
> > the bottom of the function at once.
> > As well some related functions in "common.lib.php" file also were
> modified
> > in order to return a string of HTML content.
> > But the tests were not yet modified according to my modifications.
> > Since there was a conflict after my first local commit [1] (git commit),
> I
> > had to resolve conflicts and commit again. (that is [0])
> >
> > I have already installed phpUnit framework.
> > It will be very helpful if you can suggest me some documentation to setup
> > and run tests in PMA (selenium etc).
> >
> > I'm intending to do the above refactoring procedure to all the functions
> in
> > "display_tbl.lib.php" file before moving to any other task.
> >
> > [0] :
> >
> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
> > [1] :
> >
> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
> >
> > Regards !
>
> I had a very quick look at your commit. I think that you're indenting
> some lines incorrectly (but I stand to be corrected on this one). AFAIK,
> you don't need to line up the operators, just indent by 4 spaces. Example:
>
> // THIS IS BAD
> $radio_html .= '<label for="' . $html_field_id . '">'
>             . $choice_label
>             . '</label>';
>
> // THIS IS GOOD
> $radio_html .= '<label for="' . $html_field_id . '">'
>     . $choice_label
>     . '</label>';
>
> // THIS IS ALSO GOOD
> $radio_html .= '<label for="' . $html_field_id . '">';
> $radio_html .= $choice_label;
> $radio_html .= '</label>';
>
> Bye,
> Rouslan
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Rouslan,

Thanks for your suggestion.
I'll follow the way you mentioned as "THIS IS GOOD".

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella <rouslan@...:
>
>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
>> > On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
>> > pe.chanaka.ck@...>  wrote:
>> >
>> >>
>> >>
>> >> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
>>  wrote:
>> >>
>> >>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>> >>>
>> >>>>>
>> >>>>> See "Class Variables and Methods" in [0].
>> >>>>>
>> >>>>> [0] http://pear.php.net/manual/en/standards.naming.php
>> >>>
>> >>>> Hi Marc,
>> >>>>
>> >>>> I went through that document.
>> >>>> If the function is global, it will be like
>> 'PMA_getDivForSliderEffect()'
>> >>>> And if it is a local function (for particular class), it will be like
>> >>>> 'getDivForSliderEffect()'.
>> >>>
>> >>> If this is a public method, yes. If a private one, prefix its name
>> with
>> >>> an underscore.
>> >>>
>> >>>>
>> >>>> Though I went through that document before this, I couldn't get that
>> >>> point.
>> >>>> Thanks for pointing out that.
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Marc Delisle
>> >>> http://infomarc.info
>> >>>
>> >>>
>> >>>
>> >>>
>> ------------------------------------------------------------------------------
>> >>> Live Security Virtual Conference
>> >>> Exclusive live event will cover all the ways today's security and
>> >>> threat landscape has changed and how IT managers can respond.
>> Discussions
>> >>> will include endpoint security, mobile security and the latest in
>> malware
>> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>> _______________________________________________
>> >>> Phpmyadmin-devel mailing list
>> >>> Phpmyadmin-devel@...
>> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>
>> >>>
>> >> Got it Marc.
>> >> Thanks.
>> >>
>> >>
>> >> --
>> >> ____________________________________
>> >>
>> >> Chanaka Indrajith
>> >> Bsc.Computer Engineering Undergraduate
>> >> Faculty of Engineering
>> >> University of Peradeniya
>> >> Sri Lanka
>> >> ____________________________________
>> >>
>> >>
>> > Hi Michal,
>> >
>> > I just did my first commit to my repository [0].
>> > In that commit I have done some refactoring on
>> "PMA_displayTableHeaders()"
>> > function in "display_tbl.php" file.
>> > All HTML renderings by "echo"s were removed and those HTML was rendered
>> at
>> > the bottom of the function at once.
>> > As well some related functions in "common.lib.php" file also were
>> modified
>> > in order to return a string of HTML content.
>> > But the tests were not yet modified according to my modifications.
>> > Since there was a conflict after my first local commit [1] (git
>> commit), I
>> > had to resolve conflicts and commit again. (that is [0])
>> >
>> > I have already installed phpUnit framework.
>> > It will be very helpful if you can suggest me some documentation to
>> setup
>> > and run tests in PMA (selenium etc).
>> >
>> > I'm intending to do the above refactoring procedure to all the
>> functions in
>> > "display_tbl.lib.php" file before moving to any other task.
>> >
>> > [0] :
>> >
>> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
>> > [1] :
>> >
>> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
>> >
>> > Regards !
>>
>> I had a very quick look at your commit. I think that you're indenting
>> some lines incorrectly (but I stand to be corrected on this one). AFAIK,
>> you don't need to line up the operators, just indent by 4 spaces. Example:
>>
>> // THIS IS BAD
>> $radio_html .= '<label for="' . $html_field_id . '">'
>>             . $choice_label
>>             . '</label>';
>>
>> // THIS IS GOOD
>> $radio_html .= '<label for="' . $html_field_id . '">'
>>     . $choice_label
>>     . '</label>';
>>
>> // THIS IS ALSO GOOD
>> $radio_html .= '<label for="' . $html_field_id . '">';
>> $radio_html .= $choice_label;
>> $radio_html .= '</label>';
>>
>> Bye,
>> Rouslan
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>
> Hi Rouslan,
>
> Thanks for your suggestion.
> I'll follow the way you mentioned as "THIS IS GOOD".
>
> Regards !
>
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

In some functions there are pure HTML code snippets. (Ex :-
PMA_displayTableNavigationOneButton() function in display_tbl.lib.php)

As I feel, its not good to convert all these snippets as PHP string and
render them. So I'm intending to get those pure HTML snippets into separate
function. That function can be named as 'PMA_renderTableNavigationForm'
(for above case).
What do you think about this ?

As well is there any reason for the phrase 'One' in the function
"PMA_displayTableNavigation*One*Button()" ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On 09/05/12 09:39, Chanaka Dharmarathna wrote:
> On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
> pe.chanaka.ck@...>  wrote:
>
>>
>>
>> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<rouslan@...:
>>
>>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
>>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
>>>> pe.chanaka.ck@...>   wrote:
>>>>
>>>>>
>>>>>
>>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
>>>   wrote:
>>>>>
>>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>>>>>>
>>>>>>>>
>>>>>>>> See "Class Variables and Methods" in [0].
>>>>>>>>
>>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
>>>>>>
>>>>>>> Hi Marc,
>>>>>>>
>>>>>>> I went through that document.
>>>>>>> If the function is global, it will be like
>>> 'PMA_getDivForSliderEffect()'
>>>>>>> And if it is a local function (for particular class), it will be like
>>>>>>> 'getDivForSliderEffect()'.
>>>>>>
>>>>>> If this is a public method, yes. If a private one, prefix its name
>>> with
>>>>>> an underscore.
>>>>>>
>>>>>>>
>>>>>>> Though I went through that document before this, I couldn't get that
>>>>>> point.
>>>>>>> Thanks for pointing out that.
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Marc Delisle
>>>>>> http://infomarc.info
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>> ------------------------------------------------------------------------------
>>>>>> Live Security Virtual Conference
>>>>>> Exclusive live event will cover all the ways today's security and
>>>>>> threat landscape has changed and how IT managers can respond.
>>> Discussions
>>>>>> will include endpoint security, mobile security and the latest in
>>> malware
>>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>>>> _______________________________________________
>>>>>> Phpmyadmin-devel mailing list
>>>>>> Phpmyadmin-devel@...
>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>>>
>>>>>>
>>>>> Got it Marc.
>>>>> Thanks.
>>>>>
>>>>>
>>>>> --
>>>>> ____________________________________
>>>>>
>>>>> Chanaka Indrajith
>>>>> Bsc.Computer Engineering Undergraduate
>>>>> Faculty of Engineering
>>>>> University of Peradeniya
>>>>> Sri Lanka
>>>>> ____________________________________
>>>>>
>>>>>
>>>> Hi Michal,
>>>>
>>>> I just did my first commit to my repository [0].
>>>> In that commit I have done some refactoring on
>>> "PMA_displayTableHeaders()"
>>>> function in "display_tbl.php" file.
>>>> All HTML renderings by "echo"s were removed and those HTML was rendered
>>> at
>>>> the bottom of the function at once.
>>>> As well some related functions in "common.lib.php" file also were
>>> modified
>>>> in order to return a string of HTML content.
>>>> But the tests were not yet modified according to my modifications.
>>>> Since there was a conflict after my first local commit [1] (git
>>> commit), I
>>>> had to resolve conflicts and commit again. (that is [0])
>>>>
>>>> I have already installed phpUnit framework.
>>>> It will be very helpful if you can suggest me some documentation to
>>> setup
>>>> and run tests in PMA (selenium etc).
>>>>
>>>> I'm intending to do the above refactoring procedure to all the
>>> functions in
>>>> "display_tbl.lib.php" file before moving to any other task.
>>>>
>>>> [0] :
>>>>
>>> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
>>>> [1] :
>>>>
>>> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
>>>>
>>>> Regards !
>>>
>>> I had a very quick look at your commit. I think that you're indenting
>>> some lines incorrectly (but I stand to be corrected on this one). AFAIK,
>>> you don't need to line up the operators, just indent by 4 spaces. Example:
>>>
>>> // THIS IS BAD
>>> $radio_html .= '<label for="' . $html_field_id . '">'
>>>              . $choice_label
>>>              . '</label>';
>>>
>>> // THIS IS GOOD
>>> $radio_html .= '<label for="' . $html_field_id . '">'
>>>      . $choice_label
>>>      . '</label>';
>>>
>>> // THIS IS ALSO GOOD
>>> $radio_html .= '<label for="' . $html_field_id . '">';
>>> $radio_html .= $choice_label;
>>> $radio_html .= '</label>';
>>>
>>> Bye,
>>> Rouslan
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>
>> Hi Rouslan,
>>
>> Thanks for your suggestion.
>> I'll follow the way you mentioned as "THIS IS GOOD".
>>
>> Regards !
>>
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> In some functions there are pure HTML code snippets. (Ex :-
> PMA_displayTableNavigationOneButton() function in display_tbl.lib.php)
>
> As I feel, its not good to convert all these snippets as PHP string and
> render them. So I'm intending to get those pure HTML snippets into separate
> function. That function can be named as 'PMA_renderTableNavigationForm'
> (for above case).
> What do you think about this ?
>
> As well is there any reason for the phrase 'One' in the function
> "PMA_displayTableNavigation*One*Button()" ?
>
> Regards !

I think that the above example is *exactly* the kind of stuff that needs 
to be converted to strings.

Bye,
Rouslan

Le 2012-05-09 04:39, Chanaka Dharmarathna a écrit :
(...)
> As well is there any reason for the phrase 'One' in the function
> "PMA_displayTableNavigation*One*Button()" ?

Because it displays one button; it could have been originally named
PMA_displayTableNavigationButton().

-- 
Marc Delisle
http://infomarc.info

On Wed, May 9, 2012 at 4:50 PM, Marc Delisle <marc@...> wrote:

> Le 2012-05-09 04:39, Chanaka Dharmarathna a écrit :
> (...)
> > As well is there any reason for the phrase 'One' in the function
> > "PMA_displayTableNavigation*One*Button()" ?
>
> Because it displays one button; it could have been originally named
> PMA_displayTableNavigationButton().
>
> --
> Marc Delisle
> http://infomarc.info
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Marc,

Since it displays only one button, shall I change the name of that function
to "PMA_displayTableNavigationButton()".
Due to the name have phrase 'Button' (not 'Button*s*') I think it increase
the readability and does not over understanding (with some confuse).

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Wed, May 9, 2012 at 2:27 PM, Rouslan Placella <rouslan@...:

> On 09/05/12 09:39, Chanaka Dharmarathna wrote:
> > On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
> > pe.chanaka.ck@...>  wrote:
> >
> >>
> >>
> >> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<rouslan@...
> >wrote:
> >>
> >>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
> >>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
> >>>> pe.chanaka.ck@...>   wrote:
> >>>>
> >>>>>
> >>>>>
> >>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
> >>>   wrote:
> >>>>>
> >>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
> >>>>>>
> >>>>>>>>
> >>>>>>>> See "Class Variables and Methods" in [0].
> >>>>>>>>
> >>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
> >>>>>>
> >>>>>>> Hi Marc,
> >>>>>>>
> >>>>>>> I went through that document.
> >>>>>>> If the function is global, it will be like
> >>> 'PMA_getDivForSliderEffect()'
> >>>>>>> And if it is a local function (for particular class), it will be
> like
> >>>>>>> 'getDivForSliderEffect()'.
> >>>>>>
> >>>>>> If this is a public method, yes. If a private one, prefix its name
> >>> with
> >>>>>> an underscore.
> >>>>>>
> >>>>>>>
> >>>>>>> Though I went through that document before this, I couldn't get
> that
> >>>>>> point.
> >>>>>>> Thanks for pointing out that.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> Marc Delisle
> >>>>>> http://infomarc.info
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>
> ------------------------------------------------------------------------------
> >>>>>> Live Security Virtual Conference
> >>>>>> Exclusive live event will cover all the ways today's security and
> >>>>>> threat landscape has changed and how IT managers can respond.
> >>> Discussions
> >>>>>> will include endpoint security, mobile security and the latest in
> >>> malware
> >>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>>>> _______________________________________________
> >>>>>> Phpmyadmin-devel mailing list
> >>>>>> Phpmyadmin-devel@...
> >>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>>>
> >>>>>>
> >>>>> Got it Marc.
> >>>>> Thanks.
> >>>>>
> >>>>>
> >>>>> --
> >>>>> ____________________________________
> >>>>>
> >>>>> Chanaka Indrajith
> >>>>> Bsc.Computer Engineering Undergraduate
> >>>>> Faculty of Engineering
> >>>>> University of Peradeniya
> >>>>> Sri Lanka
> >>>>> ____________________________________
> >>>>>
> >>>>>
> >>>> Hi Michal,
> >>>>
> >>>> I just did my first commit to my repository [0].
> >>>> In that commit I have done some refactoring on
> >>> "PMA_displayTableHeaders()"
> >>>> function in "display_tbl.php" file.
> >>>> All HTML renderings by "echo"s were removed and those HTML was
> rendered
> >>> at
> >>>> the bottom of the function at once.
> >>>> As well some related functions in "common.lib.php" file also were
> >>> modified
> >>>> in order to return a string of HTML content.
> >>>> But the tests were not yet modified according to my modifications.
> >>>> Since there was a conflict after my first local commit [1] (git
> >>> commit), I
> >>>> had to resolve conflicts and commit again. (that is [0])
> >>>>
> >>>> I have already installed phpUnit framework.
> >>>> It will be very helpful if you can suggest me some documentation to
> >>> setup
> >>>> and run tests in PMA (selenium etc).
> >>>>
> >>>> I'm intending to do the above refactoring procedure to all the
> >>> functions in
> >>>> "display_tbl.lib.php" file before moving to any other task.
> >>>>
> >>>> [0] :
> >>>>
> >>>
> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
> >>>> [1] :
> >>>>
> >>>
> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
> >>>>
> >>>> Regards !
> >>>
> >>> I had a very quick look at your commit. I think that you're indenting
> >>> some lines incorrectly (but I stand to be corrected on this one).
> AFAIK,
> >>> you don't need to line up the operators, just indent by 4 spaces.
> Example:
> >>>
> >>> // THIS IS BAD
> >>> $radio_html .= '<label for="' . $html_field_id . '">'
> >>>              . $choice_label
> >>>              . '</label>';
> >>>
> >>> // THIS IS GOOD
> >>> $radio_html .= '<label for="' . $html_field_id . '">'
> >>>      . $choice_label
> >>>      . '</label>';
> >>>
> >>> // THIS IS ALSO GOOD
> >>> $radio_html .= '<label for="' . $html_field_id . '">';
> >>> $radio_html .= $choice_label;
> >>> $radio_html .= '</label>';
> >>>
> >>> Bye,
> >>> Rouslan
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Live Security Virtual Conference
> >>> Exclusive live event will cover all the ways today's security and
> >>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>> will include endpoint security, mobile security and the latest in
> malware
> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>> _______________________________________________
> >>> Phpmyadmin-devel mailing list
> >>> Phpmyadmin-devel@...
> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>
> >>
> >> Hi Rouslan,
> >>
> >> Thanks for your suggestion.
> >> I'll follow the way you mentioned as "THIS IS GOOD".
> >>
> >> Regards !
> >>
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >>
> > Hi Michal,
> >
> > In some functions there are pure HTML code snippets. (Ex :-
> > PMA_displayTableNavigationOneButton() function in display_tbl.lib.php)
> >
> > As I feel, its not good to convert all these snippets as PHP string and
> > render them. So I'm intending to get those pure HTML snippets into
> separate
> > function. That function can be named as 'PMA_renderTableNavigationForm'
> > (for above case).
> > What do you think about this ?
> >
> > As well is there any reason for the phrase 'One' in the function
> > "PMA_displayTableNavigation*One*Button()" ?
> >
> > Regards !
>
> I think that the above example is *exactly* the kind of stuff that needs
> to be converted to strings.
>
> Bye,
> Rouslan
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Rouslan,

I have little doubt of the way I understand your point.

You are suggesting to render HTML content by PHP string, instead of using
pure HTML, though there is nicely placed HTML code snippets. (around 5, 6
lines)
Am I correct Rouslan ? Sorry if I'm repeat the wheel.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Le 2012-05-09 15:57, Chanaka Dharmarathna a écrit :
> On Wed, May 9, 2012 at 4:50 PM, Marc Delisle <marc@...> wrote:
> 
>> Le 2012-05-09 04:39, Chanaka Dharmarathna a écrit :
>> (...)
>>> As well is there any reason for the phrase 'One' in the function
>>> "PMA_displayTableNavigation*One*Button()" ?
>>
>> Because it displays one button; it could have been originally named
>> PMA_displayTableNavigationButton().

> Hi Marc,
> 
> Since it displays only one button, shall I change the name of that function
> to "PMA_displayTableNavigationButton()".
> Due to the name have phrase 'Button' (not 'Button*s*') I think it increase
> the readability and does not over understanding (with some confuse).
> 
> Regards !

Hi Chanaka,
sure.

-- 
Marc Delisle
http://infomarc.info

On 09/05/12 21:08, Chanaka Dharmarathna wrote:
> On Wed, May 9, 2012 at 2:27 PM, Rouslan Placella<rouslan@...:
>
>> On 09/05/12 09:39, Chanaka Dharmarathna wrote:
>>> On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
>>> pe.chanaka.ck@...>   wrote:
>>>
>>>>
>>>>
>>>> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<rouslan@...
>>> wrote:
>>>>
>>>>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
>>>>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
>>>>>> pe.chanaka.ck@...>    wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
>>>>>    wrote:
>>>>>>>
>>>>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> See "Class Variables and Methods" in [0].
>>>>>>>>>>
>>>>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
>>>>>>>>
>>>>>>>>> Hi Marc,
>>>>>>>>>
>>>>>>>>> I went through that document.
>>>>>>>>> If the function is global, it will be like
>>>>> 'PMA_getDivForSliderEffect()'
>>>>>>>>> And if it is a local function (for particular class), it will be
>> like
>>>>>>>>> 'getDivForSliderEffect()'.
>>>>>>>>
>>>>>>>> If this is a public method, yes. If a private one, prefix its name
>>>>> with
>>>>>>>> an underscore.
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Though I went through that document before this, I couldn't get
>> that
>>>>>>>> point.
>>>>>>>>> Thanks for pointing out that.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Marc Delisle
>>>>>>>> http://infomarc.info
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>
>> ------------------------------------------------------------------------------
>>>>>>>> Live Security Virtual Conference
>>>>>>>> Exclusive live event will cover all the ways today's security and
>>>>>>>> threat landscape has changed and how IT managers can respond.
>>>>> Discussions
>>>>>>>> will include endpoint security, mobile security and the latest in
>>>>> malware
>>>>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>>>>>> _______________________________________________
>>>>>>>> Phpmyadmin-devel mailing list
>>>>>>>> Phpmyadmin-devel@...
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>>>>>
>>>>>>>>
>>>>>>> Got it Marc.
>>>>>>> Thanks.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> ____________________________________
>>>>>>>
>>>>>>> Chanaka Indrajith
>>>>>>> Bsc.Computer Engineering Undergraduate
>>>>>>> Faculty of Engineering
>>>>>>> University of Peradeniya
>>>>>>> Sri Lanka
>>>>>>> ____________________________________
>>>>>>>
>>>>>>>
>>>>>> Hi Michal,
>>>>>>
>>>>>> I just did my first commit to my repository [0].
>>>>>> In that commit I have done some refactoring on
>>>>> "PMA_displayTableHeaders()"
>>>>>> function in "display_tbl.php" file.
>>>>>> All HTML renderings by "echo"s were removed and those HTML was
>> rendered
>>>>> at
>>>>>> the bottom of the function at once.
>>>>>> As well some related functions in "common.lib.php" file also were
>>>>> modified
>>>>>> in order to return a string of HTML content.
>>>>>> But the tests were not yet modified according to my modifications.
>>>>>> Since there was a conflict after my first local commit [1] (git
>>>>> commit), I
>>>>>> had to resolve conflicts and commit again. (that is [0])
>>>>>>
>>>>>> I have already installed phpUnit framework.
>>>>>> It will be very helpful if you can suggest me some documentation to
>>>>> setup
>>>>>> and run tests in PMA (selenium etc).
>>>>>>
>>>>>> I'm intending to do the above refactoring procedure to all the
>>>>> functions in
>>>>>> "display_tbl.lib.php" file before moving to any other task.
>>>>>>
>>>>>> [0] :
>>>>>>
>>>>>
>> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
>>>>>> [1] :
>>>>>>
>>>>>
>> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
>>>>>>
>>>>>> Regards !
>>>>>
>>>>> I had a very quick look at your commit. I think that you're indenting
>>>>> some lines incorrectly (but I stand to be corrected on this one).
>> AFAIK,
>>>>> you don't need to line up the operators, just indent by 4 spaces.
>> Example:
>>>>>
>>>>> // THIS IS BAD
>>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>>>>>               . $choice_label
>>>>>               . '</label>';
>>>>>
>>>>> // THIS IS GOOD
>>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>>>>>       . $choice_label
>>>>>       . '</label>';
>>>>>
>>>>> // THIS IS ALSO GOOD
>>>>> $radio_html .= '<label for="' . $html_field_id . '">';
>>>>> $radio_html .= $choice_label;
>>>>> $radio_html .= '</label>';
>>>>>
>>>>> Bye,
>>>>> Rouslan
>>>>>
>>>>>
>>>>>
>> ------------------------------------------------------------------------------
>>>>> Live Security Virtual Conference
>>>>> Exclusive live event will cover all the ways today's security and
>>>>> threat landscape has changed and how IT managers can respond.
>> Discussions
>>>>> will include endpoint security, mobile security and the latest in
>> malware
>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>>> _______________________________________________
>>>>> Phpmyadmin-devel mailing list
>>>>> Phpmyadmin-devel@...
>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>>
>>>>
>>>> Hi Rouslan,
>>>>
>>>> Thanks for your suggestion.
>>>> I'll follow the way you mentioned as "THIS IS GOOD".
>>>>
>>>> Regards !
>>>>
>>>> --
>>>> ____________________________________
>>>>
>>>> Chanaka Indrajith
>>>> Bsc.Computer Engineering Undergraduate
>>>> Faculty of Engineering
>>>> University of Peradeniya
>>>> Sri Lanka
>>>> ____________________________________
>>>>
>>>>
>>> Hi Michal,
>>>
>>> In some functions there are pure HTML code snippets. (Ex :-
>>> PMA_displayTableNavigationOneButton() function in display_tbl.lib.php)
>>>
>>> As I feel, its not good to convert all these snippets as PHP string and
>>> render them. So I'm intending to get those pure HTML snippets into
>> separate
>>> function. That function can be named as 'PMA_renderTableNavigationForm'
>>> (for above case).
>>> What do you think about this ?
>>>
>>> As well is there any reason for the phrase 'One' in the function
>>> "PMA_displayTableNavigation*One*Button()" ?
>>>
>>> Regards !
>>
>> I think that the above example is *exactly* the kind of stuff that needs
>> to be converted to strings.
>>
>> Bye,
>> Rouslan
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>
> Hi Rouslan,
>
> I have little doubt of the way I understand your point.
>
> You are suggesting to render HTML content by PHP string, instead of using
> pure HTML, though there is nicely placed HTML code snippets. (around 5, 6
> lines)
> Am I correct Rouslan ? Sorry if I'm repeat the wheel.

Yes, that's correct. And I don't thing that those lines are nice at all.

Bye,
Rouslan

On Fri, May 11, 2012 at 12:39 AM, Rouslan Placella <rouslan@...:

> On 09/05/12 21:08, Chanaka Dharmarathna wrote:
> > On Wed, May 9, 2012 at 2:27 PM, Rouslan Placella<rouslan@...
> >wrote:
> >
> >> On 09/05/12 09:39, Chanaka Dharmarathna wrote:
> >>> On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
> >>> pe.chanaka.ck@...>   wrote:
> >>>
> >>>>
> >>>>
> >>>> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<rouslan@...
> >>> wrote:
> >>>>
> >>>>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
> >>>>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
> >>>>>> pe.chanaka.ck@...>    wrote:
> >>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
> >>>>>    wrote:
> >>>>>>>
> >>>>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
> >>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> See "Class Variables and Methods" in [0].
> >>>>>>>>>>
> >>>>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
> >>>>>>>>
> >>>>>>>>> Hi Marc,
> >>>>>>>>>
> >>>>>>>>> I went through that document.
> >>>>>>>>> If the function is global, it will be like
> >>>>> 'PMA_getDivForSliderEffect()'
> >>>>>>>>> And if it is a local function (for particular class), it will be
> >> like
> >>>>>>>>> 'getDivForSliderEffect()'.
> >>>>>>>>
> >>>>>>>> If this is a public method, yes. If a private one, prefix its name
> >>>>> with
> >>>>>>>> an underscore.
> >>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Though I went through that document before this, I couldn't get
> >> that
> >>>>>>>> point.
> >>>>>>>>> Thanks for pointing out that.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Marc Delisle
> >>>>>>>> http://infomarc.info
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>
> >>
> ------------------------------------------------------------------------------
> >>>>>>>> Live Security Virtual Conference
> >>>>>>>> Exclusive live event will cover all the ways today's security and
> >>>>>>>> threat landscape has changed and how IT managers can respond.
> >>>>> Discussions
> >>>>>>>> will include endpoint security, mobile security and the latest in
> >>>>> malware
> >>>>>>>> threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>>>>>> _______________________________________________
> >>>>>>>> Phpmyadmin-devel mailing list
> >>>>>>>> Phpmyadmin-devel@...
> >>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>>>>>
> >>>>>>>>
> >>>>>>> Got it Marc.
> >>>>>>> Thanks.
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> ____________________________________
> >>>>>>>
> >>>>>>> Chanaka Indrajith
> >>>>>>> Bsc.Computer Engineering Undergraduate
> >>>>>>> Faculty of Engineering
> >>>>>>> University of Peradeniya
> >>>>>>> Sri Lanka
> >>>>>>> ____________________________________
> >>>>>>>
> >>>>>>>
> >>>>>> Hi Michal,
> >>>>>>
> >>>>>> I just did my first commit to my repository [0].
> >>>>>> In that commit I have done some refactoring on
> >>>>> "PMA_displayTableHeaders()"
> >>>>>> function in "display_tbl.php" file.
> >>>>>> All HTML renderings by "echo"s were removed and those HTML was
> >> rendered
> >>>>> at
> >>>>>> the bottom of the function at once.
> >>>>>> As well some related functions in "common.lib.php" file also were
> >>>>> modified
> >>>>>> in order to return a string of HTML content.
> >>>>>> But the tests were not yet modified according to my modifications.
> >>>>>> Since there was a conflict after my first local commit [1] (git
> >>>>> commit), I
> >>>>>> had to resolve conflicts and commit again. (that is [0])
> >>>>>>
> >>>>>> I have already installed phpUnit framework.
> >>>>>> It will be very helpful if you can suggest me some documentation to
> >>>>> setup
> >>>>>> and run tests in PMA (selenium etc).
> >>>>>>
> >>>>>> I'm intending to do the above refactoring procedure to all the
> >>>>> functions in
> >>>>>> "display_tbl.lib.php" file before moving to any other task.
> >>>>>>
> >>>>>> [0] :
> >>>>>>
> >>>>>
> >>
> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
> >>>>>> [1] :
> >>>>>>
> >>>>>
> >>
> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
> >>>>>>
> >>>>>> Regards !
> >>>>>
> >>>>> I had a very quick look at your commit. I think that you're indenting
> >>>>> some lines incorrectly (but I stand to be corrected on this one).
> >> AFAIK,
> >>>>> you don't need to line up the operators, just indent by 4 spaces.
> >> Example:
> >>>>>
> >>>>> // THIS IS BAD
> >>>>> $radio_html .= '<label for="' . $html_field_id . '">'
> >>>>>               . $choice_label
> >>>>>               . '</label>';
> >>>>>
> >>>>> // THIS IS GOOD
> >>>>> $radio_html .= '<label for="' . $html_field_id . '">'
> >>>>>       . $choice_label
> >>>>>       . '</label>';
> >>>>>
> >>>>> // THIS IS ALSO GOOD
> >>>>> $radio_html .= '<label for="' . $html_field_id . '">';
> >>>>> $radio_html .= $choice_label;
> >>>>> $radio_html .= '</label>';
> >>>>>
> >>>>> Bye,
> >>>>> Rouslan
> >>>>>
> >>>>>
> >>>>>
> >>
> ------------------------------------------------------------------------------
> >>>>> Live Security Virtual Conference
> >>>>> Exclusive live event will cover all the ways today's security and
> >>>>> threat landscape has changed and how IT managers can respond.
> >> Discussions
> >>>>> will include endpoint security, mobile security and the latest in
> >> malware
> >>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>>> _______________________________________________
> >>>>> Phpmyadmin-devel mailing list
> >>>>> Phpmyadmin-devel@...
> >>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>>
> >>>>
> >>>> Hi Rouslan,
> >>>>
> >>>> Thanks for your suggestion.
> >>>> I'll follow the way you mentioned as "THIS IS GOOD".
> >>>>
> >>>> Regards !
> >>>>
> >>>> --
> >>>> ____________________________________
> >>>>
> >>>> Chanaka Indrajith
> >>>> Bsc.Computer Engineering Undergraduate
> >>>> Faculty of Engineering
> >>>> University of Peradeniya
> >>>> Sri Lanka
> >>>> ____________________________________
> >>>>
> >>>>
> >>> Hi Michal,
> >>>
> >>> In some functions there are pure HTML code snippets. (Ex :-
> >>> PMA_displayTableNavigationOneButton() function in display_tbl.lib.php)
> >>>
> >>> As I feel, its not good to convert all these snippets as PHP string and
> >>> render them. So I'm intending to get those pure HTML snippets into
> >> separate
> >>> function. That function can be named as 'PMA_renderTableNavigationForm'
> >>> (for above case).
> >>> What do you think about this ?
> >>>
> >>> As well is there any reason for the phrase 'One' in the function
> >>> "PMA_displayTableNavigation*One*Button()" ?
> >>>
> >>> Regards !
> >>
> >> I think that the above example is *exactly* the kind of stuff that needs
> >> to be converted to strings.
> >>
> >> Bye,
> >> Rouslan
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> Live Security Virtual Conference
> >> Exclusive live event will cover all the ways today's security and
> >> threat landscape has changed and how IT managers can respond.
> Discussions
> >> will include endpoint security, mobile security and the latest in
> malware
> >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >> _______________________________________________
> >> Phpmyadmin-devel mailing list
> >> Phpmyadmin-devel@...
> >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>
> >
> > Hi Rouslan,
> >
> > I have little doubt of the way I understand your point.
> >
> > You are suggesting to render HTML content by PHP string, instead of using
> > pure HTML, though there is nicely placed HTML code snippets. (around 5, 6
> > lines)
> > Am I correct Rouslan ? Sorry if I'm repeat the wheel.
>
> Yes, that's correct. And I don't thing that those lines are nice at all.
>
> Bye,
> Rouslan
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Rouslan,

I was already thinking of do the same thing you pointed.
It will cause some sort of problems if I do the previous thing I suggested.
Thanks for your help.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Fri, May 11, 2012 at 7:05 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Fri, May 11, 2012 at 12:39 AM, Rouslan Placella <rouslan@...:
>
>> On 09/05/12 21:08, Chanaka Dharmarathna wrote:
>> > On Wed, May 9, 2012 at 2:27 PM, Rouslan Placella<rouslan@...
>> >wrote:
>> >
>> >> On 09/05/12 09:39, Chanaka Dharmarathna wrote:
>> >>> On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
>> >>> pe.chanaka.ck@...>   wrote:
>> >>>
>> >>>>
>> >>>>
>> >>>> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<
>> rouslan@...
>> >>> wrote:
>> >>>>
>> >>>>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
>> >>>>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
>> >>>>>> pe.chanaka.ck@...>    wrote:
>> >>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
>> >>>>>    wrote:
>> >>>>>>>
>> >>>>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>> >>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>> See "Class Variables and Methods" in [0].
>> >>>>>>>>>>
>> >>>>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
>> >>>>>>>>
>> >>>>>>>>> Hi Marc,
>> >>>>>>>>>
>> >>>>>>>>> I went through that document.
>> >>>>>>>>> If the function is global, it will be like
>> >>>>> 'PMA_getDivForSliderEffect()'
>> >>>>>>>>> And if it is a local function (for particular class), it will be
>> >> like
>> >>>>>>>>> 'getDivForSliderEffect()'.
>> >>>>>>>>
>> >>>>>>>> If this is a public method, yes. If a private one, prefix its
>> name
>> >>>>> with
>> >>>>>>>> an underscore.
>> >>>>>>>>
>> >>>>>>>>>
>> >>>>>>>>> Though I went through that document before this, I couldn't get
>> >> that
>> >>>>>>>> point.
>> >>>>>>>>> Thanks for pointing out that.
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> --
>> >>>>>>>> Marc Delisle
>> >>>>>>>> http://infomarc.info
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>
>> >>
>> ------------------------------------------------------------------------------
>> >>>>>>>> Live Security Virtual Conference
>> >>>>>>>> Exclusive live event will cover all the ways today's security and
>> >>>>>>>> threat landscape has changed and how IT managers can respond.
>> >>>>> Discussions
>> >>>>>>>> will include endpoint security, mobile security and the latest in
>> >>>>> malware
>> >>>>>>>> threats.
>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>>>>>>> _______________________________________________
>> >>>>>>>> Phpmyadmin-devel mailing list
>> >>>>>>>> Phpmyadmin-devel@...
>> >>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>> Got it Marc.
>> >>>>>>> Thanks.
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> --
>> >>>>>>> ____________________________________
>> >>>>>>>
>> >>>>>>> Chanaka Indrajith
>> >>>>>>> Bsc.Computer Engineering Undergraduate
>> >>>>>>> Faculty of Engineering
>> >>>>>>> University of Peradeniya
>> >>>>>>> Sri Lanka
>> >>>>>>> ____________________________________
>> >>>>>>>
>> >>>>>>>
>> >>>>>> Hi Michal,
>> >>>>>>
>> >>>>>> I just did my first commit to my repository [0].
>> >>>>>> In that commit I have done some refactoring on
>> >>>>> "PMA_displayTableHeaders()"
>> >>>>>> function in "display_tbl.php" file.
>> >>>>>> All HTML renderings by "echo"s were removed and those HTML was
>> >> rendered
>> >>>>> at
>> >>>>>> the bottom of the function at once.
>> >>>>>> As well some related functions in "common.lib.php" file also were
>> >>>>> modified
>> >>>>>> in order to return a string of HTML content.
>> >>>>>> But the tests were not yet modified according to my modifications.
>> >>>>>> Since there was a conflict after my first local commit [1] (git
>> >>>>> commit), I
>> >>>>>> had to resolve conflicts and commit again. (that is [0])
>> >>>>>>
>> >>>>>> I have already installed phpUnit framework.
>> >>>>>> It will be very helpful if you can suggest me some documentation to
>> >>>>> setup
>> >>>>>> and run tests in PMA (selenium etc).
>> >>>>>>
>> >>>>>> I'm intending to do the above refactoring procedure to all the
>> >>>>> functions in
>> >>>>>> "display_tbl.lib.php" file before moving to any other task.
>> >>>>>>
>> >>>>>> [0] :
>> >>>>>>
>> >>>>>
>> >>
>> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
>> >>>>>> [1] :
>> >>>>>>
>> >>>>>
>> >>
>> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
>> >>>>>>
>> >>>>>> Regards !
>> >>>>>
>> >>>>> I had a very quick look at your commit. I think that you're
>> indenting
>> >>>>> some lines incorrectly (but I stand to be corrected on this one).
>> >> AFAIK,
>> >>>>> you don't need to line up the operators, just indent by 4 spaces.
>> >> Example:
>> >>>>>
>> >>>>> // THIS IS BAD
>> >>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>> >>>>>               . $choice_label
>> >>>>>               . '</label>';
>> >>>>>
>> >>>>> // THIS IS GOOD
>> >>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>> >>>>>       . $choice_label
>> >>>>>       . '</label>';
>> >>>>>
>> >>>>> // THIS IS ALSO GOOD
>> >>>>> $radio_html .= '<label for="' . $html_field_id . '">';
>> >>>>> $radio_html .= $choice_label;
>> >>>>> $radio_html .= '</label>';
>> >>>>>
>> >>>>> Bye,
>> >>>>> Rouslan
>> >>>>>
>> >>>>>
>> >>>>>
>> >>
>> ------------------------------------------------------------------------------
>> >>>>> Live Security Virtual Conference
>> >>>>> Exclusive live event will cover all the ways today's security and
>> >>>>> threat landscape has changed and how IT managers can respond.
>> >> Discussions
>> >>>>> will include endpoint security, mobile security and the latest in
>> >> malware
>> >>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>>>> _______________________________________________
>> >>>>> Phpmyadmin-devel mailing list
>> >>>>> Phpmyadmin-devel@...
>> >>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>>>
>> >>>>
>> >>>> Hi Rouslan,
>> >>>>
>> >>>> Thanks for your suggestion.
>> >>>> I'll follow the way you mentioned as "THIS IS GOOD".
>> >>>>
>> >>>> Regards !
>> >>>>
>> >>>> --
>> >>>> ____________________________________
>> >>>>
>> >>>> Chanaka Indrajith
>> >>>> Bsc.Computer Engineering Undergraduate
>> >>>> Faculty of Engineering
>> >>>> University of Peradeniya
>> >>>> Sri Lanka
>> >>>> ____________________________________
>> >>>>
>> >>>>
>> >>> Hi Michal,
>> >>>
>> >>> In some functions there are pure HTML code snippets. (Ex :-
>> >>> PMA_displayTableNavigationOneButton() function in display_tbl.lib.php)
>> >>>
>> >>> As I feel, its not good to convert all these snippets as PHP string
>> and
>> >>> render them. So I'm intending to get those pure HTML snippets into
>> >> separate
>> >>> function. That function can be named as
>> 'PMA_renderTableNavigationForm'
>> >>> (for above case).
>> >>> What do you think about this ?
>> >>>
>> >>> As well is there any reason for the phrase 'One' in the function
>> >>> "PMA_displayTableNavigation*One*Button()" ?
>> >>>
>> >>> Regards !
>> >>
>> >> I think that the above example is *exactly* the kind of stuff that
>> needs
>> >> to be converted to strings.
>> >>
>> >> Bye,
>> >> Rouslan
>> >>
>> >>
>> >>
>> ------------------------------------------------------------------------------
>> >> Live Security Virtual Conference
>> >> Exclusive live event will cover all the ways today's security and
>> >> threat landscape has changed and how IT managers can respond.
>> Discussions
>> >> will include endpoint security, mobile security and the latest in
>> malware
>> >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >> _______________________________________________
>> >> Phpmyadmin-devel mailing list
>> >> Phpmyadmin-devel@...
>> >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>
>> >
>> > Hi Rouslan,
>> >
>> > I have little doubt of the way I understand your point.
>> >
>> > You are suggesting to render HTML content by PHP string, instead of
>> using
>> > pure HTML, though there is nicely placed HTML code snippets. (around 5,
>> 6
>> > lines)
>> > Am I correct Rouslan ? Sorry if I'm repeat the wheel.
>>
>> Yes, that's correct. And I don't thing that those lines are nice at all.
>>
>> Bye,
>> Rouslan
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>
> Hi Rouslan,
>
> I was already thinking of do the same thing you pointed.
> It will cause some sort of problems if I do the previous thing I suggested.
> Thanks for your help.
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

The function "PMA_displayTableBody()" in display_tbl.lib.php is always
return true.
But it does not seems like, useful for other place where it have been used.
(Used only in "PMA_displayTable()" function in same file)

Inside "PMA_displayTable()" function it just assign the return value (true)
to variable called '$clause_is_unique'.
And variable is only used at one place. it is,

echo '<input type="hidden" name="clause_is_unique"'
            .' value="' . *$clause_is_unique* . '" />' . "\n";

So, if this always return true, why don't we hard code true in the above
case.
And modify the "PMA_displayTableBody()" function to return string of html
content.

Am I going wrong ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Fri, May 11, 2012 at 11:12 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Fri, May 11, 2012 at 7:05 AM, Chanaka Dharmarathna <
> pe.chanaka.ck@...> wrote:
>
>>
>>
>> On Fri, May 11, 2012 at 12:39 AM, Rouslan Placella <rouslan@...:
>>
>>> On 09/05/12 21:08, Chanaka Dharmarathna wrote:
>>> > On Wed, May 9, 2012 at 2:27 PM, Rouslan Placella<rouslan@...
>>> >wrote:
>>> >
>>> >> On 09/05/12 09:39, Chanaka Dharmarathna wrote:
>>> >>> On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
>>> >>> pe.chanaka.ck@...>   wrote:
>>> >>>
>>> >>>>
>>> >>>>
>>> >>>> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<
>>> rouslan@...
>>> >>> wrote:
>>> >>>>
>>> >>>>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
>>> >>>>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
>>> >>>>>> pe.chanaka.ck@...>    wrote:
>>> >>>>>>
>>> >>>>>>>
>>> >>>>>>>
>>> >>>>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
>>> >>>>>    wrote:
>>> >>>>>>>
>>> >>>>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>>> >>>>>>>>
>>> >>>>>>>>>>
>>> >>>>>>>>>> See "Class Variables and Methods" in [0].
>>> >>>>>>>>>>
>>> >>>>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
>>> >>>>>>>>
>>> >>>>>>>>> Hi Marc,
>>> >>>>>>>>>
>>> >>>>>>>>> I went through that document.
>>> >>>>>>>>> If the function is global, it will be like
>>> >>>>> 'PMA_getDivForSliderEffect()'
>>> >>>>>>>>> And if it is a local function (for particular class), it will
>>> be
>>> >> like
>>> >>>>>>>>> 'getDivForSliderEffect()'.
>>> >>>>>>>>
>>> >>>>>>>> If this is a public method, yes. If a private one, prefix its
>>> name
>>> >>>>> with
>>> >>>>>>>> an underscore.
>>> >>>>>>>>
>>> >>>>>>>>>
>>> >>>>>>>>> Though I went through that document before this, I couldn't get
>>> >> that
>>> >>>>>>>> point.
>>> >>>>>>>>> Thanks for pointing out that.
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>> --
>>> >>>>>>>> Marc Delisle
>>> >>>>>>>> http://infomarc.info
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>
>>> >>
>>> ------------------------------------------------------------------------------
>>> >>>>>>>> Live Security Virtual Conference
>>> >>>>>>>> Exclusive live event will cover all the ways today's security
>>> and
>>> >>>>>>>> threat landscape has changed and how IT managers can respond.
>>> >>>>> Discussions
>>> >>>>>>>> will include endpoint security, mobile security and the latest
>>> in
>>> >>>>> malware
>>> >>>>>>>> threats.
>>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> >>>>>>>> _______________________________________________
>>> >>>>>>>> Phpmyadmin-devel mailing list
>>> >>>>>>>> Phpmyadmin-devel@...
>>> >>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>> >>>>>>>>
>>> >>>>>>>>
>>> >>>>>>> Got it Marc.
>>> >>>>>>> Thanks.
>>> >>>>>>>
>>> >>>>>>>
>>> >>>>>>> --
>>> >>>>>>> ____________________________________
>>> >>>>>>>
>>> >>>>>>> Chanaka Indrajith
>>> >>>>>>> Bsc.Computer Engineering Undergraduate
>>> >>>>>>> Faculty of Engineering
>>> >>>>>>> University of Peradeniya
>>> >>>>>>> Sri Lanka
>>> >>>>>>> ____________________________________
>>> >>>>>>>
>>> >>>>>>>
>>> >>>>>> Hi Michal,
>>> >>>>>>
>>> >>>>>> I just did my first commit to my repository [0].
>>> >>>>>> In that commit I have done some refactoring on
>>> >>>>> "PMA_displayTableHeaders()"
>>> >>>>>> function in "display_tbl.php" file.
>>> >>>>>> All HTML renderings by "echo"s were removed and those HTML was
>>> >> rendered
>>> >>>>> at
>>> >>>>>> the bottom of the function at once.
>>> >>>>>> As well some related functions in "common.lib.php" file also were
>>> >>>>> modified
>>> >>>>>> in order to return a string of HTML content.
>>> >>>>>> But the tests were not yet modified according to my modifications.
>>> >>>>>> Since there was a conflict after my first local commit [1] (git
>>> >>>>> commit), I
>>> >>>>>> had to resolve conflicts and commit again. (that is [0])
>>> >>>>>>
>>> >>>>>> I have already installed phpUnit framework.
>>> >>>>>> It will be very helpful if you can suggest me some documentation
>>> to
>>> >>>>> setup
>>> >>>>>> and run tests in PMA (selenium etc).
>>> >>>>>>
>>> >>>>>> I'm intending to do the above refactoring procedure to all the
>>> >>>>> functions in
>>> >>>>>> "display_tbl.lib.php" file before moving to any other task.
>>> >>>>>>
>>> >>>>>> [0] :
>>> >>>>>>
>>> >>>>>
>>> >>
>>> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
>>> >>>>>> [1] :
>>> >>>>>>
>>> >>>>>
>>> >>
>>> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
>>> >>>>>>
>>> >>>>>> Regards !
>>> >>>>>
>>> >>>>> I had a very quick look at your commit. I think that you're
>>> indenting
>>> >>>>> some lines incorrectly (but I stand to be corrected on this one).
>>> >> AFAIK,
>>> >>>>> you don't need to line up the operators, just indent by 4 spaces.
>>> >> Example:
>>> >>>>>
>>> >>>>> // THIS IS BAD
>>> >>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>>> >>>>>               . $choice_label
>>> >>>>>               . '</label>';
>>> >>>>>
>>> >>>>> // THIS IS GOOD
>>> >>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>>> >>>>>       . $choice_label
>>> >>>>>       . '</label>';
>>> >>>>>
>>> >>>>> // THIS IS ALSO GOOD
>>> >>>>> $radio_html .= '<label for="' . $html_field_id . '">';
>>> >>>>> $radio_html .= $choice_label;
>>> >>>>> $radio_html .= '</label>';
>>> >>>>>
>>> >>>>> Bye,
>>> >>>>> Rouslan
>>> >>>>>
>>> >>>>>
>>> >>>>>
>>> >>
>>> ------------------------------------------------------------------------------
>>> >>>>> Live Security Virtual Conference
>>> >>>>> Exclusive live event will cover all the ways today's security and
>>> >>>>> threat landscape has changed and how IT managers can respond.
>>> >> Discussions
>>> >>>>> will include endpoint security, mobile security and the latest in
>>> >> malware
>>> >>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> >>>>> _______________________________________________
>>> >>>>> Phpmyadmin-devel mailing list
>>> >>>>> Phpmyadmin-devel@...
>>> >>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>> >>>>>
>>> >>>>
>>> >>>> Hi Rouslan,
>>> >>>>
>>> >>>> Thanks for your suggestion.
>>> >>>> I'll follow the way you mentioned as "THIS IS GOOD".
>>> >>>>
>>> >>>> Regards !
>>> >>>>
>>> >>>> --
>>> >>>> ____________________________________
>>> >>>>
>>> >>>> Chanaka Indrajith
>>> >>>> Bsc.Computer Engineering Undergraduate
>>> >>>> Faculty of Engineering
>>> >>>> University of Peradeniya
>>> >>>> Sri Lanka
>>> >>>> ____________________________________
>>> >>>>
>>> >>>>
>>> >>> Hi Michal,
>>> >>>
>>> >>> In some functions there are pure HTML code snippets. (Ex :-
>>> >>> PMA_displayTableNavigationOneButton() function in
>>> display_tbl.lib.php)
>>> >>>
>>> >>> As I feel, its not good to convert all these snippets as PHP string
>>> and
>>> >>> render them. So I'm intending to get those pure HTML snippets into
>>> >> separate
>>> >>> function. That function can be named as
>>> 'PMA_renderTableNavigationForm'
>>> >>> (for above case).
>>> >>> What do you think about this ?
>>> >>>
>>> >>> As well is there any reason for the phrase 'One' in the function
>>> >>> "PMA_displayTableNavigation*One*Button()" ?
>>> >>>
>>> >>> Regards !
>>> >>
>>> >> I think that the above example is *exactly* the kind of stuff that
>>> needs
>>> >> to be converted to strings.
>>> >>
>>> >> Bye,
>>> >> Rouslan
>>> >>
>>> >>
>>> >>
>>> ------------------------------------------------------------------------------
>>> >> Live Security Virtual Conference
>>> >> Exclusive live event will cover all the ways today's security and
>>> >> threat landscape has changed and how IT managers can respond.
>>> Discussions
>>> >> will include endpoint security, mobile security and the latest in
>>> malware
>>> >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> >> _______________________________________________
>>> >> Phpmyadmin-devel mailing list
>>> >> Phpmyadmin-devel@...
>>> >> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>> >>
>>> >
>>> > Hi Rouslan,
>>> >
>>> > I have little doubt of the way I understand your point.
>>> >
>>> > You are suggesting to render HTML content by PHP string, instead of
>>> using
>>> > pure HTML, though there is nicely placed HTML code snippets. (around
>>> 5, 6
>>> > lines)
>>> > Am I correct Rouslan ? Sorry if I'm repeat the wheel.
>>>
>>> Yes, that's correct. And I don't thing that those lines are nice at all.
>>>
>>> Bye,
>>> Rouslan
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>
>> Hi Rouslan,
>>
>> I was already thinking of do the same thing you pointed.
>> It will cause some sort of problems if I do the previous thing I
>> suggested.
>> Thanks for your help.
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> The function "PMA_displayTableBody()" in display_tbl.lib.php is always
> return true.
> But it does not seems like, useful for other place where it have been
> used. (Used only in "PMA_displayTable()" function in same file)
>
> Inside "PMA_displayTable()" function it just assign the return value
> (true) to variable called '$clause_is_unique'.
> And variable is only used at one place. it is,
>
> echo '<input type="hidden" name="clause_is_unique"'
>             .' value="' . *$clause_is_unique* . '" />' . "\n";
>
> So, if this always return true, why don't we hard code true in the above
> case.
> And modify the "PMA_displayTableBody()" function to return string of html
> content.
>
> Am I going wrong ?
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I think I was wrong.
Though the block comments of PMA_displayTableBody function, mentioned that
it always return true,
when digging the code, and looking at the bottom comments, seems like its
very important.

I'll modify the function to return an array, having two elements which are
string of HTML content and boolean ($clause_is_unique)
The name will change from "PMA_displayTableBody" to
"PMA_getTableBodyParams".
I hope to see your suggestions.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On 11/05/12 08:26, Chanaka Dharmarathna wrote:
> On Fri, May 11, 2012 at 11:12 AM, Chanaka Dharmarathna<
> pe.chanaka.ck@...>  wrote:
>
>>
>>
>> On Fri, May 11, 2012 at 7:05 AM, Chanaka Dharmarathna<
>> pe.chanaka.ck@...>  wrote:
>>
>>>
>>>
>>> On Fri, May 11, 2012 at 12:39 AM, Rouslan Placella<rouslan@...:
>>>
>>>> On 09/05/12 21:08, Chanaka Dharmarathna wrote:
>>>>> On Wed, May 9, 2012 at 2:27 PM, Rouslan Placella<rouslan@...
>>>>> wrote:
>>>>>
>>>>>> On 09/05/12 09:39, Chanaka Dharmarathna wrote:
>>>>>>> On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
>>>>>>> pe.chanaka.ck@...>    wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<
>>>> rouslan@...
>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
>>>>>>>>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
>>>>>>>>>> pe.chanaka.ck@...>     wrote:
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<marc@...>
>>>>>>>>>     wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> See "Class Variables and Methods" in [0].
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Marc,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I went through that document.
>>>>>>>>>>>>> If the function is global, it will be like
>>>>>>>>> 'PMA_getDivForSliderEffect()'
>>>>>>>>>>>>> And if it is a local function (for particular class), it will
>>>> be
>>>>>> like
>>>>>>>>>>>>> 'getDivForSliderEffect()'.
>>>>>>>>>>>>
>>>>>>>>>>>> If this is a public method, yes. If a private one, prefix its
>>>> name
>>>>>>>>> with
>>>>>>>>>>>> an underscore.
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Though I went through that document before this, I couldn't get
>>>>>> that
>>>>>>>>>>>> point.
>>>>>>>>>>>>> Thanks for pointing out that.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Marc Delisle
>>>>>>>>>>>> http://infomarc.info
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>
>>>> ------------------------------------------------------------------------------
>>>>>>>>>>>> Live Security Virtual Conference
>>>>>>>>>>>> Exclusive live event will cover all the ways today's security
>>>> and
>>>>>>>>>>>> threat landscape has changed and how IT managers can respond.
>>>>>>>>> Discussions
>>>>>>>>>>>> will include endpoint security, mobile security and the latest
>>>> in
>>>>>>>>> malware
>>>>>>>>>>>> threats.
>>>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>> Phpmyadmin-devel mailing list
>>>>>>>>>>>> Phpmyadmin-devel@...
>>>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>> Got it Marc.
>>>>>>>>>>> Thanks.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> ____________________________________
>>>>>>>>>>>
>>>>>>>>>>> Chanaka Indrajith
>>>>>>>>>>> Bsc.Computer Engineering Undergraduate
>>>>>>>>>>> Faculty of Engineering
>>>>>>>>>>> University of Peradeniya
>>>>>>>>>>> Sri Lanka
>>>>>>>>>>> ____________________________________
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>> Hi Michal,
>>>>>>>>>>
>>>>>>>>>> I just did my first commit to my repository [0].
>>>>>>>>>> In that commit I have done some refactoring on
>>>>>>>>> "PMA_displayTableHeaders()"
>>>>>>>>>> function in "display_tbl.php" file.
>>>>>>>>>> All HTML renderings by "echo"s were removed and those HTML was
>>>>>> rendered
>>>>>>>>> at
>>>>>>>>>> the bottom of the function at once.
>>>>>>>>>> As well some related functions in "common.lib.php" file also were
>>>>>>>>> modified
>>>>>>>>>> in order to return a string of HTML content.
>>>>>>>>>> But the tests were not yet modified according to my modifications.
>>>>>>>>>> Since there was a conflict after my first local commit [1] (git
>>>>>>>>> commit), I
>>>>>>>>>> had to resolve conflicts and commit again. (that is [0])
>>>>>>>>>>
>>>>>>>>>> I have already installed phpUnit framework.
>>>>>>>>>> It will be very helpful if you can suggest me some documentation
>>>> to
>>>>>>>>> setup
>>>>>>>>>> and run tests in PMA (selenium etc).
>>>>>>>>>>
>>>>>>>>>> I'm intending to do the above refactoring procedure to all the
>>>>>>>>> functions in
>>>>>>>>>> "display_tbl.lib.php" file before moving to any other task.
>>>>>>>>>>
>>>>>>>>>> [0] :
>>>>>>>>>>
>>>>>>>>>
>>>>>>
>>>> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
>>>>>>>>>> [1] :
>>>>>>>>>>
>>>>>>>>>
>>>>>>
>>>> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
>>>>>>>>>>
>>>>>>>>>> Regards !
>>>>>>>>>
>>>>>>>>> I had a very quick look at your commit. I think that you're
>>>> indenting
>>>>>>>>> some lines incorrectly (but I stand to be corrected on this one).
>>>>>> AFAIK,
>>>>>>>>> you don't need to line up the operators, just indent by 4 spaces.
>>>>>> Example:
>>>>>>>>>
>>>>>>>>> // THIS IS BAD
>>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>>>>>>>>>                . $choice_label
>>>>>>>>>                . '</label>';
>>>>>>>>>
>>>>>>>>> // THIS IS GOOD
>>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>>>>>>>>>        . $choice_label
>>>>>>>>>        . '</label>';
>>>>>>>>>
>>>>>>>>> // THIS IS ALSO GOOD
>>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">';
>>>>>>>>> $radio_html .= $choice_label;
>>>>>>>>> $radio_html .= '</label>';
>>>>>>>>>
>>>>>>>>> Bye,
>>>>>>>>> Rouslan
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>
>>>> ------------------------------------------------------------------------------
>>>>>>>>> Live Security Virtual Conference
>>>>>>>>> Exclusive live event will cover all the ways today's security and
>>>>>>>>> threat landscape has changed and how IT managers can respond.
>>>>>> Discussions
>>>>>>>>> will include endpoint security, mobile security and the latest in
>>>>>> malware
>>>>>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>>>>>>> _______________________________________________
>>>>>>>>> Phpmyadmin-devel mailing list
>>>>>>>>> Phpmyadmin-devel@...
>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>>>>>>
>>>>>>>>
>>>>>>>> Hi Rouslan,
>>>>>>>>
>>>>>>>> Thanks for your suggestion.
>>>>>>>> I'll follow the way you mentioned as "THIS IS GOOD".
>>>>>>>>
>>>>>>>> Regards !
>>>>>>>>
>>>>>>>> --
>>>>>>>> ____________________________________
>>>>>>>>
>>>>>>>> Chanaka Indrajith
>>>>>>>> Bsc.Computer Engineering Undergraduate
>>>>>>>> Faculty of Engineering
>>>>>>>> University of Peradeniya
>>>>>>>> Sri Lanka
>>>>>>>> ____________________________________
>>>>>>>>
>>>>>>>>
>>>>>>> Hi Michal,
>>>>>>>
>>>>>>> In some functions there are pure HTML code snippets. (Ex :-
>>>>>>> PMA_displayTableNavigationOneButton() function in
>>>> display_tbl.lib.php)
>>>>>>>
>>>>>>> As I feel, its not good to convert all these snippets as PHP string
>>>> and
>>>>>>> render them. So I'm intending to get those pure HTML snippets into
>>>>>> separate
>>>>>>> function. That function can be named as
>>>> 'PMA_renderTableNavigationForm'
>>>>>>> (for above case).
>>>>>>> What do you think about this ?
>>>>>>>
>>>>>>> As well is there any reason for the phrase 'One' in the function
>>>>>>> "PMA_displayTableNavigation*One*Button()" ?
>>>>>>>
>>>>>>> Regards !
>>>>>>
>>>>>> I think that the above example is *exactly* the kind of stuff that
>>>> needs
>>>>>> to be converted to strings.
>>>>>>
>>>>>> Bye,
>>>>>> Rouslan
>>>>>>
>>>>>>
>>>>>>
>>>> ------------------------------------------------------------------------------
>>>>>> Live Security Virtual Conference
>>>>>> Exclusive live event will cover all the ways today's security and
>>>>>> threat landscape has changed and how IT managers can respond.
>>>> Discussions
>>>>>> will include endpoint security, mobile security and the latest in
>>>> malware
>>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>>>> _______________________________________________
>>>>>> Phpmyadmin-devel mailing list
>>>>>> Phpmyadmin-devel@...
>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>>>
>>>>>
>>>>> Hi Rouslan,
>>>>>
>>>>> I have little doubt of the way I understand your point.
>>>>>
>>>>> You are suggesting to render HTML content by PHP string, instead of
>>>> using
>>>>> pure HTML, though there is nicely placed HTML code snippets. (around
>>>> 5, 6
>>>>> lines)
>>>>> Am I correct Rouslan ? Sorry if I'm repeat the wheel.
>>>>
>>>> Yes, that's correct. And I don't thing that those lines are nice at all.
>>>>
>>>> Bye,
>>>> Rouslan
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Live Security Virtual Conference
>>>> Exclusive live event will cover all the ways today's security and
>>>> threat landscape has changed and how IT managers can respond. Discussions
>>>> will include endpoint security, mobile security and the latest in malware
>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>> _______________________________________________
>>>> Phpmyadmin-devel mailing list
>>>> Phpmyadmin-devel@...
>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>
>>>
>>> Hi Rouslan,
>>>
>>> I was already thinking of do the same thing you pointed.
>>> It will cause some sort of problems if I do the previous thing I
>>> suggested.
>>> Thanks for your help.
>>>
>>>
>>> Regards !
>>> --
>>> ____________________________________
>>>
>>> Chanaka Indrajith
>>> Bsc.Computer Engineering Undergraduate
>>> Faculty of Engineering
>>> University of Peradeniya
>>> Sri Lanka
>>> ____________________________________
>>>
>>>
>> Hi Michal,
>>
>> The function "PMA_displayTableBody()" in display_tbl.lib.php is always
>> return true.
>> But it does not seems like, useful for other place where it have been
>> used. (Used only in "PMA_displayTable()" function in same file)
>>
>> Inside "PMA_displayTable()" function it just assign the return value
>> (true) to variable called '$clause_is_unique'.
>> And variable is only used at one place. it is,
>>
>> echo '<input type="hidden" name="clause_is_unique"'
>>              .' value="' . *$clause_is_unique* . '" />' . "\n";
>>
>> So, if this always return true, why don't we hard code true in the above
>> case.
>> And modify the "PMA_displayTableBody()" function to return string of html
>> content.
>>
>> Am I going wrong ?
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> I think I was wrong.
> Though the block comments of PMA_displayTableBody function, mentioned that
> it always return true,
> when digging the code, and looking at the bottom comments, seems like its
> very important.
>
> I'll modify the function to return an array, having two elements which are
> string of HTML content and boolean ($clause_is_unique)
> The name will change from "PMA_displayTableBody" to
> "PMA_getTableBodyParams".
> I hope to see your suggestions.
>
> Regards !

It looks to me like you could easily get a value for $clause_is_unique 
outside of that function, so that you can leave its name and purpose as 
is. And you'll be able return a single string from it.

Bye,
Rouslan

On Fri, May 11, 2012 at 4:18 PM, Rouslan Placella <rouslan@...:

> On 11/05/12 08:26, Chanaka Dharmarathna wrote:
> > On Fri, May 11, 2012 at 11:12 AM, Chanaka Dharmarathna<
> > pe.chanaka.ck@...>  wrote:
> >
> >>
> >>
> >> On Fri, May 11, 2012 at 7:05 AM, Chanaka Dharmarathna<
> >> pe.chanaka.ck@...>  wrote:
> >>
> >>>
> >>>
> >>> On Fri, May 11, 2012 at 12:39 AM, Rouslan Placella<
> rouslan@...:
> >>>
> >>>> On 09/05/12 21:08, Chanaka Dharmarathna wrote:
> >>>>> On Wed, May 9, 2012 at 2:27 PM, Rouslan Placella<
> rouslan@...
> >>>>> wrote:
> >>>>>
> >>>>>> On 09/05/12 09:39, Chanaka Dharmarathna wrote:
> >>>>>>> On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
> >>>>>>> pe.chanaka.ck@...>    wrote:
> >>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<
> >>>> rouslan@...
> >>>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
> >>>>>>>>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
> >>>>>>>>>> pe.chanaka.ck@...>     wrote:
> >>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<
> marc@...>
> >>>>>>>>>     wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
> >>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> See "Class Variables and Methods" in [0].
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
> >>>>>>>>>>>>
> >>>>>>>>>>>>> Hi Marc,
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> I went through that document.
> >>>>>>>>>>>>> If the function is global, it will be like
> >>>>>>>>> 'PMA_getDivForSliderEffect()'
> >>>>>>>>>>>>> And if it is a local function (for particular class), it will
> >>>> be
> >>>>>> like
> >>>>>>>>>>>>> 'getDivForSliderEffect()'.
> >>>>>>>>>>>>
> >>>>>>>>>>>> If this is a public method, yes. If a private one, prefix its
> >>>> name
> >>>>>>>>> with
> >>>>>>>>>>>> an underscore.
> >>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Though I went through that document before this, I couldn't
> get
> >>>>>> that
> >>>>>>>>>>>> point.
> >>>>>>>>>>>>> Thanks for pointing out that.
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> --
> >>>>>>>>>>>> Marc Delisle
> >>>>>>>>>>>> http://infomarc.info
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>
> >>>>>>
> >>>>
> ------------------------------------------------------------------------------
> >>>>>>>>>>>> Live Security Virtual Conference
> >>>>>>>>>>>> Exclusive live event will cover all the ways today's security
> >>>> and
> >>>>>>>>>>>> threat landscape has changed and how IT managers can respond.
> >>>>>>>>> Discussions
> >>>>>>>>>>>> will include endpoint security, mobile security and the latest
> >>>> in
> >>>>>>>>> malware
> >>>>>>>>>>>> threats.
> >>>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>>>>>>>>>> _______________________________________________
> >>>>>>>>>>>> Phpmyadmin-devel mailing list
> >>>>>>>>>>>> Phpmyadmin-devel@...
> >>>>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>> Got it Marc.
> >>>>>>>>>>> Thanks.
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> --
> >>>>>>>>>>> ____________________________________
> >>>>>>>>>>>
> >>>>>>>>>>> Chanaka Indrajith
> >>>>>>>>>>> Bsc.Computer Engineering Undergraduate
> >>>>>>>>>>> Faculty of Engineering
> >>>>>>>>>>> University of Peradeniya
> >>>>>>>>>>> Sri Lanka
> >>>>>>>>>>> ____________________________________
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>> Hi Michal,
> >>>>>>>>>>
> >>>>>>>>>> I just did my first commit to my repository [0].
> >>>>>>>>>> In that commit I have done some refactoring on
> >>>>>>>>> "PMA_displayTableHeaders()"
> >>>>>>>>>> function in "display_tbl.php" file.
> >>>>>>>>>> All HTML renderings by "echo"s were removed and those HTML was
> >>>>>> rendered
> >>>>>>>>> at
> >>>>>>>>>> the bottom of the function at once.
> >>>>>>>>>> As well some related functions in "common.lib.php" file also
> were
> >>>>>>>>> modified
> >>>>>>>>>> in order to return a string of HTML content.
> >>>>>>>>>> But the tests were not yet modified according to my
> modifications.
> >>>>>>>>>> Since there was a conflict after my first local commit [1] (git
> >>>>>>>>> commit), I
> >>>>>>>>>> had to resolve conflicts and commit again. (that is [0])
> >>>>>>>>>>
> >>>>>>>>>> I have already installed phpUnit framework.
> >>>>>>>>>> It will be very helpful if you can suggest me some documentation
> >>>> to
> >>>>>>>>> setup
> >>>>>>>>>> and run tests in PMA (selenium etc).
> >>>>>>>>>>
> >>>>>>>>>> I'm intending to do the above refactoring procedure to all the
> >>>>>>>>> functions in
> >>>>>>>>>> "display_tbl.lib.php" file before moving to any other task.
> >>>>>>>>>>
> >>>>>>>>>> [0] :
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>
> >>>>
> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
> >>>>>>>>>> [1] :
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>
> >>>>
> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
> >>>>>>>>>>
> >>>>>>>>>> Regards !
> >>>>>>>>>
> >>>>>>>>> I had a very quick look at your commit. I think that you're
> >>>> indenting
> >>>>>>>>> some lines incorrectly (but I stand to be corrected on this one).
> >>>>>> AFAIK,
> >>>>>>>>> you don't need to line up the operators, just indent by 4 spaces.
> >>>>>> Example:
> >>>>>>>>>
> >>>>>>>>> // THIS IS BAD
> >>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">'
> >>>>>>>>>                . $choice_label
> >>>>>>>>>                . '</label>';
> >>>>>>>>>
> >>>>>>>>> // THIS IS GOOD
> >>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">'
> >>>>>>>>>        . $choice_label
> >>>>>>>>>        . '</label>';
> >>>>>>>>>
> >>>>>>>>> // THIS IS ALSO GOOD
> >>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">';
> >>>>>>>>> $radio_html .= $choice_label;
> >>>>>>>>> $radio_html .= '</label>';
> >>>>>>>>>
> >>>>>>>>> Bye,
> >>>>>>>>> Rouslan
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>
> >>>>
> ------------------------------------------------------------------------------
> >>>>>>>>> Live Security Virtual Conference
> >>>>>>>>> Exclusive live event will cover all the ways today's security and
> >>>>>>>>> threat landscape has changed and how IT managers can respond.
> >>>>>> Discussions
> >>>>>>>>> will include endpoint security, mobile security and the latest in
> >>>>>> malware
> >>>>>>>>> threats.
> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>>>>>>> _______________________________________________
> >>>>>>>>> Phpmyadmin-devel mailing list
> >>>>>>>>> Phpmyadmin-devel@...
> >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>> Hi Rouslan,
> >>>>>>>>
> >>>>>>>> Thanks for your suggestion.
> >>>>>>>> I'll follow the way you mentioned as "THIS IS GOOD".
> >>>>>>>>
> >>>>>>>> Regards !
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> ____________________________________
> >>>>>>>>
> >>>>>>>> Chanaka Indrajith
> >>>>>>>> Bsc.Computer Engineering Undergraduate
> >>>>>>>> Faculty of Engineering
> >>>>>>>> University of Peradeniya
> >>>>>>>> Sri Lanka
> >>>>>>>> ____________________________________
> >>>>>>>>
> >>>>>>>>
> >>>>>>> Hi Michal,
> >>>>>>>
> >>>>>>> In some functions there are pure HTML code snippets. (Ex :-
> >>>>>>> PMA_displayTableNavigationOneButton() function in
> >>>> display_tbl.lib.php)
> >>>>>>>
> >>>>>>> As I feel, its not good to convert all these snippets as PHP string
> >>>> and
> >>>>>>> render them. So I'm intending to get those pure HTML snippets into
> >>>>>> separate
> >>>>>>> function. That function can be named as
> >>>> 'PMA_renderTableNavigationForm'
> >>>>>>> (for above case).
> >>>>>>> What do you think about this ?
> >>>>>>>
> >>>>>>> As well is there any reason for the phrase 'One' in the function
> >>>>>>> "PMA_displayTableNavigation*One*Button()" ?
> >>>>>>>
> >>>>>>> Regards !
> >>>>>>
> >>>>>> I think that the above example is *exactly* the kind of stuff that
> >>>> needs
> >>>>>> to be converted to strings.
> >>>>>>
> >>>>>> Bye,
> >>>>>> Rouslan
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>
> ------------------------------------------------------------------------------
> >>>>>> Live Security Virtual Conference
> >>>>>> Exclusive live event will cover all the ways today's security and
> >>>>>> threat landscape has changed and how IT managers can respond.
> >>>> Discussions
> >>>>>> will include endpoint security, mobile security and the latest in
> >>>> malware
> >>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>>>> _______________________________________________
> >>>>>> Phpmyadmin-devel mailing list
> >>>>>> Phpmyadmin-devel@...
> >>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>>>
> >>>>>
> >>>>> Hi Rouslan,
> >>>>>
> >>>>> I have little doubt of the way I understand your point.
> >>>>>
> >>>>> You are suggesting to render HTML content by PHP string, instead of
> >>>> using
> >>>>> pure HTML, though there is nicely placed HTML code snippets. (around
> >>>> 5, 6
> >>>>> lines)
> >>>>> Am I correct Rouslan ? Sorry if I'm repeat the wheel.
> >>>>
> >>>> Yes, that's correct. And I don't thing that those lines are nice at
> all.
> >>>>
> >>>> Bye,
> >>>> Rouslan
> >>>>
> >>>>
> >>>>
> ------------------------------------------------------------------------------
> >>>> Live Security Virtual Conference
> >>>> Exclusive live event will cover all the ways today's security and
> >>>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>>> will include endpoint security, mobile security and the latest in
> malware
> >>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>> _______________________________________________
> >>>> Phpmyadmin-devel mailing list
> >>>> Phpmyadmin-devel@...
> >>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>
> >>>
> >>> Hi Rouslan,
> >>>
> >>> I was already thinking of do the same thing you pointed.
> >>> It will cause some sort of problems if I do the previous thing I
> >>> suggested.
> >>> Thanks for your help.
> >>>
> >>>
> >>> Regards !
> >>> --
> >>> ____________________________________
> >>>
> >>> Chanaka Indrajith
> >>> Bsc.Computer Engineering Undergraduate
> >>> Faculty of Engineering
> >>> University of Peradeniya
> >>> Sri Lanka
> >>> ____________________________________
> >>>
> >>>
> >> Hi Michal,
> >>
> >> The function "PMA_displayTableBody()" in display_tbl.lib.php is always
> >> return true.
> >> But it does not seems like, useful for other place where it have been
> >> used. (Used only in "PMA_displayTable()" function in same file)
> >>
> >> Inside "PMA_displayTable()" function it just assign the return value
> >> (true) to variable called '$clause_is_unique'.
> >> And variable is only used at one place. it is,
> >>
> >> echo '<input type="hidden" name="clause_is_unique"'
> >>              .' value="' . *$clause_is_unique* . '" />' . "\n";
> >>
> >> So, if this always return true, why don't we hard code true in the above
> >> case.
> >> And modify the "PMA_displayTableBody()" function to return string of
> html
> >> content.
> >>
> >> Am I going wrong ?
> >>
> >>
> >> Regards !
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >>
> > Hi Michal,
> >
> > I think I was wrong.
> > Though the block comments of PMA_displayTableBody function, mentioned
> that
> > it always return true,
> > when digging the code, and looking at the bottom comments, seems like its
> > very important.
> >
> > I'll modify the function to return an array, having two elements which
> are
> > string of HTML content and boolean ($clause_is_unique)
> > The name will change from "PMA_displayTableBody" to
> > "PMA_getTableBodyParams".
> > I hope to see your suggestions.
> >
> > Regards !
>
> It looks to me like you could easily get a value for $clause_is_unique
> outside of that function, so that you can leave its name and purpose as
> is. And you'll be able return a single string from it.
>
> Bye,
> Rouslan
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Rouslan,

You talking about the function "PMA_getUniqueCondition" in "common.lib.php
file" right.
Exactly, I can directly get the value for $clause_is_unique from the output
array of that function.
I'll do the necessary modifications.
Thanks for pointing out that.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Fri, May 11, 2012 at 6:17 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Fri, May 11, 2012 at 4:18 PM, Rouslan Placella <rouslan@...:
>
>> On 11/05/12 08:26, Chanaka Dharmarathna wrote:
>> > On Fri, May 11, 2012 at 11:12 AM, Chanaka Dharmarathna<
>> > pe.chanaka.ck@...>  wrote:
>> >
>> >>
>> >>
>> >> On Fri, May 11, 2012 at 7:05 AM, Chanaka Dharmarathna<
>> >> pe.chanaka.ck@...>  wrote:
>> >>
>> >>>
>> >>>
>> >>> On Fri, May 11, 2012 at 12:39 AM, Rouslan Placella<
>> rouslan@...:
>> >>>
>> >>>> On 09/05/12 21:08, Chanaka Dharmarathna wrote:
>> >>>>> On Wed, May 9, 2012 at 2:27 PM, Rouslan Placella<
>> rouslan@...
>> >>>>> wrote:
>> >>>>>
>> >>>>>> On 09/05/12 09:39, Chanaka Dharmarathna wrote:
>> >>>>>>> On Wed, May 9, 2012 at 9:21 AM, Chanaka Dharmarathna<
>> >>>>>>> pe.chanaka.ck@...>    wrote:
>> >>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>> On Wed, May 9, 2012 at 1:19 AM, Rouslan Placella<
>> >>>> rouslan@...
>> >>>>>>> wrote:
>> >>>>>>>>
>> >>>>>>>>> On 08/05/12 20:32, Chanaka Dharmarathna wrote:
>> >>>>>>>>>> On Tue, May 8, 2012 at 7:23 PM, Chanaka Dharmarathna<
>> >>>>>>>>>> pe.chanaka.ck@...>     wrote:
>> >>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>> On Tue, May 8, 2012 at 7:08 PM, Marc Delisle<
>> marc@...>
>> >>>>>>>>>     wrote:
>> >>>>>>>>>>>
>> >>>>>>>>>>>> Le 2012-05-08 09:25, Chanaka Dharmarathna a écrit :
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>>>
>> >>>>>>>>>>>>>> See "Class Variables and Methods" in [0].
>> >>>>>>>>>>>>>>
>> >>>>>>>>>>>>>> [0] http://pear.php.net/manual/en/standards.naming.php
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>> Hi Marc,
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> I went through that document.
>> >>>>>>>>>>>>> If the function is global, it will be like
>> >>>>>>>>> 'PMA_getDivForSliderEffect()'
>> >>>>>>>>>>>>> And if it is a local function (for particular class), it
>> will
>> >>>> be
>> >>>>>> like
>> >>>>>>>>>>>>> 'getDivForSliderEffect()'.
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> If this is a public method, yes. If a private one, prefix its
>> >>>> name
>> >>>>>>>>> with
>> >>>>>>>>>>>> an underscore.
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> Though I went through that document before this, I couldn't
>> get
>> >>>>>> that
>> >>>>>>>>>>>> point.
>> >>>>>>>>>>>>> Thanks for pointing out that.
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> --
>> >>>>>>>>>>>> Marc Delisle
>> >>>>>>>>>>>> http://infomarc.info
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>
>> >>>>>>>>>
>> >>>>>>
>> >>>>
>> ------------------------------------------------------------------------------
>> >>>>>>>>>>>> Live Security Virtual Conference
>> >>>>>>>>>>>> Exclusive live event will cover all the ways today's security
>> >>>> and
>> >>>>>>>>>>>> threat landscape has changed and how IT managers can respond.
>> >>>>>>>>> Discussions
>> >>>>>>>>>>>> will include endpoint security, mobile security and the
>> latest
>> >>>> in
>> >>>>>>>>> malware
>> >>>>>>>>>>>> threats.
>> >>>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>>>>>>>>>>> _______________________________________________
>> >>>>>>>>>>>> Phpmyadmin-devel mailing list
>> >>>>>>>>>>>> Phpmyadmin-devel@...
>> >>>>>>>>>>>>
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>
>> >>>>>>>>>>> Got it Marc.
>> >>>>>>>>>>> Thanks.
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>> --
>> >>>>>>>>>>> ____________________________________
>> >>>>>>>>>>>
>> >>>>>>>>>>> Chanaka Indrajith
>> >>>>>>>>>>> Bsc.Computer Engineering Undergraduate
>> >>>>>>>>>>> Faculty of Engineering
>> >>>>>>>>>>> University of Peradeniya
>> >>>>>>>>>>> Sri Lanka
>> >>>>>>>>>>> ____________________________________
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>> Hi Michal,
>> >>>>>>>>>>
>> >>>>>>>>>> I just did my first commit to my repository [0].
>> >>>>>>>>>> In that commit I have done some refactoring on
>> >>>>>>>>> "PMA_displayTableHeaders()"
>> >>>>>>>>>> function in "display_tbl.php" file.
>> >>>>>>>>>> All HTML renderings by "echo"s were removed and those HTML was
>> >>>>>> rendered
>> >>>>>>>>> at
>> >>>>>>>>>> the bottom of the function at once.
>> >>>>>>>>>> As well some related functions in "common.lib.php" file also
>> were
>> >>>>>>>>> modified
>> >>>>>>>>>> in order to return a string of HTML content.
>> >>>>>>>>>> But the tests were not yet modified according to my
>> modifications.
>> >>>>>>>>>> Since there was a conflict after my first local commit [1] (git
>> >>>>>>>>> commit), I
>> >>>>>>>>>> had to resolve conflicts and commit again. (that is [0])
>> >>>>>>>>>>
>> >>>>>>>>>> I have already installed phpUnit framework.
>> >>>>>>>>>> It will be very helpful if you can suggest me some
>> documentation
>> >>>> to
>> >>>>>>>>> setup
>> >>>>>>>>>> and run tests in PMA (selenium etc).
>> >>>>>>>>>>
>> >>>>>>>>>> I'm intending to do the above refactoring procedure to all the
>> >>>>>>>>> functions in
>> >>>>>>>>>> "display_tbl.lib.php" file before moving to any other task.
>> >>>>>>>>>>
>> >>>>>>>>>> [0] :
>> >>>>>>>>>>
>> >>>>>>>>>
>> >>>>>>
>> >>>>
>> https://github.com/Chanaka/phpmyadmin/commit/dfc73d3494445ff9430e5d0b4f33f800c6e480e0
>> >>>>>>>>>> [1] :
>> >>>>>>>>>>
>> >>>>>>>>>
>> >>>>>>
>> >>>>
>> https://github.com/Chanaka/phpmyadmin/commit/004f4f5258a0820975e2da9fa02a6d3ba6622368
>> >>>>>>>>>>
>> >>>>>>>>>> Regards !
>> >>>>>>>>>
>> >>>>>>>>> I had a very quick look at your commit. I think that you're
>> >>>> indenting
>> >>>>>>>>> some lines incorrectly (but I stand to be corrected on this
>> one).
>> >>>>>> AFAIK,
>> >>>>>>>>> you don't need to line up the operators, just indent by 4
>> spaces.
>> >>>>>> Example:
>> >>>>>>>>>
>> >>>>>>>>> // THIS IS BAD
>> >>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>> >>>>>>>>>                . $choice_label
>> >>>>>>>>>                . '</label>';
>> >>>>>>>>>
>> >>>>>>>>> // THIS IS GOOD
>> >>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">'
>> >>>>>>>>>        . $choice_label
>> >>>>>>>>>        . '</label>';
>> >>>>>>>>>
>> >>>>>>>>> // THIS IS ALSO GOOD
>> >>>>>>>>> $radio_html .= '<label for="' . $html_field_id . '">';
>> >>>>>>>>> $radio_html .= $choice_label;
>> >>>>>>>>> $radio_html .= '</label>';
>> >>>>>>>>>
>> >>>>>>>>> Bye,
>> >>>>>>>>> Rouslan
>> >>>>>>>>>
>> >>>>>>>>>
>> >>>>>>>>>
>> >>>>>>
>> >>>>
>> ------------------------------------------------------------------------------
>> >>>>>>>>> Live Security Virtual Conference
>> >>>>>>>>> Exclusive live event will cover all the ways today's security
>> and
>> >>>>>>>>> threat landscape has changed and how IT managers can respond.
>> >>>>>> Discussions
>> >>>>>>>>> will include endpoint security, mobile security and the latest
>> in
>> >>>>>> malware
>> >>>>>>>>> threats.
>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>>>>>>>> _______________________________________________
>> >>>>>>>>> Phpmyadmin-devel mailing list
>> >>>>>>>>> Phpmyadmin-devel@...
>> >>>>>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>>>>>>>
>> >>>>>>>>
>> >>>>>>>> Hi Rouslan,
>> >>>>>>>>
>> >>>>>>>> Thanks for your suggestion.
>> >>>>>>>> I'll follow the way you mentioned as "THIS IS GOOD".
>> >>>>>>>>
>> >>>>>>>> Regards !
>> >>>>>>>>
>> >>>>>>>> --
>> >>>>>>>> ____________________________________
>> >>>>>>>>
>> >>>>>>>> Chanaka Indrajith
>> >>>>>>>> Bsc.Computer Engineering Undergraduate
>> >>>>>>>> Faculty of Engineering
>> >>>>>>>> University of Peradeniya
>> >>>>>>>> Sri Lanka
>> >>>>>>>> ____________________________________
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>> Hi Michal,
>> >>>>>>>
>> >>>>>>> In some functions there are pure HTML code snippets. (Ex :-
>> >>>>>>> PMA_displayTableNavigationOneButton() function in
>> >>>> display_tbl.lib.php)
>> >>>>>>>
>> >>>>>>> As I feel, its not good to convert all these snippets as PHP
>> string
>> >>>> and
>> >>>>>>> render them. So I'm intending to get those pure HTML snippets into
>> >>>>>> separate
>> >>>>>>> function. That function can be named as
>> >>>> 'PMA_renderTableNavigationForm'
>> >>>>>>> (for above case).
>> >>>>>>> What do you think about this ?
>> >>>>>>>
>> >>>>>>> As well is there any reason for the phrase 'One' in the function
>> >>>>>>> "PMA_displayTableNavigation*One*Button()" ?
>> >>>>>>>
>> >>>>>>> Regards !
>> >>>>>>
>> >>>>>> I think that the above example is *exactly* the kind of stuff that
>> >>>> needs
>> >>>>>> to be converted to strings.
>> >>>>>>
>> >>>>>> Bye,
>> >>>>>> Rouslan
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>
>> ------------------------------------------------------------------------------
>> >>>>>> Live Security Virtual Conference
>> >>>>>> Exclusive live event will cover all the ways today's security and
>> >>>>>> threat landscape has changed and how IT managers can respond.
>> >>>> Discussions
>> >>>>>> will include endpoint security, mobile security and the latest in
>> >>>> malware
>> >>>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>>>>> _______________________________________________
>> >>>>>> Phpmyadmin-devel mailing list
>> >>>>>> Phpmyadmin-devel@...
>> >>>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>>>>
>> >>>>>
>> >>>>> Hi Rouslan,
>> >>>>>
>> >>>>> I have little doubt of the way I understand your point.
>> >>>>>
>> >>>>> You are suggesting to render HTML content by PHP string, instead of
>> >>>> using
>> >>>>> pure HTML, though there is nicely placed HTML code snippets. (around
>> >>>> 5, 6
>> >>>>> lines)
>> >>>>> Am I correct Rouslan ? Sorry if I'm repeat the wheel.
>> >>>>
>> >>>> Yes, that's correct. And I don't thing that those lines are nice at
>> all.
>> >>>>
>> >>>> Bye,
>> >>>> Rouslan
>> >>>>
>> >>>>
>> >>>>
>> ------------------------------------------------------------------------------
>> >>>> Live Security Virtual Conference
>> >>>> Exclusive live event will cover all the ways today's security and
>> >>>> threat landscape has changed and how IT managers can respond.
>> Discussions
>> >>>> will include endpoint security, mobile security and the latest in
>> malware
>> >>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>>> _______________________________________________
>> >>>> Phpmyadmin-devel mailing list
>> >>>> Phpmyadmin-devel@...
>> >>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>>
>> >>>
>> >>> Hi Rouslan,
>> >>>
>> >>> I was already thinking of do the same thing you pointed.
>> >>> It will cause some sort of problems if I do the previous thing I
>> >>> suggested.
>> >>> Thanks for your help.
>> >>>
>> >>>
>> >>> Regards !
>> >>> --
>> >>> ____________________________________
>> >>>
>> >>> Chanaka Indrajith
>> >>> Bsc.Computer Engineering Undergraduate
>> >>> Faculty of Engineering
>> >>> University of Peradeniya
>> >>> Sri Lanka
>> >>> ____________________________________
>> >>>
>> >>>
>> >> Hi Michal,
>> >>
>> >> The function "PMA_displayTableBody()" in display_tbl.lib.php is always
>> >> return true.
>> >> But it does not seems like, useful for other place where it have been
>> >> used. (Used only in "PMA_displayTable()" function in same file)
>> >>
>> >> Inside "PMA_displayTable()" function it just assign the return value
>> >> (true) to variable called '$clause_is_unique'.
>> >> And variable is only used at one place. it is,
>> >>
>> >> echo '<input type="hidden" name="clause_is_unique"'
>> >>              .' value="' . *$clause_is_unique* . '" />' . "\n";
>> >>
>> >> So, if this always return true, why don't we hard code true in the
>> above
>> >> case.
>> >> And modify the "PMA_displayTableBody()" function to return string of
>> html
>> >> content.
>> >>
>> >> Am I going wrong ?
>> >>
>> >>
>> >> Regards !
>> >> --
>> >> ____________________________________
>> >>
>> >> Chanaka Indrajith
>> >> Bsc.Computer Engineering Undergraduate
>> >> Faculty of Engineering
>> >> University of Peradeniya
>> >> Sri Lanka
>> >> ____________________________________
>> >>
>> >>
>> > Hi Michal,
>> >
>> > I think I was wrong.
>> > Though the block comments of PMA_displayTableBody function, mentioned
>> that
>> > it always return true,
>> > when digging the code, and looking at the bottom comments, seems like
>> its
>> > very important.
>> >
>> > I'll modify the function to return an array, having two elements which
>> are
>> > string of HTML content and boolean ($clause_is_unique)
>> > The name will change from "PMA_displayTableBody" to
>> > "PMA_getTableBodyParams".
>> > I hope to see your suggestions.
>> >
>> > Regards !
>>
>> It looks to me like you could easily get a value for $clause_is_unique
>> outside of that function, so that you can leave its name and purpose as
>> is. And you'll be able return a single string from it.
>>
>> Bye,
>> Rouslan
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>
> Hi Rouslan,
>
> You talking about the function "PMA_getUniqueCondition" in "common.lib.php
> file" right.
> Exactly, I can directly get the value for $clause_is_unique from the
> output array of that function.
> I'll do the necessary modifications.
>
> Thanks for pointing out that.
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I set up the testing environment in my machine and now evolving with the
improvements of unit tests for some modified function.

When I run unit test for "PMA_showMessage" function in "common.lib.php"
file, it gives me some fatal errors. (Call to undefined function
PMA_warnMissingExtension() ...)
I used the command : $phpunit
test/libraries/common/PMA_showMessage_test_disabled.php

Do you have any idea on this ?

My testing environment :
PHPUnit 3.6.10
PEAR Version: 1.9.4
PHP Version: 5.3.2-1ubuntu4.9

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

First of all please try to remove useless quoting in the email, it
makes them easier to read.

Dne Sun, 13 May 2012 16:04:17 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> I set up the testing environment in my machine and now evolving with the
> improvements of unit tests for some modified function.
> 
> When I run unit test for "PMA_showMessage" function in "common.lib.php"
> file, it gives me some fatal errors. (Call to undefined function
> PMA_warnMissingExtension() ...)
> I used the command : $phpunit
> test/libraries/common/PMA_showMessage_test_disabled.php
> 
> Do you have any idea on this ?

Probably the test is missing some includes, many of tests were not
really tested standalone.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On Mon, May 14, 2012 at 4:32 PM, Michal Čihař <michal@...> wrote:

> Hi
>
> First of all please try to remove useless quoting in the email, it
> makes them easier to read.
>
> Dne Sun, 13 May 2012 16:04:17 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
> > I set up the testing environment in my machine and now evolving with the
> > improvements of unit tests for some modified function.
> >
> > When I run unit test for "PMA_showMessage" function in "common.lib.php"
> > file, it gives me some fatal errors. (Call to undefined function
> > PMA_warnMissingExtension() ...)
> > I used the command : $phpunit
> > test/libraries/common/PMA_showMessage_test_disabled.php
> >
> > Do you have any idea on this ?
>
> Probably the test is missing some includes, many of tests were not
> really tested standalone.
>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Michal,

I'll follow your instructions Marc.

Yes, that is the case. I tried with including around three additional
files, but again the error is due to not including some necessary files.
Is there any easier way to run this unit tests independent from the other
tests ?

As well, I'm going to do some modifications regarding to improve
readability of the code.
For functions which are not too small, I'm going to add one empty line,
just after function declaration and just before the end of the function.

Ex :-
function PMA_setDisplayMode($params)
{

// function body after empty line
----
----
// end of the function body

} // end of the function after empty line

Hope this is more readable. Shall I use this ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Mon, May 14, 2012 at 5:30 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Mon, May 14, 2012 at 4:32 PM, Michal Čihař <michal@...> wrote:
>
>> Hi
>>
>> First of all please try to remove useless quoting in the email, it
>> makes them easier to read.
>>
>> Dne Sun, 13 May 2012 16:04:17 +0530
>> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>>
>> > I set up the testing environment in my machine and now evolving with the
>> > improvements of unit tests for some modified function.
>> >
>> > When I run unit test for "PMA_showMessage" function in "common.lib.php"
>> > file, it gives me some fatal errors. (Call to undefined function
>> > PMA_warnMissingExtension() ...)
>> > I used the command : $phpunit
>> > test/libraries/common/PMA_showMessage_test_disabled.php
>> >
>> > Do you have any idea on this ?
>>
>> Probably the test is missing some includes, many of tests were not
>> really tested standalone.
>>
>> --
>>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
> Hi Michal,
>
> I'll follow your instructions Marc.
>
> Yes, that is the case. I tried with including around three additional
> files, but again the error is due to not including some necessary files.
> Is there any easier way to run this unit tests independent from the other
> tests ?
>
> As well, I'm going to do some modifications regarding to improve
> readability of the code.
> For functions which are not too small, I'm going to add one empty line,
> just after function declaration and just before the end of the function.
>
> Ex :-
> function PMA_setDisplayMode($params)
> {
>
> // function body after empty line
> ----
> ----
> // end of the function body
>
> } // end of the function after empty line
>
> Hope this is more readable. Shall I use this ?
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I have introduced two small functions to reduce the code repetition in
PMA_getVerticalTable() function in display_tbl.lib.php file.
Both functions are using the global variable $vertical_display.

Now I'm trying to implement unit tests for those functions.
Since there is global variable, it represent null while run the test.
Is there any way to implement test cases for this kind of functions ?

As well, is it possible to implement tests for functions like
PMA_getTableNavigation() which is return a large string ?
If possible, Can you give me some guidance to implement tests for that kind
of functions.

Please note that above function names used in my repository [0].

[0] : https://github.com/Chanaka/phpmyadmin

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

Dne Wed, 16 May 2012 21:33:17 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> I have introduced two small functions to reduce the code repetition in
> PMA_getVerticalTable() function in display_tbl.lib.php file.
> Both functions are using the global variable $vertical_display.

Please try to avoid using global variables, this one should be passed
as parameter (or it should be attribute of class which embeds
displaying query results).

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On Thu, May 17, 2012 at 1:08 PM, Michal Čihař <michal@...> wrote:

> Hi
>
> Dne Wed, 16 May 2012 21:33:17 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
> > I have introduced two small functions to reduce the code repetition in
> > PMA_getVerticalTable() function in display_tbl.lib.php file.
> > Both functions are using the global variable $vertical_display.
>
> Please try to avoid using global variables, this one should be passed
> as parameter (or it should be attribute of class which embeds
> displaying query results).
>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Michal,

Thanks for pointing that.
I'll pass them as parameters.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Thu, May 17, 2012 at 1:15 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Thu, May 17, 2012 at 1:08 PM, Michal Čihař <michal@...> wrote:
>
>> Hi
>>
>> Dne Wed, 16 May 2012 21:33:17 +0530
>> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>>
>> > I have introduced two small functions to reduce the code repetition in
>> > PMA_getVerticalTable() function in display_tbl.lib.php file.
>> > Both functions are using the global variable $vertical_display.
>>
>> Please try to avoid using global variables, this one should be passed
>> as parameter (or it should be attribute of class which embeds
>> displaying query results).
>>
>> --
>>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
> Hi Michal,
>
> Thanks for pointing that.
> I'll pass them as parameters.
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

In PMA_getTableHeaders() function in display_tbl.lib.php file, there is a
if else condition to set the variable $span.
But it seems like, $span is not used any other place in PMA.
So, I'll remove that code segment due to it's a dead code.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

Dne Sun, 20 May 2012 00:19:14 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> In PMA_getTableHeaders() function in display_tbl.lib.php file, there is a
> if else condition to set the variable $span.
> But it seems like, $span is not used any other place in PMA.
> So, I'll remove that code segment due to it's a dead code.

Indeed it looks like no longer used code.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On Mon, May 21, 2012 at 12:09 PM, Michal Čihař <michal@...> wrote:

> Hi
>
> Dne Sun, 20 May 2012 00:19:14 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
> > In PMA_getTableHeaders() function in display_tbl.lib.php file, there is a
> > if else condition to set the variable $span.
> > But it seems like, $span is not used any other place in PMA.
> > So, I'll remove that code segment due to it's a dead code.
>
> Indeed it looks like no longer used code.
>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Michal,

Thanks for giving your feedback.
Yes, I did more changes to the code.
Pleas get me into the right track if I'm going wrong.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

Dne Mon, 21 May 2012 12:28:42 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> Thanks for giving your feedback.
> Yes, I did more changes to the code.
> Pleas get me into the right track if I'm going wrong.

I think you're heading in right direction - splitting the code to
smaller blocks which are easy to understand always helps.

I'm currently commenting some things in your commits, so let's keep
this part on github.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On Mon, May 21, 2012 at 6:31 PM, Michal Čihař <michal@...> wrote:

> Hi
>
> Dne Mon, 21 May 2012 12:28:42 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
> > Thanks for giving your feedback.
> > Yes, I did more changes to the code.
> > Pleas get me into the right track if I'm going wrong.
>
> I think you're heading in right direction - splitting the code to
> smaller blocks which are easy to understand always helps.
>
> I'm currently commenting some things in your commits, so let's keep
> this part on github.
>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Michal,

That's good to hear.
I put a reply in github

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Mon, May 21, 2012 at 6:58 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Mon, May 21, 2012 at 6:31 PM, Michal Čihař <michal@...> wrote:
>
>> Hi
>>
>> Dne Mon, 21 May 2012 12:28:42 +0530
>> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>>
>> > Thanks for giving your feedback.
>> > Yes, I did more changes to the code.
>> > Pleas get me into the right track if I'm going wrong.
>>
>> I think you're heading in right direction - splitting the code to
>> smaller blocks which are easy to understand always helps.
>>
>> I'm currently commenting some things in your commits, so let's keep
>> this part on github.
>>
>> --
>>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
> Hi Michal,
>
> That's good to hear.
> I put a reply in github
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I'm going to change my plans little bit.
At the moment I think the most prioritized task is to make the
display_tbl.lib.php file as a PHP class.
So, if there is no matter of that, I'll involve with this task in this week
(In my third week).

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Tue, May 22, 2012 at 12:54 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Mon, May 21, 2012 at 6:58 PM, Chanaka Dharmarathna <
> pe.chanaka.ck@...> wrote:
>
>>
>>
>> On Mon, May 21, 2012 at 6:31 PM, Michal Čihař <michal@...> wrote:
>>
>>> Hi
>>>
>>> Dne Mon, 21 May 2012 12:28:42 +0530
>>> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>>>
>>> > Thanks for giving your feedback.
>>> > Yes, I did more changes to the code.
>>> > Pleas get me into the right track if I'm going wrong.
>>>
>>> I think you're heading in right direction - splitting the code to
>>> smaller blocks which are easy to understand always helps.
>>>
>>> I'm currently commenting some things in your commits, so let's keep
>>> this part on github.
>>>
>>> --
>>>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>>
>> Hi Michal,
>>
>> That's good to hear.
>> I put a reply in github
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> I'm going to change my plans little bit.
> At the moment I think the most prioritized task is to make the
> display_tbl.lib.php file as a PHP class.
> So, if there is no matter of that, I'll involve with this task in this
> week (In my third week).
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I have a plan on introducing Display class instead of the set of global
functions inside the display_tbl.lib.php file.

Currently the only function which used by the outsiders is PMA_getTable().
And the only outside file accessed this function is sql.php file.

With the Display class,
All fields and methods other that getTable() method are keep as private.
To remove the use of global fields in every function, instance variables
are used and they are initialized by a separate function which is inside
the getTable() method. For initializing them Global variables are used.

I have documented the rough plan about my design in my blog [0].
The design for this should also be extend with the future plans of PMA.
So I'm waiting to hear your comments and suggestions to create a solid
design.

[0] :
http://chanakaindrajith.blogspot.com/2012/05/design-for-display-class-of-pma.html

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On 22/05/12 12:57, Chanaka Dharmarathna wrote:
> On Tue, May 22, 2012 at 12:54 AM, Chanaka Dharmarathna<
> pe.chanaka.ck@...>  wrote:
>
>>
>>
>> On Mon, May 21, 2012 at 6:58 PM, Chanaka Dharmarathna<
>> pe.chanaka.ck@...>  wrote:
>>
>>>
>>>
>>> On Mon, May 21, 2012 at 6:31 PM, Michal Čihař<michal@...>  wrote:
>>>
>>>> Hi
>>>>
>>>> Dne Mon, 21 May 2012 12:28:42 +0530
>>>> Chanaka Dharmarathna<pe.chanaka.ck@...>  napsal(a):
>>>>
>>>>> Thanks for giving your feedback.
>>>>> Yes, I did more changes to the code.
>>>>> Pleas get me into the right track if I'm going wrong.
>>>>
>>>> I think you're heading in right direction - splitting the code to
>>>> smaller blocks which are easy to understand always helps.
>>>>
>>>> I'm currently commenting some things in your commits, so let's keep
>>>> this part on github.
>>>>
>>>> --
>>>>         Michal Čihař | http://cihar.com | http://blog.cihar.com
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Live Security Virtual Conference
>>>> Exclusive live event will cover all the ways today's security and
>>>> threat landscape has changed and how IT managers can respond. Discussions
>>>> will include endpoint security, mobile security and the latest in malware
>>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>>> _______________________________________________
>>>> Phpmyadmin-devel mailing list
>>>> Phpmyadmin-devel@...
>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>
>>>>
>>> Hi Michal,
>>>
>>> That's good to hear.
>>> I put a reply in github
>>>
>>>
>>> Regards !
>>> --
>>> ____________________________________
>>>
>>> Chanaka Indrajith
>>> Bsc.Computer Engineering Undergraduate
>>> Faculty of Engineering
>>> University of Peradeniya
>>> Sri Lanka
>>> ____________________________________
>>>
>>>
>> Hi Michal,
>>
>> I'm going to change my plans little bit.
>> At the moment I think the most prioritized task is to make the
>> display_tbl.lib.php file as a PHP class.
>> So, if there is no matter of that, I'll involve with this task in this
>> week (In my third week).
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> I have a plan on introducing Display class instead of the set of global
> functions inside the display_tbl.lib.php file.
>
> Currently the only function which used by the outsiders is PMA_getTable().
> And the only outside file accessed this function is sql.php file.
>
> With the Display class,
> All fields and methods other that getTable() method are keep as private.
> To remove the use of global fields in every function, instance variables
> are used and they are initialized by a separate function which is inside
> the getTable() method. For initializing them Global variables are used.
>
> I have documented the rough plan about my design in my blog [0].
> The design for this should also be extend with the future plans of PMA.
> So I'm waiting to hear your comments and suggestions to create a solid
> design.
>
> [0] :
> http://chanakaindrajith.blogspot.com/2012/05/design-for-display-class-of-pma.html
>
> Regards !

Not sure why your methods are static and you have an initialisation 
method. To me it makes more sense to have non-static methods are the use 
of a constructor for the class. This way, the usage will be even more 
extensible. Also the class name is not very descriptive.

How about something like this?

$table = PMA_TableDisplay($GLOBALS['db'], $GLOBALS['table']);
echo $table->getDisplay();

class PMA_TableDisplay {
     private $_db;
     private $_table;
     public function __contruct($db, $table) {
         $this->_db = $db;
         $this->_table = $table;
     }
     public function getDisplay() {
         // ...
     }
     private static function getTableHeaders() {
         // ...
         $msg = getMessage($this->_db, $this->_table);
         // ...
     }
     // ...
}

BTW, what about extending our existing PMA_Table class? I'm not sure how 
good of an idea it is, so I'm just throwing it out there...

Bye,
Rouslan

On Tue, May 22, 2012 at 6:02 PM, Rouslan Placella <rouslan@...:

> On 22/05/12 12:57, Chanaka Dharmarathna wrote:
> > On Tue, May 22, 2012 at 12:54 AM, Chanaka Dharmarathna<
> > pe.chanaka.ck@...>  wrote:
> >
> >>
> >>
> >> On Mon, May 21, 2012 at 6:58 PM, Chanaka Dharmarathna<
> >> pe.chanaka.ck@...>  wrote:
> >>
> >>>
> >>>
> >>> On Mon, May 21, 2012 at 6:31 PM, Michal Čihař<michal@...>
>  wrote:
> >>>
> >>>> Hi
> >>>>
> >>>> Dne Mon, 21 May 2012 12:28:42 +0530
> >>>> Chanaka Dharmarathna<pe.chanaka.ck@...>  napsal(a):
> >>>>
> >>>>> Thanks for giving your feedback.
> >>>>> Yes, I did more changes to the code.
> >>>>> Pleas get me into the right track if I'm going wrong.
> >>>>
> >>>> I think you're heading in right direction - splitting the code to
> >>>> smaller blocks which are easy to understand always helps.
> >>>>
> >>>> I'm currently commenting some things in your commits, so let's keep
> >>>> this part on github.
> >>>>
> >>>> --
> >>>>         Michal Čihař | http://cihar.com | http://blog.cihar.com
> >>>>
> >>>>
> >>>>
> ------------------------------------------------------------------------------
> >>>> Live Security Virtual Conference
> >>>> Exclusive live event will cover all the ways today's security and
> >>>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>>> will include endpoint security, mobile security and the latest in
> malware
> >>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>>> _______________________________________________
> >>>> Phpmyadmin-devel mailing list
> >>>> Phpmyadmin-devel@...
> >>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>>
> >>>>
> >>> Hi Michal,
> >>>
> >>> That's good to hear.
> >>> I put a reply in github
> >>>
> >>>
> >>> Regards !
> >>> --
> >>> ____________________________________
> >>>
> >>> Chanaka Indrajith
> >>> Bsc.Computer Engineering Undergraduate
> >>> Faculty of Engineering
> >>> University of Peradeniya
> >>> Sri Lanka
> >>> ____________________________________
> >>>
> >>>
> >> Hi Michal,
> >>
> >> I'm going to change my plans little bit.
> >> At the moment I think the most prioritized task is to make the
> >> display_tbl.lib.php file as a PHP class.
> >> So, if there is no matter of that, I'll involve with this task in this
> >> week (In my third week).
> >>
> >>
> >> Regards !
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >>
> > Hi Michal,
> >
> > I have a plan on introducing Display class instead of the set of global
> > functions inside the display_tbl.lib.php file.
> >
> > Currently the only function which used by the outsiders is
> PMA_getTable().
> > And the only outside file accessed this function is sql.php file.
> >
> > With the Display class,
> > All fields and methods other that getTable() method are keep as private.
> > To remove the use of global fields in every function, instance variables
> > are used and they are initialized by a separate function which is inside
> > the getTable() method. For initializing them Global variables are used.
> >
> > I have documented the rough plan about my design in my blog [0].
> > The design for this should also be extend with the future plans of PMA.
> > So I'm waiting to hear your comments and suggestions to create a solid
> > design.
> >
> > [0] :
> >
> http://chanakaindrajith.blogspot.com/2012/05/design-for-display-class-of-pma.html
> >
> > Regards !
>
> Not sure why your methods are static and you have an initialisation
> method. To me it makes more sense to have non-static methods are the use
> of a constructor for the class. This way, the usage will be even more
> extensible. Also the class name is not very descriptive.
>
> How about something like this?
>
> $table = PMA_TableDisplay($GLOBALS['db'], $GLOBALS['table']);
> echo $table->getDisplay();
>
> class PMA_TableDisplay {
>     private $_db;
>     private $_table;
>     public function __contruct($db, $table) {
>         $this->_db = $db;
>         $this->_table = $table;
>     }
>     public function getDisplay() {
>         // ...
>     }
>     private static function getTableHeaders() {
>         // ...
>         $msg = getMessage($this->_db, $this->_table);
>         // ...
>     }
>     // ...
> }
>
> BTW, what about extending our existing PMA_Table class? I'm not sure how
> good of an idea it is, so I'm just throwing it out there...
>
> Bye,
> Rouslan
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Rouslan,

Thanks for participating to this discussion and share your valuable
suggestions.

As I remember Michal has already suggested to not to use an object of this
case.
And use PMA_Display::someFunction where needed.
Thats why I focused on static fields and behaviors.

The constructor of the function only executed, if create an object of a
class. (I think your code trying to say create an object, new keyword is
missing there).
So I don't think to get the use of a constructor. That's why I'm using a
function for initialize instance variables.

I'm agreed to use more meaningful name. It is better if we can name it as
PMA_DisplayTable .

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

Dne Tue, 22 May 2012 22:37:47 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> On Tue, May 22, 2012 at 6:02 PM, Rouslan Placella <rouslan@...:
> > BTW, what about extending our existing PMA_Table class? I'm not sure how
> > good of an idea it is, so I'm just throwing it out there...

I don't think this would be useful, this class should care less about
table (actually should be table independent) and more oriented on
displaying results.

> Thanks for participating to this discussion and share your valuable
> suggestions.
> 
> As I remember Michal has already suggested to not to use an object of this
> case.
> And use PMA_Display::someFunction where needed.
> Thats why I focused on static fields and behaviors.

Well it was just a naming condition, you should really make that
object, get parameters in constructor. So basically Rouslans example is
what I would expect.

> The constructor of the function only executed, if create an object of a
> class. (I think your code trying to say create an object, new keyword is
> missing there).
> So I don't think to get the use of a constructor. That's why I'm using a
> function for initialize instance variables.
> 
> I'm agreed to use more meaningful name. It is better if we can name it as
> PMA_DisplayTable .

PMA_DisplayResults might be better. Please remember this should not be
about displaying tables but results of any SQL query - results of
stored procedure, browsing SQL processes or displaying binary log.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On Wed, May 23, 2012 at 12:14 PM, Michal Čihař <michal@...> wrote:

> Hi
>
> Dne Tue, 22 May 2012 22:37:47 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
> > On Tue, May 22, 2012 at 6:02 PM, Rouslan Placella <rouslan@...
> >wrote:
> > > BTW, what about extending our existing PMA_Table class? I'm not sure
> how
> > > good of an idea it is, so I'm just throwing it out there...
>
> I don't think this would be useful, this class should care less about
> table (actually should be table independent) and more oriented on
> displaying results.
>
> > Thanks for participating to this discussion and share your valuable
> > suggestions.
> >
> > As I remember Michal has already suggested to not to use an object of
> this
> > case.
> > And use PMA_Display::someFunction where needed.
> > Thats why I focused on static fields and behaviors.
>
> Well it was just a naming condition, you should really make that
> object, get parameters in constructor. So basically Rouslans example is
> what I would expect.
>
> > The constructor of the function only executed, if create an object of a
> > class. (I think your code trying to say create an object, new keyword is
> > missing there).
> > So I don't think to get the use of a constructor. That's why I'm using a
> > function for initialize instance variables.
> >
> > I'm agreed to use more meaningful name. It is better if we can name it as
> > PMA_DisplayTable .
>
> PMA_DisplayResults might be better. Please remember this should not be
> about displaying tables but results of any SQL query - results of
> stored procedure, browsing SQL processes or displaying binary log.
>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Michal,

I was thinking of get the use of this class by using an object as in my
proposal [0].
But, I had misunderstood your comment about creating an object.
That's why I looked into this way.
Any way it's a mistake by me.

Thanks for getting me into the right track soon.
I'll introduce the new design of the class as soon as possible.

[0] :
http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/chanaka777/1

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

Dne Wed, 23 May 2012 12:48:28 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> I was thinking of get the use of this class by using an object as in my
> proposal [0].
> But, I had misunderstood your comment about creating an object.
> That's why I looked into this way.
> Any way it's a mistake by me.

Sorry for that, I actually hate PHP way of object::method and
object->method :-).

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On Wed, May 23, 2012 at 2:36 PM, Michal Čihař <michal@...> wrote:

> Hi
>
> Dne Wed, 23 May 2012 12:48:28 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
> > I was thinking of get the use of this class by using an object as in my
> > proposal [0].
> > But, I had misunderstood your comment about creating an object.
> > That's why I looked into this way.
> > Any way it's a mistake by me.
>
> Sorry for that, I actually hate PHP way of object::method and
> object->method :-).
>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Michal,

It is okay Michal, I understood it incorrectly.

I have updated my blog[0] with the updated design.
The file should be named as DisplayResults.class.php right ?

If you are okay with the design I can start the implementation.
But if their should be any improvements please let me know.

[0] :
http://chanakaindrajith.blogspot.com/2012/05/design-for-display-class-of-pma.html

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

Dne Wed, 23 May 2012 15:55:38 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> I have updated my blog[0] with the updated design.
> The file should be named as DisplayResults.class.php right ?
> 
> If you are okay with the design I can start the implementation.
> But if their should be any improvements please let me know.

Yes it looks okay. Maybe just the method should be called something
like getHtml.

On the other topic - I've merged your changes so far and as you can see
[1] they produced lot of coding style violations. Please try to prevent
this in future work. I'm committing fixes right now so that you can
check the mistakes.

[1]: https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1491/

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On 5/23/12, Michal Čihař <michal@...> wrote:
> Hi
>
> Dne Wed, 23 May 2012 15:55:38 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
>> I have updated my blog[0] with the updated design.
>> The file should be named as DisplayResults.class.php right ?
>>
>> If you are okay with the design I can start the implementation.
>> But if their should be any improvements please let me know.
>
> Yes it looks okay. Maybe just the method should be called something
> like getHtml.
>
> On the other topic - I've merged your changes so far and as you can see
> [1] they produced lot of coding style violations. Please try to prevent
> this in future work. I'm committing fixes right now so that you can
> check the mistakes.
>
> [1]: https://ci.phpmyadmin.net/job/phpMyAdmin-continuous/1491/
>
> --
> 	Michal Čihař | http://cihar.com | http://blog.cihar.com
>

Hi Michal,

Its great to heard that you have merge my changes to the master branch.
I'll consider more on coding style in the future work and fix existing ones.

I'll start implementation on the PMA_DisplayResults class soon.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

Dne Wed, 23 May 2012 18:47:18 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> Its great to heard that you have merge my changes to the master branch.
> I'll consider more on coding style in the future work and fix existing ones.

You should run phpcs locally to see possible violations when you're
making changes, it's documented on the wiki:

http://wiki.phpmyadmin.net/pma/CodeSniffer

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

On Wed, May 23, 2012 at 8:15 PM, Michal Čihař <michal@...> wrote:

> Hi
>
> Dne Wed, 23 May 2012 18:47:18 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>
> > Its great to heard that you have merge my changes to the master branch.
> > I'll consider more on coding style in the future work and fix existing
> ones.
>
> You should run phpcs locally to see possible violations when you're
> making changes, it's documented on the wiki:
>
> http://wiki.phpmyadmin.net/pma/CodeSniffer
>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Michal,

Thanks for helping more in that case.
I'll follow that procedure.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Wed, May 23, 2012 at 11:11 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Wed, May 23, 2012 at 8:15 PM, Michal Čihař <michal@...> wrote:
>
>> Hi
>>
>> Dne Wed, 23 May 2012 18:47:18 +0530
>> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>>
>> > Its great to heard that you have merge my changes to the master branch.
>> > I'll consider more on coding style in the future work and fix existing
>> ones.
>>
>> You should run phpcs locally to see possible violations when you're
>> making changes, it's documented on the wiki:
>>
>> http://wiki.phpmyadmin.net/pma/CodeSniffer
>>
>> --
>>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
> Hi Michal,
>
> Thanks for helping more in that case.
> I'll follow that procedure.
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

Its indeed, you have fixed large number of coding violation issues in my
code.
Thanks for doing it for me.
And now I'm fixing existing coding violations.

I have a doubt on introducing or changing a string.
If we newly introduce a string or change existing one, do we need to make
the changes for any other files like language files (es.po, en_GB.po) ?

As well I feel its better to have more clarification on your word on the
design of PMA_DisplayResults class.
"Yes it looks okay. Maybe just the method should be called something like
getHtml. "
Can you please explain me about the getHtml thing ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

2012/5/24 Chanaka Dharmarathna <pe.chanaka.ck@...>:
>
>
> On Wed, May 23, 2012 at 11:11 PM, Chanaka Dharmarathna
> <pe.chanaka.ck@...> wrote:
>>
>>
>>
>> On Wed, May 23, 2012 at 8:15 PM, Michal Čihař <michal@...> wrote:
>>>
>>> Hi
>>>
>>> Dne Wed, 23 May 2012 18:47:18 +0530
>>> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
>>>
>>> > Its great to heard that you have merge my changes to the master branch.
>>> > I'll consider more on coding style in the future work and fix existing
>>> > ones.
>>>
>>> You should run phpcs locally to see possible violations when you're
>>> making changes, it's documented on the wiki:
>>>
>>> http://wiki.phpmyadmin.net/pma/CodeSniffer
>>>
>>> --
>>>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>
>> Hi Michal,
>>
>> Thanks for helping more in that case.
>> I'll follow that procedure.
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>
> Hi Michal,
>
> Its indeed, you have fixed large number of coding violation issues in my
> code.
> Thanks for doing it for me.
> And now I'm fixing existing coding violations.
>
> I have a doubt on introducing or changing a string.
> If we newly introduce a string or change existing one, do we need to make
> the changes for any other files like language files (es.po, en_GB.po) ?

There is no need to change the .po files manually. There is a script
to update the .po files. But you don't need to run it in your branch,
the .po files will be updated when your changes are merged with
master.

Anyway, make sure to use the __() method for translatable strings.
More info can be found on our wiki [0]

On a related note, if you output variables (as part of a translatable
string, or seperately), make sure to escape them properly, please
check our wiki regarding this, especially the part about escaping html
output : [1]

> As well I feel its better to have more clarification on your word on the
> design of PMA_DisplayResults class.
>
> "Yes it looks okay. Maybe just the method should be called something like
> getHtml. "
> Can you please explain me about the getHtml thing ?

I think Michal means that method getHtml() should generate and return
a html string.
When calling the method you would get something like this :

$class_results = new PMA_DisplayResults();
echo $class_results->getHtml();


[0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers
[1] http://wiki.phpmyadmin.net/pma/Security_pitfalls

-- 
Kind regards,

Dieter Adriaenssens

On Fri, May 25, 2012 at 4:40 PM, Dieter Adriaenssens <
dieter.adriaenssens@...> wrote:

> 2012/5/24 Chanaka Dharmarathna <pe.chanaka.ck@...>:
> >
> >
> > On Wed, May 23, 2012 at 11:11 PM, Chanaka Dharmarathna
> > <pe.chanaka.ck@...> wrote:
> >>
> >>
> >>
> >> On Wed, May 23, 2012 at 8:15 PM, Michal Čihař <michal@...> wrote:
> >>>
> >>> Hi
> >>>
> >>> Dne Wed, 23 May 2012 18:47:18 +0530
> >>> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):
> >>>
> >>> > Its great to heard that you have merge my changes to the master
> branch.
> >>> > I'll consider more on coding style in the future work and fix
> existing
> >>> > ones.
> >>>
> >>> You should run phpcs locally to see possible violations when you're
> >>> making changes, it's documented on the wiki:
> >>>
> >>> http://wiki.phpmyadmin.net/pma/CodeSniffer
> >>>
> >>> --
> >>>        Michal Čihař | http://cihar.com | http://blog.cihar.com
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Live Security Virtual Conference
> >>> Exclusive live event will cover all the ways today's security and
> >>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>> will include endpoint security, mobile security and the latest in
> malware
> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>> _______________________________________________
> >>> Phpmyadmin-devel mailing list
> >>> Phpmyadmin-devel@...
> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>
> >>
> >> Hi Michal,
> >>
> >> Thanks for helping more in that case.
> >> I'll follow that procedure.
> >>
> >>
> >> Regards !
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >
> > Hi Michal,
> >
> > Its indeed, you have fixed large number of coding violation issues in my
> > code.
> > Thanks for doing it for me.
> > And now I'm fixing existing coding violations.
> >
> > I have a doubt on introducing or changing a string.
> > If we newly introduce a string or change existing one, do we need to make
> > the changes for any other files like language files (es.po, en_GB.po) ?
>
> There is no need to change the .po files manually. There is a script
> to update the .po files. But you don't need to run it in your branch,
> the .po files will be updated when your changes are merged with
> master.
>
> Anyway, make sure to use the __() method for translatable strings.
> More info can be found on our wiki [0]
>
> On a related note, if you output variables (as part of a translatable
> string, or seperately), make sure to escape them properly, please
> check our wiki regarding this, especially the part about escaping html
> output : [1]
>
> > As well I feel its better to have more clarification on your word on the
> > design of PMA_DisplayResults class.
> >
> > "Yes it looks okay. Maybe just the method should be called something like
> > getHtml. "
> > Can you please explain me about the getHtml thing ?
>
> I think Michal means that method getHtml() should generate and return
> a html string.
> When calling the method you would get something like this :
>
> $class_results = new PMA_DisplayResults();
> echo $class_results->getHtml();
>
>
> [0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers
> [1] http://wiki.phpmyadmin.net/pma/Security_pitfalls
>
> --
> Kind regards,
>
> Dieter Adriaenssens
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Dieter,

Thanks for your valuable information and pointing those links.
That will be very helpful for me.
I'll follow that procedure.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi All,

I have a doubt of using *@see* tag in Docblock comments for functions.
In the comments of functions PMA_getTable() and PMA_getTableBody() in
display_tbl.lib.php file, @see tag is used for different purposes.
As I feel PMA_getTableBody() used that corrrectly.
What should be the actual behavior ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Fri, Jun 8, 2012 at 10:58 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

> Hi All,
>
> I have a doubt of using *@see* tag in Docblock comments for functions.
> In the comments of functions PMA_getTable() and PMA_getTableBody() in
> display_tbl.lib.php file, @see tag is used for different purposes.
> As I feel PMA_getTableBody() used that corrrectly.
> What should be the actual behavior ?
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi All,

I am fixing some code violations in my code now.
For remove code violation of large comparison in a if condition, what would
be the better approach ?

Ex:-
if ((PMA_strlen($wkbval) > $GLOBALS['cfg']['LimitChars'])
    && ($_SESSION['tmp_user_values']['display_text'] ==
self::DISPLAY_PARTIAL_TEXT)
) {
// code
}

Is that good to use tempory variable insted of using
$_SESSION['tmp_user_values']['display_text'] ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Le 2012-06-09 15:44, Chanaka Dharmarathna a écrit :
> On Fri, Jun 8, 2012 at 10:58 AM, Chanaka Dharmarathna <
> pe.chanaka.ck@...> wrote:
> 
>> Hi All,
>>
>> I have a doubt of using *@see* tag in Docblock comments for functions.
>> In the comments of functions PMA_getTable() and PMA_getTableBody() in
>> display_tbl.lib.php file, @see tag is used for different purposes.
>> As I feel PMA_getTableBody() used that corrrectly.
>> What should be the actual behavior ?
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi All,
> 
> I am fixing some code violations in my code now.
> For remove code violation of large comparison in a if condition, what would
> be the better approach ?
> 
> Ex:-
> if ((PMA_strlen($wkbval) > $GLOBALS['cfg']['LimitChars'])
>     && ($_SESSION['tmp_user_values']['display_text'] ==
> self::DISPLAY_PARTIAL_TEXT)
> ) {
> // code
> }
> 
> Is that good to use tempory variable insted of using
> $_SESSION['tmp_user_values']['display_text'] ?
> 
> Regards !

Chanaka,
what kind of code violation is it? A line too long?

If it's the case, well we should adjust our violations tests because for
me, introducing an unneeded temporary variable just for that would
reduce readability.

-- 
Marc Delisle
http://infomarc.info

2012/6/9 Chanaka Dharmarathna <pe.chanaka.ck@...>:
>
>
> On Fri, Jun 8, 2012 at 10:58 AM, Chanaka Dharmarathna
> <pe.chanaka.ck@...> wrote:
>>
>> Hi All,
>>
>> I have a doubt of using @see tag in Docblock comments for functions.
>> In the comments of functions PMA_getTable() and PMA_getTableBody() in
>> display_tbl.lib.php file, @see tag is used for different purposes.
>> As I feel PMA_getTableBody() used that corrrectly.
>> What should be the actual behavior ?
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>
> Hi All,
>
> I am fixing some code violations in my code now.
> For remove code violation of large comparison in a if condition, what would
> be the better approach ?
>
> Ex:-
> if ((PMA_strlen($wkbval) > $GLOBALS['cfg']['LimitChars'])
>     && ($_SESSION['tmp_user_values']['display_text'] ==
> self::DISPLAY_PARTIAL_TEXT)
> ) {
> // code
> }
>
> Is that good to use tempory variable insted of using
> $_SESSION['tmp_user_values']['display_text'] ?

It depends :

If the value of $_SESSION['tmp_user_values']['display_text'] is used
later on in the code, you could assign it to a shorter local
(temporary) variable, and use that variable with a shorter name, in
the if statement and further on in the code.

If it is used only oncet you might consider assigning the result of

$_SESSION['tmp_user_values']['display_text'] == self::DISPLAY_PARTIAL_TEXT

to a local (temporary) variable and use that variable in the if statement.

Hope this helps!

-- 
Kind regards,

Dieter Adriaenssens

On Sun, Jun 10, 2012 at 5:02 AM, Marc Delisle <marc@...> wrote:

> Le 2012-06-09 15:44, Chanaka Dharmarathna a écrit :
> > On Fri, Jun 8, 2012 at 10:58 AM, Chanaka Dharmarathna <
> > pe.chanaka.ck@...> wrote:
> >
> >> Hi All,
> >>
> >> I have a doubt of using *@see* tag in Docblock comments for functions.
> >> In the comments of functions PMA_getTable() and PMA_getTableBody() in
> >> display_tbl.lib.php file, @see tag is used for different purposes.
> >> As I feel PMA_getTableBody() used that corrrectly.
> >> What should be the actual behavior ?
> >>
> >> Regards !
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >>
> > Hi All,
> >
> > I am fixing some code violations in my code now.
> > For remove code violation of large comparison in a if condition, what
> would
> > be the better approach ?
> >
> > Ex:-
> > if ((PMA_strlen($wkbval) > $GLOBALS['cfg']['LimitChars'])
> >     && ($_SESSION['tmp_user_values']['display_text'] ==
> > self::DISPLAY_PARTIAL_TEXT)
> > ) {
> > // code
> > }
> >
> > Is that good to use tempory variable insted of using
> > $_SESSION['tmp_user_values']['display_text'] ?
> >
> > Regards !
>
> Chanaka,
> what kind of code violation is it? A line too long?
>
> If it's the case, well we should adjust our violations tests because for
> me, introducing an unneeded temporary variable just for that would
> reduce readability.
>
> --
> Marc Delisle
> http://infomarc.info
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Marc,

Thanks for replying.
Yes, code sniffer gives warning saying line is too long.
I also feel its not a good idea to use temporary variable if only it is not
used couple of time.
Shall we define convention for this kind of scenario so that everywhere
handle this kind of situation in same way.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Sun, Jun 10, 2012 at 11:21 PM, Dieter Adriaenssens <
dieter.adriaenssens@...> wrote:

> 2012/6/9 Chanaka Dharmarathna <pe.chanaka.ck@...>:
> >
> >
> > On Fri, Jun 8, 2012 at 10:58 AM, Chanaka Dharmarathna
> > <pe.chanaka.ck@...> wrote:
> >>
> >> Hi All,
> >>
> >> I have a doubt of using @see tag in Docblock comments for functions.
> >> In the comments of functions PMA_getTable() and PMA_getTableBody() in
> >> display_tbl.lib.php file, @see tag is used for different purposes.
> >> As I feel PMA_getTableBody() used that corrrectly.
> >> What should be the actual behavior ?
> >>
> >> Regards !
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >
> > Hi All,
> >
> > I am fixing some code violations in my code now.
> > For remove code violation of large comparison in a if condition, what
> would
> > be the better approach ?
> >
> > Ex:-
> > if ((PMA_strlen($wkbval) > $GLOBALS['cfg']['LimitChars'])
> >     && ($_SESSION['tmp_user_values']['display_text'] ==
> > self::DISPLAY_PARTIAL_TEXT)
> > ) {
> > // code
> > }
> >
> > Is that good to use tempory variable insted of using
> > $_SESSION['tmp_user_values']['display_text'] ?
>
> It depends :
>
> If the value of $_SESSION['tmp_user_values']['display_text'] is used
> later on in the code, you could assign it to a shorter local
> (temporary) variable, and use that variable with a shorter name, in
> the if statement and further on in the code.
>
> If it is used only oncet you might consider assigning the result of
>
> $_SESSION['tmp_user_values']['display_text'] == self::DISPLAY_PARTIAL_TEXT
>
> to a local (temporary) variable and use that variable in the if statement.
>
> Hope this helps!
>
> --
> Kind regards,
>
> Dieter Adriaenssens
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Dieter,

Thanks for your reply.
I agreed your first point.
But I feels little odd in the second point because only for one place we
use an additional variable.
Its better if we can put that kind of conditions to two lines. Currently it
gives errors by code sniffer.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

I NEED TO REDIRECT MY WEBSITE.... HOW AND WHERE CAN I DO THAT????


From: Chanaka Dharmarathna <pe.chanaka.ck@...>
To: phpmyadmin-devel@... 
Sent: Monday, June 11, 2012 4:02 PM
Subject: Re: [Phpmyadmin-devel] Refactoring: Displaying query results





On Sun, Jun 10, 2012 at 11:21 PM, Dieter Adriaenssens <dieter.adriaenssens@...> wrote:

2012/6/9 Chanaka Dharmarathna <pe.chanaka.ck@...>:
>
>>
>>
>> On Fri, Jun 8, 2012 at 10:58 AM, Chanaka Dharmarathna
>> <pe.chanaka.ck@...> wrote:
>>>
>>> Hi All,
>>>
>>> I have a doubt of using @see tag in Docblock comments for functions.
>>> In the comments of functions PMA_getTable() and PMA_getTableBody() in
>>> display_tbl.lib.php file, @see tag is used for different purposes.
>>> As I feel PMA_getTableBody() used that corrrectly.
>>> What should be the actual behavior ?
>>>
>>> Regards !
>>> --
>>> ____________________________________
>>>
>>> Chanaka Indrajith
>>> Bsc.Computer Engineering Undergraduate
>>> Faculty of Engineering
>>> University of Peradeniya
>>> Sri Lanka
>>> ____________________________________
>>>
>>
>> Hi All,
>>
>> I am fixing some code violations in my code now.
>> For remove code violation of large comparison in a if condition, what would
>> be the better approach ?
>>
>> Ex:-
>> if ((PMA_strlen($wkbval) > $GLOBALS['cfg']['LimitChars'])
>>     && ($_SESSION['tmp_user_values']['display_text'] ==
>> self::DISPLAY_PARTIAL_TEXT)
>> ) {
>> // code
>> }
>>
>> Is that good to use tempory variable insted of using
>> $_SESSION['tmp_user_values']['display_text'] ?
>
>It depends :
>
>If the value of $_SESSION['tmp_user_values']['display_text'] is used
>later on in the code, you could assign it to a shorter local
>(temporary) variable, and use that variable with a shorter name, in
>the if statement and further on in the code.
>
>If it is used only oncet you might consider assigning the result of
>
>$_SESSION['tmp_user_values']['display_text'] == self::DISPLAY_PARTIAL_TEXT
>
>to a local (temporary) variable and use that variable in the if statement.
>
>Hope this helps!
>
>--
>Kind regards,
>
>Dieter Adriaenssens
>
>
>------------------------------------------------------------------------------
>Live Security Virtual Conference
>Exclusive live event will cover all the ways today's security and
>threat landscape has changed and how IT managers can respond. Discussions
>will include endpoint security, mobile security and the latest in malware
>threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>_______________________________________________
>Phpmyadmin-devel mailing list
>Phpmyadmin-devel@...
>https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
Hi Dieter,

Thanks for your reply.
I agreed your first point.
But I feels little odd in the second point because only for one place we use an additional variable.
Its better if we can put that kind of conditions to two lines. Currently it gives errors by code sniffer.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Phpmyadmin-devel mailing list
Phpmyadmin-devel@...
https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

Le 2012-06-11 16:26, Maria Medina a écrit :
> I NEED TO REDIRECT MY WEBSITE.... HOW AND WHERE CAN I DO THAT????

You could contact your web host provider, not this list.

-- 
Marc Delisle
http://infomarc.info

On Tue, Jun 12, 2012 at 1:32 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Sun, Jun 10, 2012 at 11:21 PM, Dieter Adriaenssens <
> dieter.adriaenssens@...> wrote:
>
>> 2012/6/9 Chanaka Dharmarathna <pe.chanaka.ck@...>:
>> >
>> >
>> > On Fri, Jun 8, 2012 at 10:58 AM, Chanaka Dharmarathna
>> > <pe.chanaka.ck@...> wrote:
>> >>
>> >> Hi All,
>> >>
>> >> I have a doubt of using @see tag in Docblock comments for functions.
>> >> In the comments of functions PMA_getTable() and PMA_getTableBody() in
>> >> display_tbl.lib.php file, @see tag is used for different purposes.
>> >> As I feel PMA_getTableBody() used that corrrectly.
>> >> What should be the actual behavior ?
>> >>
>> >> Regards !
>> >> --
>> >> ____________________________________
>> >>
>> >> Chanaka Indrajith
>> >> Bsc.Computer Engineering Undergraduate
>> >> Faculty of Engineering
>> >> University of Peradeniya
>> >> Sri Lanka
>> >> ____________________________________
>> >>
>> >
>> > Hi All,
>> >
>> > I am fixing some code violations in my code now.
>> > For remove code violation of large comparison in a if condition, what
>> would
>> > be the better approach ?
>> >
>> > Ex:-
>> > if ((PMA_strlen($wkbval) > $GLOBALS['cfg']['LimitChars'])
>> >     && ($_SESSION['tmp_user_values']['display_text'] ==
>> > self::DISPLAY_PARTIAL_TEXT)
>> > ) {
>> > // code
>> > }
>> >
>> > Is that good to use tempory variable insted of using
>> > $_SESSION['tmp_user_values']['display_text'] ?
>>
>> It depends :
>>
>> If the value of $_SESSION['tmp_user_values']['display_text'] is used
>> later on in the code, you could assign it to a shorter local
>> (temporary) variable, and use that variable with a shorter name, in
>> the if statement and further on in the code.
>>
>> If it is used only oncet you might consider assigning the result of
>>
>> $_SESSION['tmp_user_values']['display_text'] == self::DISPLAY_PARTIAL_TEXT
>>
>> to a local (temporary) variable and use that variable in the if statement.
>>
>> Hope this helps!
>>
>> --
>> Kind regards,
>>
>> Dieter Adriaenssens
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>
> Hi Dieter,
>
> Thanks for your reply.
> I agreed your first point.
> But I feels little odd in the second point because only for one place we
> use an additional variable.
> Its better if we can put that kind of conditions to two lines. Currently
> it gives errors by code sniffer.
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I'll moving into refactoring common.lib.php file.
I'm intending to use the same improvements for this file as
DisplayResults.class.php , including creating common.lib.php as a class.
Is there any suggestions from your side ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Thu, Jun 14, 2012 at 12:58 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Tue, Jun 12, 2012 at 1:32 AM, Chanaka Dharmarathna <
> pe.chanaka.ck@...> wrote:
>
>>
>>
>> On Sun, Jun 10, 2012 at 11:21 PM, Dieter Adriaenssens <
>> dieter.adriaenssens@...> wrote:
>>
>>> 2012/6/9 Chanaka Dharmarathna <pe.chanaka.ck@...>:
>>> >
>>> >
>>> > On Fri, Jun 8, 2012 at 10:58 AM, Chanaka Dharmarathna
>>> > <pe.chanaka.ck@...> wrote:
>>> >>
>>> >> Hi All,
>>> >>
>>> >> I have a doubt of using @see tag in Docblock comments for functions.
>>> >> In the comments of functions PMA_getTable() and PMA_getTableBody() in
>>> >> display_tbl.lib.php file, @see tag is used for different purposes.
>>> >> As I feel PMA_getTableBody() used that corrrectly.
>>> >> What should be the actual behavior ?
>>> >>
>>> >> Regards !
>>> >> --
>>> >> ____________________________________
>>> >>
>>> >> Chanaka Indrajith
>>> >> Bsc.Computer Engineering Undergraduate
>>> >> Faculty of Engineering
>>> >> University of Peradeniya
>>> >> Sri Lanka
>>> >> ____________________________________
>>> >>
>>> >
>>> > Hi All,
>>> >
>>> > I am fixing some code violations in my code now.
>>> > For remove code violation of large comparison in a if condition, what
>>> would
>>> > be the better approach ?
>>> >
>>> > Ex:-
>>> > if ((PMA_strlen($wkbval) > $GLOBALS['cfg']['LimitChars'])
>>> >     && ($_SESSION['tmp_user_values']['display_text'] ==
>>> > self::DISPLAY_PARTIAL_TEXT)
>>> > ) {
>>> > // code
>>> > }
>>> >
>>> > Is that good to use tempory variable insted of using
>>> > $_SESSION['tmp_user_values']['display_text'] ?
>>>
>>> It depends :
>>>
>>> If the value of $_SESSION['tmp_user_values']['display_text'] is used
>>> later on in the code, you could assign it to a shorter local
>>> (temporary) variable, and use that variable with a shorter name, in
>>> the if statement and further on in the code.
>>>
>>> If it is used only oncet you might consider assigning the result of
>>>
>>> $_SESSION['tmp_user_values']['display_text'] ==
>>> self::DISPLAY_PARTIAL_TEXT
>>>
>>> to a local (temporary) variable and use that variable in the if
>>> statement.
>>>
>>> Hope this helps!
>>>
>>> --
>>> Kind regards,
>>>
>>> Dieter Adriaenssens
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>
>> Hi Dieter,
>>
>> Thanks for your reply.
>> I agreed your first point.
>> But I feels little odd in the second point because only for one place we
>> use an additional variable.
>> Its better if we can put that kind of conditions to two lines. Currently
>> it gives errors by code sniffer.
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> I'll moving into refactoring common.lib.php file.
> I'm intending to use the same improvements for this file as
> DisplayResults.class.php , including creating common.lib.php as a class.
> Is there any suggestions from your side ?
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi All,

I have already create a class for display_tbl.lib.php
andPMA_getDataCellForBlobField() in master used the
PMA_mimeDefaultFunction() function as a global function.
EX :
$str = 'PMA_mimeDefaultFunction';
$str($parameters);

I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php (in
master) to common.lib.php file due to the way it has used inside
display_tbl.lib.php.

Now I'm implementing class behavior in common.lib.php file.
So can anyone tell me a file, which contain global function, to where I
should again move this PMA_mimeDefaultFunction().

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Le 2012-06-16 00:26, Chanaka Dharmarathna a écrit :

> Hi All,
> 
> I have already create a class for display_tbl.lib.php
> andPMA_getDataCellForBlobField() in master used the
> PMA_mimeDefaultFunction() function as a global function.
> EX :
> $str = 'PMA_mimeDefaultFunction';
> $str($parameters);
> 
> I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php (in
> master) to common.lib.php file due to the way it has used inside
> display_tbl.lib.php.
> 
> Now I'm implementing class behavior in common.lib.php file.
> So can anyone tell me a file, which contain global function, to where I
> should again move this PMA_mimeDefaultFunction().
> 
> Regards !

Chanaka,
I believe that this function should not be global, as it's only called
from other functions in libraries/DisplayResults.class.php, right?

-- 
Marc Delisle
http://infomarc.info

On Sun, Jun 17, 2012 at 4:39 PM, Marc Delisle <marc@...> wrote:

> Le 2012-06-16 00:26, Chanaka Dharmarathna a écrit :
>
> > Hi All,
> >
> > I have already create a class for display_tbl.lib.php
> > andPMA_getDataCellForBlobField() in master used the
> > PMA_mimeDefaultFunction() function as a global function.
> > EX :
> > $str = 'PMA_mimeDefaultFunction';
> > $str($parameters);
> >
> > I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php (in
> > master) to common.lib.php file due to the way it has used inside
> > display_tbl.lib.php.
> >
> > Now I'm implementing class behavior in common.lib.php file.
> > So can anyone tell me a file, which contain global function, to where I
> > should again move this PMA_mimeDefaultFunction().
> >
> > Regards !
>
> Chanaka,
> I believe that this function should not be global, as it's only called
> from other functions in libraries/DisplayResults.class.php, right?
>
> --
> Marc Delisle
> http://infomarc.info
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Marc,

Sorry for little bit delay to respond.
I first try to use this function while it is inside the PMA_DisplayResults
class.
But if there is any field with transformations, it does not work properly.

So that put it as a global function.
But I can again consider on that after completing the implement class
behavior of common.lib.php file
For just now I move PMA_mimeDefaultFunction() function to core.lib.php file.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Mon, Jun 18, 2012 at 6:36 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Sun, Jun 17, 2012 at 4:39 PM, Marc Delisle <marc@...> wrote:
>
>> Le 2012-06-16 00:26, Chanaka Dharmarathna a écrit :
>>
>> > Hi All,
>> >
>> > I have already create a class for display_tbl.lib.php
>> > andPMA_getDataCellForBlobField() in master used the
>> > PMA_mimeDefaultFunction() function as a global function.
>> > EX :
>> > $str = 'PMA_mimeDefaultFunction';
>> > $str($parameters);
>> >
>> > I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php (in
>> > master) to common.lib.php file due to the way it has used inside
>> > display_tbl.lib.php.
>> >
>> > Now I'm implementing class behavior in common.lib.php file.
>> > So can anyone tell me a file, which contain global function, to where I
>> > should again move this PMA_mimeDefaultFunction().
>> >
>> > Regards !
>>
>> Chanaka,
>> I believe that this function should not be global, as it's only called
>> from other functions in libraries/DisplayResults.class.php, right?
>>
>> --
>> Marc Delisle
>> http://infomarc.info
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>
> Hi Marc,
>
> Sorry for little bit delay to respond.
> I first try to use this function while it is inside the PMA_DisplayResults
> class.
> But if there is any field with transformations, it does not work properly.
>
> So that put it as a global function.
> But I can again consider on that after completing the implement class
> behavior of common.lib.php file
> For just now I move PMA_mimeDefaultFunction() function to core.lib.php
> file.
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

There are many places which are using functions in common.lib.php file.
After implement the class behavior for this file, all the other places need
to call those functions using an object of PMA_CommonFunctions class.
Even in the same file I may need to create several objects of the
PMA_CommonFunctions class. (files with global functions)

So I' thinking of using global variable (in $GLOBALS super global array) to
store an object of PMA_CommonFunctions class and introduce a global
function (may be under core.lib.php) to get that object by checking whether
the global variable is set or not.
So that even inside the procedural code segments, that function can be used.
Its highly appreciated if you can give me your feedback on this approach.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On 19/06/12 09:35, Chanaka Dharmarathna wrote:
> On Mon, Jun 18, 2012 at 6:36 PM, Chanaka Dharmarathna<
> pe.chanaka.ck@...>  wrote:
>
>>
>>
>> On Sun, Jun 17, 2012 at 4:39 PM, Marc Delisle<marc@...>  wrote:
>>
>>> Le 2012-06-16 00:26, Chanaka Dharmarathna a écrit :
>>>
>>>> Hi All,
>>>>
>>>> I have already create a class for display_tbl.lib.php
>>>> andPMA_getDataCellForBlobField() in master used the
>>>> PMA_mimeDefaultFunction() function as a global function.
>>>> EX :
>>>> $str = 'PMA_mimeDefaultFunction';
>>>> $str($parameters);
>>>>
>>>> I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php (in
>>>> master) to common.lib.php file due to the way it has used inside
>>>> display_tbl.lib.php.
>>>>
>>>> Now I'm implementing class behavior in common.lib.php file.
>>>> So can anyone tell me a file, which contain global function, to where I
>>>> should again move this PMA_mimeDefaultFunction().
>>>>
>>>> Regards !
>>>
>>> Chanaka,
>>> I believe that this function should not be global, as it's only called
>>> from other functions in libraries/DisplayResults.class.php, right?
>>>
>>> --
>>> Marc Delisle
>>> http://infomarc.info
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Live Security Virtual Conference
>>> Exclusive live event will cover all the ways today's security and
>>> threat landscape has changed and how IT managers can respond. Discussions
>>> will include endpoint security, mobile security and the latest in malware
>>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel@...
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>
>> Hi Marc,
>>
>> Sorry for little bit delay to respond.
>> I first try to use this function while it is inside the PMA_DisplayResults
>> class.
>> But if there is any field with transformations, it does not work properly.
>>
>> So that put it as a global function.
>> But I can again consider on that after completing the implement class
>> behavior of common.lib.php file
>> For just now I move PMA_mimeDefaultFunction() function to core.lib.php
>> file.
>>
>>
>> Regards !
>> --
>> ____________________________________
>>
>> Chanaka Indrajith
>> Bsc.Computer Engineering Undergraduate
>> Faculty of Engineering
>> University of Peradeniya
>> Sri Lanka
>> ____________________________________
>>
>>
> Hi Michal,
>
> There are many places which are using functions in common.lib.php file.
> After implement the class behavior for this file, all the other places need
> to call those functions using an object of PMA_CommonFunctions class.
> Even in the same file I may need to create several objects of the
> PMA_CommonFunctions class. (files with global functions)
>
> So I' thinking of using global variable (in $GLOBALS super global array) to
> store an object of PMA_CommonFunctions class and introduce a global
> function (may be under core.lib.php) to get that object by checking whether
> the global variable is set or not.
> So that even inside the procedural code segments, that function can be used.
> Its highly appreciated if you can give me your feedback on this approach.
>
> Regards !


What you seem to want is a singleton [0]. In a few words: the 
constructor is private, the instance is in a static variable and a 
public getInstance method allows access to the instance. You can also 
have a look at the PMA_Response class for a concrete example.

Bye,
Rouslan

[0]: http://en.wikipedia.org/wiki/Singleton_pattern

On Tue, Jun 19, 2012 at 2:37 PM, Rouslan Placella <rouslan@...:

> On 19/06/12 09:35, Chanaka Dharmarathna wrote:
> > On Mon, Jun 18, 2012 at 6:36 PM, Chanaka Dharmarathna<
> > pe.chanaka.ck@...>  wrote:
> >
> >>
> >>
> >> On Sun, Jun 17, 2012 at 4:39 PM, Marc Delisle<marc@...>
>  wrote:
> >>
> >>> Le 2012-06-16 00:26, Chanaka Dharmarathna a écrit :
> >>>
> >>>> Hi All,
> >>>>
> >>>> I have already create a class for display_tbl.lib.php
> >>>> andPMA_getDataCellForBlobField() in master used the
> >>>> PMA_mimeDefaultFunction() function as a global function.
> >>>> EX :
> >>>> $str = 'PMA_mimeDefaultFunction';
> >>>> $str($parameters);
> >>>>
> >>>> I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php
> (in
> >>>> master) to common.lib.php file due to the way it has used inside
> >>>> display_tbl.lib.php.
> >>>>
> >>>> Now I'm implementing class behavior in common.lib.php file.
> >>>> So can anyone tell me a file, which contain global function, to where
> I
> >>>> should again move this PMA_mimeDefaultFunction().
> >>>>
> >>>> Regards !
> >>>
> >>> Chanaka,
> >>> I believe that this function should not be global, as it's only called
> >>> from other functions in libraries/DisplayResults.class.php, right?
> >>>
> >>> --
> >>> Marc Delisle
> >>> http://infomarc.info
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> Live Security Virtual Conference
> >>> Exclusive live event will cover all the ways today's security and
> >>> threat landscape has changed and how IT managers can respond.
> Discussions
> >>> will include endpoint security, mobile security and the latest in
> malware
> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> >>> _______________________________________________
> >>> Phpmyadmin-devel mailing list
> >>> Phpmyadmin-devel@...
> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >>>
> >>
> >> Hi Marc,
> >>
> >> Sorry for little bit delay to respond.
> >> I first try to use this function while it is inside the
> PMA_DisplayResults
> >> class.
> >> But if there is any field with transformations, it does not work
> properly.
> >>
> >> So that put it as a global function.
> >> But I can again consider on that after completing the implement class
> >> behavior of common.lib.php file
> >> For just now I move PMA_mimeDefaultFunction() function to core.lib.php
> >> file.
> >>
> >>
> >> Regards !
> >> --
> >> ____________________________________
> >>
> >> Chanaka Indrajith
> >> Bsc.Computer Engineering Undergraduate
> >> Faculty of Engineering
> >> University of Peradeniya
> >> Sri Lanka
> >> ____________________________________
> >>
> >>
> > Hi Michal,
> >
> > There are many places which are using functions in common.lib.php file.
> > After implement the class behavior for this file, all the other places
> need
> > to call those functions using an object of PMA_CommonFunctions class.
> > Even in the same file I may need to create several objects of the
> > PMA_CommonFunctions class. (files with global functions)
> >
> > So I' thinking of using global variable (in $GLOBALS super global array)
> to
> > store an object of PMA_CommonFunctions class and introduce a global
> > function (may be under core.lib.php) to get that object by checking
> whether
> > the global variable is set or not.
> > So that even inside the procedural code segments, that function can be
> used.
> > Its highly appreciated if you can give me your feedback on this approach.
> >
> > Regards !
>
>
> What you seem to want is a singleton [0]. In a few words: the
> constructor is private, the instance is in a static variable and a
> public getInstance method allows access to the instance. You can also
> have a look at the PMA_Response class for a concrete example.
>
> Bye,
> Rouslan
>
> [0]: http://en.wikipedia.org/wiki/Singleton_pattern
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

Hi Rouslan,

Thanks for your quick and valuable information.
Singleton pattern definitely use only one object and it save the memory.
I'll use that.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Tue, Jun 19, 2012 at 3:23 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
> On Tue, Jun 19, 2012 at 2:37 PM, Rouslan Placella <rouslan@...:
>
>> On 19/06/12 09:35, Chanaka Dharmarathna wrote:
>> > On Mon, Jun 18, 2012 at 6:36 PM, Chanaka Dharmarathna<
>> > pe.chanaka.ck@...>  wrote:
>> >
>> >>
>> >>
>> >> On Sun, Jun 17, 2012 at 4:39 PM, Marc Delisle<marc@...>
>>  wrote:
>> >>
>> >>> Le 2012-06-16 00:26, Chanaka Dharmarathna a écrit :
>> >>>
>> >>>> Hi All,
>> >>>>
>> >>>> I have already create a class for display_tbl.lib.php
>> >>>> andPMA_getDataCellForBlobField() in master used the
>> >>>> PMA_mimeDefaultFunction() function as a global function.
>> >>>> EX :
>> >>>> $str = 'PMA_mimeDefaultFunction';
>> >>>> $str($parameters);
>> >>>>
>> >>>> I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php
>> (in
>> >>>> master) to common.lib.php file due to the way it has used inside
>> >>>> display_tbl.lib.php.
>> >>>>
>> >>>> Now I'm implementing class behavior in common.lib.php file.
>> >>>> So can anyone tell me a file, which contain global function, to
>> where I
>> >>>> should again move this PMA_mimeDefaultFunction().
>> >>>>
>> >>>> Regards !
>> >>>
>> >>> Chanaka,
>> >>> I believe that this function should not be global, as it's only called
>> >>> from other functions in libraries/DisplayResults.class.php, right?
>> >>>
>> >>> --
>> >>> Marc Delisle
>> >>> http://infomarc.info
>> >>>
>> >>>
>> >>>
>> ------------------------------------------------------------------------------
>> >>> Live Security Virtual Conference
>> >>> Exclusive live event will cover all the ways today's security and
>> >>> threat landscape has changed and how IT managers can respond.
>> Discussions
>> >>> will include endpoint security, mobile security and the latest in
>> malware
>> >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> >>> _______________________________________________
>> >>> Phpmyadmin-devel mailing list
>> >>> Phpmyadmin-devel@...
>> >>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>> >>>
>> >>
>> >> Hi Marc,
>> >>
>> >> Sorry for little bit delay to respond.
>> >> I first try to use this function while it is inside the
>> PMA_DisplayResults
>> >> class.
>> >> But if there is any field with transformations, it does not work
>> properly.
>> >>
>> >> So that put it as a global function.
>> >> But I can again consider on that after completing the implement class
>> >> behavior of common.lib.php file
>> >> For just now I move PMA_mimeDefaultFunction() function to core.lib.php
>> >> file.
>> >>
>> >>
>> >> Regards !
>> >> --
>> >> ____________________________________
>> >>
>> >> Chanaka Indrajith
>> >> Bsc.Computer Engineering Undergraduate
>> >> Faculty of Engineering
>> >> University of Peradeniya
>> >> Sri Lanka
>> >> ____________________________________
>> >>
>> >>
>> > Hi Michal,
>> >
>> > There are many places which are using functions in common.lib.php file.
>> > After implement the class behavior for this file, all the other places
>> need
>> > to call those functions using an object of PMA_CommonFunctions class.
>> > Even in the same file I may need to create several objects of the
>> > PMA_CommonFunctions class. (files with global functions)
>> >
>> > So I' thinking of using global variable (in $GLOBALS super global
>> array) to
>> > store an object of PMA_CommonFunctions class and introduce a global
>> > function (may be under core.lib.php) to get that object by checking
>> whether
>> > the global variable is set or not.
>> > So that even inside the procedural code segments, that function can be
>> used.
>> > Its highly appreciated if you can give me your feedback on this
>> approach.
>> >
>> > Regards !
>>
>>
>> What you seem to want is a singleton [0]. In a few words: the
>> constructor is private, the instance is in a static variable and a
>> public getInstance method allows access to the instance. You can also
>> have a look at the PMA_Response class for a concrete example.
>>
>> Bye,
>> Rouslan
>>
>> [0]: http://en.wikipedia.org/wiki/Singleton_pattern
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel@...
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>
> Hi Rouslan,
>
> Thanks for your quick and valuable information.
> Singleton pattern definitely use only one object and it save the memory.
> I'll use that.
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
Hi Michal,

I almost did the modifications related to introduce class behavior of
common.lib.php file.
It is quite time consuming task since there are lot of files to do the
minor modifications.

Now I'm facing to a problem.
Due to this changes code has not working properly. (I didn't commit the
code yet since it is not working)
Is there any log file or something where we can see code is breaking?
Since this is not just one file its very hard to find out the errors.
Looking for suggestions to debug this code.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

First comment: Please try to remove useless previous discussion when
posting new email.

Dne Fri, 22 Jun 2012 00:57:35 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> I almost did the modifications related to introduce class behavior of
> common.lib.php file.
> It is quite time consuming task since there are lot of files to do the
> minor modifications.

Indeed, it will take some time.

> Now I'm facing to a problem.
> Due to this changes code has not working properly. (I didn't commit the
> code yet since it is not working)
> Is there any log file or something where we can see code is breaking?
> Since this is not just one file its very hard to find out the errors.
> Looking for suggestions to debug this code.

What kind of error do you get? Do you have enabled gathering and
displaying of errors [1]?

[1]: http://wiki.phpmyadmin.net/pma/Config#Error_Handler


-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com

Hi Michal,

First comment: Please try to remove useless previous discussion when
> posting new email.
>

Sure, I'll follow your instructions.


> What kind of error do you get? Do you have enabled gathering and
> displaying of errors [1]?
>
> [1]: http://wiki.phpmyadmin.net/pma/Confi<http://wiki.phpmyadmin.net/pma/Config#Error_Handler>
>

 Actually I got nothing after login to PMA.
I had only enabled display errors but not others.
But now I am debugging the error points after following suggested link.
Thanks for your great guide.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

> > Hi All,
> >
> > I have already create a class for display_tbl.lib.php
> > andPMA_getDataCellForBlobField() in master used the
> > PMA_mimeDefaultFunction() function as a global function.
> > EX :
> > $str = 'PMA_mimeDefaultFunction';
> > $str($parameters);
> >
> > I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php (in
> > master) to common.lib.php file due to the way it has used inside
> > display_tbl.lib.php.
> >
> > Now I'm implementing class behavior in common.lib.php file.
> > So can anyone tell me a file, which contain global function, to where I
> > should again move this PMA_mimeDefaultFunction().
> >
> > Regards !
>
> Chanaka,
> I believe that this function should not be global, as it's only called
> from other functions in libraries/DisplayResults.class.php, right?
>
>
Hi Marc,

I'm going to look into getting PMA_mimeDefaultFunction() function inside
PMA_DisplayResults class. (currently it is under core.lib.php)
I think it is possible to use this function inside that class, and call
directly ($this->_mimeDefaultFunction()) instead of using additional string
to store method name. (current way)

Then the default function for the mime transformation is inside a class.
But the other existing transformations functions are still global functions.
If that is not good (feels not good), those also should convert to classes.

And if other transformations converted to classes, in which way I can
create objects of those classes.
Should I need to use string to store the class name and then use it as
belows.

$class_name = 'TestClass';
$ob = new $class_name($params);

It is very helpful for me if you can share your suggestions.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Le 2012-06-27 22:04, Chanaka Dharmarathna a écrit :
>>> Hi All,
>>>
>>> I have already create a class for display_tbl.lib.php
>>> andPMA_getDataCellForBlobField() in master used the
>>> PMA_mimeDefaultFunction() function as a global function.
>>> EX :
>>> $str = 'PMA_mimeDefaultFunction';
>>> $str($parameters);
>>>
>>> I have moved the PMA_mimeDefaultFunction() from display_tbl.lib.php (in
>>> master) to common.lib.php file due to the way it has used inside
>>> display_tbl.lib.php.
>>>
>>> Now I'm implementing class behavior in common.lib.php file.
>>> So can anyone tell me a file, which contain global function, to where I
>>> should again move this PMA_mimeDefaultFunction().
>>>
>>> Regards !
>>
>> Chanaka,
>> I believe that this function should not be global, as it's only called
>> from other functions in libraries/DisplayResults.class.php, right?
>>
>>
> Hi Marc,
> 
> I'm going to look into getting PMA_mimeDefaultFunction() function inside
> PMA_DisplayResults class. (currently it is under core.lib.php)
> I think it is possible to use this function inside that class, and call
> directly ($this->_mimeDefaultFunction()) instead of using additional string
> to store method name. (current way)
> 
> Then the default function for the mime transformation is inside a class.
> But the other existing transformations functions are still global functions.
> If that is not good (feels not good), those also should convert to classes.
> 
> And if other transformations converted to classes, in which way I can
> create objects of those classes.
> Should I need to use string to store the class name and then use it as
> belows.
> 
> $class_name = 'TestClass';
> $ob = new $class_name($params);
> 
> It is very helpful for me if you can share your suggestions.
> 
> Regards !

Hi Chanaka,
maybe others, especially Alex Marin, would have an idea to share with
you. I have not yet studied his new plugin system for transformations.


-- 
Marc Delisle
http://infomarc.info

Hi Chanaka,

On Thu, Jun 28, 2012 at 5:04 AM, Chanaka Dharmarathna
<pe.chanaka.ck@...> wrote:
> I'm going to look into getting PMA_mimeDefaultFunction() function inside
> PMA_DisplayResults class. (currently it is under core.lib.php)
> I think it is possible to use this function inside that class, and call
> directly ($this->_mimeDefaultFunction()) instead of using additional string
> to store method name. (current way)
>
> Then the default function for the mime transformation is inside a class.
> But the other existing transformations functions are still global functions.
> If that is not good (feels not good), those also should convert to classes.

I've seen that the PMA_mimeDefaultFunction is only currently used in
DisplayResults.class.php, so I think it's a good idea to move it there.

> And if other transformations converted to classes, in which way I can create
> objects of those classes.
> Should I need to use string to store the class name and then use it as
> belows.
>
> $class_name = 'TestClass';
> $ob = new $class_name($params);
>
> It is very helpful for me if you can share your suggestions.

As general info, to use a transformation plugin, you have to include it and
then instantiate it. For example, if you want to use Text_Plain_Sql:
  include_once 'libraries/plugins/transformations/Text_Plain_Sql.class.php';
  $plugin_manager = null; // Still working on this, so you can use null for now
  $sql_transf = new Text_Plain_Sql($plugin_manager);
Then, you can use the actual transformation by calling:
  $sql_transf->applyTransformation();

In DisplayResults.class.php, inside _getTableBody(), there is an init:
[2158] $default_function = 'PMA_mimeDefaultFunction'; // default_function
Then, this variable is passed as an argument to several functions along
the way:
  _getDataCellForNumericColumns,
  _getDataCellForBlobColumns,
  _getDataCellForGeometryColumns,
  _getDataCellForNonNumericAndNonBlobColumns,
  _getRowData,
  _addClass
  _handleNonPrintableContents

Some of the functions only pass it further, while others use actually use it.
I replaced the use of the PMA_transformation_[FILENAME]() with the
use of $transformation_plugin->applyTransformation() and kept the same
arguments.
So I had to pass an instance of the transformation class as an argument
($transformation_plugin), but my problem was that in some cases I had to use
the applyTransformations method, while in others, I had to use the default
function ( PMA_mimeDefaultFunction() ). Therefore, where needed, I set the
argument $transformation_plugin = $default_function, and, in the above
mentioned methods I checked and used accordingly, something similar to:
$result = ($transformation_plugin != $default_function
    ? $transformation_plugin->applyTransformation(
        $data,
        $transform_options,
        $meta
    )
    : $default_function($data)
)

Hope that helps. I will write some wikis for all of the plugins, but I thought
I should first finish the whole system (the plugin managers).

--
Alex

Hi Alex,

Sorry for posting top post, but I'm just reading up on some mails on my
phone while waiting for the intermission to end.

Just an idea, while reading your description of how to use the
transformation classes : why don't you provide a factory pattern to
instantiate/create the classes. Everything like checking if the include
file exists, including it and preparing/instantiating can be done in the
factory.

Also consider creating an interface for every type of class (auth,
export/import, transformation, ...) and implement it in every derived class
(f.e. ExportSql, ExportXml could implement a ExportInterface)

Kind regards,
Dieter Adriaenssens.
Op 28 jun. 2012 18:08 schreef "Alex Marin" <alex.ukf@...> het
volgende:

> Hi Chanaka,
>
> On Thu, Jun 28, 2012 at 5:04 AM, Chanaka Dharmarathna
> <pe.chanaka.ck@...> wrote:
> > I'm going to look into getting PMA_mimeDefaultFunction() function inside
> > PMA_DisplayResults class. (currently it is under core.lib.php)
> > I think it is possible to use this function inside that class, and call
> > directly ($this->_mimeDefaultFunction()) instead of using additional
> string
> > to store method name. (current way)
> >
> > Then the default function for the mime transformation is inside a class.
> > But the other existing transformations functions are still global
> functions.
> > If that is not good (feels not good), those also should convert to
> classes.
>
> I've seen that the PMA_mimeDefaultFunction is only currently used in
> DisplayResults.class.php, so I think it's a good idea to move it there.
>
> > And if other transformations converted to classes, in which way I can
> create
> > objects of those classes.
> > Should I need to use string to store the class name and then use it as
> > belows.
> >
> > $class_name = 'TestClass';
> > $ob = new $class_name($params);
> >
> > It is very helpful for me if you can share your suggestions.
>
> As general info, to use a transformation plugin, you have to include it and
> then instantiate it. For example, if you want to use Text_Plain_Sql:
>  include_once 'libraries/plugins/transformations/Text_Plain_Sql.class.php';
>  $plugin_manager = null; // Still working on this, so you can use null for
> now
>  $sql_transf = new Text_Plain_Sql($plugin_manager);
> Then, you can use the actual transformation by calling:
>  $sql_transf->applyTransformation();
>
> In DisplayResults.class.php, inside _getTableBody(), there is an init:
> [2158] $default_function = 'PMA_mimeDefaultFunction'; // default_function
> Then, this variable is passed as an argument to several functions along
> the way:
>  _getDataCellForNumericColumns,
>  _getDataCellForBlobColumns,
>  _getDataCellForGeometryColumns,
>  _getDataCellForNonNumericAndNonBlobColumns,
>  _getRowData,
>  _addClass
>  _handleNonPrintableContents
>
> Some of the functions only pass it further, while others use actually use
> it.
> I replaced the use of the PMA_transformation_[FILENAME]() with the
> use of $transformation_plugin->applyTransformation() and kept the same
> arguments.
> So I had to pass an instance of the transformation class as an argument
> ($transformation_plugin), but my problem was that in some cases I had to
> use
> the applyTransformations method, while in others, I had to use the default
> function ( PMA_mimeDefaultFunction() ). Therefore, where needed, I set the
> argument $transformation_plugin = $default_function, and, in the above
> mentioned methods I checked and used accordingly, something similar to:
> $result = ($transformation_plugin != $default_function
>    ? $transformation_plugin->applyTransformation(
>        $data,
>        $transform_options,
>        $meta
>    )
>    : $default_function($data)
> )
>
> Hope that helps. I will write some wikis for all of the plugins, but I
> thought
> I should first finish the whole system (the plugin managers).
>
> --
> Alex
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>

On Thu, Jun 28, 2012 at 11:38 PM, Dieter Adriaenssens
<dieter.adriaenssens@...> wrote:
> Just an idea, while reading your description of how to use the
> transformation classes : why don't you provide a factory pattern to
> instantiate/create the classes. Everything like checking if the include file
> exists, including it and preparing/instantiating can be done in the factory.

That sounds like a good idea.

> Also consider creating an interface for every type of class (auth,
> export/import, transformation, ...) and implement it in every derived class
> (f.e. ExportSql, ExportXml could implement a ExportInterface)

Currently, this is implemented with abstract classes (f.e. ExportSql and
ExportXml extend ExportPlugin and so on), and those provide a similar
functionality to the interface. I decided to use abstract classes, because
I wanted to be able to declare some common variables and getters and
setters for them.

--
Alex

> > I'm going to look into getting PMA_mimeDefaultFunction() function inside
> > PMA_DisplayResults class. (currently it is under core.lib.php)
> > I think it is possible to use this function inside that class, and call
> > directly ($this->_mimeDefaultFunction()) instead of using additional
> string
> > to store method name. (current way)
> >
> > Then the default function for the mime transformation is inside a class.
> > But the other existing transformations functions are still global
> functions.
> > If that is not good (feels not good), those also should convert to
> classes.
>
> I've seen that the PMA_mimeDefaultFunction is only currently used in
> DisplayResults.class.php, so I think it's a good idea to move it there.
>
> > And if other transformations converted to classes, in which way I can
> create
> > objects of those classes.
> > Should I need to use string to store the class name and then use it as
> > belows.
> >
> > $class_name = 'TestClass';
> > $ob = new $class_name($params);
> >
> > It is very helpful for me if you can share your suggestions.
>
> As general info, to use a transformation plugin, you have to include it and
> then instantiate it. For example, if you want to use Text_Plain_Sql:
>  include_once 'libraries/plugins/transformations/Text_Plain_Sql.class.php';
>  $plugin_manager = null; // Still working on this, so you can use null for
> now
>  $sql_transf = new Text_Plain_Sql($plugin_manager);
> Then, you can use the actual transformation by calling:
>  $sql_transf->applyTransformation();
>
> In DisplayResults.class.php, inside _getTableBody(), there is an init:
> [2158] $default_function = 'PMA_mimeDefaultFunction'; // default_function
> Then, this variable is passed as an argument to several functions along
> the way:
>  _getDataCellForNumericColumns,
>  _getDataCellForBlobColumns,
>  _getDataCellForGeometryColumns,
>  _getDataCellForNonNumericAndNonBlobColumns,
>  _getRowData,
>  _addClass
>  _handleNonPrintableContents
>
> Some of the functions only pass it further, while others use actually use
> it.
> I replaced the use of the PMA_transformation_[FILENAME]() with the
> use of $transformation_plugin->applyTransformation() and kept the same
> arguments.
> So I had to pass an instance of the transformation class as an argument
> ($transformation_plugin), but my problem was that in some cases I had to
> use
> the applyTransformations method, while in others, I had to use the default
> function ( PMA_mimeDefaultFunction() ). Therefore, where needed, I set the
> argument $transformation_plugin = $default_function, and, in the above
> mentioned methods I checked and used accordingly, something similar to:
> $result = ($transformation_plugin != $default_function
>    ? $transformation_plugin->applyTransformation(
>        $data,
>        $transform_options,
>        $meta
>    )
>    : $default_function($data)
> )
>
> Hope that helps. I will write some wikis for all of the plugins, but I
> thought
> I should first finish the whole system (the plugin managers).
>

Hi Alex,

Thanks for sharing your ideas on this.
These days I'm getting many conflicts due to modifying common.lib.php file.
Same thing happens again after merging master.

Is there any possibility that you need to use default mime function outside
the PMA_DisplayResults class ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

2012/6/29 Alex Marin <alex.ukf@...>:
> On Thu, Jun 28, 2012 at 11:38 PM, Dieter Adriaenssens
> <dieter.adriaenssens@...> wrote:
>> Just an idea, while reading your description of how to use the
>> transformation classes : why don't you provide a factory pattern to
>> instantiate/create the classes. Everything like checking if the include file
>> exists, including it and preparing/instantiating can be done in the factory.
>
> That sounds like a good idea.
>
>> Also consider creating an interface for every type of class (auth,
>> export/import, transformation, ...) and implement it in every derived class
>> (f.e. ExportSql, ExportXml could implement a ExportInterface)
>
> Currently, this is implemented with abstract classes (f.e. ExportSql and
> ExportXml extend ExportPlugin and so on), and those provide a similar
> functionality to the interface. I decided to use abstract classes, because
> I wanted to be able to declare some common variables and getters and
> setters for them.

Hi Alex,

Good thinking! :)
Deriving your actual classes from a common abstract class is the best
way to do this, adding an interface is optional because the necessary
public classes are probably already defined in your abstract class,
but it's a good practise to provide an interface. ;)

-- 
Kind regards,

Dieter Adriaenssens

Hi,

On Fri, Jun 29, 2012 at 4:05 AM, Chanaka Dharmarathna
<pe.chanaka.ck@...> wrote:
> Is there any possibility that you need to use default mime function outside
> the PMA_DisplayResults class ?

Right now, I can't see any use for it in some other place.

--
Alex

Hi Alex,

> Is there any possibility that you need to use default mime function
> outside
> > the PMA_DisplayResults class ?
>
> Right now, I can't see any use for it in some other place.
>
> Fine. :)

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi Michal,

I have merged the current master and commit it to my forked copy.
It contains the class behavior of the common.lib.php file in addition to
the changes in current master.

But there are several known issues.
1. While browse tables with JPEG or PNG mime types I get following warning,
Warning in ./libraries/DisplayResults.class.php#4582
strpos() expects parameter 1 to be string, object given

2. When the session expires, after click logout I get following notice,
Notice in ./libraries/relation.lib.php#35
Undefined index: controllink

3. When incorrect login, following warning raised,
*Warning* in ./libraries/dbi/mysqli.dbi.lib.php#97
mysqli_real_connect(): (28000/1045): Access denied for user 'root'@'localhost'
(using password: YES)

4. When insert data for any table, after click Go button, it shows the SQL
window. (should redirect to Browse window)

Can you please verify that current master have any of this issues or not.
And if those are not because of my commits, I think its ready to merge my
code to master.
Otherwise I could resolve more and more conflicts as same as these days :)

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Sat, Jun 30, 2012 at 12:39 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

> Hi Michal,
>
> I have merged the current master and commit it to my forked copy.
> It contains the class behavior of the common.lib.php file in addition to
> the changes in current master.
>
> But there are several known issues.
> 1. While browse tables with JPEG or PNG mime types I get following warning,
> Warning in ./libraries/DisplayResults.class.php#4582
> strpos() expects parameter 1 to be string, object given
>
> 2. When the session expires, after click logout I get following notice,
> Notice in ./libraries/relation.lib.php#35
> Undefined index: controllink
>
> 3. When incorrect login, following warning raised,
> *Warning* in ./libraries/dbi/mysqli.dbi.lib.php#97
> mysqli_real_connect(): (28000/1045): Access denied for user 'root'@'localhost'
> (using password: YES)
>
> 4. When insert data for any table, after click Go button, it shows the SQL
> window. (should redirect to Browse window)
>
> Can you please verify that current master have any of this issues or not.
> And if those are not because of my commits, I think its ready to merge my
> code to master.
> Otherwise I could resolve more and more conflicts as same as these days :)
>
>
Hi Michal,

Only the issue 1 has corrected in the master.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi

Dne Sat, 30 Jun 2012 12:39:33 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> I have merged the current master and commit it to my forked copy.

It looks like you did something wrong as you've reintroduced files
which were deleted in master.

> It contains the class behavior of the common.lib.php file in addition to
> the changes in current master.
> 
> But there are several known issues.
> 1. While browse tables with JPEG or PNG mime types I get following warning,
> Warning in ./libraries/DisplayResults.class.php#4582
> strpos() expects parameter 1 to be string, object given

AFAIK already fixed in master.

> 2. When the session expires, after click logout I get following notice,
> Notice in ./libraries/relation.lib.php#35
> Undefined index: controllink

Probably a bug, not necessarily in your changes.

> 3. When incorrect login, following warning raised,
> *Warning* in ./libraries/dbi/mysqli.dbi.lib.php#97
> mysqli_real_connect(): (28000/1045): Access denied for user 'root'@'localhost'
> (using password: YES)

This is correct.

> 4. When insert data for any table, after click Go button, it shows the SQL
> window. (should redirect to Browse window)

Probably not related to your changes.

-- 
	Michal Čihař | http://cihar.com | http://phpmyadmin.cz

Hi Michal,

It looks like you did something wrong as you've reintroduced files
> which were deleted in master.
>

You are correct, Its my mistake while I'm messed up with resolving
conflicts.
Sorry for that and thanks for pointing that
I just corrected them.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Le 2012-06-30 10:59, Michal Čihař a écrit :
> Hi
> 
> Dne Sat, 30 Jun 2012 12:39:33 +0530
> Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

>> 4. When insert data for any table, after click Go button, it shows the SQL
>> window. (should redirect to Browse window)
> 
> Probably not related to your changes.

This is fixed now.

-- 
Marc Delisle
http://infomarc.info

Hi Michal,

I'm going to improve test cases for PMA_DisplayResults class.
I saw some test cases has already implemented by Yasitha.
I'll implement tests for remaining functions.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi Michal,

I almost reduce the use of super global variables inside functions of
PMA_DisplayResults class.
Most of the fields are set while executing the getTable() function since
they cannot set while executing the constructor.

Now I'm move into writing tests.
I am facing to a problem with writing tests.
How can I access or set the private variables, by a test ?
The already existed tests also failing due to this change.
Your suggestions will very helpful.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

2012/7/7 Chanaka Dharmarathna <pe.chanaka.ck@...>:
> Hi Michal,
>
> I almost reduce the use of super global variables inside functions of
> PMA_DisplayResults class.
> Most of the fields are set while executing the getTable() function since
> they cannot set while executing the constructor.
>
> Now I'm move into writing tests.
> I am facing to a problem with writing tests.
> How can I access or set the private variables, by a test ?
> The already existed tests also failing due to this change.
> Your suggestions will very helpful.

Hi Chanaka,

I didn't have a look at the current tests and at PMA_DisplayResults
class, so I won't be able to go into specifics about your tests, but I
will try to answer your questions, and point you in a direction.

Accessing or setting private variables in a class/method is not
possible during a unit test.
The idea of unit tests is to test the functionality of a class method
or global function by testing the output of it, or catching errors.
You expect a certain behaviour of the method/function depending on the
value of the input parameters (or environmental states, like global
variables, database content, or config settings).
So basically you think of all different situations that can affect the
behaviour of the method/function, define what kind of result this
would give and write a test that sets up the situation and test
(assert) the output of the function/method.

When writing unit tests, you should keep in mind that you are only
testing the behaviour of that function/method. Any functions/methods
used by a function/method should be tested seperately. By which I mean
that you must assume when testing a function/method that the
functions/methods that are used in that method, work correctly.
To make things easier for you, you can define stubs/mocks [0] that
replace the methods/functions used in a function/method you are
testing. This way you don't have to set up a complete environment, but
can concentrate on what the function/method does.

As an example

If you have a class that gets values from a database :

class DbValues
{
   private $_values;

   __construct()
   {
       $this->_values = array();
   }

   public function getValuesFromDb()
   {
       // functionality making a connection to a database, executing a
query and setting the resulting values to $_values.
   }

   public function getValues()
   {
       return $this->_values;
   }

  public function count()
  {
     return count($this->getValues());
  }
}


And you want to test the behaviour of the count() method. The only way
to populate the _values variable in this example would be by setting
up a database with different sets of values, for each case you want to
test and call the getValuesFromDb() method, OR, you can  define a stub
that replaces the getValues() method and let it return an array with
the necessary amount of values (depending on what you want to test).
This way you avoid having to set up a complicated testing environment,
when testing a single class method. (Note : when testing the
getValuesFromDb() method you will probably have to set up a database,
but that's because that method is all about connecting to a database
and getting data from it, but all other methods in this class can
assume that the getValuesFromDb works, so there is no need to
replicate the complicated test environment every time)

I suggest you read up a bit on testing class methods and the use of
stubs/mocks. I hope my example didn't confuse you too much.

[0] http://www.phpunit.de/manual/current/en/test-doubles.html#test-doubles.stubs

Kind regards,

Dieter

>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>



-- 
Kind regards,

Dieter Adriaenssens

Hi Dieter,

> I almost reduce the use of super global variables inside functions of
> > PMA_DisplayResults class.
> > Most of the fields are set while executing the getTable() function since
> > they cannot set while executing the constructor.
> >
> > Now I'm move into writing tests.
> > I am facing to a problem with writing tests.
> > How can I access or set the private variables, by a test ?
> > The already existed tests also failing due to this change.
> > Your suggestions will very helpful.
>
>
>
> I didn't have a look at the current tests and at PMA_DisplayResults
> class, so I won't be able to go into specifics about your tests, but I
> will try to answer your questions, and point you in a direction.
>
> Accessing or setting private variables in a class/method is not
> possible during a unit test.
> The idea of unit tests is to test the functionality of a class method
> or global function by testing the output of it, or catching errors.
> You expect a certain behaviour of the method/function depending on the
> value of the input parameters (or environmental states, like global
> variables, database content, or config settings).
> So basically you think of all different situations that can affect the
> behaviour of the method/function, define what kind of result this
> would give and write a test that sets up the situation and test
> (assert) the output of the function/method.
>
> When writing unit tests, you should keep in mind that you are only
> testing the behaviour of that function/method. Any functions/methods
> used by a function/method should be tested seperately. By which I mean
> that you must assume when testing a function/method that the
> functions/methods that are used in that method, work correctly.
> To make things easier for you, you can define stubs/mocks [0] that
> replace the methods/functions used in a function/method you are
> testing. This way you don't have to set up a complete environment, but
> can concentrate on what the function/method does.
>
> As an example
>
> If you have a class that gets values from a database :
>
> class DbValues
> {
>    private $_values;
>
>    __construct()
>    {
>        $this->_values = array();
>    }
>
>    public function getValuesFromDb()
>    {
>        // functionality making a connection to a database, executing a
> query and setting the resulting values to $_values.
>    }
>
>    public function getValues()
>    {
>        return $this->_values;
>    }
>
>   public function count()
>   {
>      return count($this->getValues());
>   }
> }
>
>
> And you want to test the behaviour of the count() method. The only way
> to populate the _values variable in this example would be by setting
> up a database with different sets of values, for each case you want to
> test and call the getValuesFromDb() method, OR, you can  define a stub
> that replaces the getValues() method and let it return an array with
> the necessary amount of values (depending on what you want to test).
> This way you avoid having to set up a complicated testing environment,
> when testing a single class method. (Note : when testing the
> getValuesFromDb() method you will probably have to set up a database,
> but that's because that method is all about connecting to a database
> and getting data from it, but all other methods in this class can
> assume that the getValuesFromDb works, so there is no need to
> replicate the complicated test environment every time)
>
> I suggest you read up a bit on testing class methods and the use of
> stubs/mocks. I hope my example didn't confuse you too much.
>
> [0]
> http://www.phpunit.de/manual/current/en/test-doubles.html#test-doubles.stubs
>
>
Thank you very much for spending your time for clarify this with valuable
and enough information.
I completely agree with you, on writing unit tests independent/separate
from another layer/function.
Mock objects/stubs are helpful in that case.

At the moment there are around 25 private fields in PMA_DisplayResults
class.
What I am thinking of implement getter setter methods for all those and use
getters and setters where needed.
In that way I will be able to set those private fields even from the tests.
What do you think on this ?

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

On Sat, Jul 7, 2012 at 8:00 PM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

> Hi Dieter,
>
> > I almost reduce the use of super global variables inside functions of
>> > PMA_DisplayResults class.
>> > Most of the fields are set while executing the getTable() function since
>> > they cannot set while executing the constructor.
>> >
>> > Now I'm move into writing tests.
>> > I am facing to a problem with writing tests.
>> > How can I access or set the private variables, by a test ?
>> > The already existed tests also failing due to this change.
>> > Your suggestions will very helpful.
>>
>>
>>
>> I didn't have a look at the current tests and at PMA_DisplayResults
>> class, so I won't be able to go into specifics about your tests, but I
>> will try to answer your questions, and point you in a direction.
>>
>> Accessing or setting private variables in a class/method is not
>> possible during a unit test.
>> The idea of unit tests is to test the functionality of a class method
>> or global function by testing the output of it, or catching errors.
>> You expect a certain behaviour of the method/function depending on the
>> value of the input parameters (or environmental states, like global
>> variables, database content, or config settings).
>> So basically you think of all different situations that can affect the
>> behaviour of the method/function, define what kind of result this
>> would give and write a test that sets up the situation and test
>> (assert) the output of the function/method.
>>
>> When writing unit tests, you should keep in mind that you are only
>> testing the behaviour of that function/method. Any functions/methods
>> used by a function/method should be tested seperately. By which I mean
>> that you must assume when testing a function/method that the
>> functions/methods that are used in that method, work correctly.
>> To make things easier for you, you can define stubs/mocks [0] that
>> replace the methods/functions used in a function/method you are
>> testing. This way you don't have to set up a complete environment, but
>> can concentrate on what the function/method does.
>>
>> As an example
>>
>> If you have a class that gets values from a database :
>>
>> class DbValues
>> {
>>    private $_values;
>>
>>    __construct()
>>    {
>>        $this->_values = array();
>>    }
>>
>>    public function getValuesFromDb()
>>    {
>>        // functionality making a connection to a database, executing a
>> query and setting the resulting values to $_values.
>>    }
>>
>>    public function getValues()
>>    {
>>        return $this->_values;
>>    }
>>
>>   public function count()
>>   {
>>      return count($this->getValues());
>>   }
>> }
>>
>>
>> And you want to test the behaviour of the count() method. The only way
>> to populate the _values variable in this example would be by setting
>> up a database with different sets of values, for each case you want to
>> test and call the getValuesFromDb() method, OR, you can  define a stub
>> that replaces the getValues() method and let it return an array with
>> the necessary amount of values (depending on what you want to test).
>> This way you avoid having to set up a complicated testing environment,
>> when testing a single class method. (Note : when testing the
>> getValuesFromDb() method you will probably have to set up a database,
>> but that's because that method is all about connecting to a database
>> and getting data from it, but all other methods in this class can
>> assume that the getValuesFromDb works, so there is no need to
>> replicate the complicated test environment every time)
>>
>> I suggest you read up a bit on testing class methods and the use of
>> stubs/mocks. I hope my example didn't confuse you too much.
>>
>> [0]
>> http://www.phpunit.de/manual/current/en/test-doubles.html#test-doubles.stubs
>>
>>
> Thank you very much for spending your time for clarify this with valuable
> and enough information.
> I completely agree with you, on writing unit tests independent/separate
> from another layer/function.
> Mock objects/stubs are helpful in that case.
>
> At the moment there are around 25 private fields in PMA_DisplayResults
> class.
> What I am thinking of implement getter setter methods for all those and
> use getters and setters where needed.
> In that way I will be able to set those private fields even from the tests.
> What do you think on this ?
>
>
> Regards !
> --
> ____________________________________
>
> Chanaka Indrajith
> Bsc.Computer Engineering Undergraduate
> Faculty of Engineering
> University of Peradeniya
> Sri Lanka
> ____________________________________
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel@...
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
Hi Chanaka,

When writing test cases we might have to test protected/private functions
as well. The method used in PMA is by using php Refection class. They used
setAccessible method to make them public for test class. There is a method
in reflection class called getProperties which can used for access
protected and private attributes. Refer this [1] for more details. But I am
not sure is it a good approach when testing.

[1] - http://php.net/manual/en/reflectionproperty.setaccessible.php

Regards,
-- 
Yasitha Pandithawatta
Undergraduate
Computer Science and Engineering Department
University of Moratuwa
Sri Lanka

> Hi Dieter,
>>
>> > I almost reduce the use of super global variables inside functions of
>>> > PMA_DisplayResults class.
>>> > Most of the fields are set while executing the getTable() function
>>> since
>>> > they cannot set while executing the constructor.
>>> >
>>> > Now I'm move into writing tests.
>>> > I am facing to a problem with writing tests.
>>> > How can I access or set the private variables, by a test ?
>>> > The already existed tests also failing due to this change.
>>> > Your suggestions will very helpful.
>>>
>>>
>>>
>>> I didn't have a look at the current tests and at PMA_DisplayResults
>>> class, so I won't be able to go into specifics about your tests, but I
>>> will try to answer your questions, and point you in a direction.
>>>
>>> Accessing or setting private variables in a class/method is not
>>> possible during a unit test.
>>> The idea of unit tests is to test the functionality of a class method
>>> or global function by testing the output of it, or catching errors.
>>> You expect a certain behaviour of the method/function depending on the
>>> value of the input parameters (or environmental states, like global
>>> variables, database content, or config settings).
>>> So basically you think of all different situations that can affect the
>>> behaviour of the method/function, define what kind of result this
>>> would give and write a test that sets up the situation and test
>>> (assert) the output of the function/method.
>>>
>>> When writing unit tests, you should keep in mind that you are only
>>> testing the behaviour of that function/method. Any functions/methods
>>> used by a function/method should be tested seperately. By which I mean
>>> that you must assume when testing a function/method that the
>>> functions/methods that are used in that method, work correctly.
>>> To make things easier for you, you can define stubs/mocks [0] that
>>> replace the methods/functions used in a function/method you are
>>> testing. This way you don't have to set up a complete environment, but
>>> can concentrate on what the function/method does.
>>>
>>> As an example
>>>
>>> If you have a class that gets values from a database :
>>>
>>> class DbValues
>>> {
>>>    private $_values;
>>>
>>>    __construct()
>>>    {
>>>        $this->_values = array();
>>>    }
>>>
>>>    public function getValuesFromDb()
>>>    {
>>>        // functionality making a connection to a database, executing a
>>> query and setting the resulting values to $_values.
>>>    }
>>>
>>>    public function getValues()
>>>    {
>>>        return $this->_values;
>>>    }
>>>
>>>   public function count()
>>>   {
>>>      return count($this->getValues());
>>>   }
>>> }
>>>
>>>
>>> And you want to test the behaviour of the count() method. The only way
>>> to populate the _values variable in this example would be by setting
>>> up a database with different sets of values, for each case you want to
>>> test and call the getValuesFromDb() method, OR, you can  define a stub
>>> that replaces the getValues() method and let it return an array with
>>> the necessary amount of values (depending on what you want to test).
>>> This way you avoid having to set up a complicated testing environment,
>>> when testing a single class method. (Note : when testing the
>>> getValuesFromDb() method you will probably have to set up a database,
>>> but that's because that method is all about connecting to a database
>>> and getting data from it, but all other methods in this class can
>>> assume that the getValuesFromDb works, so there is no need to
>>> replicate the complicated test environment every time)
>>>
>>> I suggest you read up a bit on testing class methods and the use of
>>> stubs/mocks. I hope my example didn't confuse you too much.
>>>
>>> [0]
>>> http://www.phpunit.de/manual/current/en/test-doubles.html#test-doubles.stubs
>>>
>>>
>> Thank you very much for spending your time for clarify this with valuable
>> and enough information.
>> I completely agree with you, on writing unit tests independent/separate
>> from another layer/function.
>> Mock objects/stubs are helpful in that case.
>>
>> At the moment there are around 25 private fields in PMA_DisplayResults
>> class.
>> What I am thinking of implement getter setter methods for all those and
>> use getters and setters where needed.
>> In that way I will be able to set those private fields even from the
>> tests.
>> What do you think on this ?
>>
>>
>> Regards !
>>
>>
> Hi Chanaka,
>
> When writing test cases we might have to test protected/private functions
> as well. The method used in PMA is by using php Refection class. They used
> setAccessible method to make them public for test class. There is a method
> in reflection class called getProperties which can used for access
> protected and private attributes. Refer this [1] for more details. But I am
> not sure is it a good approach when testing.
>
> [1] - http://php.net/manual/en/reflectionproperty.setaccessible.php
>
>
Hi Yasitha,

Thanks for your information.
I have already referred some tests done by you, accessing to private
functions.
I'll use the same way for testing private methods.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi,

I introduced new function to initialize set of properties of
PMA_DisplayResults class which are not set inside the constructor.
That functions is appeared as processParams().
But I'm not sure its a good name for that method.
Will a name like setProperties() or setAdditionalProperties() more suitable
for this function ?
Welcome to any suggestions.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

2012/7/10 Chanaka Dharmarathna <pe.chanaka.ck@...>:
> Hi,
>
> I introduced new function to initialize set of properties of
> PMA_DisplayResults class which are not set inside the constructor.
> That functions is appeared as processParams().
> But I'm not sure its a good name for that method.
> Will a name like setProperties() or setAdditionalProperties() more suitable
> for this function ?
> Welcome to any suggestions.

Hi Chanaka,

Assuming that you are talking about the properties that are not set
with a constructor parameter (the properties should be defined in the
constructor anyway, but not necessarely with a value supplied by a
constructor parameter), I think setProperties() is the best choice.

Would this method only set the properties that cannot be set with a
constructor parameter, or just any property?
Maybe you can consider calling it setProperty($name, $value). This
enables you to set just any parameter.
How are your properties defined? As single variables? Or as an array
of properties?

Kind regards,

Dieter

Hi Dieter,

Thanks for your suggestions.

> I introduced new function to initialize set of properties of
> > PMA_DisplayResults class which are not set inside the constructor.
> > That functions is appeared as processParams().
> > But I'm not sure its a good name for that method.
> > Will a name like setProperties() or setAdditionalProperties() more
> suitable
> > for this function ?
> > Welcome to any suggestions.
>
> Hi Chanaka,
>
> Assuming that you are talking about the properties that are not set
> with a constructor parameter (the properties should be defined in the
> constructor anyway, but not necessarely with a value supplied by a
> constructor parameter), I think setProperties() is the best choice.
>

Yes, that's good.


> Would this method only set the properties that cannot be set with a
> constructor parameter, or just any property?
>

This method only set the properties which cannot be set in constructor.


> Maybe you can consider calling it setProperty($name, $value). This
> enables you to set just any parameter.
>

The class already have a method called __set($name, $value) to set any of
the property in class.
But since there are around 17 properties to initialized, I think better to
use this setProperties() method.


> How are your properties defined? As single variables? Or as an array
> of properties?
>

Sorry if I'm not calling to your question. (I'm not clear about what you
try to ask.)
>From the sql.php file I pass parameters to this function separately.
ex - setProperties($property1, property2, etc.)
Those properties are with different data types.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

2012/7/11 Chanaka Dharmarathna <pe.chanaka.ck@...>:
> Hi Dieter,
>
> Thanks for your suggestions.
>
>> > I introduced new function to initialize set of properties of
>> > PMA_DisplayResults class which are not set inside the constructor.
>> > That functions is appeared as processParams().
>> > But I'm not sure its a good name for that method.
>> > Will a name like setProperties() or setAdditionalProperties() more
>> > suitable
>> > for this function ?
>> > Welcome to any suggestions.
>>
>> Hi Chanaka,
>>
>> Assuming that you are talking about the properties that are not set
>> with a constructor parameter (the properties should be defined in the
>> constructor anyway, but not necessarely with a value supplied by a
>> constructor parameter), I think setProperties() is the best choice.
>
>
> Yes, that's good.
>
>>
>> Would this method only set the properties that cannot be set with a
>> constructor parameter, or just any property?
>
>
> This method only set the properties which cannot be set in constructor.
>
>>
>> Maybe you can consider calling it setProperty($name, $value). This
>> enables you to set just any parameter.
>
>
> The class already have a method called __set($name, $value) to set any of
> the property in class.
> But since there are around 17 properties to initialized, I think better to
> use this setProperties() method.
>
>>
>> How are your properties defined? As single variables? Or as an array
>> of properties?
>
>
> Sorry if I'm not calling to your question. (I'm not clear about what you try
> to ask.)

This is what I meant : Do you have a single array (or an container
class) with properties, like :

private $_properties = array();

or do you define all your properties seperately (ommiting the
docblocks in this example) :

private $_property1;
private $_property2;
private $_property3;
...
private $_propertyN;

Kind regards,

Dieter

>
> >
> > Thanks for your suggestions.
> >
> >> > I introduced new function to initialize set of properties of
> >> > PMA_DisplayResults class which are not set inside the constructor.
> >> > That functions is appeared as processParams().
> >> > But I'm not sure its a good name for that method.
> >> > Will a name like setProperties() or setAdditionalProperties() more
> >> > suitable
> >> > for this function ?
> >> > Welcome to any suggestions.
> >>
> >> Hi Chanaka,
> >>
> >> Assuming that you are talking about the properties that are not set
> >> with a constructor parameter (the properties should be defined in the
> >> constructor anyway, but not necessarely with a value supplied by a
> >> constructor parameter), I think setProperties() is the best choice.
> >
> >
> > Yes, that's good.
> >
> >>
> >> Would this method only set the properties that cannot be set with a
> >> constructor parameter, or just any property?
> >
> >
> > This method only set the properties which cannot be set in constructor.
> >
> >>
> >> Maybe you can consider calling it setProperty($name, $value). This
> >> enables you to set just any parameter.
> >
> >
> > The class already have a method called __set($name, $value) to set any of
> > the property in class.
> > But since there are around 17 properties to initialized, I think better
> to
> > use this setProperties() method.
> >
> >>
> >> How are your properties defined? As single variables? Or as an array
> >> of properties?
> >
> >
> > Sorry if I'm not calling to your question. (I'm not clear about what you
> try
> > to ask.)
>
> This is what I meant : Do you have a single array (or an container
> class) with properties, like :
>
> private $_properties = array();
>
> or do you define all your properties seperately (ommiting the
> docblocks in this example) :
>
> private $_property1;
> private $_property2;
> private $_property3;
> ...
> private $_propertyN;
>
>
Hi Dieter,

Now I got that.
I have defined them separately as your second example.

Regards !
-- 
____________________________________

Chanaka Indrajith
Bsc.Computer Engineering Undergraduate
Faculty of Engineering
University of Peradeniya
Sri Lanka
____________________________________

Hi Michal,

These days I'm having problems with improving the test cases.
It's not a good idea to run all the tests after improve test for each
function since it takes much time.
As well I can't run tests individually without errors again and again.
(File not found, undefined constant,  undefined variable)
I cannot find that my tests are correct or not.

Please suggest me some way to get rid of this problem.
Its very helpful if you can give one example for fixing a failing test in
PMA_DisplayResults_test.php

Regards !

*Chanaka*

Hi

Dne Thu, 12 Jul 2012 19:50:21 +0530
Chanaka Dharmarathna <pe.chanaka.ck@...> napsal(a):

> These days I'm having problems with improving the test cases.
> It's not a good idea to run all the tests after improve test for each
> function since it takes much time.
> As well I can't run tests individually without errors again and again.
> (File not found, undefined constant,  undefined variable)
> I cannot find that my tests are correct or not.

First of all the tests should run standalone as well as part of
testsuite. I see lot of tests fail in both modes, so maybe that's the
reason why it fails for you?

> Please suggest me some way to get rid of this problem.
> Its very helpful if you can give one example for fixing a failing test in
> PMA_DisplayResults_test.php

Fix the tests and code to work together :-).

-- 
	Michal Čihař | http://cihar.com | http://phpmyadmin.cz

>
> > These days I'm having problems with improving the test cases.
> > It's not a good idea to run all the tests after improve test for each
> > function since it takes much time.
> > As well I can't run tests individually without errors again and again.
> > (File not found, undefined constant,  undefined variable)
> > I cannot find that my tests are correct or not.
>
> First of all the tests should run standalone as well as part of
> testsuite. I see lot of tests fail in both modes, so maybe that's the
> reason why it fails for you?
>
> > Please suggest me some way to get rid of this problem.
> > Its very helpful if you can give one example for fixing a failing test in
> > PMA_DisplayResults_test.php
>
> Fix the tests and code to work together :-).
>

Okay I'll try again Michal

>> > These days I'm having problems with improving the test cases.
>> > It's not a good idea to run all the tests after improve test for each
>> > function since it takes much time.
>> > As well I can't run tests individually without errors again and again.
>> > (File not found, undefined constant,  undefined variable)
>> > I cannot find that my tests are correct or not.
>>
>> First of all the tests should run standalone as well as part of
>> testsuite. I see lot of tests fail in both modes, so maybe that's the
>> reason why it fails for you?
>>
>> > Please suggest me some way to get rid of this problem.
>> > Its very helpful if you can give one example for fixing a failing test
>> in
>> > PMA_DisplayResults_test.php
>>
>> Fix the tests and code to work together :-).
>>
>
> Okay I'll try again Michal
>

Hi Michal,

I managed to run only needed tests by modifying phpunit.xml.dist file. And
now Its no need to wait till all tests are running.

The problem for the errors in PMA_DisplayResults_test.php tests is not
properly set the properties of PMA_DisplayResults class.
So that, I get following two types of errors :
1. Trying to get property of non-object  -   $fields_meta[0]->table
2. Invalid argument supplied for foreach()  -  foreach
($vertical_display[$operation] as $val)

I try to set those parameters by calling setProperties() method.
As I found, the conditions inside __set and __get method are not
satisfying.

That is,
if (property_exists($this, $property))

But if I print the object at testing time, it shows me the properties are
actually there itself.
I am confusing about this.
Do you have any idea or suggestion for this ?

Regards !

*Chanaka*

On Fri, Jul 13, 2012 at 6:38 AM, Chanaka Dharmarathna <
pe.chanaka.ck@...> wrote:

>
>
>
>>> > These days I'm having problems with improving the test cases.
>>> > It's not a good idea to run all the tests after improve test for each
>>> > function since it takes much time.
>>> > As well I can't run tests individually without errors again and again.
>>> > (File not found, undefined constant,  undefined variable)
>>> > I cannot find that my tests are correct or not.
>>>
>>> First of all the tests should run standalone as well as part of
>>> testsuite. I see lot of tests fail in both modes, so maybe that's the
>>> reason why it fails for you?
>>>
>>> > Please suggest me some way to get rid of this problem.
>>> > Its very helpful if you can give one example for fixing a failing test
>>> in
>>> > PMA_DisplayResults_test.php
>>>
>>> Fix the tests and code to work together :-).
>>>
>>
>> Okay I'll try again Michal
>>
>
> Hi Michal,
>
> I managed to run only needed tests by modifying phpunit.xml.dist file. And
> now Its no need to wait till all tests are running.
>
> The problem for the errors in PMA_DisplayResults_test.php tests is not
> properly set the properties of PMA_DisplayResults class.
> So that, I get following two types of errors :
> 1. Trying to get property of non-object  -   $fields_meta[0]->table
> 2. Invalid argument supplied for foreach()  -  foreach
> ($vertical_display[$operation] as $val)
>
> I try to set those parameters by calling setProperties() method.
> As I found, the conditions inside __set and __get method are not
> satisfying.
>
> That is,
> if (property_exists($this, $property))
>
> But if I print the object at testing time, it shows me the properties are
> actually there itself.
> I am confusing about this.
> Do you have any idea or suggestion for this ?
>
> Regards !
>
> *Chanaka*
>

Hi Michal,

I just found that, property_exists method cannot detect properties in magic
method __get, from the manual [0].
I'll try with changing the method names.

[0] : http://php.net/manual/en/function.property-exists.php

Regards !

*Chanaka*

>
>>>> > These days I'm having problems with improving the test cases.
>>>> > It's not a good idea to run all the tests after improve test for each
>>>> > function since it takes much time.
>>>> > As well I can't run tests individually without errors again and again.
>>>> > (File not found, undefined constant,  undefined variable)
>>>> > I cannot find that my tests are correct or not.Chanaka
>>>>
>>>> First of all the tests should run standalone as well as part of
>>>> testsuite. I see lot of tests fail in both modes, so maybe that's the
>>>> reason why it fails for you?
>>>>
>>>> > Please suggest me some way to get rid of this problem.
>>>> > Its very helpful if you can give one example for fixing a failing
>>>> test in
>>>> > PMA_DisplayResults_test.php
>>>>
>>>> Fix the tests and code to work together :-).
>>>>
>>>
>>> Okay I'll try again Michal
>>>
>>
>> Hi Michal,
>>
>> I managed to run only needed tests by modifying phpunit.xml.dist file.
>> And now Its no need to wait till all tests are running.
>>
>> The problem for the errors in PMA_DisplayResults_test.php tests is not
>> properly set the properties of PMA_DisplayResults class.
>> So that, I get following two types of errors :
>> 1. Trying to get property of non-object  -   $fields_meta[0]->table
>> 2. Invalid argument supplied for foreach()  -  foreach
>> ($vertical_display[$operation] as $val)
>>
>> I try to set those parameters by calling setProperties() method.
>> As I found, the conditions inside __set and __get method are not
>> satisfying.
>>
>> That is,
>> if (property_exists($this, $property))
>>
>> But if I print the object at testing time, it shows me the properties are
>> actually there itself.
>> I am confusing about this.
>> Do you have any idea or suggestion for this ?
>>
>> Hi Michal,
>
> I just found that, property_exists method cannot detect properties in
> magic method __get, from the manual [0].
> I'll try with changing the method names.
>
> [0] : http://php.net/manual/en/function.property-exists.php
>

Hi Michal,

I try some modifications in those magic methods in order to fix those tests.
I use an array to store the all properties instead of using separate set of
properties. (I feel Dieter also try to say something like that in a
previous mail)
Now there is no doubt of using magic methods at any place.

I need your suggestion before doing this change.
Following snippet shows what I'm going to do.

// initialize at the top so that any property should include here
private $_properties_array = array('_db'=>null, '_table'=>null, .........);

public function __set($property, $value)
{
    if(array_key_exists($property, $this->_properties_array)) { // check
array key is defined - this is same as check property exist
        $this->_properties_array[$property] = $value;
    }
}

public function __get($property)
{
    if(array_key_exists($property, $this->_properties_array)) {
        return $this->_properties_array[$property];
    }
}

Waiting for your suggestions.

Regards !

*Chanaka*