LMMS

perhaps this has context to the bug i found?
https://sourceforge.net/tracker/?func=detail&aid=3493928&group_id=105168&atid=640434

Br.

-----
Hope this helped
BR.
---------------------
Tutorials and some music on : http://www.youtube.com/user/bearsoundz

-- 
View this message in context: http://old.nabble.com/Marking-scales%2C-bug--3493928-tp33419652p33419957.html
Sent from the lmms-devel mailing list archive at Nabble.com.

Quoting musikBear <mkrus18@...>:

>
> perhaps this has context to the bug i found?
> https://sourceforge.net/tracker/?func=detail&aid=3493928&group_id=105168&atid=640434
>
> Br.

Absolutely. (see subject :) My previous email was a bit of a "note to  
self" (and the world), as I for some reason couldn't log in and  
mention this in the bug tracker ATM. Happens sometimes.

-- 
raine@...
http://www.mikseri.net/radioproject

Hi,

2012/3/1 Raine M. Ekman <raine@...>:
> The formula in the scale marking code (src/gui/piano_roll.cpp) is screwed:
>
>     if( chord->hasSemiTone( std::abs( key - i ) % cap ) )
>
> should really be something like this:
>
>    if( chord->hasSemiTone( ( i - ( key % cap ) ) % cap ) )

Without having taken a look at it in detail - if it solves the
problem, we should change it accordingly! Can someone verify that this
change helps?

Toby

Hi,

It helps, I've made a little change to avoid the case where i < key % cap

if( chord->hasSemiTone( ( i + cap - ( key % cap ) ) % cap ) )

Works also well with chords marking

On Thu, Mar 1, 2012 at 11:08 PM, Tobias Doerffel
<tobias.doerffel@...> wrote:
> Hi,
>
> 2012/3/1 Raine M. Ekman <raine@...>:
>> The formula in the scale marking code (src/gui/piano_roll.cpp) is screwed:
>>
>>     if( chord->hasSemiTone( std::abs( key - i ) % cap ) )
>>
>> should really be something like this:
>>
>>    if( chord->hasSemiTone( ( i - ( key % cap ) ) % cap ) )
>
> Without having taken a look at it in detail - if it solves the
> problem, we should change it accordingly! Can someone verify that this
> change helps?
>
> Toby
>
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> LMMS-devel mailing list
> LMMS-devel@...
> https://lists.sourceforge.net/lists/listinfo/lmms-devel

i have no idea if this
http://www.youtube.com/watch?v=LkZTgE0usN0&context=C36c674cADOEgsToPDskLyUqkko8e77Kf5iifwGtmu
can aid in understanding the bug - but anyways -here it is -shows how to
circumvent the bug
-in short
if C0 is used as mark-register, the bug is circumvented.

Btw - i reported this bug on the tracker last week (with something else too)

Br.


-----
Hope this helped
BR.
---------------------
Tutorials and some music on : http://www.youtube.com/user/bearsoundz

-- 
View this message in context: http://old.nabble.com/Marking-scales%2C-bug--3493928-tp33419652p33428364.html
Sent from the lmms-devel mailing list archive at Nabble.com.

Hi,

2012/3/2 S . <noisebynorthwest@...>:
> It helps, I've made a little change to avoid the case where i < key % cap
>
> if( chord->hasSemiTone( ( i + cap - ( key % cap ) ) % cap ) )

So you propose to change the line accordingly? Would you mind preparing a patch?

Best regards

Toby

Toby, I think you applied the patch for this in May already... :)
(commit 02db2fbd2f10c61f576f26935819fe0f707dbc84)

Quoting Tobias Doerffel <tobias.doerffel@...>:

> Hi,
>
> 2012/3/2 S . <noisebynorthwest@...>:
>> It helps, I've made a little change to avoid the case where i < key % cap
>>
>> if( chord->hasSemiTone( ( i + cap - ( key % cap ) ) % cap ) )
>
> So you propose to change the line accordingly? Would you mind   
> preparing a patch?
>
> Best regards
>
> Toby
>
>



-- 
raine@...
04 00 83 83 95