Postfix Admin

Hello,

as you might have seen, I have done some changes on fetchmail.php and=20
fetchmail.tpl tonight.

Status:
=2D all SQL queries use escape_string
=2D the layout now looks more postfixadmin-like :-)  (separate editing=20
  page instead of "embedding" it in the list view)
=2D no more "undefined index" warnings (see below)
=2D known bug: adding a new entry is totally broken right now :-(  -=20
  probably I applied too much quoting to the SQL query...
=2D ToDo: insert a domain dropdown to only display fetchmail setup of a=20
  specific domain
=2D ToDo: fetchmail.php and fetchmail.tpl contain lots of tabs which need=20
  to be converted to spaces. I'll do a separate commit just for these=20
  whitespace changes.

Note 1:
=46eel free to use the safeget/safepost/safeserver functions at other=20
places too ;-)

    $var =3D safeget('var');
is easier to use than
    $var =3D "";
    if (isset($_GET['var'])) $var =3D $_GET['var'];

Optionally you can specify a default value which will be returned if the=20
$_GET variable is not set:
    $var =3D safeget('var', 'default');


Note 2:
$fm_struct in fetchmail.php is a really useful array once you understand=20
how to use it. We should consider to use similar arrays for the other=20
tables (something for after the 2.2 release).


Regards,

Christian Boltz
=2D-=20
PS: Achja, Du schuldest mir eine neue Tischplatte... Warum mu=DFte ich=20
heute morgen nur den SuSE-Ordner =F6ffnen? [Helga Fischer in suse-linux]

<snip>
> Note 1:
> Feel free to use the safeget/safepost/safeserver functions at other=20
> places too ;-)
>=20
>     $var =3D safeget('var');
> is easier to use than
>     $var =3D "";
>     if (isset($_GET['var'])) $var =3D $_GET['var'];
>=20
> Optionally you can specify a default value which will be returned if the=
=20
> $_GET variable is not set:
>     $var =3D safeget('var', 'default');

It's name (safeget) implies (to me) that it will return something
safe.... and probably doesn't need to have escape_string applied on it.
I know this isn't the case.

Would it be more useful to do something like Zend_Filter - namely
ensuring that a field matches a given type as well.

function safeget($name, $type, $default =3D null)
or something; so you could ensure you had e.g. an int back?

>=20
> Note 2:
> $fm_struct in fetchmail.php is a really useful array once you understand=
=20
> how to use it. We should consider to use similar arrays for the other=20
> tables (something for after the 2.2 release).

Guess I'll have to read the code sometime then :)

(Sorry I've not done much lately, I'll pull my finger out one day soon)

Thanks
David.
--=20
David Goodwin=20

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]

Hello,

Am Dienstag, 23. Oktober 2007 schrieb David Goodwin:
> > Note 1:
> > Feel free to use the safeget/safepost/safeserver functions at other
> > places too ;-)
[...]
> It's name (safeget) implies (to me) that it will return something
> safe.... and probably doesn't need to have escape_string applied on
> it. I know this isn't the case.

Hmm, I'm using this function names in some other projects and homepages=20
I'm involved in, and you are the first one who complains about the=20
name ;-)

"safeget" because you won't get any "undefined index" warnings and you=20
have a sane dafault as fallback. (We could also think about including=20
stripslashes if magic_quotes are on.)

Anyhow: If you know better names for these functions, just tell me ;-)

> Would it be more useful to do something like Zend_Filter - namely
> ensuring that a field matches a given type as well.
>
> function safeget($name, $type, $default =3D null)
> or something; so you could ensure you had e.g. an int back?

I usually do this using
    $var =3D (int) safeget('var');

Doing it inside safeget would make things more difficult - it would need=20
some if or case switching. And you never know which types you need and=20
will have to add another type every now and then. (I'm not even talking=20
about values that must validate against a regex etc.)

> > Note 2:
> > $fm_struct in fetchmail.php is a really useful array once you
> > understand how to use it. We should consider to use similar arrays
> > for the other tables (something for after the 2.2 release).
>
> Guess I'll have to read the code sometime then :)

Yes ;-)
Hint: read the comments around the array definition, and then read the=20
template file. Or simply play a bit with the values and reload the=20
fetchmail page in your browser...

> (Sorry I've not done much lately, I'll pull my finger out one day
> soon)

No problem. As long as nobody pays you, nobody can/will force you to do=20
lots of work ;-)


Regards,

Christian Boltz
=2D-=20
> > Wow consensus in less than 24 hours....imagine if it always
> > worked that way....:-)
> Something smells fishy here ;-)
Do you have the solution(tm) for the "Kanzlerfrage"? :)
[>> Peter Flodin, > Andreas J=E4ger und Christoph Thiel in opensuse]