On Thu, Jun 27, 2002 at 07:27:52AM +0200, Vitezslav Samel wrote:
> don't know which bug it fixes (not included)
I don't know either, but I'll keep it unless I find a reason against it.
I'm sure it didn't get added by accident...
> not applied - what's the problem?
ISTR it being necessary to have joe work properly on 64-bit architectures.
> not applied - SHOULD be in mainstream? (does joe works better,
> more effeciently with this patch or what ???)
It wouldn't work properly without it...
> better (and more portable) fix included as of 2.9.1
Both versions suck :)
The O_NOFOLLOW is a GNU extension, yes, but that's not the true problem with
our patch. The problem is that it ignores the privacy of the data, as it
will hapilly write the data to someone else's DEADJOE file. Sadly, I never
got around to reviewing the patch after the initial security advisory craze.
Your version doesn't seem to check any errnos... but I only had a short
glimpse at it.
> Debian specific patch - will not be applied to mainstream
Obviously it was necessary to do this that way without autoconf.
> value of CFLAGS now depends on autoconf (with user value precedence)
> your change long --> int is bogus (ftell is "long ftell(FILE *)"
> according to my man-pages), also change "oaddr=addr" to
> "oaddr=addr=0" is bogus due to goto loop near the end of the gen()
I'll fix that, thanks. (Dijkstra would hate Joe Allen. :)
2. That which causes joy or happiness.