Mifos - Microfinance Open Source

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kay Chau updated MIFOS-3610:
----------------------------

         Assignee: mifosdeveloperqueue
    Fix Version/s: Unscheduled

> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: mifosdeveloperqueue
>            Priority: Trivial
>             Fix For: Unscheduled
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=69733#comment-69733 ] 

Lukasz Chudy commented on MIFOS-3610:
-------------------------------------

Issue still exists in Release 2.2
                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: mifosdeveloperqueue
>            Priority: Trivial
>             Fix For: Unscheduled
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

keithwoodlock reassigned MIFOS-3610:
------------------------------------

    Assignee: keithwoodlock  (was: mifosdeveloperqueue)
    
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Unscheduled
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=69736#comment-69736 ] 

keithwoodlock commented on MIFOS-3610:
--------------------------------------

userGlobalNo doesn't appear to be used in any presentation files? (.jsp, .ftl, .xml)

Theres no indication from the description what the actual issue here is as a result of userGlobalNo not being populated.

I guess pre the move to spring security it may of been used to hold the personnel_global_number, not sure but in 2.2 its still not used anywhere as far as I can see.
                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Unscheduled
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=69739#comment-69739 ] 

Ferenc Kovács commented on MIFOS-3610:
--------------------------------------

well, a non-populated property is somewhat useless, isn't it? :-)

actually i wanted to use it to provide client-client integration (and sso) with another systems...

                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Unscheduled
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=69740#comment-69740 ] 

keithwoodlock commented on MIFOS-3610:
--------------------------------------

It is indeed Frenc :) You should use the global number of PersonnelBO entity (which is representation of users (and personnel) in mifos)
                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Unscheduled
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=69742#comment-69742 ] 

Mifos Hudson Jira Plugin User commented on MIFOS-3610:
------------------------------------------------------

Integrated in !http://ci.mifos.org/hudson/images/16x16/yellow.png! [head-g-release-secondary #150|http://ci.mifos.org/hudson/job/head-g-release-secondary/150/]
     MIFOS-3610: remove globalUserNo field from UserContext as it not used anywhere.

Keith Woodlock : 
Files : 
* abstract-domain/src/main/java/org/mifos/security/util/UserContext.java

                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Unscheduled
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

keithwoodlock resolved MIFOS-3610.
----------------------------------

       Resolution: Invalid
    Fix Version/s:     (was: Unscheduled)
                   Release 2.2.1
    Scheduled For: Release
         Assignee: Lukasz Chudy  (was: keithwoodlock)
             Team: Community  (was: Core)

marking as invalid and removed the unused userglobalNo field from userContext
                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: Lukasz Chudy
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=69745#comment-69745 ] 

Ferenc Kovács commented on MIFOS-3610:
--------------------------------------

Sorry I don't really understand. This is exactly what happens: you populate the usercontext with data from PersonnelBO. Why to separate populating this attribute from populating other user data (eg. name, etc.)?


                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: Lukasz Chudy
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=70148#comment-70148 ] 

Mifos Hudson Jira Plugin User commented on MIFOS-3610:
------------------------------------------------------

Integrated in !http://ci.mifos.org/hudson/images/16x16/yellow.png! [head-master-secondary #512|http://ci.mifos.org/hudson/job/head-master-secondary/512/]
     MIFOS-3610: remove globalUserNo field from UserContext as it not used anywhere.

Keith Woodlock : 
Files : 
* abstract-domain/src/main/java/org/mifos/security/util/UserContext.java

                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: Lukasz Chudy
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=70153#comment-70153 ] 

Lukasz Chudy commented on MIFOS-3610:
-------------------------------------

Keith,

You've marked this issue as invalid but what about the Ferenc question?
                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: Lukasz Chudy
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Chudy reassigned MIFOS-3610:
-----------------------------------

    Assignee: keithwoodlock  (was: Lukasz Chudy)
    
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=70155#comment-70155 ] 

keithwoodlock commented on MIFOS-3610:
--------------------------------------

Lukasz, Ferenc,

As far as I can see, the userContext was never populated with the user global no. So I marked the issue as invalid as if ferenc or any other developer wanted access to the user global no they could get that off the PersonnelBO entity itself (infact its DTO equivalent) rather than translating it into another location (UserContext).

Added to this, the UserContext is passed back to .jsp pages but it is not the strategy with .ftl pages. Instead other DTO objects are passed back and the objective going forward was to remove all .jsp pages and release the lock they have on domain objects.

                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=70157#comment-70157 ] 

Ferenc Kovács commented on MIFOS-3610:
--------------------------------------

Hi Keith!

Thank you for your thorough answer. If I understand you correctly, we can expect the whole UserContext story going to deprecated with the elimination of .jsp pages? So from now on, the "pure" DTO-s are to be used all over the client layer?

Best regards,
Ferenc


                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=70158#comment-70158 ] 

keithwoodlock commented on MIFOS-3610:
--------------------------------------

Ferenc, that was the plan at least but nothing has happened in this direction (re-implementation of UI using DTOs rather than domain bojects) since end of June 2011. 

There are a number of problems with JSP implementation of presentation and Whilst I dont know about DTO 'pure'-ness, it was the mechanism used to get around problems of passing domain entities back to presentation and the future goal of mifos to be an open 'platform' with a clear set of exposed services.


                
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: keithwoodlock
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

keithwoodlock reassigned MIFOS-3610:
------------------------------------

    Assignee: Lukasz Chudy  (was: keithwoodlock)
    
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: Lukasz Chudy
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://mifosforge.jira.com/browse/MIFOS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukasz Chudy closed MIFOS-3610.
-------------------------------

    
> UserContext.userGlobalNo does not get populated
> -----------------------------------------------
>
>                 Key: MIFOS-3610
>                 URL: http://mifosforge.jira.com/browse/MIFOS-3610
>             Project: mifos
>          Issue Type: Bug
>          Components: Personnel
>    Affects Versions: Release 1.6.0
>            Reporter: Ferenc Kovács
>            Assignee: Lukasz Chudy
>            Priority: Trivial
>             Fix For: Release 2.2.1
>
>   Original Estimate: 15 minutes
>  Remaining Estimate: 15 minutes
>
> PersonnelBO.setUserContext() does not set userGlobalNo attribute of the UserContext. Hence it is not available at jsp side.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira