Kdenlive - KDE Non Linear Video Editor

Found by cppcheck.
---
 src/renderwidget.cpp |    2 +-
 src/renderwidget.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/renderwidget.cpp b/src/renderwidget.cpp
index e4b6b9e..6136857 100644
--- a/src/renderwidget.cpp
+++ b/src/renderwidget.cpp
@@ -252,7 +252,7 @@ void RenderWidget::showInfoPanel()
     }
 }
 
-void RenderWidget::setDocumentPath(const QString path)
+void RenderWidget::setDocumentPath(const QString &path)
 {
     if (m_view.out_file->url().directory() == KUrl(m_projectFolder).directory()) {
         const QString fileName = m_view.out_file->url().fileName();
diff --git a/src/renderwidget.h b/src/renderwidget.h
index de2a370..6dd8ac4 100644
--- a/src/renderwidget.h
+++ b/src/renderwidget.h
@@ -116,7 +116,7 @@ public:
     void setProfile(MltVideoProfile profile);
     void setRenderJob(const QString &dest, int progress = 0);
     void setRenderStatus(const QString &dest, int status, const QString &error);
-    void setDocumentPath(const QString path);
+    void setDocumentPath(const QString &path);
     void reloadProfiles();
     void setRenderProfile(QMap <QString, QString> props);
     int waitingJobsCount() const;
-- 
1.7.5.4

Found by cppcheck.
---
 src/docclipbase.cpp |    4 ++--
 src/docclipbase.h   |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/docclipbase.cpp b/src/docclipbase.cpp
index 527f939..fc45161 100644
--- a/src/docclipbase.cpp
+++ b/src/docclipbase.cpp
@@ -209,7 +209,7 @@ bool DocClipBase::isTransparent() const
     return (m_properties.value("transparency") == "1");
 }
 
-const QString DocClipBase::getProperty(const QString prop) const
+const QString DocClipBase::getProperty(const QString &prop) const
 {
     return m_properties.value(prop);
 }
@@ -870,7 +870,7 @@ void DocClipBase::clearProperty(const QString &key)
     m_properties.remove(key);
 }
 
-void DocClipBase::getFileHash(const QString url)
+void DocClipBase::getFileHash(const QString &url)
 {
     if (m_clipType == SLIDESHOW) return;
     QFile file(url);
diff --git a/src/docclipbase.h b/src/docclipbase.h
index a19d226..95e0b6b 100644
--- a/src/docclipbase.h
+++ b/src/docclipbase.h
@@ -76,7 +76,7 @@ Q_OBJECT public:
     bool isTransparent() const;
 
     /** Returns any property of this clip. */
-    const QString getProperty(const QString prop) const;
+    const QString getProperty(const QString &prop) const;
     void setProperty(const QString &key, const QString &value);
     void clearProperty(const QString &key);
 
@@ -248,7 +248,7 @@ private:   // Private attributes
     void slotRefreshProducer();
     void setProducerProperty(const char *name, int data);
     void setProducerProperty(const char *name, double data);
-    void getFileHash(const QString url);
+    void getFileHash(const QString &url);
     /** @brief When duplicating a producer, make sure all manually set properties are passed to it. */
     void adjustProducerProperties(Mlt::Producer *prod, const QString &id, bool mute, bool blind);
     /** @brief Create another instance of a producer. */
-- 
1.7.5.4

Found by cppcheck.
---
 src/dvdwizardchapters.cpp |    2 +-
 src/dvdwizardchapters.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/dvdwizardchapters.cpp b/src/dvdwizardchapters.cpp
index 0804f5c..807e180 100644
--- a/src/dvdwizardchapters.cpp
+++ b/src/dvdwizardchapters.cpp
@@ -134,7 +134,7 @@ void DvdWizardChapters::slotGoToChapter()
     if (m_view.chapters_list->currentItem()) m_monitor->setTimePos(m_tc.reformatSeparators(m_view.chapters_list->currentItem()->text() + ":00"));
 }
 
-void DvdWizardChapters::setVobFiles(bool isPal, bool isWide, const QStringList movies, const QStringList durations, const QStringList chapters)
+void DvdWizardChapters::setVobFiles(bool isPal, bool isWide, const QStringList &movies, const QStringList &durations, const QStringList &chapters)
 {
     m_isPal = isPal;
     QString profile;
diff --git a/src/dvdwizardchapters.h b/src/dvdwizardchapters.h
index 620da01..515d942 100644
--- a/src/dvdwizardchapters.h
+++ b/src/dvdwizardchapters.h
@@ -39,7 +39,7 @@ public:
     virtual bool isComplete() const;
     void changeProfile(bool isPal);
     void setPal(bool isPal);
-    void setVobFiles(bool isPal, bool isWide, const QStringList movies, const QStringList durations, const QStringList chapters);
+    void setVobFiles(bool isPal, bool isWide, const QStringList &movies, const QStringList &durations, const QStringList &chapters);
     QStringList selectedTitles() const;
     QStringList selectedTargets() const;
     QStringList chapters(int ix) const;
-- 
1.7.5.4

Found by cppcheck.
---
 src/dvdwizardvob.cpp |    4 ++--
 src/dvdwizardvob.h   |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/dvdwizardvob.cpp b/src/dvdwizardvob.cpp
index 39e7d37..8b9b0d6 100644
--- a/src/dvdwizardvob.cpp
+++ b/src/dvdwizardvob.cpp
@@ -276,7 +276,7 @@ QString DvdWizardVob::introMovie() const
     return m_view.intro_vob->url().path();
 }
 
-void DvdWizardVob::setIntroMovie(const QString path)
+void DvdWizardVob::setIntroMovie(const QString& path)
 {
     m_view.intro_vob->setUrl(KUrl(path));
     m_view.use_intro->setChecked(path.isEmpty() == false);
@@ -338,7 +338,7 @@ bool DvdWizardVob::isWide() const
     return (m_view.dvd_profile->currentIndex() == 1 || m_view.dvd_profile->currentIndex() == 3);
 }
 
-void DvdWizardVob::setProfile(const QString profile)
+void DvdWizardVob::setProfile(const QString& profile)
 {
     if (profile == "dv_pal") m_view.dvd_profile->setCurrentIndex(0);
     else if (profile == "dv_pal_wide") m_view.dvd_profile->setCurrentIndex(1);
diff --git a/src/dvdwizardvob.h b/src/dvdwizardvob.h
index 6fd5b7f..58698cf 100644
--- a/src/dvdwizardvob.h
+++ b/src/dvdwizardvob.h
@@ -49,10 +49,10 @@ public:
     int duration(int ix) const;
     QStringList durations() const;
     QStringList chapters() const;
-    void setProfile(const QString profile);
+    void setProfile(const QString& profile);
     void clear();
     void updateChapters(QMap <QString, QString> chaptersdata);
-    void setIntroMovie(const QString path);
+    void setIntroMovie(const QString& path);
 
 private:
     Ui::DvdWizardVob_UI m_view;
-- 
1.7.5.4

Found by cppcheck.
---
 src/effectslist.cpp |    2 +-
 src/effectslist.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/effectslist.cpp b/src/effectslist.cpp
index f3ac887..6fc98a9 100644
--- a/src/effectslist.cpp
+++ b/src/effectslist.cpp
@@ -177,7 +177,7 @@ bool EffectsList::hasGeometryKeyFrames(QDomElement effect)
     return false;
 }
 
-void EffectsList::clone(const EffectsList original)
+void EffectsList::clone(const EffectsList &original)
 {
     setContent(original.toString());
     m_baseElement = documentElement();
diff --git a/src/effectslist.h b/src/effectslist.h
index a12a36f..456dda5 100644
--- a/src/effectslist.h
+++ b/src/effectslist.h
@@ -58,7 +58,7 @@ public:
     QStringList effectNames();
     QString getInfo(const QString & tag, const QString & id) const;
     QString getInfoFromIndex(const int ix) const;
-    void clone(const EffectsList original);
+    void clone(const EffectsList &original);
     void append(QDomElement e);
     bool isEmpty() const;
     int count() const;
-- 
1.7.5.4

Found by cppcheck:

[../src/dvdwizardmenu.h:39]: (warning) Member variable 'DvdScene::m_width' is not initialized in the constructor.
[../src/dvdwizardmenu.h:39]: (warning) Member variable 'DvdScene::m_height' is not initialized in the constructor.
---
 src/dvdwizardmenu.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/dvdwizardmenu.h b/src/dvdwizardmenu.h
index 6a9d44c..8c9931e 100644
--- a/src/dvdwizardmenu.h
+++ b/src/dvdwizardmenu.h
@@ -36,7 +36,9 @@ class DvdScene : public QGraphicsScene
 {
 
 public:
-    DvdScene(QObject * parent = 0): QGraphicsScene(parent) {}
+    DvdScene(QObject * parent = 0): QGraphicsScene(parent) {
+        m_width = 0; m_height = 0;
+    }
     void setProfile(int width, int height) {
         m_width = width;
         m_height = height;
-- 
1.7.5.4

Found by cppcheck:

[../src/abstractclipitem.h:45]: (performance) Parameter 'info' is passed as a value. It could be passed as a (const) reference which is usually faster and recommended in C++.
[../src/abstractclipitem.h:52]: (performance) Parameter 'pos' is passed as a value. It could be passed as a (const) reference which is usually faster and recommended in C++.
[../src/abstractclipitem.h:53]: (performance) Parameter 'pos' is passed as a value. It could be passed as a (const) reference which is usually faster and recommended in C++.
---
 src/abstractclipitem.cpp |    6 +++---
 src/abstractclipitem.h   |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/abstractclipitem.cpp b/src/abstractclipitem.cpp
index 030ec84..1dd8862 100644
--- a/src/abstractclipitem.cpp
+++ b/src/abstractclipitem.cpp
@@ -29,7 +29,7 @@
 #include <QToolTip>
 #include <QGraphicsSceneMouseEvent>
 
-AbstractClipItem::AbstractClipItem(const ItemInfo info, const QRectF& rect, double fps) :
+AbstractClipItem::AbstractClipItem(const ItemInfo &info, const QRectF& rect, double fps) :
         QObject(),
         QGraphicsRectItem(rect),
         m_info(info),
@@ -395,7 +395,7 @@ double AbstractClipItem::selectedKeyFrameValue() const
     return m_keyframes.value(m_selectedKeyframe);
 }
 
-void AbstractClipItem::updateKeyFramePos(const GenTime pos, const double value)
+void AbstractClipItem::updateKeyFramePos(const GenTime &pos, const double value)
 {
     if (!m_keyframes.contains(m_editedKeyframe))
         return;
@@ -437,7 +437,7 @@ int AbstractClipItem::keyFrameNumber() const
     return m_keyframes.count();
 }
 
-int AbstractClipItem::addKeyFrame(const GenTime pos, const double value)
+int AbstractClipItem::addKeyFrame(const GenTime &pos, const double value)
 {
     QRectF br = sceneBoundingRect();
     double maxh = 100.0 / br.height() / m_keyframeFactor;
diff --git a/src/abstractclipitem.h b/src/abstractclipitem.h
index ff59dec..c621c8c 100644
--- a/src/abstractclipitem.h
+++ b/src/abstractclipitem.h
@@ -42,15 +42,15 @@ class AbstractClipItem : public QObject, public QGraphicsRectItem
 #endif
 
 public:
-    AbstractClipItem(const ItemInfo info, const QRectF& rect, double fps);
+    AbstractClipItem(const ItemInfo &info, const QRectF& rect, double fps);
     virtual ~ AbstractClipItem();
     void updateSelectedKeyFrame();
 
     /** @brief Move the selected keyframe (does not influence the effect, only the display in timeline).
     * @param pos new Position
     * @param value new Value */
-    void updateKeyFramePos(const GenTime pos, const double value);
-    int addKeyFrame(const GenTime pos, const double value);
+    void updateKeyFramePos(const GenTime &pos, const double value);
+    int addKeyFrame(const GenTime &pos, const double value);
     bool hasKeyFrames() const;
     int editedKeyFramePos() const;
     int selectedKeyFramePos() const;
-- 
1.7.5.4

Found by cppcheck.
---
 src/docclipbase.h   |    4 ++--
 src/projectlist.cpp |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/docclipbase.h b/src/docclipbase.h
index 95e0b6b..b23945d 100644
--- a/src/docclipbase.h
+++ b/src/docclipbase.h
@@ -278,9 +278,9 @@ public slots:
 signals:
     void gotAudioData();
     /** @brief Generate a proxy clip (lower resolution copy) named like the clip's hash. */
-    void createProxy(const QString id);
+    void createProxy(const QString &id);
     /** @brief Abort creation of the proxy clip (lower resolution copy). */
-    void abortProxy(const QString id, const QString proxyPath);
+    void abortProxy(const QString &id, const QString &proxyPath);
 };
 
 #endif
diff --git a/src/projectlist.cpp b/src/projectlist.cpp
index ab15315..69af733 100644
--- a/src/projectlist.cpp
+++ b/src/projectlist.cpp
@@ -1018,8 +1018,8 @@ void ProjectList::slotAddClip(DocClipBase *clip, bool getProperties)
         item = new ProjectItem(m_listView, clip);
     }
     if (item->data(0, DurationRole).isNull()) item->setData(0, DurationRole, i18n("Loading"));
-    connect(clip, SIGNAL(createProxy(const QString)), this, SLOT(slotCreateProxy(const QString)));
-    connect(clip, SIGNAL(abortProxy(const QString, const QString)), this, SLOT(slotAbortProxy(const QString, const QString)));
+    connect(clip, SIGNAL(createProxy(const QString &)), this, SLOT(slotCreateProxy(const QString &)));
+    connect(clip, SIGNAL(abortProxy(const QString &, const QString &)), this, SLOT(slotAbortProxy(const QString, const QString)));
     if (getProperties) {
         m_listView->processLayout();
         QDomElement e = clip->toXML().cloneNode().toElement();
-- 
1.7.5.4

Found by cppcheck.
---
 src/customtrackview.cpp |   28 ++++++++++++++--------------
 src/customtrackview.h   |   30 +++++++++++++++---------------
 2 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/src/customtrackview.cpp b/src/customtrackview.cpp
index 38ab4d6..04874a6 100644
--- a/src/customtrackview.cpp
+++ b/src/customtrackview.cpp
@@ -1371,7 +1371,7 @@ void CustomTrackView::editItemDuration()
     }
 }
 
-void CustomTrackView::editKeyFrame(const GenTime /*pos*/, const int /*track*/, const int /*index*/, const QString /*keyframes*/)
+void CustomTrackView::editKeyFrame(const GenTime & /*pos*/, const int /*track*/, const int /*index*/, const QString & /*keyframes*/)
 {
     /*ClipItem *clip = getClipItemAt((int)pos.frames(m_document->fps()), track);
     if (clip) {
@@ -1456,7 +1456,7 @@ void CustomTrackView::insertClipCut(DocClipBase *clip, int in, int out)
         splitAudio();
 }
 
-bool CustomTrackView::insertDropClips(const QMimeData *data, const QPoint pos)
+bool CustomTrackView::insertDropClips(const QMimeData *data, const QPoint &pos)
 {
     if (data->hasFormat("kdenlive/clip")) {
         m_clipDrag = true;
@@ -3045,7 +3045,7 @@ void CustomTrackView::slotInsertSpace()
     }
 }
 
-void CustomTrackView::insertSpace(QList<ItemInfo> clipsToMove, QList<ItemInfo> transToMove, int track, const GenTime duration, const GenTime offset)
+void CustomTrackView::insertSpace(QList<ItemInfo> clipsToMove, QList<ItemInfo> transToMove, int track, const GenTime &duration, const GenTime &offset)
 {
     int diff = duration.frames(m_document->fps());
     resetSelectionGroup();
@@ -4270,7 +4270,7 @@ Transition *CustomTrackView::getTransitionItemAtStart(GenTime pos, int track)
     return clip;
 }
 
-void CustomTrackView::moveClip(const ItemInfo start, const ItemInfo end, bool refresh)
+void CustomTrackView::moveClip(const ItemInfo &start, const ItemInfo &end, bool refresh)
 {
     if (m_selectionGroup) resetSelectionGroup(false);
     ClipItem *item = getClipItemAt((int) start.startPos.frames(m_document->fps()), start.track);
@@ -4313,7 +4313,7 @@ void CustomTrackView::moveClip(const ItemInfo start, const ItemInfo end, bool re
     if (refresh) m_document->renderer()->doRefresh();
 }
 
-void CustomTrackView::moveGroup(QList <ItemInfo> startClip, QList <ItemInfo> startTransition, const GenTime offset, const int trackOffset, bool reverseMove)
+void CustomTrackView::moveGroup(QList <ItemInfo> startClip, QList <ItemInfo> startTransition, const GenTime &offset, const int trackOffset, bool reverseMove)
 {
     // Group Items
     resetSelectionGroup();
@@ -4431,7 +4431,7 @@ void CustomTrackView::moveGroup(QList <ItemInfo> startClip, QList <ItemInfo> sta
     } else kDebug() << "///////// WARNING; NO GROUP TO MOVE";
 }
 
-void CustomTrackView::moveTransition(const ItemInfo start, const ItemInfo end, bool m_refresh)
+void CustomTrackView::moveTransition(const ItemInfo &start, const ItemInfo &end, bool m_refresh)
 {
     Transition *item = getTransitionItemAt(start.startPos, start.track);
     if (!item) {
@@ -4479,7 +4479,7 @@ void CustomTrackView::moveTransition(const ItemInfo start, const ItemInfo end, b
     setDocumentModified();
 }
 
-void CustomTrackView::resizeClip(const ItemInfo start, const ItemInfo end, bool dontWorry)
+void CustomTrackView::resizeClip(const ItemInfo &start, const ItemInfo &end, bool dontWorry)
 {
     bool resizeClipStart = (start.startPos != end.startPos);
     ClipItem *item = getClipItemAtStart(start.startPos, start.track);
@@ -4983,7 +4983,7 @@ void CustomTrackView::slotDeleteAllClipMarkers(const QString &id)
     m_commandStack->push(deleteMarkers);
 }
 
-void CustomTrackView::addMarker(const QString &id, const GenTime &pos, const QString comment)
+void CustomTrackView::addMarker(const QString &id, const GenTime &pos, const QString &comment)
 {
     DocClipBase *base = m_document->clipManager()->getClipById(id);
     if (!comment.isEmpty()) base->addSnapMarker(pos, comment);
@@ -5015,7 +5015,7 @@ void CustomTrackView::buildGuidesMenu(QMenu *goMenu) const
     goMenu->setEnabled(!m_guides.isEmpty());
 }
 
-void CustomTrackView::editGuide(const GenTime oldPos, const GenTime pos, const QString &comment)
+void CustomTrackView::editGuide(const GenTime &oldPos, const GenTime &pos, const QString &comment)
 {
     if (oldPos > GenTime() && pos > GenTime()) {
         // move guide
@@ -5043,7 +5043,7 @@ void CustomTrackView::editGuide(const GenTime oldPos, const GenTime pos, const Q
     m_document->syncGuides(m_guides);
 }
 
-bool CustomTrackView::addGuide(const GenTime pos, const QString &comment)
+bool CustomTrackView::addGuide(const GenTime &pos, const QString &comment)
 {
     for (int i = 0; i < m_guides.count(); i++) {
         if (m_guides.at(i)->position() == pos) {
@@ -5833,7 +5833,7 @@ void CustomTrackView::autoTransition()
     setDocumentModified();
 }
 
-void CustomTrackView::clipNameChanged(const QString id, const QString name)
+void CustomTrackView::clipNameChanged(const QString &id, const QString &name)
 {
     QList<QGraphicsItem *> list = scene()->items();
     ClipItem *clip = NULL;
@@ -5880,7 +5880,7 @@ void CustomTrackView::getTransitionAvailableSpace(AbstractClipItem *item, GenTim
     }
 }
 
-void CustomTrackView::loadGroups(const QDomNodeList groups)
+void CustomTrackView::loadGroups(const QDomNodeList &groups)
 {
     for (int i = 0; i < groups.count(); i++) {
         QDomNodeList children = groups.at(i).childNodes();
@@ -6554,7 +6554,7 @@ bool CustomTrackView::hasAudio(int track) const
     return false;
 }
 
-void CustomTrackView::slotAddTrackEffect(const QDomElement effect, int ix)
+void CustomTrackView::slotAddTrackEffect(const QDomElement &effect, int ix)
 {
     AddEffectCommand *command = new AddEffectCommand(this, m_document->tracksCount() - ix, GenTime(-1), effect, true);
     m_commandStack->push(command);
@@ -6562,7 +6562,7 @@ void CustomTrackView::slotAddTrackEffect(const QDomElement effect, int ix)
 }
 
 
-EffectsParameterList CustomTrackView::getEffectArgs(const QDomElement effect)
+EffectsParameterList CustomTrackView::getEffectArgs(const QDomElement &effect)
 {
     EffectsParameterList parameters;
     QLocale locale;
diff --git a/src/customtrackview.h b/src/customtrackview.h
index 70c89e7..dbde9f8 100644
--- a/src/customtrackview.h
+++ b/src/customtrackview.h
@@ -60,16 +60,16 @@ public:
     void configTracks(QList <TrackInfo> trackInfos);
     int cursorPos();
     void checkAutoScroll();
-    void moveClip(const ItemInfo start, const ItemInfo end, bool refresh);
-    void moveGroup(QList <ItemInfo> startClip, QList <ItemInfo> startTransition, const GenTime offset, const int trackOffset, bool reverseMove = false);
+    void moveClip(const ItemInfo &start, const ItemInfo &end, bool refresh);
+    void moveGroup(QList <ItemInfo> startClip, QList <ItemInfo> startTransition, const GenTime &offset, const int trackOffset, bool reverseMove = false);
     /** move transition, startPos = (old start, old end), endPos = (new start, new end) */
-    void moveTransition(const ItemInfo start, const ItemInfo end, bool m_refresh);
-    void resizeClip(const ItemInfo start, const ItemInfo end, bool dontWorry = false);
+    void moveTransition(const ItemInfo &start, const ItemInfo &end, bool m_refresh);
+    void resizeClip(const ItemInfo &start, const ItemInfo &end, bool dontWorry = false);
     void addClip(QDomElement xml, const QString &clipId, ItemInfo info, EffectsList list = EffectsList(), bool overwrite = false, bool push = false, bool refresh = true);
     void deleteClip(ItemInfo info, bool refresh = true);
     void slotDeleteClipMarker(const QString &comment, const QString &id, const GenTime &position);
     void slotDeleteAllClipMarkers(const QString &id);
-    void addMarker(const QString &id, const GenTime &pos, const QString comment);
+    void addMarker(const QString &id, const GenTime &pos, const QString &comment);
     void setScale(double scaleFactor, double verticalScale);
     void deleteClip(const QString &clipId);
     void slotAddEffect(QDomElement effect, GenTime pos, int track);
@@ -95,7 +95,7 @@ public:
     void slotSeekToPreviousSnap();
     void slotSeekToNextSnap();
     double getSnapPointForPos(double pos);
-    void editKeyFrame(const GenTime pos, const int track, const int index, const QString keyframes);
+    void editKeyFrame(const GenTime &pos, const int track, const int index, const QString &keyframes);
     bool findString(const QString &text);
     void selectFound(QString track, QString pos);
     bool findNextString(const QString &text);
@@ -117,7 +117,7 @@ public:
     void slotInsertSpace();
     /** @brief Prepares removing space. */
     void slotRemoveSpace();
-    void insertSpace(QList<ItemInfo> clipsToMove, QList<ItemInfo> transToMove, int track, const GenTime duration, const GenTime offset);
+    void insertSpace(QList<ItemInfo> clipsToMove, QList<ItemInfo> transToMove, int track, const GenTime &duration, const GenTime &offset);
     ClipItem *getActiveClipUnderCursor(bool allowOutsideCursor = false) const;
     void deleteTimelineTrack(int ix, TrackInfo trackinfo);
     void saveThumbnails();
@@ -133,7 +133,7 @@ public:
     void lockTrack(int ix, bool lock, bool requestUpdate = true);
     void groupClips(bool group = true);
     void doGroupClips(QList <ItemInfo> clipInfos, QList <ItemInfo> transitionInfos, bool group);
-    void loadGroups(const QDomNodeList groups);
+    void loadGroups(const QDomNodeList &groups);
 
     /** @brief Creates SplitAudioCommands for selected clips. */
     void splitAudio();
@@ -209,7 +209,7 @@ public slots:
      * @param t Position of the marker
      * @param c Comment of the marker */
     void slotAddClipMarker(const QString &id, GenTime t, QString c);
-    bool addGuide(const GenTime pos, const QString &comment);
+    bool addGuide(const GenTime &pos, const QString &comment);
 
     /** @brief Shows a dialog for adding a guide.
      * @param dialog (default = true) false = do not show the dialog but use current position as position and comment */
@@ -218,7 +218,7 @@ public slots:
     void slotEditGuide(int guidePos = -1);
     void slotDeleteGuide(int guidePos = -1);
     void slotDeleteAllGuides();
-    void editGuide(const GenTime oldPos, const GenTime pos, const QString &comment);
+    void editGuide(const GenTime &oldPos, const GenTime &pos, const QString &comment);
     void copyClip();
     void pasteClip();
     void pasteClipEffects();
@@ -231,7 +231,7 @@ public slots:
     void slotDeleteTrack(int ix);
     /** @brief Shows the configure tracks dialog. */
     void slotConfigTracks(int ix);
-    void clipNameChanged(const QString id, const QString name);
+    void clipNameChanged(const QString &id, const QString &name);
     void slotTrackUp();
     void slotTrackDown();
     void slotSelectTrack(int ix);
@@ -259,7 +259,7 @@ public slots:
     /** @brief Add en effect to a track.
     * @param effect The new effect xml
     * @param ix The track index */
-    void slotAddTrackEffect(const QDomElement effect, int ix);
+    void slotAddTrackEffect(const QDomElement &effect, int ix);
 
     /** @brief Update the list of snap points (sticky timeline hotspots).
     * @param selected The currently selected clip if any
@@ -357,7 +357,7 @@ private:
     /** Get the index of the video track that is just below current track */
     int getPreviousVideoTrack(int track);
     void updatePositionEffects(ClipItem * item, ItemInfo info, bool standalone = true);
-    bool insertDropClips(const QMimeData *data, const QPoint pos);
+    bool insertDropClips(const QMimeData *data, const QPoint &pos);
     bool canBePastedTo(QList <ItemInfo> infoList, int type) const;
     bool canBePasted(QList<AbstractClipItem *> items, GenTime offset, int trackOffset) const;
     bool canBeMoved(QList<AbstractClipItem *> items, GenTime offset, int trackOffset) const;
@@ -410,7 +410,7 @@ private:
     void razorGroup(AbstractGroupItem *group, GenTime cutPos);
 
     /** @brief Gets the effect parameters that will be passed to Mlt. */
-    EffectsParameterList getEffectArgs(const QDomElement effect);
+    EffectsParameterList getEffectArgs(const QDomElement &effect);
 
     /** @brief Update Tracknames to fit again after track was added/deleted.
      * @param track Number of track which was added/deleted
@@ -464,7 +464,7 @@ signals:
     void activateDocumentMonitor();
     void trackHeightChanged();
     void tracksChanged();
-    void displayMessage(const QString, MessageType);
+    void displayMessage(const QString &, MessageType);
     void showClipFrame(DocClipBase *, QPoint, const int);
     void doTrackLock(int, bool);
     void updateClipMarkers(DocClipBase *);
-- 
1.7.5.4

Found by cppcheck.
---
 src/clipmanager.cpp |   16 ++++++++--------
 src/clipmanager.h   |   16 ++++++++--------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/clipmanager.cpp b/src/clipmanager.cpp
index 7993794..d3669ca 100644
--- a/src/clipmanager.cpp
+++ b/src/clipmanager.cpp
@@ -264,7 +264,7 @@ void ClipManager::resetProducersList(const QList <Mlt::Producer *> prods, bool d
     emit checkAllClips(displayRatioChanged, fpsChanged);
 }
 
-void ClipManager::slotAddClipList(const KUrl::List urls, const QString group, const QString &groupId)
+void ClipManager::slotAddClipList(const KUrl::List urls, const QString &group, const QString &groupId)
 {
     QUndoCommand *addClips = new QUndoCommand();
 
@@ -340,12 +340,12 @@ void ClipManager::slotAddClipList(const KUrl::List urls, const QString group, co
     }
 }
 
-void ClipManager::slotAddClipFile(const KUrl url, const QString group, const QString &groupId)
+void ClipManager::slotAddClipFile(const KUrl &url, const QString &group, const QString &groupId)
 {
     slotAddClipList(KUrl::List(url), group, groupId);
 }
 
-void ClipManager::slotAddXmlClipFile(const QString name, const QDomElement xml, const QString group, const QString &groupId)
+void ClipManager::slotAddXmlClipFile(const QString &name, const QDomElement &xml, const QString &group, const QString &groupId)
 {
     QDomDocument doc;
     doc.appendChild(doc.importNode(xml, true));
@@ -362,7 +362,7 @@ void ClipManager::slotAddXmlClipFile(const QString name, const QDomElement xml,
     m_doc->commandStack()->push(command);
 }
 
-void ClipManager::slotAddColorClipFile(const QString name, const QString color, QString duration, const QString group, const QString &groupId)
+void ClipManager::slotAddColorClipFile(const QString &name, const QString &color, QString duration, const QString &group, const QString &groupId)
 {
     QDomDocument doc;
     QDomElement prod = doc.createElement("producer");
@@ -383,10 +383,10 @@ void ClipManager::slotAddColorClipFile(const QString name, const QString color,
     m_doc->commandStack()->push(command);
 }
 
-void ClipManager::slotAddSlideshowClipFile(const QString name, const QString path, int count, const QString duration,
+void ClipManager::slotAddSlideshowClipFile(const QString &name, const QString &path, int count, const QString &duration,
         const bool loop, const bool crop, const bool fade,
         const QString &luma_duration, const QString &luma_file, const int softness,
-        const QString &animation, QString group, const QString &groupId)
+        const QString &animation, const QString &group, const QString &groupId)
 {
     QDomDocument doc;
     QDomElement prod = doc.createElement("producer");
@@ -416,7 +416,7 @@ void ClipManager::slotAddSlideshowClipFile(const QString name, const QString pat
 
 
 
-void ClipManager::slotAddTextClipFile(const QString titleName, int out, const QString xml, const QString group, const QString &groupId)
+void ClipManager::slotAddTextClipFile(const QString &titleName, int out, const QString &xml, const QString &group, const QString &groupId)
 {
     QDomDocument doc;
     QDomElement prod = doc.createElement("producer");
@@ -438,7 +438,7 @@ void ClipManager::slotAddTextClipFile(const QString titleName, int out, const QS
     m_doc->commandStack()->push(command);
 }
 
-void ClipManager::slotAddTextTemplateClip(QString titleName, const KUrl path, const QString group, const QString &groupId)
+void ClipManager::slotAddTextTemplateClip(QString titleName, const KUrl &path, const QString &group, const QString &groupId)
 {
     QDomDocument doc;
     QDomElement prod = doc.createElement("producer");
diff --git a/src/clipmanager.h b/src/clipmanager.h
index f9ac172..4bf78eb 100644
--- a/src/clipmanager.h
+++ b/src/clipmanager.h
@@ -70,22 +70,22 @@ Q_OBJECT public:
      * @param url file to add
      * @param group name of the group to insert the file in (can be empty)
      * @param groupId id of the group (if any) */
-    void slotAddClipFile(const KUrl url, const QString group, const QString &groupId);
+    void slotAddClipFile(const KUrl &url, const QString &group, const QString &groupId);
 
     /** @brief Adds a list of files to the project.
      * @param urls files to add
      * @param group name of the group to insert the files in (can be empty)
      * @param groupId id of the group (if any)
      * It checks for duplicated items and asks to the user for instructions. */
-    void slotAddClipList(const KUrl::List urls, const QString group, const QString &groupId);
-    void slotAddTextClipFile(const QString titleName, int out, const QString xml, const QString group, const QString &groupId);
-    void slotAddTextTemplateClip(QString titleName, const KUrl path, const QString group, const QString &groupId);
-    void slotAddXmlClipFile(const QString name, const QDomElement xml, const QString group, const QString &groupId);
-    void slotAddColorClipFile(const QString name, const QString color, QString duration, const QString group, const QString &groupId);
-    void slotAddSlideshowClipFile(const QString name, const QString path, int count, const QString duration,
+    void slotAddClipList(const KUrl::List urls, const QString &group, const QString &groupId);
+    void slotAddTextClipFile(const QString &titleName, int out, const QString &xml, const QString &group, const QString &groupId);
+    void slotAddTextTemplateClip(QString titleName, const KUrl &path, const QString &group, const QString &groupId);
+    void slotAddXmlClipFile(const QString &name, const QDomElement &xml, const QString &group, const QString &groupId);
+    void slotAddColorClipFile(const QString &name, const QString &color, QString duration, const QString &group, const QString &groupId);
+    void slotAddSlideshowClipFile(const QString &name, const QString &path, int count, const QString &duration,
                                   const bool loop, const bool crop,const bool fade,
                                   const QString &luma_duration, const QString &luma_file, const int softness,
-                                  const QString &animation, const QString group, const QString &groupId);
+                                  const QString &animation, const QString &group, const QString &groupId);
     DocClipBase *getClipById(QString clipId);
     const QList <DocClipBase *> getClipByResource(QString resource);
     void slotDeleteClips(QStringList ids);
-- 
1.7.5.4

Found by cppcheck.
---
 src/abstractscopewidget.cpp       |    2 +-
 src/abstractscopewidget.h         |    2 +-
 src/audioscopes/audiospectrum.cpp |    2 +-
 src/audioscopes/audiospectrum.h   |    2 +-
 src/audioscopes/spectrogram.cpp   |    2 +-
 src/audioscopes/spectrogram.h     |    2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/abstractscopewidget.cpp b/src/abstractscopewidget.cpp
index 2ef642b..022063d 100644
--- a/src/abstractscopewidget.cpp
+++ b/src/abstractscopewidget.cpp
@@ -554,7 +554,7 @@ void AbstractScopeWidget::slotAutoRefreshToggled(bool autoRefresh)
     }
 }
 
-void AbstractScopeWidget::handleMouseDrag(const QPoint, const RescaleDirection, const Qt::KeyboardModifiers) { }
+void AbstractScopeWidget::handleMouseDrag(const QPoint &, const RescaleDirection, const Qt::KeyboardModifiers) { }
 
 
 #ifdef DEBUG_ASW
diff --git a/src/abstractscopewidget.h b/src/abstractscopewidget.h
index a251505..e518e1f 100644
--- a/src/abstractscopewidget.h
+++ b/src/abstractscopewidget.h
@@ -184,7 +184,7 @@ protected:
     /** The Abstract Scope will try to detect the movement direction when dragging on the widget with the mouse.
         As soon as the direction is determined it will execute this method. Can be used e.g. for re-scaling content.
         This is just a dummy function, re-implement to add functionality. */
-    virtual void handleMouseDrag(const QPoint movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers);
+    virtual void handleMouseDrag(const QPoint &movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers);
 
     ///// Reimplemented /////
 
diff --git a/src/audioscopes/audiospectrum.cpp b/src/audioscopes/audiospectrum.cpp
index ecab68f..eeb6a53 100644
--- a/src/audioscopes/audiospectrum.cpp
+++ b/src/audioscopes/audiospectrum.cpp
@@ -509,7 +509,7 @@ void AudioSpectrum::slotResetMaxFreq()
 
 ///// EVENTS /////
 
-void AudioSpectrum::handleMouseDrag(const QPoint movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers)
+void AudioSpectrum::handleMouseDrag(const QPoint &movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers)
 {
     if (rescaleDirection == North) {
         // Nort-South direction: Adjust the dB scale
diff --git a/src/audioscopes/audiospectrum.h b/src/audioscopes/audiospectrum.h
index a0d8d29..3f486c2 100644
--- a/src/audioscopes/audiospectrum.h
+++ b/src/audioscopes/audiospectrum.h
@@ -56,7 +56,7 @@ protected:
     virtual void readConfig();
     void writeConfig();
 
-    virtual void handleMouseDrag(const QPoint movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers);
+    virtual void handleMouseDrag(const QPoint &movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers);
 
 private:
     Ui::AudioSpectrum_UI *ui;
diff --git a/src/audioscopes/spectrogram.cpp b/src/audioscopes/spectrogram.cpp
index c075900..bf06833 100644
--- a/src/audioscopes/spectrogram.cpp
+++ b/src/audioscopes/spectrogram.cpp
@@ -444,7 +444,7 @@ bool Spectrogram::isHUDDependingOnInput() const { return false; }
 bool Spectrogram::isScopeDependingOnInput() const { return true; }
 bool Spectrogram::isBackgroundDependingOnInput() const { return false; }
 
-void Spectrogram::handleMouseDrag(const QPoint movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers)
+void Spectrogram::handleMouseDrag(const QPoint &movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers)
 {
     if (rescaleDirection == North) {
         // Nort-South direction: Adjust the dB scale
diff --git a/src/audioscopes/spectrogram.h b/src/audioscopes/spectrogram.h
index e95ba69..8d3f5f4 100644
--- a/src/audioscopes/spectrogram.h
+++ b/src/audioscopes/spectrogram.h
@@ -52,7 +52,7 @@ protected:
     bool isBackgroundDependingOnInput() const;
     virtual void readConfig();
     void writeConfig();
-    void handleMouseDrag(const QPoint movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers);
+    void handleMouseDrag(const QPoint &movement, const RescaleDirection rescaleDirection, const Qt::KeyboardModifiers rescaleModifiers);
     void resizeEvent(QResizeEvent *event);
 
 private:
-- 
1.7.5.4

Found by cppcheck.
---
 src/guide.cpp      |    2 +-
 src/guide.h        |    2 +-
 src/mainwindow.cpp |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/guide.cpp b/src/guide.cpp
index 9c92236..47ba15e 100644
--- a/src/guide.cpp
+++ b/src/guide.cpp
@@ -70,7 +70,7 @@ CommentedTime Guide::info() const
     return CommentedTime(m_position, m_label);
 }
 
-void Guide::updateGuide(const GenTime newPos, const QString &comment)
+void Guide::updateGuide(const GenTime &newPos, const QString &comment)
 {
     m_position = newPos;
     setPos(m_position.frames(m_view->fps()), 0);
diff --git a/src/guide.h b/src/guide.h
index 1265d13..bcedf3a 100644
--- a/src/guide.h
+++ b/src/guide.h
@@ -36,7 +36,7 @@ class Guide : public QGraphicsLineItem
 public:
     Guide(CustomTrackView *view, GenTime pos, QString label, double height);
     GenTime position() const;
-    void updateGuide(const GenTime newPos, const QString &comment = QString());
+    void updateGuide(const GenTime &newPos, const QString &comment = QString());
     QString label() const;
     CommentedTime info() const;
     void updatePos();
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index 4b534f6..ae32c9b 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@@ -2495,7 +2495,7 @@ void MainWindow::connectDocument(TrackView *trackView, KdenliveDoc *doc)   //cha
 
     connect(doc, SIGNAL(docModified(bool)), this, SLOT(slotUpdateDocumentState(bool)));
     connect(doc, SIGNAL(guidesUpdated()), this, SLOT(slotGuidesUpdated()));
-    connect(doc, SIGNAL(saveTimelinePreview(const QString)), trackView, SLOT(slotSaveTimelinePreview(const QString)));
+    connect(doc, SIGNAL(saveTimelinePreview(const QString &)), trackView, SLOT(slotSaveTimelinePreview(const QString)));
     
     connect(m_notesWidget, SIGNAL(textChanged()), doc, SLOT(setModified()));
 
-- 
1.7.5.4

Found by cppcheck.
---
 src/effectstackview.cpp |    2 +-
 src/effectstackview.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/effectstackview.cpp b/src/effectstackview.cpp
index 92bcfce..95ff95c 100644
--- a/src/effectstackview.cpp
+++ b/src/effectstackview.cpp
@@ -159,7 +159,7 @@ void EffectStackView::slotSaveEffect()
     emit reloadEffects();
 }
 
-void EffectStackView::slotUpdateEffectParams(const QDomElement old, const QDomElement e)
+void EffectStackView::slotUpdateEffectParams(const QDomElement &old, const QDomElement &e)
 {
     if (m_trackMode)
         emit updateEffect(NULL, m_trackindex, old, e, m_ui.effectlist->currentRow());
diff --git a/src/effectstackview.h b/src/effectstackview.h
index e87b828..89055a2 100644
--- a/src/effectstackview.h
+++ b/src/effectstackview.h
@@ -94,7 +94,7 @@ public slots:
     * @param e New effect information
     *
     * Connected to a parameter change in the editor */
-    void slotUpdateEffectParams(const QDomElement old, const QDomElement e);
+    void slotUpdateEffectParams(const QDomElement &old, const QDomElement &e);
 
     /** @brief Removes the selected effect. */
     void slotItemDel();
-- 
1.7.5.4

Found by cppcheck.
---
 src/effectstackedit.cpp |    2 +-
 src/effectstackedit.h   |    4 ++--
 src/effectstackview.cpp |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/effectstackedit.cpp b/src/effectstackedit.cpp
index 955f0c5..af2b1e5 100644
--- a/src/effectstackedit.cpp
+++ b/src/effectstackedit.cpp
@@ -205,7 +205,7 @@ void EffectStackEdit::updateParameter(const QString &name, const QString &value)
     }
 }
 
-void EffectStackEdit::transferParamDesc(const QDomElement d, ItemInfo info, bool isEffect)
+void EffectStackEdit::transferParamDesc(const QDomElement &d, ItemInfo info, bool isEffect)
 {
     clearAllItems();
     if (m_keyframeEditor) delete m_keyframeEditor;
diff --git a/src/effectstackedit.h b/src/effectstackedit.h
index d277059..ea41b30 100644
--- a/src/effectstackedit.h
+++ b/src/effectstackedit.h
@@ -87,7 +87,7 @@ private:
 
 public slots:
     /** @brief Called when an effect is selected, builds the UI for this effect. */
-    void transferParamDesc(const QDomElement d, ItemInfo info, bool isEffect = true);
+    void transferParamDesc(const QDomElement &d, ItemInfo info, bool isEffect = true);
 
     /** @brief Called whenever(?) some parameter is changed in the gui.
      *
@@ -98,7 +98,7 @@ public slots:
     void slotSyncEffectsPos(int pos);
 
 signals:
-    void parameterChanged(const QDomElement, const QDomElement);
+    void parameterChanged(const QDomElement &, const QDomElement &);
     void seekTimeline(int);
     void displayMessage(const QString&, int);
     void checkMonitorPosition(int);
diff --git a/src/effectstackview.cpp b/src/effectstackview.cpp
index 53cb6c4..92bcfce 100644
--- a/src/effectstackview.cpp
+++ b/src/effectstackview.cpp
@@ -91,7 +91,7 @@ EffectStackView::EffectStackView(Monitor *monitor, QWidget *parent) :
     connect(m_ui.buttonReset, SIGNAL(clicked()), this, SLOT(slotResetEffect()));
     connect(m_ui.checkAll, SIGNAL(stateChanged(int)), this, SLOT(slotCheckAll(int)));
     connect(m_ui.buttonShowComments, SIGNAL(clicked()), this, SLOT(slotShowComments()));
-    connect(m_effectedit, SIGNAL(parameterChanged(const QDomElement, const QDomElement)), this , SLOT(slotUpdateEffectParams(const QDomElement, const QDomElement)));
+    connect(m_effectedit, SIGNAL(parameterChanged(const QDomElement &, const QDomElement &)), this , SLOT(slotUpdateEffectParams(const QDomElement &, const QDomElement &)));
     connect(m_effectedit, SIGNAL(seekTimeline(int)), this , SLOT(slotSeekTimeline(int)));
     connect(m_effectedit, SIGNAL(displayMessage(const QString&, int)), this, SIGNAL(displayMessage(const QString&, int)));
     connect(m_effectedit, SIGNAL(checkMonitorPosition(int)), this, SLOT(slotCheckMonitorPosition(int)));
-- 
1.7.5.4

Found by cppcheck.
---
 src/geometryval.cpp |    2 +-
 src/geometryval.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/geometryval.cpp b/src/geometryval.cpp
index 290435b..9dfe5f3 100644
--- a/src/geometryval.cpp
+++ b/src/geometryval.cpp
@@ -29,7 +29,7 @@
 #include <QTimer>
 
 
-Geometryval::Geometryval(const MltVideoProfile profile, Timecode t, QPoint frame_size, int startPoint, QWidget* parent) :
+Geometryval::Geometryval(const MltVideoProfile &profile, Timecode t, QPoint frame_size, int startPoint, QWidget* parent) :
         QWidget(parent),
         m_profile(profile),
         m_paramRect(NULL),
diff --git a/src/geometryval.h b/src/geometryval.h
index 3bacb18..bccad66 100644
--- a/src/geometryval.h
+++ b/src/geometryval.h
@@ -41,7 +41,7 @@ class Geometryval : public QWidget, public Ui::Geometryval
 {
     Q_OBJECT
 public:
-    explicit Geometryval(const MltVideoProfile profile, Timecode t, QPoint frame_size, int startPoint = 0, QWidget* parent = 0);
+    explicit Geometryval(const MltVideoProfile &profile, Timecode t, QPoint frame_size, int startPoint = 0, QWidget* parent = 0);
     virtual ~Geometryval();
     QDomElement getParamDesc();
     QString getValue() const;
-- 
1.7.5.4

Found by cppcheck.
---
 src/definitions.h |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/definitions.h b/src/definitions.h
index 6b0576b..4384e8c 100644
--- a/src/definitions.h
+++ b/src/definitions.h
@@ -101,14 +101,14 @@ struct MltVideoProfile {
 class EffectParameter
 {
 public:
-    EffectParameter(const QString name, const QString value): m_name(name), m_value(value) {}
+    EffectParameter(const QString &name, const QString &value): m_name(name), m_value(value) {}
     QString name()   const          {
         return m_name;
     }
     QString value() const          {
         return m_value;
     }
-    void setValue(const QString value) {
+    void setValue(const QString &value) {
         m_value = value;
     }
 
@@ -124,12 +124,12 @@ class EffectsParameterList: public QList < EffectParameter >
 {
 public:
     EffectsParameterList(): QList < EffectParameter >() {}
-    bool hasParam(const QString name) const {
+    bool hasParam(const QString &name) const {
         for (int i = 0; i < size(); i++)
             if (at(i).name() == name) return true;
         return false;
     }
-    QString paramValue(const QString name, QString defaultValue = QString()) const {
+    QString paramValue(const QString &name, QString defaultValue = QString()) const {
         for (int i = 0; i < size(); i++) {
             if (at(i).name() == name) return at(i).value();
         }
@@ -139,7 +139,7 @@ public:
         if (name.isEmpty()) return;
         append(EffectParameter(name, value));
     }
-    void removeParam(const QString name) {
+    void removeParam(const QString &name) {
         for (int i = 0; i < size(); i++)
             if (at(i).name() == name) {
                 removeAt(i);
@@ -152,7 +152,7 @@ class CommentedTime
 {
 public:
     CommentedTime(): t(GenTime(0)) {}
-    CommentedTime(const GenTime time, QString comment)
+    CommentedTime(const GenTime &time, QString comment)
         : t(time), c(comment) { }
 
     QString comment()   const          {
-- 
1.7.5.4

Found by cppcheck.
---
 src/databackup/backupwidget.cpp |    4 ++--
 src/databackup/backupwidget.h   |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/databackup/backupwidget.cpp b/src/databackup/backupwidget.cpp
index 64e4a88..c3e4f34 100644
--- a/src/databackup/backupwidget.cpp
+++ b/src/databackup/backupwidget.cpp
@@ -24,7 +24,7 @@
 #include <KUrl>
 
 
-BackupWidget::BackupWidget(KUrl projectUrl, KUrl projectFolder, const QString projectId, QWidget * parent) :
+BackupWidget::BackupWidget(KUrl projectUrl, KUrl projectFolder, const QString &projectId, QWidget * parent) :
         QDialog(parent)
 {
     setupUi(this);
@@ -110,4 +110,4 @@ QString BackupWidget::selectedFile()
 {
     if (!backup_list->currentItem()) return QString();
     return backup_list->currentItem()->data(Qt::UserRole).toString();
-}
\ No newline at end of file
+}
diff --git a/src/databackup/backupwidget.h b/src/databackup/backupwidget.h
index 5878f7b..cb21fd3 100644
--- a/src/databackup/backupwidget.h
+++ b/src/databackup/backupwidget.h
@@ -37,7 +37,7 @@ class BackupWidget : public QDialog, public Ui::BackupDialog_UI
     Q_OBJECT
 
 public:
-    BackupWidget(KUrl projectUrl, KUrl projectFolder, const QString projectId, QWidget * parent = 0);
+    BackupWidget(KUrl projectUrl, KUrl projectFolder, const QString &projectId, QWidget * parent = 0);
     // Constructor for extracting widget
     ~BackupWidget();
     /** @brief Return the path for selected backup file. */
-- 
1.7.5.4

Found by cppcheck.
---
 src/recmonitor.cpp |    4 ++--
 src/recmonitor.h   |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/recmonitor.cpp b/src/recmonitor.cpp
index 41ea650..0ace145 100644
--- a/src/recmonitor.cpp
+++ b/src/recmonitor.cpp
@@ -192,7 +192,7 @@ void RecMonitor::slotConfigure()
     emit showConfigDialog(4, device_selector->currentIndex());
 }
 
-void RecMonitor::slotUpdateCaptureFolder(const QString currentProjectFolder)
+void RecMonitor::slotUpdateCaptureFolder(const QString &currentProjectFolder)
 {
     if (KdenliveSettings::capturetoprojectfolder()) m_capturePath = currentProjectFolder;
     else m_capturePath = KdenliveSettings::capturefolder();
@@ -305,7 +305,7 @@ void RecMonitor::slotSetInfoMessage(const QString &message)
     m_logger.insertItem(0, message);
 }
 
-QPixmap RecMonitor::mergeSideBySide(const QPixmap& pix, const QString txt)
+QPixmap RecMonitor::mergeSideBySide(const QPixmap& pix, const QString &txt)
 {
     QPainter p;
     QRect r = QApplication::fontMetrics().boundingRect(QRect(0, 0, video_frame->width(), video_frame->height()), Qt::AlignLeft, txt);
diff --git a/src/recmonitor.h b/src/recmonitor.h
index d9bd734..12056d7 100644
--- a/src/recmonitor.h
+++ b/src/recmonitor.h
@@ -105,7 +105,7 @@ private:
     VideoPreviewContainer *m_videoBox;
     bool m_analyse;
     void checkDeviceAvailability();
-    QPixmap mergeSideBySide(const QPixmap& pix, const QString txt);
+    QPixmap mergeSideBySide(const QPixmap& pix, const QString &txt);
     void manageCapturedFiles();
     /** @brief Build MLT producer for device, using path as profile. */
     void buildMltDevice(const QString &path);
@@ -133,7 +133,7 @@ public slots:
     void stop();
     void start();
     void slotStopCapture();
-    void slotUpdateCaptureFolder(const QString currentProjectFolder);
+    void slotUpdateCaptureFolder(const QString &currentProjectFolder);
 
 signals:
     void renderPosition(int);
-- 
1.7.5.4

Found by cppcheck.
---
 src/kdenlivedoc.cpp |   14 +++++++-------
 src/kdenlivedoc.h   |   18 +++++++++---------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/kdenlivedoc.cpp b/src/kdenlivedoc.cpp
index f453f70..ef76ad0 100644
--- a/src/kdenlivedoc.cpp
+++ b/src/kdenlivedoc.cpp
@@ -54,7 +54,7 @@
 
 const double DOCUMENTVERSION = 0.87;
 
-KdenliveDoc::KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, QString profileName, QMap <QString, QString> properties, const QPoint tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent, KProgressDialog *progressDialog) :
+KdenliveDoc::KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, QString profileName, QMap <QString, QString> properties, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent, KProgressDialog *progressDialog) :
     QObject(parent),
     m_autosave(NULL),
     m_url(url),
@@ -555,7 +555,7 @@ QPoint KdenliveDoc::zone() const
     return QPoint(m_documentProperties.value("zonein").toInt(), m_documentProperties.value("zoneout").toInt());
 }
 
-QDomDocument KdenliveDoc::xmlSceneList(const QString &scene, const QStringList expandedFolders)
+QDomDocument KdenliveDoc::xmlSceneList(const QString &scene, const QStringList &expandedFolders)
 {
     QDomDocument sceneList;
     sceneList.setContent(scene, true);
@@ -692,7 +692,7 @@ QDomDocument KdenliveDoc::xmlSceneList(const QString &scene, const QStringList e
     return sceneList;
 }
 
-bool KdenliveDoc::saveSceneList(const QString &path, const QString &scene, const QStringList expandedFolders, bool autosave)
+bool KdenliveDoc::saveSceneList(const QString &path, const QString &scene, const QStringList &expandedFolders, bool autosave)
 {
     QDomDocument sceneList = xmlSceneList(scene, expandedFolders);
     if (sceneList.isNull()) {
@@ -896,7 +896,7 @@ Render *KdenliveDoc::renderer()
     return m_render;
 }
 
-void KdenliveDoc::updateClip(const QString id)
+void KdenliveDoc::updateClip(const QString &id)
 {
     emit updateClipDisplay(id);
 }
@@ -1166,7 +1166,7 @@ void KdenliveDoc::deleteClip(const QString &clipId)
     emit signalDeleteProjectClip(clipId);
 }
 
-void KdenliveDoc::slotAddClipList(const KUrl::List urls, const QString group, const QString &groupId)
+void KdenliveDoc::slotAddClipList(const KUrl::List urls, const QString &group, const QString &groupId)
 {
     m_clipManager->slotAddClipList(urls, group, groupId);
     //emit selectLastAddedClip(QString::number(m_clipManager->lastClipId()));
@@ -1174,7 +1174,7 @@ void KdenliveDoc::slotAddClipList(const KUrl::List urls, const QString group, co
 }
 
 
-void KdenliveDoc::slotAddClipFile(const KUrl url, const QString group, const QString &groupId)
+void KdenliveDoc::slotAddClipFile(const KUrl &url, const QString &group, const QString &groupId)
 {
     m_clipManager->slotAddClipFile(url, group, groupId);
     emit selectLastAddedClip(QString::number(m_clipManager->lastClipId()));
@@ -1205,7 +1205,7 @@ void KdenliveDoc::slotCreateColorClip(const QString &name, const QString &color,
     emit selectLastAddedClip(QString::number(m_clipManager->lastClipId()));
 }
 
-void KdenliveDoc::slotCreateSlideshowClipFile(const QString name, const QString path, int count, const QString duration,
+void KdenliveDoc::slotCreateSlideshowClipFile(const QString &name, const QString &path, int count, const QString &duration,
         const bool loop, const bool crop, const bool fade,
         const QString &luma_duration, const QString &luma_file, const int softness,
         const QString &animation, QString group, const QString &groupId)
diff --git a/src/kdenlivedoc.h b/src/kdenlivedoc.h
index 17bbf97..b712a1d 100644
--- a/src/kdenlivedoc.h
+++ b/src/kdenlivedoc.h
@@ -52,7 +52,7 @@ class KdenliveDoc: public QObject
 {
 Q_OBJECT public:
 
-    KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, QString profileName, QMap <QString, QString> properties, const QPoint tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent = 0, KProgressDialog *progressDialog = 0);
+    KdenliveDoc(const KUrl &url, const KUrl &projectFolder, QUndoGroup *undoGroup, QString profileName, QMap <QString, QString> properties, const QPoint &tracks, Render *render, KTextEdit *notes, bool *openBackup, MainWindow *parent = 0, KProgressDialog *progressDialog = 0);
     ~KdenliveDoc();
     QDomNodeList producersList();
     double fps() const;
@@ -83,12 +83,12 @@ Q_OBJECT public:
      *
      * If the clip wasn't added before, it tries to add it to the project. */
     bool addClipInfo(QDomElement elem, QDomElement orig, QString clipId);
-    void slotAddClipFile(const KUrl url, const QString group, const QString &groupId = QString());
-    void slotAddClipList(const KUrl::List urls, const QString group, const QString &groupId = QString());
+    void slotAddClipFile(const KUrl &url, const QString &group, const QString &groupId = QString());
+    void slotAddClipList(const KUrl::List urls, const QString &group, const QString &groupId = QString());
     void deleteClip(const QString &clipId);
     int getFramePos(QString duration);
     DocClipBase *getBaseClip(const QString &clipId);
-    void updateClip(const QString id);
+    void updateClip(const QString &id);
 
     /** @brief Informs Kdenlive of the audio thumbnails generation progress. */
     void setThumbsProgress(const QString &message, int progress);
@@ -113,9 +113,9 @@ Q_OBJECT public:
     double dar() const;
     double projectDuration() const;
     /** @brief Returns the project file xml. */
-    QDomDocument xmlSceneList(const QString &scene, const QStringList expandedFolders);
+    QDomDocument xmlSceneList(const QString &scene, const QStringList &expandedFolders);
     /** @brief Saves the project file xml to a file. */
-    bool saveSceneList(const QString &path, const QString &scene, const QStringList expandedFolders, bool autosave = false);
+    bool saveSceneList(const QString &path, const QString &scene, const QStringList &expandedFolders, bool autosave = false);
     int tracksCount() const;
     TrackInfo trackInfoAt(int ix) const;
     void insertTrack(int ix, TrackInfo type);
@@ -208,8 +208,8 @@ private:
 public slots:
     void slotCreateXmlClip(const QString &name, const QDomElement xml, QString group, const QString &groupId);
     void slotCreateColorClip(const QString &name, const QString &color, const QString &duration, QString group, const QString &groupId);
-    void slotCreateSlideshowClipFile(const QString name, const QString path,
-                                     int count, const QString duration,
+    void slotCreateSlideshowClipFile(const QString &name, const QString &path,
+                                     int count, const QString &duration,
                                      const bool loop, const bool crop,
                                      const bool fade, const QString &luma_duration,
                                      const QString &luma_file, const int softness,
@@ -240,7 +240,7 @@ signals:
     void selectLastAddedClip(const QString &);
     void guidesUpdated();
     /** @brief When creating a backup file, also save a thumbnail of current timeline */
-    void saveTimelinePreview(const QString path);
+    void saveTimelinePreview(const QString &path);
 };
 
 #endif
-- 
1.7.5.4

Found by cppcheck.
---
 src/transition.cpp |    2 +-
 src/transition.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/transition.cpp b/src/transition.cpp
index eefa77b..1c134f6 100644
--- a/src/transition.cpp
+++ b/src/transition.cpp
@@ -31,7 +31,7 @@
 #include <QStyleOptionGraphicsItem>
 
 
-Transition::Transition(const ItemInfo info, int transitiontrack, double fps, QDomElement params, bool automaticTransition) :
+Transition::Transition(const ItemInfo &info, int transitiontrack, double fps, QDomElement params, bool automaticTransition) :
         AbstractClipItem(info, QRectF(), fps),
         m_forceTransitionTrack(false),
         m_automaticTransition(automaticTransition),
diff --git a/src/transition.h b/src/transition.h
index a904d1d..7ffdc6c 100644
--- a/src/transition.h
+++ b/src/transition.h
@@ -41,7 +41,7 @@ class Transition : public AbstractClipItem
     Q_OBJECT
 public:
 
-    Transition(const ItemInfo info, int transitiontrack, double fps, QDomElement params = QDomElement(), bool automaticTransition = false);
+    Transition(const ItemInfo &info, int transitiontrack, double fps, QDomElement params = QDomElement(), bool automaticTransition = false);
     virtual ~Transition();
     virtual void paint(QPainter *painter,
                        const QStyleOptionGraphicsItem *option,
-- 
1.7.5.4

Found by cppcheck.
---
 src/titlewidget.cpp |    2 +-
 src/titlewidget.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/titlewidget.cpp b/src/titlewidget.cpp
index 8ba4eb4..53b7516 100644
--- a/src/titlewidget.cpp
+++ b/src/titlewidget.cpp
@@ -2399,7 +2399,7 @@ void TitleWidget::slotSelectNone()
     selectionChanged();
 }
 
-QString TitleWidget::getTooltipWithShortcut(const QString text, QAction *button)
+QString TitleWidget::getTooltipWithShortcut(const QString &text, QAction *button)
 {
     return text + "  <b>" + button->shortcut().toString() + "</b>";
 }
diff --git a/src/titlewidget.h b/src/titlewidget.h
index 0d9a65d..a589269 100644
--- a/src/titlewidget.h
+++ b/src/titlewidget.h
@@ -224,7 +224,7 @@ private:
     void selectItems(int itemType);
 
     /** @brief Appends the shortcut of a QAction to a tooltip text */
-    QString getTooltipWithShortcut(const QString text, QAction *button);
+    QString getTooltipWithShortcut(const QString& text, QAction *button);
 
 public slots:
     void slotNewText(QGraphicsTextItem *tt);
-- 
1.7.5.4

Found by cppcheck.
---
 src/timecode.cpp |    4 ++--
 src/timecode.h   |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/timecode.cpp b/src/timecode.cpp
index 5e68e0d..89063dd 100644
--- a/src/timecode.cpp
+++ b/src/timecode.cpp
@@ -137,13 +137,13 @@ QString Timecode::reformatSeparators(QString duration) const
     return duration.replace(8, 1, ':');
 }
 
-int Timecode::getDisplayFrameCount(const QString duration, bool frameDisplay) const
+int Timecode::getDisplayFrameCount(const QString &duration, bool frameDisplay) const
 {
     if (frameDisplay) return duration.toInt();
     return getFrameCount(duration);
 }
 
-int Timecode::getFrameCount(const QString duration) const
+int Timecode::getFrameCount(const QString &duration) const
 {
     if (m_dropFrameTimecode) {
 
diff --git a/src/timecode.h b/src/timecode.h
index e1ae7cb..7c2d269 100644
--- a/src/timecode.h
+++ b/src/timecode.h
@@ -50,8 +50,8 @@ public:
     /** Returns the timecode for a given time */
     QString getDisplayTimecode(const GenTime & time, bool frameDisplay) const;
     QString getTimecode(const GenTime & time) const;
-    int getDisplayFrameCount(const QString duration, bool frameDisplay) const;
-    int getFrameCount(const QString duration) const;
+    int getDisplayFrameCount(const QString &duration, bool frameDisplay) const;
+    int getFrameCount(const QString &duration) const;
     static QString getEasyTimecode(const GenTime & time, const double &fps);
     static QString getStringTimecode(int frames, const double &fps);
     const QString getDisplayTimecodeFromFrames(int frames, bool frameDisplay) const;
-- 
1.7.5.4

Found by cppcheck.
---
 src/renderer.cpp |    8 ++++----
 src/renderer.h   |   18 +++++++++---------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/renderer.cpp b/src/renderer.cpp
index 879d676..743e776 100644
--- a/src/renderer.cpp
+++ b/src/renderer.cpp
@@ -176,7 +176,7 @@ void Render::slotSwitchFullscreen()
     if (m_mltConsumer) m_mltConsumer->set("full_screen", 1);
 }
 
-void Render::buildConsumer(const QString profileName)
+void Render::buildConsumer(const QString &profileName)
 {
     delete m_blackClip;
     m_blackClip = NULL;
@@ -553,7 +553,7 @@ void Render::slotSplitView(bool doit)
     }
 }
 
-void Render::getFileProperties(const QDomElement xml, const QString &clipId, int imageHeight, bool replaceProducer, bool selectClip)
+void Render::getFileProperties(const QDomElement &xml, const QString &clipId, int imageHeight, bool replaceProducer, bool selectClip)
 {
     QString path;
     QLocale locale;
@@ -1905,7 +1905,7 @@ bool Render::mltRemoveClip(int track, GenTime position)
     return true;
 }
 
-int Render::mltGetSpaceLength(const GenTime pos, int track, bool fromBlankStart)
+int Render::mltGetSpaceLength(const GenTime &pos, int track, bool fromBlankStart)
 {
     if (!m_mltProducer) {
         kDebug() << "PLAYLIST NOT INITIALISED //////";
@@ -1952,7 +1952,7 @@ int Render::mltTrackDuration(int track)
     return trackProducer.get_playtime() - 1;
 }
 
-void Render::mltInsertSpace(QMap <int, int> trackClipStartList, QMap <int, int> trackTransitionStartList, int track, const GenTime duration, const GenTime timeOffset)
+void Render::mltInsertSpace(QMap <int, int> trackClipStartList, QMap <int, int> trackTransitionStartList, int track, const GenTime &duration, const GenTime &timeOffset)
 {
     if (!m_mltProducer) {
         kDebug() << "PLAYLIST NOT INITIALISED //////";
diff --git a/src/renderer.h b/src/renderer.h
index 7bd25b3..cb2183b 100644
--- a/src/renderer.h
+++ b/src/renderer.h
@@ -84,7 +84,7 @@ Q_OBJECT public:
      *  @param rendererName A unique identifier for this renderer
      *  @param winid The parent widget identifier (required for SDL display). Set to 0 for OpenGL rendering
      *  @param profile The MLT profile used for the renderer (default one will be used if empty). */
-    Render(const QString & rendererName, int winid, QString profile = QString(), QWidget *parent = 0);
+    Render(const QString &rendererName, int winid, QString profile = QString(), QWidget *parent = 0);
 
     /** @brief Destroy the MLT Renderer. */
     virtual ~Render();
@@ -127,7 +127,7 @@ Q_OBJECT public:
 
     /** @brief Stops playing.
      * @param startTime time to seek to */
-    void stop(const GenTime & startTime);
+    void stop(const GenTime &startTime);
     int volume() const;
 
     QImage extractFrame(int frame_position, QString path = QString(), int width = -1, int height = -1);
@@ -170,7 +170,7 @@ Q_OBJECT public:
      * @param profileName The MLT profile name
      * @param dropSceneList If true, the current playlist will be deleted
      * . */
-    int resetProfile(const QString profileName, bool dropSceneList = false);
+    int resetProfile(const QString& profileName, bool dropSceneList = false);
     double fps() const;
 
     /** @brief Returns the width of a frame for this profile. */
@@ -192,8 +192,8 @@ Q_OBJECT public:
     int mltInsertClip(ItemInfo info, QDomElement element, Mlt::Producer *prod, bool overwrite = false, bool push = false);
     bool mltUpdateClip(ItemInfo info, QDomElement element, Mlt::Producer *prod);
     void mltCutClip(int track, GenTime position);
-    void mltInsertSpace(QMap <int, int> trackClipStartList, QMap <int, int> trackTransitionStartList, int track, const GenTime duration, const GenTime timeOffset);
-    int mltGetSpaceLength(const GenTime pos, int track, bool fromBlankStart);
+    void mltInsertSpace(QMap <int, int> trackClipStartList, QMap <int, int> trackTransitionStartList, int track, const GenTime &duration, const GenTime &timeOffset);
+    int mltGetSpaceLength(const GenTime &pos, int track, bool fromBlankStart);
 
     /** @brief Returns the duration/length of @param track as reported by the track producer. */
     int mltTrackDuration(int track);
@@ -316,7 +316,7 @@ private:
 
     /** @brief Build the MLT Consumer object with initial settings.
      *  @param profileName The MLT profile to use for the consumer */
-    void buildConsumer(const QString profileName);
+    void buildConsumer(const QString& profileName);
     void resetZoneMode();
     void fillSlowMotionProducers();
     /** @brief Get the track number of the lowest audible (non muted) audio track
@@ -366,13 +366,13 @@ signals:
     void refreshDocumentProducers(bool displayRatioChanged, bool fpsChanged);
     
     /** @brief If we will delete the producer, make sure to pause the monitor */
-    void blockClipMonitor(const QString);
+    void blockClipMonitor(const QString &);
 
     /** @brief A frame's image has to be shown.
      *
      * Used in Mac OS X. */
     void showImageSignal(QImage);
-    void showAudioSignal(const QByteArray);
+    void showAudioSignal(const QByteArray &);
 
 public slots:
 
@@ -394,7 +394,7 @@ public slots:
         @param selectClip If true, clip item will be selected in project view
      * Upon return, the result will be emitted via replyGetFileProperties().
      * Wraps the VEML command of the same name. */
-    void getFileProperties(const QDomElement xml, const QString &clipId, int imageHeight, bool replaceProducer = true, bool selectClip = false);
+    void getFileProperties(const QDomElement &xml, const QString &clipId, int imageHeight, bool replaceProducer = true, bool selectClip = false);
 
     void exportFileToFirewire(QString srcFileName, int port, GenTime startTime, GenTime endTime);
     void mltSavePlaylist();
-- 
1.7.5.4

Found by cppcheck.
---
 src/monitor.cpp  |    2 +-
 src/monitor.h    |    2 +-
 src/renderer.cpp |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/monitor.cpp b/src/monitor.cpp
index 54c708b..d800b62 100644
--- a/src/monitor.cpp
+++ b/src/monitor.cpp
@@ -857,7 +857,7 @@ void Monitor::slotSaveZone()
     //render->setSceneList(doc, 0);
 }
 
-void Monitor::resetProfile(const QString profile)
+void Monitor::resetProfile(const QString &profile)
 {
     m_timePos->updateTimeCode(m_monitorManager->timecode());
     if (render == NULL) return;
diff --git a/src/monitor.h b/src/monitor.h
index 2359e74..13f107a 100644
--- a/src/monitor.h
+++ b/src/monitor.h
@@ -114,7 +114,7 @@ public:
     ~Monitor();
     Render *render;
     AbstractRender *abstractRender();
-    void resetProfile(const QString profile);
+    void resetProfile(const QString &profile);
     const QString name() const;
     void resetSize();
     bool isActive() const;
diff --git a/src/renderer.cpp b/src/renderer.cpp
index 2142f93..879d676 100644
--- a/src/renderer.cpp
+++ b/src/renderer.cpp
@@ -291,7 +291,7 @@ Mlt::Producer *Render::invalidProducer(const QString &id)
     return clip;
 }
 
-int Render::resetProfile(const QString profileName, bool dropSceneList)
+int Render::resetProfile(const QString &profileName, bool dropSceneList)
 {
     QString scene;
     if (!dropSceneList) scene = sceneList();
-- 
1.7.5.4

Found by cppcheck.
---
 src/monitormanager.cpp |    2 +-
 src/monitormanager.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/monitormanager.cpp b/src/monitormanager.cpp
index 9bf6ce4..662748e 100644
--- a/src/monitormanager.cpp
+++ b/src/monitormanager.cpp
@@ -81,7 +81,7 @@ void MonitorManager::activateMonitor(QString name)
     emit checkColorScopes();
 }
 
-bool MonitorManager::isActive(const QString name) const
+bool MonitorManager::isActive(const QString &name) const
 {
     return m_activeMonitor ? m_activeMonitor->name() == name: false;
 }
diff --git a/src/monitormanager.h b/src/monitormanager.h
index 171ad0b..30e1864 100644
--- a/src/monitormanager.h
+++ b/src/monitormanager.h
@@ -47,7 +47,7 @@ public slots:
     /** @brief Activates a monitor.
      * @param name name of the monitor to activate */
     void activateMonitor(QString name = QString());
-    bool isActive(const QString name) const;
+    bool isActive(const QString &name) const;
     void slotPlay();
     void slotPause();
     void slotPlayZone();
-- 
1.7.5.4

Found by cppcheck.
---
 src/mltdevicecapture.cpp |    2 +-
 src/mltdevicecapture.h   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mltdevicecapture.cpp b/src/mltdevicecapture.cpp
index 7998aa2..a60f34a 100644
--- a/src/mltdevicecapture.cpp
+++ b/src/mltdevicecapture.cpp
@@ -504,7 +504,7 @@ void MltDeviceCapture::setOverlay(const QString &path)
     //delete clip;
 }
 
-void MltDeviceCapture::setOverlayEffect(const QString tag, QStringList parameters)
+void MltDeviceCapture::setOverlayEffect(const QString &tag, QStringList parameters)
 {
     if (m_mltProducer == NULL || !m_mltProducer->is_valid()) return;
     Mlt::Service service(m_mltProducer->parent().get_service());
diff --git a/src/mltdevicecapture.h b/src/mltdevicecapture.h
index 30d695c..7ba44c2 100644
--- a/src/mltdevicecapture.h
+++ b/src/mltdevicecapture.h
@@ -89,7 +89,7 @@ Q_OBJECT public:
     void setOverlay(const QString &path);
 
     /** @brief This will add an MLT video effect to the overlay track. */
-    void setOverlayEffect(const QString tag, QStringList parameters);
+    void setOverlayEffect(const QString &tag, QStringList parameters);
 
     /** @brief This will add a horizontal flip effect, easier to work when filming yourself. */
     void mirror(bool activate);
-- 
1.7.5.4

Found by cppcheck.
---
 src/mainwindow.cpp              |    2 +-
 src/mltdevicecapture.h          |    2 +-
 src/stopmotion/capturehandler.h |    2 +-
 src/stopmotion/stopmotion.cpp   |   10 +++++-----
 src/stopmotion/stopmotion.h     |    6 +++---
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index ae32c9b..016a904 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@@ -4302,7 +4302,7 @@ void MainWindow::slotOpenStopmotion()
 {
     if (m_stopmotion == NULL) {
         m_stopmotion = new StopmotionWidget(m_monitorManager, m_activeDocument->projectFolder(), m_stopmotion_actions->actions(), this);
-        connect(m_stopmotion, SIGNAL(addOrUpdateSequence(const QString)), m_projectList, SLOT(slotAddOrUpdateSequence(const QString)));
+        connect(m_stopmotion, SIGNAL(addOrUpdateSequence(const QString &)), m_projectList, SLOT(slotAddOrUpdateSequence(const QString)));
         //for (int i = 0; i < m_gfxScopesList.count(); i++) {
             // Check if we need the renderer to send a new frame for update
             /*if (!m_scopesList.at(i)->widget()->visibleRegion().isEmpty() && !(static_cast<AbstractScopeWidget *>(m_scopesList.at(i)->widget())->autoRefreshEnabled())) request = true;*/
diff --git a/src/mltdevicecapture.h b/src/mltdevicecapture.h
index 9603326..30d695c 100644
--- a/src/mltdevicecapture.h
+++ b/src/mltdevicecapture.h
@@ -139,7 +139,7 @@ signals:
     /** @brief This signal contains the audio of the current frame. */
     void audioSamplesSignal(const QVector<int16_t>&, int freq, int num_channels, int num_samples);
 
-    void frameSaved(const QString);
+    void frameSaved(const QString &);
     
     void droppedFrames(int);
     
diff --git a/src/stopmotion/capturehandler.h b/src/stopmotion/capturehandler.h
index 9e1e350..b2ea249 100644
--- a/src/stopmotion/capturehandler.h
+++ b/src/stopmotion/capturehandler.h
@@ -52,7 +52,7 @@ protected:
 signals:
     void gotTimeCode(ulong);
     void gotMessage(const QString &);
-    void frameSaved(const QString);
+    void frameSaved(const QString &);
     void gotFrame(QImage);
 };
 
diff --git a/src/stopmotion/stopmotion.cpp b/src/stopmotion/stopmotion.cpp
index a018fe7..f76f9c2 100644
--- a/src/stopmotion/stopmotion.cpp
+++ b/src/stopmotion/stopmotion.cpp
@@ -276,7 +276,7 @@ StopmotionWidget::StopmotionWidget(MonitorManager *manager, KUrl projectFolder,
 
     connect(capture_device, SIGNAL(currentIndexChanged(int)), this, SLOT(slotUpdateDeviceHandler()));
     /*if (m_bmCapture) {
-        connect(m_bmCapture, SIGNAL(frameSaved(const QString)), this, SLOT(slotNewThumb(const QString)));
+        connect(m_bmCapture, SIGNAL(frameSaved(const QString &)), this, SLOT(slotNewThumb(const QString &)));
         connect(m_bmCapture, SIGNAL(gotFrame(QImage)), this, SIGNAL(gotFrame(QImage)));
     } else live_button->setEnabled(false);*/
 
@@ -303,7 +303,7 @@ StopmotionWidget::StopmotionWidget(MonitorManager *manager, KUrl projectFolder,
     m_captureDevice = new MltDeviceCapture(profilePath, m_videoBox, this);
     m_captureDevice->sendFrameForAnalysis = KdenliveSettings::analyse_stopmotion();
     m_monitor->setRender(m_captureDevice);
-    connect(m_captureDevice, SIGNAL(frameSaved(const QString)), this, SLOT(slotNewThumb(const QString)));
+    connect(m_captureDevice, SIGNAL(frameSaved(const QString &)), this, SLOT(slotNewThumb(const QString &)));
 
     live_button->setChecked(false);
     button_addsequence->setEnabled(false);
@@ -488,7 +488,7 @@ void StopmotionWidget::slotLive(bool isOn)
             m_captureDevice = new MltDeviceCapture(profilePath, m_videoBox, this);
             m_captureDevice->sendFrameForAnalysis = KdenliveSettings::analyse_stopmotion();
             m_monitor->setRender(m_captureDevice);
-            connect(m_captureDevice, SIGNAL(frameSaved(const QString)), this, SLOT(slotNewThumb(const QString)));
+            connect(m_captureDevice, SIGNAL(frameSaved(const QString &)), this, SLOT(slotNewThumb(const QString &)));
         }
 
         m_manager->activateMonitor("stopmotion");
@@ -664,7 +664,7 @@ void StopmotionWidget::slotPreNotify()
 }
 
 
-void StopmotionWidget::slotNewThumb(const QString path)
+void StopmotionWidget::slotNewThumb(const QString &path)
 {
     if (!KdenliveSettings::showstopmotionthumbs()) return;
     m_filesList.append(path);
@@ -883,7 +883,7 @@ void StopmotionWidget::slotSwitchMirror(bool isOn)
     if (m_captureDevice) m_captureDevice->mirror(isOn);
 }
 
-const QString StopmotionWidget::createProducer(MltVideoProfile profile, const QString service, const QString resource)
+const QString StopmotionWidget::createProducer(MltVideoProfile profile, const QString &service, const QString &resource)
 {
     Q_UNUSED(profile)
 
diff --git a/src/stopmotion/stopmotion.h b/src/stopmotion/stopmotion.h
index 1ddb4c5..3e11527 100644
--- a/src/stopmotion/stopmotion.h
+++ b/src/stopmotion/stopmotion.h
@@ -152,7 +152,7 @@ private:
     StopmotionMonitor *m_monitor;
 
     /** @brief Create the XML playlist. */
-    const QString createProducer(MltVideoProfile profile, const QString service, const QString resource);
+    const QString createProducer(MltVideoProfile profile, const QString &service, const QString &resource);
 
     /** @brief A new frame arrived, reload overlay. */
     void reloadOverlay();
@@ -225,7 +225,7 @@ private slots:
     void slotConfigure();
 
     /** @brief Prepare to crete thumb for newly captured frame. */
-    void slotNewThumb(const QString path);
+    void slotNewThumb(const QString &path);
 
     /** @brief Set the effect to be applied to overlay frame. */
     void slotUpdateOverlayEffect(QAction* act);
@@ -247,7 +247,7 @@ private slots:
 
 signals:
     /** @brief Ask to add sequence to current project. */
-    void addOrUpdateSequence(const QString);
+    void addOrUpdateSequence(const QString &);
 
     void doCreateThumbs(QImage, int);
     void gotFrame(QImage);
-- 
1.7.5.4

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/28/2011 12:24 PM, Mikko Rapeli wrote:
> While waiting for proxy clips to be generated, I decided to run 
> cppcheck on kdenlive and fix most of the issues found. I used 
> cppcheck version

Thanks a lot!
jbm applied all your patches in the meantime.

> 1.49-1 available on Debian unstable.
> 
> Patches were created in one bunch but I tried to separate them in 
> git so that each change would still compile. I have not tested
> this though.
> 
> As for testing, I have used these patches to preview and do small 
> changes in a few old projects I have. I will run these while 
> editing a bigger project from now on. Obviously I'm biased but 
> kdenlive seems a bit snappier with these patches.
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk508qUACgkQzwEyz7QP6nSoqACbBfIYr4Kyhrcabxla/SQscWn6
ZfAAn3QRa3CUBZ8RTKdQOG1k8TuobPdp
=jTOu
-----END PGP SIGNATURE-----

On Sat, Sep 17, 2011 at 09:19:39PM +0200, Till Theato wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 08/28/2011 12:24 PM, Mikko Rapeli wrote:
> > While waiting for proxy clips to be generated, I decided to run 
> > cppcheck on kdenlive and fix most of the issues found. I used 
> > cppcheck version
> 
> Thanks a lot!
> jbm applied all your patches in the meantime.

You're welcome. I noticed them in git a few days back.

Has anyone run valgrind with mlt and kdenlive?

I noticed a ton of Qt related complains and a number of other items
with leackcheck but most of the complains don't come from kdenlive directly.
My first test case was just to start kdenlive without a project.

-Mikko

On Sat, Sep 17, 2011 at 1:49 PM, Mikko Rapeli <mikko.rapeli@...> wrote:
> On Sat, Sep 17, 2011 at 09:19:39PM +0200, Till Theato wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 08/28/2011 12:24 PM, Mikko Rapeli wrote:
>> > While waiting for proxy clips to be generated, I decided to run
>> > cppcheck on kdenlive and fix most of the issues found. I used
>> > cppcheck version
>>
>> Thanks a lot!
>> jbm applied all your patches in the meantime.
>
> You're welcome. I noticed them in git a few days back.
>
> Has anyone run valgrind with mlt and kdenlive?
>
> I noticed a ton of Qt related complains and a number of other items
> with leackcheck but most of the complains don't come from kdenlive directly.
> My first test case was just to start kdenlive without a project.

I do occasionally with mlt. A number of things seem to occur with
dependencies and dlopen and related. For example, with swfdec, if it
is built against gstreamer, seems to generate a lot of complaints. I
made suppressions for things related to dlerror_run or things I
struggled to track down due to lack of symbols and that trace back to
mlt_factory_init (something that seems to occur once just due to
loading a plugin). However, coverage is another issue. I do not
usually have much time to create tests to exercise various code paths.

-- 
+-DRD-+

On Sat, Sep 17, 2011 at 07:25:56PM -0700, Dan Dennedy wrote:
> On Sat, Sep 17, 2011 at 1:49 PM, Mikko Rapeli <mikko.rapeli@...> wrote:
> > On Sat, Sep 17, 2011 at 09:19:39PM +0200, Till Theato wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> On 08/28/2011 12:24 PM, Mikko Rapeli wrote:
> >> > While waiting for proxy clips to be generated, I decided to run
> >> > cppcheck on kdenlive and fix most of the issues found. I used
> >> > cppcheck version
> >>
> >> Thanks a lot!
> >> jbm applied all your patches in the meantime.
> >
> > You're welcome. I noticed them in git a few days back.
> >
> > Has anyone run valgrind with mlt and kdenlive?
> >
> > I noticed a ton of Qt related complains and a number of other items
> > with leackcheck but most of the complains don't come from kdenlive directly.
> > My first test case was just to start kdenlive without a project.
> 
> I do occasionally with mlt. A number of things seem to occur with
> dependencies and dlopen and related. For example, with swfdec, if it
> is built against gstreamer, seems to generate a lot of complaints. I
> made suppressions for things related to dlerror_run or things I
> struggled to track down due to lack of symbols and that trace back to
> mlt_factory_init (something that seems to occur once just due to
> loading a plugin). However, coverage is another issue. I do not
> usually have much time to create tests to exercise various code paths.

Ok, I will try to run it while rendering one of my projects too.

Btw, one of the findings which puzle me is this:

==9377== Invalid read of size 4
==9377==    at 0x4059AB4: mlt_properties_parse_yaml (mlt_properties.c:1611)
==9377==    by 0x20201F: ???
==9377==  Address 0xcaa34a8 is 48 bytes inside a block of size 51 alloc'd
==9377==    at 0x4023796: calloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-li
nux.so)
==9377==    by 0x4059A8B: mlt_properties_parse_yaml (mlt_properties.c:1609)
==9377==    by 0x20201F: ???

Where code is:

1606                // Blank line (prepended with spaces) is new line
1607                if ( strcmp( name, "" ) == 0 )
1608                {
1609                        value = calloc( 1, strlen( old_value ) + 2 );
1610                        strcat( value, old_value );
1611                        strcat( value, "\n" );
1612                }

To me this looks correct, but valgrind is constantly complaining about it.

-Mikko

On Sun, Sep 18, 2011 at 8:51 AM, Mikko Rapeli <mikko.rapeli@...> wrote:

> On Sat, Sep 17, 2011 at 07:25:56PM -0700, Dan Dennedy wrote:
> > On Sat, Sep 17, 2011 at 1:49 PM, Mikko Rapeli <mikko.rapeli@...>
> wrote:
> > > On Sat, Sep 17, 2011 at 09:19:39PM +0200, Till Theato wrote:
> > >> -----BEGIN PGP SIGNED MESSAGE-----
> > >> Hash: SHA1
> > >>
> > >> On 08/28/2011 12:24 PM, Mikko Rapeli wrote:
> > >> > While waiting for proxy clips to be generated, I decided to run
> > >> > cppcheck on kdenlive and fix most of the issues found. I used
> > >> > cppcheck version
> > >>
> > >> Thanks a lot!
> > >> jbm applied all your patches in the meantime.
> > >
> > > You're welcome. I noticed them in git a few days back.
> > >
> > > Has anyone run valgrind with mlt and kdenlive?
> > >
> > > I noticed a ton of Qt related complains and a number of other items
> > > with leackcheck but most of the complains don't come from kdenlive
> directly.
> > > My first test case was just to start kdenlive without a project.
> >
> > I do occasionally with mlt. A number of things seem to occur with
> > dependencies and dlopen and related. For example, with swfdec, if it
> > is built against gstreamer, seems to generate a lot of complaints. I
> > made suppressions for things related to dlerror_run or things I
> > struggled to track down due to lack of symbols and that trace back to
> > mlt_factory_init (something that seems to occur once just due to
> > loading a plugin). However, coverage is another issue. I do not
> > usually have much time to create tests to exercise various code paths.
>
> Ok, I will try to run it while rendering one of my projects too.
>
> Btw, one of the findings which puzle me is this:
>
> ==9377== Invalid read of size 4
> ==9377==    at 0x4059AB4: mlt_properties_parse_yaml (mlt_properties.c:1611)
> ==9377==    by 0x20201F: ???
> ==9377==  Address 0xcaa34a8 is 48 bytes inside a block of size 51 alloc'd
> ==9377==    at 0x4023796: calloc (in
> /usr/lib/valgrind/vgpreload_memcheck-x86-li
> nux.so)
> ==9377==    by 0x4059A8B: mlt_properties_parse_yaml (mlt_properties.c:1609)
> ==9377==    by 0x20201F: ???
>
> Where code is:
>
> 1606                // Blank line (prepended with spaces) is new line
> 1607                if ( strcmp( name, "" ) == 0 )
> 1608                {
> 1609                        value = calloc( 1, strlen( old_value ) + 2 );
> 1610                        strcat( value, old_value );
> 1611                        strcat( value, "\n" );
> 1612                }
>
> To me this looks correct, but valgrind is constantly complaining about it.
>
>
Not so surprising if the implementation is this:
http://www.student.cs.uwaterloo.ca/~cs350/common/os161-src-html/strcat_8c-source.html
It uses pointer arithmetic, and hence copies stuff into a pointer that is
exactly 2 bytes less that you have calloc'd, that matches the length of the
input in your case. I thought that valgrind had a list of "known to work
fine issues it should not report" (= suppression lists), and the same should
apply for Qt.

You could create a suppression list for stuff you known you won't fix by
using the simple steps here:
http://wiki.wxwidgets.org/Valgrind_Suppression_File_Howto

--paf


> -Mikko
>
>
> ------------------------------------------------------------------------------
> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> http://p.sf.net/sfu/rim-devcon-copy2
> _______________________________________________
> Kdenlive-devel mailing list
> Kdenlive-devel@...
> https://lists.sourceforge.net/lists/listinfo/kdenlive-devel
>