TortoiseHg

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

Steve Borho / sborho on Tue, 24 May 2011 21:24:13 +0200:

Changes:
  status: new -> open

--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

André Sintzoff / sintzoff on Tue, 24 May 2011 23:03:02 +0200:

Comment:
  The issue seems related to a Qt issue.

Depending on the Qt version, the issue occurs or not.

At least Qt versions 4.6.3 (on Debian) and 4.7 (on Mac OS X) fail. Qt version 4.7.2 (on Ubuntu) does not fail.

For Qt 4.7, I have found a workaround in hgignore.py but I don't understand why it works.

{{{
@@ -204,7 +204,8 @@
             self.refresh()
 
     def addEntry(self):
-        newfilter = hglib.fromunicode(self.le.text()).strip()
+        utext = hglib.fromunicode(self.le.text())
+        newfilter = utext.strip()
         if newfilter == '':
             return
         if self.recombo.currentIndex() == 0:
}}}



--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

André Sintzoff / sintzoff on Wed, 25 May 2011 08:32:26 +0200:

Comment:
  Could you provide more information on your configuration? Mainly, could you paste the content of the TortoiseHg About window?


--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

_dedalus_ on Wed, 25 May 2011 08:37:08 +0200:

Comment:
  TortoiseHg
version 2.0.4
with Mercurial-1.8.3, Python-2.6.6, PyQt-4.8.3, Qt-4.7.1

--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

André Sintzoff / sintzoff on Wed, 25 May 2011 13:48:54 +0200:

Comment:
  I just did some additional tests. They are absolutely not conclusive...
Mainly, we can forget my first comment.

Depending on the number and the "position" of selected files before using "Ignore" context menu, I can add some or all files in the "Ignore filter" window.

When selecting only one untracked file in the workbench, I'm able to add all untracked files in the "Ignore filter" window.
 

--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

Steve Borho / sborho on Wed, 25 May 2011 17:19:58 +0200:

Comment:
  Sounds like a crazy Python scoping bug

--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

Phil Currier / pcurrier on Wed, 25 May 2011 17:51:58 +0200:

Comment:
  I'm probably missing something, but I think it's just a matter of repopulating the line edit box.  The attached patch seems to fix the OP's complaint -- is there something else going on here?

Added attachment: thg_11820.patch

--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

Steve Borho / sborho on Fri, 27 May 2011 05:17:01 +0200:

Comment:
  ignore: clear line edit box before refresh (closes #738)

→ <<cset 38bd971853d1>>

Changes:
  status: open -> resolved

--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.

--- you can reply above this line ---

Issue 738: Trivial issue on adding files on ignore window
https://bitbucket.org/tortoisehg/thg/issue/738/trivial-issue-on-adding-files-on-ignore

Steve Borho / sborho on Fri, 27 May 2011 05:17:02 +0200:

Comment:
  ignore: repopulate line edit box after refresh (closes #738)

→ <<cset e84c18ab34e8>>

--

This is an issue notification from bitbucket.org. You are receiving
this either because you are the owner of the issue, or you are
following the issue.