Codestriker: collaborative code reviewer

On Monday 08 October 2007 10:18, David Sitsky wrote:
> Just curious - what version of svn are you using?
I don't have physical access to it, but the admin tells me 1.4.4.

> This is happening in the code when Codestriker is trying to determine
> if what you have passed in is either a file or a directory.  I take it
> your repository was set to something like:
>
> svn:http://svn.openchange.org/openchange/trunk
=46rom codestriker.conf:
     'svn:https://svn.openchange.org/openchange/trunk',
(I previously used http, but https seems better).

> And you provided a start_tag of 268, and end_tag of 272 and a module of
> libmapi?
yep.

> Can you execute the following command?
>
> "/usr/bin/svn" "info" "--non-interactive" "--no-auth-cache" --xml
> "http://svn.openchange.org/openchange/trunk/libmapi"
[bradh@... ~]$ "/usr/bin/svn" "info" "--non-interactive"=20
"--no-auth-cache" --xml "http://svn.openchange.org/openchange/trunk/libmapi"
<?xml version=3D"1.0"?>
<info>
svn: PROPFIND request failed on '/openchange/trunk/libmapi'
svn: PROPFIND of '/openchange/trunk/libmapi': 405 Method Not Allowed=20
(http://svn.openchange.org)

That didn't look too good. So I tried with https, instead of http:

[bradh@... ~]$ "/usr/bin/svn" "info" "--non-interactive"=20
"--no-auth-cache" --xml "https://svn.openchange.org/openchange/trunk/libmap=
i"
<?xml version=3D"1.0"?>
<info>
<entry
   kind=3D"dir"
   path=3D"libmapi"
   revision=3D"272">
<url>https://svn.openchange.org/openchange/trunk/libmapi</url>
<repository>
<root>https://svn.openchange.org/openchange</root>
<uuid>71d39326-ef09-db11-b2a4-00e04c779ad1</uuid>
</repository>
<commit
   revision=3D"272">
<author>jkerihuel</author>
<date>2007-10-05T06:10:29.999496Z</date>
</commit>
</entry>
</info>

> Codestriker should have tried executing this first - but if this
> fails, that is possible because you are running svn 1.2 or earlier.
I'm happy to do tests, but if it would be faster/easier, note that the serv=
er=20
is public.

Brad

On Tuesday 09 October 2007 20:19, David Sitsky wrote:
> An even easier solution, make your repository string:
>
> 'svn://svn.openchange.org/openchange/trunk'
That is great. Trying to run svn as the apache user didn't really work out,=
=20
because it is such a limited account.

I'm now able to pull down recent patches.  I still get ugly failures if I=20
leave out one of the revs, or I ask for a module that didn't exist at the=20
start rev.

Also, I'd like to be able to do a review of a whole file (or possibly=20
directory) from svn. Is the only way to do this to download it and upload i=
t=20
again?

Brad

On Tuesday 09 October 2007 22:05, David Sitsky wrote:
> > Also, I'd like to be able to do a review of a whole file (or possibly
> > directory) from svn. Is the only way to do this to download it and uplo=
ad
> > it again?
>
> Can't you use a start_tag of 1 and the current revision as the end tag
> for this purpose?  I haven't tried it myself, so I am just guessing.
Tried that, but it doesn't work if the directory didn't exist at rev 1. It=
=20
results in this:
Software error:

Command failed: Failed to execute "/usr/bin/svn" "diff" "--non-interactive"=
=20
"--no-auth-cache" "-r" "1:270" "--old"=20
"svn://svn.openchange.org/openchange/trunk" "libmapi" >=20
"/tmp/tjk4ZSbJUo/stdout.txt" 2> "/tmp/tjk4ZSbJUo/stderr.txt":=20
=20
at /var/www/codestriker/codestriker-1.9.4/bin/../lib/Codestriker/Repository=
/Subversion.pm=20
line 207

/usr/bin/svn diff --non-interactive --no-auth-cache -r 1:270 --old=20
svn://svn.openchange.org/openchange/trunk libmapi
Check your webserver error log for more information.
=20
at /var/www/codestriker/codestriker-1.9.4/bin/../lib/Codestriker/Repository=
/Subversion.pm=20
line 207

=46or help, please send mail to the webmaster (root@...), giving this=
=20
error message and the time and date of the error.=20

 - -=20

Uploading a file isn't that big a deal.

Brad