Music Player Daemon

On Sun, Apr 17, 2011 at 2:35 PM, David Schneider <dnschneid@...> wrote:
> At least on Ubuntu, libgme doesn't seem to have any autoconf package
> metadata, so automatic detection fails.
> This patch changes configure.ac to check for it the "other" way.

I use the latest svn of libgme:
http://code.google.com/p/game-music-emu/downloads/detail?name=game-music-emu-0.5.5.tbz2&can=2&q=

and it installs a .pc file fine. I was unaware that there was an
ubuntu package for this library. Why not send the maintainers of the
ubuntu package a patch that includes the .pc file instead?

Yeah, I don't know why it's not part of the package.
https://bugs.launchpad.net/ubuntu/+source/game-music-emu/+bug/641892
But as nothing seems to be being done, I'd figure a small, non-obtrusive
tweak to MPD's configure wouldn't hurt anything, and would make the
experience nicer for people who want the features.

---------- Sun, 17 Apr 2011 16:54:38 -0700 ----------
Tony Miller <mcfiredrill@...> wrote:

> I use the latest svn of libgme:
> http://code.google.com/p/game-music-emu/downloads/detail?name=game-music-emu-0.5.5.tbz2&can=2&q=
> 
> and it installs a .pc file fine. I was unaware that there was an
> ubuntu package for this library. Why not send them a patch that
> includes the .pc file instead?
> 
> On Sun, Apr 17, 2011 at 2:35 PM, David Schneider <dnschneid@...> wrote:
> > At least on Ubuntu, libgme doesn't seem to have any autoconf package
> > metadata, so automatic detection fails.
> > This patch changes configure.ac to check for it the "other" way.
> > ------------------------------------------------------------------------------
> > Benefiting from Server Virtualization: Beyond Initial Workload
> > Consolidation -- Increasing the use of server virtualization is a top
> > priority.Virtualization can reduce costs, simplify management, and improve
> > application availability and disaster protection. Learn more about boosting
> > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> > _______________________________________________
> > Musicpd-dev-team mailing list
> > Musicpd-dev-team@...
> > https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
> >
> >

On 2011/04/19 02:19, David Schneider <dnschneid@...> wrote:
> Yeah, I don't know why it's not part of the package.
> https://bugs.launchpad.net/ubuntu/+source/game-music-emu/+bug/641892
> But as nothing seems to be being done, I'd figure a small, non-obtrusive
> tweak to MPD's configure wouldn't hurt anything, and would make the
> experience nicer for people who want the features.

Oh yes, it would hurt.  Your patch removes the pkg-config detection
completely.  Since you can override the pkg-config detection, there is
no reason for this regression.  MPD will not compensate for
distribution bugs if it means a disadvantage for users with sane
distributions.

Max Kellermann <max@...> wrote:

> On 2011/04/19 02:19, David Schneider <dnschneid@...> wrote:
> > Yeah, I don't know why it's not part of the package.
> > https://bugs.launchpad.net/ubuntu/+source/game-music-emu/+bug/641892
> > But as nothing seems to be being done, I'd figure a small, non-obtrusive
> > tweak to MPD's configure wouldn't hurt anything, and would make the
> > experience nicer for people who want the features.
> 
> Oh yes, it would hurt.  Your patch removes the pkg-config detection
> completely.  Since you can override the pkg-config detection, there is
> no reason for this regression.  MPD will not compensate for
> distribution bugs if it means a disadvantage for users with sane
> distributions.

I'm not very familiar with autoconfig, but I thought the change I made would
still properly detect whether or not libgme was usable on both sane and buggy
distros.  Evidently I didn't succeed in that regard.
Sorry for wasting your time.

On 2011/05/09 07:55, David Schneider <dnschneid@...> wrote:
> I thought the change I made would still properly detect whether or
> not libgme was usable on both sane and buggy distros.  Evidently I
> didn't succeed in that regard.

Users with pkg-config properly set up may not be able to automatically
detect libgme anymore, if their pkg-config files contain non-standard
flags (such as non-standard library paths).

Max Kellermann <max@...> wrote:

> On 2011/05/09 07:55, David Schneider <dnschneid@...> wrote:
> > I thought the change I made would still properly detect whether or
> > not libgme was usable on both sane and buggy distros.  Evidently I
> > didn't succeed in that regard.
> 
> Users with pkg-config properly set up may not be able to automatically
> detect libgme anymore, if their pkg-config files contain non-standard
> flags (such as non-standard library paths).

That makes sense; I wasn't aware that users did that.
Thanks for clarifying things!