libMesh: A C++ Finite Element Library

On Tue, Mar 1, 2011 at 4:14 PM, David Andrs <David.Andrs@...> wrote:
>
> Hi!
>
> Attached patch is improving 2 things in PETSc vector:
> 1) improving the detection of PETSc vector type in a copy c-tor (current
> check was ok for parallel runs, but not for serial runs)
> 2) enabling the assignment of parallel vector into ghosted vector
>
> Please review and check in, if ok.

We fixed the strcmp bug in this version of the patch, I will check it in today.

-- 
John

On Tue, 1 Mar 2011, David Andrs wrote:

> Attached patch is improving 2 things in PETSc vector:
> 1) improving the detection of PETSc vector type in a copy c-tor (current check was ok for parallel runs, but not for serial runs)
> 2) enabling the assignment of parallel vector into ghosted vector
> 
> Please review and check in, if ok.

John, the operative words there were "if ok".  ;-)

I've fixed it so that the VecGetType call matches the PETSc docs I
found online and no longer fails to compile against my petsc/3.1p5
installation; you guys might want to double-check and make sure it
still works with whatever version you're using.
---
Roy

On Wed, Mar 2, 2011 at 10:24 AM, Roy Stogner <roystgnr@...> wrote:
>
> On Tue, 1 Mar 2011, David Andrs wrote:
>
>> Attached patch is improving 2 things in PETSc vector:
>> 1) improving the detection of PETSc vector type in a copy c-tor (current
>> check was ok for parallel runs, but not for serial runs)
>> 2) enabling the assignment of parallel vector into ghosted vector
>>
>> Please review and check in, if ok.
>
> John, the operative words there were "if ok".  ;-)
>
> I've fixed it so that the VecGetType call matches the PETSc docs I
> found online and no longer fails to compile against my petsc/3.1p5
> installation; you guys might want to double-check and make sure it
> still works with whatever version you're using.

Roy,

Can you try it again with Petsc 3 just to be sure?  Sorry for the inconvenience.

-- 
John

On Wed, 2 Mar 2011, John Peterson wrote:

> Can you try it again with Petsc 3 just to be sure?  Sorry for the inconvenience.

Still works fine here, thanks.
---
Roy

>> Can you try it again with Petsc 3 just to be sure?  Sorry for the
>> inconvenience.
> 
> Still works fine here, thanks.

Works for me with PETSC 3.0 and 3.1.

Sure looks weird having to put a const in there so you can pass its address
:-P