On Fri, 3 May 2002, Sebastian John wrote:
> - speedwalk.py should use self._regexp.match(), not self._regexp.search() -
> would be slightly faster i think, and a bit cleaner.
Done.
> - included is a patch to the testserver, allowing to append new commands
> faster.
I think you missed the attachment. I'm not sure how you would append new
commands faster since I've got it doing it in one line.
> - in modules/basic.py, textin_cmd(), the code tries to fetch
> 'args["filename"]', but in the command_dict the entry is only "file", so
> an exception is thrown by python.
Done.
> - in speedwalk.py you should change 'swdirs.append(self._dirs[dir])' +
> 'return "\n".join(swdirs)' with 'swdirs.append(self._dirs[dir] + "\n")' +
> 'return "".join(swdirs)', because currently it doesn't send a trailing
> newline char, the last command won't be executed.
Are you sure? It works fine for me right now. I double-checked even that
all the commands I was feeding the speedwalking stuff were getting
executed. I know that if I implement this fix we'll be sending two \n's
to the mud.
/will
--
whatever it is, you can find it at http://www.bluesock.org/~willg/
except Will--you can only see him in real life.
|