Universal JTAG library, server and tools

As suggested by Mike.
Measurement showed a substantial performance gain

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@...>
---
 urjtag/src/tap/cable/gpio.c |   63 +++++++++++++++++++------------------------
 1 files changed, 28 insertions(+), 35 deletions(-)

diff --git a/urjtag/src/tap/cable/gpio.c b/urjtag/src/tap/cable/gpio.c
index b380dba..2d70946 100644
--- a/urjtag/src/tap/cable/gpio.c
+++ b/urjtag/src/tap/cable/gpio.c
@@ -56,7 +56,7 @@ typedef struct {
     unsigned int jtag_gpios[4];
     int          signals;
     uint32_t     lastout;
-    FILE        *fp_gpios[4];
+    int          fd_gpios[4];
 } gpio_params_t;
 
 static int gpio_export (unsigned int gpio, int export)
@@ -113,11 +113,12 @@ static int gpio_direction (unsigned int gpio, int out)
     return URJ_STATUS_OK;
 }
 
-static int gpio_set_value (FILE *fp, int value)
+static int gpio_set_value (int fd, int value)
 {
-    int ret;
+    ssize_t ret;
+    char gpio_value = value + '0';
 
-    ret = fprintf (fp, "%u", value ? 1 : 0);
+    ret = write(fd, &gpio_value, 1);
     if (ret != 1)
     {
         urj_warning (_("Error setting value gpio\n"));
@@ -127,13 +128,13 @@ static int gpio_set_value (FILE *fp, int value)
     return URJ_STATUS_OK;
 }
 
-static int gpio_get_value (FILE *fp, unsigned int gpio)
+static int gpio_get_value (int *fd, unsigned int gpio)
 {
-    int ret;
-    int value;
+    ssize_t ret;
+    char value;
 
-    fseek(fp, 0, 0);
-    ret = fscanf (fp, "%i", &value);
+    lseek(fd, 0, 0);
+    ret = read(fd, &value, 1);
 
     if (ret != 1)
     {
@@ -141,7 +142,7 @@ static int gpio_get_value (FILE *fp, unsigned int gpio)
         return URJ_STATUS_FAIL;
     }
 
-    return value;
+    return value == '1';
 }
 
 static int
@@ -164,23 +165,15 @@ gpio_open (urj_cable_t *cable)
         }
         gpio_direction (gpio, (i == GPIO_TDO) ? 0 : 1);
 
-        p->fp_gpios[i] = NULL;
+        p->fd_gpios[i] = -1;
         snprintf (fname, sizeof (fname), "%sgpio%u/value", GPIO_PATH, gpio);
         fname[sizeof (fname) - 1] = '\0';
-        if (i != GPIO_TDO)
-            p->fp_gpios[i] = fopen (fname, "w");
-        else
-            p->fp_gpios[i] = fopen (fname, "r");
-        if (!p->fp_gpios[i])
+        p->fd_gpios[i] = open (fname, O_RDWR);
+        if (p->fd_gpios[i] < 0)
         {
             urj_warning (_("%s: cannot open gpio[%d] %u\n"), fname, i, gpio);
             return URJ_STATUS_FAIL;
         }
-        if (setvbuf(p->fp_gpios[i], (char *)NULL, _IONBF, 0))
-        {
-            urj_warning (_("gpio[%d] %u still in buffered mode\n"), i, gpio);
-            return URJ_STATUS_FAIL;
-        }
    }
 
     return URJ_STATUS_OK;
@@ -194,8 +187,8 @@ gpio_close (urj_cable_t *cable)
 
     for (i = 0; i < GPIO_REQUIRED; i++)
     {
-        if (p->fp_gpios[i])
-            fclose (p->fp_gpios[i]);
+        if (p->fd_gpios[i])
+            close (p->fd_gpios[i]);
         gpio_export (p->jtag_gpios[i], 0);
     }
 
@@ -319,14 +312,14 @@ gpio_clock (urj_cable_t *cable, int tms, int tdi, int n)
     tms = tms ? 1 : 0;
     tdi = tdi ? 1 : 0;
 
-    gpio_set_value (p->fp_gpios[GPIO_TMS], tms);
-    gpio_set_value (p->fp_gpios[GPIO_TDI], tdi);
+    gpio_set_value (p->fd_gpios[GPIO_TMS], tms);
+    gpio_set_value (p->fd_gpios[GPIO_TDI], tdi);
 
     for (i = 0; i < n; i++)
     {
-        gpio_set_value (p->fp_gpios[GPIO_TCK], 0);
-        gpio_set_value (p->fp_gpios[GPIO_TCK], 1);
-        gpio_set_value (p->fp_gpios[GPIO_TCK], 0);
+        gpio_set_value (p->fd_gpios[GPIO_TCK], 0);
+        gpio_set_value (p->fd_gpios[GPIO_TCK], 1);
+        gpio_set_value (p->fd_gpios[GPIO_TCK], 0);
     }
 }
 
@@ -335,14 +328,14 @@ gpio_get_tdo ( urj_cable_t *cable )
 {
     gpio_params_t *p = cable->params;
 
-    gpio_set_value(p->fp_gpios[GPIO_TCK], 0);
-    gpio_set_value(p->fp_gpios[GPIO_TDI], 0);
-    gpio_set_value(p->fp_gpios[GPIO_TMS], 0);
+    gpio_set_value(p->fd_gpios[GPIO_TCK], 0);
+    gpio_set_value(p->fd_gpios[GPIO_TDI], 0);
+    gpio_set_value(p->fd_gpios[GPIO_TMS], 0);
     p->lastout &= ~(URJ_POD_CS_TMS | URJ_POD_CS_TDI | URJ_POD_CS_TCK);
 
     urj_tap_cable_wait (cable);
 
-    return gpio_get_value (p->fp_gpios[GPIO_TDO], p->jtag_gpios[GPIO_TDO]);
+    return gpio_get_value (p->fd_gpios[GPIO_TDO], p->jtag_gpios[GPIO_TDO]);
 }
 
 static int
@@ -370,11 +363,11 @@ gpio_set_signal (urj_cable_t *cable, int mask, int val)
     if (mask != 0)
     {
         if (mask & URJ_POD_CS_TMS)
-            gpio_set_value (p->fp_gpios[GPIO_TMS], val & URJ_POD_CS_TMS);
+            gpio_set_value (p->fd_gpios[GPIO_TMS], val & URJ_POD_CS_TMS);
         if (mask & URJ_POD_CS_TDI)
-            gpio_set_value (p->fp_gpios[GPIO_TDI], val & URJ_POD_CS_TDI);
+            gpio_set_value (p->fd_gpios[GPIO_TDI], val & URJ_POD_CS_TDI);
         if (mask & URJ_POD_CS_TCK)
-            gpio_set_value (p->fp_gpios[GPIO_TCK], val & URJ_POD_CS_TCK);
+            gpio_set_value (p->fd_gpios[GPIO_TCK], val & URJ_POD_CS_TCK);
     }
 
     p->lastout = val & mask;
-- 
1.7.0.4

commit c00e9e68d7f77cc3cf3475203860a66cafeba449:
Use already cached fp rather than constantly re-opening things on the fly.
breaks gpio operation.
It is possible to reuse the cached fp, but then we need to seek to the
beginning each time.
/sys/class/gpio/gpio*/value contains only one byte so without seek
we will get only one byte.

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@...>
---
 urjtag/src/tap/cable/gpio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/urjtag/src/tap/cable/gpio.c b/urjtag/src/tap/cable/gpio.c
index 6e4c2c7..b380dba 100644
--- a/urjtag/src/tap/cable/gpio.c
+++ b/urjtag/src/tap/cable/gpio.c
@@ -132,6 +132,7 @@ static int gpio_get_value (FILE *fp, unsigned int gpio)
     int ret;
     int value;
 
+    fseek(fp, 0, 0);
     ret = fscanf (fp, "%i", &value);
 
     if (ret != 1)
-- 
1.7.0.4

avoided doing a strlen in align_string
let align_string return the new length
that way the caller can also avoid calling strlen

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@...>
---
 urjtag/src/svf/svf_flex.l |   31 +++++++++++++++++--------------
 1 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/urjtag/src/svf/svf_flex.l b/urjtag/src/svf/svf_flex.l
index 37e996a..ad19763 100644
--- a/urjtag/src/svf/svf_flex.l
+++ b/urjtag/src/svf/svf_flex.l
@@ -49,7 +49,7 @@
 #define YY_EXTRA_TYPE urj_svf_scanner_extra_t *
 
 static int map_keyw_ident(YYSTYPE *, char *);
-static void align_string(char *);
+static int align_string(char *);
 
 static void fix_yylloc(YYLTYPE *, char *);
 static void fix_yylloc_nl(YYLTYPE *, char *, YY_EXTRA_TYPE);
@@ -143,11 +143,12 @@ COMMENT         (!.*)|("//".*)[^\n]
      This is enabled with <expect_vector>. */
   /* token is a vector string */
   char *cstring;
+  int len;
 
   fix_yylloc_nl(yylloc, yytext, yyget_extra(yyscanner));
-  align_string(yytext);
+  len = align_string(yytext);
 
-  cstring = malloc(strlen(yytext) + 1);
+  cstring = malloc(len + 1);
   strcpy(cstring, yytext);
   yylval->cvalue = cstring;
   return(VECTOR_STRING);
@@ -161,13 +162,16 @@ COMMENT         (!.*)|("//".*)[^\n]
      1024 is chosen arbitrarily, increasing to e.g. 4096 enhances scanner
      performance, trading off against huge table sizes.
      This whole strategy needs to be revisited with support of flex experts.
+     Actually svf files generated by Quartus II SVF converter 10.0 have 
+     fragments of 255 bytes as that is the data on a line
   */
   char *cstring;
+  int len;
 
   fix_yylloc_nl(yylloc, yytext, yyget_extra(yyscanner));
-  align_string(yytext);
+  len = align_string(yytext);
 
-  cstring = (char *)malloc(strlen(yytext) + 1);
+  cstring = (char *)malloc(len + 1);
   strcpy(cstring, yytext);
   yylval->cvalue = cstring;
   return(HEXA_NUM_FRAGMENT);
@@ -333,20 +337,19 @@ map_keyw_ident (YYSTYPE *mylval, char *str)
 }
 
 
-static void
+static int
 align_string (char *str)
 {
-    int src, dst, len;
-
-    dst = 0;
-    len = strlen (str);
+    char *src = str;
+    char *dst;
 
-    for (src = 0; src < len; src++)
+    for (dst = src; *src; src++)
     {
-        if (isxdigit (str[src]))
-            str[dst++] = str[src];
+        if (isxdigit (*src))
+	    *dst++ = *src;
     }
-    str[dst] = '\0';
+    *dst = '\0';
+    return (dst - str);
 }
 
 
-- 
1.7.0.4

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@...>
---
 urjtag/src/svf/svf_bison.y |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/urjtag/src/svf/svf_bison.y b/urjtag/src/svf/svf_bison.y
index a8ce7dc..979c583 100644
--- a/urjtag/src/svf/svf_bison.y
+++ b/urjtag/src/svf/svf_bison.y
@@ -303,7 +303,8 @@ hexa_num_sequence
            | hexa_num_sequence HEXA_NUM_FRAGMENT
              {
 #define REALLOC_STEP (1 << 16)
-                 size_t req_len = $1.strlen + strlen ($2);
+                 size_t frag_len = strlen ($2);
+                 size_t req_len = $1.strlen + frag_len;
                  if ($1.buflen <= req_len) {
                      size_t newlen = req_len - $1.buflen < REALLOC_STEP ?
                          $1.buflen + REALLOC_STEP : req_len + 1;
@@ -312,7 +313,7 @@ hexa_num_sequence
                  }
                  if ($1.buf != NULL) {
                      strcat ($1.buf, $2);
-                     $1.strlen += strlen ($2);
+                     $1.strlen += frag_len;
                  }
                  free ($2);
                  $$ = $1;
-- 
1.7.0.4

The original code was:
strcat ($1.buf, $2);
this is changed into
strcpy ($1.buf + $1.strlen, $2);

As strcat needs to scan the string to find the end
and the string can become quite long this can take
quite some time.
Since we already have the len of the string we can
immediately go to the end of the string and strcpy there

Gain increases with the length of the design but for a 2.4 MB svf
file the gain processing the data reduced by 30 % (from 5.3 to 3.6
seconds on my system)

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@...>
---
 urjtag/src/svf/svf_bison.y |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/urjtag/src/svf/svf_bison.y b/urjtag/src/svf/svf_bison.y
index 979c583..92aacc2 100644
--- a/urjtag/src/svf/svf_bison.y
+++ b/urjtag/src/svf/svf_bison.y
@@ -312,7 +312,7 @@ hexa_num_sequence
                      $1.buflen = newlen;
                  }
                  if ($1.buf != NULL) {
-                     strcat ($1.buf, $2);
+                     strcpy ($1.buf + $1.strlen, $2);
                      $1.strlen += frag_len;
                  }
                  free ($2);
-- 
1.7.0.4

fix_yylloc calculates the length of the string argument, but
this is already available in yyleng. Pass yyleng as argument
and remove the strlen call

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@...>
---
 urjtag/src/svf/svf_flex.l |   22 +++++++++++-----------
 1 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/urjtag/src/svf/svf_flex.l b/urjtag/src/svf/svf_flex.l
index ad19763..bc0f2e2 100644
--- a/urjtag/src/svf/svf_flex.l
+++ b/urjtag/src/svf/svf_flex.l
@@ -51,7 +51,7 @@
 static int map_keyw_ident(YYSTYPE *, char *);
 static int align_string(char *);
 
-static void fix_yylloc(YYLTYPE *, char *);
+static void fix_yylloc(YYLTYPE *, char *, int);
 static void fix_yylloc_nl(YYLTYPE *, char *, YY_EXTRA_TYPE);
 static void progress_nl(YYLTYPE *, YY_EXTRA_TYPE);
 
@@ -87,7 +87,7 @@ COMMENT         (!.*)|("//".*)[^\n]
   /* token is a keyword or identifier */
   int keyw;
 
-  fix_yylloc(yylloc, yytext);
+  fix_yylloc(yylloc, yytext, yyleng);
   keyw = map_keyw_ident(yylval, yytext);
 
   /* enable detection of VECTOR_STRING when this is a PIO command */
@@ -125,7 +125,7 @@ COMMENT         (!.*)|("//".*)[^\n]
       *point_pos = extra->decimal_point;
 
     yylval->dvalue = strtod(real_string, (char **) NULL);
-    fix_yylloc(yylloc, yytext);
+    fix_yylloc(yylloc, yytext, yyleng);
 
     free(real_string);
   } else
@@ -180,18 +180,18 @@ COMMENT         (!.*)|("//".*)[^\n]
 
 {WSPACE}+ {
   /* token is a white space character */
-  fix_yylloc(yylloc, yytext);
+  fix_yylloc(yylloc, yytext, yyleng);
 } /* end of white space */
 
 
 {COMMENT} {
   /* token is a comment */
-  fix_yylloc(yylloc, yytext);
+  fix_yylloc(yylloc, yytext, yyleng);
 } /* end of comment */
 
 
 <INITIAL>"(" {
-  fix_yylloc(yylloc, yytext);
+  fix_yylloc(yylloc, yytext, yyleng);
   return(yytext[0]);
 } /* end of left or right parenthesis */
 
@@ -199,13 +199,13 @@ COMMENT         (!.*)|("//".*)[^\n]
   /* scanning until a left parenthesis under this start condition implicitly
      skips whitespace that would have been attributed to HEXA_NUM_FRAGMENT
      otherwise */
-  fix_yylloc(yylloc, yytext);
+  fix_yylloc(yylloc, yytext, yyleng);
   /* now hand over to HEXA_NUM_FRAGMENT */
   BEGIN(expect_hexa_num);
   return(yytext[0]);
 } /* end of left or right parenthesis */
 ")" {
-  fix_yylloc(yylloc, yytext);
+  fix_yylloc(yylloc, yytext, yyleng);
   BEGIN(INITIAL);
   return(yytext[0]);
 } /* end of left or right parenthesis */
@@ -227,7 +227,7 @@ COMMENT         (!.*)|("//".*)[^\n]
   /* release start condition */
   BEGIN(INITIAL);
 
-  fix_yylloc(yylloc, yytext);
+  fix_yylloc(yylloc, yytext, yyleng);
   return(yytext[0]);
 } /* end of statement character */
 
@@ -354,11 +354,11 @@ align_string (char *str)
 
 
 static void
-fix_yylloc (YYLTYPE *mylloc, char *str)
+fix_yylloc (YYLTYPE *mylloc, char *str, int len)
 {
     mylloc->first_line = mylloc->last_line;
     mylloc->first_column = mylloc->last_column;
-    mylloc->last_column += strlen (str);
+    mylloc->last_column += len;
 }
 
 
-- 
1.7.0.4

as suggested by Mike.
gains about 1% in my test (which for me is about half a second)

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@...>
---
 urjtag/src/tap/cable/gpio.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/urjtag/src/tap/cable/gpio.c b/urjtag/src/tap/cable/gpio.c
index 2d70946..96b2dee 100644
--- a/urjtag/src/tap/cable/gpio.c
+++ b/urjtag/src/tap/cable/gpio.c
@@ -133,8 +133,7 @@ static int gpio_get_value (int *fd, unsigned int gpio)
     ssize_t ret;
     char value;
 
-    lseek(fd, 0, 0);
-    ret = read(fd, &value, 1);
+    ret = pread(fd, &value, 1, 0);
 
     if (ret != 1)
     {
-- 
1.7.0.4

On Thursday, August 26, 2010 06:20:41 Frans Meulenbroeks wrote:
> commit c00e9e68d7f77cc3cf3475203860a66cafeba449:
> Use already cached fp rather than constantly re-opening things on the fly.
> breaks gpio operation.
> It is possible to reuse the cached fp, but then we need to seek to the
> beginning each time.
> /sys/class/gpio/gpio*/value contains only one byte so without seek
> we will get only one byte.

sorry, i forgot to sync svn->git.  ive done that now and you can drop this.
-mike

On Thursday, August 26, 2010 06:20:42 Frans Meulenbroeks wrote:
> As suggested by Mike.

perhaps, but ...

> -static int gpio_get_value (FILE *fp, unsigned int gpio)
> +static int gpio_get_value (int *fd, unsigned int gpio)

my patch certainly didnt do a pointer to a fd ;)

ive fixed that and some style issues and extended the changelog and merged it
-mike

On Thursday, August 26, 2010 06:20:47 Frans Meulenbroeks wrote:
> as suggested by Mike.
> gains about 1% in my test (which for me is about half a second)

merged, thanks
-mike

On Thursday, August 26, 2010 06:20:43 Frans Meulenbroeks wrote:
> @@ -143,11 +143,12 @@ COMMENT         (!.*)|("//".*)[^\n]
>       This is enabled with <expect_vector>. */
>    /* token is a vector string */
>    char *cstring;
> +  int len;
> 
>    fix_yylloc_nl(yylloc, yytext, yyget_extra(yyscanner));
> -  align_string(yytext);
> +  len = align_string(yytext);
> 
> -  cstring = malloc(strlen(yytext) + 1);
> +  cstring = malloc(len + 1);
>    strcpy(cstring, yytext);
>    yylval->cvalue = cstring;

we know the length, so let's change strcpy() to memcpy() while we're here (and 
in the other places too)
-mike

On Thursday, August 26, 2010 06:20:44 Frans Meulenbroeks wrote:
>                       strcat ($1.buf, $2);
> -                     $1.strlen += strlen ($2);
> +                     $1.strlen += frag_len;

we know the length of $2 here, so also doing a memcpy() should work
	memcpy($1.buf + $1.strlen, $2, frag_len + 1);
-mike

2010/8/26 Mike Frysinger <vapier@...>:
> On Thursday, August 26, 2010 06:20:43 Frans Meulenbroeks wrote:
>> @@ -143,11 +143,12 @@ COMMENT         (!.*)|("//".*)[^\n]
>>       This is enabled with <expect_vector>. */
>>    /* token is a vector string */
>>    char *cstring;
>> +  int len;
>>
>>    fix_yylloc_nl(yylloc, yytext, yyget_extra(yyscanner));
>> -  align_string(yytext);
>> +  len = align_string(yytext);
>>
>> -  cstring = malloc(strlen(yytext) + 1);
>> +  cstring = malloc(len + 1);
>>    strcpy(cstring, yytext);
>>    yylval->cvalue = cstring;
>
> we know the length, so let's change strcpy() to memcpy() while we're here (and
> in the other places too)
> -mike
>
Oops, did the reply instead of reply-all thing again.
Can't we have reply to the list as default?

Anyway: my msg:
Is that a request to me or a note to self ?
memcpy might make a marginal difference if it is clever enough to to
go longword copy where possible.

On Thursday, August 26, 2010 16:19:45 Mike Frysinger wrote:
> On Thursday, August 26, 2010 06:20:43 Frans Meulenbroeks wrote:
> > @@ -143,11 +143,12 @@ COMMENT         (!.*)|("//".*)[^\n]
> > 
> >       This is enabled with <expect_vector>. */
> >    
> >    /* token is a vector string */
> >    char *cstring;
> > 
> > +  int len;
> > 
> >    fix_yylloc_nl(yylloc, yytext, yyget_extra(yyscanner));
> > 
> > -  align_string(yytext);
> > +  len = align_string(yytext);
> > 
> > -  cstring = malloc(strlen(yytext) + 1);
> > +  cstring = malloc(len + 1);
> > 
> >    strcpy(cstring, yytext);
> >    yylval->cvalue = cstring;
> 
> we know the length, so let's change strcpy() to memcpy() while we're here
> (and in the other places too)

i merged your original change and then made the strcpy->memcpy fix myself
-mike

On Thursday, August 26, 2010 06:20:46 Frans Meulenbroeks wrote:
> fix_yylloc calculates the length of the string argument, but
> this is already available in yyleng. Pass yyleng as argument
> and remove the strlen call

merged, thanks
-mike

On Thursday, August 26, 2010 06:20:45 Frans Meulenbroeks wrote:
> The original code was:
> strcat ($1.buf, $2);
> this is changed into
> strcpy ($1.buf + $1.strlen, $2);
> 
> As strcat needs to scan the string to find the end
> and the string can become quite long this can take
> quite some time.
> Since we already have the len of the string we can
> immediately go to the end of the string and strcpy there
> 
> Gain increases with the length of the design but for a 2.4 MB svf
> file the gain processing the data reduced by 30 % (from 5.3 to 3.6
> seconds on my system)

merged, thanks
-mike

On Thursday, August 26, 2010 16:24:56 Mike Frysinger wrote:
> On Thursday, August 26, 2010 06:20:44 Frans Meulenbroeks wrote:
> >                       strcat ($1.buf, $2);
> > 
> > -                     $1.strlen += strlen ($2);
> > +                     $1.strlen += frag_len;
> 
> we know the length of $2 here, so also doing a memcpy() should work
> 	memcpy($1.buf + $1.strlen, $2, frag_len + 1);

merged your original change and then added my memcpy fix, thanks
-mike

ive merged all your changes (i hope) and added some fixes of my own on top.  
please make sure current trunk still works for you.
-mike

2010/8/30 Mike Frysinger <vapier@...>:
> ive merged all your changes (i hope) and added some fixes of my own on top.
> please make sure current trunk still works for you.
> -mike
>
I'll try to verify tomorrow. If I do not manage tomorrow it'll become
thursday or friday.
I'll report back my findings (success/failure).

Thanks for merging.

Frans

2010/8/30 Mike Frysinger <vapier@...>:
> ive merged all your changes (i hope) and added some fixes of my own on top.
> please make sure current trunk still works for you.
> -mike
>

Finally got to this.
I noticed one thing, not related to my changes:
there is no makefile dependency for the bison files.
The patch updated the .y file but the .c file was not regenerated when
doing a make.
guess I had to d a make distclean or so, but expected it to work out of the box.

FYI part of my dir after the make
-rw-r--r-- 1 frans frans  67735 2010-08-26 10:01 svf_bison.c
-rw-r--r-- 1 frans frans   4671 2010-08-24 13:15 svf_bison.h
-rw-r--r-- 1 frans frans  12523 2010-09-02 16:21 svf_bison.y
-rw-r--r-- 1 root  root   35948 2010-08-26 10:05 svf.c
-rw-r--r-- 1 frans frans 201685 2010-08-26 09:26 svf_flex.c
-rw-r--r-- 1 frans frans  11080 2010-09-02 16:21 svf_flex.l

Will report back on the testing tomorrow or so.

Frans

On Thursday, September 02, 2010 10:30:51 Frans Meulenbroeks wrote:
> I noticed one thing, not related to my changes:
> there is no makefile dependency for the bison files.
> The patch updated the .y file but the .c file was not regenerated when
> doing a make.
> guess I had to d a make distclean or so, but expected it to work out of the
> box.

yes, that is a known issue atm
-mike

2010/9/2 Mike Frysinger <vapier@...>:
> On Thursday, September 02, 2010 10:30:51 Frans Meulenbroeks wrote:
>> I noticed one thing, not related to my changes:
>> there is no makefile dependency for the bison files.
>> The patch updated the .y file but the .c file was not regenerated when
>> doing a make.
>> guess I had to d a make distclean or so, but expected it to work out of the
>> box.
>
> yes, that is a known issue atm
> -mike
>

Mike have you tested svf after doing the patches?
I tried git head earlier today. It seems to program the fpga (svf
command takes about the time I expect it to take) but the device does
not start although it is the same file I used before in my test (which
did work then).
The board is verifed to work (quartus programs the same design without
problems).
This happens both with usbblaster and a std ftdi2232 chip. host is
intel pc with ubuntu 10.4 (64 bit).

I will try to pinpoint the problem tomorrow at work. Could also be
that something changed due to the move to libusb1.

Frans

On Thursday, September 02, 2010 14:14:41 Frans Meulenbroeks wrote:
> Mike have you tested svf after doing the patches?

i have no idea how to use svf
-mike

2010/9/2 Frans Meulenbroeks <fransmeulenbroeks@...>:
> 2010/9/2 Mike Frysinger <vapier@...>:
>> On Thursday, September 02, 2010 10:30:51 Frans Meulenbroeks wrote:
>>> I noticed one thing, not related to my changes:
>>> there is no makefile dependency for the bison files.
>>> The patch updated the .y file but the .c file was not regenerated when
>>> doing a make.
>>> guess I had to d a make distclean or so, but expected it to work out of the
>>> box.
>>
>> yes, that is a known issue atm
>> -mike
>>
>
> Mike have you tested svf after doing the patches?
> I tried git head earlier today. It seems to program the fpga (svf
> command takes about the time I expect it to take) but the device does
> not start although it is the same file I used before in my test (which
> did work then).
> The board is verifed to work (quartus programs the same design without
> problems).
> This happens both with usbblaster and a std ftdi2232 chip. host is
> intel pc with ubuntu 10.4 (64 bit).
>
> I will try to pinpoint the problem tomorrow at work. Could also be
> that something changed due to the move to libusb1.
>
> Frans
>

Followup: apparently something went wrong after doing a git pull.
I've rebuild from scratch and dev head with the gpio and flex and
bison patches now work like charm for me.
(tested with usbblaster and ft2232 cable on ubuntu 10.04 64 bit and
with usbblaster, ft2232 and gpio on powerpc)

Frans