Steel Bank Common Lisp

Christophe Rhodes <csr21@...> writes:

> Hi,
>
> Well, 54 commits probably means that it's worth releasing sbcl this
> month :-) Please consider CVS frozen, meaning regressions and
> documentation fixes should be preferred to exciting new features and
> workarounds.  I expect to release next weekend.

If I get the solaris patches I've been working on updated to the current
development sources, any interest in getting them in before this is
tagged?  Without them, SBCL doesn't currently build on Solaris, so there
should be no negative impact of including them.

The only thing I'm still fighting with is sb-grovel support for the
struct dirent corner case -- I've got it passing the tests for dirent in
the sb-posix contrib tests, but I'm not sure the solution is robust.

I also have patches to fix install on Solaris (install.sh needs to use
the /usr/xpg4 version of id(1) on solaris, as /usr/bin/id misses some flags it
counts on).

When do these need to be ready to make it in for this release?

Thanks,
-- 
				Jim Wise
				jwise@...

Christophe Rhodes <csr21@...> writes:

> Hi,
>
> Well, 54 commits probably means that it's worth releasing sbcl this
> month :-) Please consider CVS frozen, meaning regressions and
> documentation fixes should be preferred to exciting new features and
> workarounds.  I expect to release next weekend.

The asdf-install contrib has been broken since the asdf contrib was
updated. https://bugs.launchpad.net/sbcl/+bug/612998 has a description
and a fix.

Zach

Jim Wise <jwise@...> writes:

> Christophe Rhodes <csr21@...> writes:
>
>> Hi,
>>
>> Well, 54 commits probably means that it's worth releasing sbcl this
>> month :-) Please consider CVS frozen, meaning regressions and
>> documentation fixes should be preferred to exciting new features and
>> workarounds.  I expect to release next weekend.
>
> If I get the solaris patches I've been working on updated to the current
> development sources, any interest in getting them in before this is
> tagged?  Without them, SBCL doesn't currently build on Solaris, so there
> should be no negative impact of including them.

I've placed the current version of this patch at:

     http://www.draga.com/~jwise/sbcl/sbcl-current-solaris10.diff

This is against CVS sources as of this morning.

Thanks,
-- 
				Jim Wise
				jwise@...

Zach Beane <xach@...> writes:

> Christophe Rhodes <csr21@...> writes:
>
>> Well, 54 commits probably means that it's worth releasing sbcl this
>> month :-) Please consider CVS frozen, meaning regressions and
>> documentation fixes should be preferred to exciting new features and
>> workarounds.  I expect to release next weekend.
>
> The asdf-install contrib has been broken since the asdf contrib was
> updated. https://bugs.launchpad.net/sbcl/+bug/612998 has a description
> and a fix.

I see a description; since I don't plan to test what I commit, I'd
appreciate it if a machine-readable fix such as a patch (rather than a
descriptive one) were appended to that bug report.

Thanks,

Christophe

Christophe Rhodes <csr21@...> writes:

> Zach Beane <xach@...> writes:
>
>> Christophe Rhodes <csr21@...> writes:
>>
>>> Well, 54 commits probably means that it's worth releasing sbcl this
>>> month :-) Please consider CVS frozen, meaning regressions and
>>> documentation fixes should be preferred to exciting new features and
>>> workarounds.  I expect to release next weekend.
>>
>> The asdf-install contrib has been broken since the asdf contrib was
>> updated. https://bugs.launchpad.net/sbcl/+bug/612998 has a description
>> and a fix.
>
> I see a description; since I don't plan to test what I commit, I'd
> appreciate it if a machine-readable fix such as a patch (rather than a
> descriptive one) were appended to that bug report.

Below is the diff described in that bug report.  This should work as a
quick patch, but there's more extensive asdf 2 support in the upstream
asdf-install fixes.

Index: contrib/asdf-install/installer.lisp
===================================================================
RCS file: /cvsroot/sbcl/sbcl/contrib/asdf-install/installer.lisp,v
retrieving revision 1.23
diff -p -u -u -w -r1.23 installer.lisp
--- contrib/asdf-install/installer.lisp	15 Mar 2010 09:36:41 -0000	1.23
+++ contrib/asdf-install/installer.lisp	24 Aug 2010 14:44:54 -0000
@@ -200,7 +200,7 @@
     (loop for l = (read-line (process-output proc) nil nil)
           while l
           when (> (mismatch l "[GNUPG:]") 6)
-          do (destructuring-bind (_ tag &rest data) (asdf::split l)
+          do (destructuring-bind (_ tag &rest data) (asdf::split-string l)
                (declare (ignore _))
                (pushnew (cons (intern tag :keyword)
                               data) tags)))

-- 
				Jim Wise
				jwise@...

Jim Wise <jwise@...> writes:

> ...there's more extensive asdf 2 support in the upstream asdf-install
> fixes.

For what it's what's it's worth, there's no "upstream" for SBCL's
asdf-install - it's the original. The portable asdf-install is a fork
that shares the same name but is otherwise pretty different.

Zach

Zach Beane <xach@...> writes:

> Jim Wise <jwise@...> writes:
>
>> ...there's more extensive asdf 2 support in the upstream asdf-install
>> fixes.
>
> For what it's what's it's worth, there's no "upstream" for SBCL's
> asdf-install - it's the original. The portable asdf-install is a fork
> that shares the same name but is otherwise pretty different.

Aha -- that makes sense.

Thanks,
-- 
				Jim Wise
				jwise@...

One more quick patch, this makes run-sbcl.sh runnable with the Solaris
/bin/sh:

? contrib/sb-concurrency/test-passed
Index: run-sbcl.sh
===================================================================
RCS file: /cvsroot/sbcl/sbcl/run-sbcl.sh,v
retrieving revision 1.8
diff -p -u -u -w -r1.8 run-sbcl.sh
--- run-sbcl.sh	17 Aug 2010 11:35:24 -0000	1.8
+++ run-sbcl.sh	24 Aug 2010 15:39:59 -0000
@@ -19,10 +19,10 @@ CORE_DEFINED=no
 
 for arg in $*; do
     case $arg in
-        (--core)
+        --core)
           CORE_DEFINED=yes
           ;;
-        (--help)
+        --help)
           echo "usage: run-sbcl.sh sbcl-options*"
           echo
           echo "Runs SBCL from the build directory or binary tarball without need for"

-- 
				Jim Wise
				jwise@...

Jim Wise <jwise@...> writes:

> One more quick patch, this makes run-sbcl.sh runnable with the Solaris
> /bin/sh:

And here's the fix I mentioned to turn off distrust-size for struct dirent in
sb-posix on Solaris -- as mentioned, this isn't quite right, but it does
pass the dirent tests, and is better that the build failure that's there
now.  I'm still working on a better fix, but it won't be ready for
Friday.

Index: contrib/sb-posix/constants.lisp
===================================================================
RCS file: /cvsroot/sbcl/sbcl/contrib/sb-posix/constants.lisp,v
retrieving revision 1.48
diff -p -u -u -w -r1.48 constants.lisp
--- contrib/sb-posix/constants.lisp	23 Aug 2010 23:21:27 -0000	1.48
+++ contrib/sb-posix/constants.lisp	24 Aug 2010 15:54:58 -0000
@@ -272,7 +272,8 @@
               #-(and linux largefile) "struct dirent"
               #-win32 (:ino-t ino "ino_t" "d_ino")
               (:c-string name "char *" "d_name"
-                         :distrust-length #+sunos t #-sunos nil)) t)
+                         :distrust-length nil)) t)
+;; NOTE: sunos should really have :distrust-length t, but this is currently broken
 
  ;; password database
  #-win32

-- 
				Jim Wise
				jwise@...

Jim Wise <jwise@...> writes:

> Jim Wise <jwise@...> writes:
>
>> One more quick patch, this makes run-sbcl.sh runnable with the Solaris
>> /bin/sh:

And one more, to make documentation buildable with /bin/sh on Solaris:

Index: doc/manual/Makefile
===================================================================
RCS file: /cvsroot/sbcl/sbcl/doc/manual/Makefile,v
retrieving revision 1.25
diff -p -u -u -w -r1.25 Makefile
--- doc/manual/Makefile	6 Jun 2010 20:43:58 -0000	1.25
+++ doc/manual/Makefile	24 Aug 2010 16:08:17 -0000
@@ -97,7 +97,7 @@ info: $(INFOFILES)
 CONTRIB_FASLS=$(shell find $(shell echo $(MODULES) | sed "s|:|$(CONTRIBDIR)|g") -name '*.fasl')
 docstrings: $(CONTRIB_FASLS) tempfiles-stamp
 	for module in $(shell echo $(MODULES)); do \
-		test -e $(CONTRIBDIR)/$${module#:}/test-passed \
+		test -f $(CONTRIBDIR)/`echo $$module | tr -d :`/test-passed \
 		|| { echo "The documented contrib $$module seems \
                            to have failed its tests." && exit 1; } \
 	done
Index: doc/manual/make-tempfiles.sh
===================================================================
RCS file: /cvsroot/sbcl/sbcl/doc/manual/make-tempfiles.sh,v
retrieving revision 1.12
diff -p -u -u -w -r1.12 make-tempfiles.sh
--- doc/manual/make-tempfiles.sh	11 Nov 2009 18:20:34 -0000	1.12
+++ doc/manual/make-tempfiles.sh	24 Aug 2010 16:08:17 -0000
@@ -21,7 +21,7 @@ then
 
     sbclsystem=$SBCL_PWD/../../src/runtime/sbcl
     sbclcore=$SBCL_PWD/../../output/sbcl.core
-    if [ -e $sbclsystem ] && [ -e $sbclcore ]
+    if [ -f $sbclsystem ] && [ -f $sbclcore ]
     then
         SBCLRUNTIME="$sbclsystem --core $sbclcore"
         SBCL_HOME=$SBCL_PWD/../../contrib/; export SBCL_HOME

-- 
				Jim Wise
				jwise@...

> Below is the diff described in that bug report.  This should work as a
> quick patch, but there's more extensive asdf 2 support in the upstream
> asdf-install fixes.

Thank you; merged as sbcl-1.0.41.56.

Best,

Christophe