Home / Browse / CEDET / Mail / Archive

CEDET

Email Archive: cedet-devel (read-only)

[CEDET-devel] About utests

From: Marco Bardelli <bardelli.marco@gm...> - 2010-07-20 01:11

Hi list,
about utest i see a lot of:
 Warning: cedet-called-interactively-p called with 0 arguments, but
 requires 1

i noticed that:

 find /path/to/cedet -name '*.el' | \
 xargs grep -r '(cedet-called-interactively-p)' - | \
 cut -f1 -d: | sort | uniq

get:

./cogre/cogre.el
./cogre/cogre-mode.el
./cogre/cogre-semantic.el
./cogre/cogre-uml.el
./common/cedet-graphviz.el
./common/cedet-utests.el
./common/pulse.el
./contrib/semantic-tag-folding.el
./ede/ede-dired.el
./ede/ede.el
./eieio/eieio-opt.el
./semantic/ctags/semantic-ectag-util.el
./semantic/semantic-analyze-complete.el
./semantic/semanticdb-system.el
./semantic/semantic-fold.el
./semantic/senator.el
./semantic/symref/semantic-symref-filter.el
./semantic/wisent/wisent-calc.el

Seems that cedet-called-interactively-p take only
 'interactive either 'any symbols for arguments.

If is safe fix it with 'any arg, i would fix it.

Another bad thing is 'make utest' failure on javasctript,
i haven't any ideas and i don't know javascript.

   * ERROR: (error "Buffer javascripttest.js was not set up for parsing")

Instead tests for c, python and java pass all without
any "setup for parsing".

I'm using emacs from trunk and cedet CVS via git://randomsample.de (thanks).
To prevent (may be uselessly) from load cedet integrated in emacs trunk,
in common/cedet.el and cedet-build.el, i eval this form:
--
(let ((cedetlib (locate-file "cedet" load-path '(".el" ".elc"))))
 (when cedetlib
  (setq load-path
   (remove (directory-file-name (file-name-directory cedetlib)) load-path))))
--

GNU Emacs 24.0.50.1 (powerpc-unknown-linux-gnu, GTK+ Version 2.20.0)
 of 2010-05-21 on jbook, modified by Debian

CEDET Version:	1.0
  			Requested	File		Loaded
  Package		Version		Version		Version
  ----------------------------------------------------------
  cedet:		1.0		ok		ok
  eieio:		1.3		ok		ok
  semantic:		2.0		ok		ok
  srecode:		1.0		ok		ok
  ede:			1.0		ok		ok
  speedbar:		1.0.3		ok		ok
  cogre:		1.0		ok		Not Loaded
  cedet-contrib:	1.0		ok		Not Loaded


Best regards,
Marco

Thread View

Thread	Author	Date
[CEDET-devel] About utests	Marco Bardelli <bardelli.marco@gm...>

Re: [CEDET-devel] About utests

From: Eric M. Ludlam <eric@si...> - 2010-07-20 02:18

On 07/19/2010 09:10 PM, Marco Bardelli wrote:
> Hi list,
> about utest i see a lot of:
>   Warning: cedet-called-interactively-p called with 0 arguments, but
>   requires 1

Emacs 23.2 has an arg to called-interactively-p, and when I back-merged 
their changes it broke Emacs 22 use of CEDET.  This macro is the solution.

At a guess, you may have compiled in Emacs 23, then ran in Emacs 22?

I run tests in Emacs 22 periodically, and found no errors when I also 
compile in Emacs 22.

See cedet-compat for more on this complex macro thingy.

>
> Another bad thing is 'make utest' failure on javasctript,
> i haven't any ideas and i don't know javascript.
>
>     * ERROR: (error "Buffer javascripttest.js was not set up for parsing")
>
> Instead tests for c, python and java pass all without
> any "setup for parsing".

Here I guess your javascript mode was not set up right.  By that I mean 
that you have javascript-mode defined, but it is not in the 
auto-mode-alist.  If there is no mode at all, it doesn't run the test, 
so you must have an intermediate state.

> I'm using emacs from trunk and cedet CVS via git://randomsample.de (thanks).
> To prevent (may be uselessly) from load cedet integrated in emacs trunk,
> in common/cedet.el and cedet-build.el, i eval this form:
> --
> (let ((cedetlib (locate-file "cedet" load-path '(".el" ".elc"))))
>   (when cedetlib
>    (setq load-path
>     (remove (directory-file-name (file-name-directory cedetlib)) load-path))))
> --

I have read this isn't needed, and that is is needed.  I don't know what 
the real deal is.

> GNU Emacs 24.0.50.1 (powerpc-unknown-linux-gnu, GTK+ Version 2.20.0)
>   of 2010-05-21 on jbook, modified by Debian

This implies you are not using emacs 22.  I can't guess what may be 
going on with your build.  I haven't tried Emacs 24 builds.

Eric