cruisecontrol

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kent R. Spillner updated CC-981:
--------------------------------

    Attachment: send-email-without-explicit-smtp-server.patch
                send-email-without-explicit-smtp-server-dependencies.zip

The attached patch adds support for using the email and htmlemail publishers without explicitly configuring an SMTP server.  If no mailhost is configured, then the publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

The zip file includes new dependencies required by the patch:

* aspirin v0.8.3 - aspirin provides a simple API for using the subset of functionality offered by Apache JAMES necessary to support sending MIME messages via the JavaMail API without requiring any smtp server configuration
* commons-pool v1.5.4 - required by aspirin
* dnsjava v2.0.8 - required by aspirin

The zip file should be expanded from the root directory of your local working copy.

> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Rollo resolved CC-981.
--------------------------

    Fix Version/s: 2.8.4
       Resolution: Fixed

Committed. Very nice patch!  Thanks!

> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Rollo reassigned CC-981:
----------------------------

    Assignee: Dan Rollo

> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>         Assigned To: Dan Rollo
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Rollo reopened CC-981:
--------------------------


Urgh! It appears the aspirin.jar was compiled to jdk1.6 spec. We need to maintain 1.5 spec (until a discussion is had to drop 1.5 support).
I'll try to build a 1.5 jar...

> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_18512 ] 

Dan Rollo commented on CC-981:
------------------------------

OK, I think I've got it fixed:

I changed the masukomi-aspirin-4211836/build/build.xml "compile" target from:

<javac srcdir="${src}" destdir="${classes}" deprecation="on" debug="${debug}" >
to:
<javac srcdir="${src}" destdir="${classes}" deprecation="on" debug="${debug}" target="1.5">

This appeared to produce a 1.5 version of the jar.

Kent, could you grab the latest and verify things are working? And/or can you build a 1.5 jar (that you are certain is aspirin v.0.8.3) and attach it here?

Thanks,
Dan


> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>         Assigned To: Dan Rollo
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_18515 ] 

Kent R. Spillner commented on CC-981:
-------------------------------------

Hi, Dan-

Doh!  I'm sorry I forgot to check JDK1.5 compatibility. :(

Unfortunately, it doesn't work for me as you've committed it: it times out connecting to every SMTP server I've tried.  I'm not sure if the jar you compiled is the culprit, or if it's something with my network or SMTP settings, but I'm digging into it and will keep you posted.

Best,
Kent


> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>         Assigned To: Dan Rollo
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_18516 ] 

Dan Rollo commented on CC-981:
------------------------------

I'm not confident the jar I built used the correct v2.0.8 source. You might want to try building a 1.5 jar from the v2.0.8 source (in case mine was wrong).

> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>         Assigned To: Dan Rollo
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_18521 ] 

Kent R. Spillner commented on CC-981:
-------------------------------------

Hey, Dan-

Actually, the updated .jar you committed works for me (tested on two machines).  I believe the problems I experienced last weekend were caused by a temporary network outage at my ISP.

Sorry for the confusion, and thanks again for committing this!

Best,
Kent


> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>         Assigned To: Dan Rollo
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Rollo resolved CC-981.
--------------------------

    Resolution: Fixed

Kent verified the 1.5 version of the jar works.

> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>         Assigned To: Dan Rollo
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.public.thoughtworks.org/browse/CC-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_18523 ] 

Dan Rollo commented on CC-981:
------------------------------

Great news, and Thanks for checking into it! I'm gonna mark this as done.

> Add support for sending build notification emails without requiring an SMTP relay server
> ----------------------------------------------------------------------------------------
>
>                 Key: CC-981
>                 URL: http://jira.public.thoughtworks.org/browse/CC-981
>             Project: CruiseControl
>          Issue Type: New Feature
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Kent R. Spillner
>         Assigned To: Dan Rollo
>             Fix For: 2.8.4
>
>         Attachments: send-email-without-explicit-smtp-server-dependencies.zip, send-email-without-explicit-smtp-server.patch
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Add support for sending build notification emails without requiring an SMTP relay server.  In the absence of a mailhost attribute, the email and htmlemail publishers will attempt to connect directly to the SMTP servers defined in the DNS MX records for each recipient's domain.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira