gtk2-perl

https://bugzilla.gnome.org/show_bug.cgi?id=604782
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149881|none                        |committed
             status|                            |

--- Comment #1 from Torsten Schoenfeld <kaffeetisch@...> 2009-12-17 21:03:33 UTC ---
Review of attachment 149881:
 --> (https://bugzilla.gnome.org/review?bug=604782&attachment=149881)

For fun, I built a gtk+ 2.0 sandbox and tested the patch.  Works fine. 
Committed, with the corresponding test changes:
<http://git.gnome.org/cgit/perl-Gtk2/commit/?id=ad47d5ccb78e>.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

https://bugzilla.gnome.org/show_bug.cgi?id=604782
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |kaffeetisch@...
         Resolution|                            |FIXED

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

https://bugzilla.gnome.org/show_bug.cgi?id=604782
  gnome-perl | Gtk2 | unspecified

--- Comment #2 from Kevin Ryde <user42@...> 2009-12-28 00:21:48 UTC ---
Created an attachment (id=150479)
 View: https://bugzilla.gnome.org/attachment.cgi?id=150479
 Review: https://bugzilla.gnome.org/review?bug=604782&attachment=150479

same for Gtk2::TreeStore remove()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

https://bugzilla.gnome.org/show_bug.cgi?id=604782
  gnome-perl | Gtk2 | unspecified

Kevin Ryde <user42> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #3 from Kevin Ryde <user42@...> 2009-12-28 00:23:02 UTC ---
I missed the tests being conditionalized on the version :).

I see the same can be done for remove in Gtk2::TreeStore, which I also forgot
to look at.  New attachment and reopen for that ...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

https://bugzilla.gnome.org/show_bug.cgi?id=604782
  gnome-perl | Gtk2 | unspecified

Torsten Schoenfeld <kaffeetisch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #150479|none                        |committed
             status|                            |

--- Comment #4 from Torsten Schoenfeld <kaffeetisch@...> 2010-01-09 19:14:37 UTC ---
Review of attachment 150479:
 --> (https://bugzilla.gnome.org/review?bug=604782&attachment=150479)

Committed.  Thanks!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.