2009/10/21 Maynard Johnson <maynardj@...>:
> Chen Jie wrote:
>> The second version of patch adds oprofile userland support for ICT
>> loongson2 processor.
>> Signed-off-by Chen Jie <chenj@...>
>> == changes since patch v1 ==
>> * Fix 'make distcheck' fails
>> * Add new entry to ChangeLog
>> About godson2 and loongson2:
>> godson is the codename, and loongson is the trademark, using
>> "loongson" is perferred.
>> The relationship may like Nehalem and core i7.
>> Currently, the kernel identifies loongson2 as "mips/godson2"
>> (arch/mips/oprofile/op_model_loongson2.c), so I put the substantial
>> content in godson2 events, and let loongson2 events include it.
> This seems wrong. The way you explain it, this is *not* analogous to Nehalem. For the Nehalem-based processors, the oprofile kernel driver reports their cpu_type as the specific type; e.g. "i386/core_i7". The event info is put into the events/i386/nehalem/events file, and then events/i386/core_i7/events file simply includes the nehalem events file. If the kernel reports the processor as "mips/godson2", then all you need is the godson2 events file. I don't see where the loongson2 events file would ever come into play. Did you run 'make distcheck'? This must pass before your patch can be accepted.
I've ran 'make distcheck', no error reports.
Currently only a few parts in kernel source reference "loongson" as
"godson", these will be changed to "loongson" in the future.