We like that you like it.
We'll try to make what you said.
We're going to generate all the patches from a trunk copy,
and tomorrow we will have all the desktop improvement, gio connections
And of course we will try to improve the inefficiencies that you have
recommended to us.
The way I used to store icon position was not the optimal because i
tried to use the
same function that pcmafm brings, and there was a problem naming icons,
name it using almost all alpha characters including "=", so that was the
best idea: put them backwards;
and it happens the same with the sort by type icon function i founded there.
Don't worry, we'll try to improve it.
El 24/09/09 10:30, PCMan escribió:
> I already get your branch tested. Nice work!
> Here are some comments& issues found:
> 1. moving desktop icons works. nice! however the position of icons are
> not saved properly sometimes.
> 2. The way used to store icon position will be more readable if it looks like
> rather than
> as current implementation.
> 3. managing gtk+ themes in a file manager is not a good idea although
> the UI looks ok. Anyway it's not the job of file manager and this
> could break other theme manager, like lxappearance, too. However I
> like your wallpaper management dialog. maybe we should add wallpaper
> management in lxappearance instead?
> 4. mounting remote filesystems with gvfs tools is a good idea. maybe
> you can replace the path showed in location bar with URIs rather than
> ~/.gvfs/some_remote_folder. Just create a hash table to map URIs to
> ~/.gvfs and this can be done.
> 5. the new branch doesn't seem to come with all history in old
> revisions. so merging with trunk is not possible. please use svn copy
> to create a branch in branches and do your modifications there.
> otherwise you lost all the revision history in trunk. please refer to
> svn documentations and do it correctly. so things can be merged later.
> 6. Some string in the new UI are not in English. Please fix them and
> use gettext. However, don't do the translation in branches now.
> Otherwise this can cause problems later when merge is needed. We only
> do translation in trunk.
> Thank you for the contribution!
> On Wed, Sep 23, 2009 at 11:45 PM, Mario Behling<mb@...> wrote:
>> thanks for the info. I am checking it out. Great to see you joining up!
>> What are the plans of merging the code into pcmanfm main?
>> Ciao Mario
>> On Tue, Sep 22, 2009 at 3:41 AM, Miguel Albalat Aguila<malbalat@...> wrote:
>>> I'm a new Cuban developer of pcmanfm.
>>> I've committed a new branch of pcmanfm under the name "desktop".
>>> It features desktop icons movement, drag and drop on desktop, and some other cool stuff like Gio based network connections.
>>> I want you to test it and report bugs to my account.
>>> Enjoy it.
>> Come build with us! The BlackBerry® Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and stay
>> ahead of the curve. Join us from November 9-12, 2009. Register now!
>> Lxde-list mailing list