Codestriker: collaborative code reviewer

Hi Arun;

  Nice question!

  We have the same issue in my team -- the second round is now exercised
with cvs diffs in the comment section or a new Codestriker topic is started
and the comments from the first topic are disconnected from the comments in
the second topic.

Thanks,
Ken Wolcott

On Thu, Sep 24, 2009 at 11:32, Arun Saha <arunksaha@...> wrote:

> Hi,
> We are using codestriker, and are very excited about it. We are using
> version 1.9.7.
>
> Is there any option to upload a second version of the diff?
>
> The question is coming from the following situation. I create a topic, and
> upload a version of diff. Reviewers provide some comments. I incorporate the
> comments and want to upload a second version of diff for reviewers'
> approval.
>
> Regards,
> Arun
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>
>

Yes.. its not ideal at the moment.  For really small changes, diffs in
the comments is a practical approach, or you can obsolete the topic
(see obsolete option on topic properties screen), create the new
topic, and then at least you are just a click away from the previous
comments.

Ideally, the best approach would be to upload new versions of the
changed files into the same topic, and Codestriker could automatically
maintain versions of files, including their comments.

If I actually had any spare time, I don't think it would be a mammoth
task, but these days, our team have migrated to a post-commit
workflow, which presents its own issues for tracking review comments
and responses to them.

On Fri, Sep 25, 2009 at 4:48 AM, Kenneth Wolcott
<kennethwolcott@...> wrote:
> Hi Arun;
>
>   Nice question!
>
>   We have the same issue in my team -- the second round is now exercised
> with cvs diffs in the comment section or a new Codestriker topic is started
> and the comments from the first topic are disconnected from the comments in
> the second topic.
>
> Thanks,
> Ken Wolcott
>
> On Thu, Sep 24, 2009 at 11:32, Arun Saha <arunksaha@...> wrote:
>>
>> Hi,
>> We are using codestriker, and are very excited about it. We are using
>> version 1.9.7.
>> Is there any option to upload a second version of the diff?
>> The question is coming from the following situation. I create a topic, and
>> upload a version of diff. Reviewers provide some comments. I incorporate the
>> comments and want to upload a second version of diff for reviewers'
>> approval.
>> Regards,
>> Arun
>>
>> ------------------------------------------------------------------------------
>> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and stay
>> ahead of the curve. Join us from November 9&#45;12, 2009. Register
>> now&#33;
>> http://p.sf.net/sfu/devconf
>> _______________________________________________
>> Codestriker-user mailing list
>> Codestriker-user@...
>> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>>
>
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Codestriker-user mailing list
> Codestriker-user@...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
>
>

Thank you Ken and David.

On Thu, Sep 24, 2009 at 14:35, David Sitsky <david.sitsky@...> wrote:

> Yes.. its not ideal at the moment.  For really small changes, diffs in
> the comments is a practical approach, or you can obsolete the topic
> (see obsolete option on topic properties screen), create the new
> topic, and then at least you are just a click away from the previous
> comments.
>
> Ideally, the best approach would be to upload new versions of the
> changed files into the same topic, and Codestriker could automatically
> maintain versions of files, including their comments.
>
> If I actually had any spare time, I don't think it would be a mammoth
> task, but these days, our team have migrated to a post-commit
> workflow, which presents its own issues for tracking review comments
> and responses to them.
>
> On Fri, Sep 25, 2009 at 4:48 AM, Kenneth Wolcott
> <kennethwolcott@...> wrote:
> > Hi Arun;
> >
> >   Nice question!
> >
> >   We have the same issue in my team -- the second round is now exercised
> > with cvs diffs in the comment section or a new Codestriker topic is
> started
> > and the comments from the first topic are disconnected from the comments
> in
> > the second topic.
> >
> > Thanks,
> > Ken Wolcott
> >
> > On Thu, Sep 24, 2009 at 11:32, Arun Saha <arunksaha@...> wrote:
> >>
> >> Hi,
> >> We are using codestriker, and are very excited about it. We are using
> >> version 1.9.7.
> >> Is there any option to upload a second version of the diff?
> >> The question is coming from the following situation. I create a topic,
> and
> >> upload a version of diff. Reviewers provide some comments. I incorporate
> the
> >> comments and want to upload a second version of diff for reviewers'
> >> approval.
> >> Regards,
> >> Arun
> >>
>