FCKeditor

#4387: Right clicking in Kama skin can lead to a javascript error
----------------------+-----------------------------------------------------
 Reporter:  fringley  |       Owner:  tobiasz.cudnik
     Type:  Bug       |      Status:  assigned      
 Priority:  Normal    |   Milestone:  CKEditor 3.1  
Component:  General   |     Version:  CKEditor 3.0  
 Keywords:            |  
----------------------+-----------------------------------------------------
Changes (by tobiasz.cudnik):

  * owner:  => tobiasz.cudnik
  * status:  new => assigned


-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:1>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
-----------------------+----------------------------------------------------
 Reporter:  fringley   |       Owner:  tobiasz.cudnik
     Type:  Bug        |      Status:  assigned      
 Priority:  Normal     |   Milestone:  CKEditor 3.1  
Component:  General    |     Version:  CKEditor 3.0  
 Keywords:  Confirmed  |  
-----------------------+----------------------------------------------------
Changes (by tobiasz.cudnik):

  * keywords:  => Confirmed


Comment:

 What version of safari is affected by this issue ?

 It looks strange as it's just a "for in" loop over array. I can't
 reproduce it on newest safari 4 and safari 3.2.2.

 Anyway, thank you for the patch.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:2>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
----------------------+-----------------------------------------------------
 Reporter:  fringley  |       Owner:  tobiasz.cudnik
     Type:  Bug       |      Status:  assigned      
 Priority:  Normal    |   Milestone:  CKEditor 3.1  
Component:  General   |     Version:  CKEditor 3.0  
 Keywords:  Pending   |  
----------------------+-----------------------------------------------------
Changes (by tobiasz.cudnik):

  * keywords:  Confirmed => Pending


-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:3>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
----------------------+-----------------------------------------------------
 Reporter:  fringley  |       Owner:  tobiasz.cudnik
     Type:  Bug       |      Status:  assigned      
 Priority:  Normal    |   Milestone:  CKEditor 3.1  
Component:  General   |     Version:  CKEditor 3.0  
 Keywords:  Pending   |  
----------------------+-----------------------------------------------------

Comment(by fringley):

 I had the problem in 4.0.3.

 I was a little puzzled by the problem as well, but generally it is bad
 practice to use for..in loops with arrays as it is not reliable if
 anything changes the array prototype.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:4>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
-------------------------------+--------------------------------------------
 Reporter:  fringley           |       Owner:  tobiasz.cudnik
     Type:  Bug                |      Status:  assigned      
 Priority:  Normal             |   Milestone:  CKEditor 3.1  
Component:  General            |     Version:  CKEditor 3.0  
 Keywords:  Confirmed Review?  |  
-------------------------------+--------------------------------------------
Changes (by tobiasz.cudnik):

  * keywords:  Pending => Confirmed Review?


Comment:

 Changed array prototype explains the issue.

 Attaching prepared patch.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:5>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
-------------------------------+--------------------------------------------
 Reporter:  fringley           |       Owner:  tobiasz.cudnik
     Type:  Bug                |      Status:  assigned      
 Priority:  Normal             |   Milestone:  CKEditor 3.1  
Component:  General            |     Version:  CKEditor 3.0  
 Keywords:  Confirmed Review?  |  
-------------------------------+--------------------------------------------

Comment(by fringley):

 The patch I made to our version is from the 3.0 release (which if
 different to the one in Trunk) which seemed to use the same iteration
 technique in several places.  You may want to double-check anywhere else
 that uses for..in.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:6>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
-------------------------------+--------------------------------------------
 Reporter:  fringley           |       Owner:  tobiasz.cudnik
     Type:  Bug                |      Status:  assigned      
 Priority:  Normal             |   Milestone:  CKEditor 3.1  
Component:  General            |     Version:  CKEditor 3.0  
 Keywords:  Confirmed Review+  |  
-------------------------------+--------------------------------------------
Changes (by garry.yao):

  * keywords:  Confirmed Review? => Confirmed Review+


-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:7>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
-------------------------------+--------------------------------------------
 Reporter:  fringley           |       Owner:  tobiasz.cudnik
     Type:  Bug                |      Status:  assigned      
 Priority:  Normal             |   Milestone:  CKEditor 3.1  
Component:  General            |     Version:  CKEditor 3.0  
 Keywords:  Confirmed Review+  |  
-------------------------------+--------------------------------------------

Comment(by tobiasz.cudnik):

 You're right, there were 3 more.

 After deeper checking, there is quite a bunch of for..in loops inside core
 code. Most of it iterates over objects (i think nobody extends
 Object.prototype those days ?), but some of them like editor.js L189 are
 same cases like this one. Doesn't it create any issue for you ?

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:8>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
-----------------------+----------------------------------------------------
  Reporter:  fringley  |       Owner:  tobiasz.cudnik   
      Type:  Bug       |      Status:  closed           
  Priority:  Normal    |   Milestone:  CKEditor 3.1     
 Component:  General   |     Version:  CKEditor 3.0     
Resolution:  fixed     |    Keywords:  Confirmed Review+
-----------------------+----------------------------------------------------
Changes (by tobiasz.cudnik):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 Fixed with [4211].

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:9>
CKEditor <http://ckeditor.com/>
The text editor for Internet

#4387: Right clicking in Kama skin can lead to a javascript error
-----------------------+----------------------------------------------------
  Reporter:  fringley  |       Owner:  tobiasz.cudnik   
      Type:  Bug       |      Status:  closed           
  Priority:  Normal    |   Milestone:  CKEditor 3.1     
 Component:  General   |     Version:  CKEditor 3.0     
Resolution:  fixed     |    Keywords:  Confirmed Review+
-----------------------+----------------------------------------------------

Comment(by fringley):

 As yet, I've not had any more javascript errors occur, but it is possible
 that in my use I have not exercised those code paths.

-- 
Ticket URL: <http://dev.fckeditor.net/ticket/4387#comment:10>
CKEditor <http://ckeditor.com/>
The text editor for Internet