On Fri, Aug 14, 2009 at 03:03:02PM +0100, Keith Whitwell wrote:
> Regarding 0006-progs-egl-Fix-compilation-error-of-demo3.patch:
> In general it is preferable not to introduce compilation errors into the
> git history, at least knowingly. Can you respin your patch series to
> not introduce the error in the first place?
Sure, sorry about that. This patch series reflects my git history, and
as you said, it is better not to introduce build error. I have the
updated patch series attached.
> I think I saw this in a previous series from you, that compilation broke
> in one patch & was fixed in a subsequent one in the series. That's a
> pain later on if someone tries to bisect & lands at your broken patch...
Regarding the api overhaul series, I intended to split them in a way
that I assume is easier to review. Logically, it changes only one
thing: eglapi.c. I want to add a check to functions in it. But the
result is that I have to update many files and drivers. If I were to
try not break the build, I would have to either submit a single big
patch, or many small ones each touches many files cross the tree.
Either way, they are harder to read.
As for driver/display series, I will update it after I receive more
comments. This is to avoid it from reaching version 6 or something too