libMesh: A C++ Finite Element Library

On Mon, Jun 15, 2009 at 9:35 AM, Norbert Stoop<norbert@...> wrote:
> Dear libmesh developers
>
> My Valgrind reports a couple of leaks in the VTKIO mesh input/output
> routines. Apparently, most (all?) VTK functions for adding elements to a
> grid require a pointer to the objects to be added, but internally the
> data is copied nevertheless. In other words, one manually has to clean
> up afterwards which is not always the case in vtk_io.C. Attached is a
> patch that makes my Valgrind happy.
>
> Please check if I free the _vtk_grid at the correct places (in
> particular the read function). AFAIK, _vtk_grid is not used across any
> of the functions. It should therefore be safe to free it at the end of
> the function where it is allocated (read, write and
> write_equation_systems), but like I said, I'm not sure...

Thanks very much for the patch.  I'll be happy to check it in.  Anyone
else who actually uses VTK output from Libmesh should also feel free
to comment, as I don't use it much myself.

-- 
John

On Mon, 15 Jun 2009, Norbert Stoop wrote:

> Dear libmesh developers

Hmm... is anyone else familiar with the VTK IO?  I can take a look at
this if nobody volunteers - IIRC our VTK support has been built up
from contributions from people other than the regular devs.
---
Roy

the patch looks good to me.
It will be a while before I can try with a recent libmesh checkout so
I suggest to proceed with checkin.

Wout

On Mon, Jun 15, 2009 at 5:19 PM, Roy Stogner<roystgnr@...> wrote:
>
> On Mon, 15 Jun 2009, Norbert Stoop wrote:
>
>> Dear libmesh developers
>
> Hmm... is anyone else familiar with the VTK IO?  I can take a look at
> this if nobody volunteers - IIRC our VTK support has been built up
> from contributions from people other than the regular devs.
> ---
> Roy
>
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables unlimited
> royalty-free distribution of the report engine for externally facing
> server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Libmesh-devel mailing list
> Libmesh-devel@...
> https://lists.sourceforge.net/lists/listinfo/libmesh-devel
>

On Thu, Jun 18, 2009 at 8:58 AM, Wout Ruijter<woutruijter@...> wrote:
> the patch looks good to me.
> It will be a while before I can try with a recent libmesh checkout so
> I suggest to proceed with checkin.

Patch is in, thanks everyone for your input.

-- 
John