GStreamer

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m@...
             Status|UNCONFIRMED                 |NEEDINFO




------- Comment #1 from Tim-Philipp Müller  2009-05-04 18:36 UTC -------
What version of lame do you have? Presumably something < 3.98?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git

Tristan Matthews changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |UNCONFIRMED




------- Comment #2 from Tristan Matthews  2009-05-04 19:33 UTC -------
i have lame 3.97 (package from Hardy)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git




------- Comment #3 from Tim-Philipp Müller  2009-05-04 19:42 UTC -------
Created an attachment (id=133953)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=133953&action=view)
possible fix: fall back to _set_VBR_q() if _set_VBR_quality() is not available

Does this fix it for you?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git




------- Comment #4 from Tristan Matthews  2009-05-04 20:00 UTC -------
i applied the patch but it's still not getting that function definition:
  CC    gstlamemp3enc.o
cc1: warnings being treated as errors
gstlamemp3enc.c: In function ‘gst_lamemp3enc_setup’:
gstlamemp3enc.c:776: warning: implicit declaration of function
‘lame_set_VBR_quality’


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git




------- Comment #5 from Tim-Philipp Müller  2009-05-04 21:41 UTC -------
Was configure.ac updated and did configure re-run?


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git




------- Comment #6 from Tristan Matthews  2009-05-04 23:26 UTC -------
yeah the changes are there, i ran
make distclean && ./autogen.sh && ./configure && make && sudo make install
to no avail


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133953|0                           |1
        is obsolete|                            |




------- Comment #7 from Tim-Philipp Müller  2009-05-05 00:02 UTC -------
Created an attachment (id=133980)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=133980&action=view)
possible fix: fall back to _set_VBR_q() if _set_VBR_quality() is not available
(this time for real)

Let's try this again ...


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git




------- Comment #8 from Tristan Matthews  2009-05-05 00:33 UTC -------
still doesn't work, same error as before.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO




------- Comment #9 from Tim-Philipp Müller  2009-05-05 07:59 UTC -------
Ok, so:

 - what's the output of 'grep LAME_CFLAGS Makefile' ?

 - what's the output of

   grep -A 200 lame_init config.log  | grep -B 200 'These plugins will be
built: lame'

   (as attachement if too long please)


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git




------- Comment #10 from Tristan Matthews  2009-05-05 15:10 UTC -------
Created an attachment (id=134027)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=134027&action=view)
output of grep for LAME_CFLAGS etc.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git

Tristan Matthews changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134027|0                           |1
        is obsolete|                            |




------- Comment #11 from Tristan Matthews  2009-05-05 15:15 UTC -------
Created an attachment (id=134028)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=134028&action=view)
output of grep for LAME_CFLAGS etc.

the last one wasn't correct


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133980|0                           |1
        is obsolete|                            |
 Attachment #134028|0                           |1
        is obsolete|                            |




------- Comment #12 from Tim-Philipp Müller  2009-05-05 15:28 UTC -------
Created an attachment (id=134030)
 --> (http://bugzilla.gnome.org/attachment.cgi?id=134030&action=view)
possible fix: third attempt


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git

Tristan Matthews changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED




------- Comment #13 from Tristan Matthews  2009-05-05 15:33 UTC -------
That did it.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.

If you have any questions why you received this email, please see the text at
the end of this email. Replies to this email are NOT read, please see the text
at the end of this email. You can add comments to this bug at:
  http://bugzilla.gnome.org/show_bug.cgi?id=581341

  GStreamer | gst-plugins-ugly | Ver: git

Tim-Philipp Müller changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134030|none                        |committed
               Flag|                            |
            Summary|Building gst-plugins-ugly   |[lamemp3enc] doesn't build
                   |fails due to warning for    |with LAME 3.97: implicit
                   |gstlamemp3enc.c             |declaration of function
                   |                            |‘lame_set_VBR_quality’
   Target Milestone|HEAD                        |0.10.12




------- Comment #14 from Tim-Philipp Müller  2009-05-05 15:46 UTC -------
commit 95ddda57e2f5ac2b52fb4431e739cceba5a20722
Author: Tim-Philipp Müller <tim.muller@...>
Date:   Tue May 5 16:38:19 2009 +0100

    lame: fix compilation with LAME versions < 3.98

    lame_set_VBR_quality(), which takes a floating point value for the
    quality, has been added only in v3.98. Use lame_set_VBR_q(), which
    takes quality as an integer, for older LAME versions.

    Fixes #581341.


-- 
See http://bugzilla.gnome.org/page.cgi?id=email.html for more info about why you received
this email, why you can't respond via email, how to stop receiving
emails (or reduce the number you receive), and how to contact someone
if you are having problems with the system.

You can add comments to this bug at http://bugzilla.gnome.org/show_bug.cgi?id=581341.