On Thu, Jan 22, 2009 at 11:01 PM, Alessio Stalla
> Alright, I have finally found some time to attack the issue of merging
> the "scripting" branch with trunk.
> I checked out abcl's trunk head (revision 11575), done a merge in my
> working copy and verified that it builds. I have run my little test
> cases (to be added to abcl's own tests sooner or later...) for the
> jsr-223 support and got no errors. I have also run the ansi-tests for
> the first time (via the ant target) - it said "build successful" after
> 25 or so minutes, but I don't know if that means the tests actually
> passed (shouldn't some fail with current abcl?). Then I generated a
> patch (which I'm attaching) and briefly contorlled it - it seems to be
> basically only additions, no deletions, as I expected, so it seems
> relatively safe.
Thanks for taking the time. The "Build successfull" part is probably
misleading, however, a little bit before the end, there should be a
list of items which failed. If you have around 45 errors, that's good.
> I am aware of at least two problems that imho should be solved before
> committing the merge:
> 1. the ant build still checks for java > 1.5 to include jsr-223
> support instead of controlling the existence of the
> javax.script.ScriptEngine class (as someone correctly suggested some
> time ago)
> 2. the jsr-223 support is not at all integrated with the lisp-based
> build (which I don't know since I've only used it once a looong time
> ago ;-)
> problem 1 is easy to solve and I'll do it as soon as possible
> (probably tomorrow). Problem 2 is a bit harder for me, so if anyone
> has got ideas (or kindly wants to volunteer for such an interesting
> job ;-), he's welcome.
Problem 2 is "easy" to fix for me; some others may also be able to do
it. So, if you merge the change to trunk, possibly you (or Mark) can
fix (1) and Mark, Ville or I can fix (2).
> Is everyone ok with this?
Yes! Thanks again for the great contribution!
BTW: I may have already asked you so, but are you using the code yourself?