LAME (Lame Aint an MP3 Encoder)

Hello Fabian,

for which version of LAME is this patch intended?
I'm asking, because 3.98.1 comes with a similar patch already.

Am 14.01.2009, 09:56 Uhr, schrieb Fabian Greffrath <greffrath@...>:

> Dear lame developers,
>
> the attached patch courtesy of Russell Coker <russell@...>
> disables the executable stack in the shared library.
>
> Author: Russell Coker <russell@...>
> Description: Disabling executable stack.
>
> diff -Naurp lame.orig/libmp3lame/i386/nasm.h lame/libmp3lame/i386/nasm.h
> --- lame.orig/libmp3lame/i386/nasm.h+0000
> +++ lame/libmp3lame/i386/nasm.h
> @@ -18,6 +18,8 @@
>
>   BITS 32
>
> +section .note.GNU-stack noalloc noexec nowrite progbits
> +
>   %ifdef YASM
>   	%define segment_code segment .text align=16 use32
>   	%define segment_data segment .data align=16 use32
>
> Cheers,
> Fabian
>



-- 


Ciao Robert

robert schrieb:
> for which version of LAME is this patch intended?
> I'm asking, because 3.98.1 comes with a similar patch already.

It's for 3.98.2 respectively current trunk where 
libmp3lame/i386/nasm.h hasn't been patched already.

Fabian

-- 
Dipl.-Phys. Fabian Greffrath

Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum

Telefon: +49 (0)234 / 32-26334
Fax:     +49 (0)234 / 32-14227
E-Mail:  greffrath@...

Hi, Fabian, Robert.

On Jan 14 2009, Fabian Greffrath wrote:
> robert schrieb:
> > for which version of LAME is this patch intended?
> > I'm asking, because 3.98.1 comes with a similar patch already.
> 
> It's for 3.98.2 respectively current trunk where 
> libmp3lame/i386/nasm.h hasn't been patched already.

Is this still needed?

Regards,

-- 
Rogério Brito : rbrito@... : GPG key 1024D/7C2CAEB8
http://www.ime.usp.br/~rbrito : http://meusite.mackenzie.com.br/rbrito
Projects: algorithms.berlios.de : lame.sf.net : vrms.alioth.debian.org

Hi Rogerio,

Rogério Brito schrieb:
> Is this still needed?

well, at least it hasn't been applied yet. ;)

Having a look at the affected file, it seems a similar fix has indeed 
already been applied in line 40. However, as far as I understand the 
ifdef/elifdef/etc logic, it is only processed if all three of "%ifdef 
YASM", "%elifdef WIN32" and "%elifdef AOUT" are false. It's only an 
idea, I am not an expert in ASM, but could it be an error hides behind 
this logic?

Cheers,
Fabian



-- 
Dipl.-Phys. Fabian Greffrath

Ruhr-Universität Bochum
Lehrstuhl für Energieanlagen und Energieprozesstechnik (LEAT)
Universitätsstr. 150, IB 3/134
D-44780 Bochum

Telefon: +49 (0)234 / 32-26334
Fax:     +49 (0)234 / 32-14227
E-Mail:  greffrath@...