Home / Browse / CEDET / Mail / Archive

CEDET

Email Archive: cedet-devel (read-only)

[CEDET-devel] Quick fix for JDEE and ECB in Emacs CVS

From: Bryan Waite <bryanwaite@gm...> - 2008-12-24 03:21

It looks like there's an issue with JDEE and ECB using bytecomp when using recent emacs cvs builds (I've tested with the 2008-12-05 build for ubuntu 8.10 from https://launchpad.net/~ubuntu-elisp/+archive and a custom build from today). Trying to load either results in a failure with "wrong number of arguments" error, and debug-on-entry points to a number of "byte-compile" and "byte-optimize" function calls just before the error. Since I figured that other people may be having the same problem, I've got a quick patch that may help. It's dumped from a git repo though, so it may need a bit of filename tweaking to apply cleanly to the cvs version though.

----------------------------

diff --git a/eieio/eieio.el b/eieio/eieio.el
index 1c5cb9d..8a34410 100755
--- a/eieio/eieio.el
+++ b/eieio/eieio.el
@@ -1197,11 +1197,11 @@ IMPL is the symbol holding the method implementation."
   ;; NOTE: I tried out byte compiling this little fcn.  Turns out it
   ;; is faster to execute this for not byte-compiled.  ie, install this,
   ;; then measure calls going through here.  I wonder why.
-  (require 'bytecomp)
-  (let ((byte-compile-free-references nil)
-	(byte-compile-warnings nil)
-	)
-    (byte-compile-lambda
+  ;; (require 'bytecomp)
+  ;; (let ((byte-compile-free-references nil)
+  ;;       (byte-compile-warnings nil)
+  ;;       )
+  ;;   (byte-compile-lambda
      `(lambda (&rest local-args)
 	,doc-string
 	;; This is a cool cheat.  Usually we need to look up in the
@@ -1234,7 +1234,7 @@ IMPL is the symbol holding the method implementation."
 	      (apply ,(list 'quote impl) local-args)
 	      ;(,impl local-args)
 	      ))))
-     ))
+     ;; ))  
   )
 
 (defsubst eieio-defgeneric-reset-generic-form-primary-only-one (method)

Thread View

Thread	Author	Date
[CEDET-devel] Quick fix for JDEE and ECB in Emacs CVS	Bryan Waite <bryanwaite@gm...>

Re: [CEDET-devel] Quick fix for JDEE and ECB in Emacs CVS

From: Eric M. Ludlam <eric@si...> - 2008-12-29 04:33

Hi,

  I updated my Emacs from CVS recently (Dec 24) and have since done a
full rebuild of CEDET with the fresh Emacs.

  I have run into no such problems during compilation of CEDET, nor
ECB from CVS.  I didn't try JDEE .  There have been a couple EIEIO
changes since your build of 12/05, so perhaps it was fixed?

  I cannot install ubuntu but if you have some other straightforward
compilation steps I can take to repro the problem, I'd like to know
what they might be.

  I don't think the byte-comp step should be removed from this code,
since it is a part of the performance boost the change went in for in
the first place.

Thanks
Eric

>>> Bryan Waite <bryanwaite@...> seems to think that:
>It looks like there's an issue with JDEE and ECB using bytecomp when
>using recent emacs cvs builds (I've tested with the 2008-12-05 build
>for ubuntu 8.10 from https://launchpad.net/~ubuntu-elisp/+archive and
>a custom build from today). Trying to load either results in a failure
>with "wrong number of arguments" error, and debug-on-entry points to a
>number of "byte-compile" and "byte-optimize" function calls just
>before the error. Since I figured that other people may be having the
>same problem, I've got a quick patch that may help. It's dumped from a
>git repo though, so it may need a bit of filename tweaking to apply
>cleanly to the cvs version though.
>
>----------------------------
>
>diff --git a/eieio/eieio.el b/eieio/eieio.el
>index 1c5cb9d..8a34410 100755
>--- a/eieio/eieio.el
>+++ b/eieio/eieio.el
>@@ -1197,11 +1197,11 @@ IMPL is the symbol holding the method implementation."
>   ;; NOTE: I tried out byte compiling this little fcn.  Turns out it
>   ;; is faster to execute this for not byte-compiled.  ie, install this,
>   ;; then measure calls going through here.  I wonder why.
>-  (require 'bytecomp)
>-  (let ((byte-compile-free-references nil)
>-	(byte-compile-warnings nil)
>-	)
>-    (byte-compile-lambda
>+  ;; (require 'bytecomp)
>+  ;; (let ((byte-compile-free-references nil)
>+  ;;       (byte-compile-warnings nil)
>+  ;;       )
>+  ;;   (byte-compile-lambda
>      `(lambda (&rest local-args)
> 	,doc-string
> 	;; This is a cool cheat.  Usually we need to look up in the
>@@ -1234,7 +1234,7 @@ IMPL is the symbol holding the method implementation."
> 	      (apply ,(list 'quote impl) local-args)
> 	      ;(,impl local-args)
> 	      ))))
>-     ))
>+     ;; ))  
>   )
> 
> (defsubst eieio-defgeneric-reset-generic-form-primary-only-one (method)
>
>------------------------------------------------------------------------------
>_______________________________________________
>Cedet-devel mailing list
>Cedet-devel@...
>https://lists.sourceforge.net/lists/listinfo/cedet-devel
>

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net

Re: [CEDET-devel] Quick fix for JDEE and ECB in Emacs CVS

From: Daniel Clemente <dcl441-bugs@ya...> - 2009-01-01 10:10

Hi,
  I also got this problem with Emacs and CEDET and JDE all from version control from yesterday. I might have older byte-compiled files there.

  JDEE contains in efc.el this code:

(defmethod efc-coll-add ((this efc-list) item)
  "Adds an item to the list."
  (if (efc-coll-type-compatible-p this item)
      (oset this items (append (oref this items) (list item)))
    (error "Tried to add an item of type %s to a list of items of type %s"
	   (typep item) (oref this elem-type))))

  If I eval this, I get the stack trace appended below.

  Just substituting the (typep item) to for instance "(type item)" makes the code run (and JDEE load again) without a big loss.

Daniel


--------------------
Debugger entered--Lisp error: (wrong-number-of-arguments #[(form val type) "Å!2

Re: [CEDET-devel] Quick fix for JDEE and ECB in Emacs CVS

From: Daniel Clemente <dcl441-bugs@ya...> - 2009-01-01 10:22

I see the stacktrace was trimmed. I will try again, this time without so many control characters:



Debugger entered--Lisp error: (wrong-number-of-arguments #[(form val type) "Å!2.Æ	Ç!\".È
	\"É>Ê	! .
0.ËÌ!.Í	DCÎ	
#E))" [type val res temp form cl-const-expr-p cl-make-type-test cl-const-expr-val cl-expr-contains (nil 1) cl-simple-expr-p make-symbol "--cl-var--" let subst] 6] 2)
  #[(form val type) "Å!2.Æ	Ç!\".È\n	\"É>Ê	! .\n0.ËÌ!.Í	DCÎ	\n#E))\f" [type val res temp form cl-const-expr-p cl-make-type-test cl-const-expr-val cl-expr-contains (nil 1) cl-simple-expr-p make-symbol "--cl-var--" let subst] 6]((typep item) item)
  apply(#[(form val type) "Å!2.Æ	Ç!\".È\n	\"É>Ê	! .\n0.ËÌ!.Í	DCÎ	\n#E))\f" [type val res temp form cl-const-expr-p cl-make-type-test cl-const-expr-val cl-expr-contains (nil 1) cl-simple-expr-p make-symbol "--cl-var--" let subst] 6] (typep item) item)
  compiler-macroexpand((typep item))
  byte-optimize-form-code-walker((typep item) nil)
  byte-optimize-form((typep item))
  mapcar(byte-optimize-form ("Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type)))
  byte-optimize-form-code-walker((error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type)) nil)
  byte-optimize-form((error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type)) nil)
  byte-optimize-body(((error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type))) nil)
  byte-optimize-form-code-walker((if (efc-coll-type-compatible-p this item) (oset this items (append ... ...)) (error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type))) nil)
  byte-optimize-form((if (efc-coll-type-compatible-p this item) (oset this items (append ... ...)) (error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type))) nil)
  byte-optimize-form-code-walker((progn (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))) nil)
  byte-optimize-form((progn (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))) nil)
  byte-compile-top-level((progn (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))) nil lambda)
  byte-compile-lambda((lambda (this item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))))
  byte-compile-function-form((function (lambda (this item) "Adds an item to the list." (if ... ... ...))))
  byte-compile-form((function (lambda (this item) "Adds an item to the list." (if ... ... ...))))
  mapc(byte-compile-form ((function (lambda ... "Adds an item to the list." ...)) local-args))
  byte-compile-normal-call((apply (function (lambda ... "Adds an item to the list." ...)) local-args))
  byte-compile-funarg((apply (quote (lambda ... "Adds an item to the list." ...)) local-args))
  byte-compile-form((apply (quote (lambda ... "Adds an item to the list." ...)) local-args) nil)
  byte-compile-body(((apply (quote ...) local-args)) nil)
  byte-compile-let((let ((scoped-class efc-list) (eieio-generic-call-next-method-list nil) (eieio-generic-call-key method-primary) (eieio-generic-call-methodname ...) (eieio-generic-call-arglst local-args)) (apply (quote ...) local-args)))
  byte-compile-form((let ((scoped-class efc-list) (eieio-generic-call-next-method-list nil) (eieio-generic-call-key method-primary) (eieio-generic-call-methodname ...) (eieio-generic-call-arglst local-args)) (apply (quote ...) local-args)) nil)
  byte-compile-body(((let (... ... ... ... ...) (apply ... local-args))) nil)
  byte-compile-if((if (not (child-of-class-p ... efc-list)) (apply (quote no-applicable-method) (car local-args) (quote efc-coll-add) local-args) (let (... ... ... ... ...) (apply ... local-args))))
  byte-compile-form((if (not (child-of-class-p ... efc-list)) (apply (quote no-applicable-method) (car local-args) (quote efc-coll-add) local-args) (let (... ... ... ... ...) (apply ... local-args))) nil)
  byte-compile-body(((if (not ...) (apply ... ... ... local-args) (let ... ...))) nil)
  byte-compile-if((if (not (condition-case nil ... ...)) (signal (quote no-method-definition) (list ... local-args)) (if (not ...) (apply ... ... ... local-args) (let ... ...))))
  byte-compile-form((if (not (condition-case nil ... ...)) (signal (quote no-method-definition) (list ... local-args)) (if (not ...) (apply ... ... ... local-args) (let ... ...))) nil)
  byte-compile-top-level((progn (if (not ...) (signal ... ...) (if ... ... ...))) nil lambda)
  byte-compile-lambda((lambda (&rest local-args) "Adds an item to the list." (if (not ...) (signal ... ...) (if ... ... ...))))
  eieio-defgeneric-form-primary-only-one(efc-coll-add "Adds an item to the list." efc-list (lambda (this item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))))
  eieio-defmethod(efc-coll-add (((this efc-list) item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))))
  (defmethod efc-coll-add ((this efc-list) item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...)))
  eval((defmethod efc-coll-add ((this efc-list) item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))))
  eval-last-sexp-1(nil)
  eval-last-sexp(nil)
  call-interactively(eval-last-sexp nil nil)
  recursive-edit()
  byte-code("Æ.	@Ç=!.ÈÉÊ\"ËÉ!.A@)¢Ì=!.ÈÍÊ\"Î!Ï Ð	!\fd.Ñed\".VW.ebÒ.¥y`dbÒ.¥.Zy`|)ÓcebÔÕÖ \"×Æ!ÔØ!ÙÊÔØ!Ú +Ù" [unread-command-char debugger-args x debugger-buffer noninteractive debugger-batch-max-lines -1 debug backtrace-debug 4 t backtrace-frame lambda 5 pop-to-buffer debugger-mode debugger-setup-buffer count-lines 2 "...\n" message "%s" buffer-string kill-emacs "" nil recursive-edit middlestart buffer-read-only standard-output] 4)
  debug(error (wrong-number-of-arguments #[(form val type) "Å!2.Æ	Ç!\".È\n	\"É>Ê	! .\n0.ËÌ!.Í	DCÎ	\n#E))\f" [type val res temp form cl-const-expr-p cl-make-type-test cl-const-expr-val cl-expr-contains ... cl-simple-expr-p make-symbol "--cl-var--" let subst] 6] 2))
  #[(form val type) "Å!2.Æ	Ç!\".È\n	\"É>Ê	! .\n0.ËÌ!.Í	DCÎ	\n#E))\f" [type val res temp form cl-const-expr-p cl-make-type-test cl-const-expr-val cl-expr-contains (nil 1) cl-simple-expr-p make-symbol "--cl-var--" let subst] 6]((typep item) item)
  apply(#[(form val type) "Å!2.Æ	Ç!\".È\n	\"É>Ê	! .\n0.ËÌ!.Í	DCÎ	\n#E))\f" [type val res temp form cl-const-expr-p cl-make-type-test cl-const-expr-val cl-expr-contains (nil 1) cl-simple-expr-p make-symbol "--cl-var--" let subst] 6] (typep item) item)
  compiler-macroexpand((typep item))
  byte-optimize-form-code-walker((typep item) nil)
  byte-optimize-form((typep item))
  mapcar(byte-optimize-form ("Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type)))
  byte-optimize-form-code-walker((error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type)) nil)
  byte-optimize-form((error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type)) nil)
  byte-optimize-body(((error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type))) nil)
  byte-optimize-form-code-walker((if (efc-coll-type-compatible-p this item) (oset this items (append ... ...)) (error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type))) nil)
  byte-optimize-form((if (efc-coll-type-compatible-p this item) (oset this items (append ... ...)) (error "Tried to add an item of type %s to a list of items of type %s" (typep item) (oref this elem-type))) nil)
  byte-optimize-form-code-walker((progn (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))) nil)
  byte-optimize-form((progn (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))) nil)
  byte-compile-top-level((progn (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))) nil lambda)
  byte-compile-lambda((lambda (this item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))))
  byte-compile-function-form((function (lambda (this item) "Adds an item to the list." (if ... ... ...))))
  byte-compile-form((function (lambda (this item) "Adds an item to the list." (if ... ... ...))))
  mapc(byte-compile-form ((function (lambda ... "Adds an item to the list." ...)) local-args))
  byte-compile-normal-call((apply (function (lambda ... "Adds an item to the list." ...)) local-args))
  byte-compile-funarg((apply (quote (lambda ... "Adds an item to the list." ...)) local-args))
  byte-compile-form((apply (quote (lambda ... "Adds an item to the list." ...)) local-args) nil)
  byte-compile-body(((apply (quote ...) local-args)) nil)
  byte-compile-let((let ((scoped-class efc-list) (eieio-generic-call-next-method-list nil) (eieio-generic-call-key method-primary) (eieio-generic-call-methodname ...) (eieio-generic-call-arglst local-args)) (apply (quote ...) local-args)))
  byte-compile-form((let ((scoped-class efc-list) (eieio-generic-call-next-method-list nil) (eieio-generic-call-key method-primary) (eieio-generic-call-methodname ...) (eieio-generic-call-arglst local-args)) (apply (quote ...) local-args)) nil)
  byte-compile-body(((let (... ... ... ... ...) (apply ... local-args))) nil)
  byte-compile-if((if (not (child-of-class-p ... efc-list)) (apply (quote no-applicable-method) (car local-args) (quote efc-coll-add) local-args) (let (... ... ... ... ...) (apply ... local-args))))
  byte-compile-form((if (not (child-of-class-p ... efc-list)) (apply (quote no-applicable-method) (car local-args) (quote efc-coll-add) local-args) (let (... ... ... ... ...) (apply ... local-args))) nil)
  byte-compile-body(((if (not ...) (apply ... ... ... local-args) (let ... ...))) nil)
  byte-compile-if((if (not (condition-case nil ... ...)) (signal (quote no-method-definition) (list ... local-args)) (if (not ...) (apply ... ... ... local-args) (let ... ...))))
  byte-compile-form((if (not (condition-case nil ... ...)) (signal (quote no-method-definition) (list ... local-args)) (if (not ...) (apply ... ... ... local-args) (let ... ...))) nil)
  byte-compile-top-level((progn (if (not ...) (signal ... ...) (if ... ... ...))) nil lambda)
  byte-compile-lambda((lambda (&rest local-args) "Adds an item to the list." (if (not ...) (signal ... ...) (if ... ... ...))))
  eieio-defgeneric-form-primary-only-one(efc-coll-add "Adds an item to the list." efc-list (lambda (this item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))))
  eieio-defmethod(efc-coll-add (((this efc-list) item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))))
  (defmethod efc-coll-add ((this efc-list) item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...)))
  eval((defmethod efc-coll-add ((this efc-list) item) "Adds an item to the list." (if (efc-coll-type-compatible-p this item) (oset this items ...) (error "Tried to add an item of type %s to a list of items of type %s" ... ...))))
  eval-last-sexp-1(nil)
  eval-last-sexp(nil)
  call-interactively(eval-last-sexp nil nil)

Re: [CEDET-devel] Quick fix for JDEE and ECB in Emacs CVS

From: Eric M. Ludlam <eric@si...> - 2009-01-01 13:15

Hi,

  Eieio has some new optimizations in it, one of which is generating
code at run-time, not compile time.  To keep the speed up, it then
byte-compiles at run time also.

  To disable it, you can set eieio-optimize-primary-methods-flag to
nil, which will most likely stop the error.

  Of course, all that is moot, since typep is supposed to take 2
arguments, not just 1.  Perhaps no-one ever ran into this line of code
before?  Also, the error command wants a string.  Typep would be a
boolean.

  Better code might be to use %S and pass in the item directly.

Eric

>>> Daniel Clemente <dcl441-bugs@...> seems to think that:
>
>Hi,
>  I also got this problem with Emacs and CEDET and JDE all from version control from yesterday. I might have older byte-compiled files there.
>
>  JDEE contains in efc.el this code:
>
>(defmethod efc-coll-add ((this efc-list) item)
>  "Adds an item to the list."
>  (if (efc-coll-type-compatible-p this item)
>      (oset this items (append (oref this items) (list item)))
>    (error "Tried to add an item of type %s to a list of items of type %s"
>	   (typep item) (oref this elem-type))))
>
>  If I eval this, I get the stack trace appended below.
>
>  Just substituting the (typep item) to for instance "(type item)" makes the code run (and JDEE load again) without a big loss.
>
>Daniel
>
>
>--------------------
>Debugger entered--Lisp error: (wrong-number-of-arguments #[(form val type) "Å!2
>
>
>
>------------------------------------------------------------------------------
>
>_______________________________________________
>Cedet-devel mailing list
>Cedet-devel@...
>https://lists.sourceforge.net/lists/listinfo/cedet-devel
>

Re: [CEDET-devel] Quick fix for JDEE and ECB in Emacs CVS

From: Daniel Clemente <dcl441-bugs@ya...> - 2009-01-01 13:36

"Eric M. Ludlam" <eric@...> writes:
>
>   Eieio has some new optimizations in it, one of which is generating
> code at run-time, not compile time.  To keep the speed up, it then
> byte-compiles at run time also.
>
  Nice!

>
>   Of course, all that is moot, since typep is supposed to take 2
> arguments, not just 1.  Perhaps no-one ever ran into this line of code
> before?  Also, the error command wants a string.  Typep would be a
> boolean.
>

  In JDEE's Subversion repository there's a branch called 2.3.6. In that branch, the code reads now:

(defmethod efc-coll-add ((this efc-list) item)
  "Adds an item to the list."
  (if (efc-coll-type-compatible-p this item)
      (oset this items (append (oref this items) (list item)))
    (error "Tried to add an item of type %s to a list of items of type %s"
	   (type-of item) (oref this elem-type))))

  So it was type-of what they wanted; not typep. In JDEE 2.3.5.1 it's wrong; in JDEE 2.3.6 it's fixed.
  I hope JDEE 2.3.6 is released some day...