CEDET

Hi,

Here is what I discovered investigating the code about the
previously mentionned problem :

Here's the method that "relativizes" :


(defmethod ede-subproject-relative-path ((proj ede-project) &optional parent-in)
  "Get a path name for PROJ which is relative to the parent project.
If PARENT is specified, then be relative to the PARENT project.
Specifying PARENT is useful for sub-sub projects relative to the root project."

This last sentence is precisely the point ! In my example in the previous mail sound was a subsubproject and its directory should be calculated relatively to the project directly above and not the root. 

(defmethod ede-proj-makefile-insert-subproj-rules ((this ede-proj-project))
  "Insert a rule for the project THIS which should be a subproject."
  (insert ".PHONY:" (ede-name this))
  (newline)
  (insert (ede-name this) ":")
  (newline)
  (insert "\tcd "
	  (directory-file-name (ede-subproject-relative-path this))
	  "; $(MAKE)")
  (newline)
  (newline)
  )


ede-subproject-relative-path is called here without any second
argument hence the path will be relativized with respect to the
result of ede-parent-project wich seems to return the root
project and not the project directly above. 

This last method ede-parent-project does not look completly
clear to me but certainly I didn't investigate enough ...


Regards,

Pierre

Hi,

Well my opinion is that the ede-parent-project method has
changed and that the new implementation is no longer compatible
with previous use. Hence I think that modifications should be
done if the present implementation of the above method must be
kept. I made a few changes in the ede-pmake.el file.

Any of this modification is introduced by 
;;; Modified by PLN
followed by the output of current-time-string at the moment I
made it so that you can easily track them. 

With these modifications it works on my site but building of
the tags and dist targets should be modified too. I didn't made
them since I first do not use these targets for the moment and
second I wonder if the new behavior of ede-parent-project is
really wished ! Anyway if the actual spec is that this method
returns the root and not the project directly above I would
personnaly find very convenient that a method doing the latter
job is implemented as well.

Tell me if my modification will be done in the cvs version or
if they are not needed : it is not totally impossible that I
misunderstood everything and that I did completely wrong !

Regards 

Pierre

>>> Pierre Lorenzon <devel@...> seems to think that:
>
>Hi,
>
>Well my opinion is that the ede-parent-project method has
>changed and that the new implementation is no longer compatible
>with previous use. Hence I think that modifications should be
>done if the present implementation of the above method must be
>kept. I made a few changes in the ede-pmake.el file.
  [ ... ]

Hi,

  Earlier today I found that the "ede-current-project" fcn was
returning the root, and not the current project.  This was due to some
optimizations I've been trying to do to make things go faster.  I had
fixed that earlier before getting your email.

  I've just read your mail, and checked in that fix, plus some other
optimizations I was working on.  Hopefully it will fix your issue.
(I'm guessing.)

  I haven't had time to explicitly test the feature you were talking
about or look at your patch.  I'll do that next time I have some time
to work on this.

Eric

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net