[ http://www.datanucleus.org/servlet/jira/browse/NUCACCESS-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15783#action_15783 ]
Andy Jefferson commented on NUCACCESS-3:
----------------------------------------
======= INHERITANCE =========
> Do the scripts help with Erik's Ant builds?
The scripts are nothing to do with Erik's Ant builds. His builds use the pom.xml and having parentage in the M2 pom breaks the process since it is not accessible via a flat checkout (as stated in forum threads). Hence why I said parentage breaks his building, hence why the plugin POMs don't now have parentage, and hence they work with SVN-style or flat checkouts. Which is why I am against parentage in M2 poms.
======= AGGREGATION ========
> No, they don't have to be bidirectional. You can have aggregation without inheritance by leaving out entirely the " <parent>" tags from the child-modules. Alternatively, we could just leave out the "relativePath", relying on the parent pom being installed already for inheritance (as you suggested IIRC).
So if they aren't bidirectional and only using aggregation then you're doing the same as my scripts, just that you use M2. No problem with that since it doesn't affect my use of M2 within a plugin since inheritance isn't used. Obviously only one route for building all parts of a product will be maintained - whether it is scripts or "M2 aggregation convenience POM".
Presumably by talking about parent POM's you mean there will be a parent POM for "accessplatform" and a parent POM for "analysisplatform", because you can't surely be thinking of having any global parent for both together.
[If they are versioned branches of the same project "maven2.project" then would be too confusing to have version 1.0 of the parent POM to be AccessPlatform 1.0, then version 1.1 of the parent POM to be AccessPlatform 1.1 then version 1.2 of the parent POM to be AnalysisPlatform 1.0] So have to assume that you mean parent POM projects for AccessPlatform, and AnalysisPlatform ? under "accessplatform", "analysisplatform".
> Maven2 build doesnt work for test projects and has to for JPOX to swap to Maven2
> --------------------------------------------------------------------------------
>
> Key: NUCACCESS-3
> URL: http://www.datanucleus.org/servlet/jira/browse/NUCACCESS-3
> Project: DataNucleus Access Platform
> Issue Type: Task
> Reporter: Andy Jefferson
> Assignee: Joerg von Frantzius
>
> See project test.jdo.general for example. Run "mvn clean test" and you get something like
> ENHANCED (PersistenceCapable) : org.jpox.samples.metadata.animal.Cat
> DataNucleus Enhancer completed with success for 100 classes. Timings : input=1305 ms, enhance=851 ms, total=2156 ms. Consult the log for full details
> [ERROR] --------------------
> [ERROR] Standard error from the JPOX tool + org.datanucleus.enhancer.DataNucleusEnhancer :
> [ERROR] --------------------
> [ERROR] log4j:WARN No appenders could be found for logger (DataNucleus.ClassLoading).
> log4j:WARN Please initialize the log4j system properly.
> [ERROR] --------------------
> [INFO] [resources:testResources]
> [INFO] Using default encoding to copy filtered resources.
> [INFO] [compiler:testCompile]
> [INFO] Compiling 37 source files to /home/andy/work/datanucleus/test/test.jdo.general/trunk/bin
> [INFO] [surefire:test]
> [INFO] Surefire report directory: /home/andy/work/datanucleus/test/test.jdo.general/trunk/bin/surefire-reports
> log4j:WARN No appenders could be found for logger (JPOX.TEST).
> log4j:WARN Please initialize the log4j system properly.
> PMF could not be created from properties file - see the log for details of the locations tested
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] There are test failures.
> [INFO] ------------------------------------------------------------------------
> [INFO] For more information, run Maven with the -e switch
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12 seconds
> [INFO] Finished at: Mon Apr 21 17:05:48 BST 2008
> [INFO] Final Memory: 12M/508M
> [INFO] ------------------------------------------------------------------------
> With Maven1 we pass in properties into the maven1 plugin via plugin.properties - which DB to run, etc etc. Doesn't seem to be set up with Maven2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.datanucleus.org/servlet/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|