Yaakov (Cygwin Ports) wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> Jon TURNEY wrote:
>> Patch-set to build 1.5.2 is at:
> Thanks; if you don't mind, I'll keep these patches in SVN.
> There do appear to be some issues:
> 1) In cygwin-build-as-console-app.patch, you remove the -mwindows flag.
> Without it, XWin *requires* a console, so if it is launched from
> Windows itself (e.g. through the Run... dialog or cygstart), you will
> get a cmd.exe console attached to XWin which you will not be able to
> close without closing XWin. So -mwindows is definitely correct, and it
> also implies -lgdi32.
Oops. Yeah, that patch slipped in by accident.
Just for my convenience I build as a console app so I get output to stdout
and can kill the server with ctrl-c.
> As for -static, except for libXfont, there is no reason not to
> dynamically link. But libXfont can't be static only because xfs
> requires a shared libXfont (else you get conflicting symbols during
> linking from the xtrans code). I'm considering a few ways to work
> around this without too much hackery.
> 2) Building the GLX extension requires installing
> include/GL/internal/dri_interface.h from Mesa with an obvious patch.
> (The source files I mentioned before should NOT be moved.)
> 3) Activation of the GLX and SGI-GLX extensions require installing
> swrast_dri.so from Mesa. With some work, this module compiles, but
> linking leaves undefined symbols to _glapi_Dispatch and _glapi_Context,
> which AFAICS are pointers that are meant to be exported by the
> implementor (libGL, xserver, etc.). This will take some more work.
> 4) The following extensions, present in 1.3, do not show in 1.5:
> DEC-XTRAP, RECORD, SECURITY, XAccessControlExtension, XC-APPGROUP,
> XFree86-Bigfont, XINERAMA. I noticed you removed some #include
> "xorg-config.h" additions from the last patch set; are these related?
I believe that HAVE_DIX_CONFIG_H is defined during the build now so that
change isn't needed, dix-config.h is included directly by miinitext.c
I know there is an effort to clean up a lot of obsolete stuff,
http://www.x.org/wiki/Releases/7.5 lists a set of extensions scheduled for
removal in R7.5
> DEC-XTrap: deleted in master, not sure when disabled by default.
"no-one who remembers this stuff is still alive" :)
Seems pretty clear that no-one should be using this for new work
> Record: commit 3eaecdd6
> Security and XC-AppGroup: commit 1c6cb353.
> XAccessControlExtension (aka XACE): still enabled by default in
> configure; perhaps disabled because Security/AppGroup aren't there to
> use it?
See commmit f6a78ee143e3a3ad69538adf2b9675d724468ffa
XACE is built-in now
> XFree86-Bigfont: commit 3c19ec47
> Xinerama: I thought RandR was providing this as well in 1.3, but not in 1.5?
I see XINERAMA in the list of extensions.
> I see that DMX has been disabled by default as well. So the questions are:
> 1) Can we confirm that these are all deprecated and are no longer in use?
We have the option of doing --enable-xtrap --enable-record --enable-security
--enable-xf86bigfont, although it might make sense to wait until someone moans
about the absence of these extensions...
> 2) If so, should we scrap the related client packages, namely
> dmxproto/libdmx, trapproto/ libXTrap/xtrap, xf86bigfontproto and
> xineramaproto? We can't do the same for recordproto, as it is a dep of
> libXtst, which is used by a number of other packages (which makes me
> wonder about disabling the Record extension).
It should be fairly benign to leave these things hanging around, as an X
client built using them should be checking at runtime if the server supports
the extension they want to use.