CEDET

Hi,

  Your patch makes some sense, but I have to wonder why these modes
are starting up at all.  They should only run if semantic-init-hooks
are run, and that should only happen if a buffer is set up for
parsing.

  Do you know how Semantic gets into that state?

  I don't use desktop, so have not encountered this issue.

Eric

>>> Alex Ott <alexott@...> seems to think that:
>Hello
>
>Some time ago i found, that cedet's routines break loading of desktop file
>with errors like "Buffer ... wasn't set for parsing", etc.  These errors
>lead to stopping load of desktop file, so it doesn't restored completely. 
>Attached file add error handlers to some places, please review it, and
>apply if all ok
>

Hello

In my setup, i first load all modes, and only after this i restore old
configuration with desktop, that loads files, registers, etc.  May be when
restoring C++ source files, semantic initialisation is happened?

>>>>> "EML" == Eric M Ludlam writes:
 EML> Hi, Your patch makes some sense, but I have to wonder why these modes
 EML> are starting up at all.  They should only run if semantic-init-hooks
 EML> are run, and that should only happen if a buffer is set up for
 EML> parsing.

 EML>   Do you know how Semantic gets into that state?

 EML>   I don't use desktop, so have not encountered this issue.

 EML> Eric

 > Alex Ott <alexott@...> seems to think that:
 >> Hello
 >> 
 >> Some time ago i found, that cedet's routines break loading of desktop
 >> file with errors like "Buffer ... wasn't set for parsing", etc.  These
 >> errors lead to stopping load of desktop file, so it doesn't restored
 >> completely.  Attached file add error handlers to some places, please
 >> review it, and apply if all ok
 >> 

-- 
With best wishes, Alex Ott, MBA
http://alexott.blogspot.com/        http://xtalk.msk.su/~ott/
http://alexott-ru.blogspot.com/

Hi,

  I checked into CVS a small patch to semantic-util-modes which
disables desktop for semantic minor modes.  There is likely a better
trick I could use instead of a disable, and to instead re-enable after
semantic has been setup again.  Perhaps someone who uses the desktop
package can work on that?

The new code is in semantic-util-modes.el in `semantic-add-minor-mode'.

Eric

>>> Alex Ott <alexott@...> seems to think that:
>Hello
>
>In my setup, i first load all modes, and only after this i restore old
>configuration with desktop, that loads files, registers, etc.  May be when
>restoring C++ source files, semantic initialisation is happened?
>
>>>>>> "EML" == Eric M Ludlam writes:
> EML> Hi, Your patch makes some sense, but I have to wonder why these modes
> EML> are starting up at all.  They should only run if semantic-init-hooks
> EML> are run, and that should only happen if a buffer is set up for
> EML> parsing.
>
> EML>   Do you know how Semantic gets into that state?
>
> EML>   I don't use desktop, so have not encountered this issue.
>
> EML> Eric
>
> > Alex Ott <alexott@...> seems to think that:
> >> Hello
> >> 
> >> Some time ago i found, that cedet's routines break loading of desktop
> >> file with errors like "Buffer ... wasn't set for parsing", etc.  These
> >> errors lead to stopping load of desktop file, so it doesn't restored
> >> completely.  Attached file add error handlers to some places, please
> >> review it, and apply if all ok
> >> 
>

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net

Hello

Thanks for patch, i'll check it tomorrow at work

On Sun, Oct 19, 2008 at 3:45 PM, Eric M. Ludlam <eric@...> wrote:
> Hi,
>
>  I checked into CVS a small patch to semantic-util-modes which
> disables desktop for semantic minor modes.  There is likely a better
> trick I could use instead of a disable, and to instead re-enable after
> semantic has been setup again.  Perhaps someone who uses the desktop
> package can work on that?
>
> The new code is in semantic-util-modes.el in `semantic-add-minor-mode'.
>
> Eric
>
>>>> Alex Ott <alexott@...> seems to think that:
>>Hello
>>
>>In my setup, i first load all modes, and only after this i restore old
>>configuration with desktop, that loads files, registers, etc.  May be when
>>restoring C++ source files, semantic initialisation is happened?
>>
>>>>>>> "EML" == Eric M Ludlam writes:
>> EML> Hi, Your patch makes some sense, but I have to wonder why these modes
>> EML> are starting up at all.  They should only run if semantic-init-hooks
>> EML> are run, and that should only happen if a buffer is set up for
>> EML> parsing.
>>
>> EML>   Do you know how Semantic gets into that state?
>>
>> EML>   I don't use desktop, so have not encountered this issue.
>>
>> EML> Eric
>>
>> > Alex Ott <alexott@...> seems to think that:
>> >> Hello
>> >>
>> >> Some time ago i found, that cedet's routines break loading of desktop
>> >> file with errors like "Buffer ... wasn't set for parsing", etc.  These
>> >> errors lead to stopping load of desktop file, so it doesn't restored
>> >> completely.  Attached file add error handlers to some places, please
>> >> review it, and apply if all ok
>> >>
>>
>
> --
>          Eric Ludlam:                       eric@...
>   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net
>



-- 
With best wishes,                    Alex Ott, MBA
http://alexott.blogspot.com/
http://alexott-ru.blogspot.com/
http://xtalk.msk.su/~ott/

Hello Eric

Desktop doesn't check value of function, that you provide to
desktop-minor-mode-handlers, so when it restore buffers, load is failed.
It's better to use dummy function, like this:

(defun my-desktop-ignore-semantic (desktop-buffer-file-name)
       "Function to ignore cedet minor modes during restore of buffers"
       nil)

With this function, all works fine

 EML> Hi, I checked into CVS a small patch to semantic-util-modes which
 EML> disables desktop for semantic minor modes.  There is likely a better
 EML> trick I could use instead of a disable, and to instead re-enable
 EML> after semantic has been setup again.  Perhaps someone who uses the
 EML> desktop package can work on that?

 EML> The new code is in semantic-util-modes.el in
 EML> `semantic-add-minor-mode'.


-- 
With best wishes, Alex Ott, MBA
http://alexott.blogspot.com/           http://xtalk.msk.su/~ott/
http://alexott-ru.blogspot.com/

Thanks!  I've checked in something equivalent.

Eric

>>> Alex Ott <alexott@...> seems to think that:
>Hello Eric
>
>Desktop doesn't check value of function, that you provide to
>desktop-minor-mode-handlers, so when it restore buffers, load is failed.
>It's better to use dummy function, like this:
>
>(defun my-desktop-ignore-semantic (desktop-buffer-file-name)
>       "Function to ignore cedet minor modes during restore of buffers"
>       nil)
>
>With this function, all works fine
>
> EML> Hi, I checked into CVS a small patch to semantic-util-modes which
> EML> disables desktop for semantic minor modes.  There is likely a better
> EML> trick I could use instead of a disable, and to instead re-enable
> EML> after semantic has been setup again.  Perhaps someone who uses the
> EML> desktop package can work on that?
>
> EML> The new code is in semantic-util-modes.el in
> EML> `semantic-add-minor-mode'.
>
>

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net