--- Comment #7 from Petri Hintukainen <phi@...> 2012-06-15 10:45:32 CEST ---
(In reply to comment #6)
> Created attachment 89 [details]
> "Fix" the segfaults. Maybe cause worse problems.
> What's really needed, I think, is for libXv to be fixed to allow arbitrary
> allocations but to clip the output image to what the hardware supports;
> this is, therefore, an X.org problem.
libXv returns max. size it can handle, so checking allocated image size seems
> Up to a point, we can check for problems and do our own clipping, but I recall
> SDL not checking either – and yes, one video output method uses SDL :-|
Yes. SDL part didn't work. SDL still returned oversized image size and crashed.
But it returned correct pitch, so maybe this could be used to detect failed
frame allocation ?
(we know YUY2 pitch must be at least 2*requested width ...)
> Try this patch; it's been a while since I looked at it, and it'll probably
> cause X etc. to crash and burn and you to reach for the reset button. But ISTR
> that it will, as far as is possible, fix the segfaults :-)
I've applied modified version to xv and xshm plugins. Allocated frames now have
stk part didn't compile. sdl part seems useless. xxmc part I couldn't test, so
it is still unapplied.
Note that decoders need to be fixed too; decoders must check returned frame
size and not expect it matches requested size. I don't think this is big issue
with video decoders, most Xv adaptors support 2048x2048 (more than Full HD).
Well, there are some Full HD 3D H.264 clips that are larger than this so we
might need to reconsider this later.
I've fixed image decoders to crop images to allocated frame size, so segfaults
should be fixed for xv/xcbxv.
I'll also add configure option to downscale images when video out can't handle
large images (I prefer downscaling instead of cropping ...).
Configure bugmail: https://bugs.xine-project.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.