Bugs item #1027328, was opened at 2004-09-13 15:58
Message generated for change (Comment added) made by gwalker
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=105113&aid=1027328&group_id=5113
Category: MRBS
Group: Minor
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Thekk (thekk)
>Assigned to: Gavin Walker (gwalker)
Summary: Handling email through mail()
Initial Comment:
The script has a little problem with mail() and having
assigned all $params in functions_mail.inc: PEARS mail
factory command sends through these parameters and
attaches them to the headers
(http://pear.php.net/manual/en/package.mail.mail.factory.php)
. That gives odd messages in my systemlog
(gentoo/postfix). The diff shows the fix that I suggest:
#diff diff functions_mail.inc functions_mail.inc.old
674,683c674,680
< // only do the params when we're not using mail()
to prevent problems with $params being passed on to
mail() if *not* in safe mode
< if (!"mail"==strtolower($backend)){
< $params['sendmail_path'] = $sendmail_path;
< $params['sendmail_args'] = $sendmail_args;
< $params['host'] = $host;
< $params['port'] = $port;
< $params['auth'] = $auth;
< $params['username'] = $username;
< $params['password'] = $password;
< }
---
> $params['sendmail_path'] = $sendmail_path;
> $params['sendmail_args'] = $sendmail_args;
> $params['host'] = $host;
> $params['port'] = $port;
> $params['auth'] = $auth;
> $params['username'] = $username;
> $params['password'] = $password;
Another thing I've changed is that I've commented (from
the same diff):
667c667
< // $headers['To'] = $recipients;
---
> $headers['To'] = $recipients;
To prevent a double 'To' header, but I don't know if
that's specific to mail() or not. It might also be
included in the if route (but then it needs to be
shoved up a little).
Oh yeah, I am running/testing version 1.2
----------------------------------------------------------------------
>Comment By: Gavin Walker (gwalker)
Date: 2004-11-21 00:25
Message:
Logged In: YES
user_id=77869
Fixed in cvs HEAD and 1.2 branch.
----------------------------------------------------------------------
Comment By: John Beranek (jberanek)
Date: 2004-10-06 12:23
Message:
Logged In: YES
user_id=71843
I (or someone else) will try to get around to looking at the
proposed fixes and checking them in if OK. Thanks,
John.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=105113&aid=1027328&group_id=5113
|