(quickly replying as I'm online for a short time)
On Mon, Aug 18, 2008 at 10:28 PM, Ville Voutilainen
>> Stay tuned.
> Patch attached. I added a helper function that concats the suffixes
> .lisp and .abcl
> and checks the modification dates if files for both suffixes are
> found, as I planned.
It's a great patch, almost what I had in mind after finding the source
of the issue, indeed. I like the fact that you factored out some code.
> I modified the original Load filename parameter to be non-final, since
> it was just easier to reassign it after modification. The code still
> contains more
> copy-pasteish stuff than I'd like (the isFile queries, the getName
> reassigns), but
> I didn't like to return that stuff through parameters, since returning
> through a parameter
> looks horrible in java, especially for immutable objects where I'd
> need an array.
> A separate (inner) class or something like that for the return value
> of addExtension
> is also a bit too much for me to tolerate.
The code is nice as it is. However, I have 2 remarks:
1) you could make use of the fact that - according to the File()
docstring - "new File(filename) == new File(dir, filename)" when dir
2) File.getName() doesn't work for me when using absolute paths (where
the ABCL file isn't in the current directory); maybe File.getPath()
> According to my tests, with this patch load works as desired. I tested loading
> with full filename, then without suffix and modded the modification date of
> my .lisp and .abcl files. AFAIK this loads the correct file in all cases.
Could you give the patch another round please? I can commit after the
above 2 issues are addressed.