Home / Browse / Direct Rendering Infrastructure / Mail / Archive

Direct Rendering Infrastructure

Email Archive: dri-devel (read-only)

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-07-02 15:10

http://bugs.freedesktop.org/show_bug.cgi?id=16194





--- Comment #8 from Brian Paul <brian.paul@...>  2008-07-02 08:10:28 PST ---
OK, I've commited a cleaned-up version of the patch.  Though, it doesn't make
any difference in the above-attached test program, and I don't see how it would
effect the i915 driver.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

Thread View

Thread	Author	Date
[Bug 16194] Fog not applied to bitmap	<bugzilla-daemon@fr...>

[Bug 16194] [mesa_7_0_branch] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-06-03 05:50

http://bugs.freedesktop.org/show_bug.cgi?id=16194


Gordon Jin <gordon.jin@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16029
            Summary|Fog not applied to bitmap   |[mesa_7_0_branch] Fog not
                   |                            |applied to bitmap




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-06-05 05:01

http://bugs.freedesktop.org/show_bug.cgi?id=16194


WuNian <nian.wu@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[mesa_7_0_branch] Fog not   |[mesa_7_0_branch i915] Fog
                   |applied to bitmap           |not applied to bitmap




--- Comment #2 from WuNian <nian.wu@...>  2008-06-04 22:01:23 PST ---
The bug only exists with i915 driver. i965 driver has no this bug.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-06-10 01:54

http://bugs.freedesktop.org/show_bug.cgi?id=16194





--- Comment #3 from haihao <haihao.xiang@...>  2008-06-09 18:54:15 PST ---
Created an attachment (id=17021)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=17021)
patch to set fragment fogc attribute for the span

Hi, Brian
    I915 adds some extra instructions to do fog, then turn off FogOption, which
causes the FOGC attribute of the span isn't set on mesa_7_0_branch.  This patch
fixes this issue, but I am not sure whether it breaks other driver. Could you
take a look?

Thanks
Haihao




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-06-10 02:32

http://bugs.freedesktop.org/show_bug.cgi?id=16194


haihao <haihao.xiang@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17021|0                           |1
        is obsolete|                            |




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-06-10 02:33

http://bugs.freedesktop.org/show_bug.cgi?id=16194





--- Comment #4 from haihao <haihao.xiang@...>  2008-06-09 19:33:07 PST ---
Created an attachment (id=17024)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=17024)
patch to set fragment fogc attribute for the span


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-06-10 11:55

http://bugs.freedesktop.org/show_bug.cgi?id=16194





--- Comment #5 from Roland Scheidegger <sroland@...>  2008-06-10 04:55:26 PST ---
(In reply to comment #3)
> Created an attachment (id=17021)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=17021) [details]
> patch to set fragment fogc attribute for the span

>     I915 adds some extra instructions to do fog, then turn off FogOption, which
> causes the FOGC attribute of the span isn't set on mesa_7_0_branch.  This patch
> fixes this issue, but I am not sure whether it breaks other driver. Could you
> take a look?

I don't think this is entirely correct. A (user supplied) fragment program
could use FOGC for something else than fog.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-07-02 01:18

http://bugs.freedesktop.org/show_bug.cgi?id=16194


haihao <haihao.xiang@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sroland@...




--- Comment #6 from haihao <haihao.xiang@...>  2008-07-01 18:18:34 PST ---
(In reply to comment #5)
> >     I915 adds some extra instructions to do fog, then turn off FogOption, which
> > causes the FOGC attribute of the span isn't set on mesa_7_0_branch.  This patch
> > fixes this issue, but I am not sure whether it breaks other driver. Could you
> > take a look?
> 
> I don't think this is entirely correct. A (user supplied) fragment program
> could use FOGC for something else than fog.
> 
This patch just initializes the FOGC attribute of the span if FOGC is used as
an input.  If a fragment used FOGC for something, it still need to initialize
this attribute, right?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-07-02 12:42

http://bugs.freedesktop.org/show_bug.cgi?id=16194





--- Comment #7 from Roland Scheidegger <sroland@...>  2008-07-02 05:42:42 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > >     I915 adds some extra instructions to do fog, then turn off FogOption, which
> > > causes the FOGC attribute of the span isn't set on mesa_7_0_branch.  This patch
> > > fixes this issue, but I am not sure whether it breaks other driver. Could you
> > > take a look?
> > 
> > I don't think this is entirely correct. A (user supplied) fragment program
> > could use FOGC for something else than fog.
> > 
> This patch just initializes the FOGC attribute of the span if FOGC is used as
> an input.  If a fragment used FOGC for something, it still need to initialize
> this attribute, right?

You're right I didn't look closely enough. May cause (little) unnecessary work
to be done but if fog is applied or not is not determined by this, so should
probably be ok.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-07-02 15:10

http://bugs.freedesktop.org/show_bug.cgi?id=16194





--- Comment #8 from Brian Paul <brian.paul@...>  2008-07-02 08:10:28 PST ---
OK, I've commited a cleaned-up version of the patch.  Though, it doesn't make
any difference in the above-attached test program, and I don't see how it would
effect the i915 driver.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-07-04 01:37

http://bugs.freedesktop.org/show_bug.cgi?id=16194





--- Comment #9 from haihao <haihao.xiang@...>  2008-07-03 18:37:18 PST ---
(In reply to comment #8)
> OK, I've commited a cleaned-up version of the patch.  Though, it doesn't make
> any difference in the above-attached test program, 

Need to define GL_GLEXT_PROTOTYPES when compiling this test case.

> and I don't see how it would
> effect the i915 driver.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-07-04 01:39

http://bugs.freedesktop.org/show_bug.cgi?id=16194


haihao <haihao.xiang@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #10 from haihao <haihao.xiang@...>  2008-07-03 18:39:55 PST ---
fixed in mesa_7_0_branch (8261c40bb9b689d05e80e1423eb8d9f13b49b2b8)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2008-07-07 01:18

http://bugs.freedesktop.org/show_bug.cgi?id=16194


WuNian <nian.wu@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 16194] [mesa_7_0_branch i915] Fog not applied to bitmap

From: <bugzilla-daemon@fr...> - 2009-08-24 19:30

http://bugs.freedesktop.org/show_bug.cgi?id=16194


ajax at nwnk dot net <ajax@...> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS                         |git




--- Comment #11 from ajax at nwnk dot net <ajax@...>  2009-08-24 12:30:16 PST ---
Mass version move, cvs -> git


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.