CEDET

Hi,

  Thanks for the patch!  Have you signed a disclaimer w/ the FSF for
contributing your changes to Emacs?  If so, I can integrate this.
Otherwise, I will put it into the `contrib' directory, which will have
roughly the same effect in cedet.tar.gz.

  CEDET will be integrated into Emacs sometime soon.  When it does,
stuff in the contrib directory will not be included.

  Did you have any short test files w/ PHP in them?  In order for me
to keep pieces I don't understand working, tests are important so I
don't break things accidentally in the future.  See
semantic/semantic-utest.el for one possible way to help me keep your
stuff working.

Thanks!
Eric

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net

Hi,

> Have you signed a disclaimer w/ the FSF for
> contributing your changes to Emacs?

No, however i'm a GNOME developer and GNOME Foundation member.

> Otherwise, I will put it into the `contrib' directory, which will have
> roughly the same effect in cedet.tar.gz.

IIRC, the patch add files in contrib.

>   CEDET will be integrated into Emacs sometime soon.

So good news :)

> When it does, stuff in the contrib directory will not be included.

>   Did you have any short test files w/ PHP in them?

I didn't wrote the files, the code is from geben project
( http://trac.sakura.ne.jp/geben/ ). I just created the patch to include
it in cedet (just like ruby). This will ease the distribution of geben.
geben is alpha software, but i don't know if this part is such unstable.

I added Thoru in CC, i hope he didn't abandon the project. PHP debugging
is actually a must have feature for web development.

Regards,
Étienne.

>>> =?ISO-8859-1?Q?=C9tienne?= BERSAC <bersace03@...> seems to think that:
>Hi,
>
>Let me propose you a patch against cedet CVS adding wisent PHP from
>geben project.o;? ( http://trac.sakura.ne.jp/geben/ ). Patch attached.
>
>I'm packaging geben for debian. Geben implement PHP debugging into
>emacs.
  [ ... ]

Hi,

  Is there some missing code in your patch?  It appears that there is
a missing wisent-php-tags.wy.  Also, wisent-php appears to need a
(require 'wisent-php) just before the declaration of the lexer.

  Lastly, you left David Ponce as the author of these files.  Was that
intended? :)

Thanks
Eric

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net

Hi,

That's a mistake. I renamed files removing -tags from the name
(following existing wisent). I guess we should rename inside the code
too.

Étienne.

>>> =?ISO-8859-1?Q?=C9tienne?= BERSAC <bersace03@...> seems to think that:
>Hi,
>
>That's a mistake. I renamed files removing -tags from the name
>(following existing wisent). I guess we should rename inside the code
>too.
  [ ... ]

I eventually figured out the pattern of the error and got everything
to compile clean.  Thanks.

Could you please specify how you want the header-comment attribute to
list you, as opposed to David Ponce.

Thanks
Eric

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net

Hi,

Please don't include me in comment header.

Regards,
Étienne.

>>> =?ISO-8859-1?Q?=C9tienne?= BERSAC <bersace03@...> seems to think that:
>Hi,
>Please don't include me in comment header.
  [ ... ]

Ok.

Eric

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net

Greetings all.

  I checked in the PHP files.  It seemed like there was a lot of
interest, so checked them in without much testing as I do not yet have
the php-mode.el.  They do compile for me though, so things should
still compile smoothly.

Eric

-- 
          Eric Ludlam:                       eric@...
   Siege: http://www.siege-engine.com          Emacs: http://cedet.sourceforge.net