gPhoto

Bugs item #1956106, was opened at 2008-05-02 12:01
Message generated for change (Comment added) made by marcusmeissner
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108874&aid=1956106&group_id=8874

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: libgphoto2_port
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Thomas Klausner (thomasklausner)
>Assigned to: Marcus Meissner (marcusmeissner)
Summary: Portability problem re XOPEN_SOURCE

Initial Comment:
libgphoto2-2.4.1 installs the header gphoto2-port-portability.h, which includes:
/* XOPEN needed for usleep */
#ifndef _XOPEN_SOURCE
# define _XOPEN_SOURCE 500
#else
# if ((_XOPEN_SOURCE - 0) < 500)
#  undef _XOPEN_SOURCE
#  define _XOPEN_SOURCE 500
# endif
#endif

This header is included when an application includes gphoto2.h. Since the define may affect system headers, it shouldn't be set in a header file itself.

In this particular case, this define breaks digikam compilation on NetBSD-4.99.62/amd64, since it causes a mismatch between C and C++ headers.

----------------------------------------------------------------------

>Comment By: Marcus Meissner (marcusmeissner)
Date: 2008-07-13 20:13

Message:
Logged In: YES 
user_id=48092
Originator: NO

i have committed a patch that enables this only during libgphoto2 build
itself.

thanks for the report!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108874&aid=1956106&group_id=8874