Audacity

| From "David Bailes" <drbailes@...> 
| Fri, 4 Jan 2008 14:41:02 +0000
| Subject: [Audacity-devel] Focus problem after effect preview
> In the aim to section of the checklist there's:
> Fix all effects so that ALT + V always applies a Preview without
> having to change the effect settings first (EQ is one of the few
> effects where ALT + V works with the parameters that load). After
> Preview completes, ensure focus returns to the effect window rather
> than drifting to the Project window.
> 
> Could the focus bug be made priority aim to? Although you can get back
> to the dialog by pressing alt + F6, it's a confusing bug for users of
> screen readers who are not aware of the problem. I seem to remember
> that Leland fixed this problem a while back, but it seems to have
> gotten unfixed.

The focus part of the bug is a regression on 1.2.6 which gives it some
merit for "promotion" to priority aim-to, but if we were to go through
the aim-to's I expect we'd find quite a few others which were also 
regressions. It is a minor irritation even for sighted users if you use 
effects a lot, and affects all effects as far as I know. I'd agree with
priority aim-to unless some one disagreed, but it does not mean it 
would be done for 1.4.  Perhaps if Leland has got time coming on 
stream soon he can look at it for us?

The "preview" part of the problem is worse in 1.2. 6 (I cannot find any
effects there where ALT + V works at all), so maybe that should be
called a separate problem. 


Gale

Preview seems to work in all the effects I've tried (which isn't all 
of them).

The focus going away issue I've noted before and could easily (I 
think) be fixed by about 20 insertions in the effects thus:

    m_pEffect->Preview();
    this->SetFocus();      <- new bit

which I am willing to make, but is it the best solution?  I rather 
wanted to find a way of putting the SetFocus() into Effect::Preview() 
but failed to find a way.  Like:
    theThingThatCalledMe->SetFocus();

Any ideas about how to do this or shall I just implement the easy 
solution above?

Martyn

Gale Andrews wrote:
> | From "David Bailes" <drbailes@...> 
> | Fri, 4 Jan 2008 14:41:02 +0000
> | Subject: [Audacity-devel] Focus problem after effect preview
>> In the aim to section of the checklist there's:
>> Fix all effects so that ALT + V always applies a Preview without
>> having to change the effect settings first (EQ is one of the few
>> effects where ALT + V works with the parameters that load). After
>> Preview completes, ensure focus returns to the effect window rather
>> than drifting to the Project window.
>>
>> Could the focus bug be made priority aim to? Although you can get back
>> to the dialog by pressing alt + F6, it's a confusing bug for users of
>> screen readers who are not aware of the problem. I seem to remember
>> that Leland fixed this problem a while back, but it seems to have
>> gotten unfixed.
> 
> The focus part of the bug is a regression on 1.2.6 which gives it some
> merit for "promotion" to priority aim-to, but if we were to go through
> the aim-to's I expect we'd find quite a few others which were also 
> regressions. It is a minor irritation even for sighted users if you use 
> effects a lot, and affects all effects as far as I know. I'd agree with
> priority aim-to unless some one disagreed, but it does not mean it 
> would be done for 1.4.  Perhaps if Leland has got time coming on 
> stream soon he can look at it for us?
> 
> The "preview" part of the problem is worse in 1.2. 6 (I cannot find any
> effects there where ALT + V works at all), so maybe that should be
> called a separate problem. 
> 
> 
> Gale 
> 
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Audacity-devel mailing list
> Audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

On Mon, 2008-01-07 at 01:20 +0000, Martyn Shaw wrote:
> Preview seems to work in all the effects I've tried (which isn't all 
> of them).
> 
> The focus going away issue I've noted before and could easily (I 
> think) be fixed by about 20 insertions in the effects thus:
> 
>     m_pEffect->Preview();
>     this->SetFocus();      <- new bit
> 
> which I am willing to make, but is it the best solution?  I rather 
> wanted to find a way of putting the SetFocus() into Effect::Preview() 
> but failed to find a way.  Like:
>     theThingThatCalledMe->SetFocus();
> 
> Any ideas about how to do this or shall I just implement the easy 
> solution above?

Sorry for leaving this hanging. I think you need to make
Effect::Preview() virtual (if it isn't already), and then you can do
this->SetFocus(); in it. I haven't read the code or tried it, but it
ought to work, because the virtual method is called from the derived
object, so will be called with the 'this' pointer pointing to the
derived object.

Richard

Martyn

re the "Priority Aim to": 

*  For all effects except Equalization, focus is lost to the main
project window after preview, which is an issue for keyboard users 
(regression on 1.2.6)

You've said a couple of times and marked on the Release Checklist 
that: 

 m_pEffect->Preview();
   this->SetFocus();      <- new bit

in all the effects would fix this, but a fix in Effect::Preview() would be better, 
if somebody can figure out how to do it (I've tried and failed).

Unless someone can give a better solution, I'd just do what you have in 
mind for now, as this will only take a few minutes and gets rid of another
"priority aim to". 


Gale

OK, I committed the simple fix to all the effects that I could find 
that use Preview().  Can you test and clear the 'aim to' please?

Do we just delete items off the Wiki or mark them as 'done' somewhere 
else?

Thanks
Martyn

Gale Andrews wrote:
> Martyn
> 
> re the "Priority Aim to": 
> 
> *  For all effects except Equalization, focus is lost to the main
> project window after preview, which is an issue for keyboard users 
> (regression on 1.2.6)
> 
> You've said a couple of times and marked on the Release Checklist 
> that: 
> 
>  m_pEffect->Preview();
>    this->SetFocus();      <- new bit
> 
> in all the effects would fix this, but a fix in Effect::Preview() would be better, 
> if somebody can figure out how to do it (I've tried and failed).
> 
> Unless someone can give a better solution, I'd just do what you have in 
> mind for now, as this will only take a few minutes and gets rid of another
> "priority aim to". 
> 
> 
> Gale 
>  
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Audacity-devel mailing list
> Audacity-devel@...
> https://lists.sourceforge.net/lists/listinfo/audacity-devel
>

| From Martyn Shaw <martynshaw99@...> 
| Sun, 27 Jan 2008 20:59:53 +0000
| Subject: [Audacity-devel] Focus problem after effect preview
|  > OK, I committed the simple fix to all the effects that I could find 
> that use Preview().  Can you test and clear the 'aim to' please?

Done and Wiki updated - all effects now return focus after Preview, 
thanks. Leveller needs a Preview though doesn't it? Shall we make 
that a mere aim-to? 

> Do we just delete items off the Wiki or mark them as 'done' somewhere 
> else?

Items on Release Checklist that have been cleared can be cut and then
pasted to the same section (e.g. Priority Aim-to) of the "Release
Checklist Done page":
http://audacityteam.org/wiki/index.php?title=Release_Checklist_Done

If the cleared item is listed in "Known Issues", it should also be moved
down to the "Cleared in CVS" section of that page, but since I try to look 
after the related "Changes since 1.3.4" page it's easy enough for me to do 
both those things together (also done). 

Thanks.


Gale

Gale Andrews wrote:
...
>> Do we just delete items off the Wiki or mark them as 'done' somewhere 
>> else?
> 
> Items on Release Checklist that have been cleared can be cut and then
> pasted to the same section (e.g. Priority Aim-to) of the "Release
> Checklist Done page":
> http://audacityteam.org/wiki/index.php?title=Release_Checklist_Done
> 
> If the cleared item is listed in "Known Issues", it should also be moved
> down to the "Cleared in CVS" section of that page, but since I try to look 
> after the related "Changes since 1.3.4" page it's easy enough for me to do 
> both those things together (also done). 

Apologies for not reading the instructions!

Martyn