SourceForge.net: qooxdoo:

Home / Browse / qooxdoo / Mail / Archive

Email Archive: qooxdoo-devel (read-only)

Re: [qooxdoo-devel] Changing the font of a table

From: Dietrich Streifert <dietrich.streifert@vi...> - 2007-06-18 15:49

Hi Sebastian,

Sebastian Werner schrieb:
> Hi Dietrich,
>
> thank you for your patch. Some comments:
>
> It may be better to add a new method to Font.js to support a 
> generateStyle() method
>
> In _renderFont you then could use something like this.__fontStyle = 
> value ? value.generateStyle() : "";
>
> Then you can add the generates style to the htmlArr.push in the other 
> methods.
>
>   
Done.

I additionally created renderStyle and resetStyle method which applies 
the font attributes to a map. This avoids the hook with

  this._fontStyleRef = {};
  this._fontStyleRef.style = {};
  this._fontStyle = this._fontStyleRef.style;

  font.renderElement(this._fontSyleRef);

So I can now use:

  this._fontStyle = {};

  font.renderStyle(this._fontStyle);

> And please be sure to also support all the font features e.g. bold, 
> italic, underlined etc.
>
>   
They were not supported before but are now supported.

> Sebastian
>
>
>   

-- 
Mit freundlichen Grüßen
Dietrich Streifert
--
Visionet GmbH
Firmensitz: Am Weichselgarten 7, 91058 Erlangen
Registergericht: Handelsregister Fürth, HRB 6573
Geschäftsführer: Stefan Lindner

Thread View

Thread	Author	Date
[qooxdoo-devel] Changing the font of a table	dperez <craquerpro@ya...>

Re: [qooxdoo-devel] Changing the font of a table

From: Dietrich Streifert <dietrich.streifert@vi...> - 2007-06-15 11:27

The font type and size is controlled by the 
qx.ui.table.rowrenderer.Default in the properties:

    /** The font family used for the data row */
    fontFamily :
    {
      check : "String",
      init : "'Segoe UI', Corbel, Calibri, Tahoma, 'Lucida Sans 
Unicode', sans-serif"
    },

    /** The font size used for the data row */
    fontSize :
    {
      check : "String",
      init : "11px"
    }

Note that this are NOT qooxdoo font objects because the string values of 
the properties are used to generate the row html code via concatenation.

One possibility would be mark this properties to be themeable and to 
create a theme for them.

To set the font you can  the row renderer instance and modify the

    var drr = myTableInstance.getDataRowRenderer();
    drr.setFontFamily("my fancy font");
    drr.setFontSize("10px");

But I vote for the appearance solution with themeable properties 
fontFamily and fontSize.

dperez schrieb:
> Hi,
>
> I've discovered that for the Ext theme, the font of the textfield of a
> ComboBoxEx and the font of the list isn't the same.
>
> Does anyone know if there is an API for changing the font of a table?
> Tables are a little different than other widgets, HTML is generated
> directly.
>
> Cheers,
> David
>   

-- 
Mit freundlichen Grüßen
Dietrich Streifert
--
Visionet GmbH
Firmensitz: Am Weichselgarten 7, 91058 Erlangen
Registergericht: Handelsregister Fürth, HRB 6573
Geschäftsführer: Stefan Lindner

Re: [qooxdoo-devel] Changing the font of a table

From: Sebastian Werner <info@se...> - 2007-06-15 11:29

Ooops,

we should really modify this. The font handling of qooxdoo should be 
easily combinable with raw HTML nodes. Seems like a old piece of code 
which should be refactored. Can someone please open a bug for this. We 
should enhance this API to make the usage of the typical qooxdoo font 
handling possible here, too. Thanks.

Sebastian


Dietrich Streifert schrieb:
> The font type and size is controlled by the 
> qx.ui.table.rowrenderer.Default in the properties:
> 
>     /** The font family used for the data row */
>     fontFamily :
>     {
>       check : "String",
>       init : "'Segoe UI', Corbel, Calibri, Tahoma, 'Lucida Sans 
> Unicode', sans-serif"
>     },
> 
>     /** The font size used for the data row */
>     fontSize :
>     {
>       check : "String",
>       init : "11px"
>     }
> 
> Note that this are NOT qooxdoo font objects because the string values of 
> the properties are used to generate the row html code via concatenation.
> 
> One possibility would be mark this properties to be themeable and to 
> create a theme for them.
> 
> To set the font you can  the row renderer instance and modify the
> 
>     var drr = myTableInstance.getDataRowRenderer();
>     drr.setFontFamily("my fancy font");
>     drr.setFontSize("10px");
> 
> But I vote for the appearance solution with themeable properties 
> fontFamily and fontSize.
> 
> dperez schrieb:
>> Hi,
>>
>> I've discovered that for the Ext theme, the font of the textfield of a
>> ComboBoxEx and the font of the list isn't the same.
>>
>> Does anyone know if there is an API for changing the font of a table?
>> Tables are a little different than other widgets, HTML is generated
>> directly.
>>
>> Cheers,
>> David
>>   
>

Re: [qooxdoo-devel] Changing the font of a table

From: Dietrich Streifert <dietrich.streifert@vi...> - 2007-06-15 11:44

Attachments: Message as HTML

Done as bug #493

http://bugzilla.qooxdoo.org/show_bug.cgi?id=493

Sebastian Werner schrieb:
> Ooops,
>
> we should really modify this. The font handling of qooxdoo should be 
> easily combinable with raw HTML nodes. Seems like a old piece of code 
> which should be refactored. Can someone please open a bug for this. We 
> should enhance this API to make the usage of the typical qooxdoo font 
> handling possible here, too. Thanks.
>
> Sebastian
>
>
> Dietrich Streifert schrieb:
>   
>> The font type and size is controlled by the 
>> qx.ui.table.rowrenderer.Default in the properties:
>>
>>     /** The font family used for the data row */
>>     fontFamily :
>>     {
>>       check : "String",
>>       init : "'Segoe UI', Corbel, Calibri, Tahoma, 'Lucida Sans 
>> Unicode', sans-serif"
>>     },
>>
>>     /** The font size used for the data row */
>>     fontSize :
>>     {
>>       check : "String",
>>       init : "11px"
>>     }
>>
>> Note that this are NOT qooxdoo font objects because the string values of 
>> the properties are used to generate the row html code via concatenation.
>>
>> One possibility would be mark this properties to be themeable and to 
>> create a theme for them.
>>
>> To set the font you can  the row renderer instance and modify the
>>
>>     var drr = myTableInstance.getDataRowRenderer();
>>     drr.setFontFamily("my fancy font");
>>     drr.setFontSize("10px");
>>
>> But I vote for the appearance solution with themeable properties 
>> fontFamily and fontSize.
>>
>> dperez schrieb:
>>     
>>> Hi,
>>>
>>> I've discovered that for the Ext theme, the font of the textfield of a
>>> ComboBoxEx and the font of the list isn't the same.
>>>
>>> Does anyone know if there is an API for changing the font of a table?
>>> Tables are a little different than other widgets, HTML is generated
>>> directly.
>>>
>>> Cheers,
>>> David
>>>   
>>>       
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> qooxdoo-devel mailing list
> qooxdoo-devel@...
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>   

-- 
Mit freundlichen Grüßen
Dietrich Streifert
--
Visionet GmbH
Firmensitz: Am Weichselgarten 7, 91058 Erlangen
Registergericht: Handelsregister Fürth, HRB 6573
Geschäftsführer: Stefan Lindner

Re: [qooxdoo-devel] Changing the font of a table

From: Dietrich Streifert <dietrich.streifert@vi...> - 2007-06-18 13:06

Hi David,

I've created a patch against trunk which allows the styling of the table 
font through appearance or through font setting of the default row renderer.

If you want to try this take a look at attachment

    http://bugzilla.qooxdoo.org/attachment.cgi?id=192

of bug

    http://bugzilla.qooxdoo.org/show_bug.cgi?id=493

Sebastian: any time to review my patch? Is this the right way?


dperez schrieb:
> Hi,
>
> I've discovered that for the Ext theme, the font of the textfield of a
> ComboBoxEx and the font of the list isn't the same.
>
> Does anyone know if there is an API for changing the font of a table?
> Tables are a little different than other widgets, HTML is generated
> directly.
>
> Cheers,
> David
>   

-- 
Mit freundlichen Grüßen
Dietrich Streifert
--
Visionet GmbH
Firmensitz: Am Weichselgarten 7, 91058 Erlangen
Registergericht: Handelsregister Fürth, HRB 6573
Geschäftsführer: Stefan Lindner

Re: [qooxdoo-devel] Changing the font of a table

From: Sebastian Werner <info@se...> - 2007-06-18 14:25

Hi Dietrich,

thank you for your patch. Some comments:

It may be better to add a new method to Font.js to support a 
generateStyle() method

In _renderFont you then could use something like this.__fontStyle = 
value ? value.generateStyle() : "";

Then you can add the generates style to the htmlArr.push in the other 
methods.

And please be sure to also support all the font features e.g. bold, 
italic, underlined etc.

Sebastian



Dietrich Streifert schrieb:
> Hi David,
> 
> I've created a patch against trunk which allows the styling of the table 
> font through appearance or through font setting of the default row renderer.
> 
> If you want to try this take a look at attachment
> 
>     http://bugzilla.qooxdoo.org/attachment.cgi?id=192
> 
> of bug
> 
>     http://bugzilla.qooxdoo.org/show_bug.cgi?id=493
> 
> Sebastian: any time to review my patch? Is this the right way?
> 
> 
> dperez schrieb:
>> Hi,
>>
>> I've discovered that for the Ext theme, the font of the textfield of a
>> ComboBoxEx and the font of the list isn't the same.
>>
>> Does anyone know if there is an API for changing the font of a table?
>> Tables are a little different than other widgets, HTML is generated
>> directly.
>>
>> Cheers,
>> David
>>   
>

Re: [qooxdoo-devel] Changing the font of a table

From: Dietrich Streifert <dietrich.streifert@vi...> - 2007-06-18 15:49

Hi Sebastian,

Sebastian Werner schrieb:
> Hi Dietrich,
>
> thank you for your patch. Some comments:
>
> It may be better to add a new method to Font.js to support a 
> generateStyle() method
>
> In _renderFont you then could use something like this.__fontStyle = 
> value ? value.generateStyle() : "";
>
> Then you can add the generates style to the htmlArr.push in the other 
> methods.
>
>   
Done.

I additionally created renderStyle and resetStyle method which applies 
the font attributes to a map. This avoids the hook with

  this._fontStyleRef = {};
  this._fontStyleRef.style = {};
  this._fontStyle = this._fontStyleRef.style;

  font.renderElement(this._fontSyleRef);

So I can now use:

  this._fontStyle = {};

  font.renderStyle(this._fontStyle);

> And please be sure to also support all the font features e.g. bold, 
> italic, underlined etc.
>
>   
They were not supported before but are now supported.

> Sebastian
>
>
>   

-- 
Mit freundlichen Grüßen
Dietrich Streifert
--
Visionet GmbH
Firmensitz: Am Weichselgarten 7, 91058 Erlangen
Registergericht: Handelsregister Fürth, HRB 6573
Geschäftsführer: Stefan Lindner