Webware for Python

jose@... wrote:
 > I'm on windows and I like to turn autoreload on when I'm
 > developing (I leave it off during production) so i would from the
 > command line run
 >  Appserver.bat --AppServer.AutoReload=1

I haven't looked into it yet but I'm pretty sure it's  because the new 
Launch.py script uses getopt() to read the options which stops when 
option-like arguments are passed after a normal argument, and thus does 
not pass this argument to the AppServer. It passes only non-option-like 
arguments.

Since the AppServer uses non-option-like arguments otherwise ("stop", 
"start", "workdir=...") I thought this was no problem, but I forgot to 
allow for the parameters allowing to modify the configuration.

There are two ways to fix this:

1) Change Launch.py to also pass option-like arguments to the app server
(this should be possible using gnu_getopt() instead of getopt())

2) Change ThreadedAppServer.py to use non-option like parameters for 
configuration changes, i.e.

Appserver.bat AppServer.AutoReload=1

instead of

Appserver.bat --AppServer.AutoReload=1

I prefer 2) since it would be also more consistent with Appserver 
expecting "workdir=..." instead of "--workdir=...".

But I would like to hear some opinions which is better before fixing it.

-- Christoph

On 10/4/05, Christoph Zwerschke <cito@...> wrote:
> jose@... wrote:
>  > I'm on windows and I like to turn autoreload on when I'm
>  > developing (I leave it off during production) so i would from the
>  > command line run
>  >  Appserver.bat --AppServer.AutoReload=3D1
>
> I haven't looked into it yet but I'm pretty sure it's  because the new
> Launch.py script uses getopt() to read the options which stops when
> option-like arguments are passed after a normal argument, and thus does
> not pass this argument to the AppServer. It passes only non-option-like
> arguments.
>
> Since the AppServer uses non-option-like arguments otherwise ("stop",
> "start", "workdir=3D...") I thought this was no problem, but I forgot to
> allow for the parameters allowing to modify the configuration.
>
> There are two ways to fix this:
>
> 1) Change Launch.py to also pass option-like arguments to the app server
> (this should be possible using gnu_getopt() instead of getopt())
>
> 2) Change ThreadedAppServer.py to use non-option like parameters for
> configuration changes, i.e.
>
> Appserver.bat AppServer.AutoReload=3D1
>
> instead of
>
> Appserver.bat --AppServer.AutoReload=3D1
>
> I prefer 2) since it would be also more consistent with Appserver
> expecting "workdir=3D..." instead of "--workdir=3D...".
>
> But I would like to hear some opinions which is better before fixing it.
>
> -- Christoph

In supporting this form:

Appserver.bat AppServer.AutoReload=3D1

it should be easy to strip '--' off the name in the event that the
user passed this:

Appserver.bat --AppServer.AutoReload=3D1

... if name.startswith('--'): name =3D name[2:] ...

and then we'll be compatible with prior versions of Webware.

-Chuck

> In supporting this form:
> Appserver.bat AppServer.AutoReload=1
> it should be easy to strip '--' off the name in the event that the
> user passed this:
> Appserver.bat --AppServer.AutoReload=1
> and then we'll be compatible with prior versions of Webware.

Just saw this feature was already mentioned in the WekKit doco (thought 
not in the release notes; should be added there as well) so you're right 
we probably better stay compatible.  I will change ThreadedAppServer to 
use non-option-like parameters but let Launch.py handle the case if they 
are passed as options by stripping the '--' and putting them at the end 
of the command line.

-- Christoph

jose@... wrote:
> ... so i would from the command line run
>  Appserver.bat --AppServer.AutoReload=1

Hm, are you sure that ever worked?

Because I just noticed Windows/DOS splits the parameters given to 
AppServer.bat like this:

%1 = --AppServer.AutoReload
%2 = 1

Then, AppServer.bat will pass as two arguments without equals sign to 
Launch.py, instead of one argument with equals sign. As a result,
Launch.py resp. ThreadedAppServer.py will be unable to parse the option.

So, under Windows, it would have only worked like that:

Appserver.bat "--AppServer.AutoReload=1"

Can you affirm this or do I have a particularly strange Windows version 
(XP SP2)? I'm thinking about improving the Launch script to cope with 
missing equals signs, because this is really a pitfall under Windows. 
Anything speaking against this?

-- Christoph

> ... just noticed Windows/DOS splits the parameters given to 
> AppServer.bat like this:
> 
> %1 = --AppServer.AutoReload
> %2 = 1

I think I already have a solution for this problem.
Instead of calling Launch.py like this:

Launch.py ThreadedAppServer %1 %2 %3 %4 %5 %6 %7 %8 %9

you can write

Launch.py ThreadedAppServer %*

which leaves equals signs intact.

The only problem is that "%*" does not work with 98/ME, but we can live 
with that. Or even check whether "%*" is supported with something like

if "%*"=="*" ...

-- Christoph

yes you have to pass the param as "--AppServer.AutoReload=1"
Jose

Christoph Zwerschke wrote:

> jose@... wrote:
>
>> ... so i would from the command line run
>>  Appserver.bat --AppServer.AutoReload=1
>
>
> Hm, are you sure that ever worked?
>
> Because I just noticed Windows/DOS splits the parameters given to 
> AppServer.bat like this:
>
> %1 = --AppServer.AutoReload
> %2 = 1
>
> Then, AppServer.bat will pass as two arguments without equals sign to 
> Launch.py, instead of one argument with equals sign. As a result,
> Launch.py resp. ThreadedAppServer.py will be unable to parse the option.
>
> So, under Windows, it would have only worked like that:
>
> Appserver.bat "--AppServer.AutoReload=1"
>
> Can you affirm this or do I have a particularly strange Windows 
> version (XP SP2)? I'm thinking about improving the Launch script to 
> cope with missing equals signs, because this is really a pitfall under 
> Windows. Anything speaking against this?
>
> -- Christoph
>
>
>

I'm not using 98 any longer so I really don't care if we stop supporting 
98.  Now having said that I wonder how many of us Windoz suffers are 
still using webware on 98 rather then XP or one of the 200X server 
platforms.  For windows rather then using a bat file to start the 
appserver how about using an executable?  I wonder if that would change 
the handling of the arguments?  I've not looked into how setuptools 
creates its exe files, but from what I understand that exe simply looks 
for your python executable and uses that.  Jut thinking out loud.  I 
might play with that a bit.
Jose

Christoph Zwerschke wrote:

>> ... just noticed Windows/DOS splits the parameters given to 
>> AppServer.bat like this:
>>
>> %1 = --AppServer.AutoReload
>> %2 = 1
>
>
> I think I already have a solution for this problem.
> Instead of calling Launch.py like this:
>
> Launch.py ThreadedAppServer %1 %2 %3 %4 %5 %6 %7 %8 %9
>
> you can write
>
> Launch.py ThreadedAppServer %*
>
> which leaves equals signs intact.
>
> The only problem is that "%*" does not work with 98/ME, but we can 
> live with that. Or even check whether "%*" is supported with something 
> like
>
> if "%*"=="*" ...
>
> -- Christoph
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by:
> Power Architecture Resource Center: Free content, downloads, discussions,
> and more. http://solutions.newsforge.com/ibmarch.tmpl
> _______________________________________________
> Webware-discuss mailing list
> Webware-discuss@...
> https://lists.sourceforge.net/lists/listinfo/webware-discuss
>
>
>

On 10/7/05, Jose Galvez <jose@...> wrote:
> I'm not using 98 any longer so I really don't care if we stop supporting
> 98.  Now having said that I wonder how many of us Windoz suffers are
> still using webware on 98 rather then XP or one of the 200X server
> platforms.  For windows rather then using a bat file to start the
> appserver how about using an executable?  I wonder if that would change
> the handling of the arguments?  I've not looked into how setuptools
> creates its exe files, but from what I understand that exe simply looks
> for your python executable and uses that.  Jut thinking out loud.  I
> might play with that a bit.
> Jose

I haven't used 98 or ME in years and I think that user group must be
shrinking on a daily basis. I'm comfortable requiring Windows 2000 or
higher.

-Chuck

> you can write
> Launch.py ThreadedAppServer %*
> which leaves equals signs intact.

Just checked it out, works nice, the equals sign is left intact.
*BUT*: The AppServer.bat script uses the "shift" command to remove the 
Python options from the arguments. And under Windows (unlike Unix) 
"shift" has no effect on %*, it has only effect on the positional 
parameters %1, %2,... (that's why we call it "Windoof" in Germany).

-- Christoph

Jose Galvez wrote:
> For windows rather then using a bat file to start the 
> appserver how about using an executable?

I would not like to resort to making AppServer.bat a binary file just 
because of that small problem. Actually, you don't even need the 
AppServer.bat file in a productive environmen;, you can either start 
Launch.py directly or use AppServerService.py. You only need it during 
development for the AutoReload mechanism.

Anyway, I just have improved the AppServer.bat and Launch.py scripts. 
You can now do

AppServer.bat AppServer.AutoReload=1

or

AppServer.bat "AppServer.AutoReload=1"

both will work. You can also do

AppServer.bat -u -O AppServer.AutoReload=1

and the -u and -O options will be passed to the Python interpreter, not 
to the Launch script.

The script uses features of the cmd.exe shell, but falls back to 
ordinary dos shell if these are not available.

Let me know whether this works for you as well.

-- Christoph

Dear Chris,

Thanks for fixing this, I just tried the bat file and it works great!  
And your right in a production environment you really don't need the 
appserver.bat file, I only use it when I'm going to do some active 
development, where I really want to see the console (it great to send 
print statements to) and to temporarily turn autoreload on.  just as an 
aside I generally add three more bat files to my app folder:

stopService.bat
AppServerService.py stop

start-restartService.bat
AppServerService.py restart

runAppserver.bat
AppServerService.py stop
AppServer.bat AppServer.AutoReload=1


I know the three are pretty simple and totally not needed, but their 
just really nice shortcuts to keep things simple for me.

Again thanks for fixing the argument problem.
Jose




Christoph Zwerschke wrote:

> Jose Galvez wrote:
>
>> For windows rather then using a bat file to start the appserver how 
>> about using an executable?
>
>
> I would not like to resort to making AppServer.bat a binary file just 
> because of that small problem. Actually, you don't even need the 
> AppServer.bat file in a productive environmen;, you can either start 
> Launch.py directly or use AppServerService.py. You only need it during 
> development for the AutoReload mechanism.
>
> Anyway, I just have improved the AppServer.bat and Launch.py scripts. 
> You can now do
>
> AppServer.bat AppServer.AutoReload=1
>
> or
>
> AppServer.bat "AppServer.AutoReload=1"
>
> both will work. You can also do
>
> AppServer.bat -u -O AppServer.AutoReload=1
>
> and the -u and -O options will be passed to the Python interpreter, 
> not to the Launch script.
>
> The script uses features of the cmd.exe shell, but falls back to 
> ordinary dos shell if these are not available.
>
> Let me know whether this works for you as well.
>
> -- Christoph
>
>
>